Re: [edk2-devel] [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add initial package

[Chaganty, Rangasai V]

Reviewed-by: Sai Chaganty 

-Original Message-
From: Kubacki, Michael A 
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add 
initial package

Adds a new feature package for the IPMI feature.

This change updates the advanced feature package template for IPMI and adds the 
updated template to the IpmiFeaturePkg.

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec | 29 
+++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc | 24 
++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf |  8 
++  Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf  |  
8 ++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md  | 89 

 5 files changed, 158 insertions(+)

diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
new file mode 100644
index 00..dfae88
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d
+++ ec
@@ -0,0 +1,29 @@
+## @file
+# This package provides advanced feature functionality to enable the # 
+Intelligent Platform Management Interface (IPMI).
+# This package should only depend on EDK II Core packages, IntelSiliconPkg, 
and MinPlatformPkg.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+  DEC_SPECIFICATION = 0x00010017
+  PACKAGE_NAME  = IpmiFeaturePkg
+  PACKAGE_GUID  = AE091910-F6C9-4AB5-B8B4-995E2F0D5166
+  PACKAGE_VERSION   = 0.1
+
+[Includes]
+  Include
+
+[Guids]
+  gIpmiFeaturePkgTokenSpaceGuid  =  {0xc05283f6, 0xd6a8, 0x48f3, {0x9b, 
+0x59, 0xfb, 0xca, 0x71, 0x32, 0x0f, 0x12}}
+
+[PcdsFeatureFlag]
+
+gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable|FALSE|BOOLEAN|0xA000
+0001
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc
new file mode 100644
index 00..1952ba185e
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d
+++ sc
@@ -0,0 +1,24 @@
+## @file
+# This package provides advanced feature functionality to enable the # 
+Intelligent Platform Management Interface (IPMI).
+# This package should only depend on EDK II Core packages, IntelSiliconPkg, 
and MinPlatformPkg.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+  PLATFORM_NAME  = IpmiFeaturePkg
+  PLATFORM_GUID  = 7B2E74D7-9538-4818-B51A-492F3D33BD20
+  PLATFORM_VERSION   = 0.1
+  DSC_SPECIFICATION  = 0x00010005
+  OUTPUT_DIRECTORY   = Build/$(PLATFORM_NAME)
+  SUPPORTED_ARCHITECTURES= IA32|X64
+  BUILD_TARGETS  = DEBUG|RELEASE|NOOPT
+  SKUID_IDENTIFIER   = DEFAULT
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf
new file mode 100644
index 00..c3847c54c7
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemo
+++ ry.fdf
@@ -0,0 +1,8 @@
+## @file
+#  FDF file for post-memory modules that enable Intelligent Platform 
Management Interface.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf
new file mode 100644
index 00..0c82d7eb02
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemor
+++ y.fdf
@@ -0,0 +1,8 @@
+## @file
+#  FDF file for pre-memory modules that enable Intelligent Platform Management 
Interface.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md
new file mode 100644
index 00..e70f1e850b
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md
@@ -0,0 +1,89 @@
+# Overview
+* **Feature Name:** Intelligent Platform Management Interface (IPMI)
+* **PI Phase(s) 

Re: [edk2-devel] [PATCH] BaseTools:Enhance the way to handling included dsc file

[Bob Feng]

Reviewed-by: Bob Feng 

-Original Message-
From: Fan, ZhijuX 
Sent: Tuesday, December 3, 2019 5:04 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C 
Subject: [PATCH] BaseTools:Enhance the way to handling included dsc file

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2400

In Dsc Parser, included dsc file is parsed always no matter if its condition is 
False

  gUefiOvmfPkgTokenSpaceGuid.test1|FALSE
!if gUefiOvmfPkgTokenSpaceGuid.test1 == FALSE
  !include OvmfPkg/test1.dsc
!else
  !include OvmfPkg/test2.dsc
!endif

In the above case, since the conditional result is FALSE, "test2.dsc" is not 
parsed.
The patch avoids processing redundant dsc files and improves the way Tool 
handles them.

Cc: Liming Gao 
Cc: Bob Feng 
Signed-off-by: Zhiju.Fan 
---
 .../Source/Python/Workspace/MetaFileParser.py  | 79 +++---
 1 file changed, 40 insertions(+), 39 deletions(-)

diff --git a/BaseTools/Source/Python/Workspace/MetaFileParser.py 
b/BaseTools/Source/Python/Workspace/MetaFileParser.py
index 8a665b118e..a3b6edbd15 100644
--- a/BaseTools/Source/Python/Workspace/MetaFileParser.py
+++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py
@@ -1612,46 +1612,47 @@ class DscParser(MetaFileParser):
 # First search the include file under the same directory as DSC 
file
 #
 IncludedFile1 = PathClass(IncludedFile, self.MetaFile.Dir)
-ErrorCode, ErrorInfo1 = IncludedFile1.Validate()
-if ErrorCode != 0:
-#
-# Also search file under the WORKSPACE directory
-#
-IncludedFile1 = PathClass(IncludedFile, GlobalData.gWorkspace)
-ErrorCode, ErrorInfo2 = IncludedFile1.Validate()
+if self._Enabled:
+ErrorCode, ErrorInfo1 = IncludedFile1.Validate()
 if ErrorCode != 0:
-EdkLogger.error('parser', ErrorCode, 
File=self._FileWithError,
-Line=self._LineIndex + 1, 
ExtraData=ErrorInfo1 + "\n" + ErrorInfo2)
-
-self._FileWithError = IncludedFile1
-
-FromItem = self._Content[self._ContentIndex - 1][0]
-if self._InSubsection:
-Owner = self._Content[self._ContentIndex - 1][8]
-else:
-Owner = self._Content[self._ContentIndex - 1][0]
-IncludedFileTable = MetaFileStorage(self._RawTable.DB, 
IncludedFile1, MODEL_FILE_DSC, False, FromItem=FromItem)
-Parser = DscParser(IncludedFile1, self._FileType, self._Arch, 
IncludedFileTable,
-   Owner=Owner, From=FromItem)
-
-self.IncludedFiles.add (IncludedFile1)
-
-# set the parser status with current status
-Parser._SectionName = self._SectionName
-Parser._SubsectionType = self._SubsectionType
-Parser._InSubsection = self._InSubsection
-Parser._SectionType = self._SectionType
-Parser._Scope = self._Scope
-Parser._Enabled = self._Enabled
-# Parse the included file
-Parser.StartParse()
-# Insert all records in the table for the included file into dsc 
file table
-Records = IncludedFileTable.GetAll()
-if Records:
-self._Content[self._ContentIndex:self._ContentIndex] = Records
-self._Content.pop(self._ContentIndex - 1)
-self._ValueList = None
-self._ContentIndex -= 1
+#
+# Also search file under the WORKSPACE directory
+#
+IncludedFile1 = PathClass(IncludedFile, 
GlobalData.gWorkspace)
+ErrorCode, ErrorInfo2 = IncludedFile1.Validate()
+if ErrorCode != 0:
+EdkLogger.error('parser', ErrorCode, 
File=self._FileWithError,
+Line=self._LineIndex + 1, 
+ ExtraData=ErrorInfo1 + "\n" + ErrorInfo2)
+
+self._FileWithError = IncludedFile1
+
+FromItem = self._Content[self._ContentIndex - 1][0]
+if self._InSubsection:
+Owner = self._Content[self._ContentIndex - 1][8]
+else:
+Owner = self._Content[self._ContentIndex - 1][0]
+IncludedFileTable = MetaFileStorage(self._RawTable.DB, 
IncludedFile1, MODEL_FILE_DSC, False, FromItem=FromItem)
+Parser = DscParser(IncludedFile1, self._FileType, self._Arch, 
IncludedFileTable,
+   Owner=Owner, From=FromItem)
+
+self.IncludedFiles.add (IncludedFile1)
+
+# set the parser status with current status
+Parser._SectionName = self._SectionName
+Parser._SubsectionType = self._SubsectionType
+Parser._InSubsection = self._InSubsection
+

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time.

[Dong, Eric]

Hi Philippe,

> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Thursday, November 28, 2019 9:16 PM
> To: devel@edk2.groups.io; Dong, Eric 
> Cc: Ni, Ray ; Laszlo Ersek 
> Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid
> allocate Token every time.
> 
> Hi Eric,
> 
> On 11/28/19 7:17 AM, Dong, Eric via Groups.Io wrote:
> > v2 changes:
> >Minor update based on comments.
> >
> > v1 changes:
> 
> Nitpick, previous comments should not go into the commit description,
> either on a cover letter, or after the '---' marker so they get stripped out 
> by
> git-am.
[[Eric]] got it, will use this format in my next version change. Thanks.

> 
> Another nitpick, remove the trailing dot in commit subject.
[[Eric]] Update in my next version change.

> 
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
> >
> > Current logic allocate Token every time when need to use it. The logic
> > caused SMI latency raised to very high. Update logic to allocate Token
> > buffer at driver's entry point. Later use the token from the allocated
> > token buffer. Only when all the buffer have been used, then need to
> > allocate new buffer.
> >
> > Signed-off-by: Eric Dong 
> > Cc: Ray Ni 
> > Cc: Laszlo Ersek 
> > ---
> >   UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c  | 56
> --
> >   UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 16 +++
> >   2 files changed, 68 insertions(+), 4 deletions(-)
> >
> > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> > index d8d2b6f444..4632e5b0c2 100644
> > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> > @@ -492,6 +492,23 @@ FreeTokens (
> >   {
> > LIST_ENTRY*Link;
> > PROCEDURE_TOKEN   *ProcToken;
> > +  TOKEN_BUFFER  *TokenBuf;
> > +
> > +  //
> > +  // Not free the buffer, just clear the UsedTokenNum. In order to
> > + // avoid later trig allcate action again when need to use token.
> 
> Maybe: "In order to avoid triggering allocate action when we need to use the
> token, do not free the buffer."
[[Eric]] Update it in my next version change.

Thanks,
Eric
> 
> Patch looks good otherwise.
> 
> > +  //
> > +  gSmmCpuPrivate->UsedTokenNum = 0;
> > +
> > +  Link = GetFirstNode (>OldTokenBufList);
> > +  while (!IsNull (>OldTokenBufList, Link)) {
> > +TokenBuf = TOKEN_BUFFER_FROM_LINK (Link);
> > +
> > +Link = RemoveEntryList (>Link);
> > +
> > +FreePool (TokenBuf->Buffer);
> > +FreePool (TokenBuf);
> > +  }
> >
> > while (!IsListEmpty (>TokenList)) {
> >   Link = GetFirstNode (>TokenList); @@ -499,7
> > +516,6 @@ FreeTokens (
> >
> >   RemoveEntryList (>Link);
> >
> > -FreePool ((VOID *)ProcToken->ProcedureToken);
> >   FreePool (ProcToken);
> > }
> >   }
> > @@ -1115,13 +1131,35 @@ CreateToken (
> > VOID
> > )
> >   {
> > -  PROCEDURE_TOKEN*ProcToken;
> > +  PROCEDURE_TOKEN *ProcToken;
> > SPIN_LOCK   *CpuToken;
> > UINTN   SpinLockSize;
> > +  TOKEN_BUFFER*TokenBuf;
> >
> > SpinLockSize = GetSpinLockProperties ();
> > -  CpuToken = AllocatePool (SpinLockSize);
> > -  ASSERT (CpuToken != NULL);
> > +
> > +  if (gSmmCpuPrivate->UsedTokenNum ==
> MAX_PRE_RESERVE_TOKEN_COUNT) {
> > +DEBUG((DEBUG_INFO, "CpuSmm: No free token buffer, allocate new
> > + buffer!\n"));
> > +
> > +//
> > +// Record current token buffer for later free action usage.
> > +// Current used token buffer not in this list.
> > +//
> > +TokenBuf = AllocatePool (sizeof (TOKEN_BUFFER));
> > +ASSERT (TokenBuf != NULL);
> > +TokenBuf->Signature = TOKEN_BUFFER_SIGNATURE;
> > +TokenBuf->Buffer  = gSmmCpuPrivate->CurrentTokenBuf;
> > +
> > +InsertTailList (>OldTokenBufList,
> > + >Link);
> > +
> > +gSmmCpuPrivate->CurrentTokenBuf   = AllocateZeroPool (SpinLockSize
> * MAX_PRE_RESERVE_TOKEN_COUNT);
> > +ASSERT (gSmmCpuPrivate->CurrentTokenBuf != NULL);
> > +gSmmCpuPrivate->UsedTokenNum = 0;  }
> > +
> > +  CpuToken = (SPIN_LOCK *)(gSmmCpuPrivate->CurrentTokenBuf +
> > + SpinLockSize * gSmmCpuPrivate->UsedTokenNum);
> > + gSmmCpuPrivate->UsedTokenNum++;
> > +
> > InitializeSpinLock (CpuToken);
> > AcquireSpinLock (CpuToken);
> >
> > @@ -1737,10 +1775,20 @@ InitializeDataForMmMp (
> > VOID
> > )
> >   {
> > +  UINTN  SpinLockSize;
> > +
> > +  SpinLockSize = GetSpinLockProperties ();  DEBUG((DEBUG_INFO,
> > + "CpuSmm: SpinLock Size = 0x%x\n", SpinLockSize));
> > +
> > +  gSmmCpuPrivate->CurrentTokenBuf = AllocateZeroPool (SpinLockSize *
> > + MAX_PRE_RESERVE_TOKEN_COUNT);  ASSERT
> > + (gSmmCpuPrivate->CurrentTokenBuf != NULL);
> > + gSmmCpuPrivate->UsedTokenNum = 0;
> > +
> > gSmmCpuPrivate->ApWrapperFunc = AllocatePool (sizeof
> (PROCEDURE_WRAPPER) * gSmmCpuPrivate-
> >SmmCoreEntryContext.NumberOfCpus);
> > ASSERT 

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time.

[Dong, Eric]

Hi Laszlo,

> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, November 29, 2019 3:39 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Liming 
> Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid
> allocate Token every time.
> 
> On 11/29/19 04:02, Dong, Eric wrote:
> > Hi Laszlo,
> >
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Laszlo Ersek
> > Sent: Thursday, November 28, 2019 9:57 PM
> > To: Dong, Eric ; devel@edk2.groups.io
> > Cc: Ni, Ray ; Gao, Liming 
> > Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm:
> Avoid allocate Token every time.
> 
> >>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c  | 56
> --
> >>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 16 +++
> >>  2 files changed, 68 insertions(+), 4 deletions(-)
> >
> > commenting on the header file changes first:
> > [Eric] what's this sentence means? Follow above comments to update the
> comment message?
> 
> Your patch email included the C source file changes first, and the header file
> changes second. I find that more difficult to reason about than the opposite
> order (header first, C source second).
> 
> Therefore, I split your email in two parts, and moved the H file changes to 
> the
> top. And, I commented on those H file changes first.
> 
> >> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> >> b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> >> index d8d2b6f444..4632e5b0c2 100644
> >> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> >> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> >> @@ -492,6 +492,23 @@ FreeTokens (
> >>  {
> >>LIST_ENTRY*Link;
> >>PROCEDURE_TOKEN   *ProcToken;
> >> +  TOKEN_BUFFER  *TokenBuf;
> >> +
> >> +  //
> >> +  // Not free the buffer, just clear the UsedTokenNum. In order to
> >> + // avoid later trig allcate action again when need to use token.
> >> +  //
> >> +  gSmmCpuPrivate->UsedTokenNum = 0;
> >
> > (6) Here we do not zero out the current token buffer, but in
> > CreateToken() and InitializeDataForMmMp(), we use AllocateZeroPool().
> >
> > This is an inconsistency, we should call either ZeroMem() here (if
> > zeroing matters), or AllocatePool() in the other two places (if
> > zeroing does not matter).
> > [Eric] Not catch your meaning here? Why can't use  "=0" here?
> 
> In both CreateToken() and InitializeDataForMmMp(), we perform *three*
> actions:
> (a) ensure CurrentTokenBuf is allocated,
> (b) clear CurrentTokenBuf,
> (c) set UsedTokenNum to zero.
> 
> In FreeTokens(), we perform *two* actions:
> (a) ensure CurrentTokenBuf is allocated (it needs no explicit action, but it 
> is
> an invariant nonetheless),
> (c) set UsedTokenNum to zero.
> 
> Step (b) is missing from FreeTokens(). That's inconsistent with
> CreateToken() and InitializeDataForMmMp().
> 
> The question is whether the following predicate is important or not:
> 
> - "all unused tokens in the current token buffer must be all-bits-zero"
> 
> If this predicate is important, then you should add step (b) to
> FreeTokens():
> 
>   ZeroMem (
> gSmmCpuPrivate->CurrentTokenBuf,
> SpinLockSize * MAX_PRE_RESERVE_TOKEN_COUNT
> );
> 
> If the predicate is not important, then you should replace the
> AllocateZeroPool() calls with AllocatePool(), in CreateToken() and
> InitializeDataForMmMp().
> 
> It is not consistent to clear CurrentTokenBuf in only *some* cases when
> UsedTokenNum is set to zero.

[[Eric]] In CreateToken function, I add code InitializeSpinLock() to initialize
the Token space first, so "Clear CurrentTokenBuf" action is not must have item.
I will remove the "Zero Memory" action in my next version changes.

> 
> >> @@ -1115,13 +1131,35 @@ CreateToken (
> >>VOID
> >>)
> >>  {
> >> -  PROCEDURE_TOKEN*ProcToken;
> >> +  PROCEDURE_TOKEN *ProcToken;
> >>SPIN_LOCK   *CpuToken;
> >>UINTN   SpinLockSize;
> >> +  TOKEN_BUFFER*TokenBuf;
> >>
> >>SpinLockSize = GetSpinLockProperties ();
> >> -  CpuToken = AllocatePool (SpinLockSize);
> >> -  ASSERT (CpuToken != NULL);
> >> +
> >> +  if (gSmmCpuPrivate->UsedTokenNum ==
> MAX_PRE_RESERVE_TOKEN_COUNT) {
> >> +DEBUG((DEBUG_INFO, "CpuSmm: No free token buffer, allocate new
> >> + buffer!\n"));
> >
> > (7) This is an expected case, and not too much a corner case at that.
> > Furthermore, the DEBUG message is in a performance-sensitive path.
> > [Eric] this code is called by the caller.  I don't think it's
> > performance sensitive. What's your rule for "performance-sensitive
> > path" ? I add this debug message because I want to know how often the
> > pre allocate buffer is not enough.  We can enlarge the buffer size to get
> better performance.
> 
> The patch is about making CreateToken() faster. It's done by allocating
> SMRAM less frequently (not on every call to CreateToken()). In some cases
> however, CreateToken() will still allocate SMRAM, and that's going 

Re: [edk2-devel] Public-Service-Announcement: send-email issues with Git 2.22.0+

[Liming Gao]

Nate:
  Thanks for your sharing. I apply this command in my development machine. 

Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Nate DeSimone
>Sent: Wednesday, December 04, 2019 12:31 PM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] Public-Service-Announcement: send-email issues with
>Git 2.22.0+
>Importance: High
>
>Hi Everyone,
>
>I have been dealing with a very frustrating issue recently where all of my "CR
>LF" line endings get erroneously converted into "LF LF" once I send my patch
>to the mailing list. I have discovered the root cause for this problem. The 
>issue
>is the following commit to git itself:
>
>https://github.com/git/git/commit/5983ddc165221c3ec2a4299b65cfb2ecc1ce7
>765
>
>This change is present in git version 2.20.0 or later, per the release notes:
>
>https://github.com/git/git/blob/v2.22.0/Documentation/RelNotes/2.22.0.txt
>
>With this change, if you leave sendemail.transferEncoding set to the default
>value of "auto", then git will inspect the body of your email. If it finds a 
>'\r'
>character in the message, then it converts the entire message content into
>Quoted-Printable encoding. It appears that when groups.io converts the QP
>encoding back to text format, the '\r' characters somehow become '\n'. To
>workaround this make sure to set the following configuration option:
>
>git config --global sendemail.transferEncoding 8bit
>
>This will prevent send-email from converting the message into QP encoding,
>allowing the patches to pass through to the mailing list unharmed. Hope that
>saves other people a few hours of frustration.
>
>Regards,
>Nate
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51716): https://edk2.groups.io/g/devel/message/51716
Mute This Topic: https://groups.io/mt/66206907/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Public-Service-Announcement: send-email issues with Git 2.22.0+

[Nate DeSimone]

Hi Everyone,

I have been dealing with a very frustrating issue recently where all of my "CR 
LF" line endings get erroneously converted into "LF LF" once I send my patch to 
the mailing list. I have discovered the root cause for this problem. The issue 
is the following commit to git itself:

https://github.com/git/git/commit/5983ddc165221c3ec2a4299b65cfb2ecc1ce7765

This change is present in git version 2.20.0 or later, per the release notes:

https://github.com/git/git/blob/v2.22.0/Documentation/RelNotes/2.22.0.txt

With this change, if you leave sendemail.transferEncoding set to the default 
value of "auto", then git will inspect the body of your email. If it finds a 
'\r' character in the message, then it converts the entire message content into 
Quoted-Printable encoding. It appears that when groups.io converts the QP 
encoding back to text format, the '\r' characters somehow become '\n'. To 
workaround this make sure to set the following configuration option:

git config --global sendemail.transferEncoding 8bit

This will prevent send-email from converting the message into QP encoding, 
allowing the patches to pass through to the mailing list unharmed. Hope that 
saves other people a few hours of frustration.

Regards,
Nate

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51715): https://edk2.groups.io/g/devel/message/51715
Mute This Topic: https://groups.io/mt/66206907/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos

[Cœur]

Le 04/12/2019 à 00:56, Anthony PERARD a écrit :

There's seems to be missing SoB from Antoine. Could that be added?


Hi, no need to worry about my attribution: it's really just spellchecking.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51714): https://edk2.groups.io/g/devel/message/51714
Mute This Topic: https://groups.io/mt/65782892/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

[Zeng, Star]

Reviewed-by: Star Zeng 

-Original Message-
From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] 
Sent: Wednesday, December 4, 2019 12:15 AM
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Chiu, Chasel ; 
Desimone, Nathaniel L ; Zeng, Star 
; Philippe Mathieu-Daude 
Subject: [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Star Zeng 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h 
  | 2 +-
 IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
  | 4 ++--
 IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c  
  | 2 +-
 
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
| 4 ++--
 
IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
 | 4 ++--
 IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm  
  | 6 +++---
 
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
 | 2 +-
 IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm  
  | 2 +-
 8 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h 
b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
index e39054c30d3b..11a3faaad87a 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
@@ -40,7 +40,7 @@ CallFspNotifyPhase (
 /**
   Call FSP API - FspMemoryInit.
 
-  @param[in]  FspmUpdDataPtr  Pointer to the FSPM_UPD data sructure.
+  @param[in]  FspmUpdDataPtr  Pointer to the FSPM_UPD data structure.
   @param[out] HobListPtr  Pointer to receive the address of the 
HOB list.
 
   @return EFI status returned by FspMemoryInit API.
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h 
b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
index b90f0eb78302..2aa14c92fd63 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
@@ -12,7 +12,7 @@
 /**
   This function overrides the default configurations in the FSP-M UPD data 
region.
 
-  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data strcture.
+  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data 
structure.
 
 **/
 VOID
@@ -24,7 +24,7 @@ UpdateFspmUpdData (
 /**
   This function overrides the default configurations in the FSP-S UPD data 
region.
 
-  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data strcture.
+  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data 
structure.
 
 **/
 VOID
diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c 
b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 0f8cd69a0e6e..b20f0805a021 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
   EFI_BOOT_MODEBootMode;
 
   //
-  // Register MemoryDiscovered Nofity to run FspSiliconInit
+  // Register MemoryDiscovered Notify to run FspSiliconInit
   //
   Status = PeiServicesNotifyPpi ();
   ASSERT_EFI_ERROR (Status);
diff --git 
a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
 
b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
index def04b176659..dddf80b76c26 100644
--- 
a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
+++ 
b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
@@ -14,7 +14,7 @@
 
   @note At this point, memory is NOT ready, PeiServices are available to use.
 
-  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data strcture.
+  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data 
structure.
 
 **/
 VOID
@@ -28,7 +28,7 @@ UpdateFspmUpdData (
 /**
   This function overrides the default configurations in the FSP-S UPD data 
region.
 
-  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data strcture.
+  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data 
structure.
 
 **/
 VOID
diff --git 
a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
 
b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
index 54cebe127c8f..48f4b0295a30 100644
--- 
a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
+++ 

Re: [edk2-devel] [Patch 0/4 V4] Enhance Incremental Build

[Bob Feng]

1. No. If user does not update build_rule and tools_def, build will not failed. 
No impact for clean build. Since there will no COMMON_DEPS variable generated 
in Makefile, if user change a header file which is in original COMMON_DEPS, 
build tool will not rebuild the corresponding module for incremental build. 
2. Yes. for GCC and Clang, the deps file are under the same folder as .obj file 
localed. But for MSVC, they are in the module_build_folder, I can update this 
in new patch set.
3. If the compile failed, there will no deps file generated.

Thanks,
Bob

-Original Message-
From: Gao, Liming 
Sent: Tuesday, December 3, 2019 10:33 PM
To: devel@edk2.groups.io; Feng, Bob C 
Subject: RE: [edk2-devel] [Patch 0/4 V4] Enhance Incremental Build

Bob:
  Thanks for your update. I verify this enhancement. It is great. Now, I have 
some minor comments. Can you help check them?

1. This change requires tools_def and build_rule be updated together. If they 
are not updated, what will happen? Can build tool report the error and let user 
update them?
2. C compiler will generate the include file list for all other files except 
for ASL and Nasm,, and output the include file into the screen. Build tool 
catches them, and creates the file xxx.deps. Can Build tool generate xxx.deps 
in the same output directory with the output file? For example, if C source 
output file is generated into OUTPUT\X64 directory, its deps file is also 
generated into OUTPUT\X64 directory. 
3. Do you verify the error case? For example, if C source file doesn't pass 
compile, its deps will still be generated or not?

Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Bob 
> Feng
> Sent: Tuesday, December 3, 2019 4:53 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch 0/4 V4] Enhance Incremental Build
> 
> V4: Add $(DEPS_FLAGS) for rule [C-Code-File.BASE.AARCH64 ...]
> V3: Change CLANG9 to CLANGPDB according to commit 14672c34bd
> V2: Fixed a bug in patch 4/4.
> 
> Incremental build reduces the build time by only building the module 
> that need to update. Edk2 Build system is a Makefile based build 
> system. The incrememtal build ability is provided by the Make program. 
> But Edk2 build tool need to generate correct makefile to have Make 
> program do incremental build correctly.
> 
> The current solution in build tool to support incremental build is 
> that build tool find out the include file list for each source file of 
> a module, and in module's makefile, build tool add the include file list as 
> the source file's dependency.
> In this way Make program can decide if it need to rebuild a source 
> code by checking its dependency. This solution has 2 shortcommings, 
> one is the process of finding include list is slow, the other is this 
> method can't handle case that a MACRO in #include statement so the related 
> source file is always built.
> 
> This patch provides another method to support incremental build. That 
> is to use c preprocessor and trim tool to generate dependency files for the 
> source file.
> This method will save much time in AutoGen phase and handle MACRO in #include 
> correctly.
> 
> For C files:
> 1. MSVS.
> cl.exe has a build option /showIncludes to display include files on 
> stdout. Build tool captures
> that messages and generate dependency files, .deps files.
> 2. CLANG and GCC
> -MMD -MF build option are used to generate dependency files by 
> preprocessor. Build tool updates the
>.deps files.
> 
> For ASL files:
> 1. Trim find out all the included files, which are asl specific include 
> format, and generate .trim.deps file.
> 2. ASL PP use c preprocessor to find out all included files with #include 
> format and generate a .deps file
> 3. build tool updates the .deps file
> 
> For ASM files (.asm, .s or .nasm):
> 1. Trim find out all the included files, which are asm specific include 
> format, and generate .trim.deps file.
> 2. ASM PP use c preprocessor to find out all included files with #include 
> format and generate a deps file
> 3. build tool updates the .deps file
> 
> Build tool add "include" instruction for those deps files in the Makefile.
> 
> This patch does not support RVCT tool chain for the BZ 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1750
> 
> Feng, Bob C (4):
>   BaseTools: Add build option for dependency file generation
>   BaseTools: Generate dependent files for ASL and ASM files
>   BaseTools: Update build_rule.txt to generate dependent files.
>   BaseTools: Enhance Basetool for incremental build
> 
>  BaseTools/Conf/build_rule.template|  94 ---
>  BaseTools/Conf/tools_def.template | 173 ++--
>  BaseTools/Source/Python/AutoGen/GenMake.py|  83 ++
>  .../Source/Python/AutoGen/IncludesAutoGen.py  | 255 ++
>  .../Source/Python/AutoGen/ModuleAutoGen.py|  23 ++
>  BaseTools/Source/Python/Trim/Trim.py   

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Improve output formatting in maintain_submodules()

[Desimone, Ashley E]

Signed-off-by: Ashley E Desimone 
Cc: Nate DeSimone 
Cc: Puja Pandya 
---
 edkrepo/common/common_repo_functions.py | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/edkrepo/common/common_repo_functions.py 
b/edkrepo/common/common_repo_functions.py
index c8713dd..d857d09 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -201,26 +201,26 @@ def write_conditional_include(workspace_path, 
repo_sources, included_configs):
 def maintain_submodules(repo_sources, repo, verbose = False):
 try:
 output_data = repo.git.execute(['git', 'submodule', 'init'], 
with_extended_output=True, with_stdout=True)
-if verbose:
+if verbose and output_data[0]:
 print(output_data[0])
-print(output_data[1])
-if verbose:
+if output_data[1]:
+print(output_data[1])
+if verbose and output_data[2]:
 print(output_data[2])
-print()
 output_data = repo.git.execute(['git', 'submodule', 'sync', 
'--recursive'], with_extended_output=True, with_stdout=True)
-if verbose:
+if verbose and output_data[0]:
 print(output_data[0])
-print(output_data[1])
-if verbose:
+if output_data[1]:
+print(output_data[1])
+if verbose and output_data[2]:
 print(output_data[2])
-print()
 output_data = repo.git.execute(['git', 'submodule', 'update', 
'--recursive'], with_extended_output=True, with_stdout=True)
-if verbose:
+if verbose and output_data[0]:
 print(output_data[0])
-print(output_data[1])
-if verbose:
+if output_data[1]:
+print(output_data[1])
+if verbose and output_data[2]:
 print(output_data[2])
-print()
 except:
 raise 
EdkrepoGitException(SUBMODULE_FAILURE.format(repo_sources.remote_name))
 
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51711): https://edk2.groups.io/g/devel/message/51711
Mute This Topic: https://groups.io/mt/66188779/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve output formatting in maintain_submodules()

[Desimone, Ashley E]

Signed-off-by: Ashley E Desimone 
---
 edkrepo/common/common_repo_functions.py | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/edkrepo/common/common_repo_functions.py 
b/edkrepo/common/common_repo_functions.py
index c8713dd..d857d09 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -201,26 +201,26 @@ def write_conditional_include(workspace_path, 
repo_sources, included_configs):
 def maintain_submodules(repo_sources, repo, verbose = False):
 try:
 output_data = repo.git.execute(['git', 'submodule', 'init'], 
with_extended_output=True, with_stdout=True)
-if verbose:
+if verbose and output_data[0]:
 print(output_data[0])
-print(output_data[1])
-if verbose:
+if output_data[1]:
+print(output_data[1])
+if verbose and output_data[2]:
 print(output_data[2])
-print()
 output_data = repo.git.execute(['git', 'submodule', 'sync', 
'--recursive'], with_extended_output=True, with_stdout=True)
-if verbose:
+if verbose and output_data[0]:
 print(output_data[0])
-print(output_data[1])
-if verbose:
+if output_data[1]:
+print(output_data[1])
+if verbose and output_data[2]:
 print(output_data[2])
-print()
 output_data = repo.git.execute(['git', 'submodule', 'update', 
'--recursive'], with_extended_output=True, with_stdout=True)
-if verbose:
+if verbose and output_data[0]:
 print(output_data[0])
-print(output_data[1])
-if verbose:
+if output_data[1]:
+print(output_data[1])
+if verbose and output_data[2]:
 print(output_data[2])
-print()
 except:
 raise 
EdkrepoGitException(SUBMODULE_FAILURE.format(repo_sources.remote_name))
 
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51710): https://edk2.groups.io/g/devel/message/51710
Mute This Topic: https://groups.io/mt/66187162/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions

[Gao, Zhichao]

Series, Reviewed-by: Zhichao Gao 

Thanks,
Zhichao

> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Tuesday, December 3, 2019 1:41 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao ;
> Philippe Mathieu-Daude 
> Subject: [PATCH 0/2] ShellPkg: Document the use of
> EFI_INVALID_PARAMETER by two functions
> 
> Complete the list of values the functios ParseCommandLineToArgs() and
> UpdateArgcArgv() can return.
> 
> The documentation was found to be incomplete while reviewing BZ#2395:
> https://edk2.groups.io/g/devel/message/51512
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daude (2):
>   ShellPkg: Document ParseCommandLineToArgs returns
> EFI_INVALID_PARAMETER
>   ShellPkg: Document UpdateArgcArgv returns EFI_INVALID_PARAMETER
> 
>  ShellPkg/Application/Shell/ShellParametersProtocol.h | 2 ++
> ShellPkg/Application/Shell/ShellParametersProtocol.c | 2 ++
>  2 files changed, 4 insertions(+)
> 
> --
> 2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51709): https://edk2.groups.io/g/devel/message/51709
Mute This Topic: https://groups.io/mt/65089802/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V3] EdkRepo: Add list-repos command

[Nate DeSimone]

list-repos lists the git repos used by all projects
and which branches those projects use.

Cc: Ashley E Desimone 
Signed-off-by: Nate DeSimone 
---
 edkrepo/commands/arguments/list_repos_args.py |  16 ++
 edkrepo/commands/humble/__init__.py   |   8 +
 edkrepo/commands/humble/list_repos_humble.py  |  26 ++
 edkrepo/commands/list_repos_command.py| 248 ++
 setup.py  |   5 +-
 5 files changed, 300 insertions(+), 3 deletions(-)
 create mode 100644 edkrepo/commands/arguments/list_repos_args.py
 create mode 100644 edkrepo/commands/humble/__init__.py
 create mode 100644 edkrepo/commands/humble/list_repos_humble.py
 create mode 100644 edkrepo/commands/list_repos_command.py

diff --git a/edkrepo/commands/arguments/list_repos_args.py 
b/edkrepo/commands/arguments/list_repos_args.py
new file mode 100644
index 000..7133201
--- /dev/null
+++ b/edkrepo/commands/arguments/list_repos_args.py
@@ -0,0 +1,16 @@
+#!/usr/bin/env python3
+#
+## @file
+# list_repos_args.py
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+''' Contains the help and description strings for arguments in the
+list-repos command meta data.
+'''
+
+COMMAND_DESCRIPTION = 'Lists the git repos used by available projects and the 
branches that are used.'
+ARCHIVED_HELP = 'Include a listing of archived projects.'
+REPOS_HELP = 'Only show the given subset of repos instead of all repos. The 
name of a repo is determined by the name given by the most manifest files.'
diff --git a/edkrepo/commands/humble/__init__.py 
b/edkrepo/commands/humble/__init__.py
new file mode 100644
index 000..dea6eb4
--- /dev/null
+++ b/edkrepo/commands/humble/__init__.py
@@ -0,0 +1,8 @@
+#!/usr/bin/env python3
+#
+## @file
+# __init__.py
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
diff --git a/edkrepo/commands/humble/list_repos_humble.py 
b/edkrepo/commands/humble/list_repos_humble.py
new file mode 100644
index 000..9083d8e
--- /dev/null
+++ b/edkrepo/commands/humble/list_repos_humble.py
@@ -0,0 +1,26 @@
+#!/usr/bin/env python3
+#
+## @file
+# list_repos_humble.py
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+'''
+Contains user visible strings printed by the list-repos command.
+'''
+
+from colorama import Fore
+from colorama import Style
+
+BRANCHES = 'Branches:'
+BRANCH_FORMAT_STRING = '  {}{}{{}}{}'.format(Fore.BLUE, Style.BRIGHT, 
Style.RESET_ALL)
+COMBO_FORMAT_STRING = '{{}}  {}{}({{}}){}'.format(Fore.CYAN, Style.BRIGHT, 
Style.RESET_ALL)
+DEFAULT_COMBO_FORMAT_STRING = '{{}} {}{}*({{}})*{}'.format(Fore.GREEN, 
Style.BRIGHT, Style.RESET_ALL)
+MANIFEST_DIRECTORY = 'Manifest directory:'
+PROJECT_NAME_FORMAT_STRING = '{}{}{{}}{}:'.format(Fore.YELLOW, Style.BRIGHT, 
Style.RESET_ALL)
+REPOSITORIES = 'Repositories:'
+REPO_NAME_AND_URL = '{}{}{{}}{} - [{}{}{{}}{}]'.format(Fore.MAGENTA, 
Style.BRIGHT, Style.RESET_ALL, Fore.RED, Style.BRIGHT, Style.RESET_ALL)
+REPO_NAME_NOT_FOUND = 'repo_name not found'
+REPO_NOT_FOUND_IN_MANIFEST = 'Repo(s) {} not found in any manifest file'
diff --git a/edkrepo/commands/list_repos_command.py 
b/edkrepo/commands/list_repos_command.py
new file mode 100644
index 000..caf0373
--- /dev/null
+++ b/edkrepo/commands/list_repos_command.py
@@ -0,0 +1,248 @@
+#!/usr/bin/env python3
+#
+## @file
+# list_repos_command.py
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+import collections
+import os
+
+#from git import Repo
+from colorama import Fore, Style
+
+# Our modules
+from edkrepo.commands.edkrepo_command import EdkrepoCommand
+from edkrepo.commands.edkrepo_command import ColorArgument
+import edkrepo.commands.arguments.list_repos_args as arguments
+import edkrepo.commands.humble.list_repos_humble as humble
+from edkrepo.common.common_repo_functions import pull_latest_manifest_repo
+from edkrepo.common.edkrepo_exception import 
EdkrepoInvalidParametersException, EdkrepoManifestInvalidException
+from edkrepo.common.ui_functions import init_color_console
+from edkrepo_manifest_parser.edk_manifest import CiIndexXml, ManifestXml
+
+class ListReposCommand(EdkrepoCommand):
+def __init__(self):
+super().__init__()
+self.repo_names = None
+
+def get_metadata(self):
+metadata = {}
+metadata['name'] = 'list-repos'
+metadata['help-text'] = arguments.COMMAND_DESCRIPTION
+args = []
+metadata['arguments'] = args
+args.append({'name': 'repos',
+ 'positional': False,
+ 'required': False,
+ 'action': 'store',
+ 'nargs': '+',
+ 'help-text': arguments.REPOS_HELP})
+args.append({'name': 'archived',
+ 

Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

[Michael D Kinney]

Hi Chasel,

If you had authored the changes, then you could update those
copyright lines.

Since the author of the changes is Antoine Coeur ,
Antoine gets to make the choice to add a new copyright line or not.

Thanks,

Mike

> -Original Message-
> From: devel@edk2.groups.io  On
> Behalf Of Chiu, Chasel
> Sent: Tuesday, December 3, 2019 5:23 PM
> To: Philippe Mathieu-Daude ;
> devel@edk2.groups.io
> Cc: Antoine Coeur ; Desimone, Nathaniel L
> ; Zeng, Star
> 
> Subject: Re: [edk2-devel] [PATCH 10/79]
> IntelFsp2WrapperPkg: Fix various typos
> 
> 
> Philippe, thanks for helping on this.
> 
> Just minor feedbacks - many files having old copyright
> years that I replied below inline, please help to
> correct them.
> With copyright updated, Reviewed-by: Chasel Chiu
> 
> 
> 
> > -Original Message-
> > From: Philippe Mathieu-Daude 
> > Sent: Wednesday, December 4, 2019 12:15 AM
> > To: devel@edk2.groups.io
> > Cc: Antoine Coeur ; Chiu, Chasel
> ;
> > Desimone, Nathaniel L
> ; Zeng, Star
> > ; Philippe Mathieu-Daude
> 
> > Subject: [PATCH 10/79] IntelFsp2WrapperPkg: Fix
> various typos
> >
> > From: Antoine Coeur 
> >
> > Fix various typos in comments and documentation.
> >
> > Cc: Chasel Chiu 
> > Cc: Nate DeSimone 
> > Cc: Star Zeng 
> > Reviewed-by: Philippe Mathieu-Daude
> 
> > Signed-off-by: Philippe Mathieu-Daude
> 
> > ---
> >
> IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> > | 2 +-
> >
> IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformL
> ib.h
> > | 4 ++--
> >
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > | 2 +-
> >
> >
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSa
> mple/FspWrapp
> > erPlatformLibSample.c| 4 ++--
> >
> >
> IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibS
> ample/FspWrap
> > perHobProcessLibSample.c | 4 ++--
> >
> >
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Th
> unk64To32.nas
> > m| 6 +++---
> >
> >
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLib
> Sample/Ia32/Sec
> > Entry.nasm | 2 +-
> >
> >
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLib
> Sample/Ia32/Sta
> > ck.nasm| 2 +-
> >  8 files changed, 13 insertions(+), 13 deletions(-)
> >
> > diff --git
> a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.
> h
> >
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.
> h
> > index e39054c30d3b..11a3faaad87a 100644
> > ---
> a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.
> h
> > +++
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.
> h
> 
> 
> Copyright for this file should be "2014 - 2019"
> 
> 
> > @@ -40,7 +40,7 @@ CallFspNotifyPhase (
> >  /**
> >Call FSP API - FspMemoryInit.
> >
> > -  @param[in]  FspmUpdDataPtr  Pointer to the
> FSPM_UPD data
> > sructure.
> > +  @param[in]  FspmUpdDataPtr  Pointer to the
> FSPM_UPD data
> > structure.
> >@param[out] HobListPtr  Pointer to
> receive the address
> > of the HOB list.
> >
> >@return EFI status returned by FspMemoryInit API.
> > diff --git
> a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatfor
> mLib.h
> >
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatfor
> mLib.h
> > index b90f0eb78302..2aa14c92fd63 100644
> > ---
> a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatfor
> mLib.h
> > +++
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatfor
> mLib.h
> 
> 
> Copyright for this file should be "2014 - 2019"
> 
> 
> > @@ -12,7 +12,7 @@
> >  /**
> >This function overrides the default configurations
> in the FSP-M UPD data
> > region.
> >
> > -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD
> data region data
> > strcture.
> > +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD
> data region data
> > structure.
> >
> >  **/
> >  VOID
> > @@ -24,7 +24,7 @@ UpdateFspmUpdData (
> >  /**
> >This function overrides the default configurations
> in the FSP-S UPD data
> > region.
> >
> > -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD
> data region data
> > strcture.
> > +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD
> data region data
> > structure.
> >
> >  **/
> >  VOID
> > diff --git
> a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> >
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > index 0f8cd69a0e6e..b20f0805a021 100644
> > ---
> a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > +++
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > @@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
> >EFI_BOOT_MODEBootMode;
> >
> >//
> > -  // Register MemoryDiscovered Nofity to run
> FspSiliconInit
> > +  // Register MemoryDiscovered Notify to run
> FspSiliconInit
> >//
> >Status = PeiServicesNotifyPpi
> ();
> >ASSERT_EFI_ERROR (Status);
> > diff --git
> >
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLib
> Sample/FspWra
> > pperPlatformLibSample.c
> >
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLib
> Sample/FspWra
> > 

Re: [edk2-devel] [PATCH 25/79] MdePkg/IndustryStandard: Fix various typos

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Philippe Mathieu-Daude 
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Kinney, Michael D
> ; Gao, Liming
> ; Philippe Mathieu-Daude
> 
> Subject: [PATCH 25/79] MdePkg/IndustryStandard: Fix
> various typos
> 
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude
> 
> ---
>  MdePkg/Include/IndustryStandard/Acpi10.h  |  4
> +-
>  MdePkg/Include/IndustryStandard/Acpi20.h  |  4
> +-
>  MdePkg/Include/IndustryStandard/Acpi30.h  |  4
> +-
>  MdePkg/Include/IndustryStandard/Acpi40.h  |  2
> +-
>  MdePkg/Include/IndustryStandard/Acpi50.h  |  6
> +--
>  MdePkg/Include/IndustryStandard/Acpi51.h  |  4
> +-
>  MdePkg/Include/IndustryStandard/Acpi60.h  |  4
> +-
>  MdePkg/Include/IndustryStandard/Acpi61.h  |  4
> +-
>  MdePkg/Include/IndustryStandard/Acpi62.h  |  8
> ++--
>  MdePkg/Include/IndustryStandard/Atapi.h   | 40
> ++--
>  MdePkg/Include/IndustryStandard/ElTorito.h|  4
> +-
>  MdePkg/Include/IndustryStandard/Emmc.h|  2
> +-
>  MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h |  4
> +-
>  MdePkg/Include/IndustryStandard/Nvme.h| 10
> ++---
>  MdePkg/Include/IndustryStandard/Pci22.h   | 20
> +-
>  MdePkg/Include/IndustryStandard/PeImage.h |  2
> +-
>  MdePkg/Include/IndustryStandard/Scsi.h|  2
> +-
>  MdePkg/Include/IndustryStandard/SmBus.h   |  2
> +-
>  MdePkg/Include/IndustryStandard/Tpm12.h   |  2
> +-
>  19 files changed, 64 insertions(+), 64 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h
> b/MdePkg/Include/IndustryStandard/Acpi10.h
> index a38d2be61cc3..fa06eefbb6e6 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi10.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi10.h
> @@ -37,7 +37,7 @@ typedef struct {
>  #pragma pack()
> 
>  //
> -// Define for Desriptor
> +// Define for Descriptor
>  //
>  #define ACPI_SMALL_ITEM_FLAG   0x00
>  #define ACPI_LARGE_ITEM_FLAG   0x01
> @@ -109,7 +109,7 @@ typedef struct {
>  #pragma pack(1)
> 
>  ///
> -/// The commond definition of QWORD, DWORD, and WORD
> +/// The common definition of QWORD, DWORD, and WORD
>  /// Address Space Descriptors.
>  ///
>  typedef PACKED struct {
> diff --git a/MdePkg/Include/IndustryStandard/Acpi20.h
> b/MdePkg/Include/IndustryStandard/Acpi20.h
> index 8a0adbbb6a97..b63d494705a2 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi20.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi20.h
> @@ -11,7 +11,7 @@
>  #include 
> 
>  //
> -// Define for Desriptor
> +// Define for Descriptor
>  //
>  #define ACPI_LARGE_GENERIC_REGISTER_DESCRIPTOR_NAME
> 0x02
> 
> @@ -505,7 +505,7 @@ typedef struct {
>  #define
> EFI_ACPI_2_0_SYSTEM_LOCALITY_INFORMATION_TABLE_SIGNATUR
> E  SIGNATURE_32('S', 'L', 'I', 'T')
> 
>  ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
>  ///
>  #define
> EFI_ACPI_2_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE  SIGNATURE_32('S', 'P', 'C', 'R')
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h
> b/MdePkg/Include/IndustryStandard/Acpi30.h
> index 0fc947e745f4..6a7fc39c256e 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi30.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi30.h
> @@ -11,7 +11,7 @@
>  #include 
> 
>  //
> -// Define for Desriptor
> +// Define for Descriptor
>  //
>  #define
> ACPI_LARGE_EXTENDED_ADDRESS_SPACE_DESCRIPTOR_NAME
> 0x0B
> 
> @@ -684,7 +684,7 @@ typedef struct {
>  #define
> EFI_ACPI_3_0_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SP
> ACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE
> SIGNATURE_32('M', 'C', 'F', 'G')
> 
>  ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
>  ///
>  #define
> EFI_ACPI_3_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE  SIGNATURE_32('S', 'P', 'C', 'R')
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h
> b/MdePkg/Include/IndustryStandard/Acpi40.h
> index 53ec90c04243..c03ba7a6290b 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi40.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi40.h
> @@ -1264,7 +1264,7 @@ typedef struct {
>  #define
> EFI_ACPI_4_0_MANAGEMENT_CONTROLLER_HOST_INTERFACE_TABLE
> _SIGNATURE  SIGNATURE_32('M', 'C', 'H', 'I')
> 
>  ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
>  ///
>  #define
> EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE  SIGNATURE_32('S', 'P', 'C', 'R')
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h
> b/MdePkg/Include/IndustryStandard/Acpi50.h
> index 067ab68c3428..46dcdb950741 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi50.h

Re: [edk2-devel] [PATCH 30/79] MdePkg/Register: Fix various typos

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: devel@edk2.groups.io  On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Kinney, Michael D
> ; Gao, Liming
> ; Philippe Mathieu-Daude
> 
> Subject: [edk2-devel] [PATCH 30/79] MdePkg/Register:
> Fix various typos
> 
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude
> 
> ---
>  MdePkg/Include/Register/Amd/Cpuid.h
> | 8 
>  MdePkg/Include/Register/Amd/Fam17Msr.h
> | 2 +-
>  MdePkg/Include/Register/Amd/Msr.h
> | 2 +-
>  MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> | 2 +-
>  MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> | 2 +-
>  MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> | 2 +-
>  6 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/MdePkg/Include/Register/Amd/Cpuid.h
> b/MdePkg/Include/Register/Amd/Cpuid.h
> index ad1ba4d016e0..8e91e84b767f 100644
> --- a/MdePkg/Include/Register/Amd/Cpuid.h
> +++ b/MdePkg/Include/Register/Amd/Cpuid.h
> @@ -11,7 +11,7 @@
>SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>@par Specification Reference:
> -  AMD64 Architecture Programming Manaul volume 2,
> March 2017, Sections 15.34
> +  AMD64 Architecture Programming Manual volume 2,
> March 2017, Sections 15.34
> 
>  **/
> 
> @@ -364,7 +364,7 @@ typedef union {
>  ///
>  UINT32  Page1GB:1;
>  ///
> -/// [Bit 27] RDTSCP intructions.
> +/// [Bit 27] RDTSCP instructions.
>  ///
>  UINT32  RDTSCP:1;
>  ///
> @@ -513,9 +513,9 @@ typedef union {
> 
>@retval  EAX  Extended APIC ID described by the type
>  CPUID_AMD_PROCESSOR_TOPOLOGY_EAX.
> -  @retval  EBX  Core Indentifiers described by the
> type
> +  @retval  EBX  Core Identifiers described by the type
>  CPUID_AMD_PROCESSOR_TOPOLOGY_EBX.
> -  @retval  ECX  Node Indentifiers described by the
> type
> +  @retval  ECX  Node Identifiers described by the type
>  CPUID_AMD_PROCESSOR_TOPOLOGY_ECX.
>@retval  EDX  Reserved.
>  **/
> diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h
> b/MdePkg/Include/Register/Amd/Fam17Msr.h
> index 37b935dcdb30..6ef45a9b21d3 100644
> --- a/MdePkg/Include/Register/Amd/Fam17Msr.h
> +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h
> @@ -10,7 +10,7 @@
>SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>@par Specification Reference:
> -  AMD64 Architecture Programming Manaul volume 2,
> March 2017, Sections 15.34
> +  AMD64 Architecture Programming Manual volume 2,
> March 2017, Sections 15.34
> 
>  **/
> 
> diff --git a/MdePkg/Include/Register/Amd/Msr.h
> b/MdePkg/Include/Register/Amd/Msr.h
> index e74de7a1df48..084eb892cdd9 100644
> --- a/MdePkg/Include/Register/Amd/Msr.h
> +++ b/MdePkg/Include/Register/Amd/Msr.h
> @@ -10,7 +10,7 @@
>SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>@par Specification Reference:
> -  AMD64 Architecture Programming Manaul volume 2,
> March 2017, Sections 15.34
> +  AMD64 Architecture Programming Manual volume 2,
> March 2017, Sections 15.34
> 
>  **/
> 
> diff --git
> a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> index 2edc1363b7c4..c56d20df66a4 100644
> ---
> a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> +++
> b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> @@ -1,5 +1,5 @@
>  /** @file
> -  MSR Defintions for Intel Atom processors based on
> the Goldmont Plus microarchitecture.
> +  MSR Definitions for Intel Atom processors based on
> the Goldmont Plus microarchitecture.
> 
>Provides defines for Machine Specific Registers(MSR)
> indexes. Data structures
>are provided for MSRs that contain one or more bit
> fields.  If the MSR value
> diff --git
> a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> index 30f96f0e82fa..03cac77c19a6 100644
> --- a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> +++ b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> @@ -1,5 +1,5 @@
>  /** @file
> -  MSR Defintions for Intel processors based on the
> Skylake/Kabylake/Coffeelake/Cannonlake
> microarchitecture.
> +  MSR Definitions for Intel processors based on the
> Skylake/Kabylake/Coffeelake/Cannonlake
> microarchitecture.
> 
>Provides defines for Machine Specific Registers(MSR)
> indexes. Data structures
>are provided for MSRs that contain one or more bit
> fields.  If the MSR value
> diff --git
> a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> index da4c91d0f4b8..3e426701e83c 100644
> ---
> a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> +++
> b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> @@ -179,7 +179,7 @@ typedef struct {
>  } STM_RSC_ALL_RESOURCES_DESC;
> 
>  

Re: [edk2-devel] [PATCH 29/79] MdePkg/Ppi: Fix various typos

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: devel@edk2.groups.io  On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Kinney, Michael D
> ; Gao, Liming
> ; Philippe Mathieu-Daude
> 
> Subject: [edk2-devel] [PATCH 29/79] MdePkg/Ppi: Fix
> various typos
> 
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude
> 
> ---
>  MdePkg/Include/Ppi/BlockIo.h  | 4 ++--
>  MdePkg/Include/Ppi/BlockIo2.h | 2 +-
>  MdePkg/Include/Ppi/Capsule.h  | 2 +-
>  MdePkg/Include/Ppi/Decompress.h   | 2 +-
>  MdePkg/Include/Ppi/DeviceRecoveryModule.h | 2 +-
>  MdePkg/Include/Ppi/IsaHc.h| 2 +-
>  MdePkg/Include/Ppi/MpServices.h   | 2 +-
>  MdePkg/Include/Ppi/Pcd.h  | 4 ++--
>  MdePkg/Include/Ppi/RecoveryModule.h   | 2 +-
>  MdePkg/Include/Ppi/TemporaryRamDone.h | 2 +-
>  MdePkg/Include/Ppi/VectorHandoffInfo.h| 2 +-
>  11 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/MdePkg/Include/Ppi/BlockIo.h
> b/MdePkg/Include/Ppi/BlockIo.h
> index 524f026fe589..3a4955be6b59 100644
> --- a/MdePkg/Include/Ppi/BlockIo.h
> +++ b/MdePkg/Include/Ppi/BlockIo.h
> @@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-
> Clause-Patent
> 
>@par Revision Reference:
>This PPI is defined in UEFI Platform Initialization
> Specification 1.2 Volume 1:
> -  Pre-EFI Initalization Core Interface.
> +  Pre-EFI Initialization Core Interface.
> 
>  **/
> 
> @@ -58,7 +58,7 @@ typedef enum {
>  /// Specification inconsistency here:
>  /// PEI_BLOCK_IO_MEDIA has been changed to
> EFI_PEI_BLOCK_IO_MEDIA.
>  /// Inconsistency exists in UEFI Platform
> Initialization Specification 1.2
> -/// Volume 1: Pre-EFI Initalization Core Interface,
> where all referrences to
> +/// Volume 1: Pre-EFI Initialization Core Interface,
> where all references to
>  /// this structure name are with the "EFI_" prefix,
> except for the definition
>  /// which is without "EFI_".  So the name of
> PEI_BLOCK_IO_MEDIA is taken as the
>  /// exception, and EFI_PEI_BLOCK_IO_MEDIA is used to
> comply with most of
> diff --git a/MdePkg/Include/Ppi/BlockIo2.h
> b/MdePkg/Include/Ppi/BlockIo2.h
> index e1af6a4293ed..0dba6485d941 100644
> --- a/MdePkg/Include/Ppi/BlockIo2.h
> +++ b/MdePkg/Include/Ppi/BlockIo2.h
> @@ -7,7 +7,7 @@ SPDX-License-Identifier: BSD-2-Clause-
> Patent
> 
>@par Revision Reference:
>This PPI is defined in UEFI Platform Initialization
> Specification 1.4 Volume 1:
> -  Pre-EFI Initalization Core Interface.
> +  Pre-EFI Initialization Core Interface.
> 
>  **/
> 
> diff --git a/MdePkg/Include/Ppi/Capsule.h
> b/MdePkg/Include/Ppi/Capsule.h
> index cb7b0e2ae76a..331d9b81cad2 100644
> --- a/MdePkg/Include/Ppi/Capsule.h
> +++ b/MdePkg/Include/Ppi/Capsule.h
> @@ -45,7 +45,7 @@ typedef struct _EFI_PEI_CAPSULE_PPI
> PEI_CAPSULE_PPI;
>  On output, this variable
> will contain the size of the
>  coalesced capsule.
> 
> -  @retval EFI_NOT_FOUND  If: boot modecould
> not be determined, or the
> +  @retval EFI_NOT_FOUND  If: boot mode could
> not be determined, or the
>   boot mode is not
> flash-update, or the capsule descriptors were not
> found.
>@retval EFI_BUFFER_TOO_SMALL   The capsule could not
> be coalesced in the provided memory region.
>@retval EFI_SUCCESSThere was no capsule,
> or the capsule was processed successfully.
> diff --git a/MdePkg/Include/Ppi/Decompress.h
> b/MdePkg/Include/Ppi/Decompress.h
> index 7ba26e419c59..b9ca63746ab2 100644
> --- a/MdePkg/Include/Ppi/Decompress.h
> +++ b/MdePkg/Include/Ppi/Decompress.h
> @@ -1,5 +1,5 @@
>  /** @file
> -  Provides decompression services to the PEI
> Foundatoin.
> +  Provides decompression services to the PEI
> Foundation.
> 
>Copyright (c) 2006 - 2018, Intel Corporation. All
> rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/MdePkg/Include/Ppi/DeviceRecoveryModule.h
> b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
> index a4587255a3c8..64dabec1139c 100644
> --- a/MdePkg/Include/Ppi/DeviceRecoveryModule.h
> +++ b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
> @@ -15,7 +15,7 @@
> 
>@par Revision Reference:
>This PPI is defined in UEFI Platform Initialization
> Specification 1.2 Volume 1:
> -  Pre-EFI Initalization Core Interface
> +  Pre-EFI Initialization Core Interface
> 
>  **/
> 
> diff --git a/MdePkg/Include/Ppi/IsaHc.h
> b/MdePkg/Include/Ppi/IsaHc.h
> index 5468c2e94b72..d7dfd9b47e8c 100644
> --- a/MdePkg/Include/Ppi/IsaHc.h
> +++ b/MdePkg/Include/Ppi/IsaHc.h
> @@ -28,7 +28,7 @@ typedef struct _EFI_ISA_HC_PPI
> *PEFI_ISA_HC_PPI;
>that more than one caller may be assigned to the
> same aperture.
>  

Re: [edk2-devel] [PATCH 28/79] MdePkg/Library/Smm: Fix various typos

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Philippe Mathieu-Daude 
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Kinney, Michael D
> ; Gao, Liming
> ; Philippe Mathieu-Daude
> 
> Subject: [PATCH 28/79] MdePkg/Library/Smm: Fix various
> typos
> 
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude
> 
> ---
>  MdePkg/Include/Library/SmmLib.h
> |  4 +-
>  MdePkg/Include/Library/SmmMemLib.h
> |  4 +-
>  MdePkg/Include/Library/SmmPeriodicSmiLib.h
> |  6 +--
>  MdePkg/Library/SmmMemLib/SmmMemLib.c
> |  4 +-
>  MdePkg/Library/SmmPciExpressLib/PciExpressLib.c
> |  4 +-
>  MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c
> |  6 +--
>  MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
> | 42 ++--
> 
> MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.
> c |  2 +-
>  8 files changed, 36 insertions(+), 36 deletions(-)
> 
> diff --git a/MdePkg/Include/Library/SmmLib.h
> b/MdePkg/Include/Library/SmmLib.h
> index 8d83df7fd737..bcb7045c1b65 100644
> --- a/MdePkg/Include/Library/SmmLib.h
> +++ b/MdePkg/Include/Library/SmmLib.h
> @@ -45,7 +45,7 @@ TriggerRuntimeSoftwareSmi (
>it was triggered at boot time, it returns TRUE.
> Otherwise, it returns FALSE.
> 
>@retval TRUE   A software SMI triggered at boot time
> happened.
> -  @retval FLASE  No software SMI happened, or the
> software SMI was triggered at run time.
> +  @retval FALSE  No software SMI happened, or the
> software SMI was triggered at run time.
> 
>  **/
>  BOOLEAN
> @@ -62,7 +62,7 @@ IsBootServiceSoftwareSmi (
>it was triggered at run time, it returns TRUE.
> Otherwise, it returns FALSE.
> 
>@retval TRUE   A software SMI triggered at run time
> happened.
> -  @retval FLASE  No software SMI happened or the
> software SMI was triggered at boot time.
> +  @retval FALSE  No software SMI happened or the
> software SMI was triggered at boot time.
> 
>  **/
>  BOOLEAN
> diff --git a/MdePkg/Include/Library/SmmMemLib.h
> b/MdePkg/Include/Library/SmmMemLib.h
> index 72edc9adcde7..d92cbd9aabd2 100644
> --- a/MdePkg/Include/Library/SmmMemLib.h
> +++ b/MdePkg/Include/Library/SmmMemLib.h
> @@ -67,7 +67,7 @@ SmmCopyMemToSmram (
>@param  SourceBufferThe pointer to the
> source buffer of the memory copy.
>@param  Length  The number of bytes to
> copy from SourceBuffer to DestinationBuffer.
> 
> -  @retval EFI_SECURITY_VIOLATION The DesinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> +  @retval EFI_SECURITY_VIOLATION The DestinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
>@retval EFI_SUCCESSMemory is copied.
> 
>  **/
> @@ -92,7 +92,7 @@ SmmCopyMemFromSmram (
>@param  SourceBufferThe pointer to the
> source buffer of the memory copy.
>@param  Length  The number of bytes to
> copy from SourceBuffer to DestinationBuffer.
> 
> -  @retval EFI_SECURITY_VIOLATION The DesinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> +  @retval EFI_SECURITY_VIOLATION The DestinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
>@retval EFI_SECURITY_VIOLATION The SourceBuffer is
> invalid per processor architecture or overlap with
> SMRAM.
>@retval EFI_SUCCESSMemory is copied.
> 
> diff --git a/MdePkg/Include/Library/SmmPeriodicSmiLib.h
> b/MdePkg/Include/Library/SmmPeriodicSmiLib.h
> index 6215aa2232ac..a3e086d02501 100644
> --- a/MdePkg/Include/Library/SmmPeriodicSmiLib.h
> +++ b/MdePkg/Include/Library/SmmPeriodicSmiLib.h
> @@ -64,7 +64,7 @@ PeriodicSmiExit (
>This function yields control back to the SMM
> Foundation.  When the next
>periodic SMI for the currently executing handler is
> triggered, the periodic
>SMI handler will be resumed and this function will
> return.  Use of this
> -  function requires a seperate stack for the periodic
> SMI handler.  A non zero
> +  function requires a separate stack for the periodic
> SMI handler.  A non zero
>stack size must be specified in PeriodicSmiEnable()
> for this function to be
>used.
> 
> @@ -113,7 +113,7 @@ VOID
>@param[in] DispatchFunction  A pointer to a
> periodic SMI handler function.
>@param[in] Context   Optional content to
> pass into DispatchFunction.
>@param[in] TickPeriodThe requested tick
> period in 100ns units that
> -   control should be
> givien to the periodic SMI
> +   control should be
> given to the periodic SMI
> handler.  Must be
> one of the supported values
> returned by
> PeriodicSmiSupportedPickPeriod().
>@param[in] Cpu   Specifies the CPU
> that 

Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)

[Liming Gao]

You can also mention the fork branch with all changes. Then, the reviewer can 
see all changes. 

Thanks
Liming
>-Original Message-
>From: Desimone, Nathaniel L
>Sent: Wednesday, December 04, 2019 9:16 AM
>To: devel@edk2.groups.io; phi...@redhat.com; Achin Gupta
>; Andrew Fish ; Anthony Perard
>; Ard Biesheuvel ;
>Zhang, Chao B ; Chiu, Chasel
>; Dong, Eric ; Wu, Hao A
>; Wang, Jian J ; Wu, Jiaxin
>; Yao, Jiewen ; Justen, Jordan
>L ; Julien Grall ; Laszlo Ersek
>; Leif Lindholm ; Gao, Liming
>; Rabeda, Maciej ; Kinney,
>Michael D ; Ni, Ray ; Fu,
>Siyuan ; Zeng, Star ; Supreeth
>Venkatesh ; Lu, XiaoyuX
>; Gao, Zhichao 
>Cc: Antoine Cœur 
>Subject: RE: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
>
>Hi Philippe and Antoine,
>
>Thank you very much for doing this work!
>
>Please note that the mailing list currently has the braindead behavior only
>allowing a user to send 40 emails in a 30 minute window. I believe this is done
>to prevent spamming. Because of this, only patches 0-39 were actually
>received. Myself and Michael recently ran into this same problem with the
>Advanced Feature Refactor patch series. We worked around it by sending our
>emails in batches and waiting 30 minutes between each batch.
>
>Thanks,
>Nate
>
>-Original Message-
>From: devel@edk2.groups.io  On Behalf Of Philippe
>Mathieu-Daudé
>Sent: Tuesday, December 3, 2019 8:15 AM
>To: devel@edk2.groups.io; Achin Gupta ; Andrew
>Fish ; Anthony Perard ; Ard
>Biesheuvel ; Zhang, Chao B
>; Chiu, Chasel ; Dong, Eric
>; Wu, Hao A ; Wang, Jian J
>; Wu, Jiaxin ; Yao, Jiewen
>; Justen, Jordan L ;
>Julien Grall ; Laszlo Ersek ; Leif
>Lindholm ; Gao, Liming ;
>Rabeda, Maciej ; Kinney, Michael D
>; Desimone, Nathaniel L
>; Philippe Mathieu-Daude
>; Ni, Ray ; Fu, Siyuan
>; Zeng, Star ; Supreeth
>Venkatesh ; Lu, XiaoyuX
>; Gao, Zhichao 
>Cc: Antoine Cœur 
>Subject: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
>
>Around February of this year, Antoine posted various patches fixing
>a huge quantity of typos, over 8000+ lines (such [1]).
>
>The community merged the smaller patches, and told him his patches
>were too big, and he should split them.
>Around June, Antoine opened a GitHub pull request [2], due to the
>size of his patchset. We told him the project doesn't accept GitHub
>PR.
>
>Since I find his cleanup work very valuable for the project, I
>spent few hours trying to salvage a chunk of it, splitting per
>maintainer areas, each patch not to big to avoid reviewers burning
>out. I expect each maintainer to take his patches.
>
>I wanted to split Antoine work in 3 parts, but I'm about at 80
>patches, for only 1854 lines changed, so enough for a first round.
>
>Oh, and it is easier to review the patches using '--word-diff=color'
>git option :)
>
>Regards,
>
>Phil.
>
>P.D.: I think the project is really failing at getting new
>contributors involved, and keeping them. But that is another topic.
>
>[1] https://edk2.groups.io/g/devel/message/43043
>[2] https://edk2.groups.io/g/devel/message/42941
>
>Antoine Coeur (72):
>  CryptoPkg/OpensslLib: Fix few typos
>  EmbeddedPkg/FdtLib: Fix a typo
>  EmbeddedPkg/VirtualKeyboard: Fix few typos
>  EmulatorPkg/Sec: Fix various typos
>  EmulatorPkg/Unix: Fix various typos
>  EmulatorPkg/Win: Fix various typos
>  FatPkg/EnhancedFatDxe: Fix various typos
>  FatPkg/FatPei: Fix few typos
>  IntelFsp2WrapperPkg: Fix various typos
>  MdeModulePkg/Application: Improve French translation
>  MdeModulePkg/Application: Fix various typos
>  MdeModulePkg/Bus/Ata: Fix various typos
>  MdeModulePkg/Bus/I2c: Fix few typos
>  MdeModulePkg/Bus/Isa: Fix various typos
>  MdeModulePkg/Bus/Scsi: Fix various typos
>  MdeModulePkg/Bus/Sd: Fix various typos
>  MdeModulePkg/Core/Pei: Fix various typos
>  MdeModulePkg/Core/PiSmmCore: Fix various typos
>  MdeModulePkg/UsbMass: Fix various typos
>  MdeModulePkg/UsbMouse: Fix few typos
>  MdeModulePkg/UsbBus: Fix various typos
>  MdeModulePkg/Usb: Fix various typos
>  MdePkg/IndustryStandard: Fix various typos
>  MdePkg/Library/Dxe: Fix various typos
>  MdePkg/Library/Pci: Fix various typos
>  MdePkg/Library/Smm: Fix various typos
>  MdePkg/Ppi: Fix various typos
>  MdePkg/Register: Fix various typos
>  NetworkPkg/ArpDxe: Fix various typos
>  NetworkPkg/Dhcp4Dxe: Fix various typos
>  NetworkPkg/Dhcp6Dxe: Fix various typos
>  NetworkPkg/DnsDxe: Fix various typos
>  NetworkPkg/DpcDxe: Fix few typos
>  NetworkPkg/HttpBootDxe: Fix various typos
>  NetworkPkg/HttpDxe: Fix various typos
>  NetworkPkg/Ip4Dxe: Fix various typos
>  NetworkPkg/Ip6Dxe: Fix various typos
>  NetworkPkg/IScsiDxe: Fix various typos
>  NetworkPkg/Library: Fix various typos
>  NetworkPkg/MnpDxe: Fix various typos
>  NetworkPkg/Mtftp4Dxe: Fix various typos
>  NetworkPkg/Mtftp6Dxe: Fix various typos
>  NetworkPkg/SnpDxe: Fix few typos
>  NetworkPkg/TcpDxe/Sock: Fix few typos
>  NetworkPkg/TcpDxe/Tcp: Fix various typos
>  NetworkPkg/Tls: Fix few typos
>  NetworkPkg/Udp4Dxe: Fix various typos
>  

Re: [edk2-devel] [PATCH 27/79] MdePkg/Library/Pci: Fix various typos

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: devel@edk2.groups.io  On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Kinney, Michael D
> ; Gao, Liming
> ; Philippe Mathieu-Daude
> 
> Subject: [edk2-devel] [PATCH 27/79] MdePkg/Library/Pci:
> Fix various typos
> 
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude
> 
> ---
>  MdePkg/Include/Library/PciCf8Lib.h
> | 4 ++--
>  MdePkg/Include/Library/PciExpressLib.h
> | 4 ++--
>  MdePkg/Include/Library/PciLib.h
> | 4 ++--
>  MdePkg/Include/Library/PciSegmentLib.h
> | 4 ++--
> 
> MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSe
> gmentLib.c | 2 +-
> 
> MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCo
> mmon.c | 4 ++--
>  6 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/MdePkg/Include/Library/PciCf8Lib.h
> b/MdePkg/Include/Library/PciCf8Lib.h
> index 41558dabddc2..7e22a527a80e 100644
> --- a/MdePkg/Include/Library/PciCf8Lib.h
> +++ b/MdePkg/Include/Library/PciCf8Lib.h
> @@ -1027,7 +1027,7 @@ PciCf8BitFieldAndThenOr32 (
>Size into the buffer specified by Buffer. This
> function only allows the PCI
>configuration registers from a single PCI function
> to be read. Size is
>returned. When possible 32-bit PCI configuration
> read cycles are used to read
> -  from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> +  from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
>and 16-bit PCI configuration read cycles may be used
> at the beginning and the
>end of the range.
> 
> @@ -1060,7 +1060,7 @@ PciCf8ReadBuffer (
>Size from the buffer specified by Buffer. This
> function only allows the PCI
>configuration registers from a single PCI function
> to be written. Size is
>returned. When possible 32-bit PCI configuration
> write cycles are used to
> -  write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> +  write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
>8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
>and the end of the range.
> 
> diff --git a/MdePkg/Include/Library/PciExpressLib.h
> b/MdePkg/Include/Library/PciExpressLib.h
> index aec2b5f3777d..826fdcf7db6c 100644
> --- a/MdePkg/Include/Library/PciExpressLib.h
> +++ b/MdePkg/Include/Library/PciExpressLib.h
> @@ -997,7 +997,7 @@ PciExpressBitFieldAndThenOr32 (
>Size into the buffer specified by Buffer. This
> function only allows the PCI
>configuration registers from a single PCI function
> to be read. Size is
>returned. When possible 32-bit PCI configuration
> read cycles are used to read
> -  from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> +  from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
>and 16-bit PCI configuration read cycles may be used
> at the beginning and the
>end of the range.
> 
> @@ -1029,7 +1029,7 @@ PciExpressReadBuffer (
>Size from the buffer specified by Buffer. This
> function only allows the PCI
>configuration registers from a single PCI function
> to be written. Size is
>returned. When possible 32-bit PCI configuration
> write cycles are used to
> -  write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> +  write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
>8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
>and the end of the range.
> 
> diff --git a/MdePkg/Include/Library/PciLib.h
> b/MdePkg/Include/Library/PciLib.h
> index 7a7d42050f0a..836494b6c1d7 100644
> --- a/MdePkg/Include/Library/PciLib.h
> +++ b/MdePkg/Include/Library/PciLib.h
> @@ -997,7 +997,7 @@ PciBitFieldAndThenOr32 (
>Size into the buffer specified by Buffer. This
> function only allows the PCI
>configuration registers from a single PCI function
> to be read. Size is
>returned. When possible 32-bit PCI configuration
> read cycles are used to read
> -  from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> +  from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
>and 16-bit PCI configuration read cycles may be used
> at the beginning and the
>end of the range.
> 
> @@ -1029,7 +1029,7 @@ PciReadBuffer (
>Size from the buffer specified by Buffer. This
> function only allows the PCI
>configuration registers from a single PCI function
> to be written. Size is
>returned. When possible 32-bit PCI configuration
> write cycles are used to
> -  write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> +  write from StartAddress to StartAddress + Size. Due
> to alignment 

Re: [edk2-devel] [PATCH 26/79] MdePkg/Library/Dxe: Fix various typos

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: devel@edk2.groups.io  On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Kinney, Michael D
> ; Gao, Liming
> ; Philippe Mathieu-Daude
> 
> Subject: [edk2-devel] [PATCH 26/79] MdePkg/Library/Dxe:
> Fix various typos
> 
> From: Antoine Coeur 
> 
> Fix various typos in documentation, comments and
> strings,
> and remove the duplicated 'the'.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude
> 
> ---
>  MdePkg/Library/DxePcdLib/DxePcdLib.inf
> |  2 +-
>  MdePkg/Include/Library/DxeServicesLib.h
> |  2 +-
> 
> MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGui
> dedSectionLib.c | 10 +-
>  MdePkg/Library/DxeHobLib/HobLib.c
> |  2 +-
>  MdePkg/Library/DxeIoLibCpuIo2/IoLib.c
> |  2 +-
>  MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
> |  6 +++---
>  MdePkg/Library/DxeServicesLib/DxeServicesLib.c
> | 12 ++--
> 
> MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.
> c   |  2 +-
>  MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c
> |  2 +-
>  MdePkg/Library/DxePcdLib/DxePcdLib.uni
> |  2 +-
>  10 files changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> b/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> index c3f67543a4b7..3d4d21b442b4 100644
> --- a/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> +++ b/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> @@ -16,7 +16,7 @@
>  # Note: A driver of type DXE_RUNTIME_DRIVER and
> DXE_SMM_DRIVER can only use this DxePcdLib
>  #  in their initialization without any issues to
> access Dynamic and DynamicEx PCD. They can't
>  #  access Dynamic and DynamicEx PCD in the
> implementation of runtime services and SMI handlers.
> -#  Because EFI_PCD_PROTOCOL is DXE protocol that is
> not aviable in OS runtime phase.
> +#  Because EFI_PCD_PROTOCOL is DXE protocol that is
> not available in OS runtime phase.
>  #
>  # Copyright (c) 2007 - 2018, Intel Corporation. All
> rights reserved.
>  #
> diff --git a/MdePkg/Include/Library/DxeServicesLib.h
> b/MdePkg/Include/Library/DxeServicesLib.h
> index 838abf356fdd..689f47a54fa1 100644
> --- a/MdePkg/Include/Library/DxeServicesLib.h
> +++ b/MdePkg/Include/Library/DxeServicesLib.h
> @@ -171,7 +171,7 @@ GetSectionFromFv (
> 
> 
>  /**
> -  Searches the FFS file the the currently executing
> module was loaded from and returns the first matching
> FFS section.
> +  Searches the FFS file the currently executing module
> was loaded from and returns the first matching FFS
> section.
> 
>This function searches the FFS file that the
> currently executing module was loaded from for a FFS
> sections of type SectionType.
>If the FFS file contains at least SectionInstance
> instances of the FFS section specified by SectionType,
> diff --git
> a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractG
> uidedSectionLib.c
> b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractG
> uidedSectionLib.c
> index 4dfe450be9bc..ef730ec55159 100644
> ---
> a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractG
> uidedSectionLib.c
> +++
> b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractG
> uidedSectionLib.c
> @@ -150,7 +150,7 @@ ExtractGuidedSectionGetGuidList (
>If GetInfoHandler is NULL, then ASSERT().
>If DecodeHandler is NULL, then ASSERT().
> 
> -  @param[in]  SectionGuidA pointer to the GUID
> associated with the the handlers
> +  @param[in]  SectionGuidA pointer to the GUID
> associated with the handlers
>   of the GUIDed section
> type being registered.
>@param[in]  GetInfoHandler The pointer to a function
> that examines a GUIDed section and returns the
>   size of the decoded
> buffer and the size of an optional scratch buffer
> @@ -231,9 +231,9 @@
> ExtractGuidedSectionRegisterHandlers (
>Examines a GUIDed section specified by InputSection.
>If GUID for InputSection does not match any of the
> GUIDs registered through
> ExtractGuidedSectionRegisterHandlers(),
>then RETURN_UNSUPPORTED is returned.
> -  If the GUID of InputSection does match the GUID that
> this handler supports, then the the associated handler
> +  If the GUID of InputSection does match the GUID that
> this handler supports, then the associated handler
>of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER that
> was registered with
> ExtractGuidedSectionRegisterHandlers()
> -  is used to retrieve the OututBufferSize,
> ScratchSize, and Attributes values. The return status
> from the handler of
> +  is used to retrieve the OutputBufferSize,
> ScratchSize, and Attributes values. The return status
> from the handler of
>type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER is
> returned.
> 
>If InputSection is NULL, then ASSERT().
> @@ -311,7 +311,7 @@ ExtractGuidedSectionGetInfo (
>Decodes the GUIDed section 

Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

[Chiu, Chasel]

Philippe, thanks for helping on this.

Just minor feedbacks - many files having old copyright years that I replied 
below inline, please help to correct them.
With copyright updated, Reviewed-by: Chasel Chiu 


> -Original Message-
> From: Philippe Mathieu-Daude 
> Sent: Wednesday, December 4, 2019 12:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
> ; Philippe Mathieu-Daude 
> Subject: [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
> 
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Chasel Chiu 
> Cc: Nate DeSimone 
> Cc: Star Zeng 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> | 2 +-
>  IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> | 4 ++--
>  IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> | 2 +-
> 
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapp
> erPlatformLibSample.c| 4 ++--
> 
> IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrap
> perHobProcessLibSample.c | 4 ++--
> 
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nas
> m| 6 +++---
> 
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sec
> Entry.nasm | 2 +-
> 
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sta
> ck.nasm| 2 +-
>  8 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> index e39054c30d3b..11a3faaad87a 100644
> --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h


Copyright for this file should be "2014 - 2019"


> @@ -40,7 +40,7 @@ CallFspNotifyPhase (
>  /**
>Call FSP API - FspMemoryInit.
> 
> -  @param[in]  FspmUpdDataPtr  Pointer to the FSPM_UPD data
> sructure.
> +  @param[in]  FspmUpdDataPtr  Pointer to the FSPM_UPD data
> structure.
>@param[out] HobListPtr  Pointer to receive the address
> of the HOB list.
> 
>@return EFI status returned by FspMemoryInit API.
> diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> index b90f0eb78302..2aa14c92fd63 100644
> --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h


Copyright for this file should be "2014 - 2019"


> @@ -12,7 +12,7 @@
>  /**
>This function overrides the default configurations in the FSP-M UPD data
> region.
> 
> -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> strcture.
> +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> structure.
> 
>  **/
>  VOID
> @@ -24,7 +24,7 @@ UpdateFspmUpdData (
>  /**
>This function overrides the default configurations in the FSP-S UPD data
> region.
> 
> -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> strcture.
> +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> structure.
> 
>  **/
>  VOID
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 0f8cd69a0e6e..b20f0805a021 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
>EFI_BOOT_MODEBootMode;
> 
>//
> -  // Register MemoryDiscovered Nofity to run FspSiliconInit
> +  // Register MemoryDiscovered Notify to run FspSiliconInit
>//
>Status = PeiServicesNotifyPpi ();
>ASSERT_EFI_ERROR (Status);
> diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> index def04b176659..dddf80b76c26 100644
> ---
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> +++
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c


Copyright for this file should be "2014 - 2019"


> @@ -14,7 +14,7 @@
> 
>@note At this point, memory is NOT ready, PeiServices are available to
> use.
> 
> -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> strcture.
> +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> structure.
> 
>  **/
>  VOID
> @@ -28,7 +28,7 @@ UpdateFspmUpdData (
>  /**
>This function overrides the default configurations in the FSP-S UPD data
> region.
> 
> -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> strcture.
> +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> 

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Add list-repos command

[Desimone, Ashley E]

It looks good for now but in the future I would like to see an error message 
when the repo name passed with the --repos flag is not found.

Reviewed-by: Ashley E DeSimone 

-Original Message-
From: Desimone, Nathaniel L 
Sent: Tuesday, December 3, 2019 3:06 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E 
Subject: [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Add list-repos command

list-repos lists the git repos used by all projects and which branches those 
projects use.

Cc: Ashley E Desimone 
Signed-off-by: Nate DeSimone 
---
 edkrepo/commands/arguments/list_repos_args.py |  16 ++
 edkrepo/commands/humble/__init__.py   |   8 +
 edkrepo/commands/humble/list_repos_humble.py  |  26 ++
 edkrepo/commands/list_repos_command.py| 243 ++
 setup.py  |   5 +-
 5 files changed, 295 insertions(+), 3 deletions(-)  create mode 100644 
edkrepo/commands/arguments/list_repos_args.py
 create mode 100644 edkrepo/commands/humble/__init__.py
 create mode 100644 edkrepo/commands/humble/list_repos_humble.py
 create mode 100644 edkrepo/commands/list_repos_command.py

diff --git a/edkrepo/commands/arguments/list_repos_args.py 
b/edkrepo/commands/arguments/list_repos_args.py
new file mode 100644
index 000..6ff9b9c
--- /dev/null
+++ b/edkrepo/commands/arguments/list_repos_args.py
@@ -0,0 +1,16 @@
+#!/usr/bin/env python3+#+## @file+# list_repos_args.py+#+# Copyright 
+(c) 2019, Intel Corporation. All rights reserved.+# 
+SPDX-License-Identifier: BSD-2-Clause-Patent+#++''' Contains the help 
+and description strings for arguments in the+list-repos command meta 
+data.+'''++COMMAND_DESCRIPTION = 'Lists the git repos used by available 
+projects and the branches that are used.'+ARCHIVED_HELP = 'Include a 
+listing of archived projects.'+REPOS_HELP = 'Only show the given subset 
+of repos instead of all repos.'diff --git 
+a/edkrepo/commands/humble/__init__.py 
+b/edkrepo/commands/humble/__init__.py
new file mode 100644
index 000..dea6eb4
--- /dev/null
+++ b/edkrepo/commands/humble/__init__.py
@@ -0,0 +1,8 @@
+#!/usr/bin/env python3+#+## @file+# __init__.py+#+# Copyright (c) 2019, 
+Intel Corporation. All rights reserved.+# SPDX-License-Identifier: 
+BSD-2-Clause-Patent+#diff --git 
+a/edkrepo/commands/humble/list_repos_humble.py 
+b/edkrepo/commands/humble/list_repos_humble.py
new file mode 100644
index 000..bbb05a7
--- /dev/null
+++ b/edkrepo/commands/humble/list_repos_humble.py
@@ -0,0 +1,26 @@
+#!/usr/bin/env python3+#+## @file+# list_repos_humble.py+#+# Copyright (c) 
2019, Intel Corporation. All rights reserved.+# SPDX-License-Identifier: 
BSD-2-Clause-Patent+#++'''+Contains user visible strings printed by the 
list-repos command.+'''++from colorama import Fore+from colorama import 
Style++BRANCHES = 'Branches:'+BRANCH_FORMAT_STRING = '  
{}{}{{}}{}'.format(Fore.BLUE, Style.BRIGHT, 
Style.RESET_ALL)+COMBO_FORMAT_STRING = '{{}}  
{}{}({{}}){}'.format(Fore.CYAN, Style.BRIGHT, 
Style.RESET_ALL)+DEFAULT_COMBO_FORMAT_STRING = '{{}} 
{}{}*({{}})*{}'.format(Fore.GREEN, Style.BRIGHT, 
Style.RESET_ALL)+MANIFEST_DIRECTORY = 'Manifest 
directory:'+PROJECT_NAME_FORMAT_STRING = '{}{}{{}}{}:'.format(Fore.YELLOW, 
Style.BRIGHT, Style.RESET_ALL)+REPOSITORIES = 'Repositories:'+REPO_NAME_AND_URL 
= '{}{}{{}}{} - [{}{}{{}}{}]'.format(Fore.MAGENTA, Style.BRIGHT, 
Style.RESET_ALL, Fore.RED, Style.BRIGHT, Style.RESET_ALL)+REPO_NAME_NOT_FOUND = 
'repo_name not found'+REPO_NOT_FOUND_IN_MANIFEST = 'Repo {} not found in any 
manifest file'diff --git a/edkrepo/commands/list_repos_command.py 
b/edkrepo/commands/list_repos_command.py
new file mode 100644
index 000..9035993
--- /dev/null
+++ b/edkrepo/commands/list_repos_command.py
@@ -0,0 +1,243 @@
+#!/usr/bin/env python3+#+## @file+# list_repos_command.py+#+# Copyright (c) 
2019, Intel Corporation. All rights reserved.+# SPDX-License-Identifier: 
BSD-2-Clause-Patent+#++import collections+import os++#from git import Repo+from 
colorama import Fore, Style++# Our modules+from 
edkrepo.commands.edkrepo_command import EdkrepoCommand+from 
edkrepo.commands.edkrepo_command import ColorArgument+import 
edkrepo.commands.arguments.list_repos_args as arguments+import 
edkrepo.commands.humble.list_repos_humble as humble+from 
edkrepo.common.common_repo_functions import pull_latest_manifest_repo+from 
edkrepo.common.edkrepo_exception import EdkrepoInvalidParametersException, 
EdkrepoManifestInvalidException+from edkrepo.common.ui_functions import 
init_color_console+from edkrepo_manifest_parser.edk_manifest import CiIndexXml, 
ManifestXml++class ListReposCommand(EdkrepoCommand):+def __init__(self):+   
 super().__init__()+self.repo_names = None++def 
get_metadata(self):+metadata = {}+metadata['name'] = 
'list-repos'+metadata['help-text'] = arguments.COMMAND_DESCRIPTION+ 
   args = []+metadata['arguments'] = args+args.append({'name': 
'repos',+  

Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)

[Nate DeSimone]

Hi Philippe and Antoine,

Thank you very much for doing this work!

Please note that the mailing list currently has the braindead behavior only 
allowing a user to send 40 emails in a 30 minute window. I believe this is done 
to prevent spamming. Because of this, only patches 0-39 were actually received. 
Myself and Michael recently ran into this same problem with the Advanced 
Feature Refactor patch series. We worked around it by sending our emails in 
batches and waiting 30 minutes between each batch.

Thanks,
Nate

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Philippe 
Mathieu-Daudé
Sent: Tuesday, December 3, 2019 8:15 AM
To: devel@edk2.groups.io; Achin Gupta ; Andrew Fish 
; Anthony Perard ; Ard Biesheuvel 
; Zhang, Chao B ; Chiu, 
Chasel ; Dong, Eric ; Wu, Hao A 
; Wang, Jian J ; Wu, Jiaxin 
; Yao, Jiewen ; Justen, Jordan L 
; Julien Grall ; Laszlo Ersek 
; Leif Lindholm ; Gao, Liming 
; Rabeda, Maciej ; Kinney, 
Michael D ; Desimone, Nathaniel L 
; Philippe Mathieu-Daude ; 
Ni, Ray ; Fu, Siyuan ; Zeng, Star 
; Supreeth Venkatesh ; Lu, 
XiaoyuX ; Gao, Zhichao 
Cc: Antoine Cœur 
Subject: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)

Around February of this year, Antoine posted various patches fixing
a huge quantity of typos, over 8000+ lines (such [1]).

The community merged the smaller patches, and told him his patches
were too big, and he should split them.
Around June, Antoine opened a GitHub pull request [2], due to the
size of his patchset. We told him the project doesn't accept GitHub
PR.

Since I find his cleanup work very valuable for the project, I
spent few hours trying to salvage a chunk of it, splitting per
maintainer areas, each patch not to big to avoid reviewers burning
out. I expect each maintainer to take his patches.

I wanted to split Antoine work in 3 parts, but I'm about at 80
patches, for only 1854 lines changed, so enough for a first round.

Oh, and it is easier to review the patches using '--word-diff=color'
git option :)

Regards,

Phil.

P.D.: I think the project is really failing at getting new
contributors involved, and keeping them. But that is another topic.

[1] https://edk2.groups.io/g/devel/message/43043
[2] https://edk2.groups.io/g/devel/message/42941

Antoine Coeur (72):
  CryptoPkg/OpensslLib: Fix few typos
  EmbeddedPkg/FdtLib: Fix a typo
  EmbeddedPkg/VirtualKeyboard: Fix few typos
  EmulatorPkg/Sec: Fix various typos
  EmulatorPkg/Unix: Fix various typos
  EmulatorPkg/Win: Fix various typos
  FatPkg/EnhancedFatDxe: Fix various typos
  FatPkg/FatPei: Fix few typos
  IntelFsp2WrapperPkg: Fix various typos
  MdeModulePkg/Application: Improve French translation
  MdeModulePkg/Application: Fix various typos
  MdeModulePkg/Bus/Ata: Fix various typos
  MdeModulePkg/Bus/I2c: Fix few typos
  MdeModulePkg/Bus/Isa: Fix various typos
  MdeModulePkg/Bus/Scsi: Fix various typos
  MdeModulePkg/Bus/Sd: Fix various typos
  MdeModulePkg/Core/Pei: Fix various typos
  MdeModulePkg/Core/PiSmmCore: Fix various typos
  MdeModulePkg/UsbMass: Fix various typos
  MdeModulePkg/UsbMouse: Fix few typos
  MdeModulePkg/UsbBus: Fix various typos
  MdeModulePkg/Usb: Fix various typos
  MdePkg/IndustryStandard: Fix various typos
  MdePkg/Library/Dxe: Fix various typos
  MdePkg/Library/Pci: Fix various typos
  MdePkg/Library/Smm: Fix various typos
  MdePkg/Ppi: Fix various typos
  MdePkg/Register: Fix various typos
  NetworkPkg/ArpDxe: Fix various typos
  NetworkPkg/Dhcp4Dxe: Fix various typos
  NetworkPkg/Dhcp6Dxe: Fix various typos
  NetworkPkg/DnsDxe: Fix various typos
  NetworkPkg/DpcDxe: Fix few typos
  NetworkPkg/HttpBootDxe: Fix various typos
  NetworkPkg/HttpDxe: Fix various typos
  NetworkPkg/Ip4Dxe: Fix various typos
  NetworkPkg/Ip6Dxe: Fix various typos
  NetworkPkg/IScsiDxe: Fix various typos
  NetworkPkg/Library: Fix various typos
  NetworkPkg/MnpDxe: Fix various typos
  NetworkPkg/Mtftp4Dxe: Fix various typos
  NetworkPkg/Mtftp6Dxe: Fix various typos
  NetworkPkg/SnpDxe: Fix few typos
  NetworkPkg/TcpDxe/Sock: Fix few typos
  NetworkPkg/TcpDxe/Tcp: Fix various typos
  NetworkPkg/Tls: Fix few typos
  NetworkPkg/Udp4Dxe: Fix various typos
  NetworkPkg/Udp6Dxe: Fix various typos
  NetworkPkg/UefiPxeBcDxe: Fix various typos
  NetworkPkg/VlanConfigDxe: Fix few typos
  OvmfPkg/Acpi: Fix few typos
  OvmfPkg/Csm: Fix various typos
  OvmfPkg/Qemu: Fix various typos
  OvmfPkg/Virtio: Fix few typos
  OvmfPkg/Xen: Fix various typos
  PcAtChipsetPkg: Fix few typos
  SecurityPkg: Fix few typos
  SecurityPkg/Hash2DxeCrypto: Fix few typos
  SecurityPkg/Library/Tpm: Fix various typos
  SecurityPkg/Tcg: Fix various typos
  SecurityPkg/VariableAuthenticated: Fix few typos
  ShellPkg/Application: Fix various typos
  ShellPkg/DynamicCommand: Fix various typos
  SignedCapsulePkg: Fix various typos
  SignedCapsulePkg/Universal: Fix various typos
  SourceLevelDebugPkg/DebugAgent: Fix various typos
  SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
  

Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Philippe 
Mathieu-Daudé
Sent: Tuesday, December 3, 2019 8:15 AM
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Chiu, Chasel ; 
Desimone, Nathaniel L ; Zeng, Star 
; Philippe Mathieu-Daude 
Subject: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Star Zeng 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h 
  | 2 +-
 IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
  | 4 ++--
 IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c  
  | 2 +-
 
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
| 4 ++--
 
IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
 | 4 ++--
 IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm  
  | 6 +++---
 
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
 | 2 +-
 IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm  
  | 2 +-
 8 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h 
b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
index e39054c30d3b..11a3faaad87a 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
@@ -40,7 +40,7 @@ CallFspNotifyPhase (
 /**
   Call FSP API - FspMemoryInit.
 
-  @param[in]  FspmUpdDataPtr  Pointer to the FSPM_UPD data sructure.
+  @param[in]  FspmUpdDataPtr  Pointer to the FSPM_UPD data structure.
   @param[out] HobListPtr  Pointer to receive the address of the 
HOB list.
 
   @return EFI status returned by FspMemoryInit API.
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h 
b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
index b90f0eb78302..2aa14c92fd63 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
@@ -12,7 +12,7 @@
 /**
   This function overrides the default configurations in the FSP-M UPD data 
region.
 
-  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data strcture.
+  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data 
structure.
 
 **/
 VOID
@@ -24,7 +24,7 @@ UpdateFspmUpdData (
 /**
   This function overrides the default configurations in the FSP-S UPD data 
region.
 
-  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data strcture.
+  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data 
structure.
 
 **/
 VOID
diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c 
b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 0f8cd69a0e6e..b20f0805a021 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
   EFI_BOOT_MODEBootMode;
 
   //
-  // Register MemoryDiscovered Nofity to run FspSiliconInit
+  // Register MemoryDiscovered Notify to run FspSiliconInit
   //
   Status = PeiServicesNotifyPpi ();
   ASSERT_EFI_ERROR (Status);
diff --git 
a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
 
b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
index def04b176659..dddf80b76c26 100644
--- 
a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
+++ 
b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
@@ -14,7 +14,7 @@
 
   @note At this point, memory is NOT ready, PeiServices are available to use.
 
-  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data strcture.
+  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data 
structure.
 
 **/
 VOID
@@ -28,7 +28,7 @@ UpdateFspmUpdData (
 /**
   This function overrides the default configurations in the FSP-S UPD data 
region.
 
-  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data strcture.
+  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data 
structure.
 
 **/
 VOID
diff --git 
a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
 
b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
index 54cebe127c8f..48f4b0295a30 100644
--- 
a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
+++ 

Re: [edk2-devel] [PATCH 73/79] SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos

[Wu, Hao A]

> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Wednesday, December 04, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur; Wu, Hao A; Philippe Mathieu-Daude
> Subject: [PATCH 73/79] SourceLevelDebugPkg/DebugCommunicationLib: Fix
> various typos
> 
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.


Reviewed-by: Hao A Wu 

Best Regards,
Hao Wu


> 
> Cc: Hao A Wu 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
> 
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
> municationLibSerialPort.inf | 2 +-
>  SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> | 2 +-
> 
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunic
> ationLibUsb3Internal.h   | 4 ++--
> 
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
> municationLibSerialPort.c   | 2 +-
> 
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunic
> ationLibUsb3Common.c | 2 +-
> 
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunic
> ationLibUsb3Dxe.c| 2 +-
> 
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunic
> ationLibUsb3Transfer.c   | 4 ++--
> 
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
> municationLibSerialPort.uni | 2 +-
>  8 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
> index 668e0bef178e..21af18cfb0b0 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
> @@ -1,5 +1,5 @@
>  ## @file
> -#  Debug Communication Library instance based on serila port.
> +#  Debug Communication Library instance based on serial port.
>  #
>  #  Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.
>  #
> diff --git a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> index bc7a00b537c7..73e0f19f92a9 100644
> --- a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> +++ b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> @@ -30,7 +30,7 @@ VOID
>  /**
>Initialize the debug port.
> 
> -  This function will initialize debug port to get it ready for data 
> transmition. If
> +  This function will initialize debug port to get it ready for data 
> transmission. If
>certain Debug Communication Library instance has to save some private data
> in the
>stack, this function must work on the mode that doesn't return to the 
> caller,
> then
>the caller needs to wrap up all rest of logic after DebugPortInitialize() 
> into
> one
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Internal.h
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Internal.h
> index 72ed2c74162f..df50220f33dc 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Internal.h
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Internal.h
> @@ -85,7 +85,7 @@
>  #define XHC_DEBUG_PORT_ON_OFF_DELAY10
> 
>  //
> -// USB debug device string descritpor (header size + unicode string length)
> +// USB debug device string descriptor (header size + unicode string length)
>  //
>  #define STRING0_DESC_LEN  4
>  #define MANU_DESC_LEN 12
> @@ -680,7 +680,7 @@ USB3InitializeReal (
>@param  Direction The direction of data transfer.
>@param  Data  Array of pointers to the buffers of data to 
> transmit
>  from or receive into.
> -  @param  DataLengthThe lenght of the data buffer.
> +  @param  DataLengthThe length of the data buffer.
>@param  Timeout   Indicates the maximum time, in millisecond,
> which
>  the transfer is allowed to complete.
> 
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> index 604c7e6d52ce..045026508e80 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> @@ -15,7 +15,7 @@
>  /**
>Initialize the debug port.
> 
> -  This function will initialize debug port to get it ready for data 
> transmition. If
> +  This function will initialize debug port 

Re: [edk2-devel] [PATCH 72/79] SourceLevelDebugPkg/DebugAgent: Fix various typos

[Wu, Hao A]

> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Wednesday, December 04, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur; Wu, Hao A; Philippe Mathieu-Daude
> Subject: [PATCH 72/79] SourceLevelDebugPkg/DebugAgent: Fix various typos
> 
> From: Antoine Coeur 
> 
> Fix various typos in documentation, comments and debug strings.


Reviewed-by: Hao A Wu 

Best Regards,
Hao Wu


> 
> Cc: Hao A Wu 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> |  6 +--
> 
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDe
> bugSupport.h |  2 +-
> 
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugE
> xception.h   |  2 +-
> 
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDeb
> ugSupport.h  |  2 +-
> 
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugEx
> ception.h|  2 +-
>  SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
>|
> 2 +-
>  SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c
>|  2
> +-
> 
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.
> c| 52 ++--
> 
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLi
> b.c |  2 +-
>  SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
> |  6 +--
> 
> SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAg
> entLib.c   | 10 ++--
> 
> SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgent
> Lib.c | 10 ++--
> 
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFun
> cs.nasm  |  4 +-
>  13 files changed, 51 insertions(+), 51 deletions(-)
> 
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.
> h
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.
> h
> index 71d7802d1548..07ddccad335d 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.
> h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.
> h
> @@ -17,7 +17,7 @@ typedef struct {
>  } DEBUG_CPU_DATA;
> 
>  typedef struct {
> -  SPIN_LOCK MpContextSpinLock;   ///< Lock for writting MP 
> context
> +  SPIN_LOCK MpContextSpinLock;   ///< Lock for writing MP 
> context
>SPIN_LOCK DebugPortSpinLock;   ///< Lock for access debug 
> port
>SPIN_LOCK MailboxSpinLock; ///< Lock for accessing 
> mail box
>UINT8 CpuBreakMask[DEBUG_CPU_MAX_COUNT/8];///<
> Bitmask of all breaking CPUs
> @@ -26,8 +26,8 @@ typedef struct {
>UINT32BspIndex;///< Processor index value 
> of BSP
>UINT32BreakAtCpuIndex; ///< Processor index value 
> of the
> current breaking CPU
>UINT32DebugTimerInitCount; ///< Record BSP's init 
> timer count
> -  BOOLEAN   IpiSentByAp; ///< TRUR: IPI is sent by 
> AP. TALSE: IPI
> is sent by BSP
> -  BOOLEAN   RunCommandSet;   ///< TRUE: RUN commmand is
> executing. FALSE : RUN command has been executed.
> +  BOOLEAN   IpiSentByAp; ///< TRUE: IPI is sent by 
> AP. FALSE: IPI
> is sent by BSP
> +  BOOLEAN   RunCommandSet;   ///< TRUE: RUN command is
> executing. FALSE: RUN command has been executed.
>  } DEBUG_MP_CONTEXT;
> 
>  extern DEBUG_MP_CONTEXT volatile   mDebugMpContext;
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Arch
> DebugSupport.h
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Arch
> DebugSupport.h
> index d816bdaecdbe..3acb0352bf76 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Arch
> DebugSupport.h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Arch
> DebugSupport.h
> @@ -1,5 +1,5 @@
>  /** @file
> -  IA32 specific defintions for debug agent library instance.
> +  IA32 specific definitions for debug agent library instance.
> 
>Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Debu
> gException.h
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Debu
> gException.h
> index 750b3e4724eb..9147fabe6c3e 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Debu
> gException.h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Debu
> gException.h
> @@ -1,5 +1,5 @@
>  /** @file
> -  Exception defintions.
> +  Exception definitions.
> 
>Copyright (c) 2010, Intel Corporation. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git
> 

Re: [edk2-devel] [PATCH 74/79] SourceLevelDebugPkg: Fix few typos

[Wu, Hao A]

> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Wednesday, December 04, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur; Wu, Hao A; Philippe Mathieu-Daude
> Subject: [PATCH 74/79] SourceLevelDebugPkg: Fix few typos
> 
> From: Antoine Coeur 
> 
> Correctly write 'definitions' in comments and documentation.


Reviewed-by: Hao A Wu 

Best Regards,
Hao Wu


> 
> Cc: Hao A Wu 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h | 2 +-
>  SourceLevelDebugPkg/Include/TransferProtocol.h  | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
> b/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
> index 71f596f285bd..2c5cf03cec90 100644
> --- a/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
> +++ b/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
> @@ -1,5 +1,5 @@
>  /** @file
> -  IA32/x64 architecture specific defintions needed by debug transfer 
> protocol.It
> is only
> +  IA32/x64 architecture specific definitions needed by debug transfer
> protocol.It is only
>intended to be used by Debug related module implementation.
> 
>Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
> diff --git a/SourceLevelDebugPkg/Include/TransferProtocol.h
> b/SourceLevelDebugPkg/Include/TransferProtocol.h
> index 3904ba27dcb8..154e74165e8d 100644
> --- a/SourceLevelDebugPkg/Include/TransferProtocol.h
> +++ b/SourceLevelDebugPkg/Include/TransferProtocol.h
> @@ -1,5 +1,5 @@
>  /** @file
> -  Transfer protocol defintions used by debug agent and host. It is only
> +  Transfer protocol definitions used by debug agent and host. It is only
>intended to be used by Debug related module implementation.
> 
>Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
> @@ -140,7 +140,7 @@ typedef struct {
>UINT64  StopAddress;
>  } DEBUG_DATA_RESPONSE_BREAK_CAUSE;
>  //
> -// Break type defintions for DEBUG_DATA_BREAK_CAUSE
> +// Break type definitions for DEBUG_DATA_BREAK_CAUSE
>  //
>  #define DEBUG_DATA_BREAK_CAUSE_UNKNOWN0
>  #define DEBUG_DATA_BREAK_CAUSE_HW_BREAKPOINT  1
> @@ -160,7 +160,7 @@ typedef struct {
>UINT8   CpuMode;
>  } DEBUG_DATA_RESPONSE_ARCH_MODE;
>  //
> -// Cpu architecture defintions for DEBUG_DATA_RESPONSE_ARCH_MODE
> +// Cpu architecture definitions for DEBUG_DATA_RESPONSE_ARCH_MODE
>  //
>  #define DEBUG_DATA_BREAK_CPU_ARCH_IA160
>  #define DEBUG_DATA_BREAK_CPU_ARCH_IA321
> --
> 2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51695): https://edk2.groups.io/g/devel/message/51695
Mute This Topic: https://groups.io/mt/66150998/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] EDK II Stable Tag release edk2-stable201911 completed

[Liming Gao]

Takuto:
  Yes. I prepared IA32 and X64 ShellBin binary. Ard will help generate ARM and 
AARCH64 ShellBin binary. Then, I will upload them.

Thanks
Liming
From: nait...@gmail.com 
Sent: Tuesday, December 3, 2019 11:10 PM
To: Gao; Gao, Liming ; devel@edk2.groups.io
Subject: Re: [edk2-devel] EDK II Stable Tag release edk2-stable201911 completed

Hi Liming,

Congrats on releasing edk2-stable201911.
Could you add ShellBinPkg.zip to the assets of the release on GitHub?

ShellPkg of the new tag includes many improvements. ShellBinPkg.zip is helpful 
to use it.


Regards,
Takuto

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51692): https://edk2.groups.io/g/devel/message/51692
Mute This Topic: https://groups.io/mt/64493623/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

[Nate DeSimone]

Hi Philippe,

FYI, this patch from Chasel was merged 8 months ago:

https://github.com/tianocore/edk2/commit/00e3e4801467dd73b90a151994fc26ba9b5734d7

Thanks,
Nate

-Original Message-
From: Philippe Mathieu-Daudé  
Sent: Monday, December 2, 2019 11:20 PM
To: devel@edk2.groups.io; Chiu, Chasel 
Cc: Desimone, Nathaniel L ; Zeng, Star 

Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix 
coding style.

On 4/22/19 12:11 PM, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
> 
> Internal code quality check failed after this commit:
> 68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those coding style 
> issues.
> 
> Cc: Nate DeSimone 
> Cc: Star Zeng 
> Signed-off-by: Chasel Chiu 
> ---
>   IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +-
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c 
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 9f8ce16023..0f8cd69a0e 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
>   extern EFI_GUID  gFspHobGuid;
>   
>   /**
> -  This function handles S3 resume task at the end of PEI
> +  This function handles S3 resume task at the end of PEI.
>   
> @param[in] PeiServicesPointer to PEI Services Table.
> @param[in] NotifyDesc Pointer to the descriptor for the Notification 
> event that
> @@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = {
>   };
>   
>   /**
> -  This function handles S3 resume task at the end of PEI
> +  This function handles S3 resume task at the end of PEI.
>   
> @param[in] PeiServicesPointer to PEI Services Table.
> @param[in] NotifyDesc Pointer to the descriptor for the Notification 
> event that
> @@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify (
>   }
>   
>   /**
> -  Do FSP initialization in API mode
> +  Do FSP initialization in API mode.
>   
> @retval EFI_STATUSAlways return EFI_SUCCESS
>   **/
> @@ -370,7 +370,7 @@ FspsWrapperInitApiMode (
>   }
>   
>   /**
> -  Do FSP initialization in Dispatch mode
> +  Do FSP initialization in Dispatch mode.
>   
> @retval FSP initialization status.
>   **/
> @@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode (
>   }
>   
>   /**
> -  This is the entrypoint of PEIM
> +  This is the entrypoint of PEIM.
>   
> @param[in] FileHandle  Handle of the file being invoked.
> @param[in] PeiServices Describes the list of possible PEI Services.
> 

Reviewed-by: Philippe Mathieu-Daude 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51691): https://edk2.groups.io/g/devel/message/51691
Mute This Topic: https://groups.io/mt/31272219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add initial package

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 13/47] 
Features/Intel/IpmiFeaturePkg: Add initial package

Adds a new feature package for the IPMI feature.

This change updates the advanced feature package template for IPMI and adds the 
updated template to the IpmiFeaturePkg.

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec | 29 
+++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc | 24 
++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf |  8 
++  Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf  |  
8 ++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md  | 89 

 5 files changed, 158 insertions(+)

diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
new file mode 100644
index 00..dfae88
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d
+++ ec
@@ -0,0 +1,29 @@
+## @file
+# This package provides advanced feature functionality to enable the # 
+Intelligent Platform Management Interface (IPMI).
+# This package should only depend on EDK II Core packages, IntelSiliconPkg, 
and MinPlatformPkg.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+  DEC_SPECIFICATION = 0x00010017
+  PACKAGE_NAME  = IpmiFeaturePkg
+  PACKAGE_GUID  = AE091910-F6C9-4AB5-B8B4-995E2F0D5166
+  PACKAGE_VERSION   = 0.1
+
+[Includes]
+  Include
+
+[Guids]
+  gIpmiFeaturePkgTokenSpaceGuid  =  {0xc05283f6, 0xd6a8, 0x48f3, {0x9b, 
+0x59, 0xfb, 0xca, 0x71, 0x32, 0x0f, 0x12}}
+
+[PcdsFeatureFlag]
+
+gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable|FALSE|BOOLEAN|0xA000
+0001
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc
new file mode 100644
index 00..1952ba185e
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d
+++ sc
@@ -0,0 +1,24 @@
+## @file
+# This package provides advanced feature functionality to enable the # 
+Intelligent Platform Management Interface (IPMI).
+# This package should only depend on EDK II Core packages, IntelSiliconPkg, 
and MinPlatformPkg.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+  PLATFORM_NAME  = IpmiFeaturePkg
+  PLATFORM_GUID  = 7B2E74D7-9538-4818-B51A-492F3D33BD20
+  PLATFORM_VERSION   = 0.1
+  DSC_SPECIFICATION  = 0x00010005
+  OUTPUT_DIRECTORY   = Build/$(PLATFORM_NAME)
+  SUPPORTED_ARCHITECTURES= IA32|X64
+  BUILD_TARGETS  = DEBUG|RELEASE|NOOPT
+  SKUID_IDENTIFIER   = DEFAULT
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf
new file mode 100644
index 00..c3847c54c7
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemo
+++ ry.fdf
@@ -0,0 +1,8 @@
+## @file
+#  FDF file for post-memory modules that enable Intelligent Platform 
Management Interface.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf
new file mode 100644
index 00..0c82d7eb02
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemor
+++ y.fdf
@@ -0,0 +1,8 @@
+## @file
+#  FDF file for pre-memory modules that enable Intelligent Platform Management 
Interface.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md
new file mode 100644
index 00..e70f1e850b
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md
@@ -0,0 +1,89 @@
+# Overview
+* **Feature Name:** Intelligent Platform 

Re: [edk2-devel] [edk2-platforms][PATCH V2 12/47] Features/Intel/S3FeaturePkg: Add initial package

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 12/47] 
Features/Intel/S3FeaturePkg: Add initial package

Adds a new feature package for the S3 feature.

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dec   |  30 +
 Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc  | 122 

 Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc   |  30 +
 Features/Intel/PowerManagement/S3FeaturePkg/Include/PostMemory.fdf |   8 ++
 Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf  |  10 ++
 Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf|  35 ++
 Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.c  |  36 ++
 Features/Intel/PowerManagement/S3FeaturePkg/Readme.md  |  94 
+++
 8 files changed, 365 insertions(+)

diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dec 
b/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dec
new file mode 100644
index 00..2a723ad3d6
--- /dev/null
+++ b/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dec
@@ -0,0 +1,30 @@
+## @file
+# This package provides advanced feature functionality for S3 support.
+# This package should only depend on EDK II Core packages, IntelSiliconPkg, 
and MinPlatformPkg.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+  DEC_SPECIFICATION = 0x00010017
+  PACKAGE_NAME  = S3FeaturePkg
+  PACKAGE_GUID  = 600F7249-65BD-44E2-80D7-344BD5250198
+  PACKAGE_VERSION   = 0.1
+
+[Includes]
+  Include
+
+[LibraryClasses]
+
+[Guids]
+  gS3FeaturePkgTokenSpaceGuid  =  {0x423c5a51, 0x36e9, 0x4aea, {0x92, 
+0xdd, 0xdd, 0xae, 0x5b, 0x4a, 0x3d, 0x24}}
+
+[PcdsFeatureFlag]
+
+gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable|FALSE|BOOLEAN|0xA001
diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc 
b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc
new file mode 100644
index 00..647dc3f93a
--- /dev/null
+++ b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc
@@ -0,0 +1,122 @@
+## @file
+# This is a build description file for the S3 advanced feature.
+# This file should be included into another package DSC file to build this 
feature.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+###
+#
+#
+# Defines Section - statements that will be processed to create a Makefile.
+#
+###
+#
+[Defines]
+!ifndef $(PEI_ARCH)
+  !error "PEI_ARCH must be specified to build this feature!"
+!endif
+!ifndef $(DXE_ARCH)
+  !error "DXE_ARCH must be specified to build this feature!"
+!endif
+
+###
+#
+#
+# Library Class section - list of all Library Classes needed by this feature.
+#
+###
+#
+[LibraryClasses]
+  ###
+  # Edk2 Packages
+  ###
+  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+
+BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.in
+f
+  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
+  IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
+  PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf
+  PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf
+
+PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.
+inf
+
+[LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
+  ###
+  # Edk2 Packages
+  ###
+  HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
+
+MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllo
+cationLib.inf
+  PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf
+  PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
+  PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
+
+PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt
+/PeiServicesTablePointerLibIdt.inf
+
+  ###
+  # 

Re: [edk2-devel] [edk2-platforms][PATCH V2 21/47] Features/Intel/NetworkFeaturePkg: Add initial package

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 21/47] 
Features/Intel/NetworkFeaturePkg: Add initial package

Adds a new feature package for the Network feature.

The Network feature code is actually in edk2/NetworkPkg at this time so this 
package inclues the content from edk2/NetworkPkg. In the future, it is 
preferred to move the source code from NetworkPkg to NetworkFeaturePkg.

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dec  |  30 
 Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 152 

 Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc  |  30 
 Features/Intel/Network/NetworkFeaturePkg/Include/PostMemory.fdf |  10 ++
 Features/Intel/Network/NetworkFeaturePkg/Include/PreMemory.fdf  |   8 ++
 Features/Intel/Network/NetworkFeaturePkg/Readme.md  | 100 
+
 6 files changed, 330 insertions(+)

diff --git a/Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dec 
b/Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dec
new file mode 100644
index 00..670b76e52f
--- /dev/null
+++ b/Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dec
@@ -0,0 +1,30 @@
+## @file
+# This package provides advanced feature functionality for Network support.
+# This package should only depend on EDK II Core packages, IntelSiliconPkg, 
and MinPlatformPkg.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+  DEC_SPECIFICATION = 0x00010017
+  PACKAGE_NAME  = NetworkFeaturePkg
+  PACKAGE_GUID  = CA1BF91C-8B5E-40C2-9C4C-DD250D2170A9
+  PACKAGE_VERSION   = 0.1
+
+[Includes]
+  Include
+
+[LibraryClasses]
+
+[Guids]
+  gNetworkFeaturePkgTokenSpaceGuid  =  {0x990904ed, 0xb62a, 0x4b46, 
+{0xa2, 0x9d, 0xe4, 0x09, 0xa6, 0x7f, 0x54, 0x68}}
+
+[PcdsFeatureFlag]
+
+gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable|FALSE|BOOLEAN|
+0xA001
diff --git 
a/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc 
b/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc
new file mode 100644
index 00..c59c21ee6c
--- /dev/null
+++ b/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.ds
+++ c
@@ -0,0 +1,152 @@
+## @file
+# This is a build description file for the Network advanced feature.
+# This file should be included into another package DSC file to build this 
feature.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+###
+#
+#
+# Defines Section - statements that will be processed to create a Makefile.
+#
+###
+#
+[Defines]
+!ifndef $(PEI_ARCH)
+  !error "PEI_ARCH must be specified to build this feature!"
+!endif
+!ifndef $(DXE_ARCH)
+  !error "DXE_ARCH must be specified to build this feature!"
+!endif
+
+  !include NetworkPkg/NetworkDefines.dsc.inc
+
+###
+#
+#
+# PCD Section - list of EDK II PCD Entries modified by the feature.
+#
+###
+#
+[PcdsFixedAtBuild]
+  !include NetworkPkg/NetworkPcds.dsc.inc
+
+###
+#
+#
+# Library Class section - list of all Library Classes needed by this feature.
+#
+###
+#
+[LibraryClasses]
+  !include NetworkPkg/NetworkLibs.dsc.inc
+
+  ###
+  # Edk2 Packages
+  ###
+  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
+  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+
+ BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.i
+ nf  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
+  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+
+ FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.i
+ nf  HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
+  IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
+  

Re: [edk2-devel] [edk2-platforms][PATCH V2 29/47] MinPlatformPkg: Add FvAdvancedPreMemory

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: Kubacki, Michael A  
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L 
; Gao, Liming 
Subject: [edk2-platforms][PATCH V2 29/47] MinPlatformPkg: Add 
FvAdvancedPreMemory

This change adds a new firmware volume to MinPlatformPkg called 
FvAdvancedPreMemory. This firmware volume is used to hold advanced feature 
modules that must be available in pre-memory.

Previously, these modules were kept as an uncompressed child FV in FvAdvanced. 
However, in memory constrained environments before permanent memory is 
initialized, it is preferable to have a dedicated firmware volume that can 
simply be installed as a standalone firmware volume to reduce the need for 
creating FV HOBs for other post-memory advanced features if they are not needed 
and to simplify the FV layout and FV installation process.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec   
  |  3 ++
 
Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
 | 42 ++--
 
Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.c
   | 24 ---
 3 files changed, 44 insertions(+), 25 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec 
b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
index 6a765d689d..21013cc87c 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
@@ -168,6 +168,9 @@ SetCacheMtrrLib|Include/Library/SetCacheMtrrLib.h
   
gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityBase|0x|UINT32|0x2010
   
gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecuritySize|0x|UINT32|0x2011
   
gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityOffset|0x|UINT32|0x2012
+
+ gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedPreMemoryBase|0x00
+ 00|UINT32|0x202D
+ gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedPreMemorySize|0x00
+ 00|UINT32|0x202E
+ gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedPreMemoryOffset|0x
+ |UINT32|0x202F
   
gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedBase|0x|UINT32|0x2013
   
gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedSize|0x|UINT32|0x2014
   
gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedOffset|0x|UINT32|0x2015
diff --git 
a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
 
b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
index 4d96c9cf31..1ce3034fcc 100644
--- 
a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/
+++ PeiReportFvLib.inf
@@ -1,7 +1,7 @@
 ### @file
 # Component information file for the Report Firmware Volume (FV) library.
 #
-# Copyright (c) 2018, Intel Corporation. All rights reserved.
+# Copyright (c) 2018 - 2019, Intel Corporation. All rights 
+reserved.
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -30,22 +30,24 @@
   PeiReportFvLib.c
 
 [Pcd]
-  gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode   ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMBase  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspUBase  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspUSize  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryBase## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootBase  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootSize  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootBase## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootSize## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityBase  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecuritySize  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedBase  ## CONSUMES
-  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedSize  ## CONSUMES
+  gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## CONSUMES
+  gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress   ## CONSUMES
+  gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize  ## CONSUMES
+  gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMBase## CONSUMES
+  

Re: [edk2-devel] [edk2-platforms][PATCH V2 22/47] Features/Intel/AdvancedFeaturePkg: Add package

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 22/47] 
Features/Intel/AdvancedFeaturePkg: Add package

This change adds AdvancedFeaturePkg to the Features/Intel directory. 
AdvancedFeaturePkg is a special package that is located at the root level of 
Features/Intel.

All advanced features can be built using the AdvancedFeaturePkg build. To build 
all advanced features, follow the instructions in the Feature/Intel/Readme.md 
file. The actual build is performed by executing the following command in the 
Features/Intel directory:

"build -p AdvancedFeaturePkg/AdvancedFeaturePkg.dsc -a IA32 -a X64"

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec   | 31 +++
 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc   | 51 
++
 Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc | 56 

 3 files changed, 138 insertions(+)

diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec 
b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec
new file mode 100644
index 00..797a1eeb98
--- /dev/null
+++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec
@@ -0,0 +1,31 @@
+## @file
+#  Advanced Feature Package build declaration file.
+#
+# Advanced features allow a board package to be extended with advanced 
functionality.
+#
+# This package should not contain any specific advanced features. The package 
has two responsibilities:
+# 1. Present a consolidated and simplified view of all available advanced 
features to board packages.
+# 2. Provide a simple, single package build for all available advanced 
features.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights 
+reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # ## 
+[Defines] DEC_SPECIFICATION = 0x00010017
+PACKAGE_NAME  = AdvancedFeaturePkg
+PACKAGE_VERSION   = 0.1
+PACKAGE_GUID  = 086F1F68-76CD-4F40-A712-06939A0BDD12
+
+[Includes]
+Include
+
+[Guids]
+gAdvancedFeaturePkgTokenSpaceGuid =  {0xa8514688, 0x6693, 0x4ab5, 
{0xaa, 0xc8, 0xcc, 0xa9, 0x8d, 0xde, 0x90, 0xe1}}
+
+[PcdsFeatureFlag]
diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc 
b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
new file mode 100644
index 00..50c0e81048
--- /dev/null
+++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
@@ -0,0 +1,51 @@
+## @file
+#  Advanced Feature Package build description file.
+#
+# Advanced features allow a board package to be extended with advanced 
functionality.
+#
+# This package should not contain any specific advanced features. The package 
has two responsibilities:
+# 1. Present a consolidated and simplified view of all available advanced 
features to board packages.
+# 2. Provide a simple, single package build for all available advanced 
features.
+#
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights 
+reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+###
+#
+#
+# Defines Section - statements that will be processed to create a Makefile.
+#
+###
+#
+[Defines]
+  PLATFORM_NAME   = AdvancedFeaturePkg
+  PLATFORM_GUID   = 5E4C05BC-C5F0-4843-BAE1-3AAFE269DB8F
+  PLATFORM_VERSION= 0.1
+  DSC_SPECIFICATION   = 0x00010005
+  OUTPUT_DIRECTORY= Build/AdvancedFeaturePkg
+  SUPPORTED_ARCHITECTURES = IA32|X64
+  BUILD_TARGETS   = DEBUG|RELEASE
+  SKUID_IDENTIFIER= DEFAULT
+  PEI_ARCH= IA32
+  DXE_ARCH= X64
+
+###
+#
+#
+# Advanced Feature Enable section - all advanced features are enabling for the
+#   AdvancedFeaturePkg build.
+#
+###
+#
+[PcdsFeatureFlag]
+  gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable|TRUE
+  gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable  |TRUE
+  gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable|TRUE
+  gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable  |TRUE
+  gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable  |TRUE
+  

Re: [edk2-devel] [edk2-platforms][PATCH V2 44/47] DebugFeaturePkg: Remove the ACPI Debug feature

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 6:19 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Gao, Liming 
Subject: [edk2-devel] [edk2-platforms][PATCH V2 44/47] DebugFeaturePkg: Remove 
the ACPI Debug feature

Removes the ACPI Debug feature from DebugFeaturePkg. The feature does not 
follow the advanced feature design. The feature has been moved to 
Features/Intel/Debugging/AcpiDebugFeaturePkg.

Cc: Eric Dong 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc|  10 -
 Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebugDxe.inf |  57 ---  
Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf |  59 ---
 Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c  | 523 

 Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.asl| 103 
 Platform/Intel/DebugFeaturePkg/AcpiDebug/Readme.txt   |  31 --
 6 files changed, 783 deletions(-)

diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc 
b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
index efe705bd76..c43dd63a06 100644
--- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
+++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
@@ -71,14 +71,6 @@
   
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
   UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
 
-[LibraryClasses.common.DXE_SMM_DRIVER]
-  ###
-  # Edk2 Packages
-  ###
-  HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
-  
MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf
-  
SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf
-
 
###
 #
 # Components Section - list of the modules and components that will be 
processed by compilation @@ -113,8 +105,6 @@
   
DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd/Usb3DebugPortParameterLibPcd.inf
 
   # Add components here that should be included in the package build.
-  DebugFeaturePkg/AcpiDebug/AcpiDebugDxe.inf
-  DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
 
 [BuildOptions]
   *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES diff --git 
a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebugDxe.inf 
b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebugDxe.inf
deleted file mode 100644
index 7473126b11..00
--- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebugDxe.inf
+++ /dev/null
@@ -1,57 +0,0 @@
-### @file
-# Component description file for Acpi debug module.
-#
-# Copyright (c) 2019, Intel Corporation. All rights reserved. -# -# 
SPDX-License-Identifier: BSD-2-Clause-Patent -# -###
-
-[Defines]
-  INF_VERSION= 0x00010005
-  BASE_NAME  = AcpiDebugDxe
-  FILE_GUID  = EC98FF95-242C-4513-B1BC-69FA24111C58
-  MODULE_TYPE= DXE_DRIVER
-  VERSION_STRING = 1.0
-  ENTRY_POINT= InitializeAcpiDebugDxe
-#
-# The following information is for reference only and not required by the 
build tools.
-#
-#  VALID_ARCHITECTURES   = IA32 X64 IPF
-#
-
-[LibraryClasses]
-  BaseLib
-  BaseMemoryLib
-  UefiBootServicesTableLib
-  UefiDriverEntryPoint
-  DebugLib
-  PcdLib
-  DxeServicesLib
-
-[Packages]
-  MdePkg/MdePkg.dec
-  MdeModulePkg/MdeModulePkg.dec
-  DebugFeaturePkg/DebugFeaturePkg.dec
-
-[Pcd]
-  gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugEnable  ## CONSUMES
-  gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize  ## CONSUMES
-  gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugAddress ## PRODUCES
-
-[Sources]
-  AcpiDebug.c
-  AcpiDebug.asl
-
-[Protocols]
-  gEfiAcpiTableProtocolGuid ## CONSUMES
-  gEfiSmmBase2ProtocolGuid  ## CONSUMES # only for SMM version
-  gEfiSmmSwDispatch2ProtocolGuid## CONSUMES # only for SMM version
-  gEfiSmmEndOfDxeProtocolGuid   ## NOTIFY # only for SMM version
-
-[Guids]
-  gEfiEndOfDxeEventGroupGuid## CONSUMES ## Event
-
-[Depex]
-  gEfiAcpiTableProtocolGuid
-
diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf 
b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
deleted file mode 100644
index 679f9eb014..00
--- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
+++ /dev/null
@@ -1,59 +0,0 @@
-### @file
-# Component description file for Acpi Debug module.
-#
-# Copyright (c) 2019, Intel Corporation. All rights reserved. -# -# 
SPDX-License-Identifier: BSD-2-Clause-Patent -# -###
-
-[Defines]
-  INF_VERSION= 0x00010005
-  BASE_NAME  = AcpiDebugSmm
-  FILE_GUID  = 9069C144-0A7E-41ef-9C07-418BCA9BF939
-  MODULE_TYPE= DXE_SMM_DRIVER
-  VERSION_STRING = 

Re: [edk2-devel] [edk2-platforms][PATCH V2 16/47] Features/Intel/SmbiosFeaturePkg: Add initial package

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 16/47] 
Features/Intel/SmbiosFeaturePkg: Add initial package

Adds a new feature package for the SMBIOS feature.

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec 
   | 172 
 Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc
   | 115 +
 Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dsc 
   |  30 
 Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory.fdf   
   |  10 ++
 Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PreMemory.fdf
   |   8 +
 
Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasicDxe.inf
   |  83 ++
 Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasic.h 
   |  45 +
 
Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasicEntryPoint.c
  | 125 ++
 
Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/Type0BiosVendorFunction.c
|  81 +
 
Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/Type1SystemManufacturerFunction.c
| 114 +
 
Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/Type2BaseBoardManufacturerFunction.c
 | 131 +++
 
Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/Type32BootInformationFunction.c
  |  56 +++
 
Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/Type3ChassisManufacturerFunction.c
   | 125 ++
 Features/Intel/SystemInformation/SmbiosFeaturePkg/Readme.md
   |  96 +++
 14 files changed, 1191 insertions(+)

diff --git 
a/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec 
b/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec
new file mode 100644
index 00..c06a87aad0
--- /dev/null
+++ b/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec
@@ -0,0 +1,172 @@
+## @file
+# This package provides advanced feature functionality for System Management 
BIOS (SMBIOS).
+# This package should only depend on EDK II Core packages, IntelSiliconPkg, 
and MinPlatformPkg.
+#
+# The DEC files are used by the utilities that parse DSC and
+# INF files to generate AutoGen.c and AutoGen.h files
+# for the build infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+  DEC_SPECIFICATION = 0x00010017
+  PACKAGE_NAME  = SmbiosFeaturePkg
+  PACKAGE_GUID  = 8CCEE569-02AD-4844-8725-F4C7966E320A
+  PACKAGE_VERSION   = 0.1
+
+[Includes]
+  Include
+
+[LibraryClasses]
+
+[Guids]
+  gSmbiosFeaturePkgTokenSpaceGuid  =  {0xc1530658, 0xe234, 0x4c13, {0xb6, 
0x82, 0xd3, 0x87, 0x84, 0xf1, 0xd7, 0x16}}
+
+[PcdsFeatureFlag]
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable|FALSE|BOOLEAN|0xA001
+
+[PcdsDynamic, PcdsDynamicEx]
+  #
+  # SMBIOS Type 0 BIOS Information
+  #
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation|{0x0}|SMBIOS_TABLE_TYPE0|0xD001
 {
+
+  IndustryStandard/SmBios.h
+
+  MdePkg/MdePkg.dec
+  SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec
+  }
+  gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.Vendor|0x1
+  gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosVersion|0x2
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosSegment|0xF000
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosReleaseDate|0x3
+  gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosSize|0xFF
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosCharacteristics.PciIsSupported|1
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosCharacteristics.PlugAndPlayIsSupported|1
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosCharacteristics.BiosIsUpgradable|1
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosCharacteristics.BiosShadowingAllowed|1
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosCharacteristics.BootFromCdIsSupported|1
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosCharacteristics.SelectableBootIsSupported|1
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation.BiosCharacteristics.EDDSpecificationIsSupported|1
+  

Re: [edk2-devel] [edk2-platforms][PATCH V2 38/47] SimicsOpenBoardPkg: Use new advanced feature refactor

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Wei, David Y ; Agyeman, Prince 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 38/47] SimicsOpenBoardPkg: Use 
new advanced feature refactor

Updates advanced feature references in SimicsOpenBoardPkg to the new advanced 
feature packages in Features/Intel. Previously, the advanced features in 
Platform/Intel were used.

SimicsOpenBoardPkg currently uses the SMBIOS and Network advanced features. 
These are the same features used by the package prior to the advanced feature 
refactor.

Note that SimicsOpenBoardPkg depends upon these advanced features even when the 
boot stage is less than the advanced feature stage.

This bug was not fixed in this commit and is filed to be resolved in the 
following Bugzilla item:
  https://bugzilla.tianocore.org/show_bug.cgi?id=2165

Cc: Wei David Y 
Cc: Agyeman Prince 
Signed-off-by: Michael Kubacki 
---
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc  | 11 
++-
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc   | 12 
++--
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf  | 10 
++
 Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf |  1 
-
 4 files changed, 10 insertions(+), 24 deletions(-)

diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc 
b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
index 2f287a4ca4..7576648d57 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
@@ -42,8 +42,9 @@
   DEFINE NETWORK_ISCSI_ENABLE   = FALSE
   DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
 
+  !include 
+ AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.d
+ sc
   !include $(PROJECT)/OpenBoardPkgPcd.dsc
-  !include NetworkPkg/NetworkDefines.dsc.inc
+  !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
 
 

 #
@@ -80,7 +81,6 @@
 #is completed
 [Components.X64]
 !include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc
-!include AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc
 
 ###
 # Build Option Includes
@@ -285,13 +285,6 @@
   $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf
 !endif
 
-  ###
-  # Advanced Feature Package
-  ###
-!if gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosEnable == TRUE
-  AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf
-!endif
-
   ###
   # Board Package
   ###
diff --git 
a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc 
b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
index cd95755f91..cd98d09f01 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds
+++ c
@@ -96,8 +96,8 @@
   ##
   # Advanced Feature Configuration
   ##
-  gAdvancedFeaturePkgTokenSpaceGuid.PcdNetworkEnable|TRUE
-  gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosEnable|TRUE
+  gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable|TRUE
+  gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable|TRUE
 
 [PcdsFeatureFlag.X64]
   ##
@@ -252,10 +252,10 @@
   ##
   # Advanced Feature Configuration
   ##
-  
gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0StringBiosReleaseDate|"2019-08-09"
-  gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0StringBiosVersion|"Ver.1.0.0"
-  gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType1StringProductName|"QSP UEFI 
BIOS"
-  gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType2StringProductName|"QSP UEFI 
BIOS"
+  
gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0StringBiosReleaseDate|"2019-08-09"
+  gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0StringBiosVersion|"Ver.1.0.0"
+  gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType1StringProductName|"QSP UEFI 
BIOS"
+  gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType2StringProductName|"QSP UEFI 
BIOS"
 
 [PcdsDynamicExDefault]
   ##
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf 
b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
index ef6b35c92f..e0a1daddee 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
@@ -155,7 +155,7 @@ INF  

Re: [edk2-devel] [edk2-platforms][PATCH V2 14/47] Features/Intel/IpmiFeaturePkg: Add libraries

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 14/47] 
Features/Intel/IpmiFeaturePkg: Add libraries

This change adds the libraries required for the IPMI feature to IpmiFeaturePkg.

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec   
   |   9 +
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc  
   |  72 +
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc   
   |   5 +
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
   |  32 +++
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNull.inf
 |  26 ++
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiCommandLib.h
| 235 +
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiPlatformHookLib.h
   |  23 ++
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
 | 248 ++
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
 | 101 +++
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
 | 275 
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
   |  81 ++
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNull.c
   |  36 +++
 12 files changed, 1143 insertions(+)

diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
index dfae88..4c43fc5f49 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d
+++ ec
@@ -22,6 +22,15 @@
 [Includes]
   Include
 
+[LibraryClasses]
+  ## @libraryclass  Provides services to send IPMI commands.
+  #
+  IpmiCommandLib|Include/Library/IpmiCommandLib.inf
+
+  ## @libraryclass  Provides an API for platform-specific IPMI hooks.
+  #
+  IpmiCommandLib|Include/Library/IpmiPlatformHookLib.h
+
 [Guids]
   gIpmiFeaturePkgTokenSpaceGuid  =  {0xc05283f6, 0xd6a8, 0x48f3, {0x9b, 0x59, 
0xfb, 0xca, 0x71, 0x32, 0x0f, 0x12}}
 
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
new file mode 100644
index 00..c6a385108b
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat
+++ ure.dsc
@@ -0,0 +1,72 @@
+## @file
+# This is a build description file for the Intelligent Platform Management 
Interface (IPMI) advanced feature.
+# This file should be included into another package DSC file to build this 
feature.
+#
+# The DEC files are used by the utilities that parse DSC and # INF 
+files to generate AutoGen.c and AutoGen.h files # for the build 
+infrastructure.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved. # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+###
+#
+#
+# Defines Section - statements that will be processed to create a Makefile.
+#
+###
+#
+[Defines]
+
+###
+#
+#
+# Library Class section - list of all Library Classes needed by this feature.
+#
+###
+#
+[LibraryClasses]
+  ###
+  # Edk2 Packages
+  ###
+  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+
+BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.in
+f
+  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
+  IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf
+
+###
+#
+#
+# Component section - list of all components that need built for this feature.
+#
+# Note: The EDK II DSC file is not used to specify how compiled binary images 
get placed
+#   into firmware volume images. This section is just a list of modules to 
compile from
+#   source into UEFI-compliant binaries.
+#   It is the FDF file that contains 

Re: [edk2-devel] [edk2-platforms][PATCH V2 41/47] Platform/Intel/AdvancedFeaturePkg: Remove the IPMI feature

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 6:19 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 41/47] 
Platform/Intel/AdvancedFeaturePkg: Remove the IPMI feature

Removes the IPMI feature from AdvancedFeaturePkg. The feature does
not follow the advanced feature design. The feature has been moved
to Features/Intel/OutOfBandManagement/IpmiFeaturePkg.

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec   
|  11 -
 Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc   
|  59 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf 
|  48 
 Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf 
|  34 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.inf  
|  37 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.inf  
|  37 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.inf 
|  35 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.inf
|  34 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.inf
|  32 ---
 
Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLib.inf
   |  32 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.inf 
|  28 --
 
Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNull.inf
 |  29 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.inf 
|  34 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.inf 
|  38 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib.h
| 235 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiPlatformHookLib.h   
|  23 --
 Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.c   
| 257 --
 Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c   
| 236 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c
| 236 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c
|  84 --
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c   
|  67 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c  
| 150 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c  
|  96 ---
 
Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
 | 248 --
 
Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
 | 101 ---
 
Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
 | 275 
 
Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
   |  81 --
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c   
|  45 
 
Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNull.c
   |  36 ---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c   
| 112 
 Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c   
| 164 
 Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcSsdt/BmcSsdt.asl 
|  28 --
 Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcSsdt/IpmiOprRegions.asi  
|  58 -
 33 files changed, 3020 deletions(-)

diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec 
b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec
index 44e5de64db..4f8300d145 100644
--- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec
+++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec
@@ -22,7 +22,6 @@ PACKAGE_GUID = 290127D9-ABED-4DD8-A35D-73DCB4261BCB
 
 [Includes]
 Include
-Ipmi/Include
 
 [Guids]
 gAdvancedFeaturePkgTokenSpaceGuid =  {0xa8514688, 0x6693, 0x4ab5, 
{0xaa, 0xc8, 0xcc, 0xa9, 0x8d, 0xde, 0x90, 0xe1}}
@@ -138,16 +137,6 @@ 

Re: [edk2-devel] [edk2-platforms][PATCH V2 15/47] Features/Intel/IpmiFeaturePkg: Add modules

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 15/47] 
Features/Intel/IpmiFeaturePkg: Add modules

This change adds the modules for the IPMI feature to
IpmiFeaturePkg.

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec   
  |   8 +
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc  
  |  78 +-
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc   
  |   2 +
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf   
  |   8 +
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf
  |   3 +
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf  
  |  47 
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf  
  |  33 +++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf   
  |  37 +++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf   
  |  37 +++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf  
  |  35 +++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf 
  |  34 +++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf 
  |  32 +++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.inf  
  |  33 +++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.inf  
  |  37 +++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
  | 257 
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.c
  | 236 ++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.c 
  | 236 ++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.c 
  |  84 +++
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.c
  |  67 +
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.c   
  | 150 
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.c   
  |  96 
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.c
  | 112 +
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.c
  | 164 +
 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcSsdt/BmcSsdt.asl  
  |  28 +++
 
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcSsdt/IpmiOprRegions.asi
 |  58 +
 25 files changed, 1909 insertions(+), 3 deletions(-)

diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
index 4c43fc5f49..1426496d28 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
@@ -36,3 +36,11 @@
 
 [PcdsFeatureFlag]
   gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable|FALSE|BOOLEAN|0xA001
+
+[PcdsFixedAtBuild]
+  gIpmiFeaturePkgTokenSpaceGuid.PcdMaxSOLChannels|3|UINT8|0xF001
+
+[PcdsDynamic, PcdsDynamicEx]
+  gIpmiFeaturePkgTokenSpaceGuid.PcdFRB2EnabledFlag|TRUE|BOOLEAN|0xD001
+  gIpmiFeaturePkgTokenSpaceGuid.PcdFRBTimeoutValue|360|UINT16|0xD002
+  gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0xD003
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
index c6a385108b..a82f18a68c 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
@@ -18,6 +18,12 @@
 #
 

 [Defines]
+!ifndef $(PEI_ARCH)
+  !error "PEI_ARCH must be specified to build this feature!"
+!endif
+!ifndef $(DXE_ARCH)
+  !error "DXE_ARCH must be specified to build this feature!"
+!endif
 
 

 #
@@ -32,6 +38,36 @@
   BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf
   DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
   IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf
+  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
+  TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
+
+  #
+  

Re: [edk2-devel] [edk2-platforms][PATCH V2 04/47] Features/Intel: Add Readme.md

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: Kubacki, Michael A  
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Bi, Dandan ; Chaganty, Rangasai V 
; Chiu, Chasel ; Wei, 
David Y ; Desimone, Nathaniel L 
; Dong, Eric ; Gao, Liming 
; Agyeman, Prince 
Subject: [edk2-platforms][PATCH V2 04/47] Features/Intel: Add Readme.md

This change adds the initial Readme.md to the root of the Features/ Intel 
directory. The features are maintained in an Intel directory because they are 
not tested on other systems. If there is interest to support a feature on 
systems other than Intel, the feature should be tested on those other systems 
and the feature can be promoted above the Intel directory.

This Readme.md is the most important file in the Features/Intel tree as it 
provides the desired attributes and definition of advanced features, the 
advanced feature source layout, and the new feature creation checklist. This is 
the primary documentation file for new users to understand advanced features.

Cc: Dandan Bi 
Cc: Sai Chaganty 
Cc: Chasel Chiu 
Cc: Wei David Y 
Cc: Nate DeSimone 
Cc: Eric Dong 
Cc: Liming Gao 
Cc: Agyeman Prince 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/Readme.md | 236 
 1 file changed, 236 insertions(+)

diff --git a/Features/Intel/Readme.md b/Features/Intel/Readme.md new file mode 
100644 index 00..9729f90a41
--- /dev/null
+++ b/Features/Intel/Readme.md
@@ -0,0 +1,236 @@
+# **EDK II Minimum Platform Firmware Advanced Features for Intel 
+Platforms**
+
+In the EDK II Minimum Platform, advanced features are non-essential 
+features. Essential features are those required to achieve an earlier 
+boot stage (Stage I through Stage V). The Minimum Platform boot stages 
+are defined in the [EDK II Minimum Platform Draft 
Specification](https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/).
 A brief overview is also provided in the 
[Platform/Intel/Readme.md](https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/Readme.md).
+
+An advanced feature must be implemented as highly cohesive and 
+stand-alone software to only support a specific feature. Advanced features are 
the primary method to extend platform firmware capabilities in a modular 
fashion.
+
+If you would like to quickly get started creating a new advanced 
+feature, you can jump ahead to the [Add New Advanced Feature 
+Checklist](#Add-New-Advanced-Feature-Checklist) and reference other sections 
of this document as needed.
+
+## Overview
+
+### Advanced Feature Attributes
+Advanced features should be:
+* _Cohesive_, the feature should not contain any functionality unrelated to 
the feature.
+* _Complete_, the feature must have a complete design that minimizes 
+dependencies. A feature package cannot directly
+  depend on another feature package.
+* _Easy to Integrate_, the feature should expose well-defined software 
interfaces to use and configure the feature.
+  * It should also present a set of simple and well-documented standard 
+EDK II configuration options such as PCDs to
+  configure the feature.
+  * In general, features should be self-contained and started by the 
dispatcher. The board firmware should
+be required to perform as few steps as possible to enable the feature.
+  * All features are required to have a feature enable PCD 
(`PcdFeatureEnable`). Any effort to enable the feature
+besides this PCD should be carefully considered. Default configuration 
values should apply to the common case.
+* _Portable_, the feature is not allowed to depend on other advanced 
+feature or board source code packages. For example,
+  if Feature A depends on output Feature B, a board integration module 
+should use a generic interface in Feature A
+  to get the output and pass it to a generic interface in Feature B. 
+Structures should not be shared between feature
+  packages. Most structures should be defined in a common package such 
+as MdePkg if the structure is industry standard,
+  IntelSiliconPkg if the structure is specific to Intel silicon 
+initialization, etc. Feature-specific structures are
+  of course allowed to be defined within a feature package and used by 
libraries and modules in that package.
+* _Self Documenting_, the feature should follow software best practices 
+to allow others to debug the code and
+  contribute changes. In addition to source code, advanced features 
+must have a Readme.md with sufficient
+  information for a newcomer to understand the feature.
+* _Single Instance_, the feature should not have more than one instance 
+of a source solution. If an existing feature
+  package does not solve a specific instance of a problem for the 
+feature, the feature package should be re-worked
+  to consider new requirements instead of duplicating feature code.
+
+  Features should be written for a specific feature technology. Outside 
+ of technology restrictions, the feature  should not make 

Re: [edk2-devel] [edk2-platforms][PATCH V2 06/47] Features/Intel/OutOfBandManagement: Add Readme.md

[Nate DeSimone]

Reviewed-by: Nate DeSimone 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Kubacki, Michael 
A
Sent: Wednesday, November 27, 2019 5:06 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming 

Subject: [edk2-devel] [edk2-platforms][PATCH V2 06/47] 
Features/Intel/OutOfBandManagement: Add Readme.md

Adds the Readme.md file to briefly explain the types of features supported in 
the OutOfBandManagement feature domain directory.

Cc: Sai Chaganty 
Cc: Liming Gao 
Signed-off-by: Michael Kubacki 
---
 Features/Intel/OutOfBandManagement/Readme.md | 8 
 1 file changed, 8 insertions(+)

diff --git a/Features/Intel/OutOfBandManagement/Readme.md 
b/Features/Intel/OutOfBandManagement/Readme.md
new file mode 100644
index 00..dc526029a7
--- /dev/null
+++ b/Features/Intel/OutOfBandManagement/Readme.md
@@ -0,0 +1,8 @@
+# **EDK II Minimum Platform Firmware Out-of-Band Management Advanced 
+Features**
+
+This feature domain directory contains out-of-band management related advanced 
features.
+
+Features may be added to this domain whose primary role and 
+responsibility is related to out-of-band management. These are features 
+that typically interface with an external controller to enable system 
+maintenance operations such as monitoring, logging, and recovery control 
functions independent of the main processors, host CPU firmware (BIOS), and 
host operating system. An out-of-band controller is usually available when the 
system is in a powered down state.
--
2.16.2.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51676): https://edk2.groups.io/g/devel/message/51676
Mute This Topic: https://groups.io/mt/63456833/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 57/79] OvmfPkg/Csm: Fix various typos

[David Woodhouse]

On Tue, 2019-12-03 at 21:50 +0100, Laszlo Ersek wrote:
> On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> > From: Antoine Coeur 
> > 
> > Fix various typos in documentation, comments and strings.
> > 
> > Cc: Jordan Justen 
> > Cc: Laszlo Ersek 
> > Cc: Ard Biesheuvel 
> > Reviewed-by: Philippe Mathieu-Daude 
> > Signed-off-by: Philippe Mathieu-Daude 
> > ---
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf   |  2 
> > +-
> >   OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h  | 10 
> > +-
> >   OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h |  8 
> > 
> >   OvmfPkg/Csm/Include/Framework/BootScript.h  |  2 
> > +-
> >   OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h |  2 
> > +-
> >   OvmfPkg/Csm/Include/Protocol/IsaIo.h|  2 
> > +-
> >   OvmfPkg/Csm/Include/Protocol/LegacyBios.h   |  6 
> > +++---
> >   OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h   |  4 
> > ++--
> >   OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h  |  2 
> > +-
> >   OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h |  8 
> > 
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h|  4 
> > ++--
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h |  2 
> > +-
> >   OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c  |  4 
> > ++--
> >   OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c  |  6 
> > +++---
> >   OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c  |  6 
> > +++---
> >   OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c   |  4 
> > ++--
> >   OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c   |  8 
> > 
> >   OvmfPkg/Csm/LegacyBiosDxe/Thunk.c   |  4 
> > ++--
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c| 14 
> > +++---
> >   OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 
> > +-
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni   |  8 
> > 
> >   21 files changed, 62 insertions(+), 62 deletions(-)
> 
> CC'ing David -- David is the designated Reviewer for OvmfPkg/Csm/, based
> on "Maintainers.txt".
> 
> Conditional on David's R-b, you can add:
> 
> Acked-by: Laszlo Ersek 

Looks sane to me, except there's one line in which you make a
correction but still leave BIOS spelled in lower case as 'bios'.
Shouldn't that have capitals?

Reviewed-by: David Woodhouse 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51674): https://edk2.groups.io/g/devel/message/51674
Mute This Topic: https://groups.io/mt/65928418/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



smime.p7s
Description: S/MIME cryptographic signature

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Add list-repos command

[Nate DeSimone]

list-repos lists the git repos used by all projects
and which branches those projects use.

Cc: Ashley E Desimone 
Signed-off-by: Nate DeSimone 
---
 edkrepo/commands/arguments/list_repos_args.py |  16 ++
 edkrepo/commands/humble/__init__.py   |   8 +
 edkrepo/commands/humble/list_repos_humble.py  |  26 ++
 edkrepo/commands/list_repos_command.py| 243 ++
 setup.py  |   5 +-
 5 files changed, 295 insertions(+), 3 deletions(-)
 create mode 100644 edkrepo/commands/arguments/list_repos_args.py
 create mode 100644 edkrepo/commands/humble/__init__.py
 create mode 100644 edkrepo/commands/humble/list_repos_humble.py
 create mode 100644 edkrepo/commands/list_repos_command.py

diff --git a/edkrepo/commands/arguments/list_repos_args.py 
b/edkrepo/commands/arguments/list_repos_args.py
new file mode 100644
index 000..6ff9b9c
--- /dev/null
+++ b/edkrepo/commands/arguments/list_repos_args.py
@@ -0,0 +1,16 @@
+#!/usr/bin/env python3
+#
+## @file
+# list_repos_args.py
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+''' Contains the help and description strings for arguments in the
+list-repos command meta data.
+'''
+
+COMMAND_DESCRIPTION = 'Lists the git repos used by available projects and the 
branches that are used.'
+ARCHIVED_HELP = 'Include a listing of archived projects.'
+REPOS_HELP = 'Only show the given subset of repos instead of all repos.'
diff --git a/edkrepo/commands/humble/__init__.py 
b/edkrepo/commands/humble/__init__.py
new file mode 100644
index 000..dea6eb4
--- /dev/null
+++ b/edkrepo/commands/humble/__init__.py
@@ -0,0 +1,8 @@
+#!/usr/bin/env python3
+#
+## @file
+# __init__.py
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
diff --git a/edkrepo/commands/humble/list_repos_humble.py 
b/edkrepo/commands/humble/list_repos_humble.py
new file mode 100644
index 000..bbb05a7
--- /dev/null
+++ b/edkrepo/commands/humble/list_repos_humble.py
@@ -0,0 +1,26 @@
+#!/usr/bin/env python3
+#
+## @file
+# list_repos_humble.py
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+'''
+Contains user visible strings printed by the list-repos command.
+'''
+
+from colorama import Fore
+from colorama import Style
+
+BRANCHES = 'Branches:'
+BRANCH_FORMAT_STRING = '  {}{}{{}}{}'.format(Fore.BLUE, Style.BRIGHT, 
Style.RESET_ALL)
+COMBO_FORMAT_STRING = '{{}}  {}{}({{}}){}'.format(Fore.CYAN, Style.BRIGHT, 
Style.RESET_ALL)
+DEFAULT_COMBO_FORMAT_STRING = '{{}} {}{}*({{}})*{}'.format(Fore.GREEN, 
Style.BRIGHT, Style.RESET_ALL)
+MANIFEST_DIRECTORY = 'Manifest directory:'
+PROJECT_NAME_FORMAT_STRING = '{}{}{{}}{}:'.format(Fore.YELLOW, Style.BRIGHT, 
Style.RESET_ALL)
+REPOSITORIES = 'Repositories:'
+REPO_NAME_AND_URL = '{}{}{{}}{} - [{}{}{{}}{}]'.format(Fore.MAGENTA, 
Style.BRIGHT, Style.RESET_ALL, Fore.RED, Style.BRIGHT, Style.RESET_ALL)
+REPO_NAME_NOT_FOUND = 'repo_name not found'
+REPO_NOT_FOUND_IN_MANIFEST = 'Repo {} not found in any manifest file'
diff --git a/edkrepo/commands/list_repos_command.py 
b/edkrepo/commands/list_repos_command.py
new file mode 100644
index 000..9035993
--- /dev/null
+++ b/edkrepo/commands/list_repos_command.py
@@ -0,0 +1,243 @@
+#!/usr/bin/env python3
+#
+## @file
+# list_repos_command.py
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+import collections
+import os
+
+#from git import Repo
+from colorama import Fore, Style
+
+# Our modules
+from edkrepo.commands.edkrepo_command import EdkrepoCommand
+from edkrepo.commands.edkrepo_command import ColorArgument
+import edkrepo.commands.arguments.list_repos_args as arguments
+import edkrepo.commands.humble.list_repos_humble as humble
+from edkrepo.common.common_repo_functions import pull_latest_manifest_repo
+from edkrepo.common.edkrepo_exception import 
EdkrepoInvalidParametersException, EdkrepoManifestInvalidException
+from edkrepo.common.ui_functions import init_color_console
+from edkrepo_manifest_parser.edk_manifest import CiIndexXml, ManifestXml
+
+class ListReposCommand(EdkrepoCommand):
+def __init__(self):
+super().__init__()
+self.repo_names = None
+
+def get_metadata(self):
+metadata = {}
+metadata['name'] = 'list-repos'
+metadata['help-text'] = arguments.COMMAND_DESCRIPTION
+args = []
+metadata['arguments'] = args
+args.append({'name': 'repos',
+ 'positional': False,
+ 'required': False,
+ 'action': 'store',
+ 'nargs': '+',
+ 'help-text': arguments.REPOS_HELP})
+args.append({'name': 'archived',
+ 'short-name': 'a',
+ 'positional': False,
+ 

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add list-repos command

[Desimone, Ashley E]

Just a few comments:

edkrepo.commands.humble needs to be added to setup.py otherwise the 
import will not resolve.
 #length = len(max(branches, key=len)) .ljust(length) on line 101 of 
list_repos_command.py should either be uncommented or removed.

Thanks,
Ashley

-Original Message-
From: Desimone, Nathaniel L 
Sent: Tuesday, November 26, 2019 8:37 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E 
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add list-repos command

list-repos lists the git repos used by all projects and which branches those 
projects use.

Cc: Ashley E Desimone 
Signed-off-by: Nate DeSimone 
---
 edkrepo/commands/arguments/list_repos_args.py |  16 ++
 edkrepo/commands/humble/__init__.py   |   8 +
 edkrepo/commands/humble/list_repos_humble.py  |  26 +++
 edkrepo/commands/list_repos_command.py| 218 ++
 4 files changed, 268 insertions(+)
 create mode 100644 edkrepo/commands/arguments/list_repos_args.py
 create mode 100644 edkrepo/commands/humble/__init__.py
 create mode 100644 edkrepo/commands/humble/list_repos_humble.py
 create mode 100644 edkrepo/commands/list_repos_command.py

diff --git a/edkrepo/commands/arguments/list_repos_args.py 
b/edkrepo/commands/arguments/list_repos_args.py
new file mode 100644
index 000..6ff9b9c
--- /dev/null
+++ b/edkrepo/commands/arguments/list_repos_args.py
@@ -0,0 +1,16 @@
+#!/usr/bin/env python3+#+## @file+# list_repos_args.py+#+# Copyright 
+(c) 2019, Intel Corporation. All rights reserved.+# 
+SPDX-License-Identifier: BSD-2-Clause-Patent+#++''' Contains the help 
+and description strings for arguments in the+list-repos command meta 
+data.+'''++COMMAND_DESCRIPTION = 'Lists the git repos used by available 
+projects and the branches that are used.'+ARCHIVED_HELP = 'Include a 
+listing of archived projects.'+REPOS_HELP = 'Only show the given subset 
+of repos instead of all repos.'diff --git 
+a/edkrepo/commands/humble/__init__.py 
+b/edkrepo/commands/humble/__init__.py
new file mode 100644
index 000..dea6eb4
--- /dev/null
+++ b/edkrepo/commands/humble/__init__.py
@@ -0,0 +1,8 @@
+#!/usr/bin/env python3+#+## @file+# __init__.py+#+# Copyright (c) 2019, 
+Intel Corporation. All rights reserved.+# SPDX-License-Identifier: 
+BSD-2-Clause-Patent+#diff --git 
+a/edkrepo/commands/humble/list_repos_humble.py 
+b/edkrepo/commands/humble/list_repos_humble.py
new file mode 100644
index 000..bbb05a7
--- /dev/null
+++ b/edkrepo/commands/humble/list_repos_humble.py
@@ -0,0 +1,26 @@
+#!/usr/bin/env python3+#+## @file+# list_repos_humble.py+#+# Copyright (c) 
2019, Intel Corporation. All rights reserved.+# SPDX-License-Identifier: 
BSD-2-Clause-Patent+#++'''+Contains user visible strings printed by the 
list-repos command.+'''++from colorama import Fore+from colorama import 
Style++BRANCHES = 'Branches:'+BRANCH_FORMAT_STRING = '  
{}{}{{}}{}'.format(Fore.BLUE, Style.BRIGHT, 
Style.RESET_ALL)+COMBO_FORMAT_STRING = '{{}}  
{}{}({{}}){}'.format(Fore.CYAN, Style.BRIGHT, 
Style.RESET_ALL)+DEFAULT_COMBO_FORMAT_STRING = '{{}} 
{}{}*({{}})*{}'.format(Fore.GREEN, Style.BRIGHT, 
Style.RESET_ALL)+MANIFEST_DIRECTORY = 'Manifest 
directory:'+PROJECT_NAME_FORMAT_STRING = '{}{}{{}}{}:'.format(Fore.YELLOW, 
Style.BRIGHT, Style.RESET_ALL)+REPOSITORIES = 'Repositories:'+REPO_NAME_AND_URL 
= '{}{}{{}}{} - [{}{}{{}}{}]'.format(Fore.MAGENTA, Style.BRIGHT, 
Style.RESET_ALL, Fore.RED, Style.BRIGHT, Style.RESET_ALL)+REPO_NAME_NOT_FOUND = 
'repo_name not found'+REPO_NOT_FOUND_IN_MANIFEST = 'Repo {} not found in any 
manifest file'diff --git a/edkrepo/commands/list_repos_command.py 
b/edkrepo/commands/list_repos_command.py
new file mode 100644
index 000..de2de03
--- /dev/null
+++ b/edkrepo/commands/list_repos_command.py
@@ -0,0 +1,218 @@
+#!/usr/bin/env python3+#+## @file+# list_repos_command.py+#+# Copyright (c) 
2019, Intel Corporation. All rights reserved.+# SPDX-License-Identifier: 
BSD-2-Clause-Patent+#++import collections+import os++#from git import Repo+from 
colorama import Fore, Style++# Our modules+from 
edkrepo.commands.edkrepo_command import EdkrepoCommand+from 
edkrepo.commands.edkrepo_command import ColorArgument+import 
edkrepo.commands.arguments.list_repos_args as arguments+import 
edkrepo.commands.humble.list_repos_humble as humble+from 
edkrepo.common.common_repo_functions import pull_latest_manifest_repo+from 
edkrepo.common.edkrepo_exception import EdkrepoInvalidParametersException, 
EdkrepoManifestInvalidException+from edkrepo.common.ui_functions import 
init_color_console+from edkrepo_manifest_parser.edk_manifest import CiIndexXml, 
ManifestXml++class ListReposCommand(EdkrepoCommand):+def __init__(self):+   
 super().__init__()+self.repo_names = None++def 
get_metadata(self):+metadata = {}+metadata['name'] = 
'list-repos'+metadata['help-text'] = arguments.COMMAND_DESCRIPTION+ 
   args = []+metadata['arguments'] = args+

Re: [edk2-devel] [Patch wiki v2] EDK II CI: Update Phase 1 details and admin settings

[Michael D Kinney]

Hi Lazlo,

One comment below.  I have made updates based on the rest
of your feedback.

Mike

> -Original Message-
> From: Laszlo Ersek 
> Sent: Tuesday, December 3, 2019 9:08 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> 
> Cc: Sean Brogan ; Bret
> Barkelew ; Gao, Liming
> ; Andrew Fish ;
> Leif Lindholm 
> Subject: Re: [edk2-devel] [Patch wiki v2] EDK II CI:
> Update Phase 1 details and admin settings
> 
> On 12/02/19 18:56, Michael D Kinney via Groups.Io
> wrote:
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2315
> >
> > Update wiki pages providing details of the Phase 1
> > EDK II Continuous Integration features and links to
> all
> > supporting documentation.  Also provide notes for
> admins
> > to configure GitHub, Azure Pipelines, and Mergify.
> >
> > Cc: Sean Brogan 
> > Cc: Bret Barkelew 
> > Cc: Liming Gao 
> > Cc: Andrew Fish 
> > Cc: Laszlo Ersek 
> > Cc: Leif Lindholm 
> > Signed-off-by: Michael D Kinney
> 
> > ---
> >  ...I-Continuous-Integration-Administration.md | 100
> ++
> >  EDK-II-Continuous-Integration.md  |  75
> ++---
> >  2 files changed, 162 insertions(+), 13 deletions(-)
> >  create mode 100644 EDK-II-Continuous-Integration-
> Administration.md
> >
> > diff --git a/EDK-II-Continuous-Integration-
> Administration.md b/EDK-II-Continuous-Integration-
> Administration.md
> > new file mode 100644
> > index 000..669d28a
> > --- /dev/null
> > +++ b/EDK-II-Continuous-Integration-Administration.md
> > @@ -0,0 +1,100 @@
> > +# EDK II Continuous Integration Administration
> > +
> > +## Configuring edk2 repository
> > +
> > +1) Azure Pipelines Configuration Steps Part I
> > +   1) Goto https://dev.azure.com/tianocore
> > +   2) Create new project in TianoCore org called
> `edk2-ci`
> > +   3) Disable Boards
> > +   4) Disable Repositories
> > +
> > +2) GitHub Configuration Steps Part I
> > +   1) Goto https://github.com/tianocore
> > +   2) Select Settings
> > +   3) Select Installed GitHub Apps
> > +   4) Select Azure Pipelines -> Configure
> > +  * Enable `tianocore/edk2` repository
> > +  * Redirects to Azure Pipelines login.  Select
> TianoCore org and
> > +`edk2-ci` project to complete link and
> authentication between Azure
> > +Pipelines TianoCore organization and GitHub
> TianoCore organization.
> > +
> > +3) Azure Pipelines Configuration Steps Part II
> > +   1) Goto https://dev.azure.com/tianocore/edk2-
> ci/_build
> > +   2) Create New Pipeline called `Ubuntu GCC5 CI`
> for post commit checks
> > +  * YAML: Select file
> https://github.com/tianocore/edk2/blob/master/.azurepip
> elines/Ubuntu-GCC5.yml
> > +  * Name: Set to `Ubuntu GCC5 CI`
> > +  * Triggers:
> > +* CI - No changes
> > +* PR - Override + Disable
> > +  * Variables: No changes
> > +  * Save pipeline changes
> > +  * Run pipeline and verify all checks pass
> > +   3) Create New Pipeline called `Windows VS2019 CI`
> for post commit checks
> > +  * YAML: Select file
> https://github.com/tianocore/edk2/blob/master/.azurepip
> elines/Windows-VS2019.yml
> > +  * Name: `Windows VS2019 CI`
> > +  * Triggers
> > +* CI - No changes
> > +* PR - Override + Disable
> > +  * Variables: No changes
> > +  * Save pipeline changes
> > +  * Run pipeline and verify all checks pass
> > +   4) Create New Pipeline called `Ubuntu GCC5 PR`
> for pre commit checks
> > +  * YAML: Select file
> https://github.com/tianocore/edk2/blob/master/.azurepip
> elines/Ubuntu-GCC5.yml
> > +  * Name: `Ubuntu GCC5 PR`
> > +  * Triggers
> > +* CI - Override + Disable
> > +* PR - No changes
> > +  * Variables: No changes
> > +  * Save pipeline changes
> > +  * Run pipeline.  Pipeline will fail because it
> requires a GitHub PR.  Must
> > +run for pipeline name to show up in GitHub
> Branch Protection Rules.
> > +   5) Create New Pipeline called `Windows VS2019 PR`
> for pre commit checks
> > +  * YAML: Select file
> https://github.com/tianocore/edk2/blob/master/.azurepip
> elines/Windows-VS2019.yml
> > +  * Name: `Windows VS2019 PR`
> > +  * Triggers
> > +* CI - Override + Disable
> > +* PR - No changes
> > +  * Variables: No changes
> > +  * Save pipeline changes
> > +  * Run pipeline.  Pipeline will fail because it
> requires a GitHub PR.  Must
> > +run for pipeline name to show up in GitHub
> Branch Protection Rules.
> > +   6) Add PatchCheck pipeline for pre commit checks
> > +  * YAML: Select file
> https://github.com/tianocore/edk2/blob/master/.azurepip
> elines/Ubuntu-PatchCheck.yml
> > +  * Name: `tianocore.PatchCheck`
> > +  * Triggers
> > +* CI - Override + Disable
> > +* PR - No changes
> > +  * Variables: No changes
> > +  * Save pipeline changes
> > +  * Run pipeline.  Pipeline will fail because it
> requires a GitHub PR.  Must
> > +run for 

Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos

[Laszlo Ersek]

On 12/03/19 17:56, Anthony PERARD wrote:
> On Tue, Dec 03, 2019 at 05:15:44PM +0100, Philippe Mathieu-Daude wrote:
>> From: Antoine Coeur 
>>
>> Fix various typos in comments and documentation.
>>
>> Cc: Jordan Justen 
>> Cc: Laszlo Ersek 
>> Cc: Ard Biesheuvel 
>> Cc: Anthony Perard 
>> Cc: Julien Grall 
>> Reviewed-by: Philippe Mathieu-Daude 
>> Signed-off-by: Philippe Mathieu-Daude 
> 
> There's seems to be missing SoB from Antoine. Could that be added?
> 
> I might try to send the part of this patch that modify the Xen public
> headers upstream (the headers in IndustryStandard/Xen).
> 
> Otherwise, the patch looks fine.

I'll give an A-b here later, conditional on Anthony's R-b or A-b.

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51670): https://edk2.groups.io/g/devel/message/51670
Mute This Topic: https://groups.io/mt/65782892/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 60/79] OvmfPkg/Xen: Fix a typo

[Laszlo Ersek]

On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> Fix a typo in a comment.
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Ard Biesheuvel 
> Cc: Anthony Perard 
> Cc: Julien Grall 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  OvmfPkg/XenBusDxe/GrantTable.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/XenBusDxe/GrantTable.h b/OvmfPkg/XenBusDxe/GrantTable.h
> index 0d8434d1fe76..2cc889b6433f 100644
> --- a/OvmfPkg/XenBusDxe/GrantTable.h
> +++ b/OvmfPkg/XenBusDxe/GrantTable.h
> @@ -27,7 +27,7 @@ XenGrantTableInit (
>);
>  
>  /**
> -  Desinitilize the Grant Table.
> +  De-initialize the Grant Table.
>  **/
>  VOID
>  XenGrantTableDeinit (
> 

Reviewed-by: Laszlo Ersek 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51669): https://edk2.groups.io/g/devel/message/51669
Mute This Topic: https://groups.io/mt/65947034/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 79/79] UefiCpuPkg/Smm: Fix various typos

[Laszlo Ersek]

On 12/03/19 17:16, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Eric Dong 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h| 4 ++--
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h | 4 ++--
>  UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 4 ++--
>  UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c  | 2 +-
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c  | 4 ++--
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 4 ++--
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm| 2 +-
>  7 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h 
> b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> index 39ca304b31e6..dbcd57e0ad42 100644
> --- a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> +++ b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> @@ -338,7 +338,7 @@ SmmCpuFeaturesSetSmmRegister (
>  from the save state.
>  
>@retval EFI_SUCCESS   The register was read from Save State.
> -  @retval EFI_INVALID_PARAMTER  Buffer is NULL.
> +  @retval EFI_INVALID_PARAMETER  Buffer is NULL.
>@retval EFI_UNSUPPORTED   This function does not support reading 
> Register.
>  
>  **/
> @@ -364,7 +364,7 @@ SmmCpuFeaturesReadSaveStateRegister (
>@param[in] BufferUpon entry, this holds the new CPU register value.
>  
>@retval EFI_SUCCESS   The register was written to Save State.
> -  @retval EFI_INVALID_PARAMTER  Buffer is NULL.
> +  @retval EFI_INVALID_PARAMETER  Buffer is NULL.
>@retval EFI_UNSUPPORTED   This function does not support writing 
> Register.
>  **/
>  EFI_STATUS
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h 
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> index 018e918360d3..da551cc4a6a6 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> @@ -138,7 +138,7 @@ GetPiResource (
>);
>  
>  /**
> -  This functin initialize STM configuration table.
> +  This function initialize STM configuration table.
>  **/
>  VOID
>  StmSmmConfigurationTableInit (
> @@ -169,7 +169,7 @@ GetStmResource (
>  
>  /**
>This function fixes up the address of the global variable or function
> -  referred in SmiEntry assembly files to be the absoute address.
> +  referred in SmiEntry assembly files to be the absolute address.
>  **/
>  VOID
>  EFIAPI
> diff --git 
> a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c 
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> index 72c2aeca4c13..6a2670d55918 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> @@ -68,7 +68,7 @@ CommonExceptionHandlerWorker (
>  //
>  ArchRestoreExceptionContext (ExceptionType, SystemContext, 
> ExceptionHandlerData);
>  //
> -// Rlease spin lock for ApicId
> +// Release spin lock for ApicId
>  //
>  ReleaseSpinLock ([ExceptionType].SpinLock);
>  break;
> @@ -230,7 +230,7 @@ InitializeCpuExceptionHandlersWorker (
>IdtEntryCount = (IdtDescriptor.Limit + 1) / sizeof 
> (IA32_IDT_GATE_DESCRIPTOR);
>if (IdtEntryCount > CPU_EXCEPTION_NUM) {
>  //
> -// CPU exeption library only setup CPU_EXCEPTION_NUM exception handler 
> at most
> +// CPU exception library only setup CPU_EXCEPTION_NUM exception handler 
> at most
>  //
>  IdtEntryCount = CPU_EXCEPTION_NUM;
>}
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c 
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> index ec705fc489af..e7977d49b771 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> @@ -1,5 +1,5 @@
>  /** @file
> -  CPU exception handler library implemenation for SMM modules.
> +  CPU exception handler library implementation for SMM modules.
>  
>Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c 
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> index bddb7a219ce4..a00786a8ebef 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> @@ -540,7 +540,7 @@ SmmCpuFeaturesSetSmmRegister (
>  from the save state.
>  
>@retval EFI_SUCCESS   The register was read from Save State.
> -  @retval EFI_INVALID_PARAMTER  Buffer is NULL.
> +  @retval 

Re: [edk2-devel] [PATCH 78/79] UefiCpuPkg/PiSmm: Fix various typos

[Laszlo Ersek]

On 12/03/19 17:16, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Eric Dong 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h| 12 ++--
>  UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c |  2 +-
>  UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c |  2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c|  4 ++--
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c|  4 ++--
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c|  6 +++---
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c |  2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm   |  2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm|  2 +-
>  9 files changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h 
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index daf977f654b4..7f5a0b2b267a 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -272,7 +272,7 @@ extern UINT8  mSmmSaveStateRegisterLma;
>  
>@retval EFI_SUCCESS   The register was read from Save State
>@retval EFI_NOT_FOUND The register is not defined for the Save State of 
> Processor
> -  @retval EFI_INVALID_PARAMTER   This or Buffer is NULL.
> +  @retval EFI_INVALID_PARAMETER   This or Buffer is NULL.
>  
>  **/
>  EFI_STATUS
> @@ -296,7 +296,7 @@ SmmReadSaveState (
>  
>@retval EFI_SUCCESS   The register was written from Save State
>@retval EFI_NOT_FOUND The register is not defined for the Save State of 
> Processor
> -  @retval EFI_INVALID_PARAMTER   ProcessorIndex or Width is not correct
> +  @retval EFI_INVALID_PARAMETER   ProcessorIndex or Width is not correct
>  
>  **/
>  EFI_STATUS
> @@ -324,7 +324,7 @@ This function supports reading a CPU Save State register 
> in SMBase relocation ha
>  
>  @retval EFI_SUCCESS   The register was read from Save State.
>  @retval EFI_NOT_FOUND The register is not defined for the Save State 
> of Processor.
> -@retval EFI_INVALID_PARAMTER  This or Buffer is NULL.
> +@retval EFI_INVALID_PARAMETER  This or Buffer is NULL.
>  
>  **/
>  EFI_STATUS
> @@ -351,7 +351,7 @@ This function supports writing a CPU Save State register 
> in SMBase relocation ha
>  
>  @retval EFI_SUCCESS   The register was written to Save State.
>  @retval EFI_NOT_FOUND The register is not defined for the Save State 
> of Processor.
> -@retval EFI_INVALID_PARAMTER  ProcessorIndex or Width is not correct.
> +@retval EFI_INVALID_PARAMETER  ProcessorIndex or Width is not correct.
>  
>  **/
>  EFI_STATUS
> @@ -1251,7 +1251,7 @@ EdkiiSmmGetMemoryAttributes (
>  
>  /**
>This function fixes up the address of the global variable or function
> -  referred in SmmInit assembly files to be the absoute address.
> +  referred in SmmInit assembly files to be the absolute address.
>  **/
>  VOID
>  EFIAPI
> @@ -1260,7 +1260,7 @@ PiSmmCpuSmmInitFixupAddress (
>  
>  /**
>This function fixes up the address of the global variable or function
> -  referred in SmiEntry assembly files to be the absoute address.
> +  referred in SmiEntry assembly files to be the absolute address.
>  **/
>  VOID
>  EFIAPI
> diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c 
> b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> index 5d09130e5591..68e5003ad4c2 100644
> --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> @@ -366,7 +366,7 @@ Communicate (
>@param  FileHandle  Handle of the file being invoked.
>@param  PeiServices Pointer to PEI Services table.
>  
> -  @retval EFI_SUCEESS
> +  @retval EFI_SUCCESS
>@return Others  Some error occurs.
>  **/
>  EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c 
> b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> index 6be12d6c14cd..30f7d57bdd91 100644
> --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> @@ -155,7 +155,7 @@ AllocateAcpiNvsMemoryBelow4G (
>@param[in] ImageHandle  Image handle of this driver.
>@param[in] SystemTable  A Pointer to the EFI System Table.
>  
> -  @retval EFI_SUCEESS
> +  @retval EFI_SUCCESS
>@return Others  Some error occurs.
>  **/
>  EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c 
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> index 723fd5042ff4..db68e1316ec5 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> @@ -215,7 +215,7 @@ DumpModuleInfoByIp (
>  
>@retval EFI_SUCCESS   The register was read from Save State
>@retval EFI_NOT_FOUND The register is not defined 

Re: [edk2-devel] [PATCH 77/79] UefiCpuPkg/CpuDxe: Fix few typos

[Laszlo Ersek]

On 12/03/19 17:16, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur 
> 
> Fix few typos in comments and documentation.
> 
> Cc: Eric Dong 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  UefiCpuPkg/CpuDxe/CpuDxe.h   | 2 +-
>  UefiCpuPkg/CpuDxe/CpuGdt.h   | 2 +-
>  UefiCpuPkg/CpuDxe/CpuMp.h| 4 ++--
>  UefiCpuPkg/CpuDxe/CpuPageTable.h | 2 +-
>  UefiCpuPkg/CpuDxe/CpuDxe.c   | 8 
>  UefiCpuPkg/CpuDxe/CpuGdt.c   | 2 +-
>  UefiCpuPkg/CpuDxe/CpuMp.c| 4 ++--
>  UefiCpuPkg/CpuDxe/CpuPageTable.c | 6 +++---
>  8 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h
> index a6762f1a0b78..9299eaa63d8a 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.h
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.h
> @@ -208,7 +208,7 @@ CpuGetTimerValue (
>);
>  
>  /**
> -  Set memory cacheability attributes for given range of memeory.
> +  Set memory cacheability attributes for given range of memory.
>  
>@param  This   Protocol instance structure
>@param  BaseAddressSpecifies the start address of the
> diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.h b/UefiCpuPkg/CpuDxe/CpuGdt.h
> index e5c36f37b96a..3a0210b2f172 100644
> --- a/UefiCpuPkg/CpuDxe/CpuGdt.h
> +++ b/UefiCpuPkg/CpuDxe/CpuGdt.h
> @@ -1,5 +1,5 @@
>  /** @file
> -  C based implemention of IA32 interrupt handling only
> +  C based implementation of IA32 interrupt handling only
>requiring a minimal assembly interrupt entry point.
>  
>Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> diff --git a/UefiCpuPkg/CpuDxe/CpuMp.h b/UefiCpuPkg/CpuDxe/CpuMp.h
> index e7e115fc8f3d..4ee171d8c491 100644
> --- a/UefiCpuPkg/CpuDxe/CpuMp.h
> +++ b/UefiCpuPkg/CpuDxe/CpuMp.h
> @@ -147,7 +147,7 @@ GetProcessorInfo (
> and releases the BSP to continue with other tasks.
>  -# The caller can use the CheckEvent() and WaitForEvent() services to 
> check
> the state of the WaitEvent created in step 1.
> --# When the APs complete their task or TimeoutInMicroSecondss expires, 
> the MP
> +-# When the APs complete their task or TimeoutInMicroSeconds expires, 
> the MP
> Service signals WaitEvent by calling the EFI SignalEvent() function. 
> If
> FailedCpuList is not NULL, its content is available when WaitEvent is
> signaled. If all APs returned from Procedure prior to the timeout, 
> then
> @@ -254,7 +254,7 @@ StartupAllAPs (
>This function is used to dispatch one enabled AP to the function specified 
> by
>Procedure passing in the argument specified by ProcedureArgument.  If 
> WaitEvent
>is NULL, execution is in blocking mode. The BSP waits until the AP 
> finishes or
> -  TimeoutInMicroSecondss expires. Otherwise, execution is in non-blocking 
> mode.
> +  TimeoutInMicroSeconds expires. Otherwise, execution is in non-blocking 
> mode.
>BSP proceeds to the next task without waiting for the AP. If a 
> non-blocking mode
>is requested after the UEFI Event EFI_EVENT_GROUP_READY_TO_BOOT is 
> signaled,
>then EFI_UNSUPPORTED must be returned.
> diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.h 
> b/UefiCpuPkg/CpuDxe/CpuPageTable.h
> index bad6784bcb51..0b2a02a2be5c 100644
> --- a/UefiCpuPkg/CpuDxe/CpuPageTable.h
> +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.h
> @@ -78,7 +78,7 @@ VOID *
>  
>Caller should make sure BaseAddress and Length is at page boundary.
>  
> -  Caller need guarentee the TPL <= TPL_NOTIFY, if there is split page 
> request.
> +  Caller need guarantee the TPL <= TPL_NOTIFY, if there is split page 
> request.
>  
>@param  PagingContext The paging context. NULL means get page table 
> from current CPU context.
>@param  BaseAddress   The physical address that is the start address 
> of a memory region.
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
> index 7d7270e10b4a..a571fc3b1750 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.c
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
> @@ -393,7 +393,7 @@ CpuSetMemoryAttributes (
>  
>//
>// If this function is called because GCD SetMemorySpaceAttributes () is 
> called
> -  // by RefreshGcdMemoryAttributes (), then we are just synchronzing GCD 
> memory
> +  // by RefreshGcdMemoryAttributes (), then we are just synchronizing GCD 
> memory
>// map with MTRR values. So there is no need to modify MTRRs, just return 
> immediately
>// to avoid unnecessary computing.
>//
> @@ -456,7 +456,7 @@ CpuSetMemoryAttributes (
>  CurrentCacheType = MtrrGetMemoryAttribute(BaseAddress);
>  if (CurrentCacheType != CacheType) {
>//
> -  // call MTRR libary function
> +  // call MTRR library function
>//
>Status = MtrrSetMemoryAttribute (
>   BaseAddress,
> @@ -831,7 +831,7 @@ RefreshMemoryAttributesFromMtrr (
>  Attributes = CurrentAttributes;
>} else {
>  

Re: [edk2-devel] [PATCH 59/79] OvmfPkg/Virtio: Fix few typos

[Laszlo Ersek]

On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur 
> 
> Fix few typos in comments and documentation.
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Ard Biesheuvel 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  OvmfPkg/Include/Library/VirtioLib.h | 2 +-
>  OvmfPkg/Library/VirtioLib/VirtioLib.c   | 2 +-
>  OvmfPkg/VirtioNetDxe/DriverBinding.c| 2 +-
>  OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 2 +-
>  OvmfPkg/VirtioRngDxe/VirtioRng.c| 2 +-
>  OvmfPkg/VirtioScsiDxe/VirtioScsi.c  | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/OvmfPkg/Include/Library/VirtioLib.h 
> b/OvmfPkg/Include/Library/VirtioLib.h
> index e817a4206f62..e714ec7aee50 100644
> --- a/OvmfPkg/Include/Library/VirtioLib.h
> +++ b/OvmfPkg/Include/Library/VirtioLib.h
> @@ -292,7 +292,7 @@ Virtio10WriteFeatures (
>VIRTIO_UNMAP_SHARED.
>  
>  
> -  @retval EFI_SUCCESS The NumberOfBytes is succesfully mapped.
> +  @retval EFI_SUCCESS The NumberOfBytes is successfully mapped.
>@retval EFI_UNSUPPORTED The HostAddress cannot be mapped as a
>common buffer.
>@retval EFI_INVALID_PARAMETER   One or more parameters are invalid.
> diff --git a/OvmfPkg/Library/VirtioLib/VirtioLib.c 
> b/OvmfPkg/Library/VirtioLib/VirtioLib.c
> index 555d2a5ce7c9..e09324813c2d 100644
> --- a/OvmfPkg/Library/VirtioLib/VirtioLib.c
> +++ b/OvmfPkg/Library/VirtioLib/VirtioLib.c
> @@ -452,7 +452,7 @@ Virtio10WriteFeatures (
>VIRTIO_UNMAP_SHARED.
>  
>  
> -  @retval EFI_SUCCESS The NumberOfBytes is succesfully mapped.
> +  @retval EFI_SUCCESS The NumberOfBytes is successfully mapped.
>@retval EFI_UNSUPPORTED The HostAddress cannot be mapped as a
>common buffer.
>@retval EFI_INVALID_PARAMETER   One or more parameters are invalid.
> diff --git a/OvmfPkg/VirtioNetDxe/DriverBinding.c 
> b/OvmfPkg/VirtioNetDxe/DriverBinding.c
> index eb0e873657a4..3c400a604650 100644
> --- a/OvmfPkg/VirtioNetDxe/DriverBinding.c
> +++ b/OvmfPkg/VirtioNetDxe/DriverBinding.c
> @@ -419,7 +419,7 @@ VirtioNetDriverBindingSupported (
> device error.Currently not implemented.
>@retval EFI_OUT_OF_RESOURCES The request could not be completed due to 
> a
> lack of resources.
> -  @retval Others   The driver failded to start the device.
> +  @retval Others   The driver failed to start the device.
>  
>  **/
>  
> diff --git a/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c 
> b/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c
> index dc684650d665..d1e3ecfa5a0f 100644
> --- a/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c
> +++ b/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c
> @@ -118,7 +118,7 @@ VirtioNetUninitRing (
>a lack of resources.
>@return Status codes from
>VirtioMapAllBytesInSharedBuffer()
> -  @retval EFI_SUCCESS Caller-supplied buffer is succesfully 
> mapped.
> +  @retval EFI_SUCCESS Caller-supplied buffer is successfully 
> mapped.
>  */
>  EFI_STATUS
>  EFIAPI
> diff --git a/OvmfPkg/VirtioRngDxe/VirtioRng.c 
> b/OvmfPkg/VirtioRngDxe/VirtioRng.c
> index d0e2468c2373..4e2b710f9e49 100644
> --- a/OvmfPkg/VirtioRngDxe/VirtioRng.c
> +++ b/OvmfPkg/VirtioRngDxe/VirtioRng.c
> @@ -156,7 +156,7 @@ VirtioRngGetRNG (
>  
>Dev = VIRTIO_ENTROPY_SOURCE_FROM_RNG (This);
>//
> -  // Map Buffer's system phyiscal address to device address
> +  // Map Buffer's system physical address to device address
>//
>Status = VirtioMapAllBytesInSharedBuffer (
>   Dev->VirtIo,
> diff --git a/OvmfPkg/VirtioScsiDxe/VirtioScsi.c 
> b/OvmfPkg/VirtioScsiDxe/VirtioScsi.c
> index e50a697daa15..935d15439579 100644
> --- a/OvmfPkg/VirtioScsiDxe/VirtioScsi.c
> +++ b/OvmfPkg/VirtioScsiDxe/VirtioScsi.c
> @@ -497,7 +497,7 @@ VirtioScsiPassThru (
>  //  * we perform the request fine
>  //  * but we fail to unmap the "InDataMapping"
>  //
> -// In that case simply returing the EFI_DEVICE_ERROR is not sufficient. 
> In
> +// In that case simply returning the EFI_DEVICE_ERROR is not sufficient. 
> In
>  // addition to the error code we also need to update Packet fields
>  // accordingly so that we report the full loss of the incoming transfer.
>  //
> 

Reviewed-by: Laszlo Ersek 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51665): https://edk2.groups.io/g/devel/message/51665
Mute This Topic: https://groups.io/mt/65941421/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 58/79] OvmfPkg/Qemu: Fix various typos

[Laszlo Ersek]

On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Ard Biesheuvel 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf |  4 ++--
>  OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf|  4 ++--
>  OvmfPkg/AcpiPlatformDxe/Qemu.c   |  4 ++--
>  OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c  |  2 +-
>  OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c  |  4 ++--
>  OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c  |  2 +-
>  OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c  |  2 +-
>  OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c |  4 ++--
>  OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c  |  8 
> 
>  OvmfPkg/QemuVideoDxe/Driver.c|  2 +-
>  OvmfPkg/QemuVideoDxe/VbeShim.asm | 14 
> +++---
>  11 files changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf 
> b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
> index ca6326e833ed..8125fd0735a1 100644
> --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
> +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
> @@ -1,8 +1,8 @@
>  ## @file
> -#  Component description file for QEMU Flash Fimware Volume Block DXE driver
> +#  Component description file for QEMU Flash Firmware Volume Block DXE driver
>  #  module.
>  #
> -#  This DXE runtime driver implements and produces the Fimware Volue Block
> +#  This DXE runtime driver implements and produces the Firmware Volue Block
>  #  Protocol for a QEMU flash device.
>  #
>  #  Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.
> diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf 
> b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
> index 241e912e2967..4715d5fc437e 100644
> --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
> +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
> @@ -1,8 +1,8 @@
>  ## @file
> -#  Component description file for QEMU Flash Fimware Volume Block SMM driver
> +#  Component description file for QEMU Flash Firmware Volume Block SMM driver
>  #  module.
>  #
> -#  This SMM driver implements and produces the SMM Fimware Volue Block 
> Protocol
> +#  This SMM driver implements and produces the SMM Firmware Volue Block 
> Protocol
>  #  for a QEMU flash device.
>  #
>  #  Copyright (C) 2015, Red Hat, Inc.
> diff --git a/OvmfPkg/AcpiPlatformDxe/Qemu.c b/OvmfPkg/AcpiPlatformDxe/Qemu.c
> index f60e00f58af3..7fb42270043f 100644
> --- a/OvmfPkg/AcpiPlatformDxe/Qemu.c
> +++ b/OvmfPkg/AcpiPlatformDxe/Qemu.c
> @@ -137,7 +137,7 @@ QemuInstallAcpiMadtTable (
>++Iso;
>  
>//
> -  // Set Level-tiggered, Active High for all possible PCI link targets.
> +  // Set Level-triggered, Active High for all possible PCI link targets.
>//
>for (Loop = 0; Loop < 16; ++Loop) {
>  if ((PcdGet16 (Pcd8259LegacyModeEdgeLevel) & (1 << Loop)) == 0) {
> @@ -148,7 +148,7 @@ QemuInstallAcpiMadtTable (
>  Iso->Bus = 0x00; // ISA
>  Iso->Source  = (UINT8) Loop;
>  Iso->GlobalSystemInterruptVector = (UINT32) Loop;
> -Iso->Flags   = 0x000D; // Level-tiggered, Active High
> +Iso->Flags   = 0x000D; // Level-triggered, Active 
> High
>  ++Iso;
>}
>ASSERT (
> diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c 
> b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
> index bc1a891dbaf1..75a3a88a3612 100644
> --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
> +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
> @@ -1113,7 +1113,7 @@ InstallQemuFwCfgTables (
>goto UninstallAcpiTables;
>  }
>  //
> -// Ownership of S3Context has been transfered.
> +// Ownership of S3Context has been transferred.
>  //
>  S3Context = NULL;
>}
> diff --git a/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c 
> b/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
> index 49bdfdf65043..1839f11f3301 100644
> --- a/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
> +++ b/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
> @@ -1156,7 +1156,7 @@ PciBitFieldAndThenOr32 (
>Size into the buffer specified by Buffer. This function only allows the PCI
>configuration registers from a single PCI function to be read. Size is
>returned. When possible 32-bit PCI configuration read cycles are used to 
> read
> -  from StartAdress to StartAddress + Size. Due to alignment restrictions, 
> 8-bit
> +  from StartAddress to StartAddress + Size. Due to alignment restrictions, 
> 8-bit
>and 16-bit PCI 

Re: [edk2-devel] [PATCH 57/79] OvmfPkg/Csm: Fix various typos

[Laszlo Ersek]

On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur 
> 
> Fix various typos in documentation, comments and strings.
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Ard Biesheuvel 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf   |  2 +-
>  OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h  | 10 
> +-
>  OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h |  8 
> 
>  OvmfPkg/Csm/Include/Framework/BootScript.h  |  2 +-
>  OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h |  2 +-
>  OvmfPkg/Csm/Include/Protocol/IsaIo.h|  2 +-
>  OvmfPkg/Csm/Include/Protocol/LegacyBios.h   |  6 
> +++---
>  OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h   |  4 ++--
>  OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h  |  2 +-
>  OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h |  8 
> 
>  OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h|  4 ++--
>  OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h |  2 +-
>  OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c  |  4 ++--
>  OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c  |  6 
> +++---
>  OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c  |  6 
> +++---
>  OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c   |  4 ++--
>  OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c   |  8 
> 
>  OvmfPkg/Csm/LegacyBiosDxe/Thunk.c   |  4 ++--
>  OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c| 14 
> +++---
>  OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 
> +-
>  OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni   |  8 
> 
>  21 files changed, 62 insertions(+), 62 deletions(-)

CC'ing David -- David is the designated Reviewer for OvmfPkg/Csm/, based
on "Maintainers.txt".

Conditional on David's R-b, you can add:

Acked-by: Laszlo Ersek 

Thanks
Laszlo

> diff --git a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf 
> b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
> index 5cc64a1b2df2..9a790d34a0e4 100644
> --- a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
> +++ b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
> @@ -1,5 +1,5 @@
>  ## @file
> -#  Legacy Boot Maintainence UI module is library for BDS phase.
> +#  Legacy Boot Maintenance UI module is library for BDS phase.
>  #
>  #  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h 
> b/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
> index 951f4e6f768f..522e8ab15bb9 100644
> --- a/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
> +++ b/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
> @@ -241,7 +241,7 @@ BiosVideoCheckForVga (
>  
>  
>  /**
> -  Release resource for biso video instance.
> +  Release resource for bios video instance.
>  
>@param  BiosVideoPrivate   Video child device private data structure
>  
> @@ -347,9 +347,9 @@ BiosVideoGraphicsOutputVbeBlt (
>  
>  
>  /**
> -  Grahpics Output protocol instance to block transfer for VGA device.
> +  Graphics Output protocol instance to block transfer for VGA device.
>  
> -  @param  This   Pointer to Grahpics Output protocol instance
> +  @param  This   Pointer to Graphics Output protocol instance
>@param  BltBuffer  The data to transfer to screen
>@param  BltOperation   The operation to perform
>@param  SourceXThe X coordinate of the source for 
> BltOperation
> @@ -412,7 +412,7 @@ BiosVideoVgaMiniPortSetMode (
>  /**
>Event handler for Exit Boot Service.
>  
> -  @param  Event   The event that be siganlled when exiting boot service.
> +  @param  Event   The event that be signalled when exiting boot service.
>@param  Context Pointer to instance of BIOS_VIDEO_DEV.
>  
>  **/
> @@ -506,7 +506,7 @@ BiosVideoChildHandleUninstall (
>);
>  
>  /**
> -  Release resource for biso video instance.
> +  Release resource for bios video instance.
>  
>@param  BiosVideoPrivate   Video child device private data structure
>  
> diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h 
> b/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
> index dbf706179ff9..88065f15c645 100644
> --- a/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
> +++ b/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
> @@ -250,7 +250,7 @@ typedef struct {
>  #define VESA_BIOS_EXTENSIONS_VERSION_3_0  0x0300
>  
>  //
> -// Super VGA Information Block 

Re: [edk2-devel] [PATCH 56/79] OvmfPkg/Acpi: Fix few typos

[Laszlo Ersek]

On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur 
> 
> Fix few typos in comments and documentation.
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Ard Biesheuvel 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 2 +-
>  OvmfPkg/AcpiPlatformDxe/BootScript.c   | 2 +-
>  OvmfPkg/AcpiTables/Facp.aslc   | 8 
>  OvmfPkg/AcpiTables/Facs.aslc   | 4 ++--
>  OvmfPkg/AcpiTables/Madt.aslc   | 2 +-
>  5 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h 
> b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> index 12aeb1227c54..0ff57aa118ca 100644
> --- a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> +++ b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> @@ -131,7 +131,7 @@ EFI_STATUS
>  
>This services sets the power state of the ISA controller specified by 
> Device to
>the power state specified by OnOff.  TRUE denotes on, FALSE denotes off.
> -  If the power state is sucessfully set on the ISA Controller, then
> +  If the power state is successfully set on the ISA Controller, then
>EFI_SUCCESS is returned.
>  
>@param[in] This The pointer to the EFI_ISA_ACPI_PROTOCOL instance.
> diff --git a/OvmfPkg/AcpiPlatformDxe/BootScript.c 
> b/OvmfPkg/AcpiPlatformDxe/BootScript.c
> index 7137994471bd..7b1b9586da41 100644
> --- a/OvmfPkg/AcpiPlatformDxe/BootScript.c
> +++ b/OvmfPkg/AcpiPlatformDxe/BootScript.c
> @@ -240,7 +240,7 @@ FatalError:
>  Script opcodes. If the function returns successfully,
>  the caller must set the S3Context pointer -- 
> originally
>  returned by AllocateS3Context() -- immediately to 
> NULL,
> -because the ownership of S3Context has been 
> transfered.
> +because the ownership of S3Context has been 
> transferred.
>  
>@retval EFI_SUCCESS The translation of S3Context to ACPI S3 Boot Script
>opcodes has been successfully executed or queued. (This
> diff --git a/OvmfPkg/AcpiTables/Facp.aslc b/OvmfPkg/AcpiTables/Facp.aslc
> index 8829c1808a70..657a8c645821 100644
> --- a/OvmfPkg/AcpiTables/Facp.aslc
> +++ b/OvmfPkg/AcpiTables/Facp.aslc
> @@ -21,7 +21,7 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = {
>  EFI_ACPI_CREATOR_ID,// ASL compiler vendor ID
>  EFI_ACPI_CREATOR_REVISION   // ASL compiler revision number
>},
> -  0,// Physical addesss of FACS
> +  0,// Physical address of FACS
>0,// Physical address of DSDT
>RESERVED, // System Interrupt Model in ACPI 1.0, eliminated in 2.0
>EFI_ACPI_2_0_PM_PROFILE_UNSPECIFIED, // Preferred PM profile
> @@ -62,8 +62,8 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = {
>GAS2_IO(RESET_REG, 1), // Extended address of the Reset Register
>RESET_VALUE,   // Value for the Reset Register to reset the system
>{ RESERVED }, // reserved[3]
> -  0,// 64-bit physical addesss of FACS, set at installation
> -  0,// 64-bit physical addesss of DSDT, set at installation
> +  0,// 64-bit physical address of FACS, set at installation
> +  0,// 64-bit physical address of DSDT, set at installation
>  
>GAS2_IO(PM1a_EVT_BLK, PM1_EVT_LEN), // Ext. addr. of PM 1a Event Reg Blk
>{ 0 },  // PM 1b Event Reg Blk unsupported
> @@ -83,7 +83,7 @@ ReferenceAcpiTable (
>  {
>//
>// Reference the table being generated to prevent the optimizer from 
> removing the
> -  // data structure from the exeutable
> +  // data structure from the executable
>//
>return (VOID*)
>  }
> diff --git a/OvmfPkg/AcpiTables/Facs.aslc b/OvmfPkg/AcpiTables/Facs.aslc
> index 56f86c1ca4fd..8257c4bc6416 100644
> --- a/OvmfPkg/AcpiTables/Facs.aslc
> +++ b/OvmfPkg/AcpiTables/Facs.aslc
> @@ -70,8 +70,8 @@ ReferenceAcpiTable (
>)
>  {
>//
> -  // Reference the table being generated to prevent the optimizer from 
> removing the
> -  // data structure from the exeutable
> +  // Reference the table being generated to prevent the optimizer from 
> removing the 

The line above introduces a stray space character before the CRLF.
Please remove it. (I.e., the line starting with "Reference..." should
not be changed.) With that:

Reviewed-by: Laszlo Ersek 

Thanks
Laszlo

> +  // data structure from the executable
>//
>return (VOID*)
>  }
> diff --git a/OvmfPkg/AcpiTables/Madt.aslc b/OvmfPkg/AcpiTables/Madt.aslc
> index 44ffd3726500..02fc3649a0d0 100644
> --- a/OvmfPkg/AcpiTables/Madt.aslc
> +++ b/OvmfPkg/AcpiTables/Madt.aslc
> @@ -147,7 +147,7 @@ ReferenceAcpiTable (
>  {
>//
>// Reference the table being generated to prevent the optimizer from 
> removing the
> -  // data structure from the exeutable
> +  // data structure from the executable
>   

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

[Laszlo Ersek]

On 12/03/19 18:07, Kinney, Michael D wrote:
> Hi Laszlo,
> 
> I can think of ways we may be able to get the label 
> information into the body of the email in a PR comment.
> I will have to see if there is anyway to adjust the subject
> of the email.  The subject appears to always match the title
> of the PR.  That title is editable, but may only be editable
> using GitHub APIs.  Mergify does not support that feature 
> today.
> 
> If you look at the following file, you will see the current
> Mergify rules.
> 
> https://github.com/tianocore/edk2/blob/master/.mergify/config.yml
> 
> If I look at the 3rd rule for merge conflicts, I could split
> that out into 2 rules.  One for push label set and one for
> push label not set and adjust the message generated to state
> if the conflict is on a personal build or a push request.
> 
> Would small adjustments like this in the body of the email
> notifications help?  If we make the generated messages consistent
> email filters on the content of the email body can be used 
> instead of email filters on the email subject.

Sounds great, thank you. I've checked the mail filtering solution that's
available to me, and it appears capable of scanning email bodies.

I suggest picking a GUID for the message body, in best UEFI style :) ,
for representing the *absence* of the "push" label. I generally prefer
watching all kinds of notifications about the edk2 repo, *except* the
personal CI builds.

> Each developer can enable/disable the 'Watch' feature on the
> edk2 repo.  That is a developer setting, not a team setting.

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51661): https://edk2.groups.io/g/devel/message/51661
Mute This Topic: https://groups.io/mt/53725670/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 76/79] StandaloneMmPkg: Fix few typos

[Yao, Jiewen]

Reviewed-by: jiewen@intel.com

> -Original Message-
> From: Philippe Mathieu-Daude 
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Achin Gupta ; Yao,
> Jiewen ; Supreeth Venkatesh
> ; Philippe Mathieu-Daude
> 
> Subject: [PATCH 76/79] StandaloneMmPkg: Fix few typos
> 
> From: Antoine Coeur 
> 
> Fix few typos in comments.
> 
> Cc: Achin Gupta 
> Cc: Jiewen Yao 
> Cc: Supreeth Venkatesh 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
> 
> StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMm
> PeCoffExtraActionLib.inf | 2 +-
>  StandaloneMmPkg/Core/Dependency.c
>  | 2 +-
>  StandaloneMmPkg/Core/FwVol.c 
>  | 2 +-
>  StandaloneMmPkg/Core/StandaloneMmCore.c  
>  |
> 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git
> a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM
> mPeCoffExtraActionLib.inf
> b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM
> mPeCoffExtraActionLib.inf
> index e972ba3bc7b8..89083df679a1 100644
> ---
> a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM
> mPeCoffExtraActionLib.inf
> +++
> b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM
> mPeCoffExtraActionLib.inf
> @@ -1,5 +1,5 @@
>  #/** @file
> -# PeCoff extra action libary for DXE phase that run Unix emulator.
> +# PeCoff extra action library for DXE phase that run Unix emulator.
>  #
>  # Lib to provide memory journal status code reporting Routines
>  # Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.
> diff --git a/StandaloneMmPkg/Core/Dependency.c
> b/StandaloneMmPkg/Core/Dependency.c
> index 7c6e76748b2b..e0f2d3518369 100644
> --- a/StandaloneMmPkg/Core/Dependency.c
> +++ b/StandaloneMmPkg/Core/Dependency.c
> @@ -372,7 +372,7 @@ MmIsSchedulable (
>  // The math is done out of order, but it should not matter. That is
>  // we may add in the sizeof (EFI_GUID) before we account for the OP Code.
>  // This is not an issue, since we just need the correct end result. You
> -// need to be careful using Iterator in the loop as it's intermediate 
> value
> +// need to be careful using Iterator in the loop as its intermediate 
> value
>  // may be strange.
>  //
>  Iterator++;
> diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c
> index 314329ea065a..856d86011d31 100644
> --- a/StandaloneMmPkg/Core/FwVol.c
> +++ b/StandaloneMmPkg/Core/FwVol.c
> @@ -50,7 +50,7 @@ MmCoreFfsFindMmDriver (
> 
>  Routine Description:
>Given the pointer to the Firmware Volume Header find the
> -  MM driver and return it's PE32 image.
> +  MM driver and return its PE32 image.
> 
>  Arguments:
>FwVolHeader - Pointer to memory mapped FV
> diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c
> b/StandaloneMmPkg/Core/StandaloneMmCore.c
> index c52164683de8..ac3e2c0b1b93 100644
> --- a/StandaloneMmPkg/Core/StandaloneMmCore.c
> +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c
> @@ -354,7 +354,7 @@ MmEntryPoint (
>//PlatformHookBeforeMmDispatch ();
> 
>//
> -  // If a legacy boot has occured, then make sure gMmCorePrivate is not
> accessed
> +  // If a legacy boot has occurred, then make sure gMmCorePrivate is not
> accessed
>//
> 
>//
> --
> 2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51660): https://edk2.groups.io/g/devel/message/51660
Mute This Topic: https://groups.io/mt/65866744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 75/79] StandaloneMmPkg: Fix a typo

[Yao, Jiewen]

Reviewed-by: jiewen@intel.com

> -Original Message-
> From: Philippe Mathieu-Daude 
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Philippe Mathieu-Daude ; Antoine Cœur
> ; Achin Gupta ; Yao, Jiewen
> ; Supreeth Venkatesh 
> Subject: [PATCH 75/79] StandaloneMmPkg: Fix a typo
> 
> Fix a typo in a comment.
> 
> Cc: Achin Gupta 
> Cc: Jiewen Yao 
> Cc: Supreeth Venkatesh 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  StandaloneMmPkg/Core/Dispatcher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/StandaloneMmPkg/Core/Dispatcher.c
> b/StandaloneMmPkg/Core/Dispatcher.c
> index fe10e65c4bf0..2f795d01dc1f 100644
> --- a/StandaloneMmPkg/Core/Dispatcher.c
> +++ b/StandaloneMmPkg/Core/Dispatcher.c
> @@ -431,7 +431,7 @@ MmLoadImage (
>  //
>  // Copy the PDB file name to our temporary string, and replace .pdb with 
> .efi
>  // The PDB file name is limited in the range of 0~255.
> -// If the length is bigger than 255, trim the redudant characters to 
> avoid
> overflow in array boundary.
> +// If the length is bigger than 255, trim the redundant characters to 
> avoid
> overflow in array boundary.
>  //
>  for (Index = 0; Index < sizeof (EfiFileName) - 4; Index++) {
>EfiFileName[Index] = ImageContext.PdbPointer[Index + StartIndex];
> --
> 2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51659): https://edk2.groups.io/g/devel/message/51659
Mute This Topic: https://groups.io/mt/65866393/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/8] .mailmap: Add mailmap file to have a cleaner git history

[Philippe Mathieu-Daudé]

On 12/3/19 7:51 PM, Laszlo Ersek wrote:

Hi Phil,

(heavily trimmer CC list)


Good idea :)


On 11/26/19 16:08, Philippe Mathieu-Daudé via Groups.Io wrote:

Hi,

The .mailmap git feature helps fixing commit mistakes (in name/email).

The easiest way to use it is with the --use-mailmap flag:

   $ git log --use-mailmap

See:
https://git-scm.com/docs/git-shortlog#_mapping_authors
https://git-scm.com/docs/git-check-mailmap#_mapping_authors

Also interesting:
https://github.com/sympy/sympy/wiki/Using-.mailmap#making-mailmap-entries

Regards,

Phil.

Philippe Mathieu-Daudé (8):
   .mailmap: Convert emails generated by the Subversion original import
   .mailmap: Fix emails from the Subversion era
   .mailmap: Fix Intel emails rewritten by Microsoft Exchange Server
   .mailmap: Fix emails rewritten by lists DMARC / DKIM / SPF
   .mailmap: Fix incorrect email formats
   .mailmap: Unify Intel email addresses format
   .mailmap: Fix UTF-8 mojibaked names
   .mailmap: Miscellaneous fixes on various emails

  .mailmap | 221 +++
  1 file changed, 221 insertions(+)
  create mode 100644 .mailmap



our suggestion from the stewards' confcall is to avoid cross-domain
mappings, unless a contributor explicitly confirms (in an email sent
from the mapped-to, i.e. "new" address) that they are OK with the
mapped-from (i.e. "old") address being "hidden" by the mapping.

Due to two reasons:
- mappings across domains could hide employer changes,


Hmm OK.


- even the "mapped-to" (i.e. "new") address may not be up-to-date.


Agreed.


Stewards may be able ACK typo fixes and simple name order changes even
in the absence of the affected (historical) contributor, but
cross-domain mappings are not something they can ACK on their own.


Understood.


(At least this is my understanding from the meeting.)

Personal note in the end: can we perhaps structure this patch set per
email adress / "liveliness groups"? I think most people will ignore a
patch that has tens of CC's, even if their personal ACK is needed for
it. On the other hand, if we have 60-100 patches, but each patch is just
emailed to 2-3 people (and any given person only gets a very low number
of personal patch emails), such a series has a better chance at
succeeding. (We could even commit such a set piece-meal -- commit the
most recently ACKed subset every week or every two weeks.) Just some
speculation on my part.


Yes, I'll try to find a clever way.

(I had the v2 ready, but I was waiting to figure out how to restrict to 
100 recipients).



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51658): https://edk2.groups.io/g/devel/message/51658
Mute This Topic: https://groups.io/mt/61960372/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/8] .mailmap: Add mailmap file to have a cleaner git history

[Laszlo Ersek]

Hi Phil,

(heavily trimmer CC list)

On 11/26/19 16:08, Philippe Mathieu-Daudé via Groups.Io wrote:
> Hi,
> 
> The .mailmap git feature helps fixing commit mistakes (in name/email).
> 
> The easiest way to use it is with the --use-mailmap flag:
> 
>   $ git log --use-mailmap
> 
> See:
> https://git-scm.com/docs/git-shortlog#_mapping_authors
> https://git-scm.com/docs/git-check-mailmap#_mapping_authors
> 
> Also interesting:
> https://github.com/sympy/sympy/wiki/Using-.mailmap#making-mailmap-entries
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (8):
>   .mailmap: Convert emails generated by the Subversion original import
>   .mailmap: Fix emails from the Subversion era
>   .mailmap: Fix Intel emails rewritten by Microsoft Exchange Server
>   .mailmap: Fix emails rewritten by lists DMARC / DKIM / SPF
>   .mailmap: Fix incorrect email formats
>   .mailmap: Unify Intel email addresses format
>   .mailmap: Fix UTF-8 mojibaked names
>   .mailmap: Miscellaneous fixes on various emails
> 
>  .mailmap | 221 +++
>  1 file changed, 221 insertions(+)
>  create mode 100644 .mailmap
> 

our suggestion from the stewards' confcall is to avoid cross-domain
mappings, unless a contributor explicitly confirms (in an email sent
from the mapped-to, i.e. "new" address) that they are OK with the
mapped-from (i.e. "old") address being "hidden" by the mapping.

Due to two reasons:
- mappings across domains could hide employer changes,
- even the "mapped-to" (i.e. "new") address may not be up-to-date.

Stewards may be able ACK typo fixes and simple name order changes even
in the absence of the affected (historical) contributor, but
cross-domain mappings are not something they can ACK on their own.

(At least this is my understanding from the meeting.)

Personal note in the end: can we perhaps structure this patch set per
email adress / "liveliness groups"? I think most people will ignore a
patch that has tens of CC's, even if their personal ACK is needed for
it. On the other hand, if we have 60-100 patches, but each patch is just
emailed to 2-3 people (and any given person only gets a very low number
of personal patch emails), such a series has a better chance at
succeeding. (We could even commit such a set piece-meal -- commit the
most recently ACKed subset every week or every two weeks.) Just some
speculation on my part.

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51657): https://edk2.groups.io/g/devel/message/51657
Mute This Topic: https://groups.io/mt/61960372/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [EXTERNAL] RE: [edk2-devel] Seeking feedback: example of building OvmfPkg with Pytools

[Sean via Groups.Io]

Sorry let me clarify.
The plugin is not designed to work for the VS2015 toolchain.  The plugin is not 
part of pytools but part of edk2 repo.

If you would like to build with VS2017 or VS2019 the plugin will handle your 
path management.
If you are not setting the tool chain on the command line then you should 
update target.txt to use VS2017.

Hope that helps.

Thanks
Sean


From: Matthew Carlson 
Sent: Tuesday, December 3, 2019 10:08 AM
To: Jeremiah Cox ; Feng, Bob C ; 
devel@edk2.groups.io; ler...@redhat.com; Sean Brogan 
; Bret Barkelew 
Subject: RE: [EXTERNAL] RE: [edk2-devel] Seeking feedback: example of building 
OvmfPkg with Pytools

I can confirm that we don’t currently support VS2015, due to the 
VsToolChainPlugin. 
https://github.com/tianocore/edk2/blob/master/BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChain.py


Please file an issue on the GitHub, 
https://github.com/tianocore/edk2-pytool-extensions/issues
 so we can track it and discuss the changes 
The log looks like it’s missing the VS2015_PREFIX environmental variable 
(https://github.com/tianocore/edk2/blob/master/BaseTools/Conf/tools_def.template#L59),
 which should be set by the VsToolChain plugin. It’s possible that the 
TOOL_CHAIN_TAG isn’t specified, but I think it’s much more likely that the 
prefix isn’t being set by the plugin.
Thanks for clarifying my example Jeremiah. Bob, hopefully that makes a little 
more sense.

  *   Matthew Carlson

From: Jeremiah Cox
Sent: Tuesday, December 3, 2019 9:51 AM
To: Matthew Carlson; Feng, Bob 
C; 
devel@edk2.groups.io; 
ler...@redhat.com; Sean 
Brogan; Bret 
Barkelew; Matthew 
Carlson
Subject: Re: [EXTERNAL] RE: [edk2-devel] Seeking feedback: example of building 
OvmfPkg with Pytools

Hi Bob,
The 5.2 failure is expected as we do not support VS2015 yet.  If suggest adding 
a feature request here :

Re: [EXTERNAL] RE: [edk2-devel] Seeking feedback: example of building OvmfPkg with Pytools

[Jeremiah Cox via Groups.Io]

Hi Bob,
The 5.2 failure is expected as we do not support VS2015 yet.  If suggest adding 
a feature request here :
https://github.com/tianocore/edk2-pytool-extensions/issues

Regarding 2. you may need to provide a BLD_ prefix to pass build parameters to 
the platform builder, refer to my README for an example.

In Matt's example for 3, processor family is not x86, but rather a group of 
products that share common architectural components, for example IceLake 
generation products might share many components. This is somewhat similar to 
KabylakeOpenBoardPackage.

@Matthew Carlson, perhaps you could look at the 
second log in 5.2 above, perhaps we are missing a dependency in our 
requirements.txt?  System.Net.Http?


From: Matthew Carlson 
Sent: Tuesday, December 3, 2019 9:04:08 AM
To: Feng, Bob C ; Jeremiah Cox ; 
devel@edk2.groups.io ; ler...@redhat.com 
; Sean Brogan ; Bret Barkelew 
; Matthew Carlson 
Subject: RE: [EXTERNAL] RE: [edk2-devel] Seeking feedback: example of building 
OvmfPkg with Pytools


Hello Bob,



  1.  Right. We actually have three documents forthcoming on how to move 
platforms onto edk2 pytools, one on OVMF, one on Raspberry Pi, and another on 
KabylakeOpenBoardPackage. Jeremiah sent some links to his platform. We’ll have 
more example platforms and tutorial in the future
  2.  Yes. All the remaining arguments get passed into the UefiBuilder itself, 
which parses it and hands it to build.py
  3.  Where ever makes sense. Since it’s a python file, it can be very 
flexible. For our platforms using pytools, it generally goes
PROCESSOR FAMIILY
|  -- ProcessorFamilyPkg
|  -- ProductNamePkg
| |  -- PlatformBuild.py
  4.  Glad to help ??



- Matthew Carlson



From: Feng, Bob C
Sent: Monday, December 2, 2019 11:47 PM
To: Matthew Carlson; Jeremiah 
Cox; 
devel@edk2.groups.io; 
ler...@redhat.com; Sean 
Brogan; Bret 
Barkelew
Subject: RE: [EXTERNAL] RE: [edk2-devel] Seeking feedback: example of building 
OvmfPkg with Pytools



Hi Matthew and Jeremiah,



Thanks for your answers.



  1.  Cool. So platformBuild.py is intent to handle the additional pre-build 
and post-build tasks. I think it would be great if there is a document record 
how to create a PlatformBuild.py.
  2.  So the command-line arguments for build.py can also work for 
PlatformBuild.py. right?
  3.  Where would FamilyBuild.py be located?
  4.  Cool. Thanks.



For 5.2 the error message in BUILD.txt is:



PROGRESS - Running Pre Build

INFO - Cmd to run is: 
e:\pythonvenv1\lib\site-packages\edk2toollib\bin\vswhere.exe -latest -nologo 
-all -property installationPath -products *

INFO - 

INFO - --Cmd Output Starting---

INFO - 

INFO - C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional

INFO - 

INFO - --Cmd Output Finished---

INFO - - Running Time (mm:ss): 00:00 --

INFO - 

DEBUG - Calling 'C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Professional\VC\Auxiliary\Build\vcvarsall.bat amd64'

DEBUG - Getting host info for host: uname_result(system='Windows', 
node='sh1gapp1005', release='10', version='10.0.14393', machine='AMD64', 
processor='Intel64 Family 6 Model 85 Stepping 4, GenuineIntel')

DEBUG - Getting host info for host: uname_result(system='Windows', 
node='sh1gapp1005', release='10', version='10.0.14393', machine='AMD64', 
processor='Intel64 Family 6 Model 85 Stepping 4, GenuineIntel')

DEBUG - Getting host info for host: uname_result(system='Windows', 
node='sh1gapp1005', release='10', version='10.0.14393', machine='AMD64', 
processor='Intel64 Family 6 Model 85 Stepping 4, GenuineIntel')

DEBUG - Plugin Success: Windows RC Path Support

DEBUG - Plugin Success: Windows Visual Studio Tool Chain Support

INFO - Writing BuildToolsReports to 
E:\BobFeng\edk2\Build\Ovmf3264\DEBUG_VS2015x86\BUILD_TOOLS_REPORT

DEBUG - Plugin Success: Build Tools Report Generator

PROGRESS - Running Build DEBUG

DEBUG - Getting all build keys for build type DEBUG

INFO - Cmd to run is: build -p OvmfPkg/OvmfPkgIa32X64.dsc -b DEBUG -t VS2015x86 
-a IA32 -a X64

INFO - 

Re: [edk2-devel] [Patch wiki v2] EDK II Dev Process: Change push to GitHub pull request

[Laszlo Ersek]

On 12/02/19 19:01, Michael D Kinney via Groups.Io wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
>
> Update wiki pages to remove instructions that directly
> push to edk2/master.  Update these instructions to create
> a GitHub pull request from an EDK II Maintainers fork of

I suggest "Maintainer's"

> the edk2 repository.
>
> Cc: Sean Brogan 
> Cc: Bret Barkelew 
> Cc: Liming Gao 
> Cc: Andrew Fish 
> Cc: Laszlo Ersek 
> Cc: Leif Lindholm 
> Signed-off-by: Michael D Kinney 
> ---
>  EDK-II-Development-Process.md | 104 --
>  ...e-for-edk2-contributors-and-maintainers.md |  90 ---
>  images/CreateGitHubPullRequest.png| Bin 0 -> 112984 bytes
>  images/CreateGitHubPullRequest2.png   | Bin 0 -> 177099 bytes
>  4 files changed, 171 insertions(+), 23 deletions(-)
>  create mode 100644 images/CreateGitHubPullRequest.png
>  create mode 100644 images/CreateGitHubPullRequest2.png
>
> diff --git a/EDK-II-Development-Process.md b/EDK-II-Development-Process.md
> index a735e21..a205e83 100644
> --- a/EDK-II-Development-Process.md
> +++ b/EDK-II-Development-Process.md
> @@ -108,14 +108,102 @@ The maintainer process for the EDK II project
>  - Edit lines to have an 'r' to 'reword' the commit. This will
>allow you to add the Reviewed-by attributions.
>
> -6.  Push changes to the EDK II project repository
> --   Pushing the integration branch directly to origin/master is
> -preferred
> -
> -`$ git push origin HEAD:master`
> -
> -- Using the `--dry-run` parameter will show exactly what is going
> -  to be updated. Use this if you are paranoid. :)
> +6.  Push changes to the EDK II maintainer's fork of the EDK II project
> +repository.
> +- How to create a [GitHub 
> fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo)
> +  - **NOTE:** A GitHub fork can also be created using the command line
> +utility called [`hub`](https://github.com/github/hub/releases).  The
> +`hub` usage information can be found 
> [here](https://hub.github.com/hub.1.html).
> +
> +- Add remote to the EDK II maintainer's fork of the EDK II project
> +
> +`$ git remote add  https://github.com/ id>/edk2`

I suggest adding a hyphen into "". (Note: if you agree,
 occurs in other locations in this patch, so please
update those too.)

Furthermore, I believe the remote reference (in the HTTPS scheme)
carries a ".git" suffix. (It's not enforced by github.com but it's the
pattern it copies to your clipboard you when you use the "clone this
repo" feature on the webui.) IIRC


> +
> +- Push the integration branch to `/master`.  Add the
> +  `--dry-run` parameter to show exactly what is going to be updated 
> before
> +  pushing to a public branch. Use this if you are paranoid. :)
> +
> +`$ git push  `
> +

I think this is not fully consistent -- with the above "git push"
command, the  name will refer to both the local
branch name and the new remote branch name.

That's fine per se (and it does match point #7 below), but it does not
match the paragraph just above. (Which tells us to push to
/master.)

I think it's simplest if we just drop that paragraph -- I think we
should only refer to the integration branch in this article, and not to
the fork's master branch.

I think the "--dry-run" reference is no longer necessary either -- with
the new process, the maintainer cannot directly push to the core repo,
so the risk to mess up things has been greatly redudced.

> +7.  Create a GitHub pull request from the EDK II maintainer's
> +``  to `edk2/master` setting the **`push`** 
> label.
> +If all checks pass, the changes are strict rebase merged.  If the

again, s/rebase/fast-forward/ -- but perhaps "strict rebase merged" is
established github.com lingo. I'm unsure.

> +**`push`** label is not set, then the checks are run, but no changes are
> +merged.
> +
> +- How to create a [GitHub pull 
> request](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request)
> +  - **NOTE:** A GitHub pull request can also be created using the command
> +line utility called [`hub`](https://github.com/github/hub/releases).
> +The `hub` usage information can be found 
> [here](https://hub.github.com/hub.1.html).
> +
> +- Add the [TianoCore Bugzilla](https://bugzilla.tianocore.org/) issue
> +  number(s) resolved by the pull request to the pull request title.

Hm, OK. That's useful. Thanks.

> +
> +- If `` is a patch series, then copy the patch #0
> +  summary commit message into the pull request description.

I suggest removing "commit message"; just "summary" sounds great.

> +
> +- If the EDK II Maintainer wants the patches from 
> ``
> +  to be merged into `edk2/master` using strict rebase, then the 
> **`push`**

s/rebase/fast-forward/?

> +  label must be set.  By default, pull requests 

Re: [edk2-devel] EDK II Stable Tag release edk2-stable201911 completed

[Takuto Naito]

Hi Liming,

Congrats on releasing edk2-stable201911.
Could you add ShellBinPkg.zip to the assets of the release on GitHub?

ShellPkg of the new tag includes many improvements. ShellBinPkg.zip is helpful 
to use it.

Regards,
Takuto

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51653): https://edk2.groups.io/g/devel/message/51653
Mute This Topic: https://groups.io/mt/64493623/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 31/79] NetworkPkg: Fix a typo

[Philippe Mathieu-Daudé]

On 12/3/19 6:18 PM, Leif Lindholm wrote:

Hi Phil,

On Tue, Dec 03, 2019 at 17:15:14 +0100, Philippe Mathieu-Daude wrote:

Correctly write 'malformatted' in documentation, comments and
debug strings.

Cc: Andrew Fish 
Cc: Laszlo Ersek 
Cc: Leif Lindholm 
Cc: Michael D Kinney 


I would have expected:
   Jiaxin Wu 
   Siyuan Fu 
   Maciej Rabeda 
to be cc:d on NetworkPkg patches (added here).
Was there a GetMaintainer.py failure?


Human failure due to manual edition :S

Thanks for caring to Cc to correct maintainers.


/
 Leif


Signed-off-by: Philippe Mathieu-Daude 
---
  NetworkPkg/Dhcp4Dxe/Dhcp4Option.h|  6 +++---
  NetworkPkg/Ip4Dxe/Ip4Icmp.h  |  2 +-
  NetworkPkg/Ip4Dxe/Ip4Igmp.h  |  2 +-
  NetworkPkg/Ip4Dxe/Ip4Option.h|  4 ++--
  NetworkPkg/Ip6Dxe/Ip6Icmp.h  |  4 ++--
  NetworkPkg/Mtftp4Dxe/Mtftp4Option.h  |  4 ++--
  NetworkPkg/Dhcp4Dxe/Dhcp4Option.c| 10 +-
  NetworkPkg/Ip4Dxe/Ip4Icmp.c  |  2 +-
  NetworkPkg/Ip4Dxe/Ip4Igmp.c  |  2 +-
  NetworkPkg/Ip4Dxe/Ip4Option.c|  2 +-
  NetworkPkg/Ip6Dxe/Ip6Icmp.c  |  4 ++--
  NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 10 +-
  NetworkPkg/Mtftp4Dxe/Mtftp4Option.c  |  6 +++---
  NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c |  2 +-
  NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c |  2 +-
  NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c |  2 +-
  NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c |  2 +-
  17 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h 
b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
index 9e25386507ed..393176c8996d 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
@@ -133,7 +133,7 @@ DhcpIterateOptions (
@param[out] Para   The variable to save the DHCP parameters.
  
@retval EFI_OUT_OF_RESOURCES   Failed to allocate memory to validate the packet.

-  @retval EFI_INVALID_PARAMETER  The options are mal-formated
+  @retval EFI_INVALID_PARAMETER  The options are malformatted
@retval EFI_SUCCESSThe options are parsed into OptionPoint
  
  **/

@@ -167,7 +167,7 @@ DhcpValidateOptions (
  
@retval EFI_NOT_FOUND  Cannot find any option.

@retval EFI_OUT_OF_RESOURCES   Failed to allocate memory to parse the 
packet.
-  @retval EFI_INVALID_PARAMETER  The options are mal-formated
+  @retval EFI_INVALID_PARAMETER  The options are malformatted
@retval EFI_SUCCESSThe options are parsed into OptionPoint
  
  **/

@@ -211,7 +211,7 @@ DhcpAppendOption (
   function.
  
@retval EFI_OUT_OF_RESOURCES   Failed to allocate memory

-  @retval EFI_INVALID_PARAMETER  The options in SeekPacket are mal-formated
+  @retval EFI_INVALID_PARAMETER  The options in SeekPacket are malformatted
@retval EFI_SUCCESSThe packet is build.
  
  **/

diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.h b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
index 922886a96e67..a52200176f5a 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Icmp.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
@@ -83,7 +83,7 @@ extern EFI_IP4_ICMP_TYPE  mIp4SupportedIcmp[];
@param[in]  Packet The content of the ICMP query with IP4 head
   removed.
  
-  @retval EFI_INVALID_PARAMETER  The packet is malformated.

+  @retval EFI_INVALID_PARAMETER  The packet is malformatted.
@retval EFI_SUCCESSThe ICMP message is successfully processed.
@retval Others Failed to handle ICMP packet.
  
diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.h b/NetworkPkg/Ip4Dxe/Ip4Igmp.h

index 0cc944594441..49c13ba3a7a0 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Igmp.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
@@ -111,7 +111,7 @@ Ip4LeaveGroup (
@param[in]  Head   The IP4 header of the received message.
@param[in]  Packet The IGMP message, without IP4 header.
  
-  @retval EFI_INVALID_PARAMETER  The IGMP message is malformated.

+  @retval EFI_INVALID_PARAMETER  The IGMP message is malformatted.
@retval EFI_SUCCESSThe IGMP message is successfully processed.
  
  **/

diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.h b/NetworkPkg/Ip4Dxe/Ip4Option.h
index 57a5a58725f0..a39fd2b4c69d 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Option.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Option.h
@@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
  /**
Validate the IP4 option format for both the packets we received
and will transmit. It will compute the ICMP error message fields
-  if the option is mal-formated. But this information isn't used.
+  if the option is malformatted. But this information isn't used.
  
@param[in]  OptionThe first byte of the option

@param[in]  OptionLen The length of the whole option
@@ -28,7 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
  otherwise the option we wants to transmit.
  
@retval TRUE The 

Re: [edk2-devel] [PATCH 31/79] NetworkPkg: Fix a typo

[Leif Lindholm]

Hi Phil,

On Tue, Dec 03, 2019 at 17:15:14 +0100, Philippe Mathieu-Daude wrote:
> Correctly write 'malformatted' in documentation, comments and
> debug strings.
> 
> Cc: Andrew Fish 
> Cc: Laszlo Ersek 
> Cc: Leif Lindholm 
> Cc: Michael D Kinney 

I would have expected:
  Jiaxin Wu 
  Siyuan Fu 
  Maciej Rabeda 
to be cc:d on NetworkPkg patches (added here).
Was there a GetMaintainer.py failure?

/
Leif

> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  NetworkPkg/Dhcp4Dxe/Dhcp4Option.h|  6 +++---
>  NetworkPkg/Ip4Dxe/Ip4Icmp.h  |  2 +-
>  NetworkPkg/Ip4Dxe/Ip4Igmp.h  |  2 +-
>  NetworkPkg/Ip4Dxe/Ip4Option.h|  4 ++--
>  NetworkPkg/Ip6Dxe/Ip6Icmp.h  |  4 ++--
>  NetworkPkg/Mtftp4Dxe/Mtftp4Option.h  |  4 ++--
>  NetworkPkg/Dhcp4Dxe/Dhcp4Option.c| 10 +-
>  NetworkPkg/Ip4Dxe/Ip4Icmp.c  |  2 +-
>  NetworkPkg/Ip4Dxe/Ip4Igmp.c  |  2 +-
>  NetworkPkg/Ip4Dxe/Ip4Option.c|  2 +-
>  NetworkPkg/Ip6Dxe/Ip6Icmp.c  |  4 ++--
>  NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 10 +-
>  NetworkPkg/Mtftp4Dxe/Mtftp4Option.c  |  6 +++---
>  NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c |  2 +-
>  NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c |  2 +-
>  NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c |  2 +-
>  NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c |  2 +-
>  17 files changed, 33 insertions(+), 33 deletions(-)
> 
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h 
> b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
> index 9e25386507ed..393176c8996d 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
> @@ -133,7 +133,7 @@ DhcpIterateOptions (
>@param[out] Para   The variable to save the DHCP 
> parameters.
>  
>@retval EFI_OUT_OF_RESOURCES   Failed to allocate memory to validate the 
> packet.
> -  @retval EFI_INVALID_PARAMETER  The options are mal-formated
> +  @retval EFI_INVALID_PARAMETER  The options are malformatted
>@retval EFI_SUCCESSThe options are parsed into OptionPoint
>  
>  **/
> @@ -167,7 +167,7 @@ DhcpValidateOptions (
>  
>@retval EFI_NOT_FOUND  Cannot find any option.
>@retval EFI_OUT_OF_RESOURCES   Failed to allocate memory to parse the 
> packet.
> -  @retval EFI_INVALID_PARAMETER  The options are mal-formated
> +  @retval EFI_INVALID_PARAMETER  The options are malformatted
>@retval EFI_SUCCESSThe options are parsed into OptionPoint
>  
>  **/
> @@ -211,7 +211,7 @@ DhcpAppendOption (
>   function.
>  
>@retval EFI_OUT_OF_RESOURCES   Failed to allocate memory
> -  @retval EFI_INVALID_PARAMETER  The options in SeekPacket are mal-formated
> +  @retval EFI_INVALID_PARAMETER  The options in SeekPacket are malformatted
>@retval EFI_SUCCESSThe packet is build.
>  
>  **/
> diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.h b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
> index 922886a96e67..a52200176f5a 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4Icmp.h
> +++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
> @@ -83,7 +83,7 @@ extern EFI_IP4_ICMP_TYPE  mIp4SupportedIcmp[];
>@param[in]  Packet The content of the ICMP query with IP4 head
>   removed.
>  
> -  @retval EFI_INVALID_PARAMETER  The packet is malformated.
> +  @retval EFI_INVALID_PARAMETER  The packet is malformatted.
>@retval EFI_SUCCESSThe ICMP message is successfully processed.
>@retval Others Failed to handle ICMP packet.
>  
> diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.h b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
> index 0cc944594441..49c13ba3a7a0 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4Igmp.h
> +++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
> @@ -111,7 +111,7 @@ Ip4LeaveGroup (
>@param[in]  Head   The IP4 header of the received message.
>@param[in]  Packet The IGMP message, without IP4 header.
>  
> -  @retval EFI_INVALID_PARAMETER  The IGMP message is malformated.
> +  @retval EFI_INVALID_PARAMETER  The IGMP message is malformatted.
>@retval EFI_SUCCESSThe IGMP message is successfully processed.
>  
>  **/
> diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.h b/NetworkPkg/Ip4Dxe/Ip4Option.h
> index 57a5a58725f0..a39fd2b4c69d 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4Option.h
> +++ b/NetworkPkg/Ip4Dxe/Ip4Option.h
> @@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  /**
>Validate the IP4 option format for both the packets we received
>and will transmit. It will compute the ICMP error message fields
> -  if the option is mal-formated. But this information isn't used.
> +  if the option is malformatted. But this information isn't used.
>  
>@param[in]  OptionThe first byte of the option
>@param[in]  OptionLen The length of the whole option
> @@ -28,7 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  otherwise the option we wants to transmit.
>  
>@retval TRUE 

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

[Michael D Kinney]

Hi Laszlo,

I can think of ways we may be able to get the label 
information into the body of the email in a PR comment.
I will have to see if there is anyway to adjust the subject
of the email.  The subject appears to always match the title
of the PR.  That title is editable, but may only be editable
using GitHub APIs.  Mergify does not support that feature 
today.

If you look at the following file, you will see the current
Mergify rules.

https://github.com/tianocore/edk2/blob/master/.mergify/config.yml

If I look at the 3rd rule for merge conflicts, I could split
that out into 2 rules.  One for push label set and one for
push label not set and adjust the message generated to state
if the conflict is on a personal build or a push request.

Would small adjustments like this in the body of the email
notifications help?  If we make the generated messages consistent
email filters on the content of the email body can be used 
instead of email filters on the email subject.

Each developer can enable/disable the 'Watch' feature on the
edk2 repo.  That is a developer setting, not a team setting.

Mike

> -Original Message-
> From: Laszlo Ersek 
> Sent: Tuesday, December 3, 2019 12:56 AM
> To: Kinney, Michael D ;
> devel@edk2.groups.io; Sean Brogan
> ; Bret Barkelew
> ; Gao, Liming
> 
> Subject: Re: [edk2-devel] EDK II Maintainers - EDK II
> CI is now active on edk2/master
> 
> On 12/02/19 20:55, Kinney, Michael D wrote:
> 
> > So my question still stands.  What notifications
> would
> > you like to see if we have the use case of a single
> PR
> > with multiple rounds of reviews and a transition from
> > a PR without the 'push' label to a PR with a 'push'
> label?
> 
> Thank you for explaining.
> 
> In this case, I think it would be helpful if, whenever
> another email
> notification were sent out about a PR, the subject of
> that email
> contained an auto-generated part that advertized the
> push label's
> presence on the PR, at that time.
> 
> OTOH... It's also possible that I'm approaching this
> wrong. After all,
> before we adopted github.com for pushing, a maintainer
> would just go
> ahead and push post-review (with no *automatic* email
> notification about
> the fact), and then we'd expect that maintainer to
> report back under the
> patch review thread ("pushed as commit range ..."),
> and/or close the BZ
> ticket with a similar comment. (And then there would be
> an
> auto-generated bugzilla email about that.)
> 
> My point being, maybe I shouldn't even *read* these
> github.com
> notifications at all. I'm not sure if they give me
> useful information.
> (When the PR is ultimately merged, we *still* require
> the above kind of
> closing comment in Bugzilla, from the maintainer --
> thus the originally
> needed information is still provided, just like
> before.)
> 
> It's just that, *if* I attempt to read the github.com
> emails, *then*
> they confuse me (for example because they don't expose
> the push label).
> If we consider this specific kind of PR that we have
> adopted for edk2 a
> (practically) "maintainer-internal", mechanical,
> action, then I guess I
> might as well want to unsubscribe from those
> notifications. After all
> I'm still subscribed to BZ emails, and I'll see the
> resultant commit
> range noted there (through the comment that the
> assignee adds manually,
> when they close the BZ).
> 
> Is it possible for a tianocore group member to
> "unwatch" PRs?
> 
> Thanks!
> Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51649): https://edk2.groups.io/g/devel/message/51649
Mute This Topic: https://groups.io/mt/53725670/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch wiki v2] EDK II CI: Update Phase 1 details and admin settings

[Laszlo Ersek]

On 12/02/19 18:56, Michael D Kinney via Groups.Io wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
> 
> Update wiki pages providing details of the Phase 1
> EDK II Continuous Integration features and links to all
> supporting documentation.  Also provide notes for admins
> to configure GitHub, Azure Pipelines, and Mergify.
> 
> Cc: Sean Brogan 
> Cc: Bret Barkelew 
> Cc: Liming Gao 
> Cc: Andrew Fish 
> Cc: Laszlo Ersek 
> Cc: Leif Lindholm 
> Signed-off-by: Michael D Kinney 
> ---
>  ...I-Continuous-Integration-Administration.md | 100 ++
>  EDK-II-Continuous-Integration.md  |  75 ++---
>  2 files changed, 162 insertions(+), 13 deletions(-)
>  create mode 100644 EDK-II-Continuous-Integration-Administration.md
> 
> diff --git a/EDK-II-Continuous-Integration-Administration.md 
> b/EDK-II-Continuous-Integration-Administration.md
> new file mode 100644
> index 000..669d28a
> --- /dev/null
> +++ b/EDK-II-Continuous-Integration-Administration.md
> @@ -0,0 +1,100 @@
> +# EDK II Continuous Integration Administration
> +
> +## Configuring edk2 repository
> +
> +1) Azure Pipelines Configuration Steps Part I
> +   1) Goto https://dev.azure.com/tianocore
> +   2) Create new project in TianoCore org called `edk2-ci`
> +   3) Disable Boards
> +   4) Disable Repositories
> +
> +2) GitHub Configuration Steps Part I
> +   1) Goto https://github.com/tianocore
> +   2) Select Settings
> +   3) Select Installed GitHub Apps
> +   4) Select Azure Pipelines -> Configure
> +  * Enable `tianocore/edk2` repository
> +  * Redirects to Azure Pipelines login.  Select TianoCore org and
> +`edk2-ci` project to complete link and authentication between Azure
> +Pipelines TianoCore organization and GitHub TianoCore organization.
> +
> +3) Azure Pipelines Configuration Steps Part II
> +   1) Goto https://dev.azure.com/tianocore/edk2-ci/_build
> +   2) Create New Pipeline called `Ubuntu GCC5 CI` for post commit checks
> +  * YAML: Select file 
> https://github.com/tianocore/edk2/blob/master/.azurepipelines/Ubuntu-GCC5.yml
> +  * Name: Set to `Ubuntu GCC5 CI`
> +  * Triggers:
> +* CI - No changes
> +* PR - Override + Disable
> +  * Variables: No changes
> +  * Save pipeline changes
> +  * Run pipeline and verify all checks pass
> +   3) Create New Pipeline called `Windows VS2019 CI` for post commit checks
> +  * YAML: Select file 
> https://github.com/tianocore/edk2/blob/master/.azurepipelines/Windows-VS2019.yml
> +  * Name: `Windows VS2019 CI`
> +  * Triggers
> +* CI - No changes
> +* PR - Override + Disable
> +  * Variables: No changes
> +  * Save pipeline changes
> +  * Run pipeline and verify all checks pass
> +   4) Create New Pipeline called `Ubuntu GCC5 PR` for pre commit checks
> +  * YAML: Select file 
> https://github.com/tianocore/edk2/blob/master/.azurepipelines/Ubuntu-GCC5.yml
> +  * Name: `Ubuntu GCC5 PR`
> +  * Triggers
> +* CI - Override + Disable
> +* PR - No changes
> +  * Variables: No changes
> +  * Save pipeline changes
> +  * Run pipeline.  Pipeline will fail because it requires a GitHub PR.  
> Must
> +run for pipeline name to show up in GitHub Branch Protection Rules.
> +   5) Create New Pipeline called `Windows VS2019 PR` for pre commit checks
> +  * YAML: Select file 
> https://github.com/tianocore/edk2/blob/master/.azurepipelines/Windows-VS2019.yml
> +  * Name: `Windows VS2019 PR`
> +  * Triggers
> +* CI - Override + Disable
> +* PR - No changes
> +  * Variables: No changes
> +  * Save pipeline changes
> +  * Run pipeline.  Pipeline will fail because it requires a GitHub PR.  
> Must
> +run for pipeline name to show up in GitHub Branch Protection Rules.
> +   6) Add PatchCheck pipeline for pre commit checks
> +  * YAML: Select file 
> https://github.com/tianocore/edk2/blob/master/.azurepipelines/Ubuntu-PatchCheck.yml
> +  * Name: `tianocore.PatchCheck`
> +  * Triggers
> +* CI - Override + Disable
> +* PR - No changes
> +  * Variables: No changes
> +  * Save pipeline changes
> +  * Run pipeline.  Pipeline will fail because it requires a GitHub PR.  
> Must
> +run for pipeline name to show up in GitHub Branch Protection Rules.
> +
> +4) GitHub Configuration Steps Part II
> +   1) Goto https://github.com/tianocore/edk2
> +   2) Select Settings
> +   3) Select  Branches

Double space character.

> +   4) Select Branch Protection Rules
> +   5) Select `master` -> Edit
> +  * Enable `Require status checks to pass before merging`
> +  * Enable `Require branches to be up to date before merging`
> +  * Enable `Windows VS2019 PR` check
> +  * Enable `Ubuntu GCC5 PR` check
> +  * Enable `tianocore.PatchCheck` check
> +   6) Goto https://github.com/tianocore
> +   7) Select Settings
> +   8) Select Installed 

Re: [edk2-devel] [PATCH 02/79] EmbeddedPkg/FdtLib: Fix a typo

[Leif Lindholm]

Hi Phil, Antoine,

This file is imported from an external project, and arguably we should
be converting the libfdt import to a submodule instead. So I'd prefer
not pulling this one in.

/
Leif

On Tue, Dec 03, 2019 at 17:14:45 +0100, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur 
> 
> Fix a typo in a comment.
> 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 
> ---
>  EmbeddedPkg/Include/libfdt.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmbeddedPkg/Include/libfdt.h b/EmbeddedPkg/Include/libfdt.h
> index 141ecb579bde..606c80a0e8ca 100644
> --- a/EmbeddedPkg/Include/libfdt.h
> +++ b/EmbeddedPkg/Include/libfdt.h
> @@ -107,7 +107,7 @@
>* nodes, or subnodes preceding properties). */
>  #define FDT_ERR_BADLAYOUT12
>   /* FDT_ERR_BADLAYOUT: For read-write functions, the given
> -  * device tree has it's sub-blocks in an order that the
> +  * device tree has its sub-blocks in an order that the
>* function can't handle (memory reserve map, then structure,
>* then strings).  Use fdt_open_into() to reorganize the tree
>* into a form suitable for the read-write operations. */
> -- 
> 2.21.0

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51648): https://edk2.groups.io/g/devel/message/51648
Mute This Topic: https://groups.io/mt/65772875/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos

[Anthony PERARD]

On Tue, Dec 03, 2019 at 05:15:44PM +0100, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur 
> 
> Fix various typos in comments and documentation.
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Ard Biesheuvel 
> Cc: Anthony Perard 
> Cc: Julien Grall 
> Reviewed-by: Philippe Mathieu-Daude 
> Signed-off-by: Philippe Mathieu-Daude 

There's seems to be missing SoB from Antoine. Could that be added?

I might try to send the part of this patch that modify the Xen public
headers upstream (the headers in IndustryStandard/Xen).

Otherwise, the patch looks fine.

Thanks,

-- 
Anthony PERARD

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51647): https://edk2.groups.io/g/devel/message/51647
Mute This Topic: https://groups.io/mt/65782892/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 60/79] OvmfPkg/Xen: Fix a typo

[Anthony PERARD]

On Tue, Dec 03, 2019 at 05:15:43PM +0100, Philippe Mathieu-Daude wrote:
> Fix a typo in a comment.
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Ard Biesheuvel 
> Cc: Anthony Perard 
> Cc: Julien Grall 
> Signed-off-by: Philippe Mathieu-Daude 

Acked-by: Anthony PERARD 

Thanks,

-- 
Anthony PERARD

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51646): https://edk2.groups.io/g/devel/message/51646
Mute This Topic: https://groups.io/mt/65782662/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)

[Cœur]

Woah, thank you for the work, Philippe.

Tell me if there is anything I can do to help.

Antoine

Le 04/12/2019 à 00:14, Philippe Mathieu-Daude a écrit :

Around February of this year, Antoine posted various patches fixing
a huge quantity of typos, over 8000+ lines (such [1]).

The community merged the smaller patches, and told him his patches
were too big, and he should split them.
Around June, Antoine opened a GitHub pull request [2], due to the
size of his patchset. We told him the project doesn't accept GitHub
PR.

Since I find his cleanup work very valuable for the project, I
spent few hours trying to salvage a chunk of it, splitting per
maintainer areas, each patch not to big to avoid reviewers burning
out. I expect each maintainer to take his patches.

I wanted to split Antoine work in 3 parts, but I'm about at 80
patches, for only 1854 lines changed, so enough for a first round.

Oh, and it is easier to review the patches using '--word-diff=color'
git option :)

Regards,

Phil.

P.D.: I think the project is really failing at getting new
contributors involved, and keeping them. But that is another topic.

[1] https://edk2.groups.io/g/devel/message/43043
[2] https://edk2.groups.io/g/devel/message/42941

Antoine Coeur (72):
   CryptoPkg/OpensslLib: Fix few typos
   EmbeddedPkg/FdtLib: Fix a typo
   EmbeddedPkg/VirtualKeyboard: Fix few typos
   EmulatorPkg/Sec: Fix various typos
   EmulatorPkg/Unix: Fix various typos
   EmulatorPkg/Win: Fix various typos
   FatPkg/EnhancedFatDxe: Fix various typos
   FatPkg/FatPei: Fix few typos
   IntelFsp2WrapperPkg: Fix various typos
   MdeModulePkg/Application: Improve French translation
   MdeModulePkg/Application: Fix various typos
   MdeModulePkg/Bus/Ata: Fix various typos
   MdeModulePkg/Bus/I2c: Fix few typos
   MdeModulePkg/Bus/Isa: Fix various typos
   MdeModulePkg/Bus/Scsi: Fix various typos
   MdeModulePkg/Bus/Sd: Fix various typos
   MdeModulePkg/Core/Pei: Fix various typos
   MdeModulePkg/Core/PiSmmCore: Fix various typos
   MdeModulePkg/UsbMass: Fix various typos
   MdeModulePkg/UsbMouse: Fix few typos
   MdeModulePkg/UsbBus: Fix various typos
   MdeModulePkg/Usb: Fix various typos
   MdePkg/IndustryStandard: Fix various typos
   MdePkg/Library/Dxe: Fix various typos
   MdePkg/Library/Pci: Fix various typos
   MdePkg/Library/Smm: Fix various typos
   MdePkg/Ppi: Fix various typos
   MdePkg/Register: Fix various typos
   NetworkPkg/ArpDxe: Fix various typos
   NetworkPkg/Dhcp4Dxe: Fix various typos
   NetworkPkg/Dhcp6Dxe: Fix various typos
   NetworkPkg/DnsDxe: Fix various typos
   NetworkPkg/DpcDxe: Fix few typos
   NetworkPkg/HttpBootDxe: Fix various typos
   NetworkPkg/HttpDxe: Fix various typos
   NetworkPkg/Ip4Dxe: Fix various typos
   NetworkPkg/Ip6Dxe: Fix various typos
   NetworkPkg/IScsiDxe: Fix various typos
   NetworkPkg/Library: Fix various typos
   NetworkPkg/MnpDxe: Fix various typos
   NetworkPkg/Mtftp4Dxe: Fix various typos
   NetworkPkg/Mtftp6Dxe: Fix various typos
   NetworkPkg/SnpDxe: Fix few typos
   NetworkPkg/TcpDxe/Sock: Fix few typos
   NetworkPkg/TcpDxe/Tcp: Fix various typos
   NetworkPkg/Tls: Fix few typos
   NetworkPkg/Udp4Dxe: Fix various typos
   NetworkPkg/Udp6Dxe: Fix various typos
   NetworkPkg/UefiPxeBcDxe: Fix various typos
   NetworkPkg/VlanConfigDxe: Fix few typos
   OvmfPkg/Acpi: Fix few typos
   OvmfPkg/Csm: Fix various typos
   OvmfPkg/Qemu: Fix various typos
   OvmfPkg/Virtio: Fix few typos
   OvmfPkg/Xen: Fix various typos
   PcAtChipsetPkg: Fix few typos
   SecurityPkg: Fix few typos
   SecurityPkg/Hash2DxeCrypto: Fix few typos
   SecurityPkg/Library/Tpm: Fix various typos
   SecurityPkg/Tcg: Fix various typos
   SecurityPkg/VariableAuthenticated: Fix few typos
   ShellPkg/Application: Fix various typos
   ShellPkg/DynamicCommand: Fix various typos
   SignedCapsulePkg: Fix various typos
   SignedCapsulePkg/Universal: Fix various typos
   SourceLevelDebugPkg/DebugAgent: Fix various typos
   SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
   SourceLevelDebugPkg: Fix few typos
   StandaloneMmPkg: Fix few typos
   UefiCpuPkg/CpuDxe: Fix few typos
   UefiCpuPkg/PiSmm: Fix various typos
   UefiCpuPkg/Smm: Fix various typos

Philippe Mathieu-Daude (7):
   EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER
   MdeModulePkg/UsbBusDxe: Fix a typo
   NetworkPkg: Fix a typo
   NetworkPkg/DnsDxe: Fix a typo
   NetworkPkg/HttpBootDxe: Fix a typo in variable name
   OvmfPkg/Xen: Fix a typo
   StandaloneMmPkg: Fix a typo

  SignedCapsulePkg/SignedCapsulePkg.dec 
  |  4 +-
  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf  
  |  2 +-
  MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf  
  |  2 +-
  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf  
  | 10 ++--
  MdePkg/Library/DxePcdLib/DxePcdLib.inf  

[edk2-devel] [PATCH 35/79] NetworkPkg/DnsDxe: Fix a typo

[Philippe Mathieu-Daudé]

Fix the same typo in various comments.

Cc: Jiaxin Wu 
Cc: Siyuan Fu 
Cc: Maciej Rabeda 
Signed-off-by: Philippe Mathieu-Daude 
---
 NetworkPkg/DnsDxe/DnsImpl.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c
index ca4ef506a08a..4c232740be3f 100644
--- a/NetworkPkg/DnsDxe/DnsImpl.c
+++ b/NetworkPkg/DnsDxe/DnsImpl.c
@@ -1179,7 +1179,7 @@ ParseDnsResponse (
   RemainingLength  = Length;
 
   //
-  // Check whether the remaining packet length is avaiable or not.
+  // Check whether the remaining packet length is available or not.
   //
   if (RemainingLength <= sizeof (DNS_HEADER)) {
 *Completed = FALSE;
@@ -1217,7 +1217,7 @@ ParseDnsResponse (
   QueryNameLen = (UINT32) AsciiStrLen (QueryName) + 1;
 
   //
-  // Check whether the remaining packet length is avaiable or not.
+  // Check whether the remaining packet length is available or not.
   //
   if (RemainingLength <= QueryNameLen + sizeof (DNS_QUERY_SECTION)) {
 *Completed = FALSE;
@@ -1376,7 +1376,7 @@ ParseDnsResponse (
   //
   while (AnswerSectionNum < DnsHeader->AnswersNum) {
 //
-// Check whether the remaining packet length is avaiable or not.
+// Check whether the remaining packet length is available or not.
 //
 if (RemainingLength <= sizeof (UINT16) + sizeof (DNS_ANSWER_SECTION)) {
   *Completed = FALSE;
@@ -1404,7 +1404,7 @@ ParseDnsResponse (
 AnswerSection->DataLength = NTOHS (AnswerSection->DataLength);
 
 //
-// Check whether the remaining packet length is avaiable or not.
+// Check whether the remaining packet length is available or not.
 //
 if (RemainingLength < AnswerSection->DataLength) {
   *Completed = FALSE;
-- 
2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51640): https://edk2.groups.io/g/devel/message/51640
Mute This Topic: https://groups.io/mt/65773923/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 36/79] NetworkPkg/DnsDxe: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jiaxin Wu 
Cc: Siyuan Fu 
Cc: Maciej Rabeda 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 NetworkPkg/DnsDxe/DnsDriver.h   | 12 -
 NetworkPkg/DnsDxe/DnsImpl.h | 28 ++--
 NetworkPkg/DnsDxe/DnsDriver.c   | 12 -
 NetworkPkg/DnsDxe/DnsImpl.c | 20 +++---
 NetworkPkg/DnsDxe/DnsProtocol.c | 16 +--
 5 files changed, 44 insertions(+), 44 deletions(-)

diff --git a/NetworkPkg/DnsDxe/DnsDriver.h b/NetworkPkg/DnsDxe/DnsDriver.h
index 471b1134ddb3..67365ca81a1b 100644
--- a/NetworkPkg/DnsDxe/DnsDriver.h
+++ b/NetworkPkg/DnsDxe/DnsDriver.h
@@ -318,7 +318,7 @@ Dns4DriverBindingSupported (
   @retval EFI_SUCCESS  The device was started.
   @retval EFI_DEVICE_ERROR The device could not be started due to a 
device error.Currently not implemented.
   @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a 
lack of resources.
-  @retval Others   The driver failded to start the device.
+  @retval Others   The driver failed to start the device.
 
 **/
 EFI_STATUS
@@ -446,7 +446,7 @@ Dns6DriverBindingSupported (
   @retval EFI_SUCCESS  The device was started.
   @retval EFI_DEVICE_ERROR The device could not be started due to a 
device error.Currently not implemented.
   @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a 
lack of resources.
-  @retval Others   The driver failded to start the device.
+  @retval Others   The driver failed to start the device.
 
 **/
 EFI_STATUS
@@ -504,7 +504,7 @@ Dns6DriverBindingStop (
  then a new handle is created. If it is a pointer to 
an existing UEFI handle,
  then the protocol is added to the existing UEFI 
handle.
 
-  @retval EFI_SUCCESThe protocol was added to ChildHandle.
+  @retval EFI_SUCCESS   The protocol was added to ChildHandle.
   @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
   @retval EFI_OUT_OF_RESOURCES  There are not enough resources available to 
create
 the child
@@ -528,7 +528,7 @@ Dns4ServiceBindingCreateChild (
   @param[in] ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
   @param[in] ChildHandle Handle of the child to destroy
 
-  @retval EFI_SUCCESThe protocol was removed from ChildHandle.
+  @retval EFI_SUCCESS   The protocol was removed from ChildHandle.
   @retval EFI_UNSUPPORTED   ChildHandle does not support the protocol that 
is being removed.
   @retval EFI_INVALID_PARAMETER Child handle is NULL.
   @retval EFI_ACCESS_DENIED The protocol could not be removed from the 
ChildHandle
@@ -555,7 +555,7 @@ Dns4ServiceBindingDestroyChild (
  then a new handle is created. If it is a pointer to 
an existing UEFI handle,
  then the protocol is added to the existing UEFI 
handle.
 
-  @retval EFI_SUCCESThe protocol was added to ChildHandle.
+  @retval EFI_SUCCESS   The protocol was added to ChildHandle.
   @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
   @retval EFI_OUT_OF_RESOURCES  There are not enough resources available to 
create
 the child
@@ -579,7 +579,7 @@ Dns6ServiceBindingCreateChild (
   @param[in] ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
   @param[in] ChildHandle Handle of the child to destroy
 
-  @retval EFI_SUCCESThe protocol was removed from ChildHandle.
+  @retval EFI_SUCCESS   The protocol was removed from ChildHandle.
   @retval EFI_UNSUPPORTED   ChildHandle does not support the protocol that 
is being removed.
   @retval EFI_INVALID_PARAMETER Child handle is NULL.
   @retval EFI_ACCESS_DENIED The protocol could not be removed from the 
ChildHandle
diff --git a/NetworkPkg/DnsDxe/DnsImpl.h b/NetworkPkg/DnsDxe/DnsImpl.h
index fdab9c75e3f3..10bc399e9ed5 100644
--- a/NetworkPkg/DnsDxe/DnsImpl.h
+++ b/NetworkPkg/DnsDxe/DnsImpl.h
@@ -182,7 +182,7 @@ typedef struct {
   @param[in] TokenMap  All DNSv4 Token entrys.
   @param[in] TokenEntryTokenEntry need to be removed.
 
-  @retval EFI_SUCCESS  Remove TokenEntry from TokenMap sucessfully.
+  @retval EFI_SUCCESS  Remove TokenEntry from TokenMap successfully.
   @retval EFI_NOT_FOUNDTokenEntry is not found in TokenMap.
 
 **/
@@ -198,7 +198,7 @@ Dns4RemoveTokenEntry (
   @param[in] TokenMap   All DNSv6 Token entrys.
   @param[in] TokenEntry TokenEntry need to be removed.
 
-  @retval EFI_SUCCESS   Remove TokenEntry from TokenMap sucessfully.
+  @retval EFI_SUCCESS   Remove TokenEntry from TokenMap successfully.
   @retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
 
 **/
@@ -209,7 +209,7 @@ 

[edk2-devel] [PATCH 38/79] NetworkPkg/HttpBootDxe: Fix a typo in variable name

[Philippe Mathieu-Daudé]

Correctly write 'Initialized'.

Cc: Jiaxin Wu 
Cc: Siyuan Fu 
Cc: Maciej Rabeda 
Signed-off-by: Philippe Mathieu-Daude 
---
 NetworkPkg/HttpBootDxe/HttpBootConfig.h | 2 +-
 NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.h 
b/NetworkPkg/HttpBootDxe/HttpBootConfig.h
index ce2116e248b5..84eab425b04f 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootConfig.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.h
@@ -32,7 +32,7 @@ extern   UINT8
HttpBootConfigVfrBin[];
 
 struct _HTTP_BOOT_FORM_CALLBACK_INFO {
   UINT32   Signature;
-  BOOLEAN  Initilized;
+  BOOLEAN  Initialized;
   EFI_HANDLE   ChildHandle;
   EFI_DEVICE_PATH_PROTOCOL *HiiVendorDevicePath;
   EFI_HII_HANDLE   RegisteredHandle;
diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c 
b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
index 245bd49a621a..646c907b1215 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
@@ -552,7 +552,7 @@ HttpBootConfigFormInit (
 
   CallbackInfo = >CallbackInfo;
 
-  if (CallbackInfo->Initilized) {
+  if (CallbackInfo->Initialized) {
 return EFI_SUCCESS;
   }
 
@@ -632,7 +632,7 @@ HttpBootConfigFormInit (
 FreePool (MacString);
 FreePool (OldMenuString);
 
-CallbackInfo->Initilized = TRUE;
+CallbackInfo->Initialized = TRUE;
 return EFI_SUCCESS;
   }
 
-- 
2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51643): https://edk2.groups.io/g/devel/message/51643
Mute This Topic: https://groups.io/mt/65773989/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 39/79] NetworkPkg/HttpBootDxe: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jiaxin Wu 
Cc: Siyuan Fu 
Cc: Maciej Rabeda 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 NetworkPkg/HttpBootDxe/HttpBootDhcp4.h   |  2 +-
 NetworkPkg/HttpBootDxe/HttpBootDhcp6.h   |  4 ++--
 NetworkPkg/HttpBootDxe/HttpBootDxe.h |  6 +++---
 NetworkPkg/HttpBootDxe/HttpBootSupport.h | 10 +-
 NetworkPkg/HttpBootDxe/HttpBootDhcp4.c   |  2 +-
 NetworkPkg/HttpBootDxe/HttpBootDhcp6.c   | 10 +-
 NetworkPkg/HttpBootDxe/HttpBootDxe.c |  8 
 NetworkPkg/HttpBootDxe/HttpBootImpl.c|  2 +-
 NetworkPkg/HttpBootDxe/HttpBootSupport.c | 12 ++--
 9 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h 
b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
index 2c2fa28302a3..74bbdac58e86 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
@@ -41,7 +41,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 
 /// DHCP offer types among HTTP boot.
 /// Dhcp4 and Dhcp6 share this definition, and corresponding
-/// relatioinship is as follows:
+/// relationship is as follows:
 ///   Dhcp4Discover <> Dhcp6Solicit
 ///   Dhcp4Offer<> Dhcp6Advertise
 ///   Dhcp4Request  <> Dhcp6Request
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h 
b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
index e21f272aa1ac..e1a652031976 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
@@ -110,8 +110,8 @@ HttpBootDhcp6Sarr (
 
   @param[in]  Private The pointer to HTTP_BOOT_PRIVATE_DATA.
 
-  @retval EFI_SUCCESS Switch the IP policy succesfully.
-  @retval Others  Unexpect error happened.
+  @retval EFI_SUCCESS Switch the IP policy successfully.
+  @retval Others  Unexpected error happened.
 
 **/
 EFI_STATUS
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDxe.h 
b/NetworkPkg/HttpBootDxe/HttpBootDxe.h
index 89b7d6aa702b..0b45f9de0bdb 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDxe.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootDxe.h
@@ -147,7 +147,7 @@ struct _HTTP_BOOT_PRIVATE_DATA {
   HTTP_BOOT_VIRTUAL_NIC *Ip6Nic;
 
   //
-  // Cousumed children
+  // Consumed children
   //
   EFI_HANDLEIp6Child;
   EFI_HANDLEDhcp4Child;
@@ -348,7 +348,7 @@ HttpBootIp4DxeDriverBindingSupported (
   @retval EFI_SUCCESS  The device was started.
   @retval EFI_DEVICE_ERROR The device could not be started due to a 
device error.Currently not implemented.
   @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a 
lack of resources.
-  @retval Others   The driver failded to start the device.
+  @retval Others   The driver failed to start the device.
 
 **/
 EFI_STATUS
@@ -476,7 +476,7 @@ HttpBootIp6DxeDriverBindingSupported (
   @retval EFI_SUCCESS  The device was started.
   @retval EFI_DEVICE_ERROR The device could not be started due to a 
device error.Currently not implemented.
   @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a 
lack of resources.
-  @retval Others   The driver failded to start the device.
+  @retval Others   The driver failed to start the device.
 
 **/
 EFI_STATUS
diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.h 
b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
index 10f62f6ec31a..81d072ae3734 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootSupport.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
@@ -98,7 +98,7 @@ typedef struct {
 /**
   Create a HTTP_IO_HEADER to hold the HTTP header items.
 
-  @param[in]  MaxHeaderCount The maximun number of HTTP header in this 
holder.
+  @param[in]  MaxHeaderCount The maximum number of HTTP header in this 
holder.
 
   @returnA pointer of the HTTP header holder or NULL if failed.
 
@@ -109,7 +109,7 @@ HttpBootCreateHeader (
   );
 
 /**
-  Destroy the HTTP_IO_HEADER and release the resouces.
+  Destroy the HTTP_IO_HEADER and release the resources.
 
   @param[in]  HttpIoHeader   Point to the HTTP header holder to be 
destroyed.
 
@@ -300,7 +300,7 @@ HttpIoCreateIo (
   );
 
 /**
-  Destroy the HTTP_IO and release the resouces.
+  Destroy the HTTP_IO and release the resources.
 
   @param[in]  HttpIo  The HTTP_IO which wraps the HTTP service to be 
destroyed.
 
@@ -320,7 +320,7 @@ HttpIoDestroyIo (
   @param[in]   BodyLength   Length in bytes of the HTTP body.
   @param[in]   Body Body associated with the HTTP request.
 
-  @retval EFI_SUCCESSThe HTTP request is trasmitted.
+  @retval EFI_SUCCESSThe HTTP request is transmitted.
   @retval EFI_INVALID_PARAMETER  One or more parameters are invalid.
   @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory.
   @retval EFI_DEVICE_ERROR 

[edk2-devel] [PATCH 37/79] NetworkPkg/DpcDxe: Fix few typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix few typos in comments and documentation.

Cc: Jiaxin Wu 
Cc: Siyuan Fu 
Cc: Maciej Rabeda 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 NetworkPkg/DpcDxe/Dpc.h   | 2 +-
 NetworkPkg/Include/Protocol/Dpc.h | 2 +-
 NetworkPkg/DpcDxe/Dpc.c   | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/NetworkPkg/DpcDxe/Dpc.h b/NetworkPkg/DpcDxe/Dpc.h
index 2017a215e352..a5e6f7b62f90 100644
--- a/NetworkPkg/DpcDxe/Dpc.h
+++ b/NetworkPkg/DpcDxe/Dpc.h
@@ -24,7 +24,7 @@ Abstract:
 #include 
 
 //
-// Internal data struture for managing DPCs.  A DPC entry is either on the free
+// Internal data structure for managing DPCs.  A DPC entry is either on the 
free
 // list or on a DPC queue at a specific EFI_TPL.
 //
 typedef struct {
diff --git a/NetworkPkg/Include/Protocol/Dpc.h 
b/NetworkPkg/Include/Protocol/Dpc.h
index 1e1d0d316d54..5e50f6cf308c 100644
--- a/NetworkPkg/Include/Protocol/Dpc.h
+++ b/NetworkPkg/Include/Protocol/Dpc.h
@@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 }
 
 //
-// Forward reference for pure ANSI compatability
+// Forward reference for pure ANSI compatibility
 //
 typedef struct _EFI_DPC_PROTOCOL  EFI_DPC_PROTOCOL;
 
diff --git a/NetworkPkg/DpcDxe/Dpc.c b/NetworkPkg/DpcDxe/Dpc.c
index 8a490949dc8c..7c85dd8757c3 100644
--- a/NetworkPkg/DpcDxe/Dpc.c
+++ b/NetworkPkg/DpcDxe/Dpc.c
@@ -28,7 +28,7 @@ EFI_DPC_PROTOCOL mDpc = {
 };
 
 //
-// Global variables used to meaasure the DPC Queue Depths
+// Global variables used to measure the DPC Queue Depths
 //
 UINTN  mDpcQueueDepth = 0;
 UINTN  mMaxDpcQueueDepth = 0;
@@ -42,7 +42,7 @@ UINTN  mMaxDpcQueueDepth = 0;
 LIST_ENTRY  mDpcEntryFreeList = 
INITIALIZE_LIST_HEAD_VARIABLE(mDpcEntryFreeList);
 
 //
-// An array of DPC queues.  A DPC queue is allocated for every leval EFI_TPL 
value.
+// An array of DPC queues.  A DPC queue is allocated for every level EFI_TPL 
value.
 // As DPCs are queued, they are added to the end of the linked list.
 // As DPCs are dispatched, they are removed from the beginning of the linked 
list.
 //
@@ -299,7 +299,7 @@ DpcDispatchDpc (
   @param  ImageHandleThe image handle of the driver.
   @param  SystemTableThe system table.
 
-  @retval EFI_SUCCES The DPC queues were initialized and the 
EFI_DPC_PROTOCOL was
+  @retval EFI_SUCCESSThe DPC queues were initialized and the 
EFI_DPC_PROTOCOL was
  installed onto a new handle.
   @retval Others Failed to install EFI_DPC_PROTOCOL.
 
-- 
2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51642): https://edk2.groups.io/g/devel/message/51642
Mute This Topic: https://groups.io/mt/65773967/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 34/79] NetworkPkg/Dhcp6Dxe: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jiaxin Wu 
Cc: Siyuan Fu 
Cc: Maciej Rabeda 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h  |  4 +--
 NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h | 12 -
 NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c  | 12 -
 NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c| 12 -
 NetworkPkg/Dhcp6Dxe/Dhcp6Io.c  | 26 ++--
 NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 16 ++--
 6 files changed, 41 insertions(+), 41 deletions(-)

diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h 
b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h
index a609eddf2474..1b8744b9b8d2 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h
@@ -108,7 +108,7 @@ Dhcp6DriverBindingStop (
   then a new handle is created. If it is a pointer to an 
existing UEFI handle,
   then the protocol is added to the existing UEFI handle.
 
-  @retval EFI_SUCCESThe protocol was added to ChildHandle.
+  @retval EFI_SUCCESS   The protocol was added to ChildHandle.
   @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
   @retval EFI_OUT_OF_RESOURCES  There are not enough resources available to 
create
 the child.
@@ -132,7 +132,7 @@ Dhcp6ServiceBindingCreateChild (
   @param  ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
   @param  ChildHandle Handle of the child to destroy.
 
-  @retval EFI_SUCCESThe protocol was removed from ChildHandle.
+  @retval EFI_SUCCESS   The protocol was removed from ChildHandle.
   @retval EFI_UNSUPPORTED   ChildHandle does not support the protocol that 
is being removed.
   @retval EFI_INVALID_PARAMETER Child handle is NULL.
   @retval EFI_ACCESS_DENIED The protocol could not be removed from the 
ChildHandle
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h 
b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h
index 6a302adf2944..2f18eb360957 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h
@@ -71,7 +71,7 @@ Dhcp6CleanupModeData (
 
   @param[in]  Base  The base value of the time.
   @param[in]  IsFirstRt If TRUE, it is the first time to calculate expire 
time.
-  @param[in]  NeedSignedIf TRUE, the the signed factor is needed.
+  @param[in]  NeedSignedIf TRUE, the signed factor is needed.
 
   @return ExpireThe calculated result for the new expire time.
 
@@ -165,7 +165,7 @@ Dhcp6OnTransmitted (
 
   @param[in, out] Buf   The pointer to buffer.
   @param[in]  OptType   The option type.
-  @param[in]  OptLenThe lenght of option content.s
+  @param[in]  OptLenThe length of option content.s
   @param[in]  Data  The pointer to the option content.
 
   @return Buf   The position to append the next option.
@@ -270,7 +270,7 @@ Dhcp6SeekIaOption (
 /**
   Parse the address option and update the address info.
 
-  @param[in]  CurrentIa The pointer to the Ia Address in control blcok.
+  @param[in]  CurrentIa The pointer to the Ia Address in control block.
   @param[in]  IaInnerOptThe pointer to the buffer.
   @param[in]  IaInnerLenThe length to parse.
   @param[out] AddrNum   The number of addresses.
@@ -287,7 +287,7 @@ Dhcp6ParseAddrOption (
   );
 
 /**
-  Create a control blcok for the Ia according to the corresponding options.
+  Create a control block for the Ia according to the corresponding options.
 
   @param[in]  Instance  The pointer to DHCP6 Instance.
   @param[in]  IaInnerOptThe pointer to the inner options in the Ia 
option.
@@ -327,7 +327,7 @@ Dhcp6CacheIa (
 
 
 /**
-  Append CacheIa to the currrent IA. Meanwhile, clear CacheIa.ValidLifetime to 
0.
+  Append CacheIa to the current IA. Meanwhile, clear CacheIa.ValidLifetime to 
0.
 
   @param[in]  InstanceThe pointer to DHCP6 instance.
 
@@ -338,7 +338,7 @@ Dhcp6AppendCacheIa (
   );
 
 /**
-  Calculate the Dhcp6 get mapping timeout by adding additinal delay to the IP6 
DAD transmits count.
+  Calculate the Dhcp6 get mapping timeout by adding additional delay to the 
IP6 DAD transmits count.
 
   @param[in]   Ip6Cfg  The pointer to Ip6 config protocol.
   @param[out]  TimeOut The time out value in 100ns units.
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c 
b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
index 2ffdba73a563..f0b236835f86 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
@@ -1,6 +1,6 @@
 /** @file
   Driver Binding functions and Service Binding functions
-  implementationfor for Dhcp6 Driver.
+  implementation for Dhcp6 Driver.
 
   Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
 
@@ -300,7 +300,7 @@ Dhcp6CreateInstance (
 
   //
   // There is a timer for each Dhcp6 instance, which is used to track the
-  

[edk2-devel] [PATCH 28/79] MdePkg/Library/Smm: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Michael D Kinney 
Cc: Liming Gao 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdePkg/Include/Library/SmmLib.h  |  4 +-
 MdePkg/Include/Library/SmmMemLib.h   |  4 +-
 MdePkg/Include/Library/SmmPeriodicSmiLib.h   |  6 +--
 MdePkg/Library/SmmMemLib/SmmMemLib.c |  4 +-
 MdePkg/Library/SmmPciExpressLib/PciExpressLib.c  |  4 +-
 MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c |  6 +--
 MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c | 42 
++--
 MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c |  2 +-
 8 files changed, 36 insertions(+), 36 deletions(-)

diff --git a/MdePkg/Include/Library/SmmLib.h b/MdePkg/Include/Library/SmmLib.h
index 8d83df7fd737..bcb7045c1b65 100644
--- a/MdePkg/Include/Library/SmmLib.h
+++ b/MdePkg/Include/Library/SmmLib.h
@@ -45,7 +45,7 @@ TriggerRuntimeSoftwareSmi (
   it was triggered at boot time, it returns TRUE. Otherwise, it returns FALSE.
 
   @retval TRUE   A software SMI triggered at boot time happened.
-  @retval FLASE  No software SMI happened, or the software SMI was triggered 
at run time.
+  @retval FALSE  No software SMI happened, or the software SMI was triggered 
at run time.
 
 **/
 BOOLEAN
@@ -62,7 +62,7 @@ IsBootServiceSoftwareSmi (
   it was triggered at run time, it returns TRUE. Otherwise, it returns FALSE.
 
   @retval TRUE   A software SMI triggered at run time happened.
-  @retval FLASE  No software SMI happened or the software SMI was triggered at 
boot time.
+  @retval FALSE  No software SMI happened or the software SMI was triggered at 
boot time.
 
 **/
 BOOLEAN
diff --git a/MdePkg/Include/Library/SmmMemLib.h 
b/MdePkg/Include/Library/SmmMemLib.h
index 72edc9adcde7..d92cbd9aabd2 100644
--- a/MdePkg/Include/Library/SmmMemLib.h
+++ b/MdePkg/Include/Library/SmmMemLib.h
@@ -67,7 +67,7 @@ SmmCopyMemToSmram (
   @param  SourceBufferThe pointer to the source buffer of the memory 
copy.
   @param  Length  The number of bytes to copy from SourceBuffer to 
DestinationBuffer.
 
-  @retval EFI_SECURITY_VIOLATION The DesinationBuffer is invalid per processor 
architecture or overlap with SMRAM.
+  @retval EFI_SECURITY_VIOLATION The DestinationBuffer is invalid per 
processor architecture or overlap with SMRAM.
   @retval EFI_SUCCESSMemory is copied.
 
 **/
@@ -92,7 +92,7 @@ SmmCopyMemFromSmram (
   @param  SourceBufferThe pointer to the source buffer of the memory 
copy.
   @param  Length  The number of bytes to copy from SourceBuffer to 
DestinationBuffer.
 
-  @retval EFI_SECURITY_VIOLATION The DesinationBuffer is invalid per processor 
architecture or overlap with SMRAM.
+  @retval EFI_SECURITY_VIOLATION The DestinationBuffer is invalid per 
processor architecture or overlap with SMRAM.
   @retval EFI_SECURITY_VIOLATION The SourceBuffer is invalid per processor 
architecture or overlap with SMRAM.
   @retval EFI_SUCCESSMemory is copied.
 
diff --git a/MdePkg/Include/Library/SmmPeriodicSmiLib.h 
b/MdePkg/Include/Library/SmmPeriodicSmiLib.h
index 6215aa2232ac..a3e086d02501 100644
--- a/MdePkg/Include/Library/SmmPeriodicSmiLib.h
+++ b/MdePkg/Include/Library/SmmPeriodicSmiLib.h
@@ -64,7 +64,7 @@ PeriodicSmiExit (
   This function yields control back to the SMM Foundation.  When the next
   periodic SMI for the currently executing handler is triggered, the periodic
   SMI handler will be resumed and this function will return.  Use of this
-  function requires a seperate stack for the periodic SMI handler.  A non zero
+  function requires a separate stack for the periodic SMI handler.  A non zero
   stack size must be specified in PeriodicSmiEnable() for this function to be
   used.
 
@@ -113,7 +113,7 @@ VOID
   @param[in] DispatchFunction  A pointer to a periodic SMI handler 
function.
   @param[in] Context   Optional content to pass into 
DispatchFunction.
   @param[in] TickPeriodThe requested tick period in 100ns units 
that
-   control should be givien to the periodic SMI
+   control should be given to the periodic SMI
handler.  Must be one of the supported 
values
returned by 
PeriodicSmiSupportedPickPeriod().
   @param[in] Cpu   Specifies the CPU that is required to 
execute
@@ -137,7 +137,7 @@ VOID
   @retval EFI_OUT_OF_RESOURCES   There are not enough resources to enable the
  periodic SMI handler.
   @retval EFI_OUT_OF_RESOURCES   There are not enough resources to allocate the
- stack speficied by StackSize.
+ stack specified by StackSize.
   @retval EFI_SUCCESSThe periodic SMI handler 

[edk2-devel] [PATCH 23/79] MdeModulePkg/UsbBus: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h | 14 +++---
 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h |  2 +-
 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h |  2 +-
 MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h|  2 +-
 MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h  |  2 +-
 MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h|  2 +-
 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 12 ++--
 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c  |  2 +-
 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c |  4 ++--
 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c |  8 
 MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c  |  2 +-
 MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c  |  2 +-
 12 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h 
b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h
index 3fdbc94d95eb..c84a24df2413 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h
@@ -159,7 +159,7 @@ typedef struct _EFI_USB_BUS_PROTOCOL {
 
 //
 // Stands for the real USB device. Each device may
-// has several seperately working interfaces.
+// has several separately working interfaces.
 //
 struct _USB_DEVICE {
   USB_BUS   *Bus;
@@ -265,8 +265,8 @@ struct _USB_BUS {
   // USB Bus driver need to control the recursive connect policy of the bus, 
only those wanted
   // usb child device will be recursively connected.
   //
-  // WantedUsbIoDPList tracks the Usb child devices which user want to 
recursivly fully connecte,
-  // every wanted child device is stored in a item of the WantedUsbIoDPList, 
whose structrure is
+  // WantedUsbIoDPList tracks the Usb child devices which user want to 
recursively fully connecte,
+  // every wanted child device is stored in a item of the WantedUsbIoDPList, 
whose structure is
   // DEVICE_PATH_LIST_ITEM
   //
   LIST_ENTRYWantedUsbIoDPList;
@@ -337,7 +337,7 @@ UsbBusAddWantedUsbIoDP (
   Check whether a usb child device is the wanted device in a bus.
 
   @param  Bus The Usb bus's private data pointer.
-  @param  UsbIf   The usb child device inferface.
+  @param  UsbIf   The usb child device interface.
 
   @retval TrueIf a usb child device is the wanted device in a bus.
   @retval False   If a usb child device is *NOT* the wanted device in a bus.
@@ -351,7 +351,7 @@ UsbBusIsWantedUsbIO (
   );
 
 /**
-  Recursively connnect every wanted usb child device to ensure they all fully 
connected.
+  Recursively connect every wanted usb child device to ensure they all fully 
connected.
   Check all the child Usb IO handles in this bus, recursively connecte if it 
is wanted usb child device.
 
   @param  UsbBusId  Point to EFI_USB_BUS_PROTOCOL interface.
@@ -461,7 +461,7 @@ UsbIoSyncInterruptTransfer (
  the request.
   @param  PollInterval   The interval to poll the transfer result, (in 
ms).
   @param  DataLength The length of perodic data transfer.
-  @param  Callback   The function to call periodicaly when 
transfer is
+  @param  Callback   The function to call periodically when 
transfer is
  ready.
   @param  ContextThe context to the callback.
 
@@ -512,7 +512,7 @@ UsbIoIsochronousTransfer (
   @param  DeviceEndpoint The device endpoint.
   @param  Data   The data to transfer.
   @param  DataLength The length of perodic data transfer.
-  @param  IsochronousCallBackThe function to call periodicaly when 
transfer is
+  @param  IsochronousCallBackThe function to call periodically when 
transfer is
  ready.
   @param  ContextThe context to the callback.
 
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h 
b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h
index 0f4db2f34dc9..6043b5b2cd48 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h
@@ -97,7 +97,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 
 #pragma pack(1)
 //
-// Hub descriptor, the last two fields are of variable lenght.
+// Hub descriptor, the last two fields are of variable length.
 //
 typedef struct {
   UINT8   Length;
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h 
b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
index 9c52520c87f7..1d2b8a6174c7 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
@@ -101,7 +101,7 @@ UsbHcClearRootHubPortFeature (
   @param  UsbResultThe result of transfer.
 
   @retval EFI_SUCCESS  The control transfer finished without error.
-  @retval Others   The control transfer failed, reason returned in 
UsbReslt.
+  @retval Others   The control transfer failed, reason 

[edk2-devel] [PATCH 29/79] MdePkg/Ppi: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Michael D Kinney 
Cc: Liming Gao 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdePkg/Include/Ppi/BlockIo.h  | 4 ++--
 MdePkg/Include/Ppi/BlockIo2.h | 2 +-
 MdePkg/Include/Ppi/Capsule.h  | 2 +-
 MdePkg/Include/Ppi/Decompress.h   | 2 +-
 MdePkg/Include/Ppi/DeviceRecoveryModule.h | 2 +-
 MdePkg/Include/Ppi/IsaHc.h| 2 +-
 MdePkg/Include/Ppi/MpServices.h   | 2 +-
 MdePkg/Include/Ppi/Pcd.h  | 4 ++--
 MdePkg/Include/Ppi/RecoveryModule.h   | 2 +-
 MdePkg/Include/Ppi/TemporaryRamDone.h | 2 +-
 MdePkg/Include/Ppi/VectorHandoffInfo.h| 2 +-
 11 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/MdePkg/Include/Ppi/BlockIo.h b/MdePkg/Include/Ppi/BlockIo.h
index 524f026fe589..3a4955be6b59 100644
--- a/MdePkg/Include/Ppi/BlockIo.h
+++ b/MdePkg/Include/Ppi/BlockIo.h
@@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Revision Reference:
   This PPI is defined in UEFI Platform Initialization Specification 1.2 Volume 
1:
-  Pre-EFI Initalization Core Interface.
+  Pre-EFI Initialization Core Interface.
 
 **/
 
@@ -58,7 +58,7 @@ typedef enum {
 /// Specification inconsistency here:
 /// PEI_BLOCK_IO_MEDIA has been changed to EFI_PEI_BLOCK_IO_MEDIA.
 /// Inconsistency exists in UEFI Platform Initialization Specification 1.2
-/// Volume 1: Pre-EFI Initalization Core Interface, where all referrences to
+/// Volume 1: Pre-EFI Initialization Core Interface, where all references to
 /// this structure name are with the "EFI_" prefix, except for the definition
 /// which is without "EFI_".  So the name of PEI_BLOCK_IO_MEDIA is taken as the
 /// exception, and EFI_PEI_BLOCK_IO_MEDIA is used to comply with most of
diff --git a/MdePkg/Include/Ppi/BlockIo2.h b/MdePkg/Include/Ppi/BlockIo2.h
index e1af6a4293ed..0dba6485d941 100644
--- a/MdePkg/Include/Ppi/BlockIo2.h
+++ b/MdePkg/Include/Ppi/BlockIo2.h
@@ -7,7 +7,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Revision Reference:
   This PPI is defined in UEFI Platform Initialization Specification 1.4 Volume 
1:
-  Pre-EFI Initalization Core Interface.
+  Pre-EFI Initialization Core Interface.
 
 **/
 
diff --git a/MdePkg/Include/Ppi/Capsule.h b/MdePkg/Include/Ppi/Capsule.h
index cb7b0e2ae76a..331d9b81cad2 100644
--- a/MdePkg/Include/Ppi/Capsule.h
+++ b/MdePkg/Include/Ppi/Capsule.h
@@ -45,7 +45,7 @@ typedef struct _EFI_PEI_CAPSULE_PPI PEI_CAPSULE_PPI;
 On output, this variable will contain the size of 
the
 coalesced capsule.
 
-  @retval EFI_NOT_FOUND  If: boot modecould not be determined, or the
+  @retval EFI_NOT_FOUND  If: boot mode could not be determined, or the
  boot mode is not flash-update, or the capsule 
descriptors were not found.
   @retval EFI_BUFFER_TOO_SMALL   The capsule could not be coalesced in the 
provided memory region.
   @retval EFI_SUCCESSThere was no capsule, or the capsule was 
processed successfully.
diff --git a/MdePkg/Include/Ppi/Decompress.h b/MdePkg/Include/Ppi/Decompress.h
index 7ba26e419c59..b9ca63746ab2 100644
--- a/MdePkg/Include/Ppi/Decompress.h
+++ b/MdePkg/Include/Ppi/Decompress.h
@@ -1,5 +1,5 @@
 /** @file
-  Provides decompression services to the PEI Foundatoin.
+  Provides decompression services to the PEI Foundation.
 
   Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/MdePkg/Include/Ppi/DeviceRecoveryModule.h 
b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
index a4587255a3c8..64dabec1139c 100644
--- a/MdePkg/Include/Ppi/DeviceRecoveryModule.h
+++ b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
@@ -15,7 +15,7 @@
 
   @par Revision Reference:
   This PPI is defined in UEFI Platform Initialization Specification 1.2 Volume 
1:
-  Pre-EFI Initalization Core Interface
+  Pre-EFI Initialization Core Interface
 
 **/
 
diff --git a/MdePkg/Include/Ppi/IsaHc.h b/MdePkg/Include/Ppi/IsaHc.h
index 5468c2e94b72..d7dfd9b47e8c 100644
--- a/MdePkg/Include/Ppi/IsaHc.h
+++ b/MdePkg/Include/Ppi/IsaHc.h
@@ -28,7 +28,7 @@ typedef struct _EFI_ISA_HC_PPI *PEFI_ISA_HC_PPI;
   that more than one caller may be assigned to the same aperture.
   It may be possible that a single hardware aperture may be used for more than
   one device. This function tracks the number of times that each aperture is
-  referenced, and doesa not close the hardware aperture (via CloseIoAperture())
+  referenced, and does not close the hardware aperture (via CloseIoAperture())
   until there are no more references to it.
 
   @param This A pointer to this instance of the EFI_ISA_HC_PPI.
diff --git a/MdePkg/Include/Ppi/MpServices.h b/MdePkg/Include/Ppi/MpServices.h
index afcd8819e9cc..5ea3373909e1 100644
--- a/MdePkg/Include/Ppi/MpServices.h
+++ 

[edk2-devel] [PATCH 20/79] MdeModulePkg/UsbBusDxe: Fix a typo

[Philippe Mathieu-Daudé]

Correctly write 'malformatted'.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c 
b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
index a64f33fde67a..008a592859aa 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
@@ -398,7 +398,7 @@ UsbParseConfigDesc (
   break;
 
 } else if (Setting->Desc.InterfaceNumber >= NumIf) {
-  DEBUG (( EFI_D_ERROR, "UsbParseConfigDesc: mal-formated interface 
descriptor\n"));
+  DEBUG (( EFI_D_ERROR, "UsbParseConfigDesc: malformatted interface 
descriptor\n"));
 
   UsbFreeInterfaceDesc (Setting);
   goto ON_ERROR;
-- 
2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51625): https://edk2.groups.io/g/devel/message/51625
Mute This Topic: https://groups.io/mt/65773449/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 19/79] MdeModulePkg/Core/PiSmmCore: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jian J Wang 
Cc: Hao A Wu 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf| 10 
 MdeModulePkg/Core/PiSmmCore/HeapGuard.h |  2 +-
 MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 12 +-
 MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h  |  6 ++---
 MdeModulePkg/Core/PiSmmCore/Dependency.c|  4 ++--
 MdeModulePkg/Core/PiSmmCore/Dispatcher.c| 24 ++--
 MdeModulePkg/Core/PiSmmCore/HeapGuard.c |  4 ++--
 MdeModulePkg/Core/PiSmmCore/Locate.c|  8 +++
 MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c |  8 +++
 MdeModulePkg/Core/PiSmmCore/Page.c  |  4 ++--
 MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 10 
 MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c  |  8 +++
 MdeModulePkg/Core/PiSmmCore/Smi.c   |  2 +-
 MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c|  4 ++--
 14 files changed, 53 insertions(+), 53 deletions(-)

diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf 
b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
index b6b1bbcdac51..619603d6c2a0 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
@@ -57,23 +57,23 @@ [Protocols]
   gEfiSmmControl2ProtocolGuid   ## CONSUMES
   ## NOTIFY
   ## SOMETIMES_CONSUMES
-  ## UNDEFINED # Used to do smm communcation
+  ## UNDEFINED # Used to do smm communication
   gEfiDxeSmmReadyToLockProtocolGuid
   gEfiCpuArchProtocolGuid   ## SOMETIMES_CONSUMES
 
 [Guids]
   ## CONSUMES   ## Event
-  ## PRODUCES   ## UNDEFINED # Used to do smm communcation
+  ## PRODUCES   ## UNDEFINED # Used to do smm communication
   gEfiEventDxeDispatchGuid
   gEfiEventReadyToBootGuid  ## CONSUMES ## 
Event
   ## SOMETIMES_CONSUMES ## Event
-  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communcation
+  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communication
   gEfiEventLegacyBootGuid
   ## SOMETIMES_CONSUMES ## Event
-  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communcation
+  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communication
   gEfiEventExitBootServicesGuid
   ## SOMETIMES_CONSUMES ## Event
-  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communcation
+  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communication
   gEfiEventReadyToBootGuid
   gEfiEventVirtualAddressChangeGuid ## CONSUMES ## 
Event
   gEfiEndOfDxeEventGroupGuid## CONSUMES ## 
Event
diff --git a/MdeModulePkg/Core/PiSmmCore/HeapGuard.h 
b/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
index 9077db1a8496..1b5c0f2a4f57 100644
--- a/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
+++ b/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
@@ -39,7 +39,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //
 // For a normal configuration of system with 4G memory, two levels of tables
 // can track the whole memory, because two levels (L3+L4) of map tables have
-// already coverred 37-bit of memory address. And for a normal UEFI BIOS,
+// already covered 37-bit of memory address. And for a normal UEFI BIOS,
 // less than 128M memory would be consumed during boot. That means we just
 // need
 //
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h 
b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
index 0908e7f4e9e7..50a7fccb 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
@@ -171,7 +171,7 @@ typedef struct {
   EFI_GUIDProtocolID;
   /// All protocol interfaces
   LIST_ENTRY  Protocols;
-  /// Registerd notification handlers
+  /// Registered notification handlers
   LIST_ENTRY  Notify;
 } PROTOCOL_ENTRY;
 
@@ -562,7 +562,7 @@ SmmLocateHandle (
 /**
   Return the first Protocol Interface that matches the Protocol GUID. If
   Registration is pasased in return a Protocol Instance that was just add
-  to the system. If Retistration is NULL return the first Protocol Interface
+  to the system. If Registration is NULL return the first Protocol Interface
   you find.
 
   @param  Protocol   The protocol to search for
@@ -602,7 +602,7 @@ SmmLocateProtocol (
   @retval EFI_NOT_FOUND  No handles match the search.
   @retval EFI_OUT_OF_RESOURCES   There is not enough pool memory to store the
  matching results.
-  @retval EFI_INVALID_PARAMETER  One or more paramters are not valid.
+  @retval EFI_INVALID_PARAMETER  One or more parameters are not valid.
 
 **/
 EFI_STATUS
@@ -641,7 +641,7 @@ SmiManage (
 /**
   Registers a handler to execute within SMM.
 
-  @param  HandlerHandler service funtion pointer.
+  @param  HandlerHandler service function pointer.
   @param  

[edk2-devel] [PATCH 18/79] MdeModulePkg/Core/Pei: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jian J Wang 
Cc: Hao A Wu 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Core/Pei/PeiMain.h   | 20 +++---
 MdeModulePkg/Core/Pei/Dependency/Dependency.c |  4 +--
 MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 28 ++--
 MdeModulePkg/Core/Pei/FwVol/FwVol.c   |  8 +++---
 MdeModulePkg/Core/Pei/Hob/Hob.c   |  2 +-
 MdeModulePkg/Core/Pei/Image/Image.c   |  8 +++---
 MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 10 +++
 MdeModulePkg/Core/Pei/PeiMain/PeiMain.c   |  4 +--
 MdeModulePkg/Core/Pei/Ppi/Ppi.c   |  2 +-
 MdeModulePkg/Core/Pei/Security/Security.c |  2 +-
 10 files changed, 44 insertions(+), 44 deletions(-)

diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h
index f2aa97c6640c..f799f5e2776c 100644
--- a/MdeModulePkg/Core/Pei/PeiMain.h
+++ b/MdeModulePkg/Core/Pei/PeiMain.h
@@ -136,11 +136,11 @@ typedef struct {
   EFI_PEI_FV_HANDLE   FvHandle;
   UINTN   PeimCount;
   //
-  // Ponter to the buffer with the PeimCount number of Entries.
+  // Pointer to the buffer with the PeimCount number of Entries.
   //
   UINT8   *PeimState;
   //
-  // Ponter to the buffer with the PeimCount number of Entries.
+  // Pointer to the buffer with the PeimCount number of Entries.
   //
   EFI_PEI_FILE_HANDLE *FvFileHandles;
   BOOLEAN ScanFv;
@@ -282,7 +282,7 @@ struct _PEI_CORE_INSTANCE {
   EFI_PHYSICAL_ADDRESS   LoadModuleAtFixAddressTopAddress;
   //
   // The field is define for Loading modules at fixed address feature to 
tracker the PEI code
-  // memory range usage. It is a bit mapped array in which every bit indicates 
the correspoding memory page
+  // memory range usage. It is a bit mapped array in which every bit indicates 
the corresponding memory page
   // available or not.
   //
   UINT64*PeiCodeMemoryRangeUsageBitMap;
@@ -372,7 +372,7 @@ PeiCore (
 
   This is the POSTFIX version of the dependency evaluator.  When a
   PUSH [PPI GUID] is encountered, a pointer to the GUID is stored on
-  the evaluation stack.  When that entry is poped from the evaluation
+  the evaluation stack.  When that entry is popped from the evaluation
   stack, the PPI is checked if it is installed.  This method allows
   some time savings as not all PPIs must be checked for certain
   operation types (AND, OR).
@@ -412,7 +412,7 @@ PeiDispatcher (
 
   @param PrivateData PeiCore's private data structure
   @param OldCoreData Old data from SecCore
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
   @param SecCoreData Points to a data structure containing SEC to PEI 
handoff data, such as the size
  and location of temporary RAM, the stack location and 
the BFV location.
 
@@ -453,7 +453,7 @@ DepexSatisfied (
 
   @param PrivateData Pointer to the PEI Core data.
   @param OldCoreData Pointer to old PEI Core data.
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
 
 **/
 VOID
@@ -555,7 +555,7 @@ PeiLocatePpi (
 
   @retval EFI_SUCCESS   if successful
   @retval EFI_OUT_OF_RESOURCES  if no space in the database
-  @retval EFI_INVALID_PARAMETER if not a good decriptor
+  @retval EFI_INVALID_PARAMETER if not a good descriptor
 
 **/
 EFI_STATUS
@@ -659,7 +659,7 @@ PeiSetBootMode (
 
   @param PeiServices An indirect pointer to the EFI_PEI_SERVICES table 
published by the PEI Foundation.
   @param OldCoreData Pointer to the old core data.
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
 
 **/
 VOID
@@ -887,7 +887,7 @@ PeiFfsFindNextVolume (
   @param SecCoreData Points to a data structure containing SEC to PEI 
handoff data, such as the size
  and location of temporary RAM, the stack location and 
the BFV location.
   @param OldCoreData Pointer to the PEI Core data.
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
 
 **/
 VOID
@@ -1125,7 +1125,7 @@ PeiInitializeFv (
   );
 
 /**
-  Process Firmware Volum Information once FvInfoPPI install.
+  Process Firmware Volume Information once FvInfoPPI install.
 
   @param PeiServices   An indirect pointer to the EFI_PEI_SERVICES table 
published by the PEI Foundation.
   @param NotifyDescriptor  Address of the notification descriptor data 
structure.
diff --git a/MdeModulePkg/Core/Pei/Dependency/Dependency.c 

[edk2-devel] [PATCH 22/79] MdeModulePkg/UsbMouse: Fix few typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix few typos in comments and documentation.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h | 2 
+-
 MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h   | 2 
+-
 MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c| 2 
+-
 MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c | 2 
+-
 MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c   | 2 
+-
 MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c   | 2 
+-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git 
a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h 
b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h
index f7fe480d0762..c9edc45e38a4 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h
+++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h
@@ -138,7 +138,7 @@ USBMouseAbsolutePointerDriverBindingSupported (
 /**
   Starts the mouse device with this driver.
 
-  This function consumes USB I/O Portocol, intializes USB mouse device,
+  This function consumes USB I/O Protocol, initializes USB mouse device,
   installs Absolute Pointer Protocol, and submits Asynchronous Interrupt
   Transfer to manage the USB mouse device.
 
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h 
b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h
index b71ef829870a..f46069602f28 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h
+++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h
@@ -138,7 +138,7 @@ USBMouseDriverBindingSupported (
 /**
   Starts the mouse device with this driver.
 
-  This function consumes USB I/O Portocol, intializes USB mouse device,
+  This function consumes USB I/O Protocol, initializes USB mouse device,
   installs Simple Pointer Protocol, and submits Asynchronous Interrupt
   Transfer to manage the USB mouse device.
 
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c 
b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c
index d7805ad3de90..10e18e58ab45 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c
@@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
   Only short item is supported here.
 
   @param  StartPos  Start position of the HID item to get.
-  @param  EndPosEnd position of the range to get the the next HID 
item.
+  @param  EndPosEnd position of the range to get the next HID item.
   @param  HidItem   Buffer for the HID Item to return.
 
   @return Pointer to end of the HID item returned.
diff --git 
a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c 
b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
index 8953e7031cfc..83197bfd996f 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
@@ -109,7 +109,7 @@ USBMouseAbsolutePointerDriverBindingSupported (
 /**
   Starts the mouse device with this driver.
 
-  This function consumes USB I/O Portocol, intializes USB mouse device,
+  This function consumes USB I/O Protocol, initializes USB mouse device,
   installs Absolute Pointer Protocol, and submits Asynchronous Interrupt
   Transfer to manage the USB mouse device.
 
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c 
b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
index de44aec516e4..2b6d86030b26 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
@@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
   Only short item is supported here.
 
   @param  StartPos  Start position of the HID item to get.
-  @param  EndPosEnd position of the range to get the the next HID 
item.
+  @param  EndPosEnd position of the range to get the next HID item.
   @param  HidItem   Buffer for the HID Item to return.
 
   @return Pointer to end of the HID item returned.
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c 
b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
index 677815a8ade3..8284e9ec80b9 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
@@ -109,7 +109,7 @@ USBMouseDriverBindingSupported (
 /**
   Starts the mouse device with this driver.
 
-  This function consumes USB I/O Portocol, intializes USB mouse device,
+  This function consumes USB I/O Protocol, initializes USB mouse device,
   installs Simple Pointer Protocol, and submits Asynchronous Interrupt
   Transfer to manage the USB mouse device.
 
-- 
2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

[edk2-devel] [PATCH 32/79] NetworkPkg/ArpDxe: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in documentation, comments and debug strings.

Cc: Jiaxin Wu 
Cc: Siyuan Fu 
Cc: Maciej Rabeda 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 NetworkPkg/ArpDxe/ArpDriver.h | 10 +-
 NetworkPkg/ArpDxe/ArpImpl.h   | 14 +++---
 NetworkPkg/ArpDxe/ArpDriver.c | 14 +++---
 NetworkPkg/ArpDxe/ArpImpl.c   | 16 
 NetworkPkg/ArpDxe/ArpMain.c   | 10 +-
 5 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/NetworkPkg/ArpDxe/ArpDriver.h b/NetworkPkg/ArpDxe/ArpDriver.h
index 0b5b06ee37d5..7dbc1c187820 100644
--- a/NetworkPkg/ArpDxe/ArpDriver.h
+++ b/NetworkPkg/ArpDxe/ArpDriver.h
@@ -30,7 +30,7 @@ extern EFI_COMPONENT_NAME_PROTOCOLgArpComponentName;
 extern EFI_COMPONENT_NAME2_PROTOCOL   gArpComponentName2;
 
 //
-// Function prototypes for the Drivr Binding Protocol
+// Function prototypes for the Driver Binding Protocol
 //
 /**
   Tests to see if this driver supports a given controller.
@@ -55,7 +55,7 @@ extern EFI_COMPONENT_NAME2_PROTOCOL   gArpComponentName2;
   @retval EFI_ACCESS_DENIEDThe device specified by ControllerHandle and
RemainingDevicePath is already being 
managed by
a different driver or an application that
-   requires exclusive acces. Currently not 
implemented.
+   requires exclusive access. Currently not 
implemented.
   @retval EFI_UNSUPPORTED  The device specified by ControllerHandle and
RemainingDevicePath is not supported by the
driver specified by This.
@@ -97,7 +97,7 @@ ArpDriverBindingSupported (
Currently not implemented.
   @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a 
lack of
resources.
-  @retval Others   The driver failded to start the device.
+  @retval Others   The driver failed to start the device.
 
 **/
 EFI_STATUS
@@ -159,7 +159,7 @@ ArpDriverBindingStop (
   then a new handle is created. If it is a pointer to an 
existing
   UEFI handle, then the protocol is added to the existing 
UEFI handle.
 
-  @retval EFI_SUCCESThe protocol was added to ChildHandle.
+  @retval EFI_SUCCESS   The protocol was added to ChildHandle.
   @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
   @retval EFI_OUT_OF_RESOURCES  There are not enough resources available to 
create
 the child
@@ -183,7 +183,7 @@ ArpServiceBindingCreateChild (
   @param  ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
   @param  ChildHandle Handle of the child to destroy
 
-  @retval EFI_SUCCESThe protocol was removed from ChildHandle.
+  @retval EFI_SUCCESS   The protocol was removed from ChildHandle.
   @retval EFI_UNSUPPORTED   ChildHandle does not support the protocol that 
is
 being removed.
   @retval EFI_INVALID_PARAMETER Child handle is NULL.
diff --git a/NetworkPkg/ArpDxe/ArpImpl.h b/NetworkPkg/ArpDxe/ArpImpl.h
index 47eedc1cb6f7..506f3e6ef61e 100644
--- a/NetworkPkg/ArpDxe/ArpImpl.h
+++ b/NetworkPkg/ArpDxe/ArpImpl.h
@@ -436,7 +436,7 @@ ArpRequest (
 
   If the request is in the internal ARP request queue, the request is aborted
   immediately and its ResolvedEvent is signaled. Only an asynchronous address
-  request needs to be canceled. If TargeSwAddress and ResolveEvent are both
+  request needs to be canceled. If TargetSwAddress and ResolvedEvent are both
   NULL, all the pending asynchronous requests that have been issued by This
   instance will be cancelled and their corresponding events will be signaled.
 
@@ -599,7 +599,7 @@ ArpDeleteCacheEntry (
   );
 
 /**
-  Send out an arp frame using the CachEntry and the ArpOpCode.
+  Send out an arp frame using the CacheEntry and the ArpOpCode.
 
   @param[in]  Instance   Pointer to the instance context data.
   @param[in]  CacheEntry Pointer to the configuration data used to
@@ -636,7 +636,7 @@ ArpInitInstance (
 /**
   Process the Arp packets received from Mnp, the procedure conforms to RFC826.
 
-  @param[in]  ContextPointer to the context data registerd to the
+  @param[in]  ContextPointer to the context data registered to the
  Event.
 
   @return None.
@@ -652,7 +652,7 @@ ArpOnFrameRcvdDpc (
   Queue ArpOnFrameRcvdDpc as a DPC at TPL_CALLBACK.
 
   @param[in]  Event  The Event this notify function registered 
to.
-  @param[in]  ContextPointer to the context data registerd to 
the
+  @param[in]  ContextPointer to the context data registered to 
the
  

[edk2-devel] [PATCH 25/79] MdePkg/IndustryStandard: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Michael D Kinney 
Cc: Liming Gao 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdePkg/Include/IndustryStandard/Acpi10.h  |  4 +-
 MdePkg/Include/IndustryStandard/Acpi20.h  |  4 +-
 MdePkg/Include/IndustryStandard/Acpi30.h  |  4 +-
 MdePkg/Include/IndustryStandard/Acpi40.h  |  2 +-
 MdePkg/Include/IndustryStandard/Acpi50.h  |  6 +--
 MdePkg/Include/IndustryStandard/Acpi51.h  |  4 +-
 MdePkg/Include/IndustryStandard/Acpi60.h  |  4 +-
 MdePkg/Include/IndustryStandard/Acpi61.h  |  4 +-
 MdePkg/Include/IndustryStandard/Acpi62.h  |  8 ++--
 MdePkg/Include/IndustryStandard/Atapi.h   | 40 ++--
 MdePkg/Include/IndustryStandard/ElTorito.h|  4 +-
 MdePkg/Include/IndustryStandard/Emmc.h|  2 +-
 MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h |  4 +-
 MdePkg/Include/IndustryStandard/Nvme.h| 10 ++---
 MdePkg/Include/IndustryStandard/Pci22.h   | 20 +-
 MdePkg/Include/IndustryStandard/PeImage.h |  2 +-
 MdePkg/Include/IndustryStandard/Scsi.h|  2 +-
 MdePkg/Include/IndustryStandard/SmBus.h   |  2 +-
 MdePkg/Include/IndustryStandard/Tpm12.h   |  2 +-
 19 files changed, 64 insertions(+), 64 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h 
b/MdePkg/Include/IndustryStandard/Acpi10.h
index a38d2be61cc3..fa06eefbb6e6 100644
--- a/MdePkg/Include/IndustryStandard/Acpi10.h
+++ b/MdePkg/Include/IndustryStandard/Acpi10.h
@@ -37,7 +37,7 @@ typedef struct {
 #pragma pack()
 
 //
-// Define for Desriptor
+// Define for Descriptor
 //
 #define ACPI_SMALL_ITEM_FLAG   0x00
 #define ACPI_LARGE_ITEM_FLAG   0x01
@@ -109,7 +109,7 @@ typedef struct {
 #pragma pack(1)
 
 ///
-/// The commond definition of QWORD, DWORD, and WORD
+/// The common definition of QWORD, DWORD, and WORD
 /// Address Space Descriptors.
 ///
 typedef PACKED struct {
diff --git a/MdePkg/Include/IndustryStandard/Acpi20.h 
b/MdePkg/Include/IndustryStandard/Acpi20.h
index 8a0adbbb6a97..b63d494705a2 100644
--- a/MdePkg/Include/IndustryStandard/Acpi20.h
+++ b/MdePkg/Include/IndustryStandard/Acpi20.h
@@ -11,7 +11,7 @@
 #include 
 
 //
-// Define for Desriptor
+// Define for Descriptor
 //
 #define ACPI_LARGE_GENERIC_REGISTER_DESCRIPTOR_NAME  0x02
 
@@ -505,7 +505,7 @@ typedef struct {
 #define EFI_ACPI_2_0_SYSTEM_LOCALITY_INFORMATION_TABLE_SIGNATURE  
SIGNATURE_32('S', 'L', 'I', 'T')
 
 ///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
 ///
 #define EFI_ACPI_2_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE  
SIGNATURE_32('S', 'P', 'C', 'R')
 
diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h 
b/MdePkg/Include/IndustryStandard/Acpi30.h
index 0fc947e745f4..6a7fc39c256e 100644
--- a/MdePkg/Include/IndustryStandard/Acpi30.h
+++ b/MdePkg/Include/IndustryStandard/Acpi30.h
@@ -11,7 +11,7 @@
 #include 
 
 //
-// Define for Desriptor
+// Define for Descriptor
 //
 #define ACPI_LARGE_EXTENDED_ADDRESS_SPACE_DESCRIPTOR_NAME0x0B
 
@@ -684,7 +684,7 @@ typedef struct {
 #define 
EFI_ACPI_3_0_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE
  SIGNATURE_32('M', 'C', 'F', 'G')
 
 ///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
 ///
 #define EFI_ACPI_3_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE  
SIGNATURE_32('S', 'P', 'C', 'R')
 
diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h 
b/MdePkg/Include/IndustryStandard/Acpi40.h
index 53ec90c04243..c03ba7a6290b 100644
--- a/MdePkg/Include/IndustryStandard/Acpi40.h
+++ b/MdePkg/Include/IndustryStandard/Acpi40.h
@@ -1264,7 +1264,7 @@ typedef struct {
 #define EFI_ACPI_4_0_MANAGEMENT_CONTROLLER_HOST_INTERFACE_TABLE_SIGNATURE  
SIGNATURE_32('M', 'C', 'H', 'I')
 
 ///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
 ///
 #define EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE  
SIGNATURE_32('S', 'P', 'C', 'R')
 
diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h 
b/MdePkg/Include/IndustryStandard/Acpi50.h
index 067ab68c3428..46dcdb950741 100644
--- a/MdePkg/Include/IndustryStandard/Acpi50.h
+++ b/MdePkg/Include/IndustryStandard/Acpi50.h
@@ -12,7 +12,7 @@
 #include 
 
 //
-// Define for Desriptor
+// Define for Descriptor
 //
 #define ACPI_SMALL_FIXED_DMA_DESCRIPTOR_NAME 0x0A
 #define ACPI_LARGE_GPIO_CONNECTION_DESCRIPTOR_NAME   0x0C
@@ -1201,7 +1201,7 @@ typedef struct {
   ///
   UINT64  ExitBootServicesEntry;
   ///
-  /// Timer value logged at the point just prior towhen the OS loader gaining
+  /// Timer value logged at the point just prior to when the OS loader gaining
   /// control back 

[edk2-devel] [PATCH 21/79] MdeModulePkg/UsbMass: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h | 4 ++--
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h  | 4 ++--
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h  | 2 +-
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h | 2 +-
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 4 ++--
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c  | 4 ++--
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c  | 4 ++--
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 4 ++--
 8 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h 
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
index 2b89c92724a8..f34a41284e4c 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
@@ -77,7 +77,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // Mass command timeout, refers to specification[USB20-9.2.6.1]
 //
 // USB2.0 Spec define the up-limit timeout 5s for all command. USB floppy,
-// USB CD-Rom and iPod devices are much slower than USB key when reponse
+// USB CD-Rom and iPod devices are much slower than USB key when response
 // most of commands, So we set 5s as timeout here.
 //
 #define USB_BOOT_GENERAL_CMD_TIMEOUT(5 * USB_MASS_1_SECOND)
@@ -213,7 +213,7 @@ typedef struct {
   This function get the parameters for the USB mass storage media,
   It is used both to initialize the media during the Start() phase
   of Driver Binding Protocol and to re-initialize it when the media is
-  changed. Althought the RemoveableMedia is unlikely to change,
+  changed. Although the RemoveableMedia is unlikely to change,
   it is also included here.
 
   @param  UsbMassThe device to retrieve disk gemotric.
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h 
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
index ea03cf7e2fd4..3ef8f240a2c1 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
@@ -14,14 +14,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 extern USB_MASS_TRANSPORT mUsbBotTransport;
 
 //
-// Usb Bulk-Only class specfic request
+// Usb Bulk-Only class specific request
 //
 #define USB_BOT_RESET_REQUEST0xFF   ///< Bulk-Only Mass Storage Reset
 #define USB_BOT_GETLUN_REQUEST   0xFE   ///< Get Max Lun
 #define USB_BOT_CBW_SIGNATURE0x43425355 ///< dCBWSignature, tag the packet 
as CBW
 #define USB_BOT_CSW_SIGNATURE0x53425355 ///< dCSWSignature, tag the packet 
as CSW
 #define USB_BOT_MAX_LUN  0x0F   ///< Lun number is from 0 to 15
-#define USB_BOT_MAX_CMDLEN   16 ///< Maxium number of command from 
command set
+#define USB_BOT_MAX_CMDLEN   16 ///< Maximum number of command 
from command set
 
 //
 // Usb BOT command block status values
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h 
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
index 287c0330f61e..b79b9c243630 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
@@ -1,5 +1,5 @@
 /** @file
-  Defination for the USB mass storage Control/Bulk/Interrupt (CBI) transport,
+  Definition for the USB mass storage Control/Bulk/Interrupt (CBI) transport,
   according to USB Mass Storage Class Control/Bulk/Interrupt (CBI) Transport, 
Revision 1.1.
 
 Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h 
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
index 9f63deeae3db..283bed7055a0 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
@@ -48,7 +48,7 @@ USBMassDriverBindingSupported (
 /**
   Starts the USB mass storage device with this driver.
 
-  This function consumes USB I/O Portocol, intializes USB mass storage device,
+  This function consumes USB I/O Protocol, initializes USB mass storage device,
   installs Block I/O Protocol, and submits Asynchronous Interrupt
   Transfer to manage the USB mass storage device.
 
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c 
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
index 600896b6a214..aab4061e183c 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
@@ -197,7 +197,7 @@ UsbBootExecCmd (
 
   //
   // If ExecCommand() returns no error and CmdResult is success,
-  // then the commnad transfer is successful.
+  // then the command transfer is successful.
   //
   if ((CmdResult == USB_MASS_CMD_SUCCESS) && !EFI_ERROR (Status)) {
 return EFI_SUCCESS;
@@ -610,7 +610,7 @@ UsbScsiModeSense (
   This function get the 

[edk2-devel] [PATCH 31/79] NetworkPkg: Fix a typo

[Philippe Mathieu-Daudé]

Correctly write 'malformatted' in documentation, comments and
debug strings.

Cc: Andrew Fish 
Cc: Laszlo Ersek 
Cc: Leif Lindholm 
Cc: Michael D Kinney 
Signed-off-by: Philippe Mathieu-Daude 
---
 NetworkPkg/Dhcp4Dxe/Dhcp4Option.h|  6 +++---
 NetworkPkg/Ip4Dxe/Ip4Icmp.h  |  2 +-
 NetworkPkg/Ip4Dxe/Ip4Igmp.h  |  2 +-
 NetworkPkg/Ip4Dxe/Ip4Option.h|  4 ++--
 NetworkPkg/Ip6Dxe/Ip6Icmp.h  |  4 ++--
 NetworkPkg/Mtftp4Dxe/Mtftp4Option.h  |  4 ++--
 NetworkPkg/Dhcp4Dxe/Dhcp4Option.c| 10 +-
 NetworkPkg/Ip4Dxe/Ip4Icmp.c  |  2 +-
 NetworkPkg/Ip4Dxe/Ip4Igmp.c  |  2 +-
 NetworkPkg/Ip4Dxe/Ip4Option.c|  2 +-
 NetworkPkg/Ip6Dxe/Ip6Icmp.c  |  4 ++--
 NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 10 +-
 NetworkPkg/Mtftp4Dxe/Mtftp4Option.c  |  6 +++---
 NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c |  2 +-
 NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c |  2 +-
 NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c |  2 +-
 NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c |  2 +-
 17 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h 
b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
index 9e25386507ed..393176c8996d 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
@@ -133,7 +133,7 @@ DhcpIterateOptions (
   @param[out] Para   The variable to save the DHCP parameters.
 
   @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory to validate the 
packet.
-  @retval EFI_INVALID_PARAMETER  The options are mal-formated
+  @retval EFI_INVALID_PARAMETER  The options are malformatted
   @retval EFI_SUCCESSThe options are parsed into OptionPoint
 
 **/
@@ -167,7 +167,7 @@ DhcpValidateOptions (
 
   @retval EFI_NOT_FOUND  Cannot find any option.
   @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory to parse the packet.
-  @retval EFI_INVALID_PARAMETER  The options are mal-formated
+  @retval EFI_INVALID_PARAMETER  The options are malformatted
   @retval EFI_SUCCESSThe options are parsed into OptionPoint
 
 **/
@@ -211,7 +211,7 @@ DhcpAppendOption (
  function.
 
   @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory
-  @retval EFI_INVALID_PARAMETER  The options in SeekPacket are mal-formated
+  @retval EFI_INVALID_PARAMETER  The options in SeekPacket are malformatted
   @retval EFI_SUCCESSThe packet is build.
 
 **/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.h b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
index 922886a96e67..a52200176f5a 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Icmp.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
@@ -83,7 +83,7 @@ extern EFI_IP4_ICMP_TYPE  mIp4SupportedIcmp[];
   @param[in]  Packet The content of the ICMP query with IP4 head
  removed.
 
-  @retval EFI_INVALID_PARAMETER  The packet is malformated.
+  @retval EFI_INVALID_PARAMETER  The packet is malformatted.
   @retval EFI_SUCCESSThe ICMP message is successfully processed.
   @retval Others Failed to handle ICMP packet.
 
diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.h b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
index 0cc944594441..49c13ba3a7a0 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Igmp.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
@@ -111,7 +111,7 @@ Ip4LeaveGroup (
   @param[in]  Head   The IP4 header of the received message.
   @param[in]  Packet The IGMP message, without IP4 header.
 
-  @retval EFI_INVALID_PARAMETER  The IGMP message is malformated.
+  @retval EFI_INVALID_PARAMETER  The IGMP message is malformatted.
   @retval EFI_SUCCESSThe IGMP message is successfully processed.
 
 **/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.h b/NetworkPkg/Ip4Dxe/Ip4Option.h
index 57a5a58725f0..a39fd2b4c69d 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Option.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Option.h
@@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 /**
   Validate the IP4 option format for both the packets we received
   and will transmit. It will compute the ICMP error message fields
-  if the option is mal-formated. But this information isn't used.
+  if the option is malformatted. But this information isn't used.
 
   @param[in]  OptionThe first byte of the option
   @param[in]  OptionLen The length of the whole option
@@ -28,7 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 otherwise the option we wants to transmit.
 
   @retval TRUE The option is properly formatted
-  @retval FALSEThe option is mal-formated
+  @retval FALSEThe option is malformatted
 
 **/
 BOOLEAN
diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.h b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
index 49a65f296adb..c63adb009519 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Icmp.h
+++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
@@ -35,7 +35,7 @@ extern EFI_IP6_ICMP_TYPE  mIp6SupportedIcmp[];
   @param[in]  Packet The content of the ICMPv6 packet with IP 

[edk2-devel] [PATCH 24/79] MdeModulePkg/Usb: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h |  2 +-
 MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 10 +-
 MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h   |  2 +-
 MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c   |  2 +-
 MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c  |  2 +-
 MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c |  2 +-
 MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c |  8 
 MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c   |  6 +++---
 8 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h 
b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
index 266581b80995..e06e2533a776 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
@@ -1,5 +1,5 @@
 /** @file
-Common Libarary  for PEI USB.
+Common Library  for PEI USB.
 
 Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
 
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h 
b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
index 65819e43e6bd..852e43390d81 100644
--- a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
+++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
@@ -377,7 +377,7 @@ UsbKeyboardComponentNameGetControllerName (
 // Functions of Simple Text Input Protocol
 //
 /**
-  Reset the input device and optionaly run diagnostics
+  Reset the input device and optionally run diagnostics
 
   There are 2 types of reset for USB keyboard.
   For non-exhaustive reset, only keyboard buffer is cleared.
@@ -406,8 +406,8 @@ USBKeyboardReset (
information for the key that was pressed.
 
   @retval EFI_SUCCESS  The keystroke information was returned.
-  @retval EFI_NOT_READYThere was no keystroke data availiable.
-  @retval EFI_DEVICE_ERROR The keydtroke information was not returned due 
to
+  @retval EFI_NOT_READYThere was no keystroke data available.
+  @retval EFI_DEVICE_ERROR The keystroke information was not returned due 
to
hardware errors.
 
 **/
@@ -507,7 +507,7 @@ USBKeyboardSetState (
   @param  NotifyHandlePoints to the unique handle assigned to 
the registered notification.
 
   @retval EFI_SUCCESS The notification function was registered 
successfully.
-  @retval EFI_OUT_OF_RESOURCESUnable to allocate resources for 
necesssary data structures.
+  @retval EFI_OUT_OF_RESOURCESUnable to allocate resources for 
necessary data structures.
   @retval EFI_INVALID_PARAMETER   KeyData or NotifyHandle or 
KeyNotificationFunction is NULL.
 
 **/
@@ -574,7 +574,7 @@ KbdFreeNotifyList (
   @param  InputData A pointer to keystroke data for the key that was 
pressed.
 
   @retval TRUE  Key pressed matches a registered key.
-  @retval FLASE Key pressed does not matche a registered key.
+  @retval FALSE Key pressed does not match a registered key.
 
 **/
 BOOLEAN
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h 
b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
index 601fdd0c92e2..811f136b65b2 100644
--- a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
+++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
@@ -108,7 +108,7 @@ ReleaseKeyboardLayoutResources (
 
   This function is the handler function for USB keyboard's asynchronous 
interrupt transfer
   to manage the keyboard. It parses the USB keyboard input report, and inserts 
data to
-  keyboard buffer according to state of modifer keys and normal keys. Timer 
for repeat key
+  keyboard buffer according to state of modifier keys and normal keys. Timer 
for repeat key
   is also set accordingly.
 
   @param  Data A pointer to a buffer that is filled with key data 
which is
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c 
b/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
index 5c071c661a45..2b1ca20a6314 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
@@ -192,7 +192,7 @@ BotDataPhase (
   TransferredSize = 0;
 
   //
-  // retrieve the the max packet length of the given endpoint
+  // retrieve the max packet length of the given endpoint
   //
   if (Direction == EfiUsbDataIn) {
 MaxPacketLen  = (PeiBotDev->BulkInEndpoint)->MaxPacketSize;
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c 
b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
index 9e6e748845d4..41f782a78bf9 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
@@ -1,5 +1,5 @@
 /** @file
-Pei USB ATATPI command implementations.
+Pei USB ATAPI command implementations.
 
 Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
 
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c 
b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
index fe9e6203010e..292682a2e447 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
+++ 

[edk2-devel] [PATCH 27/79] MdePkg/Library/Pci: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Michael D Kinney 
Cc: Liming Gao 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdePkg/Include/Library/PciCf8Lib.h| 4 ++--
 MdePkg/Include/Library/PciExpressLib.h| 4 ++--
 MdePkg/Include/Library/PciLib.h   | 4 ++--
 MdePkg/Include/Library/PciSegmentLib.h| 4 ++--
 MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c | 2 +-
 MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 4 ++--
 6 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/MdePkg/Include/Library/PciCf8Lib.h 
b/MdePkg/Include/Library/PciCf8Lib.h
index 41558dabddc2..7e22a527a80e 100644
--- a/MdePkg/Include/Library/PciCf8Lib.h
+++ b/MdePkg/Include/Library/PciCf8Lib.h
@@ -1027,7 +1027,7 @@ PciCf8BitFieldAndThenOr32 (
   Size into the buffer specified by Buffer. This function only allows the PCI
   configuration registers from a single PCI function to be read. Size is
   returned. When possible 32-bit PCI configuration read cycles are used to read
-  from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+  from StartAddress to StartAddress + Size. Due to alignment restrictions, 
8-bit
   and 16-bit PCI configuration read cycles may be used at the beginning and the
   end of the range.
 
@@ -1060,7 +1060,7 @@ PciCf8ReadBuffer (
   Size from the buffer specified by Buffer. This function only allows the PCI
   configuration registers from a single PCI function to be written. Size is
   returned. When possible 32-bit PCI configuration write cycles are used to
-  write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+  write from StartAddress to StartAddress + Size. Due to alignment 
restrictions,
   8-bit and 16-bit PCI configuration write cycles may be used at the beginning
   and the end of the range.
 
diff --git a/MdePkg/Include/Library/PciExpressLib.h 
b/MdePkg/Include/Library/PciExpressLib.h
index aec2b5f3777d..826fdcf7db6c 100644
--- a/MdePkg/Include/Library/PciExpressLib.h
+++ b/MdePkg/Include/Library/PciExpressLib.h
@@ -997,7 +997,7 @@ PciExpressBitFieldAndThenOr32 (
   Size into the buffer specified by Buffer. This function only allows the PCI
   configuration registers from a single PCI function to be read. Size is
   returned. When possible 32-bit PCI configuration read cycles are used to read
-  from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+  from StartAddress to StartAddress + Size. Due to alignment restrictions, 
8-bit
   and 16-bit PCI configuration read cycles may be used at the beginning and the
   end of the range.
 
@@ -1029,7 +1029,7 @@ PciExpressReadBuffer (
   Size from the buffer specified by Buffer. This function only allows the PCI
   configuration registers from a single PCI function to be written. Size is
   returned. When possible 32-bit PCI configuration write cycles are used to
-  write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+  write from StartAddress to StartAddress + Size. Due to alignment 
restrictions,
   8-bit and 16-bit PCI configuration write cycles may be used at the beginning
   and the end of the range.
 
diff --git a/MdePkg/Include/Library/PciLib.h b/MdePkg/Include/Library/PciLib.h
index 7a7d42050f0a..836494b6c1d7 100644
--- a/MdePkg/Include/Library/PciLib.h
+++ b/MdePkg/Include/Library/PciLib.h
@@ -997,7 +997,7 @@ PciBitFieldAndThenOr32 (
   Size into the buffer specified by Buffer. This function only allows the PCI
   configuration registers from a single PCI function to be read. Size is
   returned. When possible 32-bit PCI configuration read cycles are used to read
-  from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+  from StartAddress to StartAddress + Size. Due to alignment restrictions, 
8-bit
   and 16-bit PCI configuration read cycles may be used at the beginning and the
   end of the range.
 
@@ -1029,7 +1029,7 @@ PciReadBuffer (
   Size from the buffer specified by Buffer. This function only allows the PCI
   configuration registers from a single PCI function to be written. Size is
   returned. When possible 32-bit PCI configuration write cycles are used to
-  write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+  write from StartAddress to StartAddress + Size. Due to alignment 
restrictions,
   8-bit and 16-bit PCI configuration write cycles may be used at the beginning
   and the end of the range.
 
diff --git a/MdePkg/Include/Library/PciSegmentLib.h 
b/MdePkg/Include/Library/PciSegmentLib.h
index bd31f05a23fe..fcd98dbfd8df 100644
--- a/MdePkg/Include/Library/PciSegmentLib.h
+++ b/MdePkg/Include/Library/PciSegmentLib.h
@@ -984,7 +984,7 @@ PciSegmentBitFieldAndThenOr32 (
   Size into the buffer specified by Buffer. This function only allows the PCI
   configuration 

[edk2-devel] [PATCH 26/79] MdePkg/Library/Dxe: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in documentation, comments and strings,
and remove the duplicated 'the'.

Cc: Michael D Kinney 
Cc: Liming Gao 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdePkg/Library/DxePcdLib/DxePcdLib.inf |  2 +-
 MdePkg/Include/Library/DxeServicesLib.h|  2 +-
 MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c | 10 
+-
 MdePkg/Library/DxeHobLib/HobLib.c  |  2 +-
 MdePkg/Library/DxeIoLibCpuIo2/IoLib.c  |  2 +-
 MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c |  6 
+++---
 MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 12 
++--
 MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c   |  2 +-
 MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c   |  2 +-
 MdePkg/Library/DxePcdLib/DxePcdLib.uni |  2 +-
 10 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/MdePkg/Library/DxePcdLib/DxePcdLib.inf 
b/MdePkg/Library/DxePcdLib/DxePcdLib.inf
index c3f67543a4b7..3d4d21b442b4 100644
--- a/MdePkg/Library/DxePcdLib/DxePcdLib.inf
+++ b/MdePkg/Library/DxePcdLib/DxePcdLib.inf
@@ -16,7 +16,7 @@
 # Note: A driver of type DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER can only use 
this DxePcdLib
 #  in their initialization without any issues to access Dynamic and DynamicEx 
PCD. They can't
 #  access Dynamic and DynamicEx PCD in the implementation of runtime services 
and SMI handlers.
-#  Because EFI_PCD_PROTOCOL is DXE protocol that is not aviable in OS runtime 
phase.
+#  Because EFI_PCD_PROTOCOL is DXE protocol that is not available in OS 
runtime phase.
 #
 # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
 #
diff --git a/MdePkg/Include/Library/DxeServicesLib.h 
b/MdePkg/Include/Library/DxeServicesLib.h
index 838abf356fdd..689f47a54fa1 100644
--- a/MdePkg/Include/Library/DxeServicesLib.h
+++ b/MdePkg/Include/Library/DxeServicesLib.h
@@ -171,7 +171,7 @@ GetSectionFromFv (
 
 
 /**
-  Searches the FFS file the the currently executing module was loaded from and 
returns the first matching FFS section.
+  Searches the FFS file the currently executing module was loaded from and 
returns the first matching FFS section.
 
   This function searches the FFS file that the currently executing module was 
loaded from for a FFS sections of type SectionType.
   If the FFS file contains at least SectionInstance instances of the FFS 
section specified by SectionType,
diff --git 
a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c 
b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c
index 4dfe450be9bc..ef730ec55159 100644
--- a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c
+++ b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c
@@ -150,7 +150,7 @@ ExtractGuidedSectionGetGuidList (
   If GetInfoHandler is NULL, then ASSERT().
   If DecodeHandler is NULL, then ASSERT().
 
-  @param[in]  SectionGuidA pointer to the GUID associated with the the 
handlers
+  @param[in]  SectionGuidA pointer to the GUID associated with the handlers
  of the GUIDed section type being registered.
   @param[in]  GetInfoHandler The pointer to a function that examines a GUIDed 
section and returns the
  size of the decoded buffer and the size of an 
optional scratch buffer
@@ -231,9 +231,9 @@ ExtractGuidedSectionRegisterHandlers (
   Examines a GUIDed section specified by InputSection.
   If GUID for InputSection does not match any of the GUIDs registered through 
ExtractGuidedSectionRegisterHandlers(),
   then RETURN_UNSUPPORTED is returned.
-  If the GUID of InputSection does match the GUID that this handler supports, 
then the the associated handler
+  If the GUID of InputSection does match the GUID that this handler supports, 
then the associated handler
   of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER that was registered with 
ExtractGuidedSectionRegisterHandlers()
-  is used to retrieve the OututBufferSize, ScratchSize, and Attributes values. 
The return status from the handler of
+  is used to retrieve the OutputBufferSize, ScratchSize, and Attributes 
values. The return status from the handler of
   type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER is returned.
 
   If InputSection is NULL, then ASSERT().
@@ -311,7 +311,7 @@ ExtractGuidedSectionGetInfo (
   Decodes the GUIDed section specified by InputSection.
   If GUID for InputSection does not match any of the GUIDs registered through 
ExtractGuidedSectionRegisterHandlers(),
   then RETURN_UNSUPPORTED is returned.
-  If the GUID of InputSection does match the GUID that this handler supports, 
then the the associated handler
+  If the GUID of InputSection does match the GUID that this handler 

[edk2-devel] [PATCH 33/79] NetworkPkg/Dhcp4Dxe: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jiaxin Wu 
Cc: Siyuan Fu 
Cc: Maciej Rabeda 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h |  4 +--
 NetworkPkg/Dhcp4Dxe/Dhcp4Io.h |  2 +-
 NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 18 +++---
 NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c |  8 +++---
 NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c   |  6 ++---
 NetworkPkg/Dhcp4Dxe/Dhcp4Io.c | 12 -
 NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 26 ++--
 7 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h 
b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
index cebde20dca5b..f6370582cbd1 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
@@ -104,7 +104,7 @@ Dhcp4DriverBindingStop (
   then a new handle is created. If it is a pointer to an 
existing UEFI handle,
   then the protocol is added to the existing UEFI handle.
 
-  @retval EFI_SUCCESThe protocol was added to ChildHandle.
+  @retval EFI_SUCCESS   The protocol was added to ChildHandle.
   @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
   @retval EFI_OUT_OF_RESOURCES  There are not enough resources available to 
create
 the child
@@ -128,7 +128,7 @@ Dhcp4ServiceBindingCreateChild (
   @param  ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
   @param  ChildHandle Handle of the child to destroy
 
-  @retval EFI_SUCCESThe protocol was removed from ChildHandle.
+  @retval EFI_SUCCESS   The protocol was removed from ChildHandle.
   @retval EFI_UNSUPPORTED   ChildHandle does not support the protocol that 
is being removed.
   @retval EFI_INVALID_PARAMETER Child handle is NULL.
   @retval EFI_ACCESS_DENIED The protocol could not be removed from the 
ChildHandle
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
index 01283e5e17b9..0dd6b46b87d0 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
@@ -108,7 +108,7 @@ DhcpSendMessage (
 /**
   Each DHCP service has three timer. Two of them are count down timer.
   One for the packet retransmission. The other is to collect the offers.
-  The third timer increaments the lease life which is compared to T1, T2,
+  The third timer increments the lease life which is compared to T1, T2,
   and lease to determine the time to renew and rebind the lease.
   DhcpOnTimerTick will be called once every second.
 
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h 
b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
index 393176c8996d..a58bb1b0baa8 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
@@ -81,9 +81,9 @@ typedef struct {
 ///
 /// Structure used to describe and validate the format of DHCP options.
 /// Type is the options' data type, such as DHCP_OPTION_INT8. MinOccur
-/// is the minium occurance of this data type. MaxOccur is defined
+/// is the minimum occurrence of this data type. MaxOccur is defined
 /// similarly. If MaxOccur is -1, it means that there is no limit on the
-/// maximum occurance. Alert tells whether DHCP client should further
+/// maximum occurrence. Alert tells whether DHCP client should further
 /// inspect the option to parse DHCP_PARAMETER.
 ///
 typedef struct {
@@ -114,8 +114,8 @@ EFI_STATUS
  found
   @param[in]  ContextThe opaque parameter for Check
 
-  @retval EFI_SUCCESSThe DHCP packet's options are well formated
-  @retval EFI_INVALID_PARAMETER  The DHCP packet's options are not well 
formated
+  @retval EFI_SUCCESSThe DHCP packet's options are well formatted
+  @retval EFI_INVALID_PARAMETER  The DHCP packet's options are not well 
formatted
 
 **/
 EFI_STATUS
@@ -133,7 +133,7 @@ DhcpIterateOptions (
   @param[out] Para   The variable to save the DHCP parameters.
 
   @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory to validate the 
packet.
-  @retval EFI_INVALID_PARAMETER  The options are malformatted
+  @retval EFI_INVALID_PARAMETER  The options are mal-formatted
   @retval EFI_SUCCESSThe options are parsed into OptionPoint
 
 **/
@@ -146,8 +146,8 @@ DhcpValidateOptions (
 /**
   Parse the options of a DHCP packet. It supports RFC 3396: Encoding
   Long Options in DHCP. That is, it will combine all the option value
-  of all the occurances of each option.
-  A little bit of implemenation:
+  of all the occurrences of each option.
+  A little bit of implementation:
   It adopts the "Key indexed counting" algorithm. First, it allocates
   an array of 256 DHCP_OPTION_COUNTs because DHCP option tag is encoded
   as a UINT8. It then iterates the DHCP packet to get data length of
@@ -167,7 +167,7 @@ DhcpValidateOptions (
 
   @retval EFI_NOT_FOUND  Cannot find any option.
   @retval EFI_OUT_OF_RESOURCES   

[edk2-devel] [PATCH 30/79] MdePkg/Register: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Michael D Kinney 
Cc: Liming Gao 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdePkg/Include/Register/Amd/Cpuid.h   | 8 
 MdePkg/Include/Register/Amd/Fam17Msr.h| 2 +-
 MdePkg/Include/Register/Amd/Msr.h | 2 +-
 MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h   | 2 +-
 MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h| 2 +-
 MdePkg/Include/Register/Intel/StmResourceDescriptor.h | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/MdePkg/Include/Register/Amd/Cpuid.h 
b/MdePkg/Include/Register/Amd/Cpuid.h
index ad1ba4d016e0..8e91e84b767f 100644
--- a/MdePkg/Include/Register/Amd/Cpuid.h
+++ b/MdePkg/Include/Register/Amd/Cpuid.h
@@ -11,7 +11,7 @@
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Specification Reference:
-  AMD64 Architecture Programming Manaul volume 2, March 2017, Sections 15.34
+  AMD64 Architecture Programming Manual volume 2, March 2017, Sections 15.34
 
 **/
 
@@ -364,7 +364,7 @@ typedef union {
 ///
 UINT32  Page1GB:1;
 ///
-/// [Bit 27] RDTSCP intructions.
+/// [Bit 27] RDTSCP instructions.
 ///
 UINT32  RDTSCP:1;
 ///
@@ -513,9 +513,9 @@ typedef union {
 
   @retval  EAX  Extended APIC ID described by the type
 CPUID_AMD_PROCESSOR_TOPOLOGY_EAX.
-  @retval  EBX  Core Indentifiers described by the type
+  @retval  EBX  Core Identifiers described by the type
 CPUID_AMD_PROCESSOR_TOPOLOGY_EBX.
-  @retval  ECX  Node Indentifiers described by the type
+  @retval  ECX  Node Identifiers described by the type
 CPUID_AMD_PROCESSOR_TOPOLOGY_ECX.
   @retval  EDX  Reserved.
 **/
diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h 
b/MdePkg/Include/Register/Amd/Fam17Msr.h
index 37b935dcdb30..6ef45a9b21d3 100644
--- a/MdePkg/Include/Register/Amd/Fam17Msr.h
+++ b/MdePkg/Include/Register/Amd/Fam17Msr.h
@@ -10,7 +10,7 @@
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Specification Reference:
-  AMD64 Architecture Programming Manaul volume 2, March 2017, Sections 15.34
+  AMD64 Architecture Programming Manual volume 2, March 2017, Sections 15.34
 
 **/
 
diff --git a/MdePkg/Include/Register/Amd/Msr.h 
b/MdePkg/Include/Register/Amd/Msr.h
index e74de7a1df48..084eb892cdd9 100644
--- a/MdePkg/Include/Register/Amd/Msr.h
+++ b/MdePkg/Include/Register/Amd/Msr.h
@@ -10,7 +10,7 @@
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Specification Reference:
-  AMD64 Architecture Programming Manaul volume 2, March 2017, Sections 15.34
+  AMD64 Architecture Programming Manual volume 2, March 2017, Sections 15.34
 
 **/
 
diff --git a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h 
b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
index 2edc1363b7c4..c56d20df66a4 100644
--- a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
+++ b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
@@ -1,5 +1,5 @@
 /** @file
-  MSR Defintions for Intel Atom processors based on the Goldmont Plus 
microarchitecture.
+  MSR Definitions for Intel Atom processors based on the Goldmont Plus 
microarchitecture.
 
   Provides defines for Machine Specific Registers(MSR) indexes. Data structures
   are provided for MSRs that contain one or more bit fields.  If the MSR value
diff --git a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h 
b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
index 30f96f0e82fa..03cac77c19a6 100644
--- a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
+++ b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
@@ -1,5 +1,5 @@
 /** @file
-  MSR Defintions for Intel processors based on the 
Skylake/Kabylake/Coffeelake/Cannonlake microarchitecture.
+  MSR Definitions for Intel processors based on the 
Skylake/Kabylake/Coffeelake/Cannonlake microarchitecture.
 
   Provides defines for Machine Specific Registers(MSR) indexes. Data structures
   are provided for MSRs that contain one or more bit fields.  If the MSR value
diff --git a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h 
b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
index da4c91d0f4b8..3e426701e83c 100644
--- a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
+++ b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
@@ -179,7 +179,7 @@ typedef struct {
 } STM_RSC_ALL_RESOURCES_DESC;
 
 /**
-  STM Register Volation Descriptor
+  STM Register Violation Descriptor
 **/
 typedef struct {
   STM_RSC_DESC_HEADER  Hdr;
-- 
2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51636): https://edk2.groups.io/g/devel/message/51636
Mute This Topic: https://groups.io/mt/65773787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)

[Philippe Mathieu-Daudé]

Around February of this year, Antoine posted various patches fixing
a huge quantity of typos, over 8000+ lines (such [1]).

The community merged the smaller patches, and told him his patches
were too big, and he should split them.
Around June, Antoine opened a GitHub pull request [2], due to the
size of his patchset. We told him the project doesn't accept GitHub
PR.

Since I find his cleanup work very valuable for the project, I
spent few hours trying to salvage a chunk of it, splitting per
maintainer areas, each patch not to big to avoid reviewers burning
out. I expect each maintainer to take his patches.

I wanted to split Antoine work in 3 parts, but I'm about at 80
patches, for only 1854 lines changed, so enough for a first round.

Oh, and it is easier to review the patches using '--word-diff=color'
git option :)

Regards,

Phil.

P.D.: I think the project is really failing at getting new
contributors involved, and keeping them. But that is another topic.

[1] https://edk2.groups.io/g/devel/message/43043
[2] https://edk2.groups.io/g/devel/message/42941

Antoine Coeur (72):
  CryptoPkg/OpensslLib: Fix few typos
  EmbeddedPkg/FdtLib: Fix a typo
  EmbeddedPkg/VirtualKeyboard: Fix few typos
  EmulatorPkg/Sec: Fix various typos
  EmulatorPkg/Unix: Fix various typos
  EmulatorPkg/Win: Fix various typos
  FatPkg/EnhancedFatDxe: Fix various typos
  FatPkg/FatPei: Fix few typos
  IntelFsp2WrapperPkg: Fix various typos
  MdeModulePkg/Application: Improve French translation
  MdeModulePkg/Application: Fix various typos
  MdeModulePkg/Bus/Ata: Fix various typos
  MdeModulePkg/Bus/I2c: Fix few typos
  MdeModulePkg/Bus/Isa: Fix various typos
  MdeModulePkg/Bus/Scsi: Fix various typos
  MdeModulePkg/Bus/Sd: Fix various typos
  MdeModulePkg/Core/Pei: Fix various typos
  MdeModulePkg/Core/PiSmmCore: Fix various typos
  MdeModulePkg/UsbMass: Fix various typos
  MdeModulePkg/UsbMouse: Fix few typos
  MdeModulePkg/UsbBus: Fix various typos
  MdeModulePkg/Usb: Fix various typos
  MdePkg/IndustryStandard: Fix various typos
  MdePkg/Library/Dxe: Fix various typos
  MdePkg/Library/Pci: Fix various typos
  MdePkg/Library/Smm: Fix various typos
  MdePkg/Ppi: Fix various typos
  MdePkg/Register: Fix various typos
  NetworkPkg/ArpDxe: Fix various typos
  NetworkPkg/Dhcp4Dxe: Fix various typos
  NetworkPkg/Dhcp6Dxe: Fix various typos
  NetworkPkg/DnsDxe: Fix various typos
  NetworkPkg/DpcDxe: Fix few typos
  NetworkPkg/HttpBootDxe: Fix various typos
  NetworkPkg/HttpDxe: Fix various typos
  NetworkPkg/Ip4Dxe: Fix various typos
  NetworkPkg/Ip6Dxe: Fix various typos
  NetworkPkg/IScsiDxe: Fix various typos
  NetworkPkg/Library: Fix various typos
  NetworkPkg/MnpDxe: Fix various typos
  NetworkPkg/Mtftp4Dxe: Fix various typos
  NetworkPkg/Mtftp6Dxe: Fix various typos
  NetworkPkg/SnpDxe: Fix few typos
  NetworkPkg/TcpDxe/Sock: Fix few typos
  NetworkPkg/TcpDxe/Tcp: Fix various typos
  NetworkPkg/Tls: Fix few typos
  NetworkPkg/Udp4Dxe: Fix various typos
  NetworkPkg/Udp6Dxe: Fix various typos
  NetworkPkg/UefiPxeBcDxe: Fix various typos
  NetworkPkg/VlanConfigDxe: Fix few typos
  OvmfPkg/Acpi: Fix few typos
  OvmfPkg/Csm: Fix various typos
  OvmfPkg/Qemu: Fix various typos
  OvmfPkg/Virtio: Fix few typos
  OvmfPkg/Xen: Fix various typos
  PcAtChipsetPkg: Fix few typos
  SecurityPkg: Fix few typos
  SecurityPkg/Hash2DxeCrypto: Fix few typos
  SecurityPkg/Library/Tpm: Fix various typos
  SecurityPkg/Tcg: Fix various typos
  SecurityPkg/VariableAuthenticated: Fix few typos
  ShellPkg/Application: Fix various typos
  ShellPkg/DynamicCommand: Fix various typos
  SignedCapsulePkg: Fix various typos
  SignedCapsulePkg/Universal: Fix various typos
  SourceLevelDebugPkg/DebugAgent: Fix various typos
  SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
  SourceLevelDebugPkg: Fix few typos
  StandaloneMmPkg: Fix few typos
  UefiCpuPkg/CpuDxe: Fix few typos
  UefiCpuPkg/PiSmm: Fix various typos
  UefiCpuPkg/Smm: Fix various typos

Philippe Mathieu-Daude (7):
  EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER
  MdeModulePkg/UsbBusDxe: Fix a typo
  NetworkPkg: Fix a typo
  NetworkPkg/DnsDxe: Fix a typo
  NetworkPkg/HttpBootDxe: Fix a typo in variable name
  OvmfPkg/Xen: Fix a typo
  StandaloneMmPkg: Fix a typo

 SignedCapsulePkg/SignedCapsulePkg.dec  
 |  4 +-
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf   
 |  2 +-
 MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf   
 |  2 +-
 MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf   
 | 10 ++--
 MdePkg/Library/DxePcdLib/DxePcdLib.inf 
 |  2 +-
 NetworkPkg/MnpDxe/MnpDxe.inf   
 |  2 +-
 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf  

[edk2-devel] [PATCH 16/79] MdeModulePkg/Bus/Scsi: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h   |  4 +--
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 10 +++---
 MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c   |  6 ++--
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 32 ++--
 4 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h 
b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h
index 917e937520a8..97581866b6f7 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h
+++ b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h
@@ -50,7 +50,7 @@ typedef struct {
 } SCSI_EVENT_DATA;
 
 //
-// SCSI Bus Controller device strcuture
+// SCSI Bus Controller device structure
 //
 #define SCSI_BUS_DEVICE_SIGNATURE  SIGNATURE_32 ('s', 'c', 's', 'i')
 
@@ -450,7 +450,7 @@ ScsiExecuteSCSICommand (
 
   @param  This   Protocol instance pointer
   @param  Controller Controller handle
-  @param  TargetId   Tartget to be scanned
+  @param  TargetId   Target to be scanned
   @param  LunThe Lun of the SCSI device on the SCSI channel.
   @param  ScsiBusDev The pointer of SCSI_BUS_DEVICE
 
diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h 
b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
index 2d8679ec6fd0..ed9bbd6f8ba8 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
+++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
@@ -185,7 +185,7 @@ extern EFI_COMPONENT_NAME2_PROTOCOL  
gScsiDiskComponentName2;
 //
 // SCSI Disk Timeout Experience Value
 //
-// As ScsiDisk and ScsiBus driver are used to manage SCSI or ATAPI devices, 
the timout
+// As ScsiDisk and ScsiBus driver are used to manage SCSI or ATAPI devices, 
the timeout
 // value is updated to 30s to follow ATA/ATAPI spec in which the device may 
take up to 30s
 // to respond command.
 //
@@ -412,7 +412,7 @@ ScsiDiskComponentNameGetControllerName (
   @retval EFI_SUCCESS  The device was reset.
   @retval EFI_DEVICE_ERROR The device is not functioning properly and could
not be reset.
-  @return EFI_STATUS is retured from EFI_SCSI_IO_PROTOCOL.ResetDevice().
+  @return EFI_STATUS is returned from EFI_SCSI_IO_PROTOCOL.ResetDevice().
 
 **/
 EFI_STATUS
@@ -464,7 +464,7 @@ ScsiDiskReadBlocks (
   @retval EFI_WRITE_PROTECTED   The device can not be written to.
   @retval EFI_DEVICE_ERROR  Fail to detect media.
   @retval EFI_NO_MEDIA  Media is not present.
-  @retval EFI_MEDIA_CHNAGED Media has changed.
+  @retval EFI_MEDIA_CHANGED Media has changed.
   @retval EFI_BAD_BUFFER_SIZE   The Buffer was not a multiple of the block 
size of the device.
   @retval EFI_INVALID_PARAMETER Invalid parameter passed in.
 
@@ -1010,7 +1010,7 @@ CheckTargetStatus (
 
   When encountering error during the process, if retrieve sense keys before
   error encountered, it returns the sense keys with return status set to 
EFI_SUCCESS,
-  and NeedRetry set to FALSE; otherwize, return the proper return status.
+  and NeedRetry set to FALSE; otherwise, return the proper return status.
 
   @param  ScsiDiskDevice The pointer of SCSI_DISK_DEV
   @param  NeedRetry  The pointer of flag indicates if need a retry
@@ -1444,7 +1444,7 @@ ScsiDiskIsHardwareError (
   @param  SenseCounts  The number of sense key
 
   @retval TRUE   Media is changed.
-  @retval FALSE  Medit is NOT changed.
+  @retval FALSE  Media is NOT changed.
 **/
 BOOLEAN
 ScsiDiskIsMediaChange (
diff --git a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c 
b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
index 1caffd38cdcb..27b554ad3e1d 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
+++ b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
@@ -487,7 +487,7 @@ SCSIBusDriverBindingStart (
   } else {
 //
 // If RemainingDevicePath is the End of Device Path Node,
-// skip enumerate any device and return EFI_SUCESSS
+// skip enumerate any device and return EFI_SUCCESS
 //
 ScanOtherPuns = FALSE;
   }
@@ -644,7 +644,7 @@ SCSIBusDriverBindingStop (
  );
   //
   // When Start() succeeds to open ExtPassThru, it always tries to open 
PassThru BY_DRIVER.
-  // Its intent is to prevent another SCSI Bus Driver from woking on the 
same host handle.
+  // Its intent is to prevent another SCSI Bus Driver from working on the 
same host handle.
   // So Stop() needs to try to close PassThru if present here.
   //
   gBS->CloseProtocol (
@@ -1099,7 +1099,7 @@ ScsiExecuteSCSICommand (
 
   @param  This   Protocol instance pointer
   @param  Controller Controller handle
-  @param  TargetId   Tartget to be scanned
+  @param  TargetId   Target to be scanned
   @param  LunThe Lun of the SCSI device on the SCSI channel.
   @param  ScsiBusDev The pointer of 

[edk2-devel] [PATCH 17/79] MdeModulePkg/Bus/Sd: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in comments and documentation.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h   |  2 +-
 MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h  |  6 +++---
 MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h  |  2 +-
 MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h  |  6 +++---
 MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h  |  2 +-
 MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c |  2 +-
 MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c   | 12 ++--
 MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c  | 12 ++--
 MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c  |  2 +-
 MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c |  2 +-
 MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c   |  6 +++---
 MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c  | 10 +-
 MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c  |  2 +-
 13 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h 
b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h
index c0e461335f43..4e3e51d14403 100644
--- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h
+++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h
@@ -244,7 +244,7 @@ EmmcPeimHcInitHost (
   Refer to EMMC Electrical Standard Spec 5.1 Section 6.10.4 for details.
 
   @param[in] Slot   The slot number of the Emmc card to send the 
command to.
-  @param[in] Access The access mode of SWTICH command.
+  @param[in] Access The access mode of SWITCH command.
   @param[in] Index  The offset of the field to be access.
   @param[in] Value  The value to be set to the specified field of 
EXT_CSD register.
   @param[in] CmdSet The value of CmdSet field of EXT_CSD register.
diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h 
b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
index 86957a42daea..62e70ae912b0 100644
--- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
+++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
@@ -43,7 +43,7 @@ EmmcReset (
   @retval EFI_SUCCESS   The data was read correctly from the device.
   @retval EFI_DEVICE_ERROR  The device reported an error while performing 
the read.
   @retval EFI_NO_MEDIA  There is no media in the device.
-  @retval EFI_MEDIA_CHANGED The MediaId does not matched the current 
device.
+  @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
   @retval EFI_BAD_BUFFER_SIZE   The Buffer was not a multiple of the block 
size of the device.
   @retval EFI_INVALID_PARAMETER The read request contains LBAs that are not 
valid,
 or the buffer is not on proper alignment.
@@ -73,7 +73,7 @@ EmmcReadBlocks (
   @retval EFI_WRITE_PROTECTED   The device can not be written to.
   @retval EFI_DEVICE_ERROR  The device reported an error while performing 
the write.
   @retval EFI_NO_MEDIA  There is no media in the device.
-  @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current 
device.
+  @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
   @retval EFI_BAD_BUFFER_SIZE   The Buffer was not a multiple of the block 
size of the device.
   @retval EFI_INVALID_PARAMETER The write request contains LBAs that are not 
valid,
 or the buffer is not on proper alignment.
@@ -176,7 +176,7 @@ EmmcReadBlocksEx (
   @retval EFI_WRITE_PROTECTED   The device can not be written to.
   @retval EFI_DEVICE_ERROR  The device reported an error while performing 
the write.
   @retval EFI_NO_MEDIA  There is no media in the device.
-  @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current 
device.
+  @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
   @retval EFI_BAD_BUFFER_SIZE   The Buffer was not a multiple of the block 
size of the device.
   @retval EFI_INVALID_PARAMETER The write request contains LBAs that are not 
valid,
 or the buffer is not on proper alignment.
diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h 
b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h
index d286d97f4213..5ecce41dee11 100644
--- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h
+++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h
@@ -235,7 +235,7 @@ EmmcDxeDriverBindingSupported (
   @retval EFI_SUCCESS  The device was started.
   @retval EFI_DEVICE_ERROR The device could not be started due to a 
device error.Currently not implemented.
   @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a 
lack of resources.
-  @retval Others   The driver failded to start the device.
+  @retval Others   The driver failed to start the device.
 
 **/
 EFI_STATUS
diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h 
b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h
index 769b47106400..b6b4c45f1f3d 100644
--- 

[edk2-devel] [PATCH 13/79] MdeModulePkg/Bus/Ata: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in documentation, comments and debug strings.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf |  2 +-
 MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h   |  4 ++--
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h |  4 ++--
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h |  4 ++--
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h  |  2 +-
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h  | 12 ++--
 MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c  |  8 
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 14 +++---
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c |  8 
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c  | 16 
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c  | 10 +-
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c  |  4 ++--
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni |  2 +-
 13 files changed, 45 insertions(+), 45 deletions(-)

diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf 
b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
index c3ab5c18f148..086ec5f7c6d3 100644
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
@@ -1,5 +1,5 @@
 ## @file
-#  ATA Bus driver to enumerate and identfy ATA devices.
+#  ATA Bus driver to enumerate and identify ATA devices.
 #
 #  This driver follows UEFI driver model and layers on ATA Pass Thru protocol 
defined
 #  in UEFI spec 2.2. It installs Block IO and Disk Info protocol for each ATA 
device
diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h 
b/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h
index 9a34dc6e4f15..2be78076bee7 100644
--- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h
+++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h
@@ -161,7 +161,7 @@ typedef struct {
   UINT8 AhciD2HRegisterFis[0x14];  // D2H Register Fis: offset 0x40
   UINT8 AhciD2HRegisterFisRsvd[0x04];
   UINT64AhciSetDeviceBitsFis;  // Set Device Bits Fix: offset 0x58
-  UINT8 AhciUnknownFis[0x40];  // Unkonwn Fis: offset 0x60
+  UINT8 AhciUnknownFis[0x40];  // Unknown Fis: offset 0x60
   UINT8 AhciUnknownFisRsvd[0x60];
 } EFI_AHCI_RECEIVED_FIS;
 
@@ -239,7 +239,7 @@ typedef struct {
 } EFI_AHCI_COMMAND_PRDT;
 
 //
-// Command table Data strucute which is pointed to by the entry in the command 
list
+// Command table Data structure which is pointed to by the entry in the 
command list
 //
 typedef struct {
   EFI_AHCI_COMMAND_FIS  CommandFis;   // A software constructed FIS.
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h 
b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h
index 66d5da0b714c..786413930ae9 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h
@@ -263,7 +263,7 @@ typedef struct {
 } EFI_AHCI_COMMAND_PRDT;
 
 //
-// Command table data strucute which is pointed to by the entry in the command 
list
+// Command table data structure which is pointed to by the entry in the 
command list
 //
 typedef struct {
   EFI_AHCI_COMMAND_FIS  CommandFis;   // A software constructed FIS.
@@ -283,7 +283,7 @@ typedef struct {
   UINT8AhciD2HRegisterFis[0x14];  // D2H Register Fis: offset 0x40
   UINT8AhciD2HRegisterFisRsvd[0x04];
   UINT64   AhciSetDeviceBitsFis;  // Set Device Bits Fix: offset 0x58
-  UINT8AhciUnknownFis[0x40];  // Unkonwn Fis: offset 0x60
+  UINT8AhciUnknownFis[0x40];  // Unknown Fis: offset 0x60
   UINT8AhciUnknownFisRsvd[0x60];
 } EFI_AHCI_RECEIVED_FIS;
 
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h 
b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h
index de9e1ee98f19..5f582b9b3e76 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h
@@ -384,7 +384,7 @@ AtaAtapiPassThruSupported (
   @retval EFI_SUCCESS  The device was started.
   @retval EFI_DEVICE_ERROR The device could not be started due to a 
device error.Currently not implemented.
   @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a 
lack of resources.
-  @retval Others   The driver failded to start the device.
+  @retval Others   The driver failed to start the device.
 
 **/
 EFI_STATUS
@@ -521,7 +521,7 @@ EnumerateAttachedDevice (
   );
 
 /**
-  Call back funtion when the timer event is signaled.
+  Call back function when the timer event is signaled.
 
   @param[in]  Event The Event this notify function registered to.
   @param[in]  Context   Pointer to the context data registered to the
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h 

[edk2-devel] [PATCH 08/79] FatPkg/EnhancedFatDxe: Fix various typos

[Philippe Mathieu-Daudé]

From: Antoine Coeur 

Fix various typos in FatPkg/EnhancedFatDxe comments.

Cc: Ray Ni 
Signed-off-by: Coeur 
Reviewed-by: Philippe Mathieu-Daude 
Signed-off-by: Philippe Mathieu-Daude 
---
 FatPkg/EnhancedFatDxe/Fat.h | 6 +++---
 FatPkg/EnhancedFatDxe/Delete.c  | 2 +-
 FatPkg/EnhancedFatDxe/DirectoryManage.c | 2 +-
 FatPkg/EnhancedFatDxe/Fat.c | 2 +-
 FatPkg/EnhancedFatDxe/FileName.c| 2 +-
 FatPkg/EnhancedFatDxe/FileSpace.c   | 6 +++---
 FatPkg/EnhancedFatDxe/Flush.c   | 4 ++--
 7 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/FatPkg/EnhancedFatDxe/Fat.h b/FatPkg/EnhancedFatDxe/Fat.h
index 46c185c3a9e9..fcc25952d495 100644
--- a/FatPkg/EnhancedFatDxe/Fat.h
+++ b/FatPkg/EnhancedFatDxe/Fat.h
@@ -236,7 +236,7 @@ struct _FAT_OFILE {
   UINTN   Signature;
   FAT_VOLUME  *Volume;
   //
-  // A permanant error code to return to all accesses to
+  // A permanent error code to return to all accesses to
   // this opened file
   //
   EFI_STATUS  Error;
@@ -246,7 +246,7 @@ struct _FAT_OFILE {
   LIST_ENTRY  Opens;
 
   //
-  // The dynamic infomation
+  // The dynamic information
   //
   UINTN   FileSize;
   UINTN   FileCluster;
@@ -1863,7 +1863,7 @@ FatCreate8Dot3Name (
   @param  FatName   - The Char8 string needs to be converted.
   @param  Len   - The length of the fat name.
   @param  LowerCase - Indicate whether to convert the string to 
lower case.
-  @param  Str   - The result of the convertion.
+  @param  Str   - The result of the conversion.
 
 **/
 VOID
diff --git a/FatPkg/EnhancedFatDxe/Delete.c b/FatPkg/EnhancedFatDxe/Delete.c
index b2a62b35ded8..8a437e3ee201 100644
--- a/FatPkg/EnhancedFatDxe/Delete.c
+++ b/FatPkg/EnhancedFatDxe/Delete.c
@@ -56,7 +56,7 @@ FatDelete (
 goto Done;
   }
   //
-  // If the file has a permanant error, skip the delete
+  // If the file has a permanent error, skip the delete
   //
   Status = OFile->Error;
   if (!EFI_ERROR (Status)) {
diff --git a/FatPkg/EnhancedFatDxe/DirectoryManage.c 
b/FatPkg/EnhancedFatDxe/DirectoryManage.c
index 93772dba09c2..90c01b3baa1c 100644
--- a/FatPkg/EnhancedFatDxe/DirectoryManage.c
+++ b/FatPkg/EnhancedFatDxe/DirectoryManage.c
@@ -13,7 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
   Get a directory entry from disk for the Ofile.
 
   @param  Parent- The parent of the OFile which need to update.
-  @param  IoMode- Indicate whether to read directory entry or 
write directroy entry.
+  @param  IoMode- Indicate whether to read directory entry or 
write directory entry.
   @param  EntryPos  - The position of the directory entry to be 
accessed.
   @param  Entry - The directory entry read or written.
 
diff --git a/FatPkg/EnhancedFatDxe/Fat.c b/FatPkg/EnhancedFatDxe/Fat.c
index 3bec1c94ecd8..77cda1953991 100644
--- a/FatPkg/EnhancedFatDxe/Fat.c
+++ b/FatPkg/EnhancedFatDxe/Fat.c
@@ -417,7 +417,7 @@ FatDriverBindingStart (
   Status = FatAllocateVolume (ControllerHandle, DiskIo, DiskIo2, BlockIo);
 
   //
-  // When the media changes on a device it will Reinstall the BlockIo 
interaface.
+  // When the media changes on a device it will Reinstall the BlockIo 
interface.
   // This will cause a call to our Stop(), and a subsequent reentrant call to 
our
   // Start() successfully. We should leave the device open when this happen.
   //
diff --git a/FatPkg/EnhancedFatDxe/FileName.c b/FatPkg/EnhancedFatDxe/FileName.c
index 256db309545a..d2d1fb31174c 100644
--- a/FatPkg/EnhancedFatDxe/FileName.c
+++ b/FatPkg/EnhancedFatDxe/FileName.c
@@ -128,7 +128,7 @@ FatTrimAsciiTrailingBlanks (
   @param  FatName   - The Char8 string needs to be converted.
   @param  Len   - The length of the fat name.
   @param  LowerCase - Indicate whether to convert the string to 
lower case.
-  @param  Str   - The result of the convertion.
+  @param  Str   - The result of the conversion.
 
 **/
 VOID
diff --git a/FatPkg/EnhancedFatDxe/FileSpace.c 
b/FatPkg/EnhancedFatDxe/FileSpace.c
index 0dd66e0c53af..f57e44e3680a 100644
--- a/FatPkg/EnhancedFatDxe/FileSpace.c
+++ b/FatPkg/EnhancedFatDxe/FileSpace.c
@@ -223,7 +223,7 @@ FatSetFatEntry (
 
 /**
 
-  Free the cluster clain.
+  Free the cluster chain.
 
   @param  Volume- FAT file system volume.
   @param  Cluster   - The first cluster of cluster chain.
@@ -575,8 +575,8 @@ FatOFilePosition (
   ASSERT_VOLUME_LOCKED (Volume);
 
   //
-  // If this is the fixed root dir, then compute it's position
-  // from it's fixed info in the fat bpb
+  // If this is the fixed root dir, then compute its position
+  // from its fixed info in the fat bpb
   //
   if (OFile->IsFixedRootDir) {
 OFile->PosDisk  = Volume->RootPos + Position;
diff --git