Re: [edk2-devel] [RFC PATCH 4/4] BaseTools/PatchCheck.py: Check the committer email address
On 2020-01-02 07:25:53, Philippe Mathieu-Daude wrote:
> To avoid patches committed with incorrect email address,
> use the EmailAddressCheck class on the committer email too.
>
> Cc: Liming Gao
> Cc: Jordan Justen
> Signed-off-by: Philippe Mathieu-Daude
> ---
> RFC because I haven't checked --pretty="%cn <%ce>" works on Windows shell.
>
> BaseTools/Scripts/PatchCheck.py | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index f0e661bfd6e3..3baeb3de7ba2 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -560,6 +560,8 @@ class CheckGitCommits:
> else:
> blank_line = True
> print('Checking git commit:', commit)
> +email = self.read_committer_email_address_from_git(commit)
> +self.ok &= EmailAddressCheck(email, 'Committer').ok
> patch = self.read_patch_from_git(commit)
> self.ok &= CheckOnePatch(commit, patch).ok
> if not commits:
> @@ -578,6 +580,10 @@ class CheckGitCommits:
> # Run git to get the commit patch
> return self.run_git('show', '--pretty=email', '--no-textconv',
> commit)
>
> +def read_committer_email_address_from_git(self, commit):
> +# Run git to get the committer email
> +return self.run_git('show', '--pretty="%cn <%ce>"', '--no-patch',
> commit)
I think '--pretty=%cn <%ce>' ought to work without double-quotes
because the argument is separately sent via the subprocess.Popen call.
I'm not certain it will work, but it ought to. :)
-Jordan
> +
> def run_git(self, *args):
> cmd = [ 'git' ]
> cmd += args
> --
> 2.21.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52845): https://edk2.groups.io/g/devel/message/52845
Mute This Topic: https://groups.io/mt/69381399/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v5 0/6] Microcode related optimizations
Hello Hao,
On 01/02/20 16:07, Laszlo Ersek wrote:
> On 01/02/20 04:12, Wu, Hao A wrote:
>> Ray and Eric, thanks a lot for the review.
>>
>> Hello Laszlo,
>> It seems that you are out of office, I plan to push the series without your
>> comments first. If you have feedbacks/comments with regard to the series, I
>> will follow up for the potential refine/revert of the series.
>
> Just returned today. I'm now working to regain control of my mailbox.
>
> The above procedure works fine for me; in fact I would have suggested it
> myself. In case I encounter a regression with OVMF, I'll report it.
I've now run some regression tests [*], with OVMF built at commit
b948a496150f ("UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN
buffer", 2020-01-02). At that stage, the tree contains your present
patch series too (which ends at commit fd30b0070773).
[*] Including, but a bit more than,
.
Basically my usual Linux guest tests.
I haven't noticed any regressions.
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52844): https://edk2.groups.io/g/devel/message/52844
Mute This Topic: https://groups.io/mt/69341881/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] Interpretation of specification
Hi Paulo, I finally got to looking into this and I was able to replicate your experiment. I created the payloads with your scripts and tried to write the "file_name" one with my firmware code and I get the error. So the problem may be not with the TestPkg.c but the way payloads are generated. I'll try to dig deeper and compare with my code that works OK, and figure it out if you want. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52843): https://edk2.groups.io/g/devel/message/52843 Mute This Topic: https://groups.io/mt/36573446/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow issue.
On 01/03/20 18:20, Laszlo Ersek wrote:
> On 01/03/20 18:06, Laszlo Ersek wrote:
>> Hello Eric,
>>
>> On 12/24/19 03:33, Ni, Ray wrote:
>>> Eric,
>>> I am curious how the SMM CPU driver ran well with the buffer overflow issue?
>>> Can you please explain the details?
>>
>> You don't seem to have answered Ray's question above.
>>
>> Accordingly, Ray doesn't appear to have posted a Reviewed-by or Acked-by
>> specifically for this patch (i.e., for [PATCH v3 2/2]). Ray only
>> approved [PATCH v3 1/2].
>>
>> However, in the git history, I see the present patch being committed as
>> 123b720eeb37. The commit message there claims "Reviewed-by: Ray Ni
>> " -- but that is invalid; Ray never reviewed this
>> particular patch (as far as I can see on the list).
>>
>> Ray: if you agree with this patch, please provide your R-b now.
>> Otherwise, we should revert commit 123b720eeb37.
>>
>> Regarding the code itself, please see below:
>>
-Original Message-
From: Dong, Eric
Sent: Monday, December 23, 2019 4:11 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek
Subject: [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow
issue.
The size for the array of mSmmMpSyncData->CpuData[] is 0 ~
mMaxNumberOfCpus -1. But current code may use
mSmmMpSyncData->CpuData[mMaxNumberOfCpus].
This patch fixed this issue.
Reviewed-by: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
index 35951cc43e..4808045f71 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
@@ -137,7 +137,7 @@ ReleaseAllAPs (
{
UINTN Index;
- for (Index = mMaxNumberOfCpus; Index-- > 0;) {
+ for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
>>
>> While the proposed change is indeed better style, I don't understand how
>> the pre-patch code leads to an access to:
>>
>> mSmmMpSyncData->CpuData[mMaxNumberOfCpus]
>>
>> The controlling expression of the "for" instruction is evaluated every
>> time *before* the loop body is executed. That includes the very first
>> time. So when we're about to enter the loop for the very first time,
>> we'll have done:
>>
>> Index = mMaxNumberOfCpus;
>> Index--;
>>
>> This means that the first access will be to
>>
>> mSmmMpSyncData->CpuData[mMaxNumberOfCpus - 1]
>>
>> That seems to imply that the patch is not needed, functionally speaking.
>>
>> I suggest reverting this patch; both because of the invalid review-by
>> claim, and also because the commit message is wrong. The patch might be
>> justified as a style improvement, but not as a bugfix. (Even the style
>> improvement aspect could be questioned, if the decrementing order
>> carries value, functionally or even just semantically.)
>
> I'm sorry, I missed that [PATCH v3 2/2] contained Ray's R-b at the time
> of posting already -- Ray gave his R-b for the patch originally under
> the v2 posting; that is, for [PATCH v2 2/2]:
>
> https://edk2.groups.io/g/devel/message/52498
> 734D49CCEBEEF84792F5B80ED585239D5C3A8DD9@SHSMSX104.ccr.corp.intel.com">http://mid.mail-archive.com/734D49CCEBEEF84792F5B80ED585239D5C3A8DD9@SHSMSX104.ccr.corp.intel.com
>
> However, I still feel it was wrong that Eric ignored (or missed) Ray's
> question about the behavior of the code, under [PATCH v3 2/2]. That
> question should have blocked the pushing of the patch, any prior R-b
> tags notwithstanding. Investigating Ray's question more closely could
> have lead to the realization that the patch was actually a no-op, and
> that consequently the commit message was wrong. (The patch is not a bugfix.)
>
> I agree that the patch shouldn't break anything (as long as the
> post-loop value of "Index" is irrelevant, and the order of processing is
> also indifferent).
>
> Ray, what's your preference:
>
> - should we revert this patch, and then re-apply it with a fixed commit
> message (saying "stylistic fix"),
> - should we simply revert the patch (because it's unnecessary),
> - should we stick with the current commit (and keep the known-wrong
> commit message)?
>
> Personally, I'd choose option#2 (revert only), but I defer to you.
The commit message also missed mentioning the following TianoCore
bugzilla ticket:
https://bugzilla.tianocore.org/show_bug.cgi?id=2434
(BTW, I'm confused by
https://bugzilla.tianocore.org/show_bug.cgi?id=2434#c1
which says "Confirmed this is a real issue" -- there are no hints at a
reproducer, or symptoms, or a test environment etc.)
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52842): https://edk2.groups.io/g/devel/message/52842
[edk2-devel] [PATCH v1 1/1] MdePkg: Do not use CreateEventEx unless required
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2446
There are many firmwares in the wild not supporting CreateEventEx,
including devices less than 5 years old.
Signed-off-by: Vitaly Cheptsov
---
MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c | 3 +--
MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c | 5 ++---
MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c | 5 ++---
MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c| 5 ++---
MdePkg/Library/UefiDebugLibDebugPortProtocol/DebugLibConstructor.c | 5 ++---
MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c| 5 ++---
MdePkg/Library/UefiRuntimeLib/RuntimeLib.c | 10
--
7 files changed, 15 insertions(+), 23 deletions(-)
diff --git a/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c
b/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c
index 862c6bff09..cc79843b1c 100644
--- a/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c
+++ b/MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c
@@ -77,9 +77,8 @@ DxeRuntimeDebugLibSerialPortConstructor (
return Status;
}
- return SystemTable->BootServices->CreateEventEx (EVT_NOTIFY_SIGNAL,
+ return SystemTable->BootServices->CreateEvent (EVT_SIGNAL_EXIT_BOOT_SERVICES,
TPL_NOTIFY, ExitBootServicesEvent, NULL,
- ,
);
}
diff --git a/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
b/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
index 6e784763be..7e5852e641 100644
--- a/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
+++ b/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
@@ -124,12 +124,11 @@ DxeRuntimePciExpressLibConstructor (
//
// Register SetVirtualAddressMap () notify function
//
- Status = gBS->CreateEventEx (
- EVT_NOTIFY_SIGNAL,
+ Status = gBS->CreateEvent (
+ EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE,
TPL_NOTIFY,
DxeRuntimePciExpressLibVirtualNotify,
NULL,
- ,
);
ASSERT_EFI_ERROR (Status);
diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c
b/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c
index 2f503ecffe..b0dbdec0cf 100644
--- a/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c
+++ b/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c
@@ -109,12 +109,11 @@ DxeRuntimePciSegmentLibConstructor (
//
// Register SetVirtualAddressMap () notify function
//
- Status = gBS->CreateEventEx (
- EVT_NOTIFY_SIGNAL,
+ Status = gBS->CreateEvent (
+ EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE,
TPL_NOTIFY,
DxeRuntimePciSegmentLibVirtualNotify,
NULL,
- ,
);
ASSERT_EFI_ERROR (Status);
diff --git a/MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c
b/MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c
index ed73f92818..b4ac17cf55 100644
--- a/MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c
+++ b/MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c
@@ -64,12 +64,11 @@ DxeDebugLibConstructor(
{
mDebugST = SystemTable;
- SystemTable->BootServices->CreateEventEx (
-EVT_NOTIFY_SIGNAL,
+ SystemTable->BootServices->CreateEvent (
+EVT_SIGNAL_EXIT_BOOT_SERVICES,
TPL_NOTIFY,
ExitBootServicesCallback,
NULL,
-,
);
diff --git a/MdePkg/Library/UefiDebugLibDebugPortProtocol/DebugLibConstructor.c
b/MdePkg/Library/UefiDebugLibDebugPortProtocol/DebugLibConstructor.c
index 6ea0912f2b..96fc1c422f 100644
--- a/MdePkg/Library/UefiDebugLibDebugPortProtocol/DebugLibConstructor.c
+++ b/MdePkg/Library/UefiDebugLibDebugPortProtocol/DebugLibConstructor.c
@@ -64,12 +64,11 @@ DxeDebugLibConstructor(
{
mDebugBS = SystemTable->BootServices;
- mDebugBS->CreateEventEx (
- EVT_NOTIFY_SIGNAL,
+ mDebugBS->CreateEvent (
+ EVT_SIGNAL_EXIT_BOOT_SERVICES,
TPL_NOTIFY,
ExitBootServicesCallback,
NULL,
- ,
);
diff --git a/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
b/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
index ed73f92818..b4ac17cf55 100644
--- a/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
+++ b/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
@@ -64,12 +64,11 @@ DxeDebugLibConstructor(
{
mDebugST = SystemTable;
-
[edk2-devel] [PATCH v1 0/1] MdePkg: Do not use CreateEventEx unless required
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2446 Vitaly Cheptsov (1): MdePkg: Do not use CreateEventEx unless required MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c | 3 +-- MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c | 5 ++--- MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c | 5 ++--- MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c| 5 ++--- MdePkg/Library/UefiDebugLibDebugPortProtocol/DebugLibConstructor.c | 5 ++--- MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c| 5 ++--- MdePkg/Library/UefiRuntimeLib/RuntimeLib.c | 10 -- 7 files changed, 15 insertions(+), 23 deletions(-) -- 2.21.0 (Apple Git-122.2) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52840): https://edk2.groups.io/g/devel/message/52840 Mute This Topic: https://groups.io/mt/69403120/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=- signature.asc Description: OpenPGP digital signature
[edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Requesting for merge in edk2-stable202002. Changes since V1: - Enable assertions by default to preserve the original behaviour - Fix bugzilla reference link - Update documentation in BaseLib.h Vitaly Cheptsov (1): MdePkg: Add PCD to disable safe string constraint assertions MdePkg/MdePkg.dec | 6 ++ MdePkg/Library/BaseLib/BaseLib.inf | 11 +-- MdePkg/Include/Library/BaseLib.h| 74 +--- MdePkg/Library/BaseLib/SafeString.c | 4 +- MdePkg/MdePkg.uni | 6 ++ 5 files changed, 71 insertions(+), 30 deletions(-) -- 2.21.0 (Apple Git-122.2) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52837): https://edk2.groups.io/g/devel/message/52837 Mute This Topic: https://groups.io/mt/69401948/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=- signature.asc Description: OpenPGP digital signature
[edk2-devel] [PATCH v3 1/1] MdePkg: Add PCD to disable safe string constraint assertions
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Runtime data checks are not meant to cause debug assertions unless explicitly needed by some debug code (thus the PCD) as this breaks debug builds validating data with BaseLib. Signed-off-by: Vitaly Cheptsov --- MdePkg/MdePkg.dec | 6 ++ MdePkg/Library/BaseLib/BaseLib.inf | 11 +-- MdePkg/Include/Library/BaseLib.h| 74 +--- MdePkg/Library/BaseLib/SafeString.c | 4 +- MdePkg/MdePkg.uni | 6 ++ 5 files changed, 71 insertions(+), 30 deletions(-) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index d022cc5e3e..0191b7a08b 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -2221,6 +2221,12 @@ [PcdsFixedAtBuild,PcdsPatchableInModule] # @Prompt Memory Address of GuidedExtractHandler Table. gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x100|UINT64|0x30001015 + ## Indicates if safe string constraint violation should assert. + # TRUE - Safe string constraint violation causes assertion. + # FALSE - Safe string constraint violation does not cause assertion. + # @Prompt Enable safe string constraint violation assertions. + gEfiMdePkgTokenSpaceGuid.PcdAssertOnSafeStringConstraints|TRUE|BOOLEAN|0x002e + [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## This value is used to set the base address of PCI express hierarchy. # @Prompt PCI Express Base Address. diff --git a/MdePkg/Library/BaseLib/BaseLib.inf b/MdePkg/Library/BaseLib/BaseLib.inf index 3586beb0ab..bc98bc6134 100644 --- a/MdePkg/Library/BaseLib/BaseLib.inf +++ b/MdePkg/Library/BaseLib/BaseLib.inf @@ -390,11 +390,12 @@ [LibraryClasses] BaseMemoryLib [Pcd] - gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength ## SOMETIMES_CONSUMES - gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength ## SOMETIMES_CONSUMES - gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ## SOMETIMES_CONSUMES - gEfiMdePkgTokenSpaceGuid.PcdControlFlowEnforcementPropertyMask ## SOMETIMES_CONSUMES - gEfiMdePkgTokenSpaceGuid.PcdSpeculationBarrierType ## SOMETIMES_CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdAssertOnSafeStringConstraints ## SOMETIMES_CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength ## SOMETIMES_CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength## SOMETIMES_CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ## SOMETIMES_CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdControlFlowEnforcementPropertyMask ## SOMETIMES_CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdSpeculationBarrierType ## SOMETIMES_CONSUMES [FeaturePcd] gEfiMdePkgTokenSpaceGuid.PcdVerifyNodeInList ## CONSUMES diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/BaseLib.h index 2a75bc023f..c413ca5f57 100644 --- a/MdePkg/Include/Library/BaseLib.h +++ b/MdePkg/Include/Library/BaseLib.h @@ -189,6 +189,8 @@ StrnSizeS ( If Destination is not aligned on a 16-bit boundary, then ASSERT(). If Source is not aligned on a 16-bit boundary, then ASSERT(). + + Unless PcdAssertOnSafeStringConstraints is set to FALSE: If an error would be returned, then the function will also ASSERT(). If an error is returned, then the Destination is unmodified. @@ -225,6 +227,8 @@ StrCpyS ( If Length > 0 and Destination is not aligned on a 16-bit boundary, then ASSERT(). If Length > 0 and Source is not aligned on a 16-bit boundary, then ASSERT(). + + Unless PcdAssertOnSafeStringConstraints is set to FALSE: If an error would be returned, then the function will also ASSERT(). If an error is returned, then the Destination is unmodified. @@ -263,6 +267,8 @@ StrnCpyS ( If Destination is not aligned on a 16-bit boundary, then ASSERT(). If Source is not aligned on a 16-bit boundary, then ASSERT(). + + Unless PcdAssertOnSafeStringConstraints is set to FALSE: If an error would be returned, then the function will also ASSERT(). If an error is returned, then the Destination is unmodified. @@ -303,6 +309,8 @@ StrCatS ( If Destination is not aligned on a 16-bit boundary, then ASSERT(). If Source is not aligned on a 16-bit boundary, then ASSERT(). + + Unless PcdAssertOnSafeStringConstraints is set to FALSE: If an error would be returned, then the function will also ASSERT(). If an error is returned, then the Destination is unmodified. @@ -350,9 +358,11 @@ StrnCatS ( be ignored. Then, the function stops at the first character that is a not a valid decimal character or a Null-terminator, whichever one comes first. + If String is not aligned in a 16-bit boundary, then ASSERT(). + + Unless PcdAssertOnSafeStringConstraints is set to FALSE: If String is NULL, then ASSERT(). If Data is NULL, then ASSERT(). - If String is not aligned in a 16-bit boundary, then ASSERT(). If PcdMaximumUnicodeStringLength is not zero, and String contains
Re: [edk2-devel] [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow issue.
Hello Eric,
On 12/24/19 03:33, Ni, Ray wrote:
> Eric,
> I am curious how the SMM CPU driver ran well with the buffer overflow issue?
> Can you please explain the details?
You don't seem to have answered Ray's question above.
Accordingly, Ray doesn't appear to have posted a Reviewed-by or Acked-by
specifically for this patch (i.e., for [PATCH v3 2/2]). Ray only
approved [PATCH v3 1/2].
However, in the git history, I see the present patch being committed as
123b720eeb37. The commit message there claims "Reviewed-by: Ray Ni
" -- but that is invalid; Ray never reviewed this
particular patch (as far as I can see on the list).
Ray: if you agree with this patch, please provide your R-b now.
Otherwise, we should revert commit 123b720eeb37.
Regarding the code itself, please see below:
>> -Original Message-
>> From: Dong, Eric
>> Sent: Monday, December 23, 2019 4:11 PM
>> To: devel@edk2.groups.io
>> Cc: Ni, Ray ; Laszlo Ersek
>> Subject: [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow
>> issue.
>>
>> The size for the array of mSmmMpSyncData->CpuData[] is 0 ~
>> mMaxNumberOfCpus -1. But current code may use
>> mSmmMpSyncData->CpuData[mMaxNumberOfCpus].
>>
>> This patch fixed this issue.
>>
>> Reviewed-by: Ray Ni
>> Cc: Laszlo Ersek
>> Signed-off-by: Eric Dong
>> ---
>> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
>> b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
>> index 35951cc43e..4808045f71 100644
>> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
>> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
>> @@ -137,7 +137,7 @@ ReleaseAllAPs (
>> {
>>
>>UINTN Index;
>>
>>
>>
>> - for (Index = mMaxNumberOfCpus; Index-- > 0;) {
>>
>> + for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
While the proposed change is indeed better style, I don't understand how
the pre-patch code leads to an access to:
mSmmMpSyncData->CpuData[mMaxNumberOfCpus]
The controlling expression of the "for" instruction is evaluated every
time *before* the loop body is executed. That includes the very first
time. So when we're about to enter the loop for the very first time,
we'll have done:
Index = mMaxNumberOfCpus;
Index--;
This means that the first access will be to
mSmmMpSyncData->CpuData[mMaxNumberOfCpus - 1]
That seems to imply that the patch is not needed, functionally speaking.
I suggest reverting this patch; both because of the invalid review-by
claim, and also because the commit message is wrong. The patch might be
justified as a style improvement, but not as a bugfix. (Even the style
improvement aspect could be questioned, if the decrementing order
carries value, functionally or even just semantically.)
... A more general note on *decrementing* loops in C:
The best form, in my opinion, is:
Index = mMaxNumberOfCpus;
while (Index > 0) {
--Index;
//
// Do stuff with "Index".
//
}
This has two advantages over
for (Index = mMaxNumberOfCpus; Index-- > 0;) {
//
// Do stuff with "Index".
//
}
namely:
- the "while" loop is easier to read,
- the "while" loop will finish with "Index" holding value 0, and not
value ((TypeOfIndex)-1). (The decrement step is conditional on the
controlling expression.)
Thanks
Laszlo
>>
>> if (IsPresentAp (Index)) {
>>
>>ReleaseSemaphore (mSmmMpSyncData->CpuData[Index].Run);
>>
>> }
>>
>> @@ -170,7 +170,7 @@ AllCpusInSmmWithExceptions (
>>
>>
>>CpuData = mSmmMpSyncData->CpuData;
>>
>>ProcessorInfo = gSmmCpuPrivate->ProcessorInfo;
>>
>> - for (Index = mMaxNumberOfCpus; Index-- > 0;) {
>>
>> + for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
>>
>> if (!(*(CpuData[Index].Present)) && ProcessorInfo[Index].ProcessorId !=
>> INVALID_APIC_ID) {
>>
>>if (((Exceptions & ARRIVAL_EXCEPTION_DELAYED) != 0) &&
>> SmmCpuFeaturesGetSmmRegister (Index, SmmRegSmmDelayed) != 0) {
>>
>> continue;
>>
>> @@ -305,7 +305,7 @@ SmmWaitForApArrival (
>> //
>>
>> // Send SMI IPIs to bring outside processors in
>>
>> //
>>
>> -for (Index = mMaxNumberOfCpus; Index-- > 0;) {
>>
>> +for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
>>
>>if (!(*(mSmmMpSyncData->CpuData[Index].Present)) &&
>> gSmmCpuPrivate->ProcessorInfo[Index].ProcessorId != INVALID_APIC_ID) {
>>
>> SendSmiIpi ((UINT32)gSmmCpuPrivate-
>>> ProcessorInfo[Index].ProcessorId);
>>
>>}
>>
>> @@ -361,7 +361,7 @@ WaitForAllAPsNotBusy (
>> {
>>
>>UINTN Index;
>>
>>
>>
>> - for (Index = mMaxNumberOfCpus; Index-- > 0;) {
>>
>> + for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
>>
>> //
>>
>> // Ignore BSP and APs which not call in SMM.
>>
>> //
>>
>> @@ -617,7 +617,7 @@ BSPHandler (
>> //
>>
>> while (TRUE) {
>>
>>PresentCount = 0;
>>
>> - for (Index = mMaxNumberOfCpus; Index--
[edk2-devel] [PATCH 3/3] MdeModulePkg/UsbMouseAbsolutePointer: Fix endpoint selection
The endpoint selected by the driver needs to not
only be an interrupt type, but have direction IN
as required to set up an asynchronous interrupt transfer.
Currently, the driver assumes that the first INT endpoint
will be of type IN, but that is not true of all devices,
and will silently fail on devices which have the OUT endpoint
before the IN. Adjust the endpoint selection loop to explictly
check for direction IN.
Signed-off-by: Matt DeVillier
---
.../Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
index 8953e7031c..9cd0e4cd53 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
@@ -203,7 +203,7 @@ USBMouseAbsolutePointerDriverBindingStart (
EndpointNumber =
UsbMouseAbsolutePointerDevice->InterfaceDescriptor.NumEndpoints;
//
- // Traverse endpoints to find interrupt endpoint
+ // Traverse endpoints to find interrupt endpoint IN
//
Found = FALSE;
for (Index = 0; Index < EndpointNumber; Index++) {
@@ -213,7 +213,8 @@ USBMouseAbsolutePointerDriverBindingStart (
);
-if ((EndpointDescriptor.Attributes & (BIT0 | BIT1)) ==
USB_ENDPOINT_INTERRUPT) {
+if (((EndpointDescriptor.Attributes & (BIT0 | BIT1)) ==
USB_ENDPOINT_INTERRUPT) &&
+((EndpointDescriptor.EndpointAddress & USB_ENDPOINT_DIR_IN) != 0)) {
//
// We only care interrupt endpoint here
//
--
2.20.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52835): https://edk2.groups.io/g/devel/message/52835
Mute This Topic: https://groups.io/mt/69401333/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 06/13] OvmfPkg/Tcg2PhysicalPresenceLib: Use pcd for user response wait time
Hello Zhichao,
On 01/03/20 04:04, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
>
> Use the pcd PcdPhysicalPresenceUserConfirmTimeout to control the
> wait time of user response.
>
> Cc: Jiewen Yao
> Cc: Jian J Wang
> Cc: Chao Zhang
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Marc-André Lureau
> Cc: Stefan Berger
> Signed-off-by: Zhichao Gao
> ---
> .../DxeTcg2PhysicalPresenceLib.c | 63 ++-
> .../DxeTcg2PhysicalPresenceLib.inf| 6 +-
> 2 files changed, 52 insertions(+), 17 deletions(-)
>
> diff --git
> a/OvmfPkg/Library/Tcg2PhysicalPresenceLibQemu/DxeTcg2PhysicalPresenceLib.c
> b/OvmfPkg/Library/Tcg2PhysicalPresenceLibQemu/DxeTcg2PhysicalPresenceLib.c
> index 00d76ba2c2..13f78cbfac 100644
> --- a/OvmfPkg/Library/Tcg2PhysicalPresenceLibQemu/DxeTcg2PhysicalPresenceLib.c
> +++ b/OvmfPkg/Library/Tcg2PhysicalPresenceLibQemu/DxeTcg2PhysicalPresenceLib.c
> @@ -9,7 +9,7 @@
>
> Copyright (C) 2018, Red Hat, Inc.
> Copyright (c) 2018, IBM Corporation. All rights reserved.
> -Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2013 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -32,6 +32,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include
> #include
> #include
> +#include
> +#include
>
> #include
>
> @@ -365,28 +367,57 @@ Tcg2ReadUserKey (
> {
>EFI_STATUSStatus;
>EFI_INPUT_KEY Key;
> - UINT16InputKey;
> + UINT16ConfirmKey;
> + UINTN Interval;
> + INT64 Timeout;
>
> - InputKey = 0;
> + //
> + // delay 100 milli-second
> + //
> + Interval= 100;
> + ConfirmKey = (CautionKey) ? SCAN_F12 : SCAN_F10;
> + Timeout = (INT64)PcdGet32 (PcdPhysicalPresenceUserConfirmTimeout);
> + if (Timeout > 0) {
> +Timeout = (INT64)MultU64x32 ((UINT64)Timeout, 1000);
> + } else {
> +//
> +// Wait forever
> +//
> +Timeout = MAX_INT64;
> + }
> +
> + //
> + // Wait for user response within the time-out
> + //
>do {
> +MicroSecondDelay (Interval * 1000);
> +
> Status = gBS->CheckEvent (gST->ConIn->WaitForKey);
> if (!EFI_ERROR (Status)) {
>Status = gST->ConIn->ReadKeyStroke (gST->ConIn, );
> - if (Key.ScanCode == SCAN_ESC) {
> -InputKey = Key.ScanCode;
> - }
> - if ((Key.ScanCode == SCAN_F10) && !CautionKey) {
> -InputKey = Key.ScanCode;
> - }
> - if ((Key.ScanCode == SCAN_F12) && CautionKey) {
> -InputKey = Key.ScanCode;
> + if (!EFI_ERROR (Status)) {
> +if (Key.ScanCode == ConfirmKey) {
> + //
> + // User Confirmation
> + //
> + return TRUE;
> +}
> +
> +if (Key.ScanCode == SCAN_ESC) {
> + //
> + // User Rejection
> + //
> + return FALSE;
> +}
> + } else if (Status == EFI_DEVICE_ERROR) {
> +//
> +// If error, assume User Rejection
> +//
> +return FALSE;
>}
> }
> - } while (InputKey == 0);
> -
> - if (InputKey != SCAN_ESC) {
> -return TRUE;
> - }
> +Timeout -= Interval;
> + } while (Timeout > 0);
>
>return FALSE;
> }
(1) I don't understand why the original (pre-patch) code uses
CheckEvent() in a busy loop. WaitForEvent() looks like a better (more
resource-conservative) option.
Does the original code use CheckEvent() because WaitForEvent() is
restricted to TPL_APPLICATION?
I don't think that being restricted to TPL_APPLICATION should be a
problem. As far as I can tell, the only call path to Tcg2ReadUserKey() is:
Tcg2PhysicalPresenceLibProcessRequest()
Tcg2ExecutePendingTpmRequest()
Tcg2UserConfirm()
Tcg2ReadUserKey()
In turn, Tcg2PhysicalPresenceLibProcessRequest() is supposed to be
called from PlatformBootManagerLib, which in turn is called from BdsDxe.
Therefore I think we can safely assume TPL_APPLICATION.
I think we should add a separate patch first, for rewriting the present
logic of Tcg2ReadUserKey() with WaitForEvent() -- remove the busy loop.
(2) Once we use WaitForEvent(), it is easier and more elegant to use a
timer event, in addition to "gST->ConIn->WaitForKey", to limit the
waiting for a keypress.
For example, the BdsWaitForSingleEvent() function in
"MdeModulePkg/Universal/BdsDxe/BdsEntry.c" is used for implementing a
timed wait for a hotkey, if I understand correctly.
(3) I think that the Tcg2ReadUserKey() function should take the timeout
parameter, and the PCD should be consumed in the Tcg2UserConfirm()
function instead. Tcg2UserConfirm() should pass the value of the PCD to
Tcg2ReadUserKey().
The PCD is called "PcdPhysicalPresenceUserConfirmTimeout", therefore it
seems more closely tied to the Tcg2UserConfirm()
Re: [edk2-devel] [PATCH v3 00/32] .mailmap: Add mailmap file to have a cleaner git history
Hi Laszlo, On 1/3/20 2:48 PM, Laszlo Ersek wrote: On 01/02/20 20:23, Philippe Mathieu-Daude wrote: The .mailmap git feature helps fixing commit mistakes (in name/email). The easiest way to use it is with the --use-mailmap flag: $ git log --use-mailmap See documentation [1] and [2], and interesting blog [3]. Laszlo replied [4] to v1 explaining stewards want to avoid avoid cross-domain mapping, and suggested to split in per email-address patches, so contributors can individually Ack/Nack. This v3 collects the patches of the 30 developers who replied to the v2 [5] with their R-b tag. OK. So am I correct to think that this sub-series is ready for merging? There is an exception with patch Hmmm... unfinished thought. :) Apparently, there is a patch that prevents the series from being merged? Which one? This comment was about patch 13/32, but Jiewen Yao already reviewed it, so this series is fully reviewed by each developer. I dropped the unreviewed patches and am cc'ing this series to the Tianocore stewards, as suggested by Laszlo in [6]. Each developer will still be Cc'ed in case a modification was requested, he/her can verify. Ah, OK, so this is *not* the final version (for round 1, per [6]), just yet. Can you please monitor the remaining feedback for this series? If everyone is happy with the v3 updates, and you determine that the patch set is fully reviewed, I can help pick up the new tags, and merge the series. Since the change is a one-line, I'd prefer avoid respining the whole series. IMHO the series is ready for step #4 "stewards go through the backlog, and decide one by one whether, for person X, the proposed mappings are cross-domain or not, and ACK or NACK" which I don't really get. I suppose this will be resolved in the open on the mailing list, so individuals will get notified their patch got refused. Thank for offering to pick and merge this series! Phil. This series is available at: https://gitlab.com/philmd/edk2/commits/mailmap-v3 Regards, Phil. [1] https://git-scm.com/docs/git-shortlog#_mapping_authors [2] https://git-scm.com/docs/git-check-mailmap#_mapping_authors [3] https://github.com/sympy/sympy/wiki/Using-.mailmap#making-mailmap-entries [4] https://edk2.groups.io/g/devel/message/51657 [5] https://edk2.groups.io/g/devel/message/51834 [6] https://edk2.groups.io/g/devel/message/51906 [...] -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52833): https://edk2.groups.io/g/devel/message/52833 Mute This Topic: https://groups.io/mt/69385958/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 24/32] .mailmap: Add an entry for Philippe Mathieu-Daudé
On 01/02/20 20:23, Philippe Mathieu-Daude wrote: > We use .mailmap to display contributors email addresses in an > uniform format. > > Add an entry for Philippe Mathieu-Daudé to have his/her name and > email address displayed properly in the git history. > > Signed-off-by: Philippe Mathieu-Daude > --- > .mailmap | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.mailmap b/.mailmap > index 2960aabaa1cc..9082d9912acf 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -51,3 +51,4 @@ Michael Kubacki > Michael Kubacki (FYDIBOHF25SPDLT)/cn=Recipients/cn=3c8b0226e75f4ab08d20c151cb7a8a72> > Ming Tan > Nikolai Saoukh > +Philippe Mathieu-Daudé > Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52832): https://edk2.groups.io/g/devel/message/52832 Mute This Topic: https://groups.io/mt/69386005/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 00/32] .mailmap: Add mailmap file to have a cleaner git history
On 01/02/20 20:23, Philippe Mathieu-Daude wrote: > The .mailmap git feature helps fixing commit mistakes (in name/email). > > The easiest way to use it is with the --use-mailmap flag: > > $ git log --use-mailmap > > See documentation [1] and [2], and interesting blog [3]. > > Laszlo replied [4] to v1 explaining stewards want to avoid avoid > cross-domain mapping, and suggested to split in per email-address > patches, so contributors can individually Ack/Nack. > > This v3 collects the patches of the 30 developers who replied to > the v2 [5] with their R-b tag. OK. So am I correct to think that this sub-series is ready for merging? > There is an exception with patch Hmmm... unfinished thought. :) Apparently, there is a patch that prevents the series from being merged? Which one? > I dropped the unreviewed patches and am cc'ing this series to the > Tianocore stewards, as suggested by Laszlo in [6]. Each developer > will still be Cc'ed in case a modification was requested, he/her > can verify. Ah, OK, so this is *not* the final version (for round 1, per [6]), just yet. Can you please monitor the remaining feedback for this series? If everyone is happy with the v3 updates, and you determine that the patch set is fully reviewed, I can help pick up the new tags, and merge the series. Thanks! Laszlo > > This series is available at: > https://gitlab.com/philmd/edk2/commits/mailmap-v3 > > Regards, > > Phil. > > [1] https://git-scm.com/docs/git-shortlog#_mapping_authors > [2] https://git-scm.com/docs/git-check-mailmap#_mapping_authors > [3] https://github.com/sympy/sympy/wiki/Using-.mailmap#making-mailmap-entries > [4] https://edk2.groups.io/g/devel/message/51657 > [5] https://edk2.groups.io/g/devel/message/51834 > [6] https://edk2.groups.io/g/devel/message/51906 > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > > Philippe Mathieu-Daudé (32): > .mailmap: Add a stub with documentation > .mailmap: Add an entry for Aaron Li > .mailmap: Add an entry for Antoine Cœur > .mailmap: Add an entry for Ard Biesheuvel > .mailmap: Add an entry for Ashley DeSimone > .mailmap: Add an entry for Baraneedharan Anbazhagan > .mailmap: Add an entry for Chasel Chiu > .mailmap: Add an entry for Christopher J Zurcher > .mailmap: Add an entry for Eric Dong > .mailmap: Add an entry for Erik Bjorge > .mailmap: Add an entry for Hao Wu > .mailmap: Add an entry for Hot Tian > .mailmap: Add an entry for Jiewen Yao > .mailmap: Add an entry for Jim Dailey > .mailmap: Add an entry for Laszlo Ersek > .mailmap: Add an entry for Liming Gao > .mailmap: Add an entry for Maciej Rabeda > .mailmap: Add an entry for Marc-André Lureau > .mailmap: Add an entry for Marvin Häuser > .mailmap: Add an entry for Maurice Ma > .mailmap: Add an entry for Michael Kubacki > .mailmap: Add an entry for Ming Tan > .mailmap: Add an entry for Nikolai Saoukh > .mailmap: Add an entry for Philippe Mathieu-Daudé > .mailmap: Add an entry for Ray Ni > .mailmap: Add an entry for Samer El-Haj-Mahmoud > .mailmap: Add an entry for Shenglei Zhang > .mailmap: Add an entry for Star Zeng > .mailmap: Add an entry for Vitaly Cheptsov > .mailmap: Add an entry for Vladimir Olovyannikov > .mailmap: Add an entry for Yonghong Zhu > .mailmap: Add an entry for Yu-Chen Lin > > .mailmap | 72 > 1 file changed, 72 insertions(+) > create mode 100644 .mailmap > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52831): https://edk2.groups.io/g/devel/message/52831 Mute This Topic: https://groups.io/mt/69385958/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 60/78] OvmfPkg/Xen: Fix various typos
On 01/03/20 10:07, Philippe Mathieu-Daudé wrote: > From: Antoine Coeur > > Fix various typos in comments and documentation. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h | 2 +- > OvmfPkg/Include/IndustryStandard/Xen/grant_table.h| 4 ++-- > OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h | 2 +- > OvmfPkg/Include/Protocol/XenBus.h | 4 ++-- > OvmfPkg/Include/Protocol/XenIo.h | 2 +- > OvmfPkg/XenBusDxe/DriverBinding.h | 2 +- > OvmfPkg/XenBusDxe/EventChannel.h | 2 +- > OvmfPkg/XenBusDxe/GrantTable.h| 2 +- > OvmfPkg/XenPvBlkDxe/BlockIo.h | 6 +++--- > OvmfPkg/XenPvBlkDxe/DriverBinding.h | 2 +- > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 4 ++-- > .../XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 6 +++--- > OvmfPkg/XenBusDxe/XenBus.c| 2 +- > OvmfPkg/XenBusDxe/XenBusDxe.c | 6 +++--- > OvmfPkg/XenBusDxe/XenStore.c | 4 ++-- > OvmfPkg/XenPvBlkDxe/BlockFront.c | 2 +- > OvmfPkg/XenPvBlkDxe/BlockIo.c | 8 > OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c | 2 +- > 18 files changed, 31 insertions(+), 31 deletions(-) So the S-o-b issue pointed out by Anthony for v1 of this patch appears to have been fixed. So, again, once Anthony is happy with this patch, I'll ACK too. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52830): https://edk2.groups.io/g/devel/message/52830 Mute This Topic: https://groups.io/mt/69395959/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 56/78] OvmfPkg/Csm/LegacyBios: Fix a typo
On 01/03/20 10:07, Philippe Mathieu-Daudé wrote: > Fix a typo in the header documentation. > > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/Csm/Include/Protocol/LegacyBios.h > b/OvmfPkg/Csm/Include/Protocol/LegacyBios.h > index cd585a8d58f3..cb320b601733 100644 > --- a/OvmfPkg/Csm/Include/Protocol/LegacyBios.h > +++ b/OvmfPkg/Csm/Include/Protocol/LegacyBios.h > @@ -1,7 +1,7 @@ > /** @file >The EFI Legacy BIOS Protocol is used to abstract legacy Option ROM usage >under EFI and Legacy OS boot. This file also includes all the related > - COMPATIBILIY16 structures and definitions. > + COMPATIBILITY16 structures and definitions. > >Note: The names for EFI_IA32_REGISTER_SET elements were picked to follow >well known naming conventions. > Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52829): https://edk2.groups.io/g/devel/message/52829 Mute This Topic: https://groups.io/mt/69395955/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 55/78] OvmfPkg/Csm: Fix various typos
On 01/03/20 10:07, Philippe Mathieu-Daudé wrote: > From: Antoine Coeur > > Fix various typos in documentation, comments and strings. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Reviewed-by: David Woodhouse > Signed-off-by: Philippe Mathieu-Daude > --- > v2: 'bios' -> 'BIOS' (David Woodhouse) > --- > .../LegacyBootMaintUiLib.inf | 2 +- > OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 +- > .../BiosThunk/VideoDxe/VesaBiosExtensions.h| 8 > OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +- > .../FrameworkInternalFormRepresentation.h | 2 +- > OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +- > OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +++--- > .../Csm/Include/Protocol/LegacyBiosPlatform.h | 4 ++-- > OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +- > .../Csm/LegacyBiosDxe/LegacyBiosInterface.h| 8 > .../LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 ++-- > .../LegacyBootMaintUiVfr.h | 2 +- > OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 ++-- > OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +++--- > OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +++--- > OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 ++-- > OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 > OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 ++-- > .../LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++--- > OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c| 18 +- > .../LegacyBootMaintUiLib.uni | 8 > 21 files changed, 62 insertions(+), 62 deletions(-) Based on David's R-b: Acked-by: Laszlo Ersek Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52828): https://edk2.groups.io/g/devel/message/52828 Mute This Topic: https://groups.io/mt/69395954/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 57/78] OvmfPkg/Qemu: Fix various typos
On 01/03/20 10:07, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix various typos in comments and documentation. > > When "VbeShim.asm" is modified, we have to re-run "VbeShim.sh" > to update "VbeShim.h". > The string modified by this patch is only used when the DEBUG > macro (at the top of the file) is commented out. Since the > string is not referenced, NASM eliminates it, resulting in > the same byte array content in "VbeShim.h". > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Reviewed-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daude > --- > v2: Comment VbeShim.h is not modified in description (Laszlo) > --- Thanks! Once the full set is sufficiently reviewed, please ping me, I'm glad to help with a PR. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52827): https://edk2.groups.io/g/devel/message/52827 Mute This Topic: https://groups.io/mt/69395956/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master
On 01/02/20 15:42, Philippe Mathieu-Daudé wrote:
> 1/ Is it possible to have the Mergify bot use the merge request author
> name/email as GIT_COMMITTER_[NAME/EMAIL] instead of throwing away this
> information from the git history?
I noticed that too, but I thought that having a robot rather than a
human in the committer meta-datum was tolerable. (Not great, but
acceptable.)
The authorship meta-datum is still correct, to my understanding. If
there's a problem later with a commit, I'd probably email the author (CC
list), not the committer.
> 2/ Can the Mergify bot send a mail to the list to notify a patch got
> merged?
>
> For example going thru my backlog I was going to review this series:
> https://edk2.groups.io/g/devel/message/52613
> But it is already merged... The series subject is "Microcode related
> optimizations" and when I searched for it first with the GitHub MR
> filter from 1/, I couldn't find it. Later I figured it got merged with
> another subject "Mpinitlib opt push 1".
>
> One way to simplify Mergify to send email, is to ask maintainers to put
> the series cover (or each patches) URL in the GitHub merge request
> description, or the email Message ID(s). Since we are switching the a
> mostly HTTP workflow, using URLs is probably recommended.
Including the cover letter contents and/or mailing list reference in the
PR description is already recommended practice, to my understanding. The
related tianocore BZ should be noted in the PR description too. AIUI,
it's also recommended to name the PR in accordance with the series cover
letter's subject line. Unfortunately, maintainers don't seem to be
following these recommendations.
Regarding an email notification about a merge, I have two comments:
- Personally, I always follow up with a manual message to the list, once
a series is merged, pointing out the new commit range. It's not a huge
burden.
- Github generates emails about PR actions. Unfortunately, the current
scheme for a merge ("Merged #263 into master") is really lacking. It
cannot be easily filtered for (you have to check the message body to see
it's a "merge"), plus the resultant commit range (-> master branch
advance) is not communicated. I don't know if this would be best
remedied in the general github.com website code, or in the mergify bot code.
No tooling will ever provide enough information for the community so
long as maintainers are unwilling to spend time on administrative
actions. The attraction of github.com for the grand public is not that
github.com implements these administrative actions itself, un-burdening
developers; instead, the attraction is that github.com pretends these
actions are not important at all, and so nobody should care about them.
You can't really make a tool care if maintainers don't care.
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52826): https://edk2.groups.io/g/devel/message/52826
Mute This Topic: https://groups.io/mt/53725670/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses
Hi, On 01/02/20 16:25, Philippe Mathieu-Daude wrote: > Last month I cleaned the git-history incorrect email > addresses: https://edk2.groups.io/g/devel/message/51834 > but today I noticed more incorrect addresses got committed > (see caa917491a4..33a3293651). > To avoid having the same cleanup in the future, fix the > problem once for all by having PatchCheck doing this > automatically (on merge). > > Since we already have code to check email address in > PatchCheck, factor the code out to reuse it, and > add checks for committer/author addresses. > > Cc: Liming Gao > Cc: Jordan Justen > > Philippe Mathieu-Daude (4): > BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck > BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked > BaseTools/PatchCheck.py: Check the patch author email address > BaseTools/PatchCheck.py: Check the committer email address > > BaseTools/Scripts/PatchCheck.py | 99 +++-- > 1 file changed, 69 insertions(+), 30 deletions(-) > still struggling with my email backlog, so I'm going to skip this for now. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52825): https://edk2.groups.io/g/devel/message/52825 Mute This Topic: https://groups.io/mt/69381374/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/7] New implementation of MM communicate for standalone MM
On Fri, 6 Dec 2019 at 16:29, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > This series implements the changes proposed by Mantis ticket 1993, which > describes how we need to modify the MM communicate protocol to make it > compatible with standalone MM based DXE_RUNTIME_DRIVER MM client using > virtually remapped memory. > > These changes have been accepted as errata for PI spec v1.7 > > Cc: Michael D Kinney > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Hao A Wu > Cc: Eric Dong > Cc: Ray Ni > Cc: Achin Gupta > Cc: Jiewen Yao > Ping? > Ard Biesheuvel (7): > MdePkg: introduce MM communicate 2 protocol > MdeModulePkg/SmmIpl: expose MM communicate 2 protocol > ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol > MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol > MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2 > protocol > MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2 > protocol > StandaloneMmPkg: switch to MM communicate 2 protocol > > .../MmCommunicationDxe/MmCommunication.c | 79 +-- > .../MmCommunicationDxe/MmCommunication.inf| 6 +- > .../Application/VariableInfo/VariableInfo.c | 19 +++-- > .../Application/VariableInfo/VariableInfo.inf | 2 +- > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c| 79 +++ > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 1 + > MdeModulePkg/Include/Guid/SmmVariableCommon.h | 6 +- > .../FaultTolerantWriteSmmCommon.h | 2 +- > .../FaultTolerantWriteSmmDxe.c| 25 +++--- > .../FaultTolerantWriteSmmDxe.h| 2 +- > .../FaultTolerantWriteSmmDxe.inf | 4 +- > .../RuntimeDxe/VariableSmmRuntimeDxe.c| 39 - > .../RuntimeDxe/VariableSmmRuntimeDxe.inf | 4 +- > MdePkg/Include/Protocol/MmCommunication2.h| 69 > MdePkg/MdePkg.dec | 7 ++ > StandaloneMmPkg/Core/StandaloneMmCore.h | 2 +- > .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h | 2 +- > 17 files changed, 254 insertions(+), 94 deletions(-) > create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h > > -- > 2.17.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52824): https://edk2.groups.io/g/devel/message/52824 Mute This Topic: https://groups.io/mt/67497114/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 75/78] StandaloneMmPkg: Fix few typos
Reviewed-by: jiewen@intel.com > -Original Message- > From: Philippe Mathieu-Daude > Sent: Friday, January 3, 2020 5:08 PM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Achin Gupta ; Yao, > Jiewen ; Supreeth Venkatesh > ; Philippe Mathieu-Daude > > Subject: [PATCH v2 75/78] StandaloneMmPkg: Fix few typos > > From: Antoine Coeur > > Fix few typos in comments. > > Cc: Achin Gupta > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Reviewed-by: jiewen@intel.com > Signed-off-by: Philippe Mathieu-Daude > --- > .../StandaloneMmPeCoffExtraActionLib.inf| 2 +- > StandaloneMmPkg/Core/Dependency.c | 2 +- > StandaloneMmPkg/Core/FwVol.c| 2 +- > StandaloneMmPkg/Core/StandaloneMmCore.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git > a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM > mPeCoffExtraActionLib.inf > b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM > mPeCoffExtraActionLib.inf > index e972ba3bc7b8..89083df679a1 100644 > --- > a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM > mPeCoffExtraActionLib.inf > +++ > b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM > mPeCoffExtraActionLib.inf > @@ -1,5 +1,5 @@ > #/** @file > -# PeCoff extra action libary for DXE phase that run Unix emulator. > +# PeCoff extra action library for DXE phase that run Unix emulator. > # > # Lib to provide memory journal status code reporting Routines > # Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved. > diff --git a/StandaloneMmPkg/Core/Dependency.c > b/StandaloneMmPkg/Core/Dependency.c > index 7c6e76748b2b..e0f2d3518369 100644 > --- a/StandaloneMmPkg/Core/Dependency.c > +++ b/StandaloneMmPkg/Core/Dependency.c > @@ -372,7 +372,7 @@ MmIsSchedulable ( > // The math is done out of order, but it should not matter. That is > // we may add in the sizeof (EFI_GUID) before we account for the OP Code. > // This is not an issue, since we just need the correct end result. You > -// need to be careful using Iterator in the loop as it's intermediate > value > +// need to be careful using Iterator in the loop as its intermediate > value > // may be strange. > // > Iterator++; > diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c > index 314329ea065a..856d86011d31 100644 > --- a/StandaloneMmPkg/Core/FwVol.c > +++ b/StandaloneMmPkg/Core/FwVol.c > @@ -50,7 +50,7 @@ MmCoreFfsFindMmDriver ( > > Routine Description: >Given the pointer to the Firmware Volume Header find the > - MM driver and return it's PE32 image. > + MM driver and return its PE32 image. > > Arguments: >FwVolHeader - Pointer to memory mapped FV > diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c > b/StandaloneMmPkg/Core/StandaloneMmCore.c > index c52164683de8..ac3e2c0b1b93 100644 > --- a/StandaloneMmPkg/Core/StandaloneMmCore.c > +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c > @@ -354,7 +354,7 @@ MmEntryPoint ( >//PlatformHookBeforeMmDispatch (); > >// > - // If a legacy boot has occured, then make sure gMmCorePrivate is not > accessed > + // If a legacy boot has occurred, then make sure gMmCorePrivate is not > accessed >// > >// > -- > 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52823): https://edk2.groups.io/g/devel/message/52823 Mute This Topic: https://groups.io/mt/69396194/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 70/78] SignedCapsulePkg/Universal: Fix various typos
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Philippe Mathieu-Daude
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Yao, Jiewen ;
> Zhang, Chao B ; Philippe Mathieu-Daude
>
> Subject: [PATCH v2 70/78] SignedCapsulePkg/Universal: Fix various typos
>
> From: Antoine Coeur
>
> Fix various typos in documentation, comments and debug strings.
>
> Cc: Jiewen Yao
> Cc: Chao Zhang
> Signed-off-by: Antoine Coeur
> Reviewed-by: Philippe Mathieu-Daude
> Signed-off-by: Philippe Mathieu-Daude
> ---
> .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 2 +-
> .../RecoveryModuleLoadPei/ParseConfigProfile.c | 2 +-
> .../RecoveryModuleLoadPei/RecoveryModuleLoadPei.c | 14 +++---
> .../SystemFirmwareUpdate/ParseConfigProfile.c | 2 +-
> .../SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 4 ++--
> .../SystemFirmwareUpdate/SystemFirmwareReportDxe.c | 8
> .../SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 4 ++--
> 7 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> index f7166e337ad7..d3cc89e5f106 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> @@ -113,7 +113,7 @@ typedef struct {
>
> #define ABORT_REASON_MAX_SIZE 0x40 // UnicodeStringSize
> including
> final L'\0'
>
> -#define CAPSULE_IMAGE_ADDITIONAL_MAX_SIZE (0x20020 + 0xA) //
> Addtional size for Capsule Header, FV block alignment + DispatchImage.
> +#define CAPSULE_IMAGE_ADDITIONAL_MAX_SIZE (0x20020 + 0xA) //
> Additional size for Capsule Header, FV block alignment + DispatchImage.
>
> typedef struct {
>UINT8 ImageIndex;
> diff --git
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
> index ee9787a2bf53..5cd690ddeb76 100644
> ---
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
> +++
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
> @@ -103,7 +103,7 @@ ParseRecoveryDataFile (
> //
>
> //
> -// FileBuid
> +// FileGuid
> //
> Status = GetGuidFromDataFile(
> Context,
> diff --git
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.c
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.c
> index eda3cc542068..53b821c2bb26 100644
> ---
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.c
> +++
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.c
> @@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include
> #include
> //
> -// The protocols, PPI and GUID defintions for this module
> +// The protocols, PPI and GUID definitions for this module
> //
> #include
> #include
> @@ -144,7 +144,7 @@ IsFmpCapsuleGuid (
> }
>
> /**
> - This function assumes the input Capusule image already passes basic check
> in
> + This function assumes the input Capsule image already passes basic check in
>ValidateFmpCapsule().
>
>Criteria of system FMP capsule is:
> @@ -235,7 +235,7 @@ IsValidCapsuleHeader (
>@param[out] IsSystemFmp If it is a system FMP.
>@param[out] EmbeddedDriverCount The EmbeddedDriverCount in the FMP
> capsule.
>
> - @retval EFI_SUCESS Input capsule is a correct FMP capsule.
> + @retval EFI_SUCCESSInput capsule is a correct FMP capsule.
>@retval EFI_INVALID_PARAMETER Input capsule is not a correct FMP capsule.
> **/
> EFI_STATUS
> @@ -398,7 +398,7 @@ InitializeRecoveryModule (
>@param[in] FvImage Points to the DXE FV image.
>@param[in] FvImageSize The length of the DXE FV image in bytes.
>
> - @retval EFI_SUCESSCreate hob and install FvInfo PPI
> successfully.
> + @retval EFI_SUCCESS Create hob and install FvInfo PPI
> successfully.
>@retval EFI_VOLUME_CORRUPTED The input data is not an FV.
>@retval EFI_OUT_OF_RESOURCES No enough resource to process the input
> data.
> **/
> @@ -479,7 +479,7 @@ CreateHobForRecoveryCapsule (
>@param[in] ConfigImage Points to the config file image.
>@param[in] ConfigImageSize The length of the config file image in
> bytes.
>
> - @retval EFI_SUCESS Process Recovery Image successfully.
> + @retval EFI_SUCCESSProcess Recovery Image successfully.
> **/
> EFI_STATUS
> RecoverImage (
> @@ -554,7 +554,7 @@ RecoverImage (
>@param[in] Image Points to the recovery image.
>@param[in] LengthThe length of the recovery image in bytes.
>
> - @retval EFI_SUCESS Process Recovery Image
Re: [edk2-devel] [PATCH v2 74/78] StandaloneMmPkg: Fix a typo
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Philippe
> Mathieu-Daudé
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Philippe Mathieu-Daude ; Achin Gupta
> ; Yao, Jiewen ; Supreeth
> Venkatesh
> Subject: [edk2-devel] [PATCH v2 74/78] StandaloneMmPkg: Fix a typo
>
> Fix a typo in a comment.
>
> Cc: Achin Gupta
> Cc: Jiewen Yao
> Cc: Supreeth Venkatesh
> Reviewed-by: jiewen@intel.com
> Signed-off-by: Philippe Mathieu-Daude
> ---
> StandaloneMmPkg/Core/Dispatcher.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/StandaloneMmPkg/Core/Dispatcher.c
> b/StandaloneMmPkg/Core/Dispatcher.c
> index fe10e65c4bf0..2f795d01dc1f 100644
> --- a/StandaloneMmPkg/Core/Dispatcher.c
> +++ b/StandaloneMmPkg/Core/Dispatcher.c
> @@ -431,7 +431,7 @@ MmLoadImage (
> //
> // Copy the PDB file name to our temporary string, and replace .pdb with
> .efi
> // The PDB file name is limited in the range of 0~255.
> -// If the length is bigger than 255, trim the redudant characters to
> avoid
> overflow in array boundary.
> +// If the length is bigger than 255, trim the redundant characters to
> avoid
> overflow in array boundary.
> //
> for (Index = 0; Index < sizeof (EfiFileName) - 4; Index++) {
>EfiFileName[Index] = ImageContext.PdbPointer[Index + StartIndex];
> --
> 2.21.0
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52822): https://edk2.groups.io/g/devel/message/52822
Mute This Topic: https://groups.io/mt/69396192/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the EdkiiSdMmcSwitchClockFreq notification before sending CMD13
Hi, wt., 24 gru 2019 o 03:52 Wu, Hao A napisał(a): > > > -Original Message- > > From: Albecki, Mateusz > > Sent: Saturday, December 21, 2019 1:13 AM > > To: devel@edk2.groups.io > > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > > Subject: [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the > > EdkiiSdMmcSwitchClockFreq notification before sending CMD13 > > > > The first patch refactors the SdMmcClockSupply function with a goal > > of sending the EdkiiSdMmcSwitchClockFreq notification before we send the > > CMD13 to check the switch status in eMMC init flow. This is required to > > avoid sending the CMD13 on link that still has not been fixed by platform. > > > > To avoid changing the driver behavior we avoid sending notifications > > when the clock is setup for the first time or when we setup the clock > > after the voltage switch procedure(adressed in second patch). > > > > The second patch in the series optimizes the SD card detection routine > > to stop it from going through the process of internal clock setup > > after switching the voltage. According to SD HC specification there > > is no need to setup internal clock all over again. > > > > Tests performed: > > - Booted eMMC in HS400 mode on platform which required post clock freq > > fixes > > > > I wasn't able to test SD card yet due to the lack of setup with working SD. > > > I performed a quick verification on the eMMC device and SD card on my side. > They work properly after the series. > > So for the series, > Tested-by: Hao A Wu > I verified eMMC HS200 / HS@50MHz and SD cards on 2 Armada platforms, so: Tested-by: Marcin Wojtas Best regards, Marcin > > > > > The patch series is available on github here: > > https://github.com/malbecki/edk2/tree/sdmmc_post_freq_notify > > > Add Ard to the loop to see if there is additional comment. > > Best Regards, > Hao Wu > > > > > > Cc: Hao A Wu > > Cc: Marcin Wojtas > > Cc: Zhichao Gao > > Cc: Liming Gao > > > > Mateusz Albecki (2): > > SdMmcPciHcDxe: Send EdkiiSdMmcSwitchClockFreq after SD clock start > > MdeModulePkg/SdMmcPciHcDxe: Add function to start SD clock > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c| 20 +-- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 25 +--- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 24 > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 136 > > +++-- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 45 ++- > > 5 files changed, 112 insertions(+), 138 deletions(-) > > > > -- > > 2.14.1.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52820): https://edk2.groups.io/g/devel/message/52820 Mute This Topic: https://groups.io/mt/68852773/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 00/78] Fix a bunch of typos (part 1)
Le 03/01/2020 à 17:06, Philippe Mathieu-Daude a écrit : Around February of this year, Antoine posted various patches fixing a huge quantity of typos, over 8000+ lines (such [1]). It was year 2019, and the changes were mostly a rebase from year 2018. ^_^ Thank you for the huge salvage. Antoine -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52819): https://edk2.groups.io/g/devel/message/52819 Mute This Topic: https://groups.io/mt/69395700/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 77/78] UefiCpuPkg/PiSmm: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Laszlo Ersek Reviewed-by: Eric Dong Signed-off-by: Philippe Mathieu-Daude --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++-- .../PiSmmCommunication/PiSmmCommunicationPei.c | 2 +- .../PiSmmCommunication/PiSmmCommunicationSmm.c | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 ++-- UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 4 ++-- UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 6 +++--- UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c| 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +- 9 files changed, 18 insertions(+), 18 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h index 33b3dd140ea7..fe7e8b0323b8 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -284,7 +284,7 @@ extern UINT8 mSmmSaveStateRegisterLma; @retval EFI_SUCCESS The register was read from Save State @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. **/ EFI_STATUS @@ -308,7 +308,7 @@ SmmReadSaveState ( @retval EFI_SUCCESS The register was written from Save State @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct **/ EFI_STATUS @@ -336,7 +336,7 @@ This function supports reading a CPU Save State register in SMBase relocation ha @retval EFI_SUCCESS The register was read from Save State. @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. -@retval EFI_INVALID_PARAMTER This or Buffer is NULL. +@retval EFI_INVALID_PARAMETER This or Buffer is NULL. **/ EFI_STATUS @@ -363,7 +363,7 @@ This function supports writing a CPU Save State register in SMBase relocation ha @retval EFI_SUCCESS The register was written to Save State. @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. -@retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct. +@retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct. **/ EFI_STATUS @@ -1263,7 +1263,7 @@ EdkiiSmmGetMemoryAttributes ( /** This function fixes up the address of the global variable or function - referred in SmmInit assembly files to be the absoute address. + referred in SmmInit assembly files to be the absolute address. **/ VOID EFIAPI @@ -1272,7 +1272,7 @@ PiSmmCpuSmmInitFixupAddress ( /** This function fixes up the address of the global variable or function - referred in SmiEntry assembly files to be the absoute address. + referred in SmiEntry assembly files to be the absolute address. **/ VOID EFIAPI diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c index 5d09130e5591..68e5003ad4c2 100644 --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c @@ -366,7 +366,7 @@ Communicate ( @param FileHandle Handle of the file being invoked. @param PeiServices Pointer to PEI Services table. - @retval EFI_SUCEESS + @retval EFI_SUCCESS @return Others Some error occurs. **/ EFI_STATUS diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c index 6be12d6c14cd..30f7d57bdd91 100644 --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c @@ -155,7 +155,7 @@ AllocateAcpiNvsMemoryBelow4G ( @param[in] ImageHandle Image handle of this driver. @param[in] SystemTable A Pointer to the EFI System Table. - @retval EFI_SUCEESS + @retval EFI_SUCCESS @return Others Some error occurs. **/ EFI_STATUS diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c index 723fd5042ff4..db68e1316ec5 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c @@ -215,7 +215,7 @@ DumpModuleInfoByIp ( @retval EFI_SUCCESS The register was read from Save State @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. **/ EFI_STATUS @@ -287,7 +287,7 @@ SmmReadSaveState ( @retval
[edk2-devel] [PATCH v2 78/78] UefiCpuPkg/Smm: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Laszlo Ersek
Reviewed-by: Eric Dong
Signed-off-by: Philippe Mathieu-Daude
---
UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h| 4 ++--
UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h | 4 ++--
.../Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c| 4 ++--
UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c | 2 +-
UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 4 ++--
UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 4 ++--
UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm| 2 +-
7 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
index 39ca304b31e6..dbcd57e0ad42 100644
--- a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
+++ b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
@@ -338,7 +338,7 @@ SmmCpuFeaturesSetSmmRegister (
from the save state.
@retval EFI_SUCCESS The register was read from Save State.
- @retval EFI_INVALID_PARAMTER Buffer is NULL.
+ @retval EFI_INVALID_PARAMETER Buffer is NULL.
@retval EFI_UNSUPPORTED This function does not support reading
Register.
**/
@@ -364,7 +364,7 @@ SmmCpuFeaturesReadSaveStateRegister (
@param[in] BufferUpon entry, this holds the new CPU register value.
@retval EFI_SUCCESS The register was written to Save State.
- @retval EFI_INVALID_PARAMTER Buffer is NULL.
+ @retval EFI_INVALID_PARAMETER Buffer is NULL.
@retval EFI_UNSUPPORTED This function does not support writing
Register.
**/
EFI_STATUS
diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
index 018e918360d3..da551cc4a6a6 100644
--- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
+++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
@@ -138,7 +138,7 @@ GetPiResource (
);
/**
- This functin initialize STM configuration table.
+ This function initialize STM configuration table.
**/
VOID
StmSmmConfigurationTableInit (
@@ -169,7 +169,7 @@ GetStmResource (
/**
This function fixes up the address of the global variable or function
- referred in SmiEntry assembly files to be the absoute address.
+ referred in SmiEntry assembly files to be the absolute address.
**/
VOID
EFIAPI
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
index 72c2aeca4c13..6a2670d55918 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
@@ -68,7 +68,7 @@ CommonExceptionHandlerWorker (
//
ArchRestoreExceptionContext (ExceptionType, SystemContext,
ExceptionHandlerData);
//
-// Rlease spin lock for ApicId
+// Release spin lock for ApicId
//
ReleaseSpinLock ([ExceptionType].SpinLock);
break;
@@ -230,7 +230,7 @@ InitializeCpuExceptionHandlersWorker (
IdtEntryCount = (IdtDescriptor.Limit + 1) / sizeof
(IA32_IDT_GATE_DESCRIPTOR);
if (IdtEntryCount > CPU_EXCEPTION_NUM) {
//
-// CPU exeption library only setup CPU_EXCEPTION_NUM exception handler at
most
+// CPU exception library only setup CPU_EXCEPTION_NUM exception handler at
most
//
IdtEntryCount = CPU_EXCEPTION_NUM;
}
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
index ec705fc489af..e7977d49b771 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
@@ -1,5 +1,5 @@
/** @file
- CPU exception handler library implemenation for SMM modules.
+ CPU exception handler library implementation for SMM modules.
Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
index bddb7a219ce4..a00786a8ebef 100644
--- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
@@ -540,7 +540,7 @@ SmmCpuFeaturesSetSmmRegister (
from the save state.
@retval EFI_SUCCESS The register was read from Save State.
- @retval EFI_INVALID_PARAMTER Buffer is NULL.
+ @retval EFI_INVALID_PARAMETER Buffer is NULL.
@retval EFI_UNSUPPORTED This function does not support reading
Register.
**/
@@ -569,7 +569,7 @@ SmmCpuFeaturesReadSaveStateRegister (
@param[in] BufferUpon entry, this holds the new CPU
[edk2-devel] [PATCH v2 76/78] UefiCpuPkg/CpuDxe: Fix few typos
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Laszlo Ersek
Reviewed-by: Eric Dong
Signed-off-by: Philippe Mathieu-Daude
---
UefiCpuPkg/CpuDxe/CpuDxe.h | 2 +-
UefiCpuPkg/CpuDxe/CpuGdt.h | 2 +-
UefiCpuPkg/CpuDxe/CpuMp.h| 4 ++--
UefiCpuPkg/CpuDxe/CpuPageTable.h | 2 +-
UefiCpuPkg/CpuDxe/CpuDxe.c | 8
UefiCpuPkg/CpuDxe/CpuGdt.c | 2 +-
UefiCpuPkg/CpuDxe/CpuMp.c| 4 ++--
UefiCpuPkg/CpuDxe/CpuPageTable.c | 6 +++---
8 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h
index a6762f1a0b78..9299eaa63d8a 100644
--- a/UefiCpuPkg/CpuDxe/CpuDxe.h
+++ b/UefiCpuPkg/CpuDxe/CpuDxe.h
@@ -208,7 +208,7 @@ CpuGetTimerValue (
);
/**
- Set memory cacheability attributes for given range of memeory.
+ Set memory cacheability attributes for given range of memory.
@param This Protocol instance structure
@param BaseAddressSpecifies the start address of the
diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.h b/UefiCpuPkg/CpuDxe/CpuGdt.h
index e5c36f37b96a..3a0210b2f172 100644
--- a/UefiCpuPkg/CpuDxe/CpuGdt.h
+++ b/UefiCpuPkg/CpuDxe/CpuGdt.h
@@ -1,5 +1,5 @@
/** @file
- C based implemention of IA32 interrupt handling only
+ C based implementation of IA32 interrupt handling only
requiring a minimal assembly interrupt entry point.
Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
diff --git a/UefiCpuPkg/CpuDxe/CpuMp.h b/UefiCpuPkg/CpuDxe/CpuMp.h
index e7e115fc8f3d..4ee171d8c491 100644
--- a/UefiCpuPkg/CpuDxe/CpuMp.h
+++ b/UefiCpuPkg/CpuDxe/CpuMp.h
@@ -147,7 +147,7 @@ GetProcessorInfo (
and releases the BSP to continue with other tasks.
-# The caller can use the CheckEvent() and WaitForEvent() services to check
the state of the WaitEvent created in step 1.
--# When the APs complete their task or TimeoutInMicroSecondss expires, the
MP
+-# When the APs complete their task or TimeoutInMicroSeconds expires, the
MP
Service signals WaitEvent by calling the EFI SignalEvent() function. If
FailedCpuList is not NULL, its content is available when WaitEvent is
signaled. If all APs returned from Procedure prior to the timeout, then
@@ -254,7 +254,7 @@ StartupAllAPs (
This function is used to dispatch one enabled AP to the function specified by
Procedure passing in the argument specified by ProcedureArgument. If
WaitEvent
is NULL, execution is in blocking mode. The BSP waits until the AP finishes
or
- TimeoutInMicroSecondss expires. Otherwise, execution is in non-blocking mode.
+ TimeoutInMicroSeconds expires. Otherwise, execution is in non-blocking mode.
BSP proceeds to the next task without waiting for the AP. If a non-blocking
mode
is requested after the UEFI Event EFI_EVENT_GROUP_READY_TO_BOOT is signaled,
then EFI_UNSUPPORTED must be returned.
diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.h b/UefiCpuPkg/CpuDxe/CpuPageTable.h
index bad6784bcb51..0b2a02a2be5c 100644
--- a/UefiCpuPkg/CpuDxe/CpuPageTable.h
+++ b/UefiCpuPkg/CpuDxe/CpuPageTable.h
@@ -78,7 +78,7 @@ VOID *
Caller should make sure BaseAddress and Length is at page boundary.
- Caller need guarentee the TPL <= TPL_NOTIFY, if there is split page request.
+ Caller need guarantee the TPL <= TPL_NOTIFY, if there is split page request.
@param PagingContext The paging context. NULL means get page table from
current CPU context.
@param BaseAddress The physical address that is the start address of
a memory region.
diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
index 7d7270e10b4a..a571fc3b1750 100644
--- a/UefiCpuPkg/CpuDxe/CpuDxe.c
+++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
@@ -393,7 +393,7 @@ CpuSetMemoryAttributes (
//
// If this function is called because GCD SetMemorySpaceAttributes () is
called
- // by RefreshGcdMemoryAttributes (), then we are just synchronzing GCD memory
+ // by RefreshGcdMemoryAttributes (), then we are just synchronizing GCD
memory
// map with MTRR values. So there is no need to modify MTRRs, just return
immediately
// to avoid unnecessary computing.
//
@@ -456,7 +456,7 @@ CpuSetMemoryAttributes (
CurrentCacheType = MtrrGetMemoryAttribute(BaseAddress);
if (CurrentCacheType != CacheType) {
//
- // call MTRR libary function
+ // call MTRR library function
//
Status = MtrrSetMemoryAttribute (
BaseAddress,
@@ -831,7 +831,7 @@ RefreshMemoryAttributesFromMtrr (
Attributes = CurrentAttributes;
} else {
//
-// If fixed MTRR attribute changed, then set memory attribute for
previous atrribute
+// If fixed MTRR attribute changed, then set memory attribute for
previous attribute
//
if
[edk2-devel] [PATCH v2 72/78] SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Hao A Wu Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Hao A Wu Signed-off-by: Philippe Mathieu-Daude --- .../DebugCommunicationLibSerialPort.inf | 2 +- SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h | 2 +- .../DebugCommunicationLibUsb3Internal.h | 4 ++-- .../DebugCommunicationLibSerialPort.c | 2 +- .../DebugCommunicationLibUsb3Common.c | 2 +- .../DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c | 2 +- .../DebugCommunicationLibUsb3Transfer.c | 4 ++-- .../DebugCommunicationLibSerialPort.uni | 2 +- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf index 668e0bef178e..21af18cfb0b0 100644 --- a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf +++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf @@ -1,5 +1,5 @@ ## @file -# Debug Communication Library instance based on serila port. +# Debug Communication Library instance based on serial port. # # Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved. # diff --git a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h index bc7a00b537c7..73e0f19f92a9 100644 --- a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h +++ b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h @@ -30,7 +30,7 @@ VOID /** Initialize the debug port. - This function will initialize debug port to get it ready for data transmition. If + This function will initialize debug port to get it ready for data transmission. If certain Debug Communication Library instance has to save some private data in the stack, this function must work on the mode that doesn't return to the caller, then the caller needs to wrap up all rest of logic after DebugPortInitialize() into one diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h index 72ed2c74162f..df50220f33dc 100644 --- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h +++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h @@ -85,7 +85,7 @@ #define XHC_DEBUG_PORT_ON_OFF_DELAY10 // -// USB debug device string descritpor (header size + unicode string length) +// USB debug device string descriptor (header size + unicode string length) // #define STRING0_DESC_LEN 4 #define MANU_DESC_LEN 12 @@ -680,7 +680,7 @@ USB3InitializeReal ( @param Direction The direction of data transfer. @param Data Array of pointers to the buffers of data to transmit from or receive into. - @param DataLengthThe lenght of the data buffer. + @param DataLengthThe length of the data buffer. @param Timeout Indicates the maximum time, in millisecond, which the transfer is allowed to complete. diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c index 604c7e6d52ce..045026508e80 100644 --- a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c +++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c @@ -15,7 +15,7 @@ /** Initialize the debug port. - This function will initialize debug port to get it ready for data transmition. If + This function will initialize debug port to get it ready for data transmission. If certain Debug Communication Library instance has to save some private data in the stack, this function must work on the mode that doesn't return to the caller, then the caller needs to wrap up all rest of logic after DebugPortInitialize() into one diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c index 4e49a7437f8b..d76314a42ae6 100644 --- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c +++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c @@ -162,7 +162,7 @@ XhcClearDebugRegBit ( } /** -
[edk2-devel] [PATCH v2 70/78] SignedCapsulePkg/Universal: Fix various typos
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Jiewen Yao
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
.../SystemFirmwareUpdate/SystemFirmwareDxe.h | 2 +-
.../RecoveryModuleLoadPei/ParseConfigProfile.c | 2 +-
.../RecoveryModuleLoadPei/RecoveryModuleLoadPei.c | 14 +++---
.../SystemFirmwareUpdate/ParseConfigProfile.c | 2 +-
.../SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 4 ++--
.../SystemFirmwareUpdate/SystemFirmwareReportDxe.c | 8
.../SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 4 ++--
7 files changed, 18 insertions(+), 18 deletions(-)
diff --git
a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
index f7166e337ad7..d3cc89e5f106 100644
--- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
+++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
@@ -113,7 +113,7 @@ typedef struct {
#define ABORT_REASON_MAX_SIZE 0x40 // UnicodeStringSize
including final L'\0'
-#define CAPSULE_IMAGE_ADDITIONAL_MAX_SIZE (0x20020 + 0xA) // Addtional
size for Capsule Header, FV block alignment + DispatchImage.
+#define CAPSULE_IMAGE_ADDITIONAL_MAX_SIZE (0x20020 + 0xA) // Additional
size for Capsule Header, FV block alignment + DispatchImage.
typedef struct {
UINT8 ImageIndex;
diff --git
a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
index ee9787a2bf53..5cd690ddeb76 100644
--- a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
+++ b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
@@ -103,7 +103,7 @@ ParseRecoveryDataFile (
//
//
-// FileBuid
+// FileGuid
//
Status = GetGuidFromDataFile(
Context,
diff --git
a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c
b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c
index eda3cc542068..53b821c2bb26 100644
--- a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c
+++ b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c
@@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include
#include
//
-// The protocols, PPI and GUID defintions for this module
+// The protocols, PPI and GUID definitions for this module
//
#include
#include
@@ -144,7 +144,7 @@ IsFmpCapsuleGuid (
}
/**
- This function assumes the input Capusule image already passes basic check in
+ This function assumes the input Capsule image already passes basic check in
ValidateFmpCapsule().
Criteria of system FMP capsule is:
@@ -235,7 +235,7 @@ IsValidCapsuleHeader (
@param[out] IsSystemFmp If it is a system FMP.
@param[out] EmbeddedDriverCount The EmbeddedDriverCount in the FMP capsule.
- @retval EFI_SUCESS Input capsule is a correct FMP capsule.
+ @retval EFI_SUCCESSInput capsule is a correct FMP capsule.
@retval EFI_INVALID_PARAMETER Input capsule is not a correct FMP capsule.
**/
EFI_STATUS
@@ -398,7 +398,7 @@ InitializeRecoveryModule (
@param[in] FvImage Points to the DXE FV image.
@param[in] FvImageSize The length of the DXE FV image in bytes.
- @retval EFI_SUCESSCreate hob and install FvInfo PPI successfully.
+ @retval EFI_SUCCESS Create hob and install FvInfo PPI successfully.
@retval EFI_VOLUME_CORRUPTED The input data is not an FV.
@retval EFI_OUT_OF_RESOURCES No enough resource to process the input data.
**/
@@ -479,7 +479,7 @@ CreateHobForRecoveryCapsule (
@param[in] ConfigImage Points to the config file image.
@param[in] ConfigImageSize The length of the config file image in
bytes.
- @retval EFI_SUCESS Process Recovery Image successfully.
+ @retval EFI_SUCCESSProcess Recovery Image successfully.
**/
EFI_STATUS
RecoverImage (
@@ -554,7 +554,7 @@ RecoverImage (
@param[in] Image Points to the recovery image.
@param[in] LengthThe length of the recovery image in bytes.
- @retval EFI_SUCESS Process Recovery Image successfully.
+ @retval EFI_SUCCESSProcess Recovery Image successfully.
@retval EFI_SECURITY_VIOLATION Recovery image is not processed due to
security violation.
**/
EFI_STATUS
@@ -607,7 +607,7 @@ ProcessRecoveryImage (
@param[in] CapsuleHeader Points to a capsule header.
@param[in] IsSystemFmp If this capsule is a system FMP capsule.
- @retval EFI_SUCESSProcess Capsule Image successfully.
+ @retval EFI_SUCCESS Process Capsule Image successfully.
@retval EFI_UNSUPPORTED
[edk2-devel] [PATCH v2 75/78] StandaloneMmPkg: Fix few typos
From: Antoine Coeur Fix few typos in comments. Cc: Achin Gupta Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: jiewen@intel.com Signed-off-by: Philippe Mathieu-Daude --- .../StandaloneMmPeCoffExtraActionLib.inf| 2 +- StandaloneMmPkg/Core/Dependency.c | 2 +- StandaloneMmPkg/Core/FwVol.c| 2 +- StandaloneMmPkg/Core/StandaloneMmCore.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf index e972ba3bc7b8..89083df679a1 100644 --- a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf +++ b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf @@ -1,5 +1,5 @@ #/** @file -# PeCoff extra action libary for DXE phase that run Unix emulator. +# PeCoff extra action library for DXE phase that run Unix emulator. # # Lib to provide memory journal status code reporting Routines # Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved. diff --git a/StandaloneMmPkg/Core/Dependency.c b/StandaloneMmPkg/Core/Dependency.c index 7c6e76748b2b..e0f2d3518369 100644 --- a/StandaloneMmPkg/Core/Dependency.c +++ b/StandaloneMmPkg/Core/Dependency.c @@ -372,7 +372,7 @@ MmIsSchedulable ( // The math is done out of order, but it should not matter. That is // we may add in the sizeof (EFI_GUID) before we account for the OP Code. // This is not an issue, since we just need the correct end result. You -// need to be careful using Iterator in the loop as it's intermediate value +// need to be careful using Iterator in the loop as its intermediate value // may be strange. // Iterator++; diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c index 314329ea065a..856d86011d31 100644 --- a/StandaloneMmPkg/Core/FwVol.c +++ b/StandaloneMmPkg/Core/FwVol.c @@ -50,7 +50,7 @@ MmCoreFfsFindMmDriver ( Routine Description: Given the pointer to the Firmware Volume Header find the - MM driver and return it's PE32 image. + MM driver and return its PE32 image. Arguments: FwVolHeader - Pointer to memory mapped FV diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c b/StandaloneMmPkg/Core/StandaloneMmCore.c index c52164683de8..ac3e2c0b1b93 100644 --- a/StandaloneMmPkg/Core/StandaloneMmCore.c +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c @@ -354,7 +354,7 @@ MmEntryPoint ( //PlatformHookBeforeMmDispatch (); // - // If a legacy boot has occured, then make sure gMmCorePrivate is not accessed + // If a legacy boot has occurred, then make sure gMmCorePrivate is not accessed // // -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52815): https://edk2.groups.io/g/devel/message/52815 Mute This Topic: https://groups.io/mt/69396194/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 74/78] StandaloneMmPkg: Fix a typo
Fix a typo in a comment.
Cc: Achin Gupta
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Reviewed-by: jiewen@intel.com
Signed-off-by: Philippe Mathieu-Daude
---
StandaloneMmPkg/Core/Dispatcher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/StandaloneMmPkg/Core/Dispatcher.c
b/StandaloneMmPkg/Core/Dispatcher.c
index fe10e65c4bf0..2f795d01dc1f 100644
--- a/StandaloneMmPkg/Core/Dispatcher.c
+++ b/StandaloneMmPkg/Core/Dispatcher.c
@@ -431,7 +431,7 @@ MmLoadImage (
//
// Copy the PDB file name to our temporary string, and replace .pdb with
.efi
// The PDB file name is limited in the range of 0~255.
-// If the length is bigger than 255, trim the redudant characters to avoid
overflow in array boundary.
+// If the length is bigger than 255, trim the redundant characters to
avoid overflow in array boundary.
//
for (Index = 0; Index < sizeof (EfiFileName) - 4; Index++) {
EfiFileName[Index] = ImageContext.PdbPointer[Index + StartIndex];
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52813): https://edk2.groups.io/g/devel/message/52813
Mute This Topic: https://groups.io/mt/69396192/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 73/78] SourceLevelDebugPkg: Fix few typos
From: Antoine Coeur
Correctly write 'definitions' in comments and documentation.
Cc: Hao A Wu
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Hao A Wu
Signed-off-by: Philippe Mathieu-Daude
---
SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h | 2 +-
SourceLevelDebugPkg/Include/TransferProtocol.h | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
b/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
index 71f596f285bd..2c5cf03cec90 100644
--- a/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
+++ b/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
@@ -1,5 +1,5 @@
/** @file
- IA32/x64 architecture specific defintions needed by debug transfer
protocol.It is only
+ IA32/x64 architecture specific definitions needed by debug transfer
protocol.It is only
intended to be used by Debug related module implementation.
Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
diff --git a/SourceLevelDebugPkg/Include/TransferProtocol.h
b/SourceLevelDebugPkg/Include/TransferProtocol.h
index 3904ba27dcb8..154e74165e8d 100644
--- a/SourceLevelDebugPkg/Include/TransferProtocol.h
+++ b/SourceLevelDebugPkg/Include/TransferProtocol.h
@@ -1,5 +1,5 @@
/** @file
- Transfer protocol defintions used by debug agent and host. It is only
+ Transfer protocol definitions used by debug agent and host. It is only
intended to be used by Debug related module implementation.
Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
@@ -140,7 +140,7 @@ typedef struct {
UINT64 StopAddress;
} DEBUG_DATA_RESPONSE_BREAK_CAUSE;
//
-// Break type defintions for DEBUG_DATA_BREAK_CAUSE
+// Break type definitions for DEBUG_DATA_BREAK_CAUSE
//
#define DEBUG_DATA_BREAK_CAUSE_UNKNOWN0
#define DEBUG_DATA_BREAK_CAUSE_HW_BREAKPOINT 1
@@ -160,7 +160,7 @@ typedef struct {
UINT8 CpuMode;
} DEBUG_DATA_RESPONSE_ARCH_MODE;
//
-// Cpu architecture defintions for DEBUG_DATA_RESPONSE_ARCH_MODE
+// Cpu architecture definitions for DEBUG_DATA_RESPONSE_ARCH_MODE
//
#define DEBUG_DATA_BREAK_CPU_ARCH_IA160
#define DEBUG_DATA_BREAK_CPU_ARCH_IA321
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52814): https://edk2.groups.io/g/devel/message/52814
Mute This Topic: https://groups.io/mt/69396193/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 71/78] SourceLevelDebugPkg/DebugAgent: Fix various typos
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Hao A Wu
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Hao A Wu
Signed-off-by: Philippe Mathieu-Daude
---
.../DebugAgent/DebugAgentCommon/DebugMp.h | 6 +--
.../DebugAgentCommon/Ia32/ArchDebugSupport.h | 2 +-
.../DebugAgentCommon/Ia32/DebugException.h| 2 +-
.../DebugAgentCommon/X64/ArchDebugSupport.h | 2 +-
.../DebugAgentCommon/X64/DebugException.h | 2 +-
.../DebugAgentDxe/DebugAgentDxe.c | 2 +-
.../DebugAgentPei/DebugAgentPei.c | 2 +-
.../DebugAgent/DebugAgentCommon/DebugAgent.c | 52 +--
.../DxeDebugAgent/DxeDebugAgentLib.c | 2 +-
.../DebugAgent/DxeDebugAgent/SerialIo.c | 6 +--
.../SecPeiDebugAgent/SecPeiDebugAgentLib.c| 10 ++--
.../SmmDebugAgent/SmmDebugAgentLib.c | 10 ++--
.../DebugAgentCommon/Ia32/AsmFuncs.nasm | 4 +-
13 files changed, 51 insertions(+), 51 deletions(-)
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
index 71d7802d1548..07ddccad335d 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
@@ -17,7 +17,7 @@ typedef struct {
} DEBUG_CPU_DATA;
typedef struct {
- SPIN_LOCK MpContextSpinLock; ///< Lock for writting MP
context
+ SPIN_LOCK MpContextSpinLock; ///< Lock for writing MP
context
SPIN_LOCK DebugPortSpinLock; ///< Lock for access debug
port
SPIN_LOCK MailboxSpinLock; ///< Lock for accessing mail
box
UINT8 CpuBreakMask[DEBUG_CPU_MAX_COUNT/8];///<
Bitmask of all breaking CPUs
@@ -26,8 +26,8 @@ typedef struct {
UINT32BspIndex;///< Processor index value of
BSP
UINT32BreakAtCpuIndex; ///< Processor index value of
the current breaking CPU
UINT32DebugTimerInitCount; ///< Record BSP's init timer
count
- BOOLEAN IpiSentByAp; ///< TRUR: IPI is sent by AP.
TALSE: IPI is sent by BSP
- BOOLEAN RunCommandSet; ///< TRUE: RUN commmand is
executing. FALSE : RUN command has been executed.
+ BOOLEAN IpiSentByAp; ///< TRUE: IPI is sent by AP.
FALSE: IPI is sent by BSP
+ BOOLEAN RunCommandSet; ///< TRUE: RUN command is
executing. FALSE: RUN command has been executed.
} DEBUG_MP_CONTEXT;
extern DEBUG_MP_CONTEXT volatile mDebugMpContext;
diff --git
a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.h
b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.h
index d816bdaecdbe..3acb0352bf76 100644
---
a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.h
+++
b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.h
@@ -1,5 +1,5 @@
/** @file
- IA32 specific defintions for debug agent library instance.
+ IA32 specific definitions for debug agent library instance.
Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git
a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugException.h
b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugException.h
index 750b3e4724eb..9147fabe6c3e 100644
---
a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugException.h
+++
b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugException.h
@@ -1,5 +1,5 @@
/** @file
- Exception defintions.
+ Exception definitions.
Copyright (c) 2010, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git
a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.h
b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.h
index 4ee12b771e9c..1e45941a9927 100644
---
a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.h
+++
b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.h
@@ -1,5 +1,5 @@
/** @file
- X64 specific defintions for debug agent library instance.
+ X64 specific definitions for debug agent library instance.
Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git
a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugException.h
b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugException.h
index 750b3e4724eb..9147fabe6c3e 100644
---
a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugException.h
+++
Re: [edk2-devel] [PATCH v2 66/78] SecurityPkg/VariableAuthenticated: Fix few typos
Reviewed-by: jiewen@intel.com > -Original Message- > From: Philippe Mathieu-Daude > Sent: Friday, January 3, 2020 5:08 PM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Yao, Jiewen ; > Wang, Jian J ; Zhang, Chao B > ; Philippe Mathieu-Daude > Subject: [PATCH v2 66/78] SecurityPkg/VariableAuthenticated: Fix few typos > > From: Antoine Coeur > > Fix few typos in comments and documentation. > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Chao Zhang > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > .../SecureBootConfigDxe/SecureBootConfigFileExplorer.c | 2 +- > .../SecureBootConfigDxe/SecureBootConfigImpl.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigF > ileExplorer.c > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigF > ileExplorer.c > index 088d6fd5d9ba..8bea707d4e18 100644 > --- > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigF > ileExplorer.c > +++ > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigF > ileExplorer.c > @@ -81,7 +81,7 @@ CleanUpPage ( > >@param DevicePath Device path. > > - @retval NULLNot enough memory resourece for AllocateCopyPool. > + @retval NULLNot enough memory resource for AllocateCopyPool. >@retval Other A new allocated string that represents the file > name. > > **/ > diff --git > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigI > mpl.c > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigI > mpl.c > index 83497a23f52d..4f01a2ed677e 100644 > --- > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigI > mpl.c > +++ > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigI > mpl.c > @@ -4071,7 +4071,7 @@ ON_EXIT: > } > > /** > - This functino to load signature data under the signature list. > + This function to load signature data under the signature list. > >@param[in] PrivateData Module's private data. >@param[in] LabelId Label number to insert opcodes. > -- > 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52809): https://edk2.groups.io/g/devel/message/52809 Mute This Topic: https://groups.io/mt/69395965/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 69/78] SignedCapsulePkg: Fix various typos
Reviewed-by: jiewen@intel.com > -Original Message- > From: Philippe Mathieu-Daude > Sent: Friday, January 3, 2020 5:08 PM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Yao, Jiewen ; > Zhang, Chao B ; Philippe Mathieu-Daude > > Subject: [PATCH v2 69/78] SignedCapsulePkg: Fix various typos > > From: Antoine Coeur > > Fix various typos in comments and documentation. > > Cc: Jiewen Yao > Cc: Chao Zhang > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > SignedCapsulePkg/SignedCapsulePkg.dec | 4 +-- > .../Include/Guid/EdkiiSystemFmpCapsule.h | 4 +-- > .../Include/Library/IniParsingLib.h | 14 +- > .../Library/IniParsingLib/IniParsingLib.c | 26 +-- > 4 files changed, 24 insertions(+), 24 deletions(-) > > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dec > b/SignedCapsulePkg/SignedCapsulePkg.dec > index 3492de6c8b9e..04dbf62af42a 100644 > --- a/SignedCapsulePkg/SignedCapsulePkg.dec > +++ b/SignedCapsulePkg/SignedCapsulePkg.dec > @@ -53,7 +53,7 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, > PcdsDynamicEx] > [PcdsDynamicEx] >## This dynamic PCD holds the EDKII system firmware image descriptor. ># This information can be used for version check in EDKII system FMP > capsule. > - # Only if the new EdkiiSystemFrimwareImageDescriptor.Version is not less > than > + # Only if the new EdkiiSystemFirmwareImageDescriptor.Version is not less > than ># the current > PcdEdkiiSystemFirmwareImageDescriptor.LowestSupportedVersion, ># the EDKII system FmpCapsule will be processed. ># The data structure of this PCD is > EDKII_SYSTEM_FIRMWARE_IMAGE_DESCRIPTOR, > @@ -65,7 +65,7 @@ [PcdsDynamicEx] > >## This dynamic PCD hold the GUID of a firmware FFS which includes EDKII ># system firmware image. > - # An EDKII system firmware udpate module need consume this PCD to extract > + # An EDKII system firmware update module need consume this PCD to extract ># the EDKII system firmware from the capsule image. ># It must be in [PcdsDynamicEx], because the EDKII system firmware update > module may ># consume the PCD produced in current system firmware image. > diff --git a/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h > b/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h > index 1129d715ae25..8295f92a7341 100644 > --- a/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h > +++ b/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h > @@ -60,7 +60,7 @@ >ImageOffset = # Fv offset of this SystemFirmware image > (HEX) >FileGuid= ---- # > PcdEdkiiSystemFirmwareFileGuid > > - NOTE: The [Name?] entry may have differnt FileGuid. > + NOTE: The [Name?] entry may have different FileGuid. >Only the one, whose FileGuid matches PcdEdkiiSystemFirmwareFileGuid, takes > effect. >The other entry is ignored. > > @@ -80,7 +80,7 @@ >ImageOffset = # Image offset of this SystemFirmware image > (HEX) >FileGuid= ---- # > PcdEdkiiSystemFirmwareFileGuid > > - NOTE: The [Name?] entry may have differnt FileGuid. > + NOTE: The [Name?] entry may have different FileGuid. >Only the one, whose FileGuid matches PcdEdkiiSystemFirmwareFileGuid, takes > effect. >The other entry is ignored. > > diff --git a/SignedCapsulePkg/Include/Library/IniParsingLib.h > b/SignedCapsulePkg/Include/Library/IniParsingLib.h > index 26d100ffde0a..edfdde7e8d32 100644 > --- a/SignedCapsulePkg/Include/Library/IniParsingLib.h > +++ b/SignedCapsulePkg/Include/Library/IniParsingLib.h > @@ -14,7 +14,7 @@ > 3.1) an ASCII String. The valid format is [A-Za-z0-9_]+ > 3.2) a GUID. The valid format is > ----, > where x is [A-Fa-f0-9] > 3.3) a decimal value. The valid format is [0-9]+ > - 3.4) a heximal value. The valid format is 0x[A-Fa-f0-9]+ > + 3.4) a hexadecimal value. The valid format is 0x[A-Fa-f0-9]+ >4) '#' or ';' can be used as comment at anywhere. >5) TAB(0x20) or SPACE(0x9) can be used as separator. >6) LF(\n, 0xA) or CR(\r, 0xD) can be used as line break. > @@ -106,14 +106,14 @@ GetDecimalUintnFromDataFile ( >); > > /** > - Get section entry heximal UINTN value. > + Get section entry hexadecimal UINTN value. > >@param[in] Context INI Config file context. >@param[in] SectionName Section name. >@param[in] EntryName Section entry name. > - @param[out] DataPoint to the got heximal UINTN value. > + @param[out] DataPoint to the got hexadecimal UINTN value. > > - @retval EFI_SUCCESSSection entry heximal UINTN value is got. > + @retval EFI_SUCCESSSection entry hexadecimal UINTN value is got. >@retval EFI_NOT_FOUND Section is not found. > **/ > EFI_STATUS > @@ -126,14
Re: [edk2-devel] [PATCH v2 62/78] SecurityPkg: Fix few typos
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Philippe
> Mathieu-Daudé
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Yao, Jiewen ;
> Wang, Jian J ; Zhang, Chao B
> ; Philippe Mathieu-Daude
> Subject: [edk2-devel] [PATCH v2 62/78] SecurityPkg: Fix few typos
>
> From: Antoine Coeur
>
> Fix few typos in comments and documentation.
>
> Cc: Jiewen Yao
> Cc: Jian J Wang
> Cc: Chao Zhang
> Signed-off-by: Antoine Coeur
> Reviewed-by: Philippe Mathieu-Daude
> Signed-off-by: Philippe Mathieu-Daude
> ---
> .../Library/PlatformSecureLibNull/PlatformSecureLibNull.inf | 2 +-
> .../DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c | 2 +-
> .../Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 2 +-
> SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 2 +-
> .../HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c| 2 +-
> .../HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c| 2 +-
> SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c | 2 +-
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c | 2 +-
> .../Library/PlatformSecureLibNull/PlatformSecureLibNull.uni | 2 +-
> 9 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git
> a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> index 9ae597d381fc..85607aa645a1 100644
> --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> +++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> @@ -1,5 +1,5 @@
> ## @file
> -# NULL platform secure library instance that alway returns TRUE for a user
> physical present
> +# NULL platform secure library instance that always returns TRUE for a user
> physical present
> #
> # NULL PlatformSecureLib instance does NOT really detect whether a physical
> present
> # user exists but returns TRUE directly. This instance can be used to verify
> security
> diff --git
> a/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
> b/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
> index 174172d5d7a5..1a9bd4659a65 100644
> ---
> a/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
> +++
> b/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
> @@ -175,7 +175,7 @@ TpmPhysicalPresence (
>@param[in] TcgProtocol EFI TCG Protocol instance.
>@param[in] Ordinal TPM command code.
>@param[in] AdditionalParameterSize Additional parameter size.
> - @param[in] AdditionalParameters Pointer to the Additional paramaters.
> + @param[in] AdditionalParameters Pointer to the Additional parameters.
>
>@retval TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE Error occurred
> during sending command to TPM or
>receiving response from
> TPM.
> diff --git
> a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
> b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
> index 04b9b0d7fbf3..5ea2d3ba8ed1 100644
> --- a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
> +++
> b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
> @@ -471,7 +471,7 @@ DxeTpm2MeasureBootHandler (
>Status = gBS->LocateDevicePath (,
> , );
>if (!EFI_ERROR (Status) && !mTcg2MeasureGptTableFlag) {
> //
> -// Find the gpt partion on the given devicepath
> +// Find the gpt partition on the given devicepath
> //
> DevicePathNode = OrigDevicePathNode;
> ASSERT (DevicePathNode != NULL);
> diff --git
> a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
> b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
> index 1f2eed29a1df..d5aeb35eb72c 100644
> --- a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
> +++ b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
> @@ -769,7 +769,7 @@ DxeTpmMeasureBootHandler (
>Status = gBS->LocateDevicePath (,
> , );
>if (!EFI_ERROR (Status) && !mMeasureGptTableFlag) {
> //
> -// Find the gpt partion on the given devicepath
> +// Find the gpt partition on the given devicepath
> //
> DevicePathNode = OrigDevicePathNode;
> ASSERT (DevicePathNode != NULL);
> diff --git
> a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.
> c
> b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.
> c
> index a7cb05849c00..7a0f61efbb8c 100644
> ---
> a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.
> c
> +++
> b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.
> c
> @@ -1,6 +1,6 @@
> /** @file
>This library is BaseCrypto router. It will redirect hash request to each
> individual
Re: [edk2-devel] [PATCH v2 65/78] SecurityPkg/Tcg: Fix various typos
Reviewed-by: jiewen@intel.com > -Original Message- > From: devel@edk2.groups.io On Behalf Of Philippe > Mathieu-Daudé > Sent: Friday, January 3, 2020 5:08 PM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Yao, Jiewen ; > Wang, Jian J ; Zhang, Chao B > ; Philippe Mathieu-Daude > Subject: [edk2-devel] [PATCH v2 65/78] SecurityPkg/Tcg: Fix various typos > > From: Antoine Coeur > > Fix various typos in documentation, comments and debug strings. > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Chao Zhang > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > SecurityPkg/Tcg/TcgSmm/TcgSmm.inf | 2 +- > SecurityPkg/Include/Library/TcgStorageCoreLib.h| 4 ++-- > SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h| 6 +++--- > SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 +- > SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c | 2 +- > SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c| 10 +- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 2 +- > SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c| 8 > .../Tcg/PhysicalPresencePei/PhysicalPresencePei.c | 2 +- > SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c| 2 +- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++-- > SecurityPkg/Tcg/TcgPei/TcgPei.c| 8 > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni| 2 +- > SecurityPkg/Tcg/TcgSmm/TcgSmm.uni | 2 +- > 14 files changed, 28 insertions(+), 28 deletions(-) > > diff --git a/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf > b/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf > index 40827041cae4..29f9c15b0e02 100644 > --- a/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf > +++ b/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf > @@ -1,5 +1,5 @@ > ## @file > -# Implements ACPI metholds for the TCG feature > +# Implements ACPI methods for the TCG feature > # > # This driver implements TPM definition block in ACPI table and registers > SMI > # callback functions for physical presence and MemoryClear to handle the > requests > diff --git a/SecurityPkg/Include/Library/TcgStorageCoreLib.h > b/SecurityPkg/Include/Library/TcgStorageCoreLib.h > index c25a56a14ca2..01a44c667c80 100644 > --- a/SecurityPkg/Include/Library/TcgStorageCoreLib.h > +++ b/SecurityPkg/Include/Library/TcgStorageCoreLib.h > @@ -588,7 +588,7 @@ TcgAddEndTransaction( >); > > /** > - Initial the tcg parse stucture. > + Initial the tcg parse structure. > >@paramParseStructInput parse structure. >@paramBuffer Input buffer data. > @@ -1218,7 +1218,7 @@ TcgParseSyncSession( >@param HostSession Host session data. >@param AceRowAce row info. >@param Authority1Authority 1 info. > - @param LogicalOperator Logiccal operator info. > + @param LogicalOperator Logical operator info. >@param Authority2Authority 2 info. > >@retvalReturn the action result. > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h > index 0543a2ce493d..557c1f8d68da 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h > @@ -247,7 +247,7 @@ GetDiskNameStringId( > >@param OpalDiskThe Opal device. > > - @retval EFI_SUCCESS Initialize the device success. > + @retval EFI_SUCCESSInitialize the device success. >@retval EFI_DEVICE_ERROR Get info from device failed. >@retval EFI_INVALID_PARAMETER Not get Msid info before get ownership > info. > > @@ -348,7 +348,7 @@ HiiUninstall( > >@param Dev The Opal device. > > - @retval EFI_SUCCESS Initialize the device success. > + @retval EFI_SUCCESS Initialize the device success. >@retval EFI_DEVICE_ERRORGet info from device failed. > > **/ > @@ -362,7 +362,7 @@ OpalDiskInitialize ( > >@param OpalDiskThe Opal device. > > - @retval EFI_SUCCESS Get ownership success. > + @retval EFI_SUCCESSGet ownership success. >@retval EFI_ACCESS_DENIED Has send BlockSID command, can't change > ownership. >@retval EFI_INVALID_PARAMETER Not get Msid info before get ownership > info. > > diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c > b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c > index f9c57a13f2e4..660f79effd53 100644 > --- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c > +++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c > @@ -837,7 +837,7 @@ TcgAddEndTransaction( > } > > /** > - Initial the tcg parse stucture. > + Initial the tcg parse structure. > >@paramParseStructInput parse structure. >@paramBuffer Input buffer data. > diff --git
Re: [edk2-devel] [PATCH v2 63/78] SecurityPkg/Hash2DxeCrypto: Fix few typos
Reviewed-by: jiewen@intel.com > -Original Message- > From: devel@edk2.groups.io On Behalf Of Philippe > Mathieu-Daudé > Sent: Friday, January 3, 2020 5:08 PM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Yao, Jiewen ; > Wang, Jian J ; Zhang, Chao B > ; Philippe Mathieu-Daude > Subject: [edk2-devel] [PATCH v2 63/78] SecurityPkg/Hash2DxeCrypto: Fix few > typos > > From: Antoine Coeur > > Fix few typos in documentation, comments and debug strings. > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Chao Zhang > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 2 +- > SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 +- > SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > index 9d84bacf189c..a0b57f051455 100644 > --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > @@ -1,7 +1,7 @@ > ## @file > # Produces the UEFI HASH2 protocol > # > -# This module will use EDKII crypto libary to HASH2 protocol. > +# This module will use EDKII crypto library to HASH2 protocol. > # > # (C) Copyright 2015 Hewlett-Packard Development Company, L.P. > # Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved. > diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > index 2b069a36c02b..d96bc136e2a4 100644 > --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > @@ -87,7 +87,7 @@ BOOLEAN >This function completes hash computation and retrieves the digest value > into >the specified memory. After this function has been called, the Hash context > cannot >be used again. > - Hash context should be already correctly intialized by HashInit(), and > should > not be > + Hash context should be already correctly initialized by HashInit(), and > should > not be >finalized by HashFinal(). Behavior with invalid Hash context is undefined. > >If HashContext is NULL, then return FALSE. > diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni > b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni > index 604c2a41be6d..9e168373f344 100644 > --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni > +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni > @@ -1,7 +1,7 @@ > // /** @file > // Produces the UEFI HASH2 protocol > // > -// This module will use EDKII crypto libary to HASH2 protocol. > +// This module will use EDKII crypto library to HASH2 protocol. > // > // Copyright (c) 2015, Intel Corporation. All rights reserved. > // > @@ -12,5 +12,5 @@ > > #string STR_MODULE_ABSTRACT #language en-US "Produces UEFI > HASH2 protocol" > > -#string STR_MODULE_DESCRIPTION #language en-US "This module will > use EDKII crypto libary to HASH2 protocol." > +#string STR_MODULE_DESCRIPTION #language en-US "This module will > use EDKII crypto library to HASH2 protocol." > > -- > 2.21.0 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52805): https://edk2.groups.io/g/devel/message/52805 Mute This Topic: https://groups.io/mt/69395962/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 64/78] SecurityPkg/Library/Tpm: Fix various typos
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Philippe Mathieu-Daude
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Yao, Jiewen ;
> Wang, Jian J ; Zhang, Chao B
> ; Philippe Mathieu-Daude
> Subject: [PATCH v2 64/78] SecurityPkg/Library/Tpm: Fix various typos
>
> From: Antoine Coeur
>
> Fix various typos in comments and documentation.
>
> Cc: Jiewen Yao
> Cc: Jian J Wang
> Cc: Chao Zhang
> Signed-off-by: Antoine Coeur
> Reviewed-by: Philippe Mathieu-Daude
> Signed-off-by: Philippe Mathieu-Daude
> ---
> SecurityPkg/Include/Library/TpmCommLib.h | 4 ++--
> SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c | 4 ++--
> SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c | 2 +-
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c| 4 ++--
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c| 6 +++---
> SecurityPkg/Library/TpmCommLib/TisPc.c | 2 +-
> 6 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/SecurityPkg/Include/Library/TpmCommLib.h
> b/SecurityPkg/Include/Library/TpmCommLib.h
> index 7e102a6a117d..1d18f8d837db 100644
> --- a/SecurityPkg/Include/Library/TpmCommLib.h
> +++ b/SecurityPkg/Include/Library/TpmCommLib.h
> @@ -185,7 +185,7 @@ typedef TIS_PC_REGISTERS *TIS_PC_REGISTERS_PTR;
> #define TIS_TIMEOUT_D 750 * 1000 // 750ms
>
> //
> -// Max TPM command/reponse length
> +// Max TPM command/response length
> //
> #define TPMCMDBUFLENGTH 1024
>
> @@ -210,7 +210,7 @@ TisPcWaitRegisterBits (
>);
>
> /**
> - Get BurstCount by reading the burstCount field of a TIS regiger
> + Get BurstCount by reading the burstCount field of a TIS register
>in the time of default TIS_TIMEOUT_D.
>
>@param[in] TisRegPointer to TIS register.
> diff --git a/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
> b/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
> index 1caa076203ba..f858090479e6 100644
> --- a/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
> +++ b/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
> @@ -28,7 +28,7 @@ typedef enum {
> } PTP_INTERFACE_TYPE;
>
> //
> -// Max TPM command/reponse length
> +// Max TPM command/response length
> //
> #define TPMCMDBUFLENGTH 1024
>
> @@ -121,7 +121,7 @@ Tpm12TisPcWaitRegisterBits (
> }
>
> /**
> - Get BurstCount by reading the burstCount field of a TIS regiger
> + Get BurstCount by reading the burstCount field of a TIS register
>in the time of default TIS_TIMEOUT_D.
>
>@param[in] TisRegPointer to TIS register.
> diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
> b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
> index 21f3bb5adf8e..32bff458448e 100644
> --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
> +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
> @@ -1,5 +1,5 @@
> /** @file
> - Implement TPM2 Miscellanenous related command.
> + Implement TPM2 Miscellaneous related command.
>
> Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> index b671cef04ed7..2c73385b6ce5 100644
> --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> @@ -26,7 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #define PTP_TIMEOUT_MAX (9 * 1000) // 90s
>
> //
> -// Max TPM command/reponse length
> +// Max TPM command/response length
> //
> #define TPMCMDBUFLENGTH 0x500
>
> @@ -290,7 +290,7 @@ PtpCrbTpmCommand (
> DEBUG ((EFI_D_VERBOSE, "\n"));
>);
>//
> - // Check the reponse data header (tag, parasize and returncode)
> + // Check the response data header (tag, parasize and returncode)
>//
>CopyMem (, BufferOut, sizeof (UINT16));
>// TPM2 should not use this RSP_COMMAND
> diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
> b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
> index bbebc94b4d01..9a809612b3d9 100644
> --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
> +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
> @@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #define TIS_TIMEOUT_MAX (9 * 1000) // 90s
>
> //
> -// Max TPM command/reponse length
> +// Max TPM command/response length
> //
> #define TPMCMDBUFLENGTH 0x500
>
> @@ -77,7 +77,7 @@ TisPcWaitRegisterBits (
> }
>
> /**
> - Get BurstCount by reading the burstCount field of a TIS regiger
> + Get BurstCount by reading the burstCount field of a TIS register
>in the time of default TIS_TIMEOUT_D.
>
>@param[in] TisRegPointer to TIS register.
> @@ -340,7 +340,7 @@ Tpm2TisTpmCommand (
> DEBUG ((EFI_D_VERBOSE, "\n"));
>
[edk2-devel] [PATCH v2 68/78] ShellPkg/DynamicCommand: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Zhichao Gao
Signed-off-by: Philippe Mathieu-Daude
---
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 2 +-
ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h | 2 +-
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 4 ++--
ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c | 2 +-
.../DynamicCommand/DpDynamicCommand/DpDynamicCommand.c| 4 ++--
ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c| 4 ++--
ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 8
ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c | 2 +-
.../TftpDynamicCommand/TftpDynamicCommand.c | 4 ++--
9 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
index e446cccde923..84fe0b502f46 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
@@ -127,7 +127,7 @@ RunDp (
);
/**
- Retrive HII package list from ImageHandle and publish to HII database.
+ Retrieve HII package list from ImageHandle and publish to HII database.
@param ImageHandleThe image handle of the process.
diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h
b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h
index 4cd778436813..c46a0d5b0c3b 100644
--- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h
+++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h
@@ -56,7 +56,7 @@ RunTftp (
);
/**
- Retrive HII package list from ImageHandle and publish to HII database.
+ Retrieve HII package list from ImageHandle and publish to HII database.
@param ImageHandleThe image handle of the process.
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
index 4ec4c18348bd..f7f3676bc91a 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
@@ -154,7 +154,7 @@ GetHandleFormModuleGuid (
*Handle = NULL;
}
//
- // Try to get the Handle form the caached array.
+ // Try to get the Handle from the cached array.
//
for (Index = 0; Index < mCachePairCount; Index++) {
if (CompareGuid (ModuleGuid, [Index].ModuleGuid)) {
@@ -918,7 +918,7 @@ Done:
/**
- Retrive HII package list from ImageHandle and publish to HII database.
+ Retrieve HII package list from ImageHandle and publish to HII database.
@param ImageHandleThe image handle of the process.
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c
b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c
index a7cecdfe0ade..b4b242a41158 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c
@@ -24,7 +24,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_STRING_ID
mStringHelpTokenId = STRING_TOKEN (S
@param ImageHandleThe image handle of the process.
@param SystemTableThe EFI System Table pointer.
- @retval EFI_SUCCESS Tftp command is executed sucessfully.
+ @retval EFI_SUCCESS Tftp command is executed successfully.
@retval EFI_ABORTED HII package was failed to initialize.
@retval othersOther errors when executing tftp command.
**/
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.c
b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.c
index d7dd85666c50..50fcc6e74616 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.c
@@ -19,7 +19,7 @@
@param[in] Shell The instance of the shell protocol used in
the context
of processing this command.
- @return EFI_SUCCESS the operation was sucessful
+ @return EFI_SUCCESS the operation was successful
@return other the operation failed.
**/
SHELL_STATUS
@@ -70,7 +70,7 @@ EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL mDpDynamicCommand = {
@param ImageHandleThe image handle of the process.
@param SystemTableThe EFI System Table pointer.
- @retval EFI_SUCCESS Tftp command is executed sucessfully.
+ @retval EFI_SUCCESS Tftp command is executed successfully.
@retval EFI_ABORTED HII package was failed to initialize.
@retval othersOther errors when executing tftp command.
**/
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
b/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
index f64c5ccf58f9..1a247d4bd492 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
[edk2-devel] [PATCH v2 69/78] SignedCapsulePkg: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiewen Yao Cc: Chao Zhang Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- SignedCapsulePkg/SignedCapsulePkg.dec | 4 +-- .../Include/Guid/EdkiiSystemFmpCapsule.h | 4 +-- .../Include/Library/IniParsingLib.h | 14 +- .../Library/IniParsingLib/IniParsingLib.c | 26 +-- 4 files changed, 24 insertions(+), 24 deletions(-) diff --git a/SignedCapsulePkg/SignedCapsulePkg.dec b/SignedCapsulePkg/SignedCapsulePkg.dec index 3492de6c8b9e..04dbf62af42a 100644 --- a/SignedCapsulePkg/SignedCapsulePkg.dec +++ b/SignedCapsulePkg/SignedCapsulePkg.dec @@ -53,7 +53,7 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] [PcdsDynamicEx] ## This dynamic PCD holds the EDKII system firmware image descriptor. # This information can be used for version check in EDKII system FMP capsule. - # Only if the new EdkiiSystemFrimwareImageDescriptor.Version is not less than + # Only if the new EdkiiSystemFirmwareImageDescriptor.Version is not less than # the current PcdEdkiiSystemFirmwareImageDescriptor.LowestSupportedVersion, # the EDKII system FmpCapsule will be processed. # The data structure of this PCD is EDKII_SYSTEM_FIRMWARE_IMAGE_DESCRIPTOR, @@ -65,7 +65,7 @@ [PcdsDynamicEx] ## This dynamic PCD hold the GUID of a firmware FFS which includes EDKII # system firmware image. - # An EDKII system firmware udpate module need consume this PCD to extract + # An EDKII system firmware update module need consume this PCD to extract # the EDKII system firmware from the capsule image. # It must be in [PcdsDynamicEx], because the EDKII system firmware update module may # consume the PCD produced in current system firmware image. diff --git a/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h b/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h index 1129d715ae25..8295f92a7341 100644 --- a/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h +++ b/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h @@ -60,7 +60,7 @@ ImageOffset = # Fv offset of this SystemFirmware image (HEX) FileGuid= ---- # PcdEdkiiSystemFirmwareFileGuid - NOTE: The [Name?] entry may have differnt FileGuid. + NOTE: The [Name?] entry may have different FileGuid. Only the one, whose FileGuid matches PcdEdkiiSystemFirmwareFileGuid, takes effect. The other entry is ignored. @@ -80,7 +80,7 @@ ImageOffset = # Image offset of this SystemFirmware image (HEX) FileGuid= ---- # PcdEdkiiSystemFirmwareFileGuid - NOTE: The [Name?] entry may have differnt FileGuid. + NOTE: The [Name?] entry may have different FileGuid. Only the one, whose FileGuid matches PcdEdkiiSystemFirmwareFileGuid, takes effect. The other entry is ignored. diff --git a/SignedCapsulePkg/Include/Library/IniParsingLib.h b/SignedCapsulePkg/Include/Library/IniParsingLib.h index 26d100ffde0a..edfdde7e8d32 100644 --- a/SignedCapsulePkg/Include/Library/IniParsingLib.h +++ b/SignedCapsulePkg/Include/Library/IniParsingLib.h @@ -14,7 +14,7 @@ 3.1) an ASCII String. The valid format is [A-Za-z0-9_]+ 3.2) a GUID. The valid format is ----, where x is [A-Fa-f0-9] 3.3) a decimal value. The valid format is [0-9]+ - 3.4) a heximal value. The valid format is 0x[A-Fa-f0-9]+ + 3.4) a hexadecimal value. The valid format is 0x[A-Fa-f0-9]+ 4) '#' or ';' can be used as comment at anywhere. 5) TAB(0x20) or SPACE(0x9) can be used as separator. 6) LF(\n, 0xA) or CR(\r, 0xD) can be used as line break. @@ -106,14 +106,14 @@ GetDecimalUintnFromDataFile ( ); /** - Get section entry heximal UINTN value. + Get section entry hexadecimal UINTN value. @param[in] Context INI Config file context. @param[in] SectionName Section name. @param[in] EntryName Section entry name. - @param[out] DataPoint to the got heximal UINTN value. + @param[out] DataPoint to the got hexadecimal UINTN value. - @retval EFI_SUCCESSSection entry heximal UINTN value is got. + @retval EFI_SUCCESSSection entry hexadecimal UINTN value is got. @retval EFI_NOT_FOUND Section is not found. **/ EFI_STATUS @@ -126,14 +126,14 @@ GetHexUintnFromDataFile ( ); /** - Get section entry heximal UINT64 value. + Get section entry hexadecimal UINT64 value. @param[in] Context INI Config file context. @param[in] SectionName Section name. @param[in] EntryName Section entry name. - @param[out] DataPoint to the got heximal UINT64 value. + @param[out] DataPoint to the got hexadecimal UINT64 value. - @retval EFI_SUCCESSSection entry heximal UINT64 value is got. +
[edk2-devel] [PATCH v2 66/78] SecurityPkg/VariableAuthenticated: Fix few typos
From: Antoine Coeur Fix few typos in comments and documentation. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- .../SecureBootConfigDxe/SecureBootConfigFileExplorer.c | 2 +- .../SecureBootConfigDxe/SecureBootConfigImpl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c index 088d6fd5d9ba..8bea707d4e18 100644 --- a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c +++ b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c @@ -81,7 +81,7 @@ CleanUpPage ( @param DevicePath Device path. - @retval NULLNot enough memory resourece for AllocateCopyPool. + @retval NULLNot enough memory resource for AllocateCopyPool. @retval Other A new allocated string that represents the file name. **/ diff --git a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c index 83497a23f52d..4f01a2ed677e 100644 --- a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c +++ b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c @@ -4071,7 +4071,7 @@ ON_EXIT: } /** - This functino to load signature data under the signature list. + This function to load signature data under the signature list. @param[in] PrivateData Module's private data. @param[in] LabelId Label number to insert opcodes. -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52800): https://edk2.groups.io/g/devel/message/52800 Mute This Topic: https://groups.io/mt/69395965/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 65/78] SecurityPkg/Tcg: Fix various typos
From: Antoine Coeur Fix various typos in documentation, comments and debug strings. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- SecurityPkg/Tcg/TcgSmm/TcgSmm.inf | 2 +- SecurityPkg/Include/Library/TcgStorageCoreLib.h| 4 ++-- SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h| 6 +++--- SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 +- SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c | 2 +- SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c| 10 +- SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 2 +- SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c| 8 .../Tcg/PhysicalPresencePei/PhysicalPresencePei.c | 2 +- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c| 2 +- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++-- SecurityPkg/Tcg/TcgPei/TcgPei.c| 8 SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni| 2 +- SecurityPkg/Tcg/TcgSmm/TcgSmm.uni | 2 +- 14 files changed, 28 insertions(+), 28 deletions(-) diff --git a/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf b/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf index 40827041cae4..29f9c15b0e02 100644 --- a/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf +++ b/SecurityPkg/Tcg/TcgSmm/TcgSmm.inf @@ -1,5 +1,5 @@ ## @file -# Implements ACPI metholds for the TCG feature +# Implements ACPI methods for the TCG feature # # This driver implements TPM definition block in ACPI table and registers SMI # callback functions for physical presence and MemoryClear to handle the requests diff --git a/SecurityPkg/Include/Library/TcgStorageCoreLib.h b/SecurityPkg/Include/Library/TcgStorageCoreLib.h index c25a56a14ca2..01a44c667c80 100644 --- a/SecurityPkg/Include/Library/TcgStorageCoreLib.h +++ b/SecurityPkg/Include/Library/TcgStorageCoreLib.h @@ -588,7 +588,7 @@ TcgAddEndTransaction( ); /** - Initial the tcg parse stucture. + Initial the tcg parse structure. @paramParseStructInput parse structure. @paramBuffer Input buffer data. @@ -1218,7 +1218,7 @@ TcgParseSyncSession( @param HostSession Host session data. @param AceRowAce row info. @param Authority1Authority 1 info. - @param LogicalOperator Logiccal operator info. + @param LogicalOperator Logical operator info. @param Authority2Authority 2 info. @retvalReturn the action result. diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h index 0543a2ce493d..557c1f8d68da 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h @@ -247,7 +247,7 @@ GetDiskNameStringId( @param OpalDiskThe Opal device. - @retval EFI_SUCCESS Initialize the device success. + @retval EFI_SUCCESSInitialize the device success. @retval EFI_DEVICE_ERROR Get info from device failed. @retval EFI_INVALID_PARAMETER Not get Msid info before get ownership info. @@ -348,7 +348,7 @@ HiiUninstall( @param Dev The Opal device. - @retval EFI_SUCCESS Initialize the device success. + @retval EFI_SUCCESS Initialize the device success. @retval EFI_DEVICE_ERRORGet info from device failed. **/ @@ -362,7 +362,7 @@ OpalDiskInitialize ( @param OpalDiskThe Opal device. - @retval EFI_SUCCESS Get ownership success. + @retval EFI_SUCCESSGet ownership success. @retval EFI_ACCESS_DENIED Has send BlockSID command, can't change ownership. @retval EFI_INVALID_PARAMETER Not get Msid info before get ownership info. diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c index f9c57a13f2e4..660f79effd53 100644 --- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c +++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c @@ -837,7 +837,7 @@ TcgAddEndTransaction( } /** - Initial the tcg parse stucture. + Initial the tcg parse structure. @paramParseStructInput parse structure. @paramBuffer Input buffer data. diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c index b6d5cf9890a0..ff331bfc8ad9 100644 --- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c +++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c @@ -640,7 +640,7 @@ TcgSetAuthorityEnabled( @param HostSession Host session data. @param AceRowAce row info. @param Authority1Authority 1 info. - @param LogicalOperator Logiccal operator info. + @param LogicalOperator Logical operator info. @param Authority2
[edk2-devel] [PATCH v2 67/78] ShellPkg/Application: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Zhichao Gao
Signed-off-by: Philippe Mathieu-Daude
---
ShellPkg/Application/Shell/ConsoleLogger.h| 4 +--
.../Application/Shell/FileHandleWrappers.h| 6 ++--
ShellPkg/Application/Shell/Shell.h| 2 +-
ShellPkg/Application/Shell/ShellEnvVar.h | 36 +--
ShellPkg/Application/Shell/ShellManParser.h | 10 +++---
.../Shell/ShellParametersProtocol.h | 20 +--
ShellPkg/Application/Shell/ShellProtocol.h| 12 +++
ShellPkg/Application/Shell/ConsoleLogger.c| 12 +++
ShellPkg/Application/Shell/ConsoleWrappers.c | 2 +-
.../Application/Shell/FileHandleWrappers.c| 8 ++---
ShellPkg/Application/Shell/Shell.c| 8 ++---
ShellPkg/Application/Shell/ShellEnvVar.c | 8 ++---
ShellPkg/Application/Shell/ShellManParser.c | 20 +--
.../Shell/ShellParametersProtocol.c | 26 +++---
ShellPkg/Application/Shell/ShellProtocol.c| 36 +--
ShellPkg/Application/ShellCTestApp/README.txt | 2 +-
16 files changed, 106 insertions(+), 106 deletions(-)
diff --git a/ShellPkg/Application/Shell/ConsoleLogger.h
b/ShellPkg/Application/Shell/ConsoleLogger.h
index c2d5a9dcd4e0..0a01bc2ca201 100644
--- a/ShellPkg/Application/Shell/ConsoleLogger.h
+++ b/ShellPkg/Application/Shell/ConsoleLogger.h
@@ -117,7 +117,7 @@ UpdateDisplayFromHistory(
);
/**
- Reset the text output device hardware and optionaly run diagnostics
+ Reset the text output device hardware and optionally run diagnostics
@param This Pointer to EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL
@param ExtendedVerification Indicates that a more extensive test may be
performed
@@ -305,7 +305,7 @@ ConsoleLoggerEnableCursor (
@param[in] ConsoleInfo The pointer to the instance of the console logger
information.
- This will be used when a mode has changed or a reset ocurred to verify all
+ This will be used when a mode has changed or a reset occurred to verify all
history buffers.
**/
EFI_STATUS
diff --git a/ShellPkg/Application/Shell/FileHandleWrappers.h
b/ShellPkg/Application/Shell/FileHandleWrappers.h
index 3398285d52f8..5d58bfb2f45c 100644
--- a/ShellPkg/Application/Shell/FileHandleWrappers.h
+++ b/ShellPkg/Application/Shell/FileHandleWrappers.h
@@ -20,17 +20,17 @@ typedef struct {
} SHELL_LINE_LOG;
///
-/// FILE sytle interfaces for StdIn.
+/// FILE styte interfaces for StdIn.
///
extern EFI_FILE_PROTOCOL FileInterfaceStdIn;
///
-/// FILE sytle interfaces for StdOut.
+/// FILE styte interfaces for StdOut.
///
extern EFI_FILE_PROTOCOL FileInterfaceStdOut;
///
-/// FILE sytle interfaces for StdErr.
+/// FILE styte interfaces for StdErr.
///
extern EFI_FILE_PROTOCOL FileInterfaceStdErr;
diff --git a/ShellPkg/Application/Shell/Shell.h
b/ShellPkg/Application/Shell/Shell.h
index 1227adc1eb63..e6eb150f57a5 100644
--- a/ShellPkg/Application/Shell/Shell.h
+++ b/ShellPkg/Application/Shell/Shell.h
@@ -135,7 +135,7 @@ typedef struct {
extern SHELL_INFO ShellInfoObject;
/**
- Converts the command line to it's post-processed form. this replaces
variables and alias' per UEFI Shell spec.
+ Converts the command line to its post-processed form. this replaces
variables and alias' per UEFI Shell spec.
@param[in,out] CmdLinepointer to the command line to update
diff --git a/ShellPkg/Application/Shell/ShellEnvVar.h
b/ShellPkg/Application/Shell/ShellEnvVar.h
index 854a71ad9709..6c8552ee6437 100644
--- a/ShellPkg/Application/Shell/ShellEnvVar.h
+++ b/ShellPkg/Application/Shell/ShellEnvVar.h
@@ -43,14 +43,14 @@ IsVolatileEnv (
);
/**
- Delete a Non-Violatile environment variable.
+ Delete a Non-Volatile environment variable.
- This will use the Runtime Services call SetVariable to remove a
non-violatile variable.
+ This will use the Runtime Services call SetVariable to remove a non-volatile
variable.
@param EnvVarName The name of the environment variable in
question
- @retval EFI_SUCCESS The variable was deleted sucessfully
- @retval other An error ocurred
+ @retval EFI_SUCCESS The variable was deleted successfully
+ @retval other An error occurred
@sa SetVariable
**/
#define SHELL_DELETE_ENVIRONMENT_VARIABLE(EnvVarName) \
@@ -61,16 +61,16 @@ IsVolatileEnv (
NULL))
/**
- Set a Non-Violatile environment variable.
+ Set a Non-Volatile environment variable.
- This will use the Runtime Services call SetVariable to set a non-violatile
variable.
+ This will use the Runtime Services call SetVariable to set a non-volatile
variable.
@param EnvVarName The name of the environment variable in
question
@param BufferSize UINTN size of Buffer
@param Buffer Pointer to
[edk2-devel] [PATCH v2 54/78] OvmfPkg/Acpi: Fix few typos
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
---
v2: Removed spurious stray space (Laszlo Ersek)
---
OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 2 +-
OvmfPkg/AcpiPlatformDxe/BootScript.c | 2 +-
OvmfPkg/AcpiTables/Facp.aslc | 8
OvmfPkg/AcpiTables/Facs.aslc | 2 +-
OvmfPkg/AcpiTables/Madt.aslc | 2 +-
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
index 12aeb1227c54..0ff57aa118ca 100644
--- a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
+++ b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
@@ -131,7 +131,7 @@ EFI_STATUS
This services sets the power state of the ISA controller specified by Device
to
the power state specified by OnOff. TRUE denotes on, FALSE denotes off.
- If the power state is sucessfully set on the ISA Controller, then
+ If the power state is successfully set on the ISA Controller, then
EFI_SUCCESS is returned.
@param[in] This The pointer to the EFI_ISA_ACPI_PROTOCOL instance.
diff --git a/OvmfPkg/AcpiPlatformDxe/BootScript.c
b/OvmfPkg/AcpiPlatformDxe/BootScript.c
index 7137994471bd..7b1b9586da41 100644
--- a/OvmfPkg/AcpiPlatformDxe/BootScript.c
+++ b/OvmfPkg/AcpiPlatformDxe/BootScript.c
@@ -240,7 +240,7 @@ FatalError:
Script opcodes. If the function returns successfully,
the caller must set the S3Context pointer -- originally
returned by AllocateS3Context() -- immediately to NULL,
-because the ownership of S3Context has been transfered.
+because the ownership of S3Context has been
transferred.
@retval EFI_SUCCESS The translation of S3Context to ACPI S3 Boot Script
opcodes has been successfully executed or queued. (This
diff --git a/OvmfPkg/AcpiTables/Facp.aslc b/OvmfPkg/AcpiTables/Facp.aslc
index 8829c1808a70..657a8c645821 100644
--- a/OvmfPkg/AcpiTables/Facp.aslc
+++ b/OvmfPkg/AcpiTables/Facp.aslc
@@ -21,7 +21,7 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = {
EFI_ACPI_CREATOR_ID,// ASL compiler vendor ID
EFI_ACPI_CREATOR_REVISION // ASL compiler revision number
},
- 0,// Physical addesss of FACS
+ 0,// Physical address of FACS
0,// Physical address of DSDT
RESERVED, // System Interrupt Model in ACPI 1.0, eliminated in 2.0
EFI_ACPI_2_0_PM_PROFILE_UNSPECIFIED, // Preferred PM profile
@@ -62,8 +62,8 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = {
GAS2_IO(RESET_REG, 1), // Extended address of the Reset Register
RESET_VALUE, // Value for the Reset Register to reset the system
{ RESERVED }, // reserved[3]
- 0,// 64-bit physical addesss of FACS, set at installation
- 0,// 64-bit physical addesss of DSDT, set at installation
+ 0,// 64-bit physical address of FACS, set at installation
+ 0,// 64-bit physical address of DSDT, set at installation
GAS2_IO(PM1a_EVT_BLK, PM1_EVT_LEN), // Ext. addr. of PM 1a Event Reg Blk
{ 0 }, // PM 1b Event Reg Blk unsupported
@@ -83,7 +83,7 @@ ReferenceAcpiTable (
{
//
// Reference the table being generated to prevent the optimizer from
removing the
- // data structure from the exeutable
+ // data structure from the executable
//
return (VOID*)
}
diff --git a/OvmfPkg/AcpiTables/Facs.aslc b/OvmfPkg/AcpiTables/Facs.aslc
index 56f86c1ca4fd..d4e6ac4b6bad 100644
--- a/OvmfPkg/AcpiTables/Facs.aslc
+++ b/OvmfPkg/AcpiTables/Facs.aslc
@@ -71,7 +71,7 @@ ReferenceAcpiTable (
{
//
// Reference the table being generated to prevent the optimizer from
removing the
- // data structure from the exeutable
+ // data structure from the executable
//
return (VOID*)
}
diff --git a/OvmfPkg/AcpiTables/Madt.aslc b/OvmfPkg/AcpiTables/Madt.aslc
index 44ffd3726500..02fc3649a0d0 100644
--- a/OvmfPkg/AcpiTables/Madt.aslc
+++ b/OvmfPkg/AcpiTables/Madt.aslc
@@ -147,7 +147,7 @@ ReferenceAcpiTable (
{
//
// Reference the table being generated to prevent the optimizer from
removing the
- // data structure from the exeutable
+ // data structure from the executable
//
return (VOID*)
}
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52788): https://edk2.groups.io/g/devel/message/52788
Mute This Topic: https://groups.io/mt/69395952/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 61/78] PcAtChipsetPkg: Fix few typos
From: Antoine Coeur
Correctly write 'serial', remove duplicated 'the'.
Cc: Ray Ni
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 +-
PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c
b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c
index 7dc11014a588..0a49093dbf26 100644
--- a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c
+++ b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c
@@ -59,7 +59,7 @@ AcpiTimerLibConstructor (
//
// If the register offset to the BAR for the ACPI I/O Port Base Address is
0x, then
- // no PCI register programming is required to enable access to the the ACPI
registers
+ // no PCI register programming is required to enable access to the ACPI
registers
// specified by PcdAcpiIoPortBaseAddress
//
if (PcdGet16 (PcdAcpiIoPciBarRegisterOffset) == 0x) {
diff --git a/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c
b/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c
index 25c4cefc1381..aa5657a7fd6b 100644
--- a/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c
+++ b/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c
@@ -58,7 +58,7 @@ UINT8 gBreakSet = 0;
If the serial device could not be initialized, then return
RETURN_DEVICE_ERROR.
@retval RETURN_SUCCESSThe serial device was initialized.
- @retval RETURN_DEVICE_ERROR The serail device could not be initialized.
+ @retval RETURN_DEVICE_ERROR The serial device could not be initialized.
**/
RETURN_STATUS
@@ -139,7 +139,7 @@ SerialPortWrite (
while ((NumberOfBytes--) != 0) {
//
-// Wait for the serail port to be ready.
+// Wait for the serial port to be ready.
//
do {
Data = IoRead8 ((UINT16) gUartBase + LSR_OFFSET);
@@ -180,7 +180,7 @@ SerialPortRead (
while ((NumberOfBytes--) != 0) {
//
-// Wait for the serail port to be ready.
+// Wait for the serial port to be ready.
//
do {
Data = IoRead8 ((UINT16) gUartBase + LSR_OFFSET);
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52795): https://edk2.groups.io/g/devel/message/52795
Mute This Topic: https://groups.io/mt/69395960/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 42/78] NetworkPkg/Library: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Include/Library/HttpLib.h | 2 +- NetworkPkg/Include/Library/IpIoLib.h | 4 ++-- NetworkPkg/Include/Library/NetLib.h | 2 +- NetworkPkg/Include/Library/TcpIoLib.h| 6 +++--- NetworkPkg/Include/Library/UdpIoLib.h| 6 +++--- NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c | 4 ++-- NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c | 16 NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 16 NetworkPkg/Library/DxeNetLib/NetBuffer.c | 4 ++-- NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c | 10 +- NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c | 10 +- 11 files changed, 40 insertions(+), 40 deletions(-) diff --git a/NetworkPkg/Include/Library/HttpLib.h b/NetworkPkg/Include/Library/HttpLib.h index 93100eb350e5..a906126b3d6e 100644 --- a/NetworkPkg/Include/Library/HttpLib.h +++ b/NetworkPkg/Include/Library/HttpLib.h @@ -425,7 +425,7 @@ HttpFreeHeaderFields ( the HTTP request message. @param[in] UrlThe URL of a remote host. @param[out] RequestMsg Pointer to the created HTTP request message. - NULL if any error occured. + NULL if any error occurred. @param[out] RequestMsgSize Size of the RequestMsg (in bytes). @retval EFI_SUCCESS If HTTP request string was created successfully. diff --git a/NetworkPkg/Include/Library/IpIoLib.h b/NetworkPkg/Include/Library/IpIoLib.h index 2d6e090f754e..d95413e87eb1 100644 --- a/NetworkPkg/Include/Library/IpIoLib.h +++ b/NetworkPkg/Include/Library/IpIoLib.h @@ -403,7 +403,7 @@ IpIoOpen ( This function is called after IpIoOpen(). The data to be sent is wrapped in Pkt. The IP instance wrapped in IpIo is used for sending by default but can be - overriden by Sender. Other sending configs, like source address and gateway + overridden by Sender. Other sending configs, like source address and gateway address etc., are specified in OverrideData. @param[in, out] IpIo Pointer to an IP_IO instance used for sending IP @@ -508,7 +508,7 @@ IpIoConfigIp ( This function pairs with IpIoAddIp(). The IpInfo is previously created by IpIoAddIp(). The IP_IO_IP_INFO::RefCnt is decremented and the IP instance - will be dstroyed if the RefCnt is zero. + will be destroyed if the RefCnt is zero. @param[in] IpIo The pointer to the IP_IO instance. @param[in] IpInfoThe pointer to the IpInfo to be removed. diff --git a/NetworkPkg/Include/Library/NetLib.h b/NetworkPkg/Include/Library/NetLib.h index 786382a1fcff..858d0b6ba07c 100644 --- a/NetworkPkg/Include/Library/NetLib.h +++ b/NetworkPkg/Include/Library/NetLib.h @@ -748,7 +748,7 @@ EFI_STATUS If it has been removed, then restart the traversal from the head. If it hasn't been removed, then continue with the next node directly. This function will end the iterate and return the CallBack's last return value if error happens, - or retrun EFI_SUCCESS if 2 complete passes are made with no changes in the number of children in the list. + or return EFI_SUCCESS if 2 complete passes are made with no changes in the number of children in the list. @param[in]List The head of the list. @param[in]CallBack Pointer to the callback function to destroy one node in the list. diff --git a/NetworkPkg/Include/Library/TcpIoLib.h b/NetworkPkg/Include/Library/TcpIoLib.h index 63872f615c0a..13c163ce9920 100644 --- a/NetworkPkg/Include/Library/TcpIoLib.h +++ b/NetworkPkg/Include/Library/TcpIoLib.h @@ -200,7 +200,7 @@ TcpIoReset ( @param[in] TcpIo The TcpIo wrapping the TCP socket. @param[in] Packet The packet to transmit. - @retval EFI_SUCCESSThe packet is trasmitted. + @retval EFI_SUCCESSThe packet is transmitted. @retval EFI_INVALID_PARAMETER One or more parameters are invalid. @retval EFI_UNSUPPORTEDOne or more of the control options are not supported in the implementation. @@ -221,14 +221,14 @@ TcpIoTransmit ( @param[in, out] TcpIo The TcpIo which wraps the socket to be destroyed. @param[in] Packet The buffer to hold the data copy from the socket rx buffer. - @param[in] AsyncMode Is this receive asyncronous or not. + @param[in] AsyncMode Is this receive asynchronous or not. @param[in] Timeout The time to wait for receiving the amount of data the Packet can hold. Set to NULL for infinite wait. @retval EFI_SUCCESSThe required
[edk2-devel] [PATCH v2 62/78] SecurityPkg: Fix few typos
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
.../Library/PlatformSecureLibNull/PlatformSecureLibNull.inf | 2 +-
.../DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c | 2 +-
.../Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 2 +-
SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 2 +-
.../HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c| 2 +-
.../HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c| 2 +-
SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c | 2 +-
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c | 2 +-
.../Library/PlatformSecureLibNull/PlatformSecureLibNull.uni | 2 +-
9 files changed, 9 insertions(+), 9 deletions(-)
diff --git
a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
index 9ae597d381fc..85607aa645a1 100644
--- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
+++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
@@ -1,5 +1,5 @@
## @file
-# NULL platform secure library instance that alway returns TRUE for a user
physical present
+# NULL platform secure library instance that always returns TRUE for a user
physical present
#
# NULL PlatformSecureLib instance does NOT really detect whether a physical
present
# user exists but returns TRUE directly. This instance can be used to verify
security
diff --git
a/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
b/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
index 174172d5d7a5..1a9bd4659a65 100644
--- a/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
+++ b/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
@@ -175,7 +175,7 @@ TpmPhysicalPresence (
@param[in] TcgProtocol EFI TCG Protocol instance.
@param[in] Ordinal TPM command code.
@param[in] AdditionalParameterSize Additional parameter size.
- @param[in] AdditionalParameters Pointer to the Additional paramaters.
+ @param[in] AdditionalParameters Pointer to the Additional parameters.
@retval TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE Error occurred during
sending command to TPM or
receiving response from TPM.
diff --git a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
index 04b9b0d7fbf3..5ea2d3ba8ed1 100644
--- a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
+++ b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
@@ -471,7 +471,7 @@ DxeTpm2MeasureBootHandler (
Status = gBS->LocateDevicePath (, ,
);
if (!EFI_ERROR (Status) && !mTcg2MeasureGptTableFlag) {
//
-// Find the gpt partion on the given devicepath
+// Find the gpt partition on the given devicepath
//
DevicePathNode = OrigDevicePathNode;
ASSERT (DevicePathNode != NULL);
diff --git a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
index 1f2eed29a1df..d5aeb35eb72c 100644
--- a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
+++ b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
@@ -769,7 +769,7 @@ DxeTpmMeasureBootHandler (
Status = gBS->LocateDevicePath (, ,
);
if (!EFI_ERROR (Status) && !mMeasureGptTableFlag) {
//
-// Find the gpt partion on the given devicepath
+// Find the gpt partition on the given devicepath
//
DevicePathNode = OrigDevicePathNode;
ASSERT (DevicePathNode != NULL);
diff --git
a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c
b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c
index a7cb05849c00..7a0f61efbb8c 100644
--- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c
+++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c
@@ -1,6 +1,6 @@
/** @file
This library is BaseCrypto router. It will redirect hash request to each
individual
- hash handler registerd, such as SHA1, SHA256.
+ hash handler registered, such as SHA1, SHA256.
Platform can use PcdTpm2HashMask to mask some hash engines.
Copyright (c) 2013 - 2018, Intel Corporation. All rights reserved.
diff --git
a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
index d31c8b0782d4..42cb562f67d3 100644
--- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
+++
[edk2-devel] [PATCH v2 45/78] NetworkPkg/Mtftp6Dxe: Fix various typos
From: Antoine Coeur Fix various typos in documentation, comments and strings. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h | 4 ++-- NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h| 4 ++-- NetworkPkg/Mtftp6Dxe/Mtftp6Option.h | 2 +- NetworkPkg/Mtftp6Dxe/Mtftp6Support.h | 2 +- NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c | 4 ++-- NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c| 4 ++-- NetworkPkg/Mtftp6Dxe/Mtftp6Option.c | 4 ++-- NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 8 NetworkPkg/Mtftp6Dxe/Mtftp6Support.c | 8 NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 2 +- 10 files changed, 21 insertions(+), 21 deletions(-) diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h b/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h index 30e6c8a3e1ab..86e8c6a77151 100644 --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h @@ -108,7 +108,7 @@ Mtftp6DriverBindingStop ( then a new handle is created. If it is a pointer to an existing UEFI handle, then the protocol is added to the existing UEFI handle. - @retval EFI_SUCCESThe protocol was added to ChildHandle. + @retval EFI_SUCCESS The protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER ChildHandle is NULL. @retval OthersThe child handle was not created. @@ -130,7 +130,7 @@ Mtftp6ServiceBindingCreateChild ( @param[in] ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance. @param[in] ChildHandle Handle of the child to destroy. - @retval EFI_SUCCESThe protocol was removed from ChildHandle. + @retval EFI_SUCCESS The protocol was removed from ChildHandle. @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed. @retval EFI_INVALID_PARAMETER Child handle is NULL. @retval OthersThe child handle was not destroyed diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h b/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h index 2c557b1928f6..321fbc1d5202 100644 --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h @@ -179,11 +179,11 @@ EfiMtftp6GetModeData ( - This is NULL. - MtftpConfigData.StationIp is neither zero nor one of the configured IP addresses in the underlying IPv6 driver. - - MtftpCofigData.ServerIp is not a valid IPv6 unicast address. + - MtftpConfigData.ServerIp is not a valid IPv6 unicast address. Note: It does not match the UEFI 2.3 Specification. @retval EFI_ACCESS_DENIED - The configuration could not be changed at this time because there is some MTFTP background operation in progress. - - MtftpCofigData.LocalPort is already in use. + - MtftpConfigData.LocalPort is already in use. Note: It does not match the UEFI 2.3 Specification. @retval EFI_NO_MAPPINGThe underlying IPv6 driver was responsible for choosing a source address for this instance, but no source address was available for use. diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Option.h b/NetworkPkg/Mtftp6Dxe/Mtftp6Option.h index 6dab4b1e71f6..ad12a7e4d0e2 100644 --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Option.h +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Option.h @@ -66,7 +66,7 @@ Mtftp6ParseMcastOption ( /** - Parse the MTFTP6 extesion options. + Parse the MTFTP6 extension options. @param[in] Options The pointer to the extension options list. @param[in] Count The num of the extension options. diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Support.h b/NetworkPkg/Mtftp6Dxe/Mtftp6Support.h index 5712601fc388..2b8a58f9de50 100644 --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Support.h +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Support.h @@ -334,7 +334,7 @@ Mtftp6RrqInput ( /** Start the Mtftp6 instance to download. It first initializes some - of the internal states then builds and sends an RRQ reqeuest packet. + of the internal states then builds and sends an RRQ request packet. Finally, it starts receive for the downloading. @param[in] Instance The pointer to the Mtftp6 instance. diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c index 18cdcddbe917..a19a67a1ce7e 100644 --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c @@ -538,7 +538,7 @@ Mtftp6DriverBindingStop ( then a new handle is created. If it is a pointer to an existing UEFI handle, then the protocol is
[edk2-devel] [PATCH v2 48/78] NetworkPkg/TcpDxe/Tcp: Fix various typos
From: Antoine Coeur Fix various typos in documentation, comments and debug strings. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/TcpDxe/TcpDriver.h | 8 NetworkPkg/TcpDxe/TcpFunc.h | 4 ++-- NetworkPkg/TcpDxe/TcpMain.h | 4 ++-- NetworkPkg/TcpDxe/TcpOption.h | 6 +++--- NetworkPkg/TcpDxe/TcpProto.h | 14 +++--- NetworkPkg/TcpDxe/TcpDispatcher.c | 6 +++--- NetworkPkg/TcpDxe/TcpDriver.c | 10 +- NetworkPkg/TcpDxe/TcpInput.c | 8 NetworkPkg/TcpDxe/TcpMain.c | 4 ++-- NetworkPkg/TcpDxe/TcpMisc.c | 2 +- NetworkPkg/TcpDxe/TcpOption.c | 2 +- NetworkPkg/TcpDxe/TcpOutput.c | 4 ++-- NetworkPkg/TcpDxe/TcpTimer.c | 2 +- 13 files changed, 37 insertions(+), 37 deletions(-) diff --git a/NetworkPkg/TcpDxe/TcpDriver.h b/NetworkPkg/TcpDxe/TcpDriver.h index 1ac412be6386..b90eed9f60a9 100644 --- a/NetworkPkg/TcpDxe/TcpDriver.h +++ b/NetworkPkg/TcpDxe/TcpDriver.h @@ -203,13 +203,13 @@ Tcp6DriverBindingStop ( ); /** - The Callback funtion called after the TCP socket is created. + The Callback function called after the TCP socket is created. @param[in] ThisPointer to the socket just created. @param[in] Context The context of the socket. @retval EFI_SUCCESS This protocol is installed successfully. - @retval other An error occured. + @retval other An error occurred. **/ EFI_STATUS @@ -248,7 +248,7 @@ TcpDestroySocketCallback ( If it is a pointer to an existing UEFI handle, then the protocol is added to the existing UEFI handle. - @retval EFI_SUCCESThe protocol was added to ChildHandle. + @retval EFI_SUCCESS The protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER ChildHandle is NULL. @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create the child. @@ -272,7 +272,7 @@ TcpServiceBindingCreateChild ( @param ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance. @param ChildHandle Handle of the child to destroy. - @retval EFI_SUCCESThe protocol was removed from ChildHandle. + @retval EFI_SUCCESS The protocol was removed from ChildHandle. @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed. @retval EFI_INVALID_PARAMETER The child handle is NULL. @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle diff --git a/NetworkPkg/TcpDxe/TcpFunc.h b/NetworkPkg/TcpDxe/TcpFunc.h index 5b8043e8ad52..05cd3c75dc51 100644 --- a/NetworkPkg/TcpDxe/TcpFunc.h +++ b/NetworkPkg/TcpDxe/TcpFunc.h @@ -46,7 +46,7 @@ TcpInitTcbLocal ( Initialize the peer related members. @param[in, out] TcbPointer to the TCP_CB of this TCP instance. - @param[in] SegPointer to the segment that contains the peer's intial information. + @param[in] SegPointer to the segment that contains the peer's initial information. @param[in] OptPointer to the options announced by the peer. **/ @@ -668,7 +668,7 @@ Tcp6RefreshNeighbor ( // /** - The procotol handler provided to the socket layer, used to + The protocol handler provided to the socket layer, used to dispatch the socket level requests by calling the corresponding TCP layer functions. diff --git a/NetworkPkg/TcpDxe/TcpMain.h b/NetworkPkg/TcpDxe/TcpMain.h index 69b35427a17b..35f12a16a87c 100644 --- a/NetworkPkg/TcpDxe/TcpMain.h +++ b/NetworkPkg/TcpDxe/TcpMain.h @@ -230,7 +230,7 @@ Tcp4Connect ( @retval EFI_SUCCESS The listen token has been queued successfully. @retval EFI_NOT_STARTED The EFI_TCP4_PROTOCOL instance hasn't been configured. - @retval EFI_ACCESS_DENIEDThe instatnce is not a passive one or it is not + @retval EFI_ACCESS_DENIEDThe instance is not a passive one or it is not in Tcp4StateListen state, or a same listen token has already existed in the listen token queue of this TCP instance. @@ -565,7 +565,7 @@ Tcp6Connect ( @retval EFI_INVALID_PARAMETER One or more of the following are TRUE: - This is NULL. - ListenToken is NULL. - - ListentToken->CompletionToken.Event is NULL. + - ListenToken->CompletionToken.Event is NULL. @retval EFI_OUT_OF_RESOURCES Could not allocate enough resources to finish the operation. @retval EFI_DEVICE_ERROR Any unexpected error not belonging to the
[edk2-devel] [PATCH v2 53/78] NetworkPkg/VlanConfigDxe: Fix few typos
From: Antoine Coeur
Correctly write 'EFI_SUCCESS' in the documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/VlanConfigDxe/VlanConfigImpl.h | 6 +++---
NetworkPkg/VlanConfigDxe/VlanConfigDriver.c | 8
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/NetworkPkg/VlanConfigDxe/VlanConfigImpl.h
b/NetworkPkg/VlanConfigDxe/VlanConfigImpl.h
index 14f99c03b7d0..2f1f17e6ef95 100644
--- a/NetworkPkg/VlanConfigDxe/VlanConfigImpl.h
+++ b/NetworkPkg/VlanConfigDxe/VlanConfigImpl.h
@@ -185,7 +185,7 @@ VlanConfigComponentNameGetControllerName (
@param[in] RemainingDevicePath Optional parameter use to pick a specific
child
device to start.
- @retval EFI_SUCCES This driver supports this device
+ @retval EFI_SUCCESS This driver supports this device
@retval EFI_ALREADY_STARTED This driver is already running on this device
@retval otherThis driver does not support this device
@@ -206,7 +206,7 @@ VlanConfigDriverBindingSupported (
@param[in] RemainingDevicePath Optional parameter use to pick a specific
child
device to start.
- @retval EFI_SUCCES This driver is added to ControllerHandle
+ @retval EFI_SUCCESS This driver is added to ControllerHandle
@retval EFI_ALREADY_STARTED This driver is already running on
ControllerHandle
@retval otherThis driver does not support this device
@@ -228,7 +228,7 @@ VlanConfigDriverBindingStart (
of children is zero stop the entire bus
driver.
@param[in] ChildHandleBufferList of Child Handles to Stop.
- @retval EFI_SUCCES This driver is removed ControllerHandle
+ @retval EFI_SUCCESS This driver is removed ControllerHandle
@retval otherThis driver was not removed from this device
**/
diff --git a/NetworkPkg/VlanConfigDxe/VlanConfigDriver.c
b/NetworkPkg/VlanConfigDxe/VlanConfigDriver.c
index c717d9ea523c..ae636b763f93 100644
--- a/NetworkPkg/VlanConfigDxe/VlanConfigDriver.c
+++ b/NetworkPkg/VlanConfigDxe/VlanConfigDriver.c
@@ -24,7 +24,7 @@ EFI_DRIVER_BINDING_PROTOCOL gVlanConfigDriverBinding = {
@param[in] ImageHandleThe image handle of the driver.
@param[in] SystemTableThe system table.
- @retval EFI_SUCCES All the related protocols are installed on
the driver.
+ @retval EFI_SUCCESSAll the related protocols are installed on
the driver.
@retval Others Failed to install protocols.
**/
@@ -54,7 +54,7 @@ VlanConfigDriverEntryPoint (
@param[in] RemainingDevicePath Optional parameter use to pick a specific
child
device to start.
- @retval EFI_SUCCES This driver supports this device
+ @retval EFI_SUCCESS This driver supports this device
@retval EFI_ALREADY_STARTED This driver is already running on this device
@retval otherThis driver does not support this device
@@ -104,7 +104,7 @@ VlanConfigDriverBindingSupported (
@param[in] RemainingDevicePath Optional parameter use to pick a specific
child
device to start.
- @retval EFI_SUCCES This driver is added to ControllerHandle
+ @retval EFI_SUCCESS This driver is added to ControllerHandle
@retval EFI_ALREADY_STARTED This driver is already running on
ControllerHandle
@retval otherThis driver does not support this device
@@ -236,7 +236,7 @@ ErrorExit:
of children is zero stop the entire bus
driver.
@param[in] ChildHandleBufferList of Child Handles to Stop.
- @retval EFI_SUCCES This driver is removed ControllerHandle
+ @retval EFI_SUCCESS This driver is removed ControllerHandle
@retval otherThis driver was not removed from this device
**/
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52787): https://edk2.groups.io/g/devel/message/52787
Mute This Topic: https://groups.io/mt/69395948/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 43/78] NetworkPkg/MnpDxe: Fix various typos
From: Antoine Coeur Fix various typos in documentation, comments and debug strings. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/MnpDxe/MnpDxe.inf | 2 +- NetworkPkg/MnpDxe/MnpDriver.h | 6 +++--- NetworkPkg/MnpDxe/MnpImpl.h | 14 +++--- NetworkPkg/MnpDxe/MnpConfig.c | 14 +++--- NetworkPkg/MnpDxe/MnpDriver.c | 10 +- NetworkPkg/MnpDxe/MnpIo.c | 8 NetworkPkg/MnpDxe/MnpMain.c | 6 +++--- NetworkPkg/MnpDxe/MnpDxe.uni | 4 ++-- 8 files changed, 32 insertions(+), 32 deletions(-) diff --git a/NetworkPkg/MnpDxe/MnpDxe.inf b/NetworkPkg/MnpDxe/MnpDxe.inf index 7280060dded1..608e52aa51d8 100644 --- a/NetworkPkg/MnpDxe/MnpDxe.inf +++ b/NetworkPkg/MnpDxe/MnpDxe.inf @@ -1,5 +1,5 @@ ## @file -# This module produces EFI MNP Protocol, EFI MNP Servie Binding Protocol and EFI VLAN Protocol. +# This module produces EFI MNP Protocol, EFI MNP Service Binding Protocol and EFI VLAN Protocol. # # This module produces EFI Managed Network Protocol upon EFI Simple Network Protocol, # to provide raw asynchronous network I/O services. It also produces EFI VLAN Protocol diff --git a/NetworkPkg/MnpDxe/MnpDriver.h b/NetworkPkg/MnpDxe/MnpDriver.h index 150d21e9ec16..4837cd0534b2 100644 --- a/NetworkPkg/MnpDxe/MnpDriver.h +++ b/NetworkPkg/MnpDxe/MnpDriver.h @@ -1,5 +1,5 @@ /** @file - Declaration of strctures and functions for MnpDxe driver. + Declaration of structures and functions for MnpDxe driver. Copyright (c) 2005 - 2016, Intel Corporation. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -223,7 +223,7 @@ MnpDriverBindingStop ( it is not NULL, then the I/O services are added to the existing child handle. - @retval EFI_SUCCES The protocol was added to ChildHandle. + @retval EFI_SUCCESSThe protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER ChildHandle is NULL. @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create the child. @@ -248,7 +248,7 @@ MnpServiceBindingCreateChild ( instance. @param[in] ChildHandleHandle of the child to destroy. - @retval EFI_SUCCES The protocol was removed from ChildHandle. + @retval EFI_SUCCESSThe protocol was removed from ChildHandle. @retval EFI_UNSUPPORTEDChildHandle does not support the protocol that is being removed. @retval EFI_INVALID_PARAMETER ChildHandle is NULL. diff --git a/NetworkPkg/MnpDxe/MnpImpl.h b/NetworkPkg/MnpDxe/MnpImpl.h index 7d5424034659..e91408c6c9bd 100644 --- a/NetworkPkg/MnpDxe/MnpImpl.h +++ b/NetworkPkg/MnpDxe/MnpImpl.h @@ -284,7 +284,7 @@ MnpFlushRcvdDataQueue ( @param[in, out] Instance Pointer to the mnp instance context data. @param[in] ConfigData Pointer to the configuration data used to configure -the isntance. +the instance. @retval EFI_SUCCESS The Instance is configured. @retval EFI_UNSUPPORTED EnableReceiveTimestamps is on and the @@ -361,12 +361,12 @@ MnpBuildTxPacket ( /** Synchronously send out the packet. - This functon places the packet buffer to SNP driver's tansmit queue. The packet - can be considered successfully sent out once SNP acccetp the packet, while the + This function places the packet buffer to SNP driver's tansmit queue. The packet + can be considered successfully sent out once SNP accept the packet, while the packet buffer recycle is deferred for better performance. @param[in] MnpServiceData Pointer to the mnp service context data. - @param[in] Packet Pointer to the pakcet buffer. + @param[in] Packet Pointer to the packet buffer. @param[in] Length The length of the packet. @param[in, out] Token Pointer to the token the packet generated from. @@ -404,7 +404,7 @@ MnpInstanceDeliverPacket ( packet. @param[in] Event The event this notify function registered to. - @param[in] Context Pointer to the context data registerd to the Event. + @param[in] Context Pointer to the context data registered to the Event. **/ VOID @@ -480,8 +480,8 @@ MnpAllocTxBuf ( @param[in, out] MnpDeviceData Pointer to the mnp device context data. - @retval EFI_SUCCESS Successed to recyclethe transmitted buffer address. - @retval Others Failed to recyclethe transmitted buffer address. + @retval EFI_SUCCESS Successed to recycle the transmitted buffer address. + @retval Others
[edk2-devel] [PATCH v2 56/78] OvmfPkg/Csm/LegacyBios: Fix a typo
Fix a typo in the header documentation. Signed-off-by: Philippe Mathieu-Daude --- OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Csm/Include/Protocol/LegacyBios.h b/OvmfPkg/Csm/Include/Protocol/LegacyBios.h index cd585a8d58f3..cb320b601733 100644 --- a/OvmfPkg/Csm/Include/Protocol/LegacyBios.h +++ b/OvmfPkg/Csm/Include/Protocol/LegacyBios.h @@ -1,7 +1,7 @@ /** @file The EFI Legacy BIOS Protocol is used to abstract legacy Option ROM usage under EFI and Legacy OS boot. This file also includes all the related - COMPATIBILIY16 structures and definitions. + COMPATIBILITY16 structures and definitions. Note: The names for EFI_IA32_REGISTER_SET elements were picked to follow well known naming conventions. -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52790): https://edk2.groups.io/g/devel/message/52790 Mute This Topic: https://groups.io/mt/69395955/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 64/78] SecurityPkg/Library/Tpm: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
SecurityPkg/Include/Library/TpmCommLib.h | 4 ++--
SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c | 4 ++--
SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c | 2 +-
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c| 4 ++--
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c| 6 +++---
SecurityPkg/Library/TpmCommLib/TisPc.c | 2 +-
6 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/SecurityPkg/Include/Library/TpmCommLib.h
b/SecurityPkg/Include/Library/TpmCommLib.h
index 7e102a6a117d..1d18f8d837db 100644
--- a/SecurityPkg/Include/Library/TpmCommLib.h
+++ b/SecurityPkg/Include/Library/TpmCommLib.h
@@ -185,7 +185,7 @@ typedef TIS_PC_REGISTERS *TIS_PC_REGISTERS_PTR;
#define TIS_TIMEOUT_D 750 * 1000 // 750ms
//
-// Max TPM command/reponse length
+// Max TPM command/response length
//
#define TPMCMDBUFLENGTH 1024
@@ -210,7 +210,7 @@ TisPcWaitRegisterBits (
);
/**
- Get BurstCount by reading the burstCount field of a TIS regiger
+ Get BurstCount by reading the burstCount field of a TIS register
in the time of default TIS_TIMEOUT_D.
@param[in] TisRegPointer to TIS register.
diff --git a/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
b/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
index 1caa076203ba..f858090479e6 100644
--- a/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
+++ b/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
@@ -28,7 +28,7 @@ typedef enum {
} PTP_INTERFACE_TYPE;
//
-// Max TPM command/reponse length
+// Max TPM command/response length
//
#define TPMCMDBUFLENGTH 1024
@@ -121,7 +121,7 @@ Tpm12TisPcWaitRegisterBits (
}
/**
- Get BurstCount by reading the burstCount field of a TIS regiger
+ Get BurstCount by reading the burstCount field of a TIS register
in the time of default TIS_TIMEOUT_D.
@param[in] TisRegPointer to TIS register.
diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
index 21f3bb5adf8e..32bff458448e 100644
--- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
+++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
@@ -1,5 +1,5 @@
/** @file
- Implement TPM2 Miscellanenous related command.
+ Implement TPM2 Miscellaneous related command.
Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
index b671cef04ed7..2c73385b6ce5 100644
--- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
+++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
@@ -26,7 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#define PTP_TIMEOUT_MAX (9 * 1000) // 90s
//
-// Max TPM command/reponse length
+// Max TPM command/response length
//
#define TPMCMDBUFLENGTH 0x500
@@ -290,7 +290,7 @@ PtpCrbTpmCommand (
DEBUG ((EFI_D_VERBOSE, "\n"));
);
//
- // Check the reponse data header (tag, parasize and returncode)
+ // Check the response data header (tag, parasize and returncode)
//
CopyMem (, BufferOut, sizeof (UINT16));
// TPM2 should not use this RSP_COMMAND
diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
index bbebc94b4d01..9a809612b3d9 100644
--- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
+++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
@@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#define TIS_TIMEOUT_MAX (9 * 1000) // 90s
//
-// Max TPM command/reponse length
+// Max TPM command/response length
//
#define TPMCMDBUFLENGTH 0x500
@@ -77,7 +77,7 @@ TisPcWaitRegisterBits (
}
/**
- Get BurstCount by reading the burstCount field of a TIS regiger
+ Get BurstCount by reading the burstCount field of a TIS register
in the time of default TIS_TIMEOUT_D.
@param[in] TisRegPointer to TIS register.
@@ -340,7 +340,7 @@ Tpm2TisTpmCommand (
DEBUG ((EFI_D_VERBOSE, "\n"));
);
//
- // Check the reponse data header (tag,parasize and returncode )
+ // Check the response data header (tag,parasize and returncode )
//
CopyMem (, BufferOut, sizeof (UINT16));
// TPM2 should not use this RSP_COMMAND
diff --git a/SecurityPkg/Library/TpmCommLib/TisPc.c
b/SecurityPkg/Library/TpmCommLib/TisPc.c
index 4a14a2bf8193..533a42e53cee 100644
--- a/SecurityPkg/Library/TpmCommLib/TisPc.c
+++ b/SecurityPkg/Library/TpmCommLib/TisPc.c
@@ -60,7 +60,7 @@ TisPcWaitRegisterBits (
}
/**
- Get BurstCount by reading the burstCount field
[edk2-devel] [PATCH v2 44/78] NetworkPkg/Mtftp4Dxe: Fix various typos
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h | 2 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h| 2 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 2 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Support.h | 2 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c | 4 ++--
NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c| 10 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 14 +++---
NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 8
NetworkPkg/Mtftp4Dxe/Mtftp4Support.c | 6 +++---
NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 6 +++---
10 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h
b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h
index c90e69018629..6637c5a93ee5 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h
@@ -113,7 +113,7 @@ Mtftp4ServiceBindingCreateChild (
@param This The service binding instance
@param ChildHandleThe child handle to destroy
- @retval EFI_INVALID_PARAMETER The parameter is invaid.
+ @retval EFI_INVALID_PARAMETER The parameter is invalid.
@retval EFI_UNSUPPORTEDThe child may have already been destroyed.
@retval EFI_SUCCESSThe child is destroyed and removed from the
parent's child list.
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h
b/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h
index 33393d42472c..b16ac0a4a483 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h
@@ -201,7 +201,7 @@ Mtftp4WrqStart (
Start the MTFTP session to download.
It will first initialize some of the internal states then build and send a
RRQ
- reqeuest packet, at last, it will start receive for the downloading.
+ request packet, at last, it will start receive for the downloading.
@param Instance The Mtftp session
@param Operation The MTFTP opcode, it may be a
EFI_MTFTP4_OPCODE_RRQ
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
index 7bfe706f88c6..5f37b0f7b9e6 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
@@ -45,7 +45,7 @@ typedef struct {
@param OptionList The point to get the option array.
@retval EFI_INVALID_PARAMETER The parametera are invalid or packet isn't a
- well-formated OACK packet.
+ well-formatted OACK packet.
@retval EFI_SUCCESSThe option array is build
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory for the array
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Support.h
b/NetworkPkg/Mtftp4Dxe/Mtftp4Support.h
index cfa7582faa4b..95e9bad43ef1 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Support.h
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Support.h
@@ -28,7 +28,7 @@ typedef struct {
RRQ and WRQ have different requirements for Start and End.
For example, during start up, WRQ initializes its whole valid block range
- to [0, 0x]. This is bacause the server will send us a ACK0 to inform us
+ to [0, 0x]. This is because the server will send us a ACK0 to inform us
to start the upload. When the client received ACK0, it will remove 0 from the
range, get the next block number, which is 1, then upload the BLOCK1. For RRQ
without option negotiation, the server will directly send us the BLOCK1 in
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c
b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c
index 06c4e202d3ef..a795d262473e 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c
@@ -30,7 +30,7 @@ EFI_SERVICE_BINDING_PROTOCOL gMtftp4ServiceBindingTemplete =
{
@param SystemTableThe system table.
@retval EFI_SUCCESS The handles are successfully installed on the image.
- @retval others some EFI_ERROR occured.
+ @retval others some EFI_ERROR occurred.
**/
EFI_STATUS
@@ -632,7 +632,7 @@ ON_ERROR:
@param This The service binding instance
@param ChildHandleThe child handle to destroy
- @retval EFI_INVALID_PARAMETER The parameter is invaid.
+ @retval EFI_INVALID_PARAMETER The parameter is invalid.
@retval EFI_UNSUPPORTEDThe child may have already been destroyed.
@retval EFI_SUCCESSThe child is destroyed and removed from the
parent's child list.
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c
b/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c
index 70bd693e4e3a..990a9ef03027 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c
@@ -226,7 +226,7 @@ Mtftp4OverrideValid (
@param UdpCfgData The UDP configure data to reconfigure the
UDP_IO
[edk2-devel] [PATCH v2 57/78] OvmfPkg/Qemu: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
When "VbeShim.asm" is modified, we have to re-run "VbeShim.sh"
to update "VbeShim.h".
The string modified by this patch is only used when the DEBUG
macro (at the top of the file) is commented out. Since the
string is not referenced, NASM eliminates it, resulting in
the same byte array content in "VbeShim.h".
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
---
v2: Comment VbeShim.h is not modified in description (Laszlo)
---
.../FvbServicesRuntimeDxe.inf | 4 ++--
.../FvbServicesSmm.inf | 4 ++--
OvmfPkg/AcpiPlatformDxe/Qemu.c | 4 ++--
OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c| 2 +-
OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c| 4 ++--
.../Library/QemuBootOrderLib/QemuBootOrderLib.c| 2 +-
OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c| 2 +-
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 4 ++--
.../FwBlockService.c | 8
OvmfPkg/QemuVideoDxe/Driver.c | 2 +-
OvmfPkg/QemuVideoDxe/VbeShim.asm | 14 +++---
11 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
index ca6326e833ed..8125fd0735a1 100644
--- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
+++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
@@ -1,8 +1,8 @@
## @file
-# Component description file for QEMU Flash Fimware Volume Block DXE driver
+# Component description file for QEMU Flash Firmware Volume Block DXE driver
# module.
#
-# This DXE runtime driver implements and produces the Fimware Volue Block
+# This DXE runtime driver implements and produces the Firmware Volue Block
# Protocol for a QEMU flash device.
#
# Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.
diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
index 241e912e2967..4715d5fc437e 100644
--- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
+++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
@@ -1,8 +1,8 @@
## @file
-# Component description file for QEMU Flash Fimware Volume Block SMM driver
+# Component description file for QEMU Flash Firmware Volume Block SMM driver
# module.
#
-# This SMM driver implements and produces the SMM Fimware Volue Block Protocol
+# This SMM driver implements and produces the SMM Firmware Volue Block
Protocol
# for a QEMU flash device.
#
# Copyright (C) 2015, Red Hat, Inc.
diff --git a/OvmfPkg/AcpiPlatformDxe/Qemu.c b/OvmfPkg/AcpiPlatformDxe/Qemu.c
index f60e00f58af3..7fb42270043f 100644
--- a/OvmfPkg/AcpiPlatformDxe/Qemu.c
+++ b/OvmfPkg/AcpiPlatformDxe/Qemu.c
@@ -137,7 +137,7 @@ QemuInstallAcpiMadtTable (
++Iso;
//
- // Set Level-tiggered, Active High for all possible PCI link targets.
+ // Set Level-triggered, Active High for all possible PCI link targets.
//
for (Loop = 0; Loop < 16; ++Loop) {
if ((PcdGet16 (Pcd8259LegacyModeEdgeLevel) & (1 << Loop)) == 0) {
@@ -148,7 +148,7 @@ QemuInstallAcpiMadtTable (
Iso->Bus = 0x00; // ISA
Iso->Source = (UINT8) Loop;
Iso->GlobalSystemInterruptVector = (UINT32) Loop;
-Iso->Flags = 0x000D; // Level-tiggered, Active High
+Iso->Flags = 0x000D; // Level-triggered, Active High
++Iso;
}
ASSERT (
diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
index bc1a891dbaf1..75a3a88a3612 100644
--- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
+++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
@@ -1113,7 +1113,7 @@ InstallQemuFwCfgTables (
goto UninstallAcpiTables;
}
//
-// Ownership of S3Context has been transfered.
+// Ownership of S3Context has been transferred.
//
S3Context = NULL;
}
diff --git a/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
b/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
index 49bdfdf65043..1839f11f3301 100644
--- a/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
+++ b/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
@@ -1156,7 +1156,7 @@ PciBitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read
- from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+ from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit
and 16-bit PCI
[edk2-devel] [PATCH v2 46/78] NetworkPkg/SnpDxe: Fix few typos
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
v2: Fixed ususlly/ususally -> usually (Maciej Rabeda)
---
NetworkPkg/SnpDxe/Snp.h | 8
NetworkPkg/SnpDxe/Callback.c | 2 +-
NetworkPkg/SnpDxe/Shutdown.c | 2 +-
NetworkPkg/SnpDxe/Snp.c | 6 +++---
NetworkPkg/SnpDxe/WaitForPacket.c | 2 +-
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/NetworkPkg/SnpDxe/Snp.h b/NetworkPkg/SnpDxe/Snp.h
index 9e4b7d6f86a0..66b5f948e27c 100644
--- a/NetworkPkg/SnpDxe/Snp.h
+++ b/NetworkPkg/SnpDxe/Snp.h
@@ -1,5 +1,5 @@
/** @file
-Declaration of strctures and functions for SnpDxe driver.
+Declaration of structures and functions for SnpDxe driver.
Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -289,7 +289,7 @@ SnpUndi32CallbackBlock (
@param UniqueId This was supplied to UNDI at Undi_Start, SNP uses this
to
store Undi interface context (Undi does not read or
write
this variable)
- @param MicroSeconds number of micro seconds to pause, ususlly multiple of
10.
+ @param MicroSeconds number of micro seconds to pause, usually multiple of
10.
**/
VOID
EFIAPI
@@ -378,7 +378,7 @@ SnpUndi32CallbackUnmap (
need to synchronize their contents whenever it writes to/reads from the
buffer
using either the cpu address or the device address.
- EFI does not provide a sync call, since virt=physical, we sould just do
+ EFI does not provide a sync call, since virt=physical, we should just do
the synchronization ourself here!
@param UniqueIdThis was supplied to UNDI at Undi_Start, SNP uses this to
store
@@ -1015,7 +1015,7 @@ SnpUndi32Receive (
);
/**
- Nofication call back function for WaitForPacket event.
+ Notification call back function for WaitForPacket event.
@param Event EFI Event.
@param SnpPtr Pointer to SNP_DRIVER structure.
diff --git a/NetworkPkg/SnpDxe/Callback.c b/NetworkPkg/SnpDxe/Callback.c
index 6387dbdb35ef..0c0b81fdca8e 100644
--- a/NetworkPkg/SnpDxe/Callback.c
+++ b/NetworkPkg/SnpDxe/Callback.c
@@ -53,7 +53,7 @@ SnpUndi32CallbackBlock (
@param UniqueId This was supplied to UNDI at Undi_Start, SNP uses this
to
store Undi interface context (Undi does not read or
write
this variable).
- @param MicroSeconds Number of micro seconds to pause, ususlly multiple of
10.
+ @param MicroSeconds Number of micro seconds to pause, usually multiple of
10.
**/
VOID
diff --git a/NetworkPkg/SnpDxe/Shutdown.c b/NetworkPkg/SnpDxe/Shutdown.c
index aad0fe8493a8..ae823fd35243 100644
--- a/NetworkPkg/SnpDxe/Shutdown.c
+++ b/NetworkPkg/SnpDxe/Shutdown.c
@@ -1,5 +1,5 @@
/** @file
-Implementation of shuting down a network adapter.
+Implementation of shutting down a network adapter.
Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/NetworkPkg/SnpDxe/Snp.c b/NetworkPkg/SnpDxe/Snp.c
index 1099dbfa6a28..078b27cf5edd 100644
--- a/NetworkPkg/SnpDxe/Snp.c
+++ b/NetworkPkg/SnpDxe/Snp.c
@@ -782,7 +782,7 @@ SimpleNetworkDriverStop (
if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
//
-// Close EXIT_BOOT_SERIVES Event
+// Close EXIT_BOOT_SERVICES Event
//
gBS->CloseEvent (Snp->ExitBootServicesEvent);
}
@@ -840,9 +840,9 @@ EFI_DRIVER_BINDING_PROTOCOL gSimpleNetworkDriverBinding = {
@param ImageHandle The driver image handle.
@param SystemTable The system table.
- @retval EFI_SUCEESS Initialization routine has found UNDI hardware,
+ @retval EFI_SUCCESS Initialization routine has found UNDI hardware,
loaded it's ROM, and installed a notify event for
- the Network Indentifier Interface Protocol
+ the Network Identifier Interface Protocol
successfully.
@retval OtherReturn value from HandleProtocol for
DeviceIoProtocol or LoadedImageProtocol
diff --git a/NetworkPkg/SnpDxe/WaitForPacket.c
b/NetworkPkg/SnpDxe/WaitForPacket.c
index 866a1e8c0e8c..c337e69290f9 100644
--- a/NetworkPkg/SnpDxe/WaitForPacket.c
+++ b/NetworkPkg/SnpDxe/WaitForPacket.c
@@ -10,7 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
/**
- Nofication call back function for WaitForPacket event.
+ Notification call back function for WaitForPacket event.
@param Event EFI Event.
@param SnpPtr Pointer to SNP_DRIVER structure.
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52780):
[edk2-devel] [PATCH v2 59/78] OvmfPkg/Xen: Fix a typo
Fix a typo in a comment. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Acked-by: Anthony PERARD Reviewed-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daude --- OvmfPkg/XenBusDxe/GrantTable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/XenBusDxe/GrantTable.h b/OvmfPkg/XenBusDxe/GrantTable.h index 0d8434d1fe76..2cc889b6433f 100644 --- a/OvmfPkg/XenBusDxe/GrantTable.h +++ b/OvmfPkg/XenBusDxe/GrantTable.h @@ -27,7 +27,7 @@ XenGrantTableInit ( ); /** - Desinitilize the Grant Table. + De-initialize the Grant Table. **/ VOID XenGrantTableDeinit ( -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52793): https://edk2.groups.io/g/devel/message/52793 Mute This Topic: https://groups.io/mt/69395958/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 49/78] NetworkPkg/Tls: Fix few typos
From: Antoine Coeur Fix few typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h | 2 +- NetworkPkg/TlsDxe/TlsDriver.h| 4 ++-- NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr | 6 +++--- NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 6 +++--- NetworkPkg/TlsDxe/TlsDriver.c| 4 ++-- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h index 89d02e39a319..e9af49289393 100644 --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h @@ -207,7 +207,7 @@ TlsAuthConfigAccessExtractConfig ( @param Progress A pointer to a string filled in with the offset of the most recent '&' before the first failing name / value pair (or the -beginn ing of the string if the failure +beginning of the string if the failure is in the first name / value pair) or the terminating NULL if all was successful. diff --git a/NetworkPkg/TlsDxe/TlsDriver.h b/NetworkPkg/TlsDxe/TlsDriver.h index e9b581d05459..64a81bd49063 100644 --- a/NetworkPkg/TlsDxe/TlsDriver.h +++ b/NetworkPkg/TlsDxe/TlsDriver.h @@ -189,7 +189,7 @@ TlsDriverEntryPoint ( then a new handle is created. If it is a pointer to an existing UEFI handle, then the protocol is added to the existing UEFI handle. - @retval EFI_SUCCESThe protocol was added to ChildHandle. + @retval EFI_SUCCESS The protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER ChildHandle is NULL. @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create the child. @@ -213,7 +213,7 @@ TlsServiceBindingCreateChild ( @param ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance. @param ChildHandle Handle of the child to destroy. - @retval EFI_SUCCESThe protocol was removed from ChildHandle. + @retval EFI_SUCCESS The protocol was removed from ChildHandle. @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed. @retval EFI_INVALID_PARAMETER Child handle is NULL. @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr index c622489afc82..99a7feafa20c 100644 --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr @@ -19,7 +19,7 @@ formset guid = TLS_AUTH_CONFIG_GUID; // - // ##1 Form1: Main form for Tls Auth configration + // ##1 Form1: Main form for Tls Auth configuration // form formid = TLS_AUTH_CONFIG_FORMID1_FORM, title = STRING_TOKEN(STR_TLS_AUTH_CONFIG_TITLE); @@ -27,7 +27,7 @@ formset subtitle text = STRING_TOKEN(STR_NULL); // -// Display Server CA configration +// Display Server CA configuration // goto TLS_AUTH_CONFIG_FORMID2_FORM, prompt = STRING_TOKEN(STR_TLS_AUTH_CONFIG_SERVER_CA), @@ -38,7 +38,7 @@ formset subtitle text = STRING_TOKEN(STR_NULL); // -// Display Client cert configration +// Display Client cert configuration // grayoutif TRUE; /// Current unsupported. goto TLS_AUTH_CONFIG_FORMID3_FORM, diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c index 666216545277..715bc3a0a941 100644 --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c @@ -298,7 +298,7 @@ ON_EXIT: @param[in]QuestionIdBase Base question id of the cert list. @param[in]DeleteIndex Cert index to delete. - @retval EFI_SUCCESS Delete siganture successfully. + @retval EFI_SUCCESS Delete signature successfully. @retval EFI_NOT_FOUND Can't find the signature item, @retval EFI_OUT_OF_RESOURCESCould not allocate needed resources. **/ @@ -597,7 +597,7 @@ DevicePathToStr ( @param DevicePath Device path. - @retval NULLNot enough memory resourece for AllocateCopyPool. + @retval NULLNot enough memory resource for AllocateCopyPool. @retval Other A new allocated string that represents the file name. **/ @@ -1303,7 +1303,7 @@ TlsAuthConfigAccessExtractConfig ( @param Progress A pointer to a string filled in with the offset of the
[edk2-devel] [PATCH v2 51/78] NetworkPkg/Udp6Dxe: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Udp6Dxe/Udp6Driver.h | 6 +++--- NetworkPkg/Udp6Dxe/Udp6Impl.h | 12 ++-- NetworkPkg/Udp6Dxe/Udp6Driver.c | 8 NetworkPkg/Udp6Dxe/Udp6Impl.c | 18 +- NetworkPkg/Udp6Dxe/Udp6Main.c | 12 ++-- 5 files changed, 28 insertions(+), 28 deletions(-) diff --git a/NetworkPkg/Udp6Dxe/Udp6Driver.h b/NetworkPkg/Udp6Dxe/Udp6Driver.h index a08623979e86..577cebd5b1fd 100644 --- a/NetworkPkg/Udp6Dxe/Udp6Driver.h +++ b/NetworkPkg/Udp6Dxe/Udp6Driver.h @@ -78,7 +78,7 @@ Udp6DriverBindingSupported ( @param[in] RemainingDevicePathOptional parameter use to pick a specific child device to start. - @retval EFI_SUCCES This driver is added to ControllerHandle. + @retval EFI_SUCCESSThis driver is added to ControllerHandle. @retval EFI_OUT_OF_RESOURCES The required system resource can't be allocated. @retval other This driver does not support this device. @@ -132,7 +132,7 @@ Udp6DriverBindingStop ( then a new handle is created. If it is a pointer to an existing UEFI handle, then the protocol is added to the existing UEFI handle. - @retval EFI_SUCCESThe protocol was added to ChildHandle. + @retval EFI_SUCCESS The protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER This is NULL or ChildHandle is NULL. @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create the child. @@ -155,7 +155,7 @@ Udp6ServiceBindingCreateChild ( @param[in] This Protocol instance pointer. @param[in] ChildHandleHandle of the child to destroy. - @retval EFI_SUCCES The I/O services were removed from the child + @retval EFI_SUCCESSThe I/O services were removed from the child handle. @retval EFI_UNSUPPORTEDThe child handle does not support the I/O services that are being removed. diff --git a/NetworkPkg/Udp6Dxe/Udp6Impl.h b/NetworkPkg/Udp6Dxe/Udp6Impl.h index 5ccbcebfdff1..55a4b8a909be 100644 --- a/NetworkPkg/Udp6Dxe/Udp6Impl.h +++ b/NetworkPkg/Udp6Dxe/Udp6Impl.h @@ -151,7 +151,7 @@ Udp6CleanInstance ( ); /** - This function intializes the new created udp instance. + This function initializes the new created udp instance. @param[in] Udp6Service Pointer to the UDP6_SERVICE_DATA. @param[in, out] Instance Pointer to the un-initialized UDP6_INSTANCE_DATA. @@ -221,7 +221,7 @@ Udp6GetModeData ( @retval EFI_SUCCESSThe configuration settings were set, changed, or reset successfully. - @retval EFI_NO_MAPPING When the UdpConifgData.UseAnyStationAddress is set + @retval EFI_NO_MAPPING When the UdpConfigData.UseAnyStationAddress is set to true and there is no address available for IP6 driver to binding source address to this instance. @@ -281,12 +281,12 @@ Udp6Configure ( .FragmentBuffer fields is NULL. One or more of the Token.Packet.TxData.UdpSessionData. - DestinationAddres are not valid unicast IPv6 + DestinationAddress are not valid unicast IPv6 addresses, if the UdpSessionData is not NULL. Token.Packet.TxData.UdpSessionData. - DestinationAddres is NULL + DestinationAddress is NULL Token.Packet.TxData.UdpSessionData. - DestinatioPort is zero. + DestinationPort is zero. Token.Packet.TxData.UdpSessionData is NULL and this instance's UdpConfigData.RemoteAddress is unspecified. @@ -430,7 +430,7 @@ Udp6Groups ( /** This function tries to bind the udp instance according to the configured port - allocation stragety. + allocation strategy. @param[in] InstanceList Pointer to the head of the list linking the udp instances. diff --git a/NetworkPkg/Udp6Dxe/Udp6Driver.c b/NetworkPkg/Udp6Dxe/Udp6Driver.c index 5334fd17343b..6021bb36993a 100644 --- a/NetworkPkg/Udp6Dxe/Udp6Driver.c +++ b/NetworkPkg/Udp6Dxe/Udp6Driver.c
[edk2-devel] [PATCH v2 52/78] NetworkPkg/UefiPxeBcDxe: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h | 2 +-
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 8
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 4 ++--
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h | 16
NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c| 4 ++--
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 10 +-
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 18 +-
NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 4 ++--
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c| 10 +-
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 12 ++--
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 8
11 files changed, 48 insertions(+), 48 deletions(-)
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h
b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h
index 69b0502bbcd9..879da18a88e9 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h
@@ -60,7 +60,7 @@
//
// Dhcp4 and Dhcp6 share this definition, and corresponding
-// relatioinship is as follows:
+// relationship is as follows:
//
// Dhcp4Discover <> Dhcp6Solicit
// Dhcp4Offer<> Dhcp6Advertise
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
index ca40fdc9d336..ae4be775e85d 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
@@ -123,7 +123,7 @@ typedef struct {
@retval EFI_ABORTED User canceled the operation.
@retval EFI_SUCCESS Selected the boot menu successfully.
- @retval EFI_NOT_READY Read the input key from the keybroad has not finish.
+ @retval EFI_NOT_READY Read the input key from the keyboard has not finish.
**/
EFI_STATUS
@@ -174,7 +174,7 @@ PxeBcParseDhcp6Packet (
@param[in] Private The pointer to the PxeBc private data.
@param[in] Address The pointer to the ready address.
- @retval EFI_SUCCESS Registered the address succesfully.
+ @retval EFI_SUCCESS Registered the address successfully.
@retval Others Failed to register the address.
**/
@@ -226,8 +226,8 @@ PxeBcDhcp6Discover (
@param[in] Private The pointer to PXEBC_PRIVATE_DATA.
- @retval EFI_SUCCESS Switch the IP policy succesfully.
- @retval Others Unexpect error happened.
+ @retval EFI_SUCCESS Switch the IP policy successfully.
+ @retval Others Unexpected error happened.
**/
EFI_STATUS
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
index 9a011e046543..7356c0ae9e58 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
@@ -33,7 +33,7 @@
@param[in, out] BufferSize Pointer to buffer size.
@retval EFI_SUCCESSSuccessfully obtained the size of file.
- @retval EFI_NOT_FOUND Parse the tftp ptions failed.
+ @retval EFI_NOT_FOUND Parse the tftp options failed.
@retval EFI_DEVICE_ERROR The network device encountered an error during
this operation.
@retval Others Did not obtain the size of the file.
@@ -119,7 +119,7 @@ PxeBcTftpWriteFile (
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether with a receive buffer.
- @retval EFI_SUCCES Successfully obtained the data from the file
included in directory.
+ @retval EFI_SUCCESSSuccessfully obtained the data from the file
included in directory.
@retval EFI_DEVICE_ERROR The network device encountered an error during
this operation.
@retval Others Operation failed.
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h
b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h
index 9264cd92c467..312572129e78 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h
@@ -21,7 +21,7 @@
/**
- Flush the previous configration using the new station Ip address.
+ Flush the previous configuration using the new station Ip address.
@param[in] PrivatePointer to PxeBc private data.
@param[in] StationIp Pointer to the station Ip address.
@@ -59,7 +59,7 @@ PxeBcCommonNotify (
@param Mode Pointer to EFI_PXE_BASE_CODE_MODE.
@param Ip4AddrThe Ip4 address for resolution.
- @param MacAddress The resoluted MAC address if the resolution is
successful.
+ @param MacAddress The resolved MAC address if the resolution is
successful.
The value is undefined if resolution fails.
@retval TRUE Found a matched entry.
@@ -156,7 +156,7 @@ PxeBcConfigUdp4Write (
@param[in] StationIpPointer to the station address.
@param[in, out] SrcPort
[edk2-devel] [PATCH v2 58/78] OvmfPkg/Virtio: Fix few typos
From: Antoine Coeur Fix few typos in comments and documentation. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daude --- OvmfPkg/Include/Library/VirtioLib.h | 2 +- OvmfPkg/Library/VirtioLib/VirtioLib.c | 2 +- OvmfPkg/VirtioNetDxe/DriverBinding.c| 2 +- OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 2 +- OvmfPkg/VirtioRngDxe/VirtioRng.c| 2 +- OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/Include/Library/VirtioLib.h b/OvmfPkg/Include/Library/VirtioLib.h index e817a4206f62..e714ec7aee50 100644 --- a/OvmfPkg/Include/Library/VirtioLib.h +++ b/OvmfPkg/Include/Library/VirtioLib.h @@ -292,7 +292,7 @@ Virtio10WriteFeatures ( VIRTIO_UNMAP_SHARED. - @retval EFI_SUCCESS The NumberOfBytes is succesfully mapped. + @retval EFI_SUCCESS The NumberOfBytes is successfully mapped. @retval EFI_UNSUPPORTED The HostAddress cannot be mapped as a common buffer. @retval EFI_INVALID_PARAMETER One or more parameters are invalid. diff --git a/OvmfPkg/Library/VirtioLib/VirtioLib.c b/OvmfPkg/Library/VirtioLib/VirtioLib.c index 555d2a5ce7c9..e09324813c2d 100644 --- a/OvmfPkg/Library/VirtioLib/VirtioLib.c +++ b/OvmfPkg/Library/VirtioLib/VirtioLib.c @@ -452,7 +452,7 @@ Virtio10WriteFeatures ( VIRTIO_UNMAP_SHARED. - @retval EFI_SUCCESS The NumberOfBytes is succesfully mapped. + @retval EFI_SUCCESS The NumberOfBytes is successfully mapped. @retval EFI_UNSUPPORTED The HostAddress cannot be mapped as a common buffer. @retval EFI_INVALID_PARAMETER One or more parameters are invalid. diff --git a/OvmfPkg/VirtioNetDxe/DriverBinding.c b/OvmfPkg/VirtioNetDxe/DriverBinding.c index eb0e873657a4..3c400a604650 100644 --- a/OvmfPkg/VirtioNetDxe/DriverBinding.c +++ b/OvmfPkg/VirtioNetDxe/DriverBinding.c @@ -419,7 +419,7 @@ VirtioNetDriverBindingSupported ( device error.Currently not implemented. @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources. - @retval Others The driver failded to start the device. + @retval Others The driver failed to start the device. **/ diff --git a/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c b/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c index dc684650d665..d1e3ecfa5a0f 100644 --- a/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c +++ b/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c @@ -118,7 +118,7 @@ VirtioNetUninitRing ( a lack of resources. @return Status codes from VirtioMapAllBytesInSharedBuffer() - @retval EFI_SUCCESS Caller-supplied buffer is succesfully mapped. + @retval EFI_SUCCESS Caller-supplied buffer is successfully mapped. */ EFI_STATUS EFIAPI diff --git a/OvmfPkg/VirtioRngDxe/VirtioRng.c b/OvmfPkg/VirtioRngDxe/VirtioRng.c index d0e2468c2373..4e2b710f9e49 100644 --- a/OvmfPkg/VirtioRngDxe/VirtioRng.c +++ b/OvmfPkg/VirtioRngDxe/VirtioRng.c @@ -156,7 +156,7 @@ VirtioRngGetRNG ( Dev = VIRTIO_ENTROPY_SOURCE_FROM_RNG (This); // - // Map Buffer's system phyiscal address to device address + // Map Buffer's system physical address to device address // Status = VirtioMapAllBytesInSharedBuffer ( Dev->VirtIo, diff --git a/OvmfPkg/VirtioScsiDxe/VirtioScsi.c b/OvmfPkg/VirtioScsiDxe/VirtioScsi.c index e50a697daa15..935d15439579 100644 --- a/OvmfPkg/VirtioScsiDxe/VirtioScsi.c +++ b/OvmfPkg/VirtioScsiDxe/VirtioScsi.c @@ -497,7 +497,7 @@ VirtioScsiPassThru ( // * we perform the request fine // * but we fail to unmap the "InDataMapping" // -// In that case simply returing the EFI_DEVICE_ERROR is not sufficient. In +// In that case simply returning the EFI_DEVICE_ERROR is not sufficient. In // addition to the error code we also need to update Packet fields // accordingly so that we report the full loss of the incoming transfer. // -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52792): https://edk2.groups.io/g/devel/message/52792 Mute This Topic: https://groups.io/mt/69395957/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 47/78] NetworkPkg/TcpDxe/Sock: Fix few typos
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/TcpDxe/SockImpl.h | 2 +-
NetworkPkg/TcpDxe/Socket.h| 36 +++
NetworkPkg/TcpDxe/SockImpl.c | 4 ++--
NetworkPkg/TcpDxe/SockInterface.c | 10 -
4 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/NetworkPkg/TcpDxe/SockImpl.h b/NetworkPkg/TcpDxe/SockImpl.h
index f255b2fb5fad..5ec0435592d7 100644
--- a/NetworkPkg/TcpDxe/SockImpl.h
+++ b/NetworkPkg/TcpDxe/SockImpl.h
@@ -93,7 +93,7 @@ SockCancelToken (
@param[in] SockInitData Pointer to the initial data of the socket.
- @return Pointer to the newly created socket, return NULL when exception
occured.
+ @return Pointer to the newly created socket, return NULL when exception
occurred.
**/
SOCKET *
diff --git a/NetworkPkg/TcpDxe/Socket.h b/NetworkPkg/TcpDxe/Socket.h
index 874708ea575a..9448710a916a 100644
--- a/NetworkPkg/TcpDxe/Socket.h
+++ b/NetworkPkg/TcpDxe/Socket.h
@@ -107,8 +107,8 @@
@param[in] Sock Pointer to the socket.
- @retval TRUE The socket is unconfigued.
- @retval FALSE The socket is not unconfigued.
+ @retval TRUE The socket is unconfigured.
+ @retval FALSE The socket is not unconfigured.
**/
#define SOCK_IS_UNCONFIGURED(Sock) ((Sock)->ConfigureState == SO_UNCONFIGURED)
@@ -118,8 +118,8 @@
@param[in] SockPointer to the socket
- @retval TRUE The socket is configued
- @retval FALSE The socket is not configued
+ @retval TRUE The socket is configured
+ @retval FALSE The socket is not configured
**/
#define SOCK_IS_CONFIGURED(Sock) \
@@ -131,8 +131,8 @@
@param[in] SockPointer to the socket.
- @retval TRUE The socket is configued to active mode.
- @retval FALSE The socket is not configued to active mode.
+ @retval TRUE The socket is configured to active mode.
+ @retval FALSE The socket is not configured to active mode.
**/
#define SOCK_IS_CONFIGURED_ACTIVE(Sock) ((Sock)->ConfigureState ==
SO_CONFIGURED_ACTIVE)
@@ -142,8 +142,8 @@
@param[in] SockPointer to the socket.
- @retval TRUE The socket is configued to passive mode.
- @retval FALSE The socket is not configued to passive mode.
+ @retval TRUE The socket is configured to passive mode.
+ @retval FALSE The socket is not configured to passive mode.
**/
#define SOCK_IS_CONNECTED_PASSIVE(Sock) ((Sock)->ConfigureState ==
SO_CONFIGURED_PASSIVE)
@@ -380,13 +380,13 @@ EFI_STATUS
);
/**
- The Callback funtion called after the TCP socket is created.
+ The Callback function called after the TCP socket is created.
@param[in] ThisPointer to the socket just created.
@param[in] Context Context of the socket.
@retval EFI_SUCCESS This protocol installed successfully.
- @retval other Some error occured.
+ @retval other Some error occurred.
**/
typedef
@@ -429,7 +429,7 @@ typedef struct _SOCK_INIT_DATA {
// Callbacks after socket is created and before socket is to be destroyed.
//
SOCK_CREATE_CALLBACK CreateCallback; ///< Callback after created
- SOCK_DESTROY_CALLBACK DestroyCallback; ///< Callback before destroied
+ SOCK_DESTROY_CALLBACK DestroyCallback; ///< Callback before destroyed
VOID *Context;///< The context of the callback
//
@@ -501,7 +501,7 @@ struct _TCP_SOCKET {
// Callbacks after socket is created and before socket is to be destroyed.
//
SOCK_CREATE_CALLBACK CreateCallback; ///< Callback after created
- SOCK_DESTROY_CALLBACK DestroyCallback; ///< Callback before destroied
+ SOCK_DESTROY_CALLBACK DestroyCallback; ///< Callback before destroyed
VOID *Context; ///< The context of the callback
};
@@ -512,7 +512,7 @@ typedef struct _SOCK_TOKEN {
LIST_ENTRYTokenList; ///< The entry to add in the token list
SOCK_COMPLETION_TOKEN *Token; ///< The application's token
UINT32RemainDataLen; ///< Unprocessed data length
- SOCKET*Sock; ///< The poninter to the socket this
token
+ SOCKET*Sock; ///< The pointer to the socket this
token
///< belongs to
} SOCK_TOKEN;
@@ -524,7 +524,7 @@ typedef struct _TCP_RSV_DATA {
} TCP_RSV_DATA;
//
-// Socket provided oprerations for low layer protocol implemented in SockImpl.c
+// Socket provided operations for low layer protocol implemented in SockImpl.c
//
/**
@@
[edk2-devel] [PATCH v2 63/78] SecurityPkg/Hash2DxeCrypto: Fix few typos
From: Antoine Coeur Fix few typos in documentation, comments and debug strings. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 2 +- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 +- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf index 9d84bacf189c..a0b57f051455 100644 --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf @@ -1,7 +1,7 @@ ## @file # Produces the UEFI HASH2 protocol # -# This module will use EDKII crypto libary to HASH2 protocol. +# This module will use EDKII crypto library to HASH2 protocol. # # (C) Copyright 2015 Hewlett-Packard Development Company, L.P. # Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved. diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c index 2b069a36c02b..d96bc136e2a4 100644 --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c @@ -87,7 +87,7 @@ BOOLEAN This function completes hash computation and retrieves the digest value into the specified memory. After this function has been called, the Hash context cannot be used again. - Hash context should be already correctly intialized by HashInit(), and should not be + Hash context should be already correctly initialized by HashInit(), and should not be finalized by HashFinal(). Behavior with invalid Hash context is undefined. If HashContext is NULL, then return FALSE. diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni index 604c2a41be6d..9e168373f344 100644 --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni @@ -1,7 +1,7 @@ // /** @file // Produces the UEFI HASH2 protocol // -// This module will use EDKII crypto libary to HASH2 protocol. +// This module will use EDKII crypto library to HASH2 protocol. // // Copyright (c) 2015, Intel Corporation. All rights reserved. // @@ -12,5 +12,5 @@ #string STR_MODULE_ABSTRACT #language en-US "Produces UEFI HASH2 protocol" -#string STR_MODULE_DESCRIPTION #language en-US "This module will use EDKII crypto libary to HASH2 protocol." +#string STR_MODULE_DESCRIPTION #language en-US "This module will use EDKII crypto library to HASH2 protocol." -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52797): https://edk2.groups.io/g/devel/message/52797 Mute This Topic: https://groups.io/mt/69395962/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 60/78] OvmfPkg/Xen: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h | 2 +-
OvmfPkg/Include/IndustryStandard/Xen/grant_table.h| 4 ++--
OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h | 2 +-
OvmfPkg/Include/Protocol/XenBus.h | 4 ++--
OvmfPkg/Include/Protocol/XenIo.h | 2 +-
OvmfPkg/XenBusDxe/DriverBinding.h | 2 +-
OvmfPkg/XenBusDxe/EventChannel.h | 2 +-
OvmfPkg/XenBusDxe/GrantTable.h| 2 +-
OvmfPkg/XenPvBlkDxe/BlockIo.h | 6 +++---
OvmfPkg/XenPvBlkDxe/DriverBinding.h | 2 +-
OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 4 ++--
.../XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 6 +++---
OvmfPkg/XenBusDxe/XenBus.c| 2 +-
OvmfPkg/XenBusDxe/XenBusDxe.c | 6 +++---
OvmfPkg/XenBusDxe/XenStore.c | 4 ++--
OvmfPkg/XenPvBlkDxe/BlockFront.c | 2 +-
OvmfPkg/XenPvBlkDxe/BlockIo.c | 8
OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c | 2 +-
18 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
b/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
index a394f8d85a5d..36338d063a9d 100644
--- a/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
+++ b/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
@@ -96,7 +96,7 @@
* All generic sub-operations
*
* HYPERVISOR_physdev_op
- * No sub-operations are currenty supported
+ * No sub-operations are currently supported
*
* HYPERVISOR_sysctl
* All generic sub-operations, with the exception of:
diff --git a/OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
b/OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
index da8d6c2705f0..54af1dbc383c 100644
--- a/OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
+++ b/OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
@@ -365,7 +365,7 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_unmap_grant_ref_t);
/*
* GNTMAP_contains_pte subflag:
* 0 => This map request contains a host virtual address.
- * 1 => This map request contains the machine addess of the PTE to update.
+ * 1 => This map request contains the machine address of the PTE to update.
*/
#define _GNTMAP_contains_pte(4)
#define GNTMAP_contains_pte (1<<_GNTMAP_contains_pte)
@@ -386,7 +386,7 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_unmap_grant_ref_t);
/* ` enum grant_status { */
#define GNTST_okay (0) /* Normal return.*/
#define GNTST_general_error(-1) /* General undefined error. */
-#define GNTST_bad_domain (-2) /* Unrecognsed domain id.*/
+#define GNTST_bad_domain (-2) /* Unrecognised domain id. */
#define GNTST_bad_gntref (-3) /* Unrecognised or inappropriate gntref. */
#define GNTST_bad_handle (-4) /* Unrecognised or inappropriate handle. */
#define GNTST_bad_virt_addr(-5) /* Inappropriate virtual address to map. */
diff --git a/OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
b/OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
index ff8e77589f92..5939610a9616 100644
--- a/OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
+++ b/OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
@@ -270,7 +270,7 @@
* access (even when it should be read-only). If the frontend hits the
* maximum number of allowed persistently mapped grants, it can fallback
* to non persistent mode. This will cause a performance degradation,
- * since the the backend driver will still try to map those grants
+ * since the backend driver will still try to map those grants
* persistently. Since the persistent grants protocol is compatible with
* the previous protocol, a frontend driver can choose to work in
* persistent mode even when the backend doesn't support it.
diff --git a/OvmfPkg/Include/Protocol/XenBus.h
b/OvmfPkg/Include/Protocol/XenBus.h
index 8ff5ca357500..0dac9266280f 100644
--- a/OvmfPkg/Include/Protocol/XenBus.h
+++ b/OvmfPkg/Include/Protocol/XenBus.h
@@ -215,7 +215,7 @@ XENSTORE_STATUS
Grant access to the page Frame to the domain DomainId.
@param This A pointer to XENBUS_PROTOCOL instance.
- @param DomainId ID of the domain to grant acces to.
+ @param DomainId ID of the domain to grant access to.
@param Frame Frame Number of the page to grant access to.
@param ReadOnly Provide read-only or read-write access.
@param RefPtr Reference number of the grant will be written to
[edk2-devel] [PATCH v2 55/78] OvmfPkg/Csm: Fix various typos
From: Antoine Coeur
Fix various typos in documentation, comments and strings.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: David Woodhouse
Signed-off-by: Philippe Mathieu-Daude
---
v2: 'bios' -> 'BIOS' (David Woodhouse)
---
.../LegacyBootMaintUiLib.inf | 2 +-
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 +-
.../BiosThunk/VideoDxe/VesaBiosExtensions.h| 8
OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +-
.../FrameworkInternalFormRepresentation.h | 2 +-
OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +-
OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +++---
.../Csm/Include/Protocol/LegacyBiosPlatform.h | 4 ++--
OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +-
.../Csm/LegacyBiosDxe/LegacyBiosInterface.h| 8
.../LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 ++--
.../LegacyBootMaintUiVfr.h | 2 +-
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 ++--
OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +++---
OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +++---
OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 ++--
OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8
OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 ++--
.../LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++---
OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c| 18 +-
.../LegacyBootMaintUiLib.uni | 8
21 files changed, 62 insertions(+), 62 deletions(-)
diff --git a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
index 5cc64a1b2df2..9a790d34a0e4 100644
--- a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
+++ b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
@@ -1,5 +1,5 @@
## @file
-# Legacy Boot Maintainence UI module is library for BDS phase.
+# Legacy Boot Maintenance UI module is library for BDS phase.
#
# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
b/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
index 951f4e6f768f..d4fe15428bf0 100644
--- a/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
+++ b/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
@@ -241,7 +241,7 @@ BiosVideoCheckForVga (
/**
- Release resource for biso video instance.
+ Release resource for BIOS video instance.
@param BiosVideoPrivate Video child device private data structure
@@ -347,9 +347,9 @@ BiosVideoGraphicsOutputVbeBlt (
/**
- Grahpics Output protocol instance to block transfer for VGA device.
+ Graphics Output protocol instance to block transfer for VGA device.
- @param This Pointer to Grahpics Output protocol instance
+ @param This Pointer to Graphics Output protocol instance
@param BltBuffer The data to transfer to screen
@param BltOperation The operation to perform
@param SourceXThe X coordinate of the source for
BltOperation
@@ -412,7 +412,7 @@ BiosVideoVgaMiniPortSetMode (
/**
Event handler for Exit Boot Service.
- @param Event The event that be siganlled when exiting boot service.
+ @param Event The event that be signalled when exiting boot service.
@param Context Pointer to instance of BIOS_VIDEO_DEV.
**/
@@ -506,7 +506,7 @@ BiosVideoChildHandleUninstall (
);
/**
- Release resource for biso video instance.
+ Release resource for BIOS video instance.
@param BiosVideoPrivate Video child device private data structure
diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
b/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
index dbf706179ff9..88065f15c645 100644
--- a/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
+++ b/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
@@ -250,7 +250,7 @@ typedef struct {
#define VESA_BIOS_EXTENSIONS_VERSION_3_0 0x0300
//
-// Super VGA Information Block Capabilities field bit defintions
+// Super VGA Information Block Capabilities field bit definitions
//
#define VESA_BIOS_EXTENSIONS_CAPABILITY_8_BIT_DAC 0x01 // 0: DAC width is
fixed at 6 bits/color
// 1: DAC width switchable to 8 bits/color
@@ -358,7 +358,7 @@ typedef struct {
} VESA_BIOS_EXTENSIONS_MODE_INFORMATION_BLOCK;
//
-// Super VGA Mode Information Block ModeAttributes field bit defintions
+// Super VGA Mode Information Block ModeAttributes field bit definitions
//
#define VESA_BIOS_EXTENSIONS_MODE_ATTRIBUTE_HARDWARE 0x0001 // 0: Mode not
supported in handware
// 1: Mode supported in handware
@@ -396,7 +396,7 @@ typedef struct {
#define VESA_BIOS_EXTENSIONS_MODE_ATTRIBUTE_DUAL_DISPLAY 0x1000 // 0: No
dual display start address support
// 1: Dual display
[edk2-devel] [PATCH v2 39/78] NetworkPkg/Ip4Dxe: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Ip4Dxe/Ip4Common.h | 14 +++---
NetworkPkg/Ip4Dxe/Ip4Config2Impl.h | 2 +-
NetworkPkg/Ip4Dxe/Ip4Driver.h | 6 +++---
NetworkPkg/Ip4Dxe/Ip4Icmp.h| 8
NetworkPkg/Ip4Dxe/Ip4If.h | 4 ++--
NetworkPkg/Ip4Dxe/Ip4Igmp.h| 2 +-
NetworkPkg/Ip4Dxe/Ip4Impl.h| 8
NetworkPkg/Ip4Dxe/Ip4Input.h | 6 +++---
NetworkPkg/Ip4Dxe/Ip4Output.h | 4 ++--
NetworkPkg/Ip4Dxe/Ip4Route.h | 12 ++--
NetworkPkg/Ip4Dxe/Ip4Common.c | 10 +-
NetworkPkg/Ip4Dxe/Ip4Config2Impl.c | 10 +-
NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 4 ++--
NetworkPkg/Ip4Dxe/Ip4Driver.c | 10 +-
NetworkPkg/Ip4Dxe/Ip4If.c | 14 +++---
NetworkPkg/Ip4Dxe/Ip4Igmp.c| 6 +++---
NetworkPkg/Ip4Dxe/Ip4Impl.c| 14 +++---
NetworkPkg/Ip4Dxe/Ip4Input.c | 28 ++--
NetworkPkg/Ip4Dxe/Ip4Option.c | 2 +-
NetworkPkg/Ip4Dxe/Ip4Output.c | 12 ++--
NetworkPkg/Ip4Dxe/Ip4Route.c | 14 +++---
21 files changed, 95 insertions(+), 95 deletions(-)
diff --git a/NetworkPkg/Ip4Dxe/Ip4Common.h b/NetworkPkg/Ip4Dxe/Ip4Common.h
index 8fbfd5487219..a84602d45ac0 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Common.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Common.h
@@ -23,7 +23,7 @@ typedef struct _IP4_SERVICEIP4_SERVICE;
#define IP4_LINK_PROMISC 0x0004
//
-// IP4 address cast type classfication. Keep it true that any
+// IP4 address cast type classification. Keep it true that any
// type bigger than or equal to LOCAL_BROADCAST is broadcast.
//
#define IP4_PROMISCUOUS 1
@@ -63,13 +63,13 @@ typedef struct _IP4_SERVICEIP4_SERVICE;
#define IP4_IS_BROADCAST(CastType) ((CastType) >= IP4_LOCAL_BROADCAST)
///
-/// Conver the Microsecond to second. IP transmit/receive time is
+/// Convert the Microsecond to second. IP transmit/receive time is
/// in the unit of microsecond. IP ticks once per second.
///
#define IP4_US_TO_SEC(Us) (((Us) + 99) / 100)
/**
- Return the cast type (Unicast/Boradcast) specific to an
+ Return the cast type (Unicast/Broadcast) specific to an
interface. All the addresses are host byte ordered.
@param[in] IpAddrThe IP address to classify in host byte
order
@@ -77,7 +77,7 @@ typedef struct _IP4_SERVICEIP4_SERVICE;
@return The cast type of this IP address specific to the interface.
@retval IP4_LOCAL_HOSTThe IpAddr equals to the interface's address
- @retval IP4_SUBNET_BROADCAST The IpAddr is a directed subnet boradcast to
the
+ @retval IP4_SUBNET_BROADCAST The IpAddr is a directed subnet broadcast to
the
interface
@retval IP4_NET_BROADCAST The IpAddr is a network broadcast to the
interface
@retval 0 Otherwise.
@@ -146,7 +146,7 @@ Ip4FindNet (
Find an interface of the service with the same Ip/Netmask pair.
@param[in] IpSb Ip4 service binding instance
- @param[in] IpThe Ip adress to find (host byte order)
+ @param[in] IpThe Ip address to find (host byte order)
@param[in] Netmask The network to find (host byte order)
@return The IP4_INTERFACE point if found, otherwise NULL
@@ -199,10 +199,10 @@ Ip4NtohHead (
/**
Validate that Ip/Netmask pair is OK to be used as station
address. Only continuous netmasks are supported. and check
- that StationAddress is a unicast address on the newtwork.
+ that StationAddress is a unicast address on the network.
@param[in] Ip The IP address to validate.
- @param[in] NetmaskThe netmaks of the IP.
+ @param[in] NetmaskThe netmask of the IP.
@retval TRUE The Ip/Netmask pair is valid.
@retval FALSE The Ip/Netmask pair is invalid.
diff --git a/NetworkPkg/Ip4Dxe/Ip4Config2Impl.h
b/NetworkPkg/Ip4Dxe/Ip4Config2Impl.h
index 1716dde399ab..0e4639e77c78 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Config2Impl.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Config2Impl.h
@@ -205,7 +205,7 @@ typedef struct {
/**
Read the configuration data from variable storage according to the VarName
and
gEfiIp4Config2ProtocolGuid. It checks the integrity of variable data. If the
- data is corrupted, it clears the variable data to ZERO. Othewise, it outputs
the
+ data is corrupted, it clears the variable data to ZERO. Otherwise, it
outputs the
configuration data to IP4_CONFIG2_INSTANCE.
@param[in] VarName The pointer to the variable name
diff --git a/NetworkPkg/Ip4Dxe/Ip4Driver.h b/NetworkPkg/Ip4Dxe/Ip4Driver.h
index be374715703c..d94bdf3bdec1 100644
---
[edk2-devel] [PATCH v2 35/78] NetworkPkg/DpcDxe: Fix few typos
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/DpcDxe/Dpc.h | 2 +-
NetworkPkg/Include/Protocol/Dpc.h | 2 +-
NetworkPkg/DpcDxe/Dpc.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/NetworkPkg/DpcDxe/Dpc.h b/NetworkPkg/DpcDxe/Dpc.h
index 2017a215e352..a5e6f7b62f90 100644
--- a/NetworkPkg/DpcDxe/Dpc.h
+++ b/NetworkPkg/DpcDxe/Dpc.h
@@ -24,7 +24,7 @@ Abstract:
#include
//
-// Internal data struture for managing DPCs. A DPC entry is either on the free
+// Internal data structure for managing DPCs. A DPC entry is either on the
free
// list or on a DPC queue at a specific EFI_TPL.
//
typedef struct {
diff --git a/NetworkPkg/Include/Protocol/Dpc.h
b/NetworkPkg/Include/Protocol/Dpc.h
index 1e1d0d316d54..5e50f6cf308c 100644
--- a/NetworkPkg/Include/Protocol/Dpc.h
+++ b/NetworkPkg/Include/Protocol/Dpc.h
@@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
}
//
-// Forward reference for pure ANSI compatability
+// Forward reference for pure ANSI compatibility
//
typedef struct _EFI_DPC_PROTOCOL EFI_DPC_PROTOCOL;
diff --git a/NetworkPkg/DpcDxe/Dpc.c b/NetworkPkg/DpcDxe/Dpc.c
index 8a490949dc8c..7c85dd8757c3 100644
--- a/NetworkPkg/DpcDxe/Dpc.c
+++ b/NetworkPkg/DpcDxe/Dpc.c
@@ -28,7 +28,7 @@ EFI_DPC_PROTOCOL mDpc = {
};
//
-// Global variables used to meaasure the DPC Queue Depths
+// Global variables used to measure the DPC Queue Depths
//
UINTN mDpcQueueDepth = 0;
UINTN mMaxDpcQueueDepth = 0;
@@ -42,7 +42,7 @@ UINTN mMaxDpcQueueDepth = 0;
LIST_ENTRY mDpcEntryFreeList =
INITIALIZE_LIST_HEAD_VARIABLE(mDpcEntryFreeList);
//
-// An array of DPC queues. A DPC queue is allocated for every leval EFI_TPL
value.
+// An array of DPC queues. A DPC queue is allocated for every level EFI_TPL
value.
// As DPCs are queued, they are added to the end of the linked list.
// As DPCs are dispatched, they are removed from the beginning of the linked
list.
//
@@ -299,7 +299,7 @@ DpcDispatchDpc (
@param ImageHandleThe image handle of the driver.
@param SystemTableThe system table.
- @retval EFI_SUCCES The DPC queues were initialized and the
EFI_DPC_PROTOCOL was
+ @retval EFI_SUCCESSThe DPC queues were initialized and the
EFI_DPC_PROTOCOL was
installed onto a new handle.
@retval Others Failed to install EFI_DPC_PROTOCOL.
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52769): https://edk2.groups.io/g/devel/message/52769
Mute This Topic: https://groups.io/mt/69395918/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 40/78] NetworkPkg/Ip6Dxe: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h | 4 ++--
NetworkPkg/Ip6Dxe/Ip6Driver.h | 8
NetworkPkg/Ip6Dxe/Ip6If.h | 4 ++--
NetworkPkg/Ip6Dxe/Ip6Impl.h | 8
NetworkPkg/Ip6Dxe/Ip6Input.h | 6 +++---
NetworkPkg/Ip6Dxe/Ip6Mld.h| 2 +-
NetworkPkg/Ip6Dxe/Ip6Nd.h | 4 ++--
NetworkPkg/Ip6Dxe/Ip6Route.h | 10 +-
NetworkPkg/Ip6Dxe/Ip6Common.c | 2 +-
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 10 +-
NetworkPkg/Ip6Dxe/Ip6ConfigNv.c | 6 +++---
NetworkPkg/Ip6Dxe/Ip6Driver.c | 12 ++--
NetworkPkg/Ip6Dxe/Ip6Icmp.c | 2 +-
NetworkPkg/Ip6Dxe/Ip6If.c | 10 +-
NetworkPkg/Ip6Dxe/Ip6Impl.c | 10 +-
NetworkPkg/Ip6Dxe/Ip6Input.c | 20 ++--
NetworkPkg/Ip6Dxe/Ip6Mld.c| 8
NetworkPkg/Ip6Dxe/Ip6Nd.c | 12 ++--
NetworkPkg/Ip6Dxe/Ip6Output.c | 2 +-
NetworkPkg/Ip6Dxe/Ip6Route.c | 6 +++---
20 files changed, 73 insertions(+), 73 deletions(-)
diff --git a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h
b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h
index bfe3bbe53875..1c2eede2ab21 100644
--- a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h
+++ b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h
@@ -1,5 +1,5 @@
/** @file
- Definitions for EFI IPv6 Configuartion Protocol implementation.
+ Definitions for EFI IPv6 Configuration Protocol implementation.
Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
@@ -210,7 +210,7 @@ struct _IP6_CONFIG_INSTANCE {
/**
Read the configuration data from variable storage according to the VarName
and
gEfiIp6ConfigProtocolGuid. It checks the integrity of variable data. If the
- data is corrupted, it clears the variable data to ZERO. Othewise, it outputs
the
+ data is corrupted, it clears the variable data to ZERO. Otherwise, it
outputs the
configuration data to IP6_CONFIG_INSTANCE.
@param[in] VarName The pointer to the variable name
diff --git a/NetworkPkg/Ip6Dxe/Ip6Driver.h b/NetworkPkg/Ip6Dxe/Ip6Driver.h
index b048dafdccc5..007f687c6e25 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Driver.h
+++ b/NetworkPkg/Ip6Dxe/Ip6Driver.h
@@ -66,7 +66,7 @@ Ip6DriverEntryPoint (
);
//
-// Function prototypes for the Drivr Binding Protocol
+// Function prototypes for the Driver Binding Protocol
//
/**
@@ -98,7 +98,7 @@ Ip6DriverBindingSupported (
@param[in] RemainingDevicePath Optional parameter used to pick a specific
child
device to start.
- @retval EFI_SUCCES This driver is added to ControllerHandle.
+ @retval EFI_SUCCESS This driver is added to ControllerHandle.
@retval EFI_ALREADY_STARTED This driver is already running on
ControllerHandle.
@retval other This driver does not support this device.
@@ -147,7 +147,7 @@ Ip6DriverBindingStop (
is not NULL, then the I/O services are added
to
the existing child handle.
- @retval EFI_SUCCES The child handle was created with the I/O
services.
+ @retval EFI_SUCCESSThe child handle was created with the I/O
services.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to
create
the child.
@retval other The child handle was not created.
@@ -166,7 +166,7 @@ Ip6ServiceBindingCreateChild (
@param[in] This Protocol instance pointer.
@param[in] ChildHandleHandle of the child to destroy.
- @retval EFI_SUCCES The I/O services were removed from the child
+ @retval EFI_SUCCESSThe I/O services were removed from the child
handle.
@retval EFI_UNSUPPORTEDThe child handle does not support the I/O
services
that are being removed.
diff --git a/NetworkPkg/Ip6Dxe/Ip6If.h b/NetworkPkg/Ip6Dxe/Ip6If.h
index a8af4322eb93..ab43d8ea592a 100644
--- a/NetworkPkg/Ip6Dxe/Ip6If.h
+++ b/NetworkPkg/Ip6Dxe/Ip6If.h
@@ -1,5 +1,5 @@
/** @file
- Definition for IP6 pesudo interface structure.
+ Definition for IP6 pseudo interface structure.
Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.
@@ -203,7 +203,7 @@ Ip6OnFrameReceived (
@retval EFI_ALREADY_STARTED There is already a pending receive request.
@retval EFI_OUT_OF_RESOURCES Failed to allocate resources to receive.
- @retval EFI_SUCCESS The recieve request has been started.
+ @retval EFI_SUCCESS The receive request has been started.
**/
EFI_STATUS
diff --git a/NetworkPkg/Ip6Dxe/Ip6Impl.h b/NetworkPkg/Ip6Dxe/Ip6Impl.h
index
[edk2-devel] [PATCH v2 37/78] NetworkPkg/HttpBootDxe: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 2 +-
NetworkPkg/HttpBootDxe/HttpBootDhcp6.h | 4 ++--
NetworkPkg/HttpBootDxe/HttpBootDxe.h | 6 +++---
NetworkPkg/HttpBootDxe/HttpBootSupport.h | 10 +-
NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 2 +-
NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 10 +-
NetworkPkg/HttpBootDxe/HttpBootDxe.c | 8
NetworkPkg/HttpBootDxe/HttpBootImpl.c| 2 +-
NetworkPkg/HttpBootDxe/HttpBootSupport.c | 12 ++--
9 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
index 2c2fa28302a3..74bbdac58e86 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
@@ -41,7 +41,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
/// DHCP offer types among HTTP boot.
/// Dhcp4 and Dhcp6 share this definition, and corresponding
-/// relatioinship is as follows:
+/// relationship is as follows:
/// Dhcp4Discover <> Dhcp6Solicit
/// Dhcp4Offer<> Dhcp6Advertise
/// Dhcp4Request <> Dhcp6Request
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
index e21f272aa1ac..e1a652031976 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
@@ -110,8 +110,8 @@ HttpBootDhcp6Sarr (
@param[in] Private The pointer to HTTP_BOOT_PRIVATE_DATA.
- @retval EFI_SUCCESS Switch the IP policy succesfully.
- @retval Others Unexpect error happened.
+ @retval EFI_SUCCESS Switch the IP policy successfully.
+ @retval Others Unexpected error happened.
**/
EFI_STATUS
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDxe.h
b/NetworkPkg/HttpBootDxe/HttpBootDxe.h
index 89b7d6aa702b..0b45f9de0bdb 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDxe.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootDxe.h
@@ -147,7 +147,7 @@ struct _HTTP_BOOT_PRIVATE_DATA {
HTTP_BOOT_VIRTUAL_NIC *Ip6Nic;
//
- // Cousumed children
+ // Consumed children
//
EFI_HANDLEIp6Child;
EFI_HANDLEDhcp4Child;
@@ -348,7 +348,7 @@ HttpBootIp4DxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a
device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a
lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -476,7 +476,7 @@ HttpBootIp6DxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a
device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a
lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.h
b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
index 10f62f6ec31a..81d072ae3734 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootSupport.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
@@ -98,7 +98,7 @@ typedef struct {
/**
Create a HTTP_IO_HEADER to hold the HTTP header items.
- @param[in] MaxHeaderCount The maximun number of HTTP header in this
holder.
+ @param[in] MaxHeaderCount The maximum number of HTTP header in this
holder.
@returnA pointer of the HTTP header holder or NULL if failed.
@@ -109,7 +109,7 @@ HttpBootCreateHeader (
);
/**
- Destroy the HTTP_IO_HEADER and release the resouces.
+ Destroy the HTTP_IO_HEADER and release the resources.
@param[in] HttpIoHeader Point to the HTTP header holder to be
destroyed.
@@ -300,7 +300,7 @@ HttpIoCreateIo (
);
/**
- Destroy the HTTP_IO and release the resouces.
+ Destroy the HTTP_IO and release the resources.
@param[in] HttpIo The HTTP_IO which wraps the HTTP service to be
destroyed.
@@ -320,7 +320,7 @@ HttpIoDestroyIo (
@param[in] BodyLength Length in bytes of the HTTP body.
@param[in] Body Body associated with the HTTP request.
- @retval EFI_SUCCESSThe HTTP request is trasmitted.
+ @retval EFI_SUCCESSThe HTTP request is transmitted.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval
[edk2-devel] [PATCH v2 41/78] NetworkPkg/IScsiDxe: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/IScsiDxe/IScsiMisc.h | 8 +++---
NetworkPkg/IScsiDxe/IScsiProto.h| 10
NetworkPkg/IScsiDxe/ComponentName.c | 2 +-
NetworkPkg/IScsiDxe/IScsiCHAP.c | 4 +--
NetworkPkg/IScsiDxe/IScsiConfig.c | 6 ++---
NetworkPkg/IScsiDxe/IScsiDhcp.c | 4 +--
NetworkPkg/IScsiDxe/IScsiDriver.c | 10
NetworkPkg/IScsiDxe/IScsiMisc.c | 6 ++---
NetworkPkg/IScsiDxe/IScsiProto.c| 40 ++---
9 files changed, 45 insertions(+), 45 deletions(-)
diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.h b/NetworkPkg/IScsiDxe/IScsiMisc.h
index 92f42e140ace..46c725aab3a4 100644
--- a/NetworkPkg/IScsiDxe/IScsiMisc.h
+++ b/NetworkPkg/IScsiDxe/IScsiMisc.h
@@ -46,7 +46,7 @@ typedef struct _ISCSI_SESSION_CONFIG_NVDATA {
UINT8 PrefixLength;
UINT8 BootLun[8];
- UINT16ConnectTimeout; ///< timout value in milliseconds.
+ UINT16ConnectTimeout; ///< timeout value in milliseconds.
UINT8 ConnectRetryCount;
UINT8 IsId[6];
@@ -104,7 +104,7 @@ IScsiLunToUnicodeStr (
);
/**
- Convert the mac address into a hexadecimal encoded "-" seperated string.
+ Convert the mac address into a hexadecimal encoded "-" separated string.
@param[in] Mac The mac address.
@param[in] Len Length in bytes of the mac address.
@@ -352,7 +352,7 @@ IScsiCreateDriverData (
@param[in] Private The iSCSI driver data.
- @retval EFI_SUCCES The clean operation is successful.
+ @retval EFI_SUCCESS The clean operation is successful.
@retval Others Other errors as indicated.
**/
@@ -439,7 +439,7 @@ IScsiOnExitBootService (
This function tests whether the driver specified by DriverBindingHandle is
currently managing the controller specified by ControllerHandle. This test
- is performed by evaluating if the the protocol specified by ProtocolGuid is
+ is performed by evaluating if the protocol specified by ProtocolGuid is
present on ControllerHandle and is was opened by DriverBindingHandle and Nic
Device handle with an attribute of EFI_OPEN_PROTOCOL_BY_DRIVER.
If ProtocolGuid is NULL, then ASSERT().
diff --git a/NetworkPkg/IScsiDxe/IScsiProto.h b/NetworkPkg/IScsiDxe/IScsiProto.h
index 34b682b68df1..3b8e66221524 100644
--- a/NetworkPkg/IScsiDxe/IScsiProto.h
+++ b/NetworkPkg/IScsiDxe/IScsiProto.h
@@ -308,7 +308,7 @@ typedef struct _ISCSI_SENSE_DATA {
} ISCSI_SENSE_DATA;
///
-/// iSCSI Task Managment Function Request.
+/// iSCSI Task Management Function Request.
///
typedef struct _ISCSI_TMF_REQUEST {
UINT8 OpCode;
@@ -870,7 +870,7 @@ IScsiReceivePdu (
@param[in, out] Conn The connection in iSCSI login.
- @retval EFI_SUCCESS The parmeter check is passed and negotiation is
finished.
+ @retval EFI_SUCCESS The parameter check is passed and negotiation
is finished.
@retval EFI_PROTOCOL_ERROR Some kind of iSCSI protocol error occurred.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
@@ -897,7 +897,7 @@ IScsiFillOpParams (
Pad the iSCSI AHS or data segment to an integer number of 4 byte words.
@param[in, out] Pdu The iSCSI pdu which contains segments to pad.
- @param[in] Len The length of the last semgnet in the PDU.
+ @param[in] Len The length of the last segment in the PDU.
@retval EFI_SUCCESS The segment is padded or no need to pad it.
@retval EFI_OUT_OF_RESOURCES There is not enough remaining free space to add
the
@@ -978,7 +978,7 @@ IScsiNormalizeName (
@param[in, out] PacketThe request packet containing IO request, SCSI
command
buffer and buffers to read/write.
- @retval EFI_SUCCES The SCSI command is executed and the result is
updated to
+ @retval EFI_SUCCESS The SCSI command is executed and the result is
updated to
the Packet.
@retval EFI_DEVICE_ERROR Session state was not as required.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
@@ -999,7 +999,7 @@ IScsiExecuteScsiCommand (
@param[in] Session The iSCSI session
- @retval EFI_SUCCESThe session is reinstated from some error.
+ @retval EFI_SUCCESS The session is reinstated from some error.
@retval Other Reinstatement failed.
**/
diff --git a/NetworkPkg/IScsiDxe/ComponentName.c
b/NetworkPkg/IScsiDxe/ComponentName.c
index 77e6f3858a29..8572ac281d1d 100644
--- a/NetworkPkg/IScsiDxe/ComponentName.c
+++ b/NetworkPkg/IScsiDxe/ComponentName.c
@@ -249,7 +249,7 @@ IScsiComponentNameGetControllerName (
}
//
- // Get the handle of the controller we are
[edk2-devel] [PATCH v2 38/78] NetworkPkg/HttpDxe: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/HttpDxe/HttpDriver.h | 8 NetworkPkg/HttpDxe/HttpProto.h| 16 NetworkPkg/HttpDxe/HttpsSupport.h | 2 +- NetworkPkg/HttpDxe/HttpDriver.c | 12 ++-- NetworkPkg/HttpDxe/HttpImpl.c | 10 +- NetworkPkg/HttpDxe/HttpProto.c| 22 +++--- NetworkPkg/HttpDxe/HttpsSupport.c | 2 +- 7 files changed, 36 insertions(+), 36 deletions(-) diff --git a/NetworkPkg/HttpDxe/HttpDriver.h b/NetworkPkg/HttpDxe/HttpDriver.h index bd6f658f3c24..5fe8c5b5e9b9 100644 --- a/NetworkPkg/HttpDxe/HttpDriver.h +++ b/NetworkPkg/HttpDxe/HttpDriver.h @@ -172,7 +172,7 @@ HttpDxeIp4DriverBindingSupported ( @retval EFI_SUCCESS The device was started. @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented. @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources. - @retval Others The driver failded to start the device. + @retval Others The driver failed to start the device. **/ EFI_STATUS @@ -301,7 +301,7 @@ HttpDxeIp6DriverBindingSupported ( @retval EFI_ALREADY_STARTED This device is already running on ControllerHandle. @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented. @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources. - @retval Others The driver failded to start the device. + @retval Others The driver failed to start the device. **/ EFI_STATUS @@ -359,7 +359,7 @@ HttpDxeIp6DriverBindingStop ( then a new handle is created. If it is a pointer to an existing UEFI handle, then the protocol is added to the existing UEFI handle. - @retval EFI_SUCCESThe protocol was added to ChildHandle. + @retval EFI_SUCCESS The protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER This is NULL, or ChildHandle is NULL. @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create the child. @@ -383,7 +383,7 @@ HttpServiceBindingCreateChild ( @param ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance. @param ChildHandle Handle of the child to destroy - @retval EFI_SUCCESThe protocol was removed from ChildHandle. + @retval EFI_SUCCESS The protocol was removed from ChildHandle. @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed. @retval EFI_INVALID_PARAMETER Child handle is NULL. @retval other The child handle was not destroyed diff --git a/NetworkPkg/HttpDxe/HttpProto.h b/NetworkPkg/HttpDxe/HttpProto.h index 34308e016d3e..00ba26aca49a 100644 --- a/NetworkPkg/HttpDxe/HttpProto.h +++ b/NetworkPkg/HttpDxe/HttpProto.h @@ -308,7 +308,7 @@ HttpCloseTcpRxEvent ( ); /** - Intiialize the HTTP_PROTOCOL structure to the unconfigured state. + Initialize the HTTP_PROTOCOL structure to the unconfigured state. @param[in, out] HttpInstance Pointer to HTTP_PROTOCOL structure. @param[in] IpVersionIndicate us TCP4 protocol or TCP6 protocol. @@ -453,7 +453,7 @@ HttpTransmitTcp ( @param[in] MapThe container of either user's transmit or receive token. @param[in] Item Current item to check against. - @param[in] ContextThe Token to check againist. + @param[in] ContextThe Token to check against. @retval EFI_ACCESS_DENIED The token or event has already been enqueued in IP @retval EFI_SUCCESSThe current item isn't the same token/event as the @@ -473,7 +473,7 @@ HttpTokenExist ( @param[in] MapThe container of TxToken. @param[in] Item Current item to check against. - @param[in] ContextThe Token to check againist. + @param[in] ContextThe Token to check against. @retval EFI_NOT_READY The HTTP message is still queued in the list. @retval EFI_SUCCESSThe HTTP message has been sent out. @@ -508,11 +508,11 @@ HttpInitSession ( ); /** - Transmit the HTTP or HTTPS mssage by processing the associated HTTP token. + Transmit the HTTP or HTTPS message by processing the associated HTTP token. @param[in] MapThe container of TxToken or Tx6Token. @param[in] Item Current item to check against. - @param[in] ContextThe Token to check againist. + @param[in] Context
[edk2-devel] [PATCH v2 33/78] NetworkPkg/DnsDxe: Fix a typo
Fix the same typo in various comments.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/DnsDxe/DnsImpl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c
index ca4ef506a08a..4c232740be3f 100644
--- a/NetworkPkg/DnsDxe/DnsImpl.c
+++ b/NetworkPkg/DnsDxe/DnsImpl.c
@@ -1179,7 +1179,7 @@ ParseDnsResponse (
RemainingLength = Length;
//
- // Check whether the remaining packet length is avaiable or not.
+ // Check whether the remaining packet length is available or not.
//
if (RemainingLength <= sizeof (DNS_HEADER)) {
*Completed = FALSE;
@@ -1217,7 +1217,7 @@ ParseDnsResponse (
QueryNameLen = (UINT32) AsciiStrLen (QueryName) + 1;
//
- // Check whether the remaining packet length is avaiable or not.
+ // Check whether the remaining packet length is available or not.
//
if (RemainingLength <= QueryNameLen + sizeof (DNS_QUERY_SECTION)) {
*Completed = FALSE;
@@ -1376,7 +1376,7 @@ ParseDnsResponse (
//
while (AnswerSectionNum < DnsHeader->AnswersNum) {
//
-// Check whether the remaining packet length is avaiable or not.
+// Check whether the remaining packet length is available or not.
//
if (RemainingLength <= sizeof (UINT16) + sizeof (DNS_ANSWER_SECTION)) {
*Completed = FALSE;
@@ -1404,7 +1404,7 @@ ParseDnsResponse (
AnswerSection->DataLength = NTOHS (AnswerSection->DataLength);
//
-// Check whether the remaining packet length is avaiable or not.
+// Check whether the remaining packet length is available or not.
//
if (RemainingLength < AnswerSection->DataLength) {
*Completed = FALSE;
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52767): https://edk2.groups.io/g/devel/message/52767
Mute This Topic: https://groups.io/mt/69395736/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 31/78] NetworkPkg/Dhcp4Dxe: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h | 4 ++--
NetworkPkg/Dhcp4Dxe/Dhcp4Io.h | 2 +-
NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 18 +-
NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c | 8
NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c | 6 +++---
NetworkPkg/Dhcp4Dxe/Dhcp4Io.c | 12 ++--
NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 26 +-
7 files changed, 38 insertions(+), 38 deletions(-)
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
index cebde20dca5b..f6370582cbd1 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
@@ -104,7 +104,7 @@ Dhcp4DriverBindingStop (
then a new handle is created. If it is a pointer to an
existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCESThe protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to
create
the child
@@ -128,7 +128,7 @@ Dhcp4ServiceBindingCreateChild (
@param ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCESThe protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that
is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the
ChildHandle
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
index 01283e5e17b9..0dd6b46b87d0 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
@@ -108,7 +108,7 @@ DhcpSendMessage (
/**
Each DHCP service has three timer. Two of them are count down timer.
One for the packet retransmission. The other is to collect the offers.
- The third timer increaments the lease life which is compared to T1, T2,
+ The third timer increments the lease life which is compared to T1, T2,
and lease to determine the time to renew and rebind the lease.
DhcpOnTimerTick will be called once every second.
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
index 393176c8996d..a58bb1b0baa8 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
@@ -81,9 +81,9 @@ typedef struct {
///
/// Structure used to describe and validate the format of DHCP options.
/// Type is the options' data type, such as DHCP_OPTION_INT8. MinOccur
-/// is the minium occurance of this data type. MaxOccur is defined
+/// is the minimum occurrence of this data type. MaxOccur is defined
/// similarly. If MaxOccur is -1, it means that there is no limit on the
-/// maximum occurance. Alert tells whether DHCP client should further
+/// maximum occurrence. Alert tells whether DHCP client should further
/// inspect the option to parse DHCP_PARAMETER.
///
typedef struct {
@@ -114,8 +114,8 @@ EFI_STATUS
found
@param[in] ContextThe opaque parameter for Check
- @retval EFI_SUCCESSThe DHCP packet's options are well formated
- @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well
formated
+ @retval EFI_SUCCESSThe DHCP packet's options are well formatted
+ @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well
formatted
**/
EFI_STATUS
@@ -133,7 +133,7 @@ DhcpIterateOptions (
@param[out] Para The variable to save the DHCP parameters.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the
packet.
- @retval EFI_INVALID_PARAMETER The options are malformatted
+ @retval EFI_INVALID_PARAMETER The options are mal-formatted
@retval EFI_SUCCESSThe options are parsed into OptionPoint
**/
@@ -146,8 +146,8 @@ DhcpValidateOptions (
/**
Parse the options of a DHCP packet. It supports RFC 3396: Encoding
Long Options in DHCP. That is, it will combine all the option value
- of all the occurances of each option.
- A little bit of implemenation:
+ of all the occurrences of each option.
+ A little bit of implementation:
It adopts the "Key indexed counting" algorithm. First, it allocates
an array of 256 DHCP_OPTION_COUNTs because DHCP option tag is encoded
as a UINT8. It then iterates the DHCP packet to get data length of
@@ -167,7 +167,7 @@ DhcpValidateOptions (
@retval
[edk2-devel] [PATCH v2 24/78] MdePkg/Library/Dxe: Fix various typos
From: Antoine Coeur Fix various typos in documentation, comments and strings, and remove the duplicated 'the'. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Michael D Kinney Signed-off-by: Philippe Mathieu-Daude --- MdePkg/Library/DxePcdLib/DxePcdLib.inf | 2 +- MdePkg/Include/Library/DxeServicesLib.h | 2 +- .../DxeExtractGuidedSectionLib.c | 10 +- MdePkg/Library/DxeHobLib/HobLib.c| 2 +- MdePkg/Library/DxeIoLibCpuIo2/IoLib.c| 2 +- .../Library/DxeRuntimePciExpressLib/PciExpressLib.c | 6 +++--- MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 12 ++-- .../DxeServicesTableLib/DxeServicesTableLib.c| 2 +- MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c | 2 +- MdePkg/Library/DxePcdLib/DxePcdLib.uni | 2 +- 10 files changed, 21 insertions(+), 21 deletions(-) diff --git a/MdePkg/Library/DxePcdLib/DxePcdLib.inf b/MdePkg/Library/DxePcdLib/DxePcdLib.inf index c3f67543a4b7..3d4d21b442b4 100644 --- a/MdePkg/Library/DxePcdLib/DxePcdLib.inf +++ b/MdePkg/Library/DxePcdLib/DxePcdLib.inf @@ -16,7 +16,7 @@ # Note: A driver of type DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER can only use this DxePcdLib # in their initialization without any issues to access Dynamic and DynamicEx PCD. They can't # access Dynamic and DynamicEx PCD in the implementation of runtime services and SMI handlers. -# Because EFI_PCD_PROTOCOL is DXE protocol that is not aviable in OS runtime phase. +# Because EFI_PCD_PROTOCOL is DXE protocol that is not available in OS runtime phase. # # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. # diff --git a/MdePkg/Include/Library/DxeServicesLib.h b/MdePkg/Include/Library/DxeServicesLib.h index 838abf356fdd..689f47a54fa1 100644 --- a/MdePkg/Include/Library/DxeServicesLib.h +++ b/MdePkg/Include/Library/DxeServicesLib.h @@ -171,7 +171,7 @@ GetSectionFromFv ( /** - Searches the FFS file the the currently executing module was loaded from and returns the first matching FFS section. + Searches the FFS file the currently executing module was loaded from and returns the first matching FFS section. This function searches the FFS file that the currently executing module was loaded from for a FFS sections of type SectionType. If the FFS file contains at least SectionInstance instances of the FFS section specified by SectionType, diff --git a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c index 4dfe450be9bc..ef730ec55159 100644 --- a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c +++ b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c @@ -150,7 +150,7 @@ ExtractGuidedSectionGetGuidList ( If GetInfoHandler is NULL, then ASSERT(). If DecodeHandler is NULL, then ASSERT(). - @param[in] SectionGuidA pointer to the GUID associated with the the handlers + @param[in] SectionGuidA pointer to the GUID associated with the handlers of the GUIDed section type being registered. @param[in] GetInfoHandler The pointer to a function that examines a GUIDed section and returns the size of the decoded buffer and the size of an optional scratch buffer @@ -231,9 +231,9 @@ ExtractGuidedSectionRegisterHandlers ( Examines a GUIDed section specified by InputSection. If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(), then RETURN_UNSUPPORTED is returned. - If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler + If the GUID of InputSection does match the GUID that this handler supports, then the associated handler of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER that was registered with ExtractGuidedSectionRegisterHandlers() - is used to retrieve the OututBufferSize, ScratchSize, and Attributes values. The return status from the handler of + is used to retrieve the OutputBufferSize, ScratchSize, and Attributes values. The return status from the handler of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER is returned. If InputSection is NULL, then ASSERT(). @@ -311,7 +311,7 @@ ExtractGuidedSectionGetInfo ( Decodes the GUIDed section specified by InputSection. If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(), then RETURN_UNSUPPORTED is returned. - If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler + If the GUID of InputSection does match the GUID that this handler supports, then the associated handler of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER that was registered with
[edk2-devel] [PATCH v2 34/78] NetworkPkg/DnsDxe: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/DnsDxe/DnsDriver.h | 12 ++--
NetworkPkg/DnsDxe/DnsImpl.h | 28 ++--
NetworkPkg/DnsDxe/DnsDriver.c | 12 ++--
NetworkPkg/DnsDxe/DnsImpl.c | 20 ++--
NetworkPkg/DnsDxe/DnsProtocol.c | 16
5 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/NetworkPkg/DnsDxe/DnsDriver.h b/NetworkPkg/DnsDxe/DnsDriver.h
index 471b1134ddb3..67365ca81a1b 100644
--- a/NetworkPkg/DnsDxe/DnsDriver.h
+++ b/NetworkPkg/DnsDxe/DnsDriver.h
@@ -318,7 +318,7 @@ Dns4DriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a
device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a
lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -446,7 +446,7 @@ Dns6DriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a
device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a
lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -504,7 +504,7 @@ Dns6DriverBindingStop (
then a new handle is created. If it is a pointer to
an existing UEFI handle,
then the protocol is added to the existing UEFI
handle.
- @retval EFI_SUCCESThe protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to
create
the child
@@ -528,7 +528,7 @@ Dns4ServiceBindingCreateChild (
@param[in] ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy
- @retval EFI_SUCCESThe protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that
is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the
ChildHandle
@@ -555,7 +555,7 @@ Dns4ServiceBindingDestroyChild (
then a new handle is created. If it is a pointer to
an existing UEFI handle,
then the protocol is added to the existing UEFI
handle.
- @retval EFI_SUCCESThe protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to
create
the child
@@ -579,7 +579,7 @@ Dns6ServiceBindingCreateChild (
@param[in] ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy
- @retval EFI_SUCCESThe protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that
is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the
ChildHandle
diff --git a/NetworkPkg/DnsDxe/DnsImpl.h b/NetworkPkg/DnsDxe/DnsImpl.h
index fdab9c75e3f3..10bc399e9ed5 100644
--- a/NetworkPkg/DnsDxe/DnsImpl.h
+++ b/NetworkPkg/DnsDxe/DnsImpl.h
@@ -182,7 +182,7 @@ typedef struct {
@param[in] TokenMap All DNSv4 Token entrys.
@param[in] TokenEntryTokenEntry need to be removed.
- @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
+ @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
@retval EFI_NOT_FOUNDTokenEntry is not found in TokenMap.
**/
@@ -198,7 +198,7 @@ Dns4RemoveTokenEntry (
@param[in] TokenMap All DNSv6 Token entrys.
@param[in] TokenEntry TokenEntry need to be removed.
- @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
+ @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
@retval EFI_NOT_FOUND
[edk2-devel] [PATCH v2 32/78] NetworkPkg/Dhcp6Dxe: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h | 4 ++-- NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h | 12 ++-- NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c | 12 ++-- NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c| 12 ++-- NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 26 +- NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 16 6 files changed, 41 insertions(+), 41 deletions(-) diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h index a609eddf2474..1b8744b9b8d2 100644 --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h @@ -108,7 +108,7 @@ Dhcp6DriverBindingStop ( then a new handle is created. If it is a pointer to an existing UEFI handle, then the protocol is added to the existing UEFI handle. - @retval EFI_SUCCESThe protocol was added to ChildHandle. + @retval EFI_SUCCESS The protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER ChildHandle is NULL. @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create the child. @@ -132,7 +132,7 @@ Dhcp6ServiceBindingCreateChild ( @param ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance. @param ChildHandle Handle of the child to destroy. - @retval EFI_SUCCESThe protocol was removed from ChildHandle. + @retval EFI_SUCCESS The protocol was removed from ChildHandle. @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed. @retval EFI_INVALID_PARAMETER Child handle is NULL. @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h index 6a302adf2944..2f18eb360957 100644 --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h @@ -71,7 +71,7 @@ Dhcp6CleanupModeData ( @param[in] Base The base value of the time. @param[in] IsFirstRt If TRUE, it is the first time to calculate expire time. - @param[in] NeedSignedIf TRUE, the the signed factor is needed. + @param[in] NeedSignedIf TRUE, the signed factor is needed. @return ExpireThe calculated result for the new expire time. @@ -165,7 +165,7 @@ Dhcp6OnTransmitted ( @param[in, out] Buf The pointer to buffer. @param[in] OptType The option type. - @param[in] OptLenThe lenght of option content.s + @param[in] OptLenThe length of option content.s @param[in] Data The pointer to the option content. @return Buf The position to append the next option. @@ -270,7 +270,7 @@ Dhcp6SeekIaOption ( /** Parse the address option and update the address info. - @param[in] CurrentIa The pointer to the Ia Address in control blcok. + @param[in] CurrentIa The pointer to the Ia Address in control block. @param[in] IaInnerOptThe pointer to the buffer. @param[in] IaInnerLenThe length to parse. @param[out] AddrNum The number of addresses. @@ -287,7 +287,7 @@ Dhcp6ParseAddrOption ( ); /** - Create a control blcok for the Ia according to the corresponding options. + Create a control block for the Ia according to the corresponding options. @param[in] Instance The pointer to DHCP6 Instance. @param[in] IaInnerOptThe pointer to the inner options in the Ia option. @@ -327,7 +327,7 @@ Dhcp6CacheIa ( /** - Append CacheIa to the currrent IA. Meanwhile, clear CacheIa.ValidLifetime to 0. + Append CacheIa to the current IA. Meanwhile, clear CacheIa.ValidLifetime to 0. @param[in] InstanceThe pointer to DHCP6 instance. @@ -338,7 +338,7 @@ Dhcp6AppendCacheIa ( ); /** - Calculate the Dhcp6 get mapping timeout by adding additinal delay to the IP6 DAD transmits count. + Calculate the Dhcp6 get mapping timeout by adding additional delay to the IP6 DAD transmits count. @param[in] Ip6Cfg The pointer to Ip6 config protocol. @param[out] TimeOut The time out value in 100ns units. diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c index 2ffdba73a563..f0b236835f86 100644 --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c @@ -1,6 +1,6 @@ /** @file Driver Binding functions and Service Binding functions - implementationfor for Dhcp6 Driver. + implementation for Dhcp6 Driver. Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. @@ -300,7 +300,7 @@ Dhcp6CreateInstance ( //
[edk2-devel] [PATCH v2 22/78] MdeModulePkg/Usb: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 2 +-
MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 10 +-
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 2 +-
MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 8
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 6 +++---
8 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
index 266581b80995..e06e2533a776 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
@@ -1,5 +1,5 @@
/** @file
-Common Libarary for PEI USB.
+Common Library for PEI USB.
Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
index 65819e43e6bd..852e43390d81 100644
--- a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
+++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
@@ -377,7 +377,7 @@ UsbKeyboardComponentNameGetControllerName (
// Functions of Simple Text Input Protocol
//
/**
- Reset the input device and optionaly run diagnostics
+ Reset the input device and optionally run diagnostics
There are 2 types of reset for USB keyboard.
For non-exhaustive reset, only keyboard buffer is cleared.
@@ -406,8 +406,8 @@ USBKeyboardReset (
information for the key that was pressed.
@retval EFI_SUCCESS The keystroke information was returned.
- @retval EFI_NOT_READYThere was no keystroke data availiable.
- @retval EFI_DEVICE_ERROR The keydtroke information was not returned due
to
+ @retval EFI_NOT_READYThere was no keystroke data available.
+ @retval EFI_DEVICE_ERROR The keystroke information was not returned due
to
hardware errors.
**/
@@ -507,7 +507,7 @@ USBKeyboardSetState (
@param NotifyHandlePoints to the unique handle assigned to
the registered notification.
@retval EFI_SUCCESS The notification function was registered
successfully.
- @retval EFI_OUT_OF_RESOURCESUnable to allocate resources for
necesssary data structures.
+ @retval EFI_OUT_OF_RESOURCESUnable to allocate resources for
necessary data structures.
@retval EFI_INVALID_PARAMETER KeyData or NotifyHandle or
KeyNotificationFunction is NULL.
**/
@@ -574,7 +574,7 @@ KbdFreeNotifyList (
@param InputData A pointer to keystroke data for the key that was
pressed.
@retval TRUE Key pressed matches a registered key.
- @retval FLASE Key pressed does not matche a registered key.
+ @retval FALSE Key pressed does not match a registered key.
**/
BOOLEAN
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
index 601fdd0c92e2..811f136b65b2 100644
--- a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
+++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
@@ -108,7 +108,7 @@ ReleaseKeyboardLayoutResources (
This function is the handler function for USB keyboard's asynchronous
interrupt transfer
to manage the keyboard. It parses the USB keyboard input report, and inserts
data to
- keyboard buffer according to state of modifer keys and normal keys. Timer
for repeat key
+ keyboard buffer according to state of modifier keys and normal keys. Timer
for repeat key
is also set accordingly.
@param Data A pointer to a buffer that is filled with key data
which is
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
b/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
index 5c071c661a45..2b1ca20a6314 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
@@ -192,7 +192,7 @@ BotDataPhase (
TransferredSize = 0;
//
- // retrieve the the max packet length of the given endpoint
+ // retrieve the max packet length of the given endpoint
//
if (Direction == EfiUsbDataIn) {
MaxPacketLen = (PeiBotDev->BulkInEndpoint)->MaxPacketSize;
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
index 9e6e748845d4..41f782a78bf9 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
@@ -1,5 +1,5 @@
/** @file
-Pei USB ATATPI command implementations.
+Pei USB ATAPI command implementations.
Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
index
[edk2-devel] [PATCH v2 25/78] MdePkg/Library/Pci: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Michael D Kinney Signed-off-by: Philippe Mathieu-Daude --- MdePkg/Include/Library/PciCf8Lib.h| 4 ++-- MdePkg/Include/Library/PciExpressLib.h| 4 ++-- MdePkg/Include/Library/PciLib.h | 4 ++-- MdePkg/Include/Library/PciSegmentLib.h| 4 ++-- .../PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c| 2 +- MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/MdePkg/Include/Library/PciCf8Lib.h b/MdePkg/Include/Library/PciCf8Lib.h index 41558dabddc2..7e22a527a80e 100644 --- a/MdePkg/Include/Library/PciCf8Lib.h +++ b/MdePkg/Include/Library/PciCf8Lib.h @@ -1027,7 +1027,7 @@ PciCf8BitFieldAndThenOr32 ( Size into the buffer specified by Buffer. This function only allows the PCI configuration registers from a single PCI function to be read. Size is returned. When possible 32-bit PCI configuration read cycles are used to read - from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit + from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit and 16-bit PCI configuration read cycles may be used at the beginning and the end of the range. @@ -1060,7 +1060,7 @@ PciCf8ReadBuffer ( Size from the buffer specified by Buffer. This function only allows the PCI configuration registers from a single PCI function to be written. Size is returned. When possible 32-bit PCI configuration write cycles are used to - write from StartAdress to StartAddress + Size. Due to alignment restrictions, + write from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit and 16-bit PCI configuration write cycles may be used at the beginning and the end of the range. diff --git a/MdePkg/Include/Library/PciExpressLib.h b/MdePkg/Include/Library/PciExpressLib.h index aec2b5f3777d..826fdcf7db6c 100644 --- a/MdePkg/Include/Library/PciExpressLib.h +++ b/MdePkg/Include/Library/PciExpressLib.h @@ -997,7 +997,7 @@ PciExpressBitFieldAndThenOr32 ( Size into the buffer specified by Buffer. This function only allows the PCI configuration registers from a single PCI function to be read. Size is returned. When possible 32-bit PCI configuration read cycles are used to read - from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit + from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit and 16-bit PCI configuration read cycles may be used at the beginning and the end of the range. @@ -1029,7 +1029,7 @@ PciExpressReadBuffer ( Size from the buffer specified by Buffer. This function only allows the PCI configuration registers from a single PCI function to be written. Size is returned. When possible 32-bit PCI configuration write cycles are used to - write from StartAdress to StartAddress + Size. Due to alignment restrictions, + write from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit and 16-bit PCI configuration write cycles may be used at the beginning and the end of the range. diff --git a/MdePkg/Include/Library/PciLib.h b/MdePkg/Include/Library/PciLib.h index 7a7d42050f0a..836494b6c1d7 100644 --- a/MdePkg/Include/Library/PciLib.h +++ b/MdePkg/Include/Library/PciLib.h @@ -997,7 +997,7 @@ PciBitFieldAndThenOr32 ( Size into the buffer specified by Buffer. This function only allows the PCI configuration registers from a single PCI function to be read. Size is returned. When possible 32-bit PCI configuration read cycles are used to read - from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit + from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit and 16-bit PCI configuration read cycles may be used at the beginning and the end of the range. @@ -1029,7 +1029,7 @@ PciReadBuffer ( Size from the buffer specified by Buffer. This function only allows the PCI configuration registers from a single PCI function to be written. Size is returned. When possible 32-bit PCI configuration write cycles are used to - write from StartAdress to StartAddress + Size. Due to alignment restrictions, + write from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit and 16-bit PCI configuration write cycles may be used at the beginning and the end of the range. diff --git a/MdePkg/Include/Library/PciSegmentLib.h b/MdePkg/Include/Library/PciSegmentLib.h index bd31f05a23fe..fcd98dbfd8df 100644 --- a/MdePkg/Include/Library/PciSegmentLib.h +++ b/MdePkg/Include/Library/PciSegmentLib.h @@ -984,7 +984,7 @@ PciSegmentBitFieldAndThenOr32 ( Size into the buffer specified by Buffer. This function
[edk2-devel] [PATCH v2 30/78] NetworkPkg/ArpDxe: Fix various typos
From: Antoine Coeur Fix various typos in documentation, comments and debug strings. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/ArpDxe/ArpDriver.h | 10 +- NetworkPkg/ArpDxe/ArpImpl.h | 14 +++--- NetworkPkg/ArpDxe/ArpDriver.c | 14 +++--- NetworkPkg/ArpDxe/ArpImpl.c | 16 NetworkPkg/ArpDxe/ArpMain.c | 10 +- 5 files changed, 32 insertions(+), 32 deletions(-) diff --git a/NetworkPkg/ArpDxe/ArpDriver.h b/NetworkPkg/ArpDxe/ArpDriver.h index 0b5b06ee37d5..7dbc1c187820 100644 --- a/NetworkPkg/ArpDxe/ArpDriver.h +++ b/NetworkPkg/ArpDxe/ArpDriver.h @@ -30,7 +30,7 @@ extern EFI_COMPONENT_NAME_PROTOCOLgArpComponentName; extern EFI_COMPONENT_NAME2_PROTOCOL gArpComponentName2; // -// Function prototypes for the Drivr Binding Protocol +// Function prototypes for the Driver Binding Protocol // /** Tests to see if this driver supports a given controller. @@ -55,7 +55,7 @@ extern EFI_COMPONENT_NAME2_PROTOCOL gArpComponentName2; @retval EFI_ACCESS_DENIEDThe device specified by ControllerHandle and RemainingDevicePath is already being managed by a different driver or an application that - requires exclusive acces. Currently not implemented. + requires exclusive access. Currently not implemented. @retval EFI_UNSUPPORTED The device specified by ControllerHandle and RemainingDevicePath is not supported by the driver specified by This. @@ -97,7 +97,7 @@ ArpDriverBindingSupported ( Currently not implemented. @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources. - @retval Others The driver failded to start the device. + @retval Others The driver failed to start the device. **/ EFI_STATUS @@ -159,7 +159,7 @@ ArpDriverBindingStop ( then a new handle is created. If it is a pointer to an existing UEFI handle, then the protocol is added to the existing UEFI handle. - @retval EFI_SUCCESThe protocol was added to ChildHandle. + @retval EFI_SUCCESS The protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER ChildHandle is NULL. @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create the child @@ -183,7 +183,7 @@ ArpServiceBindingCreateChild ( @param ThisPointer to the EFI_SERVICE_BINDING_PROTOCOL instance. @param ChildHandle Handle of the child to destroy - @retval EFI_SUCCESThe protocol was removed from ChildHandle. + @retval EFI_SUCCESS The protocol was removed from ChildHandle. @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed. @retval EFI_INVALID_PARAMETER Child handle is NULL. diff --git a/NetworkPkg/ArpDxe/ArpImpl.h b/NetworkPkg/ArpDxe/ArpImpl.h index 47eedc1cb6f7..506f3e6ef61e 100644 --- a/NetworkPkg/ArpDxe/ArpImpl.h +++ b/NetworkPkg/ArpDxe/ArpImpl.h @@ -436,7 +436,7 @@ ArpRequest ( If the request is in the internal ARP request queue, the request is aborted immediately and its ResolvedEvent is signaled. Only an asynchronous address - request needs to be canceled. If TargeSwAddress and ResolveEvent are both + request needs to be canceled. If TargetSwAddress and ResolvedEvent are both NULL, all the pending asynchronous requests that have been issued by This instance will be cancelled and their corresponding events will be signaled. @@ -599,7 +599,7 @@ ArpDeleteCacheEntry ( ); /** - Send out an arp frame using the CachEntry and the ArpOpCode. + Send out an arp frame using the CacheEntry and the ArpOpCode. @param[in] Instance Pointer to the instance context data. @param[in] CacheEntry Pointer to the configuration data used to @@ -636,7 +636,7 @@ ArpInitInstance ( /** Process the Arp packets received from Mnp, the procedure conforms to RFC826. - @param[in] ContextPointer to the context data registerd to the + @param[in] ContextPointer to the context data registered to the Event. @return None. @@ -652,7 +652,7 @@ ArpOnFrameRcvdDpc ( Queue ArpOnFrameRcvdDpc as a DPC at TPL_CALLBACK. @param[in] Event The Event this notify function registered to. - @param[in] ContextPointer to the context data registerd to the + @param[in] ContextPointer to the context data registered to the
[edk2-devel] [PATCH v2 26/78] MdePkg/Library/Smm: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Michael D Kinney Signed-off-by: Philippe Mathieu-Daude --- MdePkg/Include/Library/SmmLib.h | 4 +- MdePkg/Include/Library/SmmMemLib.h| 4 +- MdePkg/Include/Library/SmmPeriodicSmiLib.h| 6 +-- MdePkg/Library/SmmMemLib/SmmMemLib.c | 4 +- .../Library/SmmPciExpressLib/PciExpressLib.c | 4 +- .../Library/SmmPciLibPciRootBridgeIo/PciLib.c | 6 +-- .../SmmPeriodicSmiLib/SmmPeriodicSmiLib.c | 42 +-- .../SmmServicesTableLib/SmmServicesTableLib.c | 2 +- 8 files changed, 36 insertions(+), 36 deletions(-) diff --git a/MdePkg/Include/Library/SmmLib.h b/MdePkg/Include/Library/SmmLib.h index 8d83df7fd737..bcb7045c1b65 100644 --- a/MdePkg/Include/Library/SmmLib.h +++ b/MdePkg/Include/Library/SmmLib.h @@ -45,7 +45,7 @@ TriggerRuntimeSoftwareSmi ( it was triggered at boot time, it returns TRUE. Otherwise, it returns FALSE. @retval TRUE A software SMI triggered at boot time happened. - @retval FLASE No software SMI happened, or the software SMI was triggered at run time. + @retval FALSE No software SMI happened, or the software SMI was triggered at run time. **/ BOOLEAN @@ -62,7 +62,7 @@ IsBootServiceSoftwareSmi ( it was triggered at run time, it returns TRUE. Otherwise, it returns FALSE. @retval TRUE A software SMI triggered at run time happened. - @retval FLASE No software SMI happened or the software SMI was triggered at boot time. + @retval FALSE No software SMI happened or the software SMI was triggered at boot time. **/ BOOLEAN diff --git a/MdePkg/Include/Library/SmmMemLib.h b/MdePkg/Include/Library/SmmMemLib.h index 72edc9adcde7..d92cbd9aabd2 100644 --- a/MdePkg/Include/Library/SmmMemLib.h +++ b/MdePkg/Include/Library/SmmMemLib.h @@ -67,7 +67,7 @@ SmmCopyMemToSmram ( @param SourceBufferThe pointer to the source buffer of the memory copy. @param Length The number of bytes to copy from SourceBuffer to DestinationBuffer. - @retval EFI_SECURITY_VIOLATION The DesinationBuffer is invalid per processor architecture or overlap with SMRAM. + @retval EFI_SECURITY_VIOLATION The DestinationBuffer is invalid per processor architecture or overlap with SMRAM. @retval EFI_SUCCESSMemory is copied. **/ @@ -92,7 +92,7 @@ SmmCopyMemFromSmram ( @param SourceBufferThe pointer to the source buffer of the memory copy. @param Length The number of bytes to copy from SourceBuffer to DestinationBuffer. - @retval EFI_SECURITY_VIOLATION The DesinationBuffer is invalid per processor architecture or overlap with SMRAM. + @retval EFI_SECURITY_VIOLATION The DestinationBuffer is invalid per processor architecture or overlap with SMRAM. @retval EFI_SECURITY_VIOLATION The SourceBuffer is invalid per processor architecture or overlap with SMRAM. @retval EFI_SUCCESSMemory is copied. diff --git a/MdePkg/Include/Library/SmmPeriodicSmiLib.h b/MdePkg/Include/Library/SmmPeriodicSmiLib.h index 6215aa2232ac..a3e086d02501 100644 --- a/MdePkg/Include/Library/SmmPeriodicSmiLib.h +++ b/MdePkg/Include/Library/SmmPeriodicSmiLib.h @@ -64,7 +64,7 @@ PeriodicSmiExit ( This function yields control back to the SMM Foundation. When the next periodic SMI for the currently executing handler is triggered, the periodic SMI handler will be resumed and this function will return. Use of this - function requires a seperate stack for the periodic SMI handler. A non zero + function requires a separate stack for the periodic SMI handler. A non zero stack size must be specified in PeriodicSmiEnable() for this function to be used. @@ -113,7 +113,7 @@ VOID @param[in] DispatchFunction A pointer to a periodic SMI handler function. @param[in] Context Optional content to pass into DispatchFunction. @param[in] TickPeriodThe requested tick period in 100ns units that - control should be givien to the periodic SMI + control should be given to the periodic SMI handler. Must be one of the supported values returned by PeriodicSmiSupportedPickPeriod(). @param[in] Cpu Specifies the CPU that is required to execute @@ -137,7 +137,7 @@ VOID @retval EFI_OUT_OF_RESOURCES There are not enough resources to enable the periodic SMI handler. @retval EFI_OUT_OF_RESOURCES There are not enough resources to allocate the - stack speficied by StackSize. + stack specified by StackSize. @retval EFI_SUCCESSThe periodic SMI handler was enabled. **/ diff --git
[edk2-devel] [PATCH v2 29/78] NetworkPkg: Fix a typo
Correctly write 'malformatted' in documentation, comments and debug strings. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Dhcp4Dxe/Dhcp4Option.h| 6 +++--- NetworkPkg/Ip4Dxe/Ip4Icmp.h | 2 +- NetworkPkg/Ip4Dxe/Ip4Igmp.h | 2 +- NetworkPkg/Ip4Dxe/Ip4Option.h| 4 ++-- NetworkPkg/Ip6Dxe/Ip6Icmp.h | 4 ++-- NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 4 ++-- NetworkPkg/Dhcp4Dxe/Dhcp4Option.c| 10 +- NetworkPkg/Ip4Dxe/Ip4Icmp.c | 2 +- NetworkPkg/Ip4Dxe/Ip4Igmp.c | 2 +- NetworkPkg/Ip4Dxe/Ip4Option.c| 2 +- NetworkPkg/Ip6Dxe/Ip6Icmp.c | 4 ++-- NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 10 +- NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 6 +++--- NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 2 +- NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 2 +- NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 2 +- NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 2 +- 17 files changed, 33 insertions(+), 33 deletions(-) diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h index 9e25386507ed..393176c8996d 100644 --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h @@ -133,7 +133,7 @@ DhcpIterateOptions ( @param[out] Para The variable to save the DHCP parameters. @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet. - @retval EFI_INVALID_PARAMETER The options are mal-formated + @retval EFI_INVALID_PARAMETER The options are malformatted @retval EFI_SUCCESSThe options are parsed into OptionPoint **/ @@ -167,7 +167,7 @@ DhcpValidateOptions ( @retval EFI_NOT_FOUND Cannot find any option. @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet. - @retval EFI_INVALID_PARAMETER The options are mal-formated + @retval EFI_INVALID_PARAMETER The options are malformatted @retval EFI_SUCCESSThe options are parsed into OptionPoint **/ @@ -211,7 +211,7 @@ DhcpAppendOption ( function. @retval EFI_OUT_OF_RESOURCES Failed to allocate memory - @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formated + @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted @retval EFI_SUCCESSThe packet is build. **/ diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.h b/NetworkPkg/Ip4Dxe/Ip4Icmp.h index 922886a96e67..a52200176f5a 100644 --- a/NetworkPkg/Ip4Dxe/Ip4Icmp.h +++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.h @@ -83,7 +83,7 @@ extern EFI_IP4_ICMP_TYPE mIp4SupportedIcmp[]; @param[in] Packet The content of the ICMP query with IP4 head removed. - @retval EFI_INVALID_PARAMETER The packet is malformated. + @retval EFI_INVALID_PARAMETER The packet is malformatted. @retval EFI_SUCCESSThe ICMP message is successfully processed. @retval Others Failed to handle ICMP packet. diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.h b/NetworkPkg/Ip4Dxe/Ip4Igmp.h index 0cc944594441..49c13ba3a7a0 100644 --- a/NetworkPkg/Ip4Dxe/Ip4Igmp.h +++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.h @@ -111,7 +111,7 @@ Ip4LeaveGroup ( @param[in] Head The IP4 header of the received message. @param[in] Packet The IGMP message, without IP4 header. - @retval EFI_INVALID_PARAMETER The IGMP message is malformated. + @retval EFI_INVALID_PARAMETER The IGMP message is malformatted. @retval EFI_SUCCESSThe IGMP message is successfully processed. **/ diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.h b/NetworkPkg/Ip4Dxe/Ip4Option.h index 57a5a58725f0..a39fd2b4c69d 100644 --- a/NetworkPkg/Ip4Dxe/Ip4Option.h +++ b/NetworkPkg/Ip4Dxe/Ip4Option.h @@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent /** Validate the IP4 option format for both the packets we received and will transmit. It will compute the ICMP error message fields - if the option is mal-formated. But this information isn't used. + if the option is malformatted. But this information isn't used. @param[in] OptionThe first byte of the option @param[in] OptionLen The length of the whole option @@ -28,7 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent otherwise the option we wants to transmit. @retval TRUE The option is properly formatted - @retval FALSEThe option is mal-formated + @retval FALSEThe option is malformatted **/ BOOLEAN diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.h b/NetworkPkg/Ip6Dxe/Ip6Icmp.h index 49a65f296adb..c63adb009519 100644 --- a/NetworkPkg/Ip6Dxe/Ip6Icmp.h +++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.h @@ -35,7 +35,7 @@ extern EFI_IP6_ICMP_TYPE mIp6SupportedIcmp[]; @param[in] Packet The content
[edk2-devel] [PATCH v2 27/78] MdePkg/Ppi: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Michael D Kinney
Signed-off-by: Philippe Mathieu-Daude
---
MdePkg/Include/Ppi/BlockIo.h | 4 ++--
MdePkg/Include/Ppi/BlockIo2.h | 2 +-
MdePkg/Include/Ppi/Capsule.h | 2 +-
MdePkg/Include/Ppi/Decompress.h | 2 +-
MdePkg/Include/Ppi/DeviceRecoveryModule.h | 2 +-
MdePkg/Include/Ppi/IsaHc.h| 2 +-
MdePkg/Include/Ppi/MpServices.h | 2 +-
MdePkg/Include/Ppi/Pcd.h | 4 ++--
MdePkg/Include/Ppi/RecoveryModule.h | 2 +-
MdePkg/Include/Ppi/TemporaryRamDone.h | 2 +-
MdePkg/Include/Ppi/VectorHandoffInfo.h| 2 +-
11 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/MdePkg/Include/Ppi/BlockIo.h b/MdePkg/Include/Ppi/BlockIo.h
index 524f026fe589..3a4955be6b59 100644
--- a/MdePkg/Include/Ppi/BlockIo.h
+++ b/MdePkg/Include/Ppi/BlockIo.h
@@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
@par Revision Reference:
This PPI is defined in UEFI Platform Initialization Specification 1.2 Volume
1:
- Pre-EFI Initalization Core Interface.
+ Pre-EFI Initialization Core Interface.
**/
@@ -58,7 +58,7 @@ typedef enum {
/// Specification inconsistency here:
/// PEI_BLOCK_IO_MEDIA has been changed to EFI_PEI_BLOCK_IO_MEDIA.
/// Inconsistency exists in UEFI Platform Initialization Specification 1.2
-/// Volume 1: Pre-EFI Initalization Core Interface, where all referrences to
+/// Volume 1: Pre-EFI Initialization Core Interface, where all references to
/// this structure name are with the "EFI_" prefix, except for the definition
/// which is without "EFI_". So the name of PEI_BLOCK_IO_MEDIA is taken as the
/// exception, and EFI_PEI_BLOCK_IO_MEDIA is used to comply with most of
diff --git a/MdePkg/Include/Ppi/BlockIo2.h b/MdePkg/Include/Ppi/BlockIo2.h
index e1af6a4293ed..0dba6485d941 100644
--- a/MdePkg/Include/Ppi/BlockIo2.h
+++ b/MdePkg/Include/Ppi/BlockIo2.h
@@ -7,7 +7,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
@par Revision Reference:
This PPI is defined in UEFI Platform Initialization Specification 1.4 Volume
1:
- Pre-EFI Initalization Core Interface.
+ Pre-EFI Initialization Core Interface.
**/
diff --git a/MdePkg/Include/Ppi/Capsule.h b/MdePkg/Include/Ppi/Capsule.h
index cb7b0e2ae76a..331d9b81cad2 100644
--- a/MdePkg/Include/Ppi/Capsule.h
+++ b/MdePkg/Include/Ppi/Capsule.h
@@ -45,7 +45,7 @@ typedef struct _EFI_PEI_CAPSULE_PPI PEI_CAPSULE_PPI;
On output, this variable will contain the size of
the
coalesced capsule.
- @retval EFI_NOT_FOUND If: boot modecould not be determined, or the
+ @retval EFI_NOT_FOUND If: boot mode could not be determined, or the
boot mode is not flash-update, or the capsule
descriptors were not found.
@retval EFI_BUFFER_TOO_SMALL The capsule could not be coalesced in the
provided memory region.
@retval EFI_SUCCESSThere was no capsule, or the capsule was
processed successfully.
diff --git a/MdePkg/Include/Ppi/Decompress.h b/MdePkg/Include/Ppi/Decompress.h
index 7ba26e419c59..b9ca63746ab2 100644
--- a/MdePkg/Include/Ppi/Decompress.h
+++ b/MdePkg/Include/Ppi/Decompress.h
@@ -1,5 +1,5 @@
/** @file
- Provides decompression services to the PEI Foundatoin.
+ Provides decompression services to the PEI Foundation.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/MdePkg/Include/Ppi/DeviceRecoveryModule.h
b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
index a4587255a3c8..64dabec1139c 100644
--- a/MdePkg/Include/Ppi/DeviceRecoveryModule.h
+++ b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
@@ -15,7 +15,7 @@
@par Revision Reference:
This PPI is defined in UEFI Platform Initialization Specification 1.2 Volume
1:
- Pre-EFI Initalization Core Interface
+ Pre-EFI Initialization Core Interface
**/
diff --git a/MdePkg/Include/Ppi/IsaHc.h b/MdePkg/Include/Ppi/IsaHc.h
index 5468c2e94b72..d7dfd9b47e8c 100644
--- a/MdePkg/Include/Ppi/IsaHc.h
+++ b/MdePkg/Include/Ppi/IsaHc.h
@@ -28,7 +28,7 @@ typedef struct _EFI_ISA_HC_PPI *PEFI_ISA_HC_PPI;
that more than one caller may be assigned to the same aperture.
It may be possible that a single hardware aperture may be used for more than
one device. This function tracks the number of times that each aperture is
- referenced, and doesa not close the hardware aperture (via CloseIoAperture())
+ referenced, and does not close the hardware aperture (via CloseIoAperture())
until there are no more references to it.
@param This A pointer to this instance of the EFI_ISA_HC_PPI.
diff --git a/MdePkg/Include/Ppi/MpServices.h b/MdePkg/Include/Ppi/MpServices.h
index
[edk2-devel] [PATCH v2 28/78] MdePkg/Register: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Michael D Kinney
Signed-off-by: Philippe Mathieu-Daude
---
MdePkg/Include/Register/Amd/Cpuid.h | 8
MdePkg/Include/Register/Amd/Fam17Msr.h| 2 +-
MdePkg/Include/Register/Amd/Msr.h | 2 +-
MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h | 2 +-
MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h| 2 +-
MdePkg/Include/Register/Intel/StmResourceDescriptor.h | 2 +-
6 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/MdePkg/Include/Register/Amd/Cpuid.h
b/MdePkg/Include/Register/Amd/Cpuid.h
index ad1ba4d016e0..8e91e84b767f 100644
--- a/MdePkg/Include/Register/Amd/Cpuid.h
+++ b/MdePkg/Include/Register/Amd/Cpuid.h
@@ -11,7 +11,7 @@
SPDX-License-Identifier: BSD-2-Clause-Patent
@par Specification Reference:
- AMD64 Architecture Programming Manaul volume 2, March 2017, Sections 15.34
+ AMD64 Architecture Programming Manual volume 2, March 2017, Sections 15.34
**/
@@ -364,7 +364,7 @@ typedef union {
///
UINT32 Page1GB:1;
///
-/// [Bit 27] RDTSCP intructions.
+/// [Bit 27] RDTSCP instructions.
///
UINT32 RDTSCP:1;
///
@@ -513,9 +513,9 @@ typedef union {
@retval EAX Extended APIC ID described by the type
CPUID_AMD_PROCESSOR_TOPOLOGY_EAX.
- @retval EBX Core Indentifiers described by the type
+ @retval EBX Core Identifiers described by the type
CPUID_AMD_PROCESSOR_TOPOLOGY_EBX.
- @retval ECX Node Indentifiers described by the type
+ @retval ECX Node Identifiers described by the type
CPUID_AMD_PROCESSOR_TOPOLOGY_ECX.
@retval EDX Reserved.
**/
diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h
b/MdePkg/Include/Register/Amd/Fam17Msr.h
index 37b935dcdb30..6ef45a9b21d3 100644
--- a/MdePkg/Include/Register/Amd/Fam17Msr.h
+++ b/MdePkg/Include/Register/Amd/Fam17Msr.h
@@ -10,7 +10,7 @@
SPDX-License-Identifier: BSD-2-Clause-Patent
@par Specification Reference:
- AMD64 Architecture Programming Manaul volume 2, March 2017, Sections 15.34
+ AMD64 Architecture Programming Manual volume 2, March 2017, Sections 15.34
**/
diff --git a/MdePkg/Include/Register/Amd/Msr.h
b/MdePkg/Include/Register/Amd/Msr.h
index e74de7a1df48..084eb892cdd9 100644
--- a/MdePkg/Include/Register/Amd/Msr.h
+++ b/MdePkg/Include/Register/Amd/Msr.h
@@ -10,7 +10,7 @@
SPDX-License-Identifier: BSD-2-Clause-Patent
@par Specification Reference:
- AMD64 Architecture Programming Manaul volume 2, March 2017, Sections 15.34
+ AMD64 Architecture Programming Manual volume 2, March 2017, Sections 15.34
**/
diff --git a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
index 2edc1363b7c4..c56d20df66a4 100644
--- a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
+++ b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
@@ -1,5 +1,5 @@
/** @file
- MSR Defintions for Intel Atom processors based on the Goldmont Plus
microarchitecture.
+ MSR Definitions for Intel Atom processors based on the Goldmont Plus
microarchitecture.
Provides defines for Machine Specific Registers(MSR) indexes. Data structures
are provided for MSRs that contain one or more bit fields. If the MSR value
diff --git a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
index 30f96f0e82fa..03cac77c19a6 100644
--- a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
+++ b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
@@ -1,5 +1,5 @@
/** @file
- MSR Defintions for Intel processors based on the
Skylake/Kabylake/Coffeelake/Cannonlake microarchitecture.
+ MSR Definitions for Intel processors based on the
Skylake/Kabylake/Coffeelake/Cannonlake microarchitecture.
Provides defines for Machine Specific Registers(MSR) indexes. Data structures
are provided for MSRs that contain one or more bit fields. If the MSR value
diff --git a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
index da4c91d0f4b8..3e426701e83c 100644
--- a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
+++ b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
@@ -179,7 +179,7 @@ typedef struct {
} STM_RSC_ALL_RESOURCES_DESC;
/**
- STM Register Volation Descriptor
+ STM Register Violation Descriptor
**/
typedef struct {
STM_RSC_DESC_HEADER Hdr;
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52762): https://edk2.groups.io/g/devel/message/52762
Mute This Topic: https://groups.io/mt/69395730/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 23/78] MdePkg/IndustryStandard: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Michael D Kinney
Signed-off-by: Philippe Mathieu-Daude
---
MdePkg/Include/IndustryStandard/Acpi10.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi20.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi30.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi40.h | 2 +-
MdePkg/Include/IndustryStandard/Acpi50.h | 6 +--
MdePkg/Include/IndustryStandard/Acpi51.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi60.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi61.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi62.h | 8 ++--
MdePkg/Include/IndustryStandard/Atapi.h | 40 +--
MdePkg/Include/IndustryStandard/ElTorito.h| 4 +-
MdePkg/Include/IndustryStandard/Emmc.h| 2 +-
.../IndustryStandard/IpmiNetFnBridge.h| 4 +-
MdePkg/Include/IndustryStandard/Nvme.h| 10 ++---
MdePkg/Include/IndustryStandard/Pci22.h | 20 +-
MdePkg/Include/IndustryStandard/PeImage.h | 2 +-
MdePkg/Include/IndustryStandard/Scsi.h| 2 +-
MdePkg/Include/IndustryStandard/SmBus.h | 2 +-
MdePkg/Include/IndustryStandard/Tpm12.h | 2 +-
19 files changed, 64 insertions(+), 64 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h
b/MdePkg/Include/IndustryStandard/Acpi10.h
index a38d2be61cc3..fa06eefbb6e6 100644
--- a/MdePkg/Include/IndustryStandard/Acpi10.h
+++ b/MdePkg/Include/IndustryStandard/Acpi10.h
@@ -37,7 +37,7 @@ typedef struct {
#pragma pack()
//
-// Define for Desriptor
+// Define for Descriptor
//
#define ACPI_SMALL_ITEM_FLAG 0x00
#define ACPI_LARGE_ITEM_FLAG 0x01
@@ -109,7 +109,7 @@ typedef struct {
#pragma pack(1)
///
-/// The commond definition of QWORD, DWORD, and WORD
+/// The common definition of QWORD, DWORD, and WORD
/// Address Space Descriptors.
///
typedef PACKED struct {
diff --git a/MdePkg/Include/IndustryStandard/Acpi20.h
b/MdePkg/Include/IndustryStandard/Acpi20.h
index 8a0adbbb6a97..b63d494705a2 100644
--- a/MdePkg/Include/IndustryStandard/Acpi20.h
+++ b/MdePkg/Include/IndustryStandard/Acpi20.h
@@ -11,7 +11,7 @@
#include
//
-// Define for Desriptor
+// Define for Descriptor
//
#define ACPI_LARGE_GENERIC_REGISTER_DESCRIPTOR_NAME 0x02
@@ -505,7 +505,7 @@ typedef struct {
#define EFI_ACPI_2_0_SYSTEM_LOCALITY_INFORMATION_TABLE_SIGNATURE
SIGNATURE_32('S', 'L', 'I', 'T')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_2_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE
SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h
b/MdePkg/Include/IndustryStandard/Acpi30.h
index 0fc947e745f4..6a7fc39c256e 100644
--- a/MdePkg/Include/IndustryStandard/Acpi30.h
+++ b/MdePkg/Include/IndustryStandard/Acpi30.h
@@ -11,7 +11,7 @@
#include
//
-// Define for Desriptor
+// Define for Descriptor
//
#define ACPI_LARGE_EXTENDED_ADDRESS_SPACE_DESCRIPTOR_NAME0x0B
@@ -684,7 +684,7 @@ typedef struct {
#define
EFI_ACPI_3_0_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE
SIGNATURE_32('M', 'C', 'F', 'G')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_3_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE
SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h
b/MdePkg/Include/IndustryStandard/Acpi40.h
index 53ec90c04243..c03ba7a6290b 100644
--- a/MdePkg/Include/IndustryStandard/Acpi40.h
+++ b/MdePkg/Include/IndustryStandard/Acpi40.h
@@ -1264,7 +1264,7 @@ typedef struct {
#define EFI_ACPI_4_0_MANAGEMENT_CONTROLLER_HOST_INTERFACE_TABLE_SIGNATURE
SIGNATURE_32('M', 'C', 'H', 'I')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE
SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h
b/MdePkg/Include/IndustryStandard/Acpi50.h
index 067ab68c3428..46dcdb950741 100644
--- a/MdePkg/Include/IndustryStandard/Acpi50.h
+++ b/MdePkg/Include/IndustryStandard/Acpi50.h
@@ -12,7 +12,7 @@
#include
//
-// Define for Desriptor
+// Define for Descriptor
//
#define ACPI_SMALL_FIXED_DMA_DESCRIPTOR_NAME 0x0A
#define ACPI_LARGE_GPIO_CONNECTION_DESCRIPTOR_NAME 0x0C
@@ -1201,7 +1201,7 @@ typedef struct {
///
UINT64 ExitBootServicesEntry;
///
- /// Timer value logged at the point just prior towhen the OS loader gaining
+ /// Timer value logged at the point just prior to when the OS loader gaining
/// control back from calls the
[edk2-devel] [PATCH v2 08/78] FatPkg/FatPei: Fix few typos
From: Antoine Coeur
Fix few typos in comments.
Cc: Ray Ni
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Ray Ni
Signed-off-by: Philippe Mathieu-Daude
---
FatPkg/FatPei/FatLitePeim.h | 2 +-
FatPkg/FatPei/FatLiteApi.c | 2 +-
FatPkg/FatPei/Mbr.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/FatPkg/FatPei/FatLitePeim.h b/FatPkg/FatPei/FatLitePeim.h
index 9cacf74aceeb..0c3c69853ca6 100644
--- a/FatPkg/FatPei/FatLitePeim.h
+++ b/FatPkg/FatPei/FatLitePeim.h
@@ -185,7 +185,7 @@ typedef struct {
/**
Finds the recovery file on a FAT volume.
- This function finds the the recovery file named FileName on a specified FAT
volume and returns
+ This function finds the recovery file named FileName on a specified FAT
volume and returns
its FileHandle pointer.
@param PrivateData Global memory map for accessing global
diff --git a/FatPkg/FatPei/FatLiteApi.c b/FatPkg/FatPei/FatLiteApi.c
index 8c7c6e52581f..d07422ba93b7 100644
--- a/FatPkg/FatPei/FatLiteApi.c
+++ b/FatPkg/FatPei/FatLiteApi.c
@@ -591,7 +591,7 @@ LoadRecoveryCapsule (
/**
Finds the recovery file on a FAT volume.
- This function finds the the recovery file named FileName on a specified FAT
volume and returns
+ This function finds the recovery file named FileName on a specified FAT
volume and returns
its FileHandle pointer.
@param PrivateData Global memory map for accessing global
diff --git a/FatPkg/FatPei/Mbr.c b/FatPkg/FatPei/Mbr.c
index 5b01604c0749..78e73fb811d7 100644
--- a/FatPkg/FatPei/Mbr.c
+++ b/FatPkg/FatPei/Mbr.c
@@ -51,7 +51,7 @@ PartitionValidMbr (
EndingLBA = StartingLBA + UNPACK_UINT32
(Mbr->Partition[Index1].SizeInLBA) - 1;
if (EndingLBA > LastLba) {
//
- // Compatability Errata:
+ // Compatibility Errata:
// Some systems try to hide drive space with their INT 13h driver
// This does not hide space from the OS driver. This means the MBR
// that gets created from DOS is smaller than the MBR created from
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52742): https://edk2.groups.io/g/devel/message/52742
Mute This Topic: https://groups.io/mt/69395709/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 12/78] MdeModulePkg/Bus/I2c: Fix few typos
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h | 4 ++--
MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 4 ++--
MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h
b/MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h
index 3c906e720359..49f1e9b17bec 100644
--- a/MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h
+++ b/MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h
@@ -426,7 +426,7 @@ I2cBusDriverSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a
device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a
lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -773,7 +773,7 @@ I2cHostDriverSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a
device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a
lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c
b/MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c
index ed33a51da252..1833c0afb81d 100644
--- a/MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c
+++ b/MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c
@@ -538,7 +538,7 @@ I2cBusDriverSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a
device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a
lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -623,7 +623,7 @@ I2cBusDriverStart (
if ((RemainingDevicePath != NULL) && IsDevicePathEnd (RemainingDevicePath)) {
//
// If RemainingDevicePath is the End of Device Path Node,
-// don't create any child device and return EFI_SUCESS
+// don't create any child device and return EFI_SUCCESS
//
return EFI_SUCCESS;
}
diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c
b/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c
index 79c091694677..95294c9c9891 100644
--- a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c
+++ b/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c
@@ -311,7 +311,7 @@ I2cHostDriverSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a
device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a
lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52746): https://edk2.groups.io/g/devel/message/52746
Mute This Topic: https://groups.io/mt/69395714/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 19/78] MdeModulePkg/UsbMass: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 4 ++--
8 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
index 2b89c92724a8..f34a41284e4c 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
@@ -77,7 +77,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
// Mass command timeout, refers to specification[USB20-9.2.6.1]
//
// USB2.0 Spec define the up-limit timeout 5s for all command. USB floppy,
-// USB CD-Rom and iPod devices are much slower than USB key when reponse
+// USB CD-Rom and iPod devices are much slower than USB key when response
// most of commands, So we set 5s as timeout here.
//
#define USB_BOOT_GENERAL_CMD_TIMEOUT(5 * USB_MASS_1_SECOND)
@@ -213,7 +213,7 @@ typedef struct {
This function get the parameters for the USB mass storage media,
It is used both to initialize the media during the Start() phase
of Driver Binding Protocol and to re-initialize it when the media is
- changed. Althought the RemoveableMedia is unlikely to change,
+ changed. Although the RemoveableMedia is unlikely to change,
it is also included here.
@param UsbMassThe device to retrieve disk gemotric.
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
index ea03cf7e2fd4..3ef8f240a2c1 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
@@ -14,14 +14,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
extern USB_MASS_TRANSPORT mUsbBotTransport;
//
-// Usb Bulk-Only class specfic request
+// Usb Bulk-Only class specific request
//
#define USB_BOT_RESET_REQUEST0xFF ///< Bulk-Only Mass Storage Reset
#define USB_BOT_GETLUN_REQUEST 0xFE ///< Get Max Lun
#define USB_BOT_CBW_SIGNATURE0x43425355 ///< dCBWSignature, tag the packet
as CBW
#define USB_BOT_CSW_SIGNATURE0x53425355 ///< dCSWSignature, tag the packet
as CSW
#define USB_BOT_MAX_LUN 0x0F ///< Lun number is from 0 to 15
-#define USB_BOT_MAX_CMDLEN 16 ///< Maxium number of command from
command set
+#define USB_BOT_MAX_CMDLEN 16 ///< Maximum number of command
from command set
//
// Usb BOT command block status values
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
index 287c0330f61e..b79b9c243630 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
@@ -1,5 +1,5 @@
/** @file
- Defination for the USB mass storage Control/Bulk/Interrupt (CBI) transport,
+ Definition for the USB mass storage Control/Bulk/Interrupt (CBI) transport,
according to USB Mass Storage Class Control/Bulk/Interrupt (CBI) Transport,
Revision 1.1.
Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
index 9f63deeae3db..283bed7055a0 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
@@ -48,7 +48,7 @@ USBMassDriverBindingSupported (
/**
Starts the USB mass storage device with this driver.
- This function consumes USB I/O Portocol, intializes USB mass storage device,
+ This function consumes USB I/O Protocol, initializes USB mass storage device,
installs Block I/O Protocol, and submits Asynchronous Interrupt
Transfer to manage the USB mass storage device.
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
index 600896b6a214..aab4061e183c 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
@@ -197,7 +197,7 @@ UsbBootExecCmd (
//
// If ExecCommand() returns no error and CmdResult is success,
- // then the commnad transfer is successful.
+ // then the command transfer is successful.
//
if ((CmdResult == USB_MASS_CMD_SUCCESS) && !EFI_ERROR (Status)) {
return
[edk2-devel] [PATCH v2 09/78] MdeModulePkg/Application: Improve French translation
From: Antoine Coeur Use correct French. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Antoine Coeur Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Application/UiApp/FrontPageStrings.uni | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Application/UiApp/FrontPageStrings.uni b/MdeModulePkg/Application/UiApp/FrontPageStrings.uni index 254a876ec42c..a0ab9abce10a 100644 --- a/MdeModulePkg/Application/UiApp/FrontPageStrings.uni +++ b/MdeModulePkg/Application/UiApp/FrontPageStrings.uni @@ -31,7 +31,7 @@ #string STR_FRONT_PAGE_BANNER_0_RIGHT #language en-US "OK" #language fr-FR "Bon" #string STR_FRONT_PAGE_BANNER_1_LEFT #language en-US "2 Pentium® X Xeon processors running at 800Thz" - #language fr-FR "2 Pentium® X les processeurs de Xeon courants à 800Thz" + #language fr-FR "2 processeurs Pentium® X Xeon tournants à 800Thz" #string STR_FRONT_PAGE_BANNER_1_RIGHT #language en-US "24 TB System RAM" #language fr-FR "24 TB RAM de Système" #string STR_FRONT_PAGE_BANNER_2_LEFT #language en-US "ACME® EFI BIOS Version 13.5 Release 1039.92" @@ -41,11 +41,11 @@ #string STR_CONTINUE_PROMPT#language en-US "Continue" #language fr-FR "Continuer" #string STR_CONTINUE_HELP #language en-US "This selection will direct the system to continue to booting process" - #language fr-FR "Cette sélection dirigera le système pour continuer au charger de procédé" + #language fr-FR "Cette sélection dirigera le système pour continuer au processus d'amorçage" #string STR_LANGUAGE_SELECT#language en-US "Select Language" #language fr-FR "Choisir la Langue" #string STR_LANGUAGE_SELECT_HELP #language en-US "This is the option one adjusts to change the language for the current system" - #language fr-FR "Ceci est l'option que celui ajuste changer la langue pour le système actuel" + #language fr-FR "Ceci est l'option qu'on ajuste pour changer la langue pour le système actuel" #string STR_MISSING_STRING #language en-US "Missing String" #language fr-FR "Missing String" #string STR_EMPTY_STRING #language en-US "" -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52744): https://edk2.groups.io/g/devel/message/52744 Mute This Topic: https://groups.io/mt/69395712/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 01/78] CryptoPkg/OpensslLib: Fix few typos
From: Antoine Coeur
Fix few typos in comments.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
CryptoPkg/Library/OpensslLib/rand_pool.c | 8
CryptoPkg/Library/OpensslLib/rand_pool_noise.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/CryptoPkg/Library/OpensslLib/rand_pool.c
b/CryptoPkg/Library/OpensslLib/rand_pool.c
index 9d2a4ad13823..9f3983f7c35b 100644
--- a/CryptoPkg/Library/OpensslLib/rand_pool.c
+++ b/CryptoPkg/Library/OpensslLib/rand_pool.c
@@ -129,7 +129,7 @@ RandGetSeed128 (
AES_KEY AESKey;
//
- // Chose an arbitary key and zero the feed_forward_value (FFV)
+ // Chose an arbitrary key and zero the feed_forward_value (FFV)
//
for (Index = 0; Index < 16; Index++) {
Key[Index] = (UINT8) Index;
@@ -287,7 +287,7 @@ int rand_pool_add_additional_data(RAND_POOL *pool)
}
/*
- * Dummy Implememtation for UEFI
+ * Dummy Implementation for UEFI
*
* This is OpenSSL required interface.
*/
@@ -297,7 +297,7 @@ int rand_pool_init(void)
}
/*
- * Dummy Implememtation for UEFI
+ * Dummy Implementation for UEFI
*
* This is OpenSSL required interface.
*/
@@ -306,7 +306,7 @@ void rand_pool_cleanup(void)
}
/*
- * Dummy Implememtation for UEFI
+ * Dummy Implementation for UEFI
*
* This is OpenSSL required interface.
*/
diff --git a/CryptoPkg/Library/OpensslLib/rand_pool_noise.c
b/CryptoPkg/Library/OpensslLib/rand_pool_noise.c
index c16ed8b45496..212834e27acc 100644
--- a/CryptoPkg/Library/OpensslLib/rand_pool_noise.c
+++ b/CryptoPkg/Library/OpensslLib/rand_pool_noise.c
@@ -22,7 +22,7 @@ GetRandomNoise64 (
)
{
//
- // Return FALSE will fallback to use PerformaceCounter to
+ // Return FALSE will fallback to use PerformanceCounter to
// generate noise.
//
return FALSE;
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52734): https://edk2.groups.io/g/devel/message/52734
Mute This Topic: https://groups.io/mt/69395699/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 16/78] MdeModulePkg/Core/Pei: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Core/Pei/PeiMain.h | 4 ++--
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 10 +-
MdeModulePkg/Core/Pei/FwVol/FwVol.c | 4 ++--
MdeModulePkg/Core/Pei/Hob/Hob.c | 2 +-
MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 2 +-
5 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h
index 6431bdaaacf6..56b3bd85793d 100644
--- a/MdeModulePkg/Core/Pei/PeiMain.h
+++ b/MdeModulePkg/Core/Pei/PeiMain.h
@@ -282,7 +282,7 @@ struct _PEI_CORE_INSTANCE {
EFI_PHYSICAL_ADDRESS LoadModuleAtFixAddressTopAddress;
//
// The field is define for Loading modules at fixed address feature to
tracker the PEI code
- // memory range usage. It is a bit mapped array in which every bit indicates
the correspoding memory page
+ // memory range usage. It is a bit mapped array in which every bit indicates
the corresponding memory page
// available or not.
//
UINT64*PeiCodeMemoryRangeUsageBitMap;
@@ -555,7 +555,7 @@ PeiLocatePpi (
@retval EFI_SUCCESS if successful
@retval EFI_OUT_OF_RESOURCES if no space in the database
- @retval EFI_INVALID_PARAMETER if not a good decriptor
+ @retval EFI_INVALID_PARAMETER if not a good descriptor
**/
EFI_STATUS
diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
index a18ac47f617a..4c2eac1384e8 100644
--- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
+++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
@@ -257,7 +257,7 @@ PeiLoadFixAddressIsMemoryRangeAvailable (
This function should only be invoked when Loading Module at Fixed
Address(LMFA) feature is enabled. When feature is
configured as Load Modules at Fix Absolute Address, this function is to
validate the top address assigned by user. When
- feature is configured as Load Modules at Fixed Offset, the functino is to
find the top address which is TOLM-TSEG in general.
+ feature is configured as Load Modules at Fixed Offset, the function is to
find the top address which is TOLM-TSEG in general.
And also the function will re-install PEI memory.
@param PrivateData Pointer to the private data passed in from caller
@@ -604,7 +604,7 @@ PeiLoadFixAddressHook(
);
}
//
-// Delete CurrentHob by marking it as unused since the the memory range
described by is rebuilt.
+// Delete CurrentHob by marking it as unused since the memory range
described by is rebuilt.
//
GET_HOB_TYPE (CurrentHob) = EFI_HOB_TYPE_UNUSED;
}
@@ -751,7 +751,7 @@ PeiCheckAndSwitchStack (
//
// Calculate stack offset and heap offset between temporary memory and new
permanent
-// memory seperately.
+// memory separately.
//
TopOfOldStack = (UINTN)SecCoreData->StackBase + SecCoreData->StackSize;
TopOfNewStack = Private->PhysicalMemoryBegin + NewStackSize;
@@ -1229,7 +1229,7 @@ PeiDispatcher (
//
// Before walking through the next FV, we should set them to NULL/0 to
- // start at the begining of the next FV.
+ // start at the beginning of the next FV.
//
Private->CurrentFileHandle = NULL;
Private->CurrentPeimCount = 0;
@@ -1259,7 +1259,7 @@ PeiDispatcher (
@param PrivateData PeiCore's private data structure
@param OldCoreData Old data from SecCore
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
@param SecCoreData Points to a data structure containing information
about the PEI core's operating
environment, such as the size and location of
temporary RAM, the stack location and
the BFV location.
diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
index b3661146f29c..fa1a3d3accb8 100644
--- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
+++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
@@ -178,7 +178,7 @@ CalculateHeaderChecksum (
if (IS_FFS_FILE2 (FileHeader)) {
CopyMem (, FileHeader, sizeof (EFI_FFS_FILE_HEADER2));
//
-// Ingore State and File field in FFS header.
+// Ignore State and File field in FFS header.
//
TestFileHeader.State = 0;
TestFileHeader.IntegrityCheck.Checksum.File = 0;
@@ -187,7 +187,7 @@ CalculateHeaderChecksum (
} else {
CopyMem (, FileHeader, sizeof (EFI_FFS_FILE_HEADER));
//
-// Ingore State and File field in FFS header.
+// Ignore State and File field in FFS header.
//
TestFileHeader.State = 0;
TestFileHeader.IntegrityCheck.Checksum.File = 0;
diff --git
[edk2-devel] [PATCH v2 10/78] MdeModulePkg/Application: Fix various typos
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h | 2 +-
MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h | 2 +-
MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 2 +-
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 4 ++--
.../Application/MemoryProfileInfo/MemoryProfileInfo.c | 2 +-
MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h
b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h
index 04c2df5666e6..e38e87824dde 100644
--- a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h
+++ b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h
@@ -47,7 +47,7 @@ typedef struct _BOOT_MENU_POPUP_DATA {
EFI_STRING_ID HelpToken[HELP_TOKEN_COUNT]; // All of
help string ID
UINTN SelectItem;// Current
select item
BOOT_MENU_SCREENMenuScreen;// Boot menu
screen information
- BOOT_MENU_SCROLL_BAR_CONTROLScrollBarControl; // Boot menu
scroll bar inoformation
+ BOOT_MENU_SCROLL_BAR_CONTROLScrollBarControl; // Boot menu
scroll bar information
} BOOT_MENU_POPUP_DATA;
#endif
diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h
b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h
index 2f3ae45aaf27..7be45849f965 100644
--- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h
+++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h
@@ -85,7 +85,7 @@ BOOLEAN
@paramHiiHandle The hii handle for the Uiapp driver.
@paramClassGuid The class guid for the driver which is the
target.
- @paramSpecialHandlerFn The pointer to the specail handler function,
if any.
+ @paramSpecialHandlerFnThe pointer to the special handler function,
if any.
@paramStartOpCodeHandle The opcode handle to save the new opcode.
@retval EFI_SUCCESS Search the driver success
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
index 3439ce5febe0..40347147734b 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
@@ -494,7 +494,7 @@ BuildGatherList (
}
//
-// Record descirptor header
+// Record descriptor header
//
if (Index == 0) {
BlockDescriptorsHeader = BlockDescriptors1;
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
index 58a93568d013..3c293bfad84f 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
@@ -38,7 +38,7 @@ DumpUxCapsule (
{
EFI_DISPLAY_CAPSULE *DisplayCapsule;
DisplayCapsule = (EFI_DISPLAY_CAPSULE *)CapsuleHeader;
- Print(L"[UxCapusule]\n");
+ Print(L"[UxCapsule]\n");
Print(L"CapsuleHeader:\n");
Print(L" CapsuleGuid - %g\n",
>CapsuleHeader.CapsuleGuid);
Print(L" HeaderSize - 0x%x\n",
DisplayCapsule->CapsuleHeader.HeaderSize);
@@ -199,7 +199,7 @@ DumpCapsule (
DumpFmpCapsule(CapsuleHeader);
}
if (IsNestedFmpCapsule(CapsuleHeader)) {
-Print(L"[NestedCapusule]\n");
+Print(L"[NestedCapsule]\n");
Print(L"CapsuleHeader:\n");
Print(L" CapsuleGuid - %g\n", >CapsuleGuid);
Print(L" HeaderSize - 0x%x\n", CapsuleHeader->HeaderSize);
diff --git a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c
b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c
index 148607db722b..191c31068545 100644
--- a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c
+++ b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c
@@ -627,7 +627,7 @@ DumpMemoryProfileMemoryRange (
@param[in] ProfileSizeMemory profile size.
@param[in] Signature Signature.
- @return Pointer to the stucture with the signature.
+ @return Pointer to the structure with the signature.
**/
VOID *
diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
index c9823e565de8..858fdfc53d78 100644
--- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
+++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
@@ -554,7 +554,7 @@ RequiredDriver (
@paramHiiHandle The hii handle for the Uiapp driver.
@paramClassGuid The class guid for the driver which is the
[edk2-devel] [PATCH v2 15/78] MdeModulePkg/Bus/Sd: Fix various typos
From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h | 2 +- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h | 6 +++--- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h | 2 +- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h | 6 +++--- MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h | 2 +- MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 2 +- MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 12 ++-- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 12 ++-- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c | 2 +- MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 2 +- MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c | 6 +++--- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 10 +- MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 2 +- 13 files changed, 33 insertions(+), 33 deletions(-) diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h index c0e461335f43..4e3e51d14403 100644 --- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h +++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h @@ -244,7 +244,7 @@ EmmcPeimHcInitHost ( Refer to EMMC Electrical Standard Spec 5.1 Section 6.10.4 for details. @param[in] Slot The slot number of the Emmc card to send the command to. - @param[in] Access The access mode of SWTICH command. + @param[in] Access The access mode of SWITCH command. @param[in] Index The offset of the field to be access. @param[in] Value The value to be set to the specified field of EXT_CSD register. @param[in] CmdSet The value of CmdSet field of EXT_CSD register. diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h index 86957a42daea..62e70ae912b0 100644 --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h @@ -43,7 +43,7 @@ EmmcReset ( @retval EFI_SUCCESS The data was read correctly from the device. @retval EFI_DEVICE_ERROR The device reported an error while performing the read. @retval EFI_NO_MEDIA There is no media in the device. - @retval EFI_MEDIA_CHANGED The MediaId does not matched the current device. + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. @retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device. @retval EFI_INVALID_PARAMETER The read request contains LBAs that are not valid, or the buffer is not on proper alignment. @@ -73,7 +73,7 @@ EmmcReadBlocks ( @retval EFI_WRITE_PROTECTED The device can not be written to. @retval EFI_DEVICE_ERROR The device reported an error while performing the write. @retval EFI_NO_MEDIA There is no media in the device. - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device. + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. @retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device. @retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid, or the buffer is not on proper alignment. @@ -176,7 +176,7 @@ EmmcReadBlocksEx ( @retval EFI_WRITE_PROTECTED The device can not be written to. @retval EFI_DEVICE_ERROR The device reported an error while performing the write. @retval EFI_NO_MEDIA There is no media in the device. - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device. + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. @retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device. @retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid, or the buffer is not on proper alignment. diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h index d286d97f4213..5ecce41dee11 100644 --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h @@ -235,7 +235,7 @@ EmmcDxeDriverBindingSupported ( @retval EFI_SUCCESS The device was started. @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented. @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources. - @retval Others The driver failded to start the device. + @retval Others The driver failed to start the device. **/ EFI_STATUS diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h index 769b47106400..b6b4c45f1f3d
[edk2-devel] [PATCH v2 20/78] MdeModulePkg/UsbMouse: Fix few typos
From: Antoine Coeur Fix few typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- .../Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h| 2 +- MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h | 2 +- MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c | 2 +- .../Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c| 2 +- MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 2 +- MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h index f7fe480d0762..c9edc45e38a4 100644 --- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h +++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h @@ -138,7 +138,7 @@ USBMouseAbsolutePointerDriverBindingSupported ( /** Starts the mouse device with this driver. - This function consumes USB I/O Portocol, intializes USB mouse device, + This function consumes USB I/O Protocol, initializes USB mouse device, installs Absolute Pointer Protocol, and submits Asynchronous Interrupt Transfer to manage the USB mouse device. diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h index b71ef829870a..f46069602f28 100644 --- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h +++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h @@ -138,7 +138,7 @@ USBMouseDriverBindingSupported ( /** Starts the mouse device with this driver. - This function consumes USB I/O Portocol, intializes USB mouse device, + This function consumes USB I/O Protocol, initializes USB mouse device, installs Simple Pointer Protocol, and submits Asynchronous Interrupt Transfer to manage the USB mouse device. diff --git a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c index d7805ad3de90..10e18e58ab45 100644 --- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c +++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c @@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent Only short item is supported here. @param StartPos Start position of the HID item to get. - @param EndPosEnd position of the range to get the the next HID item. + @param EndPosEnd position of the range to get the next HID item. @param HidItem Buffer for the HID Item to return. @return Pointer to end of the HID item returned. diff --git a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c index 8953e7031cfc..83197bfd996f 100644 --- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c +++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c @@ -109,7 +109,7 @@ USBMouseAbsolutePointerDriverBindingSupported ( /** Starts the mouse device with this driver. - This function consumes USB I/O Portocol, intializes USB mouse device, + This function consumes USB I/O Protocol, initializes USB mouse device, installs Absolute Pointer Protocol, and submits Asynchronous Interrupt Transfer to manage the USB mouse device. diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c index de44aec516e4..2b6d86030b26 100644 --- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c +++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c @@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent Only short item is supported here. @param StartPos Start position of the HID item to get. - @param EndPosEnd position of the range to get the the next HID item. + @param EndPosEnd position of the range to get the next HID item. @param HidItem Buffer for the HID Item to return. @return Pointer to end of the HID item returned. diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c index 677815a8ade3..8284e9ec80b9 100644 --- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c +++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c @@ -109,7 +109,7 @@ USBMouseDriverBindingSupported ( /** Starts the mouse device with this driver. - This function consumes USB I/O Portocol, intializes USB mouse device, + This function consumes USB I/O Protocol, initializes USB mouse device, installs Simple Pointer Protocol, and submits Asynchronous Interrupt Transfer to manage the USB mouse device. -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.
[edk2-devel] [PATCH v2 07/78] FatPkg/EnhancedFatDxe: Fix various typos
From: Antoine Coeur
Fix various typos in FatPkg/EnhancedFatDxe comments.
Cc: Ray Ni
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
FatPkg/EnhancedFatDxe/Fat.h | 6 +++---
FatPkg/EnhancedFatDxe/Delete.c | 2 +-
FatPkg/EnhancedFatDxe/DirectoryManage.c | 2 +-
FatPkg/EnhancedFatDxe/Fat.c | 2 +-
FatPkg/EnhancedFatDxe/FileName.c| 2 +-
FatPkg/EnhancedFatDxe/FileSpace.c | 6 +++---
FatPkg/EnhancedFatDxe/Flush.c | 4 ++--
7 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/FatPkg/EnhancedFatDxe/Fat.h b/FatPkg/EnhancedFatDxe/Fat.h
index 46c185c3a9e9..fcc25952d495 100644
--- a/FatPkg/EnhancedFatDxe/Fat.h
+++ b/FatPkg/EnhancedFatDxe/Fat.h
@@ -236,7 +236,7 @@ struct _FAT_OFILE {
UINTN Signature;
FAT_VOLUME *Volume;
//
- // A permanant error code to return to all accesses to
+ // A permanent error code to return to all accesses to
// this opened file
//
EFI_STATUS Error;
@@ -246,7 +246,7 @@ struct _FAT_OFILE {
LIST_ENTRY Opens;
//
- // The dynamic infomation
+ // The dynamic information
//
UINTN FileSize;
UINTN FileCluster;
@@ -1863,7 +1863,7 @@ FatCreate8Dot3Name (
@param FatName - The Char8 string needs to be converted.
@param Len - The length of the fat name.
@param LowerCase - Indicate whether to convert the string to
lower case.
- @param Str - The result of the convertion.
+ @param Str - The result of the conversion.
**/
VOID
diff --git a/FatPkg/EnhancedFatDxe/Delete.c b/FatPkg/EnhancedFatDxe/Delete.c
index b2a62b35ded8..8a437e3ee201 100644
--- a/FatPkg/EnhancedFatDxe/Delete.c
+++ b/FatPkg/EnhancedFatDxe/Delete.c
@@ -56,7 +56,7 @@ FatDelete (
goto Done;
}
//
- // If the file has a permanant error, skip the delete
+ // If the file has a permanent error, skip the delete
//
Status = OFile->Error;
if (!EFI_ERROR (Status)) {
diff --git a/FatPkg/EnhancedFatDxe/DirectoryManage.c
b/FatPkg/EnhancedFatDxe/DirectoryManage.c
index 93772dba09c2..90c01b3baa1c 100644
--- a/FatPkg/EnhancedFatDxe/DirectoryManage.c
+++ b/FatPkg/EnhancedFatDxe/DirectoryManage.c
@@ -13,7 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
Get a directory entry from disk for the Ofile.
@param Parent- The parent of the OFile which need to update.
- @param IoMode- Indicate whether to read directory entry or
write directroy entry.
+ @param IoMode- Indicate whether to read directory entry or
write directory entry.
@param EntryPos - The position of the directory entry to be
accessed.
@param Entry - The directory entry read or written.
diff --git a/FatPkg/EnhancedFatDxe/Fat.c b/FatPkg/EnhancedFatDxe/Fat.c
index 3bec1c94ecd8..77cda1953991 100644
--- a/FatPkg/EnhancedFatDxe/Fat.c
+++ b/FatPkg/EnhancedFatDxe/Fat.c
@@ -417,7 +417,7 @@ FatDriverBindingStart (
Status = FatAllocateVolume (ControllerHandle, DiskIo, DiskIo2, BlockIo);
//
- // When the media changes on a device it will Reinstall the BlockIo
interaface.
+ // When the media changes on a device it will Reinstall the BlockIo
interface.
// This will cause a call to our Stop(), and a subsequent reentrant call to
our
// Start() successfully. We should leave the device open when this happen.
//
diff --git a/FatPkg/EnhancedFatDxe/FileName.c b/FatPkg/EnhancedFatDxe/FileName.c
index 256db309545a..d2d1fb31174c 100644
--- a/FatPkg/EnhancedFatDxe/FileName.c
+++ b/FatPkg/EnhancedFatDxe/FileName.c
@@ -128,7 +128,7 @@ FatTrimAsciiTrailingBlanks (
@param FatName - The Char8 string needs to be converted.
@param Len - The length of the fat name.
@param LowerCase - Indicate whether to convert the string to
lower case.
- @param Str - The result of the convertion.
+ @param Str - The result of the conversion.
**/
VOID
diff --git a/FatPkg/EnhancedFatDxe/FileSpace.c
b/FatPkg/EnhancedFatDxe/FileSpace.c
index 0dd66e0c53af..f57e44e3680a 100644
--- a/FatPkg/EnhancedFatDxe/FileSpace.c
+++ b/FatPkg/EnhancedFatDxe/FileSpace.c
@@ -223,7 +223,7 @@ FatSetFatEntry (
/**
- Free the cluster clain.
+ Free the cluster chain.
@param Volume- FAT file system volume.
@param Cluster - The first cluster of cluster chain.
@@ -575,8 +575,8 @@ FatOFilePosition (
ASSERT_VOLUME_LOCKED (Volume);
//
- // If this is the fixed root dir, then compute it's position
- // from it's fixed info in the fat bpb
+ // If this is the fixed root dir, then compute its position
+ // from its fixed info in the fat bpb
//
if (OFile->IsFixedRootDir) {
OFile->PosDisk = Volume->RootPos + Position;
diff --git
[edk2-devel] [PATCH v2 13/78] MdeModulePkg/Bus/Isa: Fix various typos
From: Antoine Coeur Fix various typos in documentation, comments and debug strings. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- .../Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf | 2 +- .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 14 ++--- MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h| 2 +- MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h | 2 +- MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c| 6 +++--- .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c| 16 +++ .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 20 +-- .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 4 ++-- MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c| 2 +- MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c | 4 ++-- .../Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni | 2 +- 11 files changed, 37 insertions(+), 37 deletions(-) diff --git a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf index cf2699c1d996..7e801ecd1f20 100644 --- a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf +++ b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf @@ -1,7 +1,7 @@ ## @file # PS2 Mouse Driver. # -# This dirver provides support for PS2 based mice. +# This driver provides support for PS2 based mice. # # Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved. # diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h index 3666ebc85e7a..c2762db03878 100644 --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h @@ -352,7 +352,7 @@ KeyboardReadKeyStroke ( Signal the event if there is key available @param Eventthe event object - @param Context waitting context + @param Context waiting context **/ VOID @@ -411,7 +411,7 @@ KeyboardWaitForKeyEx ( // /** - Reset the input device and optionaly run diagnostics + Reset the input device and optionally run diagnostics @param This - Protocol instance pointer. @param ExtendedVerification - Driver may perform diagnostics on reset. @@ -430,7 +430,7 @@ KeyboardEfiResetEx ( /** Reads the next keystroke from the input device. The WaitForKey Event can -be used to test for existance of a keystroke via WaitForEvent () call. +be used to test for existence of a keystroke via WaitForEvent () call. @param This - Protocol instance pointer. @@ -438,7 +438,7 @@ KeyboardEfiResetEx ( state data for the key that was pressed. @retval EFI_SUCCESS - The keystroke information was returned. -@retval EFI_NOT_READY - There was no keystroke data availiable. +@retval EFI_NOT_READY - There was no keystroke data available. @retval EFI_DEVICE_ERROR - The keystroke information was not returned due to hardware errors. @retval EFI_INVALID_PARAMETER - KeyData is NULL. @@ -486,7 +486,7 @@ KeyboardSetState ( @param NotifyHandle- Points to the unique handle assigned to the registered notification. @retval EFI_SUCCESS - The notification function was registered successfully. -@retval EFI_OUT_OF_RESOURCES- Unable to allocate resources for necesssary data structures. +@retval EFI_OUT_OF_RESOURCES- Unable to allocate resources for necessary data structures. @retval EFI_INVALID_PARAMETER - KeyData or NotifyHandle is NULL. **/ @@ -531,7 +531,7 @@ PushEfikeyBufTail ( ); /** - Judge whether is a registed key + Judge whether is a registered key @param RegsiteredData A pointer to a buffer that is filled in with the keystroke state data for the key that was registered. @@ -539,7 +539,7 @@ PushEfikeyBufTail ( state data for the key that was pressed. @retval TRUEKey be pressed matches a registered key. - @retval FLASE Match failed. + @retval FALSE Match failed. **/ BOOLEAN diff --git a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h index 61380a4d1fc6..60da42121173 100644 --- a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h +++ b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h @@ -362,7 +362,7 @@ CheckForInput ( /** I/O work flow to wait input buffer empty in given time. - @param Timeout Wating time. + @param Timeout Waiting time. @retval EFI_TIMEOUT if input is still not empty in given time. @retval EFI_SUCCESS input is empty. diff --git a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h index df2e283f6da3..1f7c310ad1f4 100644 --- a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h +++ b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h @@ -124,7 +124,7 @@ PS2MouseDriverSupported ( /**
[edk2-devel] [PATCH v2 17/78] MdeModulePkg/Core/PiSmmCore: Fix various typos
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 10
MdeModulePkg/Core/PiSmmCore/HeapGuard.h | 2 +-
MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 12 +-
.../Core/PiSmmCore/PiSmmCorePrivateData.h | 6 ++---
MdeModulePkg/Core/PiSmmCore/Dependency.c | 4 ++--
MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 24 +--
MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 4 ++--
MdeModulePkg/Core/PiSmmCore/Locate.c | 8 +++
.../Core/PiSmmCore/MemoryAttributesTable.c| 8 +++
MdeModulePkg/Core/PiSmmCore/Page.c| 4 ++--
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 10
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c| 8 +++
MdeModulePkg/Core/PiSmmCore/Smi.c | 2 +-
.../Core/PiSmmCore/SmramProfileRecord.c | 4 ++--
14 files changed, 53 insertions(+), 53 deletions(-)
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
index b6b1bbcdac51..619603d6c2a0 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
@@ -57,23 +57,23 @@ [Protocols]
gEfiSmmControl2ProtocolGuid ## CONSUMES
## NOTIFY
## SOMETIMES_CONSUMES
- ## UNDEFINED # Used to do smm communcation
+ ## UNDEFINED # Used to do smm communication
gEfiDxeSmmReadyToLockProtocolGuid
gEfiCpuArchProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
## CONSUMES ## Event
- ## PRODUCES ## UNDEFINED # Used to do smm communcation
+ ## PRODUCES ## UNDEFINED # Used to do smm communication
gEfiEventDxeDispatchGuid
gEfiEventReadyToBootGuid ## CONSUMES ##
Event
## SOMETIMES_CONSUMES ## Event
- ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communcation
+ ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communication
gEfiEventLegacyBootGuid
## SOMETIMES_CONSUMES ## Event
- ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communcation
+ ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communication
gEfiEventExitBootServicesGuid
## SOMETIMES_CONSUMES ## Event
- ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communcation
+ ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communication
gEfiEventReadyToBootGuid
gEfiEventVirtualAddressChangeGuid ## CONSUMES ##
Event
gEfiEndOfDxeEventGroupGuid## CONSUMES ##
Event
diff --git a/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
b/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
index 9077db1a8496..1b5c0f2a4f57 100644
--- a/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
+++ b/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
@@ -39,7 +39,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
//
// For a normal configuration of system with 4G memory, two levels of tables
// can track the whole memory, because two levels (L3+L4) of map tables have
-// already coverred 37-bit of memory address. And for a normal UEFI BIOS,
+// already covered 37-bit of memory address. And for a normal UEFI BIOS,
// less than 128M memory would be consumed during boot. That means we just
// need
//
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
index 0908e7f4e9e7..50a7fccb 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
@@ -171,7 +171,7 @@ typedef struct {
EFI_GUIDProtocolID;
/// All protocol interfaces
LIST_ENTRY Protocols;
- /// Registerd notification handlers
+ /// Registered notification handlers
LIST_ENTRY Notify;
} PROTOCOL_ENTRY;
@@ -562,7 +562,7 @@ SmmLocateHandle (
/**
Return the first Protocol Interface that matches the Protocol GUID. If
Registration is pasased in return a Protocol Instance that was just add
- to the system. If Retistration is NULL return the first Protocol Interface
+ to the system. If Registration is NULL return the first Protocol Interface
you find.
@param Protocol The protocol to search for
@@ -602,7 +602,7 @@ SmmLocateProtocol (
@retval EFI_NOT_FOUND No handles match the search.
@retval EFI_OUT_OF_RESOURCES There is not enough pool memory to store the
matching results.
- @retval EFI_INVALID_PARAMETER One or more paramters are not valid.
+ @retval EFI_INVALID_PARAMETER One or more parameters are not valid.
**/
EFI_STATUS
@@ -641,7 +641,7 @@ SmiManage (
/**
Registers a handler to execute within SMM.
- @param HandlerHandler service funtion pointer.
+ @param HandlerHandler service function pointer.
@param HandlerTypePoints to the handler type or NULL for
[edk2-devel] [PATCH v2 03/78] EmbeddedPkg/VirtualKeyboard: Fix few typos
From: Antoine Coeur Fix few typos in the documentation. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- .../Drivers/VirtualKeyboardDxe/VirtualKeyboard.h | 14 +++--- .../Drivers/VirtualKeyboardDxe/VirtualKeyboard.c | 16 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h index 29bc7a06fb16..026449046653 100644 --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h @@ -323,7 +323,7 @@ VirtualKeyboardReset ( ); /** - Reset the input device and optionaly run diagnostics + Reset the input device and optionally run diagnostics @param This Protocol instance pointer. @param ExtendedVerification Driver may perform diagnostics on reset. @@ -373,7 +373,7 @@ VirtualKeyboardSetState ( @retval EFI_SUCCESS The notification function was registered successfully. - @retval EFI_OUT_OF_RESOURCESUnable to allocate resources for necesssary data structures. + @retval EFI_OUT_OF_RESOURCESUnable to allocate resources for necessary data structures. @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL. **/ @@ -429,7 +429,7 @@ VirtualKeyboardFreeNotifyList ( state data for the key that was pressed. @retval TRUE Key be pressed matches a registered key. - @retval FLASE Match failed. + @retval FALSE Match failed. **/ BOOLEAN @@ -441,7 +441,7 @@ IsKeyRegistered ( /** Waiting on the keyboard event, if there's any key pressed by the user, signal the event - @param Event The event that be siganlled when any key has been stroked. + @param Event The event that be signalled when any key has been stroked. @param Context Pointer of the protocol EFI_SIMPLE_TEXT_INPUT_PROTOCOL. **/ @@ -455,7 +455,7 @@ VirtualKeyboardWaitForKey ( /** Waiting on the keyboard event, if there's any key pressed by the user, signal the event - @param EventThe event that be siganlled when any key has been stroked. + @param EventThe event that be signalled when any key has been stroked. @param Context Pointer of the protocol EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL. **/ @@ -514,14 +514,14 @@ VirtualKeyboardReadKeyStroke ( /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. @param This Protocol instance pointer. @param KeyData A pointer to a buffer that is filled in with the keystroke state data for the key that was pressed. @retval EFI_SUCCESS The keystroke information was returned. - @retval EFI_NOT_READY There was no keystroke data availiable. + @retval EFI_NOT_READY There was no keystroke data available. @retval EFI_DEVICE_ERROR The keystroke information was not returned due to hardware errors. @retval EFI_INVALID_PARAMETER KeyData is NULL. diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c index 750371a06723..e9d0b72ee6c3 100644 --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c @@ -437,7 +437,7 @@ VirtualKeyboardFreeNotifyList ( pressed. @retval TRUEKey be pressed matches a registered key. - @retval FLASE Match failed. + @retval FALSE Match failed. **/ BOOLEAN @@ -476,7 +476,7 @@ IsKeyRegistered ( Signal the event if there is key available @param Eventthe event object - @param Context waitting context + @param Context waiting context **/ VOID @@ -580,7 +580,7 @@ VirtualKeyboardReset ( } /** - Reset the input device and optionaly run diagnostics + Reset the input device and optionally run diagnostics @param This Protocol instance pointer. @param ExtendedVerification Driver may perform diagnostics on reset. @@ -621,7 +621,7 @@ VirtualKeyboardResetEx ( /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. @param VirtualKeyboardPrivate Virtualkeyboard driver private structure. @param KeyData A pointer to a buffer that is filled in @@ -629,7 +629,7 @@ VirtualKeyboardResetEx ( that was pressed.
