[edk2-devel] [PATCH 1/1] Maintainers.txt: Add bhyve reviewers

2020-08-01 Thread Rebecca Cran 
Bhyve files are under OvmfPkg, in OvmfPkg/Bhyve and
various files in OvmfPkg/Library and OvmfPkg/Include.

Update Maintainers.txt to indicate reviewers for all
bhyve-specific files.

Signed-off-by: Rebecca Cran 
Cc: Andrew Fish 
Cc: Laszlo Ersek 
Cc: Leif Lindholm 
Cc: Michael D Kinney 
Cc: Jordan Justen 
Cc: Ard Biesheuvel 
---
 Maintainers.txt | 13 +
 1 file changed, 13 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 5504bb3d17cc..569bd2511a69 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -398,6 +398,19 @@ M: Laszlo Ersek 
 M: Ard Biesheuvel 
 S: Maintained
 
+OvmfPkg: bhyve-related modules
+F: OvmfPkg/Bhyve/
+F: OvmfPkg/Include/IndustryStandard/Bhyve.h
+F: OvmfPkg/Include/Library/BhyveFwCtlLib.h
+F: OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLibBhyve.c
+F: OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLibBhyve.inf
+F: OvmfPkg/Library/BhyveFwCtlLib/
+F: OvmfPkg/Library/PlatformBootManagerLibBhyve/
+F: OvmfPkg/Library/ResetSystemLib/BaseResetShutdownBhyve.c
+F: OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibBhyve.inf
+R: Rebecca Cran 
+R: Peter Grehan 
+
 OvmfPkg: CSM modules
 F: OvmfPkg/Csm/
 R: David Woodhouse 
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63631): https://edk2.groups.io/g/devel/message/63631
Mute This Topic: https://groups.io/mt/75940056/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] TianoCore Design Meeting - APAC/NAMO - Fri, 08/07/2020 9:30am-10:30am #cal-reminder

2020-08-01 Thread devel@edk2.groups.io Calendar 
*Reminder:* TianoCore Design Meeting - APAC/NAMO

*When:* Friday, 7 August 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing

*Where:* https://zoom.us/j/299494771

View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=805409 )

*Organizer:* Ray Ni ray...@intel.com ( 
ray...@intel.com?subject=Re:%20Event:%20TianoCore%20Design%20Meeting%20-%20APAC%2FNAMO
 )

*Description:*

For more info, see here: https://www.tianocore.org/design-meeting/

-
Join Zoom Meeting
-

https://zoom.us/j/299494771

Meeting ID: 299 494 771

One tap mobile

+16699009128,,299494771# US (San Jose)

+13462487799,,299494771# US (Houston)

Dial by your location

​ +1 669 900 9128 US (San Jose)

​ +1 346 248 7799 US (Houston)

​ +1 301 715 8592 US

​ +1 312 626 6799 US (Chicago)

​ +1 646 558 8656 US (New York)

​ +1 253 215 8782 US

Meeting ID: 299 494 771

Find your local number: https://zoom.us/u/ajd9Bs4kZ

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63630): https://edk2.groups.io/g/devel/message/63630
Mute This Topic: https://groups.io/mt/75938592/21656
Mute #cal-reminder: https://groups.io/g/edk2/mutehashtag/cal-reminder
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] [EmbeddedPkg]:Update PrePiLib to return DxeCoreEntrypoint

2020-08-01 Thread Guo Dong 
Added LoadDxeCore() API to return DxeCore entry point after loading DxeCore
from FV, and del LoadDxeCoreFromFfsFile() as it is replaced by LoadDxeCore().
Update LoadDxeCoreFromFv() to use LoadDxeCore() to reduce code, and its
behavior is same.
Updated FfsProcessSection() to support both IA32 and X64 build.
With this patch, PrePiLib could be used by UefiPayloadPkg to load DxeCore
and get its entry point.

Signed-off-by: Guo Dong 
---
 EmbeddedPkg/Include/Library/PrePiLib.h  | 17 ++---
 EmbeddedPkg/Library/PrePiLib/FwVol.c|  2 +-
 EmbeddedPkg/Library/PrePiLib/PrePiLib.c | 95 
+--
 3 files changed, 68 insertions(+), 46 deletions(-)

diff --git a/EmbeddedPkg/Include/Library/PrePiLib.h 
b/EmbeddedPkg/Include/Library/PrePiLib.h
index 54f8e1e582..269907108e 100644
--- a/EmbeddedPkg/Include/Library/PrePiLib.h
+++ b/EmbeddedPkg/Include/Library/PrePiLib.h
@@ -735,11 +735,22 @@ LoadPeCoffImage (
   OUT EFI_PHYSICAL_ADDRESS  *EntryPoint
   );
 
+
+/**
+  Load DXE core from FV and return DXE core entrypoint.
+
+  @param[in]   FvInstanceThe FV instance to search DXE core. Will 
search all the FVs if it is NULL.
+  @param[out]  EntryPointDXE core entrypoint.
+
+  @return  EFI_SUCCESS   The DxeCore is loaded successfully.
+  @return  OthersFailed to load the DxeCore.
+
+**/
 EFI_STATUS
 EFIAPI
-LoadDxeCoreFromFfsFile (
-  IN EFI_PEI_FILE_HANDLE  FileHandle,
-  IN UINTNStackSize
+LoadDxeCore (
+  IN  UINTN *FvInstance,   OPTIONAL
+  OUT EFI_PHYSICAL_ADDRESS  *EntryPoint
   );
 
 EFI_STATUS
diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c 
b/EmbeddedPkg/Library/PrePiLib/FwVol.c
index 881506eddd..46ea5f733f 100644
--- a/EmbeddedPkg/Library/PrePiLib/FwVol.c
+++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c
@@ -298,7 +298,7 @@ FfsProcessSection (
   UINT16  SectionAttribute;
   UINT32  AuthenticationStatus;
   CHAR8   *CompressedData;
-  UINTN   CompressedDataLength;
+  UINT32  CompressedDataLength;
 
 
   *OutputBuffer = NULL;
diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.c 
b/EmbeddedPkg/Library/PrePiLib/PrePiLib.c
index afbe146632..c18b30e22e 100644
--- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.c
+++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.c
@@ -119,30 +119,52 @@ VOID
   IN  VOID *HobStart
   );
 
+/**
+  Load DXE core from FV and return DXE core entrypoint.
+
+  @param[in]   FvInstanceThe FV instance to search DXE core. Will 
search all the FVs if it is NULL.
+  @param[out]  EntryPointDXE core entrypoint.
+
+  @return  EFI_SUCCESS   The DxeCore is loaded successfully.
+  @return  OthersFailed to load the DxeCore.
+
+**/
 EFI_STATUS
 EFIAPI
-LoadDxeCoreFromFfsFile (
-  IN EFI_PEI_FILE_HANDLE  FileHandle,
-  IN UINTNStackSize
+LoadDxeCore (
+  IN  UINTN *FvInstance,   OPTIONAL
+  OUT EFI_PHYSICAL_ADDRESS  *EntryPoint
   )
 {
   EFI_STATUS  Status;
+  EFI_PEI_FV_HANDLE   VolumeHandle;
+  EFI_PEI_FILE_HANDLE FileHandle;
   VOID*PeCoffImage;
   EFI_PHYSICAL_ADDRESSImageAddress;
   UINT64  ImageSize;
-  EFI_PHYSICAL_ADDRESSEntryPoint;
-  VOID*BaseOfStack;
-  VOID*TopOfStack;
-  VOID*Hob;
   EFI_FV_FILE_INFOFvFileInfo;
 
+  FileHandle = NULL;
+  if (FvInstance != NULL) {
+//
+// Caller passed in a specific FV to try, so only try that one
+//
+Status = FfsFindNextVolume (*FvInstance, );
+if (!EFI_ERROR (Status)) {
+  Status = FfsFindNextFile (EFI_FV_FILETYPE_DXE_CORE, VolumeHandle, 
);
+}
+  } else {
+Status = FfsAnyFvFindFirstFile (EFI_FV_FILETYPE_DXE_CORE, , 
);
+DEBUG ((EFI_D_ERROR, "FfsAnyFvFindFirstFile Status = %r\n", Status));
+  }
+
   Status = FfsFindSectionData (EFI_SECTION_PE32, FileHandle, );
   if (EFI_ERROR  (Status)) {
 return Status;
   }
 
 
-  Status = LoadPeCoffImage (PeCoffImage, , , 
);
+  Status = LoadPeCoffImage (PeCoffImage, , , 
EntryPoint);
 // For NT32 Debug  Status = SecWinNtPeiLoadFile (PeCoffImage, , 
, );
   ASSERT_EFI_ERROR (Status);
 
@@ -152,13 +174,33 @@ LoadDxeCoreFromFfsFile (
   Status = FfsGetFileInfo (FileHandle, );
   ASSERT_EFI_ERROR (Status);
 
-  BuildModuleHob (, 
(EFI_PHYSICAL_ADDRESS)(UINTN)ImageAddress, EFI_SIZE_TO_PAGES ((UINT32) 
ImageSize) * EFI_PAGE_SIZE, EntryPoint);
+  BuildModuleHob (, 
(EFI_PHYSICAL_ADDRESS)(UINTN)ImageAddress, EFI_SIZE_TO_PAGES ((UINT32) 
ImageSize) * EFI_PAGE_SIZE, *EntryPoint);
 
-  DEBUG ((EFI_D_INFO | EFI_D_LOAD, "Loading DxeCore at 0x%10p 
EntryPoint=0x%10p\n", (VOID *)(UINTN)ImageAddress, (VOID *)(UINTN)EntryPoint));
+  DEBUG ((EFI_D_INFO | EFI_D_LOAD, "Loading

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

2020-08-01 Thread Laszlo Ersek 
On 07/31/20 19:32, Sean Brogan wrote:

> You can see the ReadMe badge showing the broken state of edk2 master.
> The build with logs can be seen here
> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=10494=logs=ec42d809-3c3b-54a9-276c-e54a8b9aaee9=596e0656-4def-5804-b10b-1585519aa2e8
> and some of the relevant failures are added below.

Fixed in commit e557442e3f7e via
; the badges are green again.

Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63628): https://edk2.groups.io/g/devel/message/63628
Mute This Topic: https://groups.io/mt/75472166/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg: fix DEC spec violation introduced by Bhyve addition

2020-08-01 Thread Laszlo Ersek 
On 08/01/20 17:50, Laszlo Ersek wrote:
> Sean reports that having two DEC files under OvmfPkg violates the DEC
> spec:
> 
>> An EDK II Package (directory) is a directory that contains an EDK II
>> package declaration (DEC) file. Only one DEC file is permitted per
>> directory. EDK II Packages cannot be nested within other EDK II
>> Packages.

Thanks to Sean for the problem report, and to Phil and Rebecca for the
fast reviews.

Merged as commit e557442e3f7e, via
.

The badges at 
are back to green.

Sorry about the regression.
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63627): https://edk2.groups.io/g/devel/message/63627
Mute This Topic: https://groups.io/mt/75929326/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix spelling mistake

2020-08-01 Thread Laszlo Ersek 
On 08/01/20 02:28, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2357
> 
> Cc: Eric Dong 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> Cc: Rahul Kumar 
> Signed-off-by: Michael D Kinney 
> ---
>  UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c 
> b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> index 844052b9a5..822126d355 100644
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> @@ -287,7 +287,7 @@ LmceSupport (
>  
>McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP);
>if (ProcessorNumber == 0) {
> -DEBUG ((EFI_D_INFO, "LMCE eanble = %x\n", (BOOLEAN) 
> (McgCap.Bits.MCG_LMCE_P != 0)));
> +DEBUG ((EFI_D_INFO, "LMCE enable = %x\n", (BOOLEAN) 
> (McgCap.Bits.MCG_LMCE_P != 0)));
>}
>return (BOOLEAN) (McgCap.Bits.MCG_LMCE_P != 0);
>  }
> 

Reviewed-by: Laszlo Ersek 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63626): https://edk2.groups.io/g/devel/message/63626
Mute This Topic: https://groups.io/mt/75918827/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 4/6] OvmfPkg: Fix spelling mistake for occurred

2020-08-01 Thread Laszlo Ersek 
On 08/01/20 03:04, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2361
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Ard Biesheuvel 
> Signed-off-by: Michael D Kinney 
> ---
>  OvmfPkg/Bhyve/BhyveRfbDxe/GopScreen.c | 2 +-
>  OvmfPkg/Include/Protocol/Legacy8259.h | 2 +-
>  OvmfPkg/SioBusDxe/SioService.c| 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/OvmfPkg/Bhyve/BhyveRfbDxe/GopScreen.c 
> b/OvmfPkg/Bhyve/BhyveRfbDxe/GopScreen.c
> index 0760ffb722..672a67fbe1 100644
> --- a/OvmfPkg/Bhyve/BhyveRfbDxe/GopScreen.c
> +++ b/OvmfPkg/Bhyve/BhyveRfbDxe/GopScreen.c
> @@ -226,7 +226,7 @@ EmuGopSetMode (
>  
>@retval EFI_SUCCESS   The Blt operation completed.
>@retval EFI_INVALID_PARAMETER BltOperation is not valid.
> -  @retval EFI_DEVICE_ERROR  A hardware error occured writting to the 
> video buffer.
> +  @retval EFI_DEVICE_ERROR  A hardware error occurred writting to the 
> video buffer.
>  
>  **/
>  EFI_STATUS
> diff --git a/OvmfPkg/Include/Protocol/Legacy8259.h 
> b/OvmfPkg/Include/Protocol/Legacy8259.h
> index 74bbb674ed..7fde1c8537 100644
> --- a/OvmfPkg/Include/Protocol/Legacy8259.h
> +++ b/OvmfPkg/Include/Protocol/Legacy8259.h
> @@ -58,7 +58,7 @@ typedef enum {
>@param  SlaveBase The base vector for the Slave PIC in the 
> 8259 controller.
>  
>@retval EFI_SUCCESS   The new bases were programmed.
> -  @retval EFI_DEVICE_ERROR  A device error occured programming the 
> vector bases.
> +  @retval EFI_DEVICE_ERROR  A device error occurred programming the 
> vector bases.
>  
>  **/
>  typedef
> diff --git a/OvmfPkg/SioBusDxe/SioService.c b/OvmfPkg/SioBusDxe/SioService.c
> index 407132ddcd..ab8fa7676f 100644
> --- a/OvmfPkg/SioBusDxe/SioService.c
> +++ b/OvmfPkg/SioBusDxe/SioService.c
> @@ -265,7 +265,7 @@ SioModify (
>@param[in] DeviceIndex   Index of the device supported by this driver.
>  
>@retval EFI_SUCCESS  The child device has been created 
> successfully.
> -  @retval Others   Error occured during the child device 
> creation.
> +  @retval Others   Error occurred during the child device 
> creation.
>  
>  **/
>  EFI_STATUS
> 

Reviewed-by: Laszlo Ersek 

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63625): https://edk2.groups.io/g/devel/message/63625
Mute This Topic: https://groups.io/mt/75919239/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg: fix DEC spec violation introduced by Bhyve addition

2020-08-01 Thread Rebecca Cran 

On 8/1/20 9:50 AM, Laszlo Ersek wrote:


 - Repo:   https://github.com/lersek/edk2.git
   Branch: bhyve_dec_fix
 
 - Personal CI build: https://github.com/tianocore/edk2/pull/846
 
 - Because the DEC spec violation is breaking CI, I'm going to push this

   as soon as Rebecca (and hopefully Sean) confirm the change is OK.
 
 - Rebecca, please account for the movements / renames in the present

   patch in your upcoming patch for "Maintainers.txt". Thanks!



Reviewed-by: Rebecca Cran 


Thanks! And sorry for the disruption.


--
Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63624): https://edk2.groups.io/g/devel/message/63624
Mute This Topic: https://groups.io/mt/75929326/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] please review the pending MdeModulePkg patches

2020-08-01 Thread Laszlo Ersek 
Hi Jian, Hao,

the following patches have been on the list for several *months* now (multiple 
versons):

- MdeModulePkg: Create PCDs to be used in support of SEV-ES
- MdeModulePkg/DxeIplPeim: Support GHCB pages when creating page tables

The latest posted version of the containing series is v13. Direct links to the 
patches:

- [PATCH v13 01/46] MdeModulePkg: Create PCDs to be used in support of SEV-ES
  https://edk2.groups.io/g/devel/message/63478
  
5165cd142314eb080a7250733cf66b045eb9bf24.1596134638.git.thomas.lendacky@amd.com">http://mid.mail-archive.com/5165cd142314eb080a7250733cf66b045eb9bf24.1596134638.git.thomas.lendacky@amd.com

- [PATCH v13 05/46] MdeModulePkg/DxeIplPeim: Support GHCB pages when creating 
page tables
  https://edk2.groups.io/g/devel/message/63482
  
d118943b5317fb26310ee22212ccdffd9630a681.1596134638.git.thomas.lendacky@amd.com">http://mid.mail-archive.com/d118943b5317fb26310ee22212ccdffd9630a681.1596134638.git.thomas.lendacky@amd.com

Please review these patches urgently, or at least designate someone from Intel 
who should review these patches in your stead.

If you no longer have time for maintaining MdeModulePkg, then please propose 
new maintainers for the package.

Thanks,
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63623): https://edk2.groups.io/g/devel/message/63623
Mute This Topic: https://groups.io/mt/75931580/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v13 45/46] UefiCpuPkg/MpInitLib: Prepare SEV-ES guest APs for OS use

2020-08-01 Thread Laszlo Ersek 
On 07/31/20 23:38, Laszlo Ersek wrote:
> On 07/31/20 16:47, Tom Lendacky wrote:
>> On 7/31/20 9:44 AM, Tom Lendacky wrote:
>>> On 7/31/20 8:36 AM, Tom Lendacky wrote:
 On 7/31/20 7:43 AM, Laszlo Ersek wrote:
> Hi Tom,

 Hi Laszlo,
>>>
>>> Hi Laszlo,
>>>
>>> Can you try this incremental patch to see if it fixes the issue you're
>>> seeing? If it does, I'll merge it into patch #45 and send out a v14.
>>
>> Looking at the formatting, I'm not sure if Thunderbird messed up the
>> diff. I'll send you another copy directly to you using git send-email
>> just in case.
> 
> I got the separate copy; I'll report back sometime next week.

The update works fine; IA32 OVMF boots OK with it.

I agree with squashing the update into patch #45, but before sending
v14, maybe we should get some feedback for the MdeModulePkg patches too,
at long last. :/

Thanks!
Laszlo


> 
>>> diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
>>> b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
>>> index 7165bcf3124a..2c00d72ddefe 100644
>>> --- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
>>> +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
>>> @@ -365,9 +365,9 @@ RelocateApLoop (
>>>   MwaitSupport,
>>>
>>>   CpuMpData->ApTargetCState,
>>>
>>>   CpuMpData->PmCodeSegment,
>>>
>>> -    CpuMpData->Pm16CodeSegment,
>>>
>>>   StackStart - ProcessorNumber * AP_SAFE_STACK_SIZE,
>>>
>>>   (UINTN) ,
>>>
>>> +    CpuMpData->Pm16CodeSegment,
>>>
>>>   CpuMpData->SevEsAPBuffer,
>>>
>>>   CpuMpData->WakeupBuffer
>>>
>>>   );
>>>
>>> diff --git a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm
>>> b/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm
>>> index 309d53bf3b37..7e81d24aa60f 100644
>>> --- a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm
>>> +++ b/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm
>>> @@ -226,7 +226,10 @@ SwitchToRealProcStart:
>>>   SwitchToRealProcEnd:
>>>
>>>  
>>>  
>>> ;-
>>>
>>>
>>> -;  AsmRelocateApLoop (MwaitSupport, ApTargetCState, PmCodeSegment,
>>> TopOfApStack, CountTofinish);
>>>
>>> +;  AsmRelocateApLoop (MwaitSupport, ApTargetCState, PmCodeSegment,
>>> TopOfApStack, CountTofinish, Pm16CodeSegment, SevEsAPJumpTable,
>>> WakeupBuffer);
>>>
>>> +;
>>>
>>> +;  The last three parameters (Pm16CodeSegment, SevEsAPJumpTable and
>>> WakeupBuffer) are
>>>
>>> +;  specific to SEV-ES support and are not applicable on IA32.
>>>
>>>  
>>> ;-
>>>
>>>
>>>   global ASM_PFX(AsmRelocateApLoop)
>>>
>>>   ASM_PFX(AsmRelocateApLoop):
>>>
>>> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h
>>> b/UefiCpuPkg/Library/MpInitLib/MpLib.h
>>> index 267aa5201c50..02652eaae126 100644
>>> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
>>> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
>>> @@ -350,9 +350,9 @@ VOID
>>>     IN BOOLEAN MwaitSupport,
>>>
>>>     IN UINTN   ApTargetCState,
>>>
>>>     IN UINTN   PmCodeSegment,
>>>
>>> -  IN UINTN   Pm16CodeSegment,
>>>
>>>     IN UINTN   TopOfApStack,
>>>
>>>     IN UINTN   NumberToFinish,
>>>
>>> +  IN UINTN   Pm16CodeSegment,
>>>
>>>     IN UINTN   SevEsAPJumpTable,
>>>
>>>     IN UINTN   WakeupBuffer
>>>
>>>     );
>>>
>>> diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
>>> b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
>>> index 3b8ec477b8b3..5d30f35b201c 100644
>>> --- a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
>>> +++ b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
>>> @@ -491,13 +491,13 @@ PM16Mode:
>>>   SwitchToRealProcEnd:
>>>
>>>  
>>>  
>>> ;-
>>>
>>>
>>> -;  AsmRelocateApLoop (MwaitSupport, ApTargetCState, PmCodeSegment,
>>> Pm16CodeSegment, TopOfApStack, CountTofinish, SevEsAPJumpTable,
>>> WakeupBuffer);
>>>
>>> +;  AsmRelocateApLoop (MwaitSupport, ApTargetCState, PmCodeSegment,
>>> TopOfApStack, CountTofinish, Pm16CodeSegment, SevEsAPJumpTable,
>>> WakeupBuffer);
>>>
>>>  
>>> ;-
>>>
>>>
>>>   global ASM_PFX(AsmRelocateApLoop)
>>>
>>>   ASM_PFX(AsmRelocateApLoop):
>>>
>>>   AsmRelocateApLoopStart:
>>>
>>>   BITS 64
>>>
>>> -    cmp    qword [rsp + 56], 0
>>>
>>> +    cmp    qword [rsp + 56], 0  ; SevEsAPJumpTable
>>>
>>>   je NoSevEs
>>>
>>>  
>>>   ;
>>>
>>> @@ -539,16 +539,17 @@ BITS 64
>>>  
>>>   NoSevEs:
>>>
>>>   cli  ; Disable interrupt before
>>> switching to 32-bit mode
>>>
>>> -    mov    rax, [rsp + 48]   ; CountTofinish
>>>
>>> +    mov    rax, [rsp + 40]   ; CountTofinish
>>>
>>>   lock dec   dword [rax]   ; (*CountTofinish)--
>>>
>>>  
>>> +    mov    r10, [rsp + 48]   ; Pm16CodeSegment

Re: [edk2-devel] [PATCH] OvmfPkg: fix DEC spec violation introduced by Bhyve addition

2020-08-01 Thread Philippe Mathieu-Daudé 
On 8/1/20 5:50 PM, Laszlo Ersek wrote:
> Sean reports that having two DEC files under OvmfPkg violates the DEC
> spec:
> 
>> An EDK II Package (directory) is a directory that contains an EDK II
>> package declaration (DEC) file. Only one DEC file is permitted per
>> directory. EDK II Packages cannot be nested within other EDK II
>> Packages.
> 
> This issue originates from commit 656419f922c0 ("Add BhyvePkg, to support
> the bhyve hypervisor", 2020-07-31).
> 
> Remedy the problem as follows. (Note that these steps are not split to
> multiple patches in order to keep Bhyve buildable across the transition.)
> 
> (1) Delete "OvmfPkg/Bhyve/BhyvePkg.dec".
> 
> (2) Point the [Packages] sections of the Bhyve-specific AcpiPlatformDxe,
> BhyveRfbDxe, and BhyveFwCtlLib INF files to "OvmfPkg.dec".
> 
> (3) Migrate the artifacts that "BhyvePkg.dec" used to have on top of
> "OvmfPkg.dec" as follows:
> 
> (3a) Merge the copyright notices from Rebecca Cran and Pluribus Networks
>  into "OvmfPkg.dec".
> 
> (3b) Merge the "BhyveFwCtlLib" class header definition into "OvmfPkg.dec".
> 
> (3c) Merge value 0x2F8 for the fixed PcdDebugIoPort into
>  "BhyvePkgX64.dsc".
> 
> (4) Unnest the the Include/Library/ and Library/ subtrees from under
> OvmfPkg/Bhyve to the corresponding, preexistent subtrees in OvmfPkg.
> The goal is to keep the [Includes] section in the "OvmfPkg.dec" file
> unchanged, plus simplify references in "BhyvePkgX64.dsc". Non-library
> modules remain under "OvmfPkg/Bhyve/".
> 
> (4a) The BhyveFwCtlLib class header, and sole instance, are already
>  uniquely named, so their movements need not involve file renames.
> 
> (4b) Rename the Bhyve-specific PlatformBootManagerLib instance to
>  PlatformBootManagerLibBhyve, in additon to moving it, for
>  distinguishing it from OvmfPkg's preexistent lib instance. Apply the
>  name change to all three of the lib instance directory name, the INF
>  file, and the BASE_NAME define in the INF file.
> 
> (4c) Update lib class resolutions in "BhyvePkgX64.dsc" accordingly.
> 
> (5) Replace the "ACPI table storage" FILE_GUID in
> "OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf" with a new GUID, and
> open-code the "ACPI table storage" GUID in the "ACPITABLE" FDF rule
> instead, replacing $(NAMED_GUID). This step is necessary because CI
> requires unique FILE_GUIDs over all INF files, and OVMF's original
> "AcpiTables.inf" already uses the "ACPI table storage" GUID as
> FILE_GUID.

Thank you for detailing each step, this helped to understand the
changes.

Reviewed-by: Philippe Mathieu-Daude 

> 
> Cc: Ard Biesheuvel 
> Cc: Jordan Justen 
> Cc: Philippe Mathieu-Daudé 
> Cc: Rebecca Cran 
> Cc: Sean Brogan 
> Fixes: 656419f922c047a3c48bd3f4ecea7d8e87d0b761
> Reported-by: Sean Brogan 
> Signed-off-by: Laszlo Ersek 
> ---
> 
> Notes:
> - Repo:   https://github.com/lersek/edk2.git
>   Branch: bhyve_dec_fix
> 
> - Personal CI build: https://github.com/tianocore/edk2/pull/846
> 
> - Because the DEC spec violation is breaking CI, I'm going to push this
>   as soon as Rebecca (and hopefully Sean) confirm the change is OK.
> 
> - Rebecca, please account for the movements / renames in the present
>   patch in your upcoming patch for "Maintainers.txt". Thanks!
> 
>  OvmfPkg/Bhyve/BhyvePkg.dec   
> | 171 
> 
>  OvmfPkg/OvmfPkg.dec  
> |   5 +
>  OvmfPkg/Bhyve/BhyvePkgX64.dsc
> |   5 +-
>  OvmfPkg/Bhyve/BhyvePkgX64.fdf
> |   2 +-
>  OvmfPkg/{Bhyve => }/Include/Library/BhyveFwCtlLib.h  
> |   0
>  OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf
> |   2 +-
>  OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf  
> |   2 +-
>  OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf
> |   2 +-
>  OvmfPkg/{Bhyve => }/Library/BhyveFwCtlLib/BhyveFwCtlLib.inf  
> |   2 +-
>  OvmfPkg/{Bhyve/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf => 
> Library/PlatformBootManagerLibBhyve/PlatformBootManagerLibBhyve.inf} |   2 +-
>

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

2020-08-01 Thread Laszlo Ersek 
On 07/31/20 23:14, Laszlo Ersek wrote:

> Regarding actual actions: I'm going to be away for a short while now.
> Plus, I'm not entirely sure what exactly is being prevented by the
> current state of the tree (i.e., how grave the regression is).
> 
> (1) If the current issue interferes with work on, and usability of,
> other packages (that is, anything *not* OvmfPkg), then I would request
> that one of the stewards please revert 656419f922c0 ("Add BhyvePkg, to
> support the bhyve hypervisor", 2020-07-31). For such a revert, please
> add at once:
> 
> Acked-by: Laszlo Ersek 
> 
> This is because the IRL stuff I've got queued up does not allow me to
> participate in the revert, urgently, either from the reviewer side, or
> even from the submitter side. (I wouldn't like to simply push a revert
> without formal review, and I don't have time to *post* the revert
> urgently). I was about to disappear for a bit, and logged back in only
> because I snuck a peek on the mailing list archive, and noticed the
> problem report.
> 
> After the revert, Rebecca and I can collaborate on the next version of
> the patch (I can review that incrementally against the one being
> reverted under this option).
> 
> (2) If, on the other hand, the current issue is restricted to OvmfPkg
> (and even OvmfPkg platforms other than bhyve can be built), then I'd
> like to ask that we keep commit 656419f922c0, and that Rebecca please
> submit an incremental fix (per the above suggestions, assuming they work).
> 
> ... Upon re-reading your comment "causing the other packages to fail", I
> think we have case (1); if that's right, then please proceed accordingly.

I'm proposing a fix here, rather than a revert:

  [edk2-devel] [PATCH]
  OvmfPkg: fix DEC spec violation introduced by Bhyve addition

  https://edk2.groups.io/g/devel/message/63619
  20200801155024.16439-1-lersek@redhat.com">http://mid.mail-archive.com/20200801155024.16439-1-lersek@redhat.com

The posting includes links to a fetchable topic branch and to a personal
CI build.

I'd really prefer merging this patch, instead of a "revert & redo".

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63620): https://edk2.groups.io/g/devel/message/63620
Mute This Topic: https://groups.io/mt/75472166/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] OvmfPkg: fix DEC spec violation introduced by Bhyve addition

2020-08-01 Thread Laszlo Ersek 
Sean reports that having two DEC files under OvmfPkg violates the DEC
spec:

> An EDK II Package (directory) is a directory that contains an EDK II
> package declaration (DEC) file. Only one DEC file is permitted per
> directory. EDK II Packages cannot be nested within other EDK II
> Packages.

This issue originates from commit 656419f922c0 ("Add BhyvePkg, to support
the bhyve hypervisor", 2020-07-31).

Remedy the problem as follows. (Note that these steps are not split to
multiple patches in order to keep Bhyve buildable across the transition.)

(1) Delete "OvmfPkg/Bhyve/BhyvePkg.dec".

(2) Point the [Packages] sections of the Bhyve-specific AcpiPlatformDxe,
BhyveRfbDxe, and BhyveFwCtlLib INF files to "OvmfPkg.dec".

(3) Migrate the artifacts that "BhyvePkg.dec" used to have on top of
"OvmfPkg.dec" as follows:

(3a) Merge the copyright notices from Rebecca Cran and Pluribus Networks
 into "OvmfPkg.dec".

(3b) Merge the "BhyveFwCtlLib" class header definition into "OvmfPkg.dec".

(3c) Merge value 0x2F8 for the fixed PcdDebugIoPort into
 "BhyvePkgX64.dsc".

(4) Unnest the the Include/Library/ and Library/ subtrees from under
OvmfPkg/Bhyve to the corresponding, preexistent subtrees in OvmfPkg.
The goal is to keep the [Includes] section in the "OvmfPkg.dec" file
unchanged, plus simplify references in "BhyvePkgX64.dsc". Non-library
modules remain under "OvmfPkg/Bhyve/".

(4a) The BhyveFwCtlLib class header, and sole instance, are already
 uniquely named, so their movements need not involve file renames.

(4b) Rename the Bhyve-specific PlatformBootManagerLib instance to
 PlatformBootManagerLibBhyve, in additon to moving it, for
 distinguishing it from OvmfPkg's preexistent lib instance. Apply the
 name change to all three of the lib instance directory name, the INF
 file, and the BASE_NAME define in the INF file.

(4c) Update lib class resolutions in "BhyvePkgX64.dsc" accordingly.

(5) Replace the "ACPI table storage" FILE_GUID in
"OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf" with a new GUID, and
open-code the "ACPI table storage" GUID in the "ACPITABLE" FDF rule
instead, replacing $(NAMED_GUID). This step is necessary because CI
requires unique FILE_GUIDs over all INF files, and OVMF's original
"AcpiTables.inf" already uses the "ACPI table storage" GUID as
FILE_GUID.

Cc: Ard Biesheuvel 
Cc: Jordan Justen 
Cc: Philippe Mathieu-Daudé 
Cc: Rebecca Cran 
Cc: Sean Brogan 
Fixes: 656419f922c047a3c48bd3f4ecea7d8e87d0b761
Reported-by: Sean Brogan 
Signed-off-by: Laszlo Ersek 
---

Notes:
- Repo:   https://github.com/lersek/edk2.git
  Branch: bhyve_dec_fix

- Personal CI build: https://github.com/tianocore/edk2/pull/846

- Because the DEC spec violation is breaking CI, I'm going to push this
  as soon as Rebecca (and hopefully Sean) confirm the change is OK.

- Rebecca, please account for the movements / renames in the present
  patch in your upcoming patch for "Maintainers.txt". Thanks!

 OvmfPkg/Bhyve/BhyvePkg.dec 
  | 171 

 OvmfPkg/OvmfPkg.dec
  |   5 +
 OvmfPkg/Bhyve/BhyvePkgX64.dsc  
  |   5 +-
 OvmfPkg/Bhyve/BhyvePkgX64.fdf  
  |   2 +-
 OvmfPkg/{Bhyve => }/Include/Library/BhyveFwCtlLib.h
  |   0
 OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf  
  |   2 +-
 OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf
  |   2 +-
 OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf  
  |   2 +-
 OvmfPkg/{Bhyve => }/Library/BhyveFwCtlLib/BhyveFwCtlLib.inf
  |   2 +-
 OvmfPkg/{Bhyve/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf => 
Library/PlatformBootManagerLibBhyve/PlatformBootManagerLibBhyve.inf} |   2 +-
 OvmfPkg/{Bhyve/Library/PlatformBootManagerLib => 
Library/PlatformBootManagerLibBhyve}/BdsPlatform.h  
|   0
 OvmfPkg/{Bhyve => }/Library/BhyveFwCtlLib/BhyveFwCtlLib.c  
  |   0
 OvmfPkg/{Bhyve/Library/PlatformBootManagerLib =>

Re: [edk2-devel] [PATCH] Check return status on calls to GetTime()

2020-08-01 Thread Heinrich Schuchardt 
On 7/31/20 7:19 PM, Grant Likely wrote:
> Not all platforms implement GetTime(), but the SCT just assumes calls to
> GetTime will be successful. If GetTime() doesn't return EFI_SUCCESS,
> then the EFI_TIME value will be uninitialized data.
>
> Fix by checking the GetTime() return code. If it doesn't return
> EFI_SUCCESS, then use the traditional 1/1/1970 epoch so that the test
> report at least looks sane, but it is obvious that we don't have a valid
> timestamp.
>
> Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=2870
>
> Cc: G Edhaya Chandran 
> Cc: Heinrich Schuchardt 
> Cc: Samer El-Haj-Mahmoud 
> Signed-off-by: Grant Likely 
> ---
>  .../SimpleNetwork/SimpleNetworkENTSTestCase.c | 26 +--
>  .../MiscBootServicesBBTestFunction.c  |  8 --
>  .../DriverBindingBBTestFunction.c |  5 +++-
>  .../SCT/Drivers/StandardTest/StandardTest.c   | 11 +---
>  .../Framework/ENTS/EasDispatcher/Core/Eas.c   |  9 +--
>  .../ENTS/EasDispatcher/Exec/EasCmdDisp.c  | 20 +-
>  6 files changed, 57 insertions(+), 22 deletions(-)
>
> diff --git 
> a/uefi-sct/SctPkg/TestCase/RIVL/Protocol/SimpleNetwork/SimpleNetworkENTSTestCase.c
>  
> b/uefi-sct/SctPkg/TestCase/RIVL/Protocol/SimpleNetwork/SimpleNetworkENTSTestCase.c
> index 9c8d2a70..5579be7e 100644
> --- 
> a/uefi-sct/SctPkg/TestCase/RIVL/Protocol/SimpleNetwork/SimpleNetworkENTSTestCase.c
> +++ 
> b/uefi-sct/SctPkg/TestCase/RIVL/Protocol/SimpleNetwork/SimpleNetworkENTSTestCase.c
> @@ -24,6 +24,8 @@ Abstract:
>
>  #include "SimpleNetworkENTSTestCase.h"
>
> +static EFI_TIME Epoch = { .Year = 1970, .Month = 1, .Day = 1 };
> +
>  //
>  // SimpleNetwork.Start
>  //
> @@ -928,7 +930,8 @@ Returns:
>Status  = EFI_SUCCESS;
>tBS->Stall (5000);
>
> -  tRT->GetTime (, NULL);
> +  if (tRT->GetTime (, NULL) != EFI_SUCCESS)
> +BeginTime = Epoch;
>for (Index = 0; Index < 1;) {
>  Status = SimpleNetwork->Transmit (
>SimpleNetwork,
> @@ -964,7 +967,8 @@ Returns:
>  }
>}
>
> -  tRT->GetTime (, NULL);
> +  if (tRT->GetTime (, NULL) != EFI_SUCCESS)
> +BeginTime = Epoch;
>
>for (Index = 1; Index < TransmitPattern1Number;) {
>  Status = SimpleNetwork->Transmit (
> @@ -1002,7 +1006,8 @@ Returns:
>}
>
>  End:
> -  tRT->GetTime (, NULL);
> +  if (tRT->GetTime (, NULL) != EFI_SUCCESS)
> +EndTime = Epoch;
>
>*TransmitPattern1Status = Status;
>
> @@ -1125,7 +1130,8 @@ Returns:
>Status  = EFI_SUCCESS;
>tBS->Stall (5000);
>
> -  tRT->GetTime (, NULL);
> +  if (tRT->GetTime (, NULL) != EFI_SUCCESS)
> +BeginTime = Epoch;
>for (Index = 0; Index < 1;) {
>  Status = SimpleNetwork->Transmit (
>SimpleNetwork,
> @@ -1161,7 +1167,8 @@ Returns:
>  }
>}
>
> -  tRT->GetTime (, NULL);
> +  if (tRT->GetTime (, NULL) != EFI_SUCCESS)
> +BeginTime = Epoch;
>
>for (Index = 1; Index < TransmitPattern2Number;) {
>  Status = SimpleNetwork->Transmit (
> @@ -1199,7 +1206,8 @@ Returns:
>}
>
>  End:
> -  tRT->GetTime (, NULL);
> +  if (tRT->GetTime (, NULL) != EFI_SUCCESS)
> +EndTime = Epoch;
>
>*TransmitPattern1Status = Status;
>
> @@ -1326,7 +1334,8 @@ Returns:
>  }
>}
>
> -  tRT->GetTime (, NULL);
> +  if (tRT->GetTime (, NULL) != EFI_SUCCESS)
> +BeginTime = Epoch;
>
>for (Index = 1; Index < ReceivePattern1Number;) {
>  *ReceivePattern1BufferSize = BufferSizeOrg;
> @@ -1346,7 +1355,8 @@ Returns:
>  }
>}
>
> -  tRT->GetTime (, NULL);
> +  if (tRT->GetTime (, NULL) != EFI_SUCCESS)
> +EndTime = Epoch;
>
>*ReceivePattern1Status = Status;
>
> diff --git 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c
>  
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c
> index 1d231d8c..3a530282 100644
> --- 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c
> +++ 
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c
> @@ -27,6 +27,8 @@ Abstract:
>  #include "SctLib.h"

I tried to apply your patch with 'git am --keep-cr'. This chunk has a
problem.

While all other lines in the file have CR LF line endings this very line
has only LF in EDK2 master. But your patch has CR LF for the line.

Did you use Windows and not Linux to create the patch?

I could apply your patch after removing the extraneous CR.

With your patch applied if GetTime() returns EFI_UNSUPPORTED, the test
log is not garbled anymore:

SetVariable_Conf:
Test Finished: 01/01/70  12:00a
Elapsed Time: 00 Days 00:00:00

If GetTime() is available:

SetVariable_Conf:
Test Finished: 08/01/20  01:52p
Elapsed Time: 00 Days 00:00:04

Except for the line-endings:

Reviewed-by: Heinrich Schuchardt 

>  #include "MiscBootServicesBBTestMain.h"
>
> +static EFI_TIME

Re: [edk2-devel] [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix spelling mistake

2020-08-01 Thread Dong, Eric 
Reviewed-by: Eric Dong 

> -Original Message-
> From: Kinney, Michael D 
> Sent: Saturday, August 1, 2020 8:28 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kumar, Rahul1 
> Subject: [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix spelling mistake
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2357
> 
> Cc: Eric Dong 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> Cc: Rahul Kumar 
> Signed-off-by: Michael D Kinney 
> ---
>  UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> index 844052b9a5..822126d355 100644
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> @@ -287,7 +287,7 @@ LmceSupport (
> 
>McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP);
>if (ProcessorNumber == 0) {
> -DEBUG ((EFI_D_INFO, "LMCE eanble = %x\n", (BOOLEAN)
> (McgCap.Bits.MCG_LMCE_P != 0)));
> +DEBUG ((EFI_D_INFO, "LMCE enable = %x\n", (BOOLEAN)
> (McgCap.Bits.MCG_LMCE_P != 0)));
>}
>return (BOOLEAN) (McgCap.Bits.MCG_LMCE_P != 0);
>  }
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63617): https://edk2.groups.io/g/devel/message/63617
Mute This Topic: https://groups.io/mt/75918827/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-