[edk2-devel] [PATCH 1/1] BaseTools: remove directly calling for gcc command

2022-07-07 Thread Yuwei Chen 
In some environment, the directly calling for gcc is not supported.
Thus replace gcc to $(CC).

Cc: Bob Feng 
Cc: Liming Gao 
Signed-off-by: Yuwei Chen 
---
 BaseTools/Source/C/DevicePath/GNUmakefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile 
b/BaseTools/Source/C/DevicePath/GNUmakefile
index c217674345b1..f683efc5648a 100644
--- a/BaseTools/Source/C/DevicePath/GNUmakefile
+++ b/BaseTools/Source/C/DevicePath/GNUmakefile
@@ -13,7 +13,7 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o 
DevicePathFromText.o  DevicePathUtili
 
 include $(MAKEROOT)/Makefiles/app.makefile
 
-GCCVERSION = $(shell gcc -dumpversion | awk -F'.' '{print $$1}')
+GCCVERSION = $(shell $(CC) -dumpversion | awk -F'.' '{print $$1}')
 ifneq ("$(GCCVERSION)", "5")
 ifneq ($(CXX), llvm)
 # gcc 12 trips over device path handling
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91176): https://edk2.groups.io/g/devel/message/91176
Mute This Topic: https://groups.io/mt/92246093/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] MinPlatformPkg: Resolve SecureBootVariableLib dependency

2022-07-07 Thread Zhiguang Liu 
The new changes in SecureBootVariableLib brought in a new dependency of
PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
MinPlatformPkg builds.

Cc: Kun Qin 
Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Liming Gao 
Cc: Eric Dong 
Signed-off-by: Zhiguang Liu 
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc 
b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index 58a18fae6e..b77d55dfd5 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -141,6 +141,7 @@
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !endif
 
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
-- 
2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91175): https://edk2.groups.io/g/devel/message/91175
Mute This Topic: https://groups.io/mt/92244799/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Fix nasm warning "signed byte value exceeds"

2022-07-07 Thread Ni, Ray 
Reviewed-by: Ray Ni 

> -Original Message-
> From: Liu, Zhiguang 
> Sent: Wednesday, July 6, 2022 9:10 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Dong, Eric ; 
> Ni, Ray ; Kumar,
> Rahul1 ; De, Debkumar ; Han, 
> Harry ; West,
> Catharine 
> Subject: [PATCH v2] UefiCpuPkg: Fix nasm warning "signed byte value exceeds"
> 
> Currently, "push byte %[Vector]" causes nasm warning when Vector is larger
> than 0x7F. This is because push accepts a signed value, and byte means
> signed int8. Maximum signed int8 is 0x7F.
> When Vector is larger the 0x7F, for example, when Vector is 255, byte 255
> turns to -1, and causes the warning "signed byte value exceeds".
> To avoid such warning, use dword instead of byte, this will increase 3 bytes
> for each IdtVector.
> For IA32, the size of IdtVector will increase from 10 bytes to 13 bytes.
> For X64, the size of IdtVector will increase from 15 bytes to 18 bytes.
> 
> Cc: Eric Dong 
> Cc: Ray Ni 
> Cc: Rahul Kumar 
> Cc: Debkumar De 
> Cc: Harry Han 
> Cc: Catharine West 
> Signed-off-by: Zhiguang Liu 
> ---
>  .../Library/CpuExceptionHandlerLib/CpuExceptionCommon.h   |  2 +-
>  .../CpuExceptionHandlerLib/Ia32/ExceptionHandlerAsm.nasm  |  7 +++
>  .../CpuExceptionHandlerLib/X64/Xcode5ExceptionHandlerAsm.nasm | 11 
> +--
>  3 files changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h
> index 0f012bccde..fd42c4be0f 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h
> @@ -22,7 +22,7 @@
> 
>  #define  CPU_EXCEPTION_NUM32
>  #define  CPU_INTERRUPT_NUM256
> -#define  HOOKAFTER_STUB_SIZE  16
> +#define  HOOKAFTER_STUB_SIZE  18
> 
>  //
>  // Exception Error Code of Page-Fault Exception
> diff --git 
> a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ExceptionHandlerAsm.nasm
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ExceptionHandlerAsm.nasm
> index 8ed2b8f455..31a00449a2 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ExceptionHandlerAsm.nasm
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ExceptionHandlerAsm.nasm
> @@ -34,7 +34,7 @@ ALIGN   8
>  AsmIdtVectorBegin:
>  %assign Vector 0
>  %rep  256
> -pushbyte %[Vector];
> +pushstrict dword %[Vector];
>  pusheax
>  mov eax, ASM_PFX(CommonInterruptEntry)
>  jmp eax
> @@ -43,9 +43,8 @@ AsmIdtVectorBegin:
>  AsmIdtVectorEnd:
> 
>  HookAfterStubBegin:
> -db  0x6a; push
> +pushstrict dword 0  ; 0 will be fixed
>  VectorNum:
> -db  0  ; 0 will be fixed
>  pusheax
>  mov eax, HookAfterStubHeaderEnd
>  jmp eax
> @@ -453,5 +452,5 @@ global ASM_PFX(AsmVectorNumFixup)
>  ASM_PFX(AsmVectorNumFixup):
>  mov eax, dword [esp + 8]
>  mov ecx, [esp + 4]
> -mov [ecx + (VectorNum - HookAfterStubBegin)], al
> +mov [ecx + (VectorNum - 4 - HookAfterStubBegin)], al
>  ret
> diff --git 
> a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionHandlerAsm.nasm
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionHandlerAsm.nasm
> index 7c0e3d3b0b..9574785742 100644
> --- 
> a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionHandlerAsm.nasm
> +++ 
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionHandlerAsm.nasm
> @@ -57,18 +57,17 @@ ALIGN   8
>  AsmIdtVectorBegin:
>  %assign Vector 0
>  %rep  256
> -pushbyte %[Vector]
> +pushstrict dword %[Vector] ; This instruction pushes sign-extended 
> 8-byte value on stack
>  pushrax
> -mov rax, strict qword 0 ;mov rax, 
> ASM_PFX(CommonInterruptEntry)
> +mov rax, strict qword 0; mov rax, 
> ASM_PFX(CommonInterruptEntry)
>  jmp rax
>  %assign Vector Vector+1
>  %endrep
>  AsmIdtVectorEnd:
> 
>  HookAfterStubHeaderBegin:
> -db  0x6a; push
> -@VectorNum:
> -db  0  ; 0 will be fixed
> +pushstrict dword 0  ; 0 will be fixed
> +VectorNum:
>  pushrax
>  mov rax, strict qword 0 ; mov rax, HookAfterStubHeaderEnd
>  JmpAbsoluteAddress:
> @@ -478,6 +477,6 @@ ASM_PFX(AsmGetTemplateAddressMap):
>  global ASM_PFX(AsmVectorNumFixup)
>  ASM_PFX(AsmVectorNumFixup):
>  mov rax, rdx
> -mov [rcx + (@VectorNum - HookAfterStubHeaderBegin)], al
> +mov [rcx + (VectorNum - 4 - HookAfterStubHeaderBegin)], al
>  ret
> 
> --
> 2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91173): https://edk2.groups.io/g/devel/message/91173
Mute This Topic: https://groups.io/mt/92205812/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 07/07/2022 #cal-reminder

2022-07-07 Thread Group Notification 
*Reminder: TianoCore Community Meeting - APAC/NAMO*

*When:*
07/07/2022
7:30pm to 8:30pm
(UTC-07:00) America/Los Angeles

*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%22b286b53a-1218-4db3-bfc9-3d4c5aa7669e%22%7d

*Organizer:* Miki Demeter

View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1519382 )

*Description:*

Microsoft Teams meeting

*Join on your computer or mobile app*

Click here to join the meeting ( 
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%22b286b53a-1218-4db3-bfc9-3d4c5aa7669e%22%7d
 )

*Join with a video conferencing device*

te...@conf.intel.com

Video Conference ID: 119 132 712 6

Alternate VTC dialing instructions ( 
https://conf.intel.com/teams/?conf=1191327126=teams=conf.intel.com=test_call
 )

*Or call in (audio only)*

+1 916-245-6934,,494156131# ( tel:+19162456934,,494156131# ) United States, 
Sacramento

Phone Conference ID: 494 156 131#

Find a local number ( 
https://dialin.teams.microsoft.com/d195d438-2daa-420e-b9ea-da26f9d1d6d5?id=494156131
 ) | Reset PIN ( https://mysettings.lync.com/pstnconferencing )

Learn More ( https://aka.ms/JoinTeamsMeeting ) | Meeting options ( 
https://teams.microsoft.com/meetingOptions/?organizerId=b286b53a-1218-4db3-bfc9-3d4c5aa7669e=46c98d88-e344-4ed4-8496-4ed7712e255d=19_meeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh@thread.v2=0=en-US
 )


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91172): https://edk2.groups.io/g/devel/message/91172
Mute This Topic: https://groups.io/mt/92243730/21656
Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 07/07/2022 #cal-reminder

2022-07-07 Thread Group Notification 
*Reminder: TianoCore Community Meeting - APAC/NAMO*

*When:*
07/07/2022
7:30pm to 8:30pm
(UTC-07:00) America/Los Angeles

*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%22b286b53a-1218-4db3-bfc9-3d4c5aa7669e%22%7d

*Organizer:* Miki Demeter

View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1519382 )

*Description:*

Microsoft Teams meeting

*Join on your computer or mobile app*

Click here to join the meeting ( 
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%22b286b53a-1218-4db3-bfc9-3d4c5aa7669e%22%7d
 )

*Join with a video conferencing device*

te...@conf.intel.com

Video Conference ID: 119 132 712 6

Alternate VTC dialing instructions ( 
https://conf.intel.com/teams/?conf=1191327126=teams=conf.intel.com=test_call
 )

*Or call in (audio only)*

+1 916-245-6934,,494156131# ( tel:+19162456934,,494156131# ) United States, 
Sacramento

Phone Conference ID: 494 156 131#

Find a local number ( 
https://dialin.teams.microsoft.com/d195d438-2daa-420e-b9ea-da26f9d1d6d5?id=494156131
 ) | Reset PIN ( https://mysettings.lync.com/pstnconferencing )

Learn More ( https://aka.ms/JoinTeamsMeeting ) | Meeting options ( 
https://teams.microsoft.com/meetingOptions/?organizerId=b286b53a-1218-4db3-bfc9-3d4c5aa7669e=46c98d88-e344-4ed4-8496-4ed7712e255d=19_meeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh@thread.v2=0=en-US
 )


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91171): https://edk2.groups.io/g/devel/message/91171
Mute This Topic: https://groups.io/mt/92243730/21656
Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 2/7] MdePkg: Allow PcdFSBClock to by Dynamic

2022-07-07 Thread gaoliming via groups.io 
Ray:

 The problem is that PcdFSBClock is configured as Dynamic on OVMF. 

 

Anthony:

 Have you any suggestion for this problem?

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 ray_l...@hotmail.com
发送时间: 2022年7月7日 12:13
收件人: Anthony PERARD ; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 2/7] MdePkg: Allow PcdFSBClock to by Dynamic

 

On Thu, Mar 25, 2021 at 11:47 PM, Anthony PERARD wrote:

- ## This value is used to configure X86 Processor FSB clock.
- # @Prompt FSB Clock.
- gEfiMdePkgTokenSpaceGuid.PcdFSBClock|2|UINT32|0x000c

hi, Sir

This change caused the OVMF failed to load in QEMU when compiled with 
"SOURCE_DEBUG_ENABLE" as True.

the verbose message of QEMU shows:

ASSERT [SecMain] d:\myedk2\edk2\MdePkg\Library\BasePcdLibNull\PcdLib.c(95): 
((BOOLEAN)(0==1))

The failure point is  PcdGet32 (PcdFSBClock) of debugtimer.c,  I  rolled back 
above change, then issue disappeared.







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91170): https://edk2.groups.io/g/devel/message/91170
Mute This Topic: https://groups.io/mt/92243726/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel][PATCH V1 1/1] UefiCpuPkg/SecCore: Add debug messages to illuminate data flow

2022-07-07 Thread Dong, Eric 
Reviewed-by: Eric Dong 

-Original Message-
From: Oram, Isaac W  
Sent: Tuesday, June 28, 2022 6:49 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Dong, Eric ; 
Ni, Ray ; Kumar, Rahul1 ; De, 
Debkumar ; Han, Harry ; West, 
Catharine 
Subject: [edk2-devel][PATCH V1 1/1] UefiCpuPkg/SecCore: Add debug messages to 
illuminate data flow

Add debug messages to make it easier to verify PlatformSecLib is passing the 
data properly.

Cc: Eric Dong 
Cc: Ray Ni 
Cc: Rahul Kumar 
Cc: Debkumar De 
Cc: Harry Han 
Cc: Catharine West 
Signed-off-by: Isaac Oram 
---
 UefiCpuPkg/SecCore/SecMain.c | 37 
 1 file changed, 37 insertions(+)

diff --git a/UefiCpuPkg/SecCore/SecMain.c b/UefiCpuPkg/SecCore/SecMain.c index 
a7526be9dd..4edf0ce972 100644
--- a/UefiCpuPkg/SecCore/SecMain.c
+++ b/UefiCpuPkg/SecCore/SecMain.c
@@ -167,6 +167,15 @@ SecStartup (
 EFI_SOFTWARE_SEC | EFI_SW_SEC_PC_ENTRY_POINT
 );
 
+  DEBUG ((
+DEBUG_INFO,
+"%a() TempRAM Base: 0x%x, TempRAM Size: 0x%x, BootFirmwareVolume 0x%x\n",
+__FUNCTION__,
+TempRamBase,
+SizeOfRam,
+BootFirmwareVolume
+));
+
   PeiStackSize = PcdGet32 (PcdPeiTemporaryRamStackSize);
   if (PeiStackSize == 0) {
 PeiStackSize = (SizeOfRam >> 1);
@@ -229,6 +238,20 @@ SecStartup (
   SecCoreData.StackBase  = (VOID *)(UINTN)(TempRamBase + 
SecCoreData.PeiTemporaryRamSize);
   SecCoreData.StackSize  = PeiStackSize;
 
+  DEBUG ((
+DEBUG_INFO,
+"%a() BFV Base: 0x%x, BFV Size: 0x%x, TempRAM Base: 0x%x, TempRAM Size: 
0x%x, PeiTempRamBase: 0x%x, PeiTempRamSize: 0x%x, StackBase: 0x%x, StackSize: 
0x%x\n",
+__FUNCTION__,
+SecCoreData.BootFirmwareVolumeBase,
+SecCoreData.BootFirmwareVolumeSize,
+SecCoreData.TemporaryRamBase,
+SecCoreData.TemporaryRamSize,
+SecCoreData.PeiTemporaryRamBase,
+SecCoreData.PeiTemporaryRamSize,
+SecCoreData.StackBase,
+SecCoreData.StackSize
+));
+
   //
   // Initialize Debug Agent to support source level debug in SEC/PEI phases 
before memory ready.
   //
@@ -318,6 +341,13 @@ SecStartupPhase2 (
 }
   }
 
+  DEBUG ((
+DEBUG_INFO,
+"%a() PeiCoreEntryPoint: 0x%x\n",
+__FUNCTION__,
+PeiCoreEntryPoint
+));
+
   if (PpiList != NULL) {
 AllSecPpiList = (EFI_PEI_PPI_DESCRIPTOR *)SecCoreData->PeiTemporaryRamBase;
 
@@ -360,6 +390,13 @@ SecStartupPhase2 (
 //
 SecCoreData->PeiTemporaryRamBase  = (VOID 
*)(((UINTN)SecCoreData->PeiTemporaryRamBase + 7) & ~0x07);
 SecCoreData->PeiTemporaryRamSize &= ~(UINTN)0x07;
+DEBUG ((
+  DEBUG_INFO,
+  "%a() PeiTemporaryRamBase: 0x%x, PeiTemporaryRamSize: 0x%x\n",
+  __FUNCTION__,
+  SecCoreData->PeiTemporaryRamBase,
+  SecCoreData->PeiTemporaryRamSize
+  ));
   } else {
 //
 // No addition PPI, PpiList directly point to the common PPI list.
--
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91169): https://edk2.groups.io/g/devel/message/91169
Mute This Topic: https://groups.io/mt/92033232/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-categorize ACPI FADT PCDs

2022-07-07 Thread Oram, Isaac W 
Reviewed-by: Isaac Oram 

-Original Message-
From: Sinha, Ankit  
Sent: Thursday, July 7, 2022 10:34 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Dong, 
Eric 
Subject: [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-categorize 
ACPI FADT PCDs

From: ankit13s 

1. Removing ACPI PCDs that were re-defined in board package 2. Re-categorize 
PCDs based on MinPlatformPkg definition

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec | 16   
Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc |  7 ---
 2 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec 
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
index 7d8e0f34a104..fa2d61c9a71b 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
@@ -237,17 +237,11 @@
   #  is large enough to meet PEI requirement in the S3 phase.
   # @Prompt Reserved S3 Boot ACPI Memory Size
   
gPlatformModuleTokenSpaceGuid.PcdS3AcpiReservedMemorySize|0x8000|UINT32|0x90010039
-  gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-  gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicCount|0|UINT8|0x9015
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicIdBase|0x09|UINT8|0x9016
   
gPlatformModuleTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000|UINT32|0x9017
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicInterruptBase|24|UINT32|0x9018
 
-
-  gPlatformModuleTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9025
-  gPlatformModuleTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x9026
-  gPlatformModuleTokenSpaceGuid.PcdFadtFlags|0x86A5|UINT32|0x9027
   
gPlatformModuleTokenSpaceGuid.PcdLocalApicAddress|0xFEE0|UINT32|0x900B
   gPlatformModuleTokenSpaceGuid.PcdIoApicAddress|0xFEC0|UINT32|0x900D
   gPlatformModuleTokenSpaceGuid.PcdIoApicId|0x02|UINT8|0x9014
@@ -438,16 +432,6 @@
   #  0x7F, 0xFF, 0x04, 0x00}
   gPlatformModuleTokenSpaceGuid.PcdTrustedConsoleOutputDevicePath|{0x02, 0x01, 
0x0C, 0x00, 0xd0, 0x41, 0x03, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x06, 
0x00,  0x00, 0x02, 0x7F, 0xFF, 0x04, 0x00}|VOID*|0x30C
 
-
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AEventBlockAddress|0x1800|UINT16|0x00010035
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0x|UINT16|0x00010036
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AControlBlockAddress|0x1804|UINT16|0x0001037
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BControlBlockAddress|0x|UINT16|0x00010038
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850|UINT16|0x00010039
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UINT16|0x0001003A
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0x0001003B
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x|UINT16|0x0001003C
-
 #
 # UBA_START
 #
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc 
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
index 8c4b9cf6ce28..cefee8273b27 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
@@ -397,9 +397,6 @@
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicInterruptBase|24
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
   gMinPlatformPkgTokenSpaceGuid.PcdLocalApicAddress|0xFEE0
   gMinPlatformPkgTokenSpaceGuid.PcdIoApicAddress|0xFEC0
   gMinPlatformPkgTokenSpaceGuid.PcdIoApicId|0x08
@@ -510,6 +507,10 @@
   gPlatformTokenSpaceGuid.PcdBootMenuFile|{ 0xdc, 0x5b, 0xc2, 0xee, 0xf2, 
0x67, 0x95, 0x4d, 0xb1, 0xd5, 0xf8, 0x1b, 0x20, 0x39, 0xd1, 0x1d }
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+
 [PcdsDynamicExDefault.X64]
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits|8
--
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91168): https://edk2.groups.io/g/devel/message/91168
Mute This Topic: https://groups.io/mt/92233724/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH V1 5/6] Platform/Intel: Removing ACPI FADT PCDs that are redefined

2022-07-07 Thread Oram, Isaac W 
Reviewed-by: Isaac Oram 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Sinha, Ankit
Sent: Thursday, July 7, 2022 10:33 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Dong, 
Eric 
Subject: [edk2-devel] [edk2-platforms PATCH V1 5/6] Platform/Intel: Removing 
ACPI FADT PCDs that are redefined

From: ankit13s 

Some PCDs are redefined in board package DEC file. Need to remove them.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec 
b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
index 196460e170b5..766dc5be4f6d 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
@@ -89,8 +89,6 @@ 
gPlatformModuleTokenSpaceGuid.PcdApicIoAddress|0xFEC0|UINT64|0x900D
 gPlatformModuleTokenSpaceGuid.PcdApicIoMmioSize|0x1000|UINT32|0x900E
 gPlatformModuleTokenSpaceGuid.PcdGttMmAddress|0xCF00|UINT64|0x900F
 gPlatformModuleTokenSpaceGuid.PcdGmAdrAddress|0xD000|UINT64|0x9010
-gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
 
gPlatformModuleTokenSpaceGuid.PcdPcieDockBridgeResourcePatchSmi|0x4D|UINT8|0x9014
 gPlatformModuleTokenSpaceGuid.PcdCmosFastBootDefaultValue|0x01|UINT8|0x9016
 
gPlatformModuleTokenSpaceGuid.PcdCmosDebugPrintErrorLevelDefaultValue|0x8046|UINT32|0x9017
-- 
2.27.0.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91167): https://edk2.groups.io/g/devel/message/91167
Mute This Topic: https://groups.io/mt/92233723/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH V1 4/6] Platform/Intel: Updating PCD category based on MinPlatformPkg

2022-07-07 Thread Oram, Isaac W 
Reviewed-by: Isaac Oram 

-Original Message-
From: Sinha, Ankit  
Sent: Thursday, July 7, 2022 10:33 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Dong, 
Eric 
Subject: [edk2-platforms PATCH V1 4/6] Platform/Intel: Updating PCD category 
based on MinPlatformPkg

From: ankit13s 

ACPI PCDs need to be re-categorized based on MinPlatformPkg definition

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 10 
+++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git 
a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc 
b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
index 9b81726623dc..44b6a812772d 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
@@ -186,9 +186,6 @@
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x450
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x408
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0003
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x0
   gMinPlatformPkgTokenSpaceGuid.PcdLocalApicAddress|0xFEE0
   gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuCoreCount|128
   gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuSocketCount|4
@@ -268,6 +265,13 @@
   gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|3
   gUefiCpuPkgTokenSpaceGuid.PcdCpuS3DataAddress|0
 
+  ##
+  # Platform Configuration
+  ##
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0003
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x0
+
 [PcdsDynamicExDefault.X64]
   ##
   # Edk2 Configuration
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91166): https://edk2.groups.io/g/devel/message/91166
Mute This Topic: https://groups.io/mt/92233720/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH V1 3/6] Platform/Intel: Modifying PCD category based on MinPlatformPkg

2022-07-07 Thread Oram, Isaac W 
Reviewed-by: Isaac Oram 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Sinha, Ankit
Sent: Thursday, July 7, 2022 10:33 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Dong, 
Eric 
Subject: [edk2-devel] [edk2-platforms PATCH V1 3/6] Platform/Intel: Modifying 
PCD category based on MinPlatformPkg

From: ankit13s 

PCDs need to be re-categorized based on the changes in MinPlatformPkg definition

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc | 8 
  Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc | 
8 
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git 
a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc 
b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc
index 6f6fb20d461c..050f9b6228ef 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.ds
+++ c
@@ -254,10 +254,6 @@
   gEfiCpuTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
   gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
-
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiEnableSwSmi|0xA0
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiDisableSwSmi|0xA1
 
@@ -372,6 +368,10 @@
 
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+
 [PcdsDynamicExDefault.X64]
 
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
diff --git 
a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc 
b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc
index bed0625df9ef..5940c40dfc9d 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.ds
+++ c
@@ -257,10 +257,6 @@
   gEfiCpuTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
   gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
-
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiEnableSwSmi|0xA0
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiDisableSwSmi|0xA1
 
@@ -375,6 +371,10 @@
 
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+
 [PcdsDynamicExDefault.X64]
 
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
--
2.27.0.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91165): https://edk2.groups.io/g/devel/message/91165
Mute This Topic: https://groups.io/mt/92233719/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH V1 2/6] Platform/Intel: Removing ACPI FADT PCDs that are redefined

2022-07-07 Thread Oram, Isaac W 
Reviewed-by: Isaac Oram 

-Original Message-
From: Sinha, Ankit  
Sent: Thursday, July 7, 2022 10:33 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Dong, 
Eric 
Subject: [edk2-platforms PATCH V1 2/6] Platform/Intel: Removing ACPI FADT PCDs 
that are redefined

From: ankit13s 

Some ACPI PCDs are redefined in board package DEC file. Removing those 
instances.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec 
b/Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec
index 1f8322eaeb22..eca92392be14 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec
+++ b/Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec
@@ -89,8 +89,6 @@ 
gPlatformModuleTokenSpaceGuid.PcdApicIoAddress|0xFEC0|UINT64|0x900D
 gPlatformModuleTokenSpaceGuid.PcdApicIoMmioSize|0x1000|UINT32|0x900E
 gPlatformModuleTokenSpaceGuid.PcdGttMmAddress|0xCF00|UINT64|0x900F
 gPlatformModuleTokenSpaceGuid.PcdGmAdrAddress|0xD000|UINT64|0x9010
-gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
 
gPlatformModuleTokenSpaceGuid.PcdPcieDockBridgeResourcePatchSmi|0x4D|UINT8|0x9014
 gPlatformModuleTokenSpaceGuid.PcdCmosFastBootDefaultValue|0x01|UINT8|0x9016
 
gPlatformModuleTokenSpaceGuid.PcdCmosDebugPrintErrorLevelDefaultValue|0x8046|UINT32|0x9017
--
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91164): https://edk2.groups.io/g/devel/message/91164
Mute This Topic: https://groups.io/mt/92233717/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH V1 1/6] Platform/Intel: Modifying PCD class for some ACPI related PCDs

2022-07-07 Thread Oram, Isaac W 
Reviewed-by: Isaac Oram 

-Original Message-
From: Sinha, Ankit  
Sent: Thursday, July 7, 2022 10:33 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Dong, 
Eric 
Subject: [edk2-platforms PATCH V1 1/6] Platform/Intel: Modifying PCD class for 
some ACPI related PCDs

From: ankit13s 

Some PCDs related to FADT entries need to be defined as dynamic for boottime 
customization and update.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 29 
++-
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 24 
+---
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec   | 30 
++--
 3 files changed, 44 insertions(+), 39 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c 
b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 3c9f79de5c6c..c7e87cbd7d9d 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1068,7 +1068,7 @@ InstallMcfgFromScratch (
  >Header,
  
EFI_ACPI_3_0_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE,
  EFI_ACPI_MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_REVISION,
- 0
+ FixedPcdGet32 (PcdAcpiDefaultOemRevision)
  );
   if (EFI_ERROR (Status)) {
 return Status;
@@ -1195,6 +1195,7 @@ PlatformUpdateTables (
 FadtHeader->PreferredPmProfile= PcdGet8 
(PcdFadtPreferredPmProfile);
 FadtHeader->IaPcBootArch  = PcdGet16 
(PcdFadtIaPcBootArch);
 FadtHeader->Flags = PcdGet32 (PcdFadtFlags);
+FadtHeader->SmiCmd= PcdGet32 (PcdFadtSmiCmd);
 FadtHeader->AcpiEnable= PcdGet8 
(PcdAcpiEnableSwSmi);
 FadtHeader->AcpiDisable   = PcdGet8 
(PcdAcpiDisableSwSmi);
 FadtHeader->Pm1aEvtBlk= PcdGet16 
(PcdAcpiPm1AEventBlockAddress);
@@ -1209,6 +1210,7 @@ PlatformUpdateTables (
 FadtHeader->Gpe1Base  = PcdGet8 (PcdAcpiGpe1Base);
 
 FadtHeader->XPm1aEvtBlk.Address   = PcdGet16 
(PcdAcpiPm1AEventBlockAddress);
+FadtHeader->XPm1bEvtBlk.Address   = PcdGet16 
(PcdAcpiPm1BEventBlockAddress);
 FadtHeader->XPm1aCntBlk.Address   = PcdGet16 
(PcdAcpiPm1AControlBlockAddress);
 FadtHeader->XPm1bCntBlk.Address   = PcdGet16 
(PcdAcpiPm1BControlBlockAddress);
 FadtHeader->XPm2CntBlk.Address= PcdGet16 
(PcdAcpiPm2ControlBlockAddress);
@@ -1216,7 +1218,7 @@ PlatformUpdateTables (
 FadtHeader->XGpe0Blk.Address  = PcdGet16 
(PcdAcpiGpe0BlockAddress);
 FadtHeader->XGpe1Blk.Address  = PcdGet16 
(PcdAcpiGpe1BlockAddress);
 
-FadtHeader->ResetReg.AccessSize   = PcdGet8 
(PcdAcpiResetRegAccessSize);
+FadtHeader->ResetReg.AccessSize   = PcdGet8 
(PcdAcpiResetRegisterAccessSize);
 FadtHeader->XPm1aEvtBlk.AccessSize= PcdGet8 
(PcdAcpiXPm1aEvtBlkAccessSize);
 FadtHeader->XPm1bEvtBlk.AccessSize= PcdGet8 
(PcdAcpiXPm1bEvtBlkAccessSize);
 FadtHeader->XPm1aCntBlk.AccessSize= PcdGet8 
(PcdAcpiXPm1aCntBlkAccessSize);
@@ -1226,22 +1228,23 @@ PlatformUpdateTables (
 FadtHeader->XGpe0Blk.AccessSize   = PcdGet8 
(PcdAcpiXGpe0BlkAccessSize);
 FadtHeader->XGpe1Blk.AccessSize   = PcdGet8 
(PcdAcpiXGpe1BlkAccessSize);
 
-FadtHeader->SleepControlReg.AddressSpaceId= PcdGet8 
(PcdAcpiSleepControlRegAddressSpaceId);
-FadtHeader->SleepControlReg.RegisterBitOffset = PcdGet8 
(PcdAcpiSleepControlRegRegisterBitOffset);
-FadtHeader->SleepControlReg.AccessSize= PcdGet8 
(PcdAcpiSleepControlRegAccessSize);
-FadtHeader->SleepControlReg.Address   = PcdGet64 
(PcdAcpiSleepControlRegAddress);
-FadtHeader->SleepStatusReg.AddressSpaceId = PcdGet8 
(PcdAcpiSleepStatusRegAddressSpaceId);
-FadtHeader->SleepStatusReg.RegisterBitWidth   = PcdGet8 
(PcdAcpiSleepStatusRegRegisterBitWidth);
-FadtHeader->SleepStatusReg.RegisterBitOffset  = PcdGet8 
(PcdAcpiSleepStatusRegRegisterBitOffset);
-FadtHeader->SleepStatusReg.AccessSize = PcdGet8 
(PcdAcpiSleepStatusRegAccessSize);
-FadtHeader->SleepStatusReg.Address= PcdGet64 
(PcdAcpiSleepStatusRegAddress);
+FadtHeader->SleepControlReg.AddressSpaceId= PcdGet8 
(PcdAcpiSleepControlRegisterAddressSpaceId);
+FadtHeader->SleepControlReg.RegisterBitWidth  = PcdGet8 
(PcdAcpiSleepControlRegisterBitWidth);
+FadtHeader->SleepControlReg.RegisterBitOffset = PcdGet8 
(PcdAcpiSleepControlRegisterBitOffset);
+

Re: [edk2-devel] [PATCH 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTPS Proxy Server for HTTP Boot

2022-07-07 Thread Saloni Kasbekar 
Hi Maciej,


  1.  I will update the code to add a new function to split that code into a 
separate function. Once the basic auth patch is checked in, I’ll re-send the 
changes for review so that we have the complete logic in the new function.
  2.  I see your point. I’ll update the code to fix it.
  3.  The code has been updated to include the proxy server and the endpoint 
server in the device path. Currently the device path just includes one URI 
which is described as (server_path/file_path). I’ve added a new option so that 
we can add an endpoint server to that device path to include the proxy server 
option. This will be have two URIs in the device path. For eg - 
(endpoint_server_path) /(proxy_server_path/file_path). If this is ok with you, 
I can update the code so that the comments makes this more clear.

Thanks,
Saloni

From: Rabeda, Maciej 
Sent: Friday, July 1, 2022 7:05 AM
To: Kasbekar, Saloni ; devel@edk2.groups.io
Cc: Wu, Jiaxin ; Siyuan Fu ; Wang, 
Jian J ; Gao, Liming 
Subject: Re: [PATCH 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTPS Proxy 
Server for HTTP Boot


Hi Saloni,

This patch contains several problems. At minimum:

  1.  HttpBootLoadFile() logic around calling HttpBootGetBootFile() is becoming 
more complex - and BZ 2504 patch adds to it. I am becoming convinced that this 
part of HttpBootLoadFile() should have a separate function with a looped state 
machine, to cover all cases.
  2.  EfiHttpRequest(): "EndPointUrl = AllocateZeroPool (UrlLen)" followed 
with... "EndPointUrl = (CHAR8 *)Request->EndPointUrl". Was it supposed to be a 
copy from Request->EndPointUrl to EndPointUrl buffer or some other operation 
that I cannot comprehend?
  3.  Could you provide more more information on device path shenanigans around 
proxy URI?
Thanks,
Maciej
On 23 cze 2022 00:54, Saloni Kasbekar wrote:

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3951



Add CONNECT HTTP command in order to create a tunnel from HTTPS

Proxy Server to EndPoint Server.

Add support to connect through proxy server using DevicePath

sent to the Boot Manager.



Cc: Maciej Rabeda 


Cc: Wu Jiaxin 

Cc: Siyuan Fu 

Cc: Jian J Wang 

Cc: Liming Gao 

Signed-off-by: Saloni Kasbekar 


---

 .../Library/UefiBootManagerLib/BmBoot.c   |  11 ++

 MdePkg/Include/Protocol/Http.h|   5 +

 NetworkPkg/HttpBootDxe/HttpBootClient.c   | 168 +-

 NetworkPkg/HttpBootDxe/HttpBootClient.h   |  16 ++

 NetworkPkg/HttpBootDxe/HttpBootDxe.h  |   6 +

 NetworkPkg/HttpBootDxe/HttpBootImpl.c |  46 +++--

 NetworkPkg/HttpBootDxe/HttpBootSupport.c  |  13 +-

 NetworkPkg/HttpBootDxe/HttpBootSupport.h  |   8 +-

 NetworkPkg/HttpDxe/HttpImpl.c |  21 ++-

 NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c|   5 +

 10 files changed, 273 insertions(+), 26 deletions(-)



diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c 
b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c

index 962892d38f14..c5f09b619a89 100644

--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c

+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c

@@ -1513,7 +1513,9 @@ BmExpandLoadFiles (

   UINTN HandleCount;

   UINTN Index;

   EFI_DEVICE_PATH_PROTOCOL  *Node;

+  URI_DEVICE_PATH   *NullUriPath;



+  NullUriPath = NULL;

   //

   // Get file buffer from load file instance.

   //

@@ -1543,10 +1545,19 @@ BmExpandLoadFiles (

   HandleCount = 0;

 }



+NullUriPath = (URI_DEVICE_PATH *)CreateDeviceNode (

+   MESSAGING_DEVICE_PATH,

+   MSG_URI_DP,

+   (UINT16)(sizeof (URI_DEVICE_PATH))

+   );

+

 for (Index = 0; Index < HandleCount; Index++) {

   if (BmMatchHttpBootDevicePath (DevicePathFromHandle (Handles[Index]), 
FilePath)) {

 Handle = Handles[Index];

 break;

+  } else if (BmMatchHttpBootDevicePath (AppendDevicePathNode 
(DevicePathFromHandle (Handles[Index]), (EFI_DEVICE_PATH_PROTOCOL 
*)NullUriPath), FilePath)) {

+Handle = Handles[Index];

+break;

   }

 }



diff --git a/MdePkg/Include/Protocol/Http.h b/MdePkg/Include/Protocol/Http.h

index 28e622159392..4cf8fa4c0c97 100644

--- a/MdePkg/Include/Protocol/Http.h

+++ b/MdePkg/Include/Protocol/Http.h

@@ -191,6 +191,11 @@ typedef struct {

   /// is assumed. See RFC 3986 for more details on URI syntax.

   ///

   CHAR16 *Url;

+  ///

+  /// The URI of an endpoint host if the Url field contains the address of a 
proxy server.

+  /// This field will be NULL if a proxy server is not involved.

+  ///

+  CHAR16 *EndPointUrl;

 }

Re: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs

2022-07-07 Thread Michael D Kinney 
Hi Liming,

I think the current Mm specific INF is actually compatible with all module 
types.

Why not add a Base version that can be used by any module?

Using Peim in name implies it is only compatible with PEIMs which is not true.

For the compatibility question, I would like to see feedback from Mm maintainers
to see if they would accept a library name change to a more general purpose
Base INF.

Mike

> -Original Message-
> From: gaoliming 
> Sent: Wednesday, July 6, 2022 6:37 PM
> To: Albecki, Mateusz ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Liu, Zhiguang 
> 
> Subject: 回复: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
> 
> Mateusz:
>   To be compatible, I suggest to add one new UefiDevicePathLibPeim.inf for
> PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf except for
> module type and base name.
> 
>   The source file rename is the compatible change. It can be made.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Mateusz Albecki 
> > 发送时间: 2022年7月1日 22:12
> > 收件人: devel@edk2.groups.io
> > 抄送: Mateusz Albecki ; Michael D Kinney
> > ; Liming Gao ;
> > Zhiguang Liu 
> > 主题: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
> >
> > DevicePathLib utilities are useful in PEI to locate the devices which need
> > an opal unlock on S3 resume. This commit reuses the implementation done
> > for standalone MM support and makes the StandaloneMm library Base.
> >
> > Signed-off-by: Mateusz Albecki 
> >
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Cc: Zhiguang Liu 
> >
> > ---
> >  ...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
> >  ...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6 +++---
> >  MdePkg/MdePkg.dsc   |
> > 2 +-
> >  3 files changed, 4 insertions(+), 4 deletions(-)
> >  rename
> > MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.c =>
> > DevicePathUtilitiesBase.c} (100%)
> >  rename
> > MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.inf =>
> > UefiDevicePathLibBase.inf} (87%)
> >
> > diff --git
> > a/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > b/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > similarity index 100%
> > rename from
> > MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > rename to MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > diff --git
> > a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > similarity index 87%
> > rename from
> > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > rename to MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > index 23fedf38b7..323043033f 100644
> > ---
> > a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > @@ -16,10 +16,10 @@
> >BASE_NAME  = UefiDevicePathLib
> >MODULE_UNI_FILE= UefiDevicePathLib.uni
> >FILE_GUID  =
> > D8E58437-44D3-4154-B7A7-EB794923EF12
> > -  MODULE_TYPE= MM_STANDALONE
> > +  MODULE_TYPE= BASE
> >PI_SPECIFICATION_VERSION   = 0x00010032
> >VERSION_STRING = 1.0
> > -  LIBRARY_CLASS  = DevicePathLib |
> > MM_STANDALONE MM_CORE_STANDALONE
> > +  LIBRARY_CLASS  = DevicePathLib
> >
> >
> >  #
> > @@ -28,7 +28,7 @@
> >
> >  [Sources]
> >DevicePathUtilities.c
> > -  DevicePathUtilitiesStandaloneMm.c
> > +  DevicePathUtilitiesBase.c
> >DevicePathToText.c
> >DevicePathFromText.c
> >UefiDevicePathLib.c
> > diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
> > index 3d8874e647..9daee93523 100644
> > --- a/MdePkg/MdePkg.dsc
> > +++ b/MdePkg/MdePkg.dsc
> > @@ -111,7 +111,7 @@
> >
> > MdePkg/Library/UefiDebugLibDebugPortProtocol/UefiDebugLibDebugPortPro
> > tocol.inf
> >MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > -  MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > +  MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> >
> > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathPro
> > tocol.inf
> >
> > MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDe
> > vicePathProtocol.inf
> >MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> > --
> > 2.28.0.windows.1
> >
> > -
> > Intel Technology Poland sp. z o.o.
> > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
> > Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP
> > 957-07-52-316 | Kapital zakladowy 200.000 PLN.
> > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> > adresata i moze

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

2022-07-07 Thread Jeff Brasen via groups.io 
Just following up on my outstanding edk2 patches to check on status/review 
feedback.

Thanks,
Jeff

> -Original Message-
> From: Jeff Brasen 
> Sent: Tuesday, June 14, 2022 11:54 AM
> To: devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn;
> zhichao@intel.com; ray...@intel.com; Jeff Brasen
> 
> Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info
> support for Ufs
> 
> Add support for getting disk info from UFS devices.
> 
> Signed-off-by: Jeff Brasen 
> ---
>  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c| 3 ++-
>  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> index fac33b9ee9..87b82f299f 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> 
> 
>BmEliminateExtraSpaces (Description);
> 
>  }
> 
> -  } else if (CompareGuid (>Interface,
> )) {
> 
> +  } else if (CompareGuid (>Interface,
> ) ||
> 
> + CompareGuid (>Interface,
> )) {
> 
>  BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> 
>  Status = DiskInfo->Inquiry (
> 
>   DiskInfo,
> 
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index fe05d5f1cc..2fc0a80a4e 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -85,6 +85,7 @@
>gEfiDiskInfoIdeInterfaceGuid  ## SOMETIMES_CONSUMES ## GUID
> 
>gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
> 
>gEfiDiskInfoSdMmcInterfaceGuid## SOMETIMES_CONSUMES ##
> GUID
> 
> +  gEfiDiskInfoUfsInterfaceGuid  ## SOMETIMES_CONSUMES ##
> GUID
> 
> 
> 
>  [Protocols]
> 
>gEfiPciRootBridgeIoProtocolGuid   ## CONSUMES
> 
> --
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91160): https://edk2.groups.io/g/devel/message/91160
Mute This Topic: https://groups.io/mt/91755004/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs

2022-07-07 Thread Jeff Brasen via groups.io 
Just following up on my outstanding edk2 patches to check on status/review 
feedback.

Thanks,
Jeff

> -Original Message-
> From: Jeff Brasen
> Sent: Friday, June 17, 2022 9:38 AM
> To: gaoliming ; devel@edk2.groups.io;
> bob.c.f...@intel.com
> Cc: 'Chen, Christine' 
> Subject: RE: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs
> 
> Anything else needed prior to getting this merged to edk2?
> 
> > -Original Message-
> > From: gaoliming 
> > Sent: Thursday, May 19, 2022 7:19 PM
> > To: devel@edk2.groups.io; bob.c.f...@intel.com; Jeff Brasen
> > 
> > Cc: 'Chen, Christine' 
> > Subject: 回复: [edk2-devel] [PATCH] .gitignore: Ignore build tools build
> > logs
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Reviewed-by: Liming Gao 
> >
> > > -邮件原件-
> > > 发件人: devel@edk2.groups.io  代表 Bob Feng
> > > 发送时间: 2022年5月18日 15:15
> > > 收件人: devel@edk2.groups.io; Gao, Liming
> > ;
> > > jbra...@nvidia.com
> > > 抄送: Chen, Christine 
> > > 主题: Re: [edk2-devel] [PATCH] .gitignore: Ignore build tools build
> > > logs
> > >
> > > They are the BaseTools build log files that are generated by
> > > BaseTools/Edk2ToolsBuild.py.
> > >
> > > Thanks,
> > > Bob
> > >
> > > -Original Message-
> > > From: devel@edk2.groups.io  On Behalf Of
> > > gaoliming
> > > Sent: Wednesday, May 18, 2022 2:40 PM
> > > To: devel@edk2.groups.io; jbra...@nvidia.com
> > > Cc: Feng, Bob C ; Chen, Christine
> > > 
> > > Subject: 回复: [edk2-devel] [PATCH] .gitignore: Ignore build tools
> > > build logs
> > >
> > > Bob:
> > >   Do you know what files will be generated in
> > > BaseTools/BaseToolsBuild directory?
> > >
> > > Thanks
> > > Liming
> > > > -邮件原件-
> > > > 发件人: devel@edk2.groups.io  代表 Jeff
> > Brasen
> > > via
> > > > groups.io
> > > > 发送时间: 2022年4月22日 1:01
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn;
> > > > yuwei.c...@intel.com; Jeff Brasen 
> > > > 主题: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs
> > > >
> > > > The python BaseTools/Edk2ToolsBuild.py creates files in
> > > > BaseTools/BaseToolsBuild and should be ignored.
> > > >
> > > > Signed-off-by: Jeff Brasen 
> > > > ---
> > > >  BaseTools/.gitignore | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore index
> > > > a45689bc89..ddf93b7116 100644
> > > > --- a/BaseTools/.gitignore
> > > > +++ b/BaseTools/.gitignore
> > > > @@ -17,4 +17,5 @@ Source/C/VfrCompile/VfrTokens.h  Source/C/bin/
> > > > Source/C/libs/
> > > >  Bin/Win32
> > > > -Lib
> > > > \ No newline at end of file
> > > > +Lib
> > > > +BaseToolsBuild/
> > > > \ No newline at end of file
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > 
> > >
> >
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91159): https://edk2.groups.io/g/devel/message/91159
Mute This Topic: https://groups.io/mt/91823747/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 2/7] MdePkg: Allow PcdFSBClock to by Dynamic

2022-07-07 Thread ray_linn 
On Thu, Mar 25, 2021 at 11:47 PM, Anthony PERARD wrote:

> 
> - ## This value is used to configure X86 Processor FSB clock.
> - # @Prompt FSB Clock.
> - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|2|UINT32|0x000c

hi, Sir

This change caused the OVMF failed to load in QEMU when compiled with 
"SOURCE_DEBUG_ENABLE" as True.

the verbose message of QEMU shows:

> 
> ASSERT [SecMain]
> d:\myedk2\edk2\MdePkg\Library\BasePcdLibNull\PcdLib.c(95):
> ((BOOLEAN)(0==1))

The failure point is  PcdGet32 (PcdFSBClock) of debugtimer.c,  I  rolled back 
above change, then issue disappeared.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91158): https://edk2.groups.io/g/devel/message/91158
Mute This Topic: https://groups.io/mt/81605800/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2] UefiPayloadPkg: Add CryptoDxe driver to UefiPayload

2022-07-07 Thread paytonx . hsieh 
From: PaytonX Hsieh 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3979

Add CryptoDxe into UPL.
Drviers can locate protocol instead of building openssl lib into drivers.
This can reduce the binary size that UPL required.

Cc: Guo Dong 
Cc: Ray Ni 
Cc: James Lu 
Cc: Gua Guo 
Signed-off-by: PaytonX Hsieh 
---
 UefiPayloadPkg/UefiPayloadPkg.dsc | 36 ++--
 UefiPayloadPkg/UefiPayloadPkg.fdf |  1 +
 2 files changed, 35 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc 
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index cfcf38578d..2428bb2ce9 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -180,8 +180,8 @@
   
CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
   DxeHobListLib|UefiPayloadPkg/Library/DxeHobListLib/DxeHobListLib.inf
-  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
-  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
+  BaseCryptLib|CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
+  TlsLib|CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
   IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
   OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
   RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
@@ -412,6 +412,29 @@
   gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE)
   gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|180
 
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Md5.Family  
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Dh.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Random.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Family  
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.X509.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Tdes.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  
gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.GetContextSize
  | TRUE
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.Init   
 | TRUE
+  
gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.CbcEncrypt
  | TRUE
+  
gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.CbcDecrypt
  | TRUE
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Arc4.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family  
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Tls.Family  
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsSet.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsGet.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+
 [PcdsPatchableInModule.X64]
   gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)
   gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER)
@@ -719,6 +742,15 @@
   MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
 !endif
 
+  #
+  # Misc
+  #
+  CryptoPkg/Driver/CryptoDxe.inf {
+
+  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
+  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
+  }
+
   #--
   #  Build the shell
   #--
diff --git

[edk2-devel] [PATCH] MdePkg/include: Update DMAR definitions to Intel VT-d spec ver4.0

2022-07-07 Thread Robert Kowalewski 
Updated DMAR definitions accordingly to changes in Intel(R) Virtualization
Technology for Directed I/O (VT-D) Architecture Specification ver4.0.

Added new definition of remapping structure - SIDP. The SoC Integrated
Device Property (SIDP) reporting structure identifies devices that have
special properties and that may put restrictions on how system software
must configure remapping structures that govern such devices in a platform
where remapping hardware is enabled.

Updated DRHD definition - field 'reserved' is replaced with 'Size'.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3978

Signed-off-by: Robert Kowalewski 

Cc: Michael D Kinney 
Cc: Liming Gao 
Cc: Zhiguang Liu 
Cc: Jenny Huang 
Cc: Sheng Wei 
---
 .../DmaRemappingReportingTable.h  | 46 +++
 1 file changed, 38 insertions(+), 8 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h 
b/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
index 193e4bced5..00588ff234 100644
--- a/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
+++ b/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
@@ -2,12 +2,12 @@
   DMA Remapping Reporting (DMAR) ACPI table definition from Intel(R)
   Virtualization Technology for Directed I/O (VT-D) Architecture Specification.
 
-  Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
+  Copyright (c) 2016 - 2022, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Revision Reference:
 - Intel(R) Virtualization Technology for Directed I/O (VT-D) Architecture
-  Specification v3.2, Dated October 2020.
+  Specification v4.0, Dated June 2022.
   
https://software.intel.com/content/dam/develop/external/us/en/documents/vt-directed-io-spec.pdf
 
   @par Glossary:
@@ -41,6 +41,7 @@
 #define EFI_ACPI_DMAR_TYPE_RHSA  0x03
 #define EFI_ACPI_DMAR_TYPE_ANDD  0x04
 #define EFI_ACPI_DMAR_TYPE_SATC  0x05
+#define EFI_ACPI_DMAR_TYPE_SIDP  0x06
 ///@}
 
 ///
@@ -56,6 +57,12 @@
 #define EFI_ACPI_DEVICE_SCOPE_ENTRY_TYPE_IOAPIC 0x03
 #define EFI_ACPI_DEVICE_SCOPE_ENTRY_TYPE_MSI_CAPABLE_HPET   0x04
 #define EFI_ACPI_DEVICE_SCOPE_ENTRY_TYPE_ACPI_NAMESPACE_DEVICE  0x05
+
+#define EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_NESTED_NOTALLOWED  BIT0
+#define EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_PWSNP_NOTALLOWED   BIT1
+#define EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_PGSNP_NOTALLOWED   BIT2
+#define EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_ATC_HARDENED   BIT3
+#define EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_ATC_REQUIRED   BIT4
 ///@}
 
 ///
@@ -83,11 +90,12 @@ typedef struct {
 /// Device Scope Structure is defined in section 8.3.1
 ///
 typedef struct {
-  UINT8 Type;
-  UINT8 Length;
-  UINT16Reserved2;
-  UINT8 EnumerationId;
-  UINT8 StartBusNumber;
+  UINT8Type;
+  UINT8Length;
+  UINT8Flags;
+  UINT8Reserved;
+  UINT8EnumerationId;
+  UINT8StartBusNumber;
 } EFI_ACPI_DMAR_DEVICE_SCOPE_STRUCTURE_HEADER;
 
 /**
@@ -111,7 +119,14 @@ typedef struct {
 - Bits[7:1] Reserved.
   **/
   UINT8 Flags;
-  UINT8 Reserved;
+
+  /**
+- Bits[3:0]: Indicates the size of the remapping hardware register set for
+ this remapping unit. If the value in this field is N, the size
+ of the register set is 2^N 4 KB pages
+- Bits[7:4]: Reserved.
+  **/
+  UINT8 Size;
   ///
   /// The PCI Segment associated with this unit.
   ///
@@ -249,6 +264,20 @@ typedef struct {
   UINT16SegmentNumber;
 } EFI_ACPI_DMAR_SATC_HEADER;
 
+/**
+  SoC Integrated Device Property (SIDP) Reporting Structure is defined in
+  section 8.9.
+**/
+typedef struct {
+  EFI_ACPI_DMAR_STRUCTURE_HEADERHeader;
+
+  UINT16Reserved;
+  ///
+  /// The PCI Segment associated with this SIDP structure.
+  ///
+  UINT16SegmentNumber;
+} EFI_ACPI_DMAR_SIDP_HEADER;
+
 /**
   DMA Remapping Reporting Structure Header as defined in section 8.1
   This header will be followed by list of Remapping Structures listed below
@@ -258,6 +287,7 @@ typedef struct {
 - Remapping Hardware Static Affinity (RHSA)
 - ACPI Name-space Device Declaration (ANDD)
 - SoC Integrated Address Translation Cache reporting (SATC)
+- SoC Integrated Device Property reporting (SIDP)
   These structure types must by reported in numerical order.
   i.e., All remapping structures of type 0 (DRHD) enumerated before remapping
   structures of type 1 (RMRR), and so forth.
-- 
2.32.0.windows.1

-
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial 
Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | 
Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i 
moze zawierac informacje poufne. W razie

[edk2-devel] [PATCH] UefiPayloadPkg: Add CryptoDxe driver to UefiPayload

2022-07-07 Thread paytonx . hsieh 
From: PaytonX Hsieh 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3979

Add macro CRYPTO_ENABLE to decide to build CryptoDxe into UPL.
Drviers can locate protocol instead of building openssl lib into drivers.
This can reduce the binary size that UPL required.

Cc: Guo Dong 
Cc: Ray Ni 
Cc: James Lu 
Cc: Gua Guo 
Signed-off-by: PaytonX Hsieh 
---
 UefiPayloadPkg/UefiPayloadPkg.dsc | 42 +++
 UefiPayloadPkg/UefiPayloadPkg.fdf |  3 +++
 2 files changed, 45 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc 
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index cfcf38578d..782635431b 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -36,6 +36,7 @@
   DEFINE PLATFORM_BOOT_TIMEOUT= 3
   DEFINE ABOVE_4G_MEMORY  = TRUE
   DEFINE BOOT_MANAGER_ESCAPE  = FALSE
+  DEFINE CRYPTO_ENABLE= FALSE
   DEFINE SD_MMC_TIMEOUT   = 100
   #
   # SBL:  UEFI payload for Slim Bootloader
@@ -180,8 +181,13 @@
   
CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
   DxeHobListLib|UefiPayloadPkg/Library/DxeHobListLib/DxeHobListLib.inf
+!if $(CRYPTO_ENABLE) == TRUE
+  BaseCryptLib|CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
+  TlsLib|CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
+!else
   BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
   TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
+!endif
   IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
   OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
   RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
@@ -412,6 +418,31 @@
   gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE)
   gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|180
 
+!if $(CRYPTO_ENABLE) == TRUE
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Md5.Family  
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Dh.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Random.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Family  
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.X509.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Tdes.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  
gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.GetContextSize
  | TRUE
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.Init   
 | TRUE
+  
gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.CbcEncrypt
  | TRUE
+  
gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.CbcDecrypt
  | TRUE
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Arc4.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family  
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Family 
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Tls.Family  
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsSet.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsGet.Family   
 | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
+!endif
+
 [PcdsPatchableInModule.X64]
   gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)

[edk2-devel] [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-categorize ACPI FADT PCDs

2022-07-07 Thread Sinha, Ankit 
From: ankit13s 

1. Removing ACPI PCDs that were re-defined in board package
2. Re-categorize PCDs based on MinPlatformPkg definition

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec | 16 
 Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc |  7 ---
 2 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec 
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
index 7d8e0f34a104..fa2d61c9a71b 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
@@ -237,17 +237,11 @@
   #  is large enough to meet PEI requirement in the S3 phase.
   # @Prompt Reserved S3 Boot ACPI Memory Size
   
gPlatformModuleTokenSpaceGuid.PcdS3AcpiReservedMemorySize|0x8000|UINT32|0x90010039
-  gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-  gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicCount|0|UINT8|0x9015
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicIdBase|0x09|UINT8|0x9016
   
gPlatformModuleTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000|UINT32|0x9017
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicInterruptBase|24|UINT32|0x9018
 
-
-  gPlatformModuleTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9025
-  gPlatformModuleTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x9026
-  gPlatformModuleTokenSpaceGuid.PcdFadtFlags|0x86A5|UINT32|0x9027
   
gPlatformModuleTokenSpaceGuid.PcdLocalApicAddress|0xFEE0|UINT32|0x900B
   gPlatformModuleTokenSpaceGuid.PcdIoApicAddress|0xFEC0|UINT32|0x900D
   gPlatformModuleTokenSpaceGuid.PcdIoApicId|0x02|UINT8|0x9014
@@ -438,16 +432,6 @@
   #  0x7F, 0xFF, 0x04, 0x00}
   gPlatformModuleTokenSpaceGuid.PcdTrustedConsoleOutputDevicePath|{0x02, 0x01, 
0x0C, 0x00, 0xd0, 0x41, 0x03, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x06, 
0x00,  0x00, 0x02, 0x7F, 0xFF, 0x04, 0x00}|VOID*|0x30C
 
-
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AEventBlockAddress|0x1800|UINT16|0x00010035
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0x|UINT16|0x00010036
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AControlBlockAddress|0x1804|UINT16|0x0001037
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BControlBlockAddress|0x|UINT16|0x00010038
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850|UINT16|0x00010039
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UINT16|0x0001003A
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0x0001003B
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x|UINT16|0x0001003C
-
 #
 # UBA_START
 #
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc 
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
index 8c4b9cf6ce28..cefee8273b27 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
@@ -397,9 +397,6 @@
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicInterruptBase|24
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
   gMinPlatformPkgTokenSpaceGuid.PcdLocalApicAddress|0xFEE0
   gMinPlatformPkgTokenSpaceGuid.PcdIoApicAddress|0xFEC0
   gMinPlatformPkgTokenSpaceGuid.PcdIoApicId|0x08
@@ -510,6 +507,10 @@
   gPlatformTokenSpaceGuid.PcdBootMenuFile|{ 0xdc, 0x5b, 0xc2, 0xee, 0xf2, 
0x67, 0x95, 0x4d, 0xb1, 0xd5, 0xf8, 0x1b, 0x20, 0x39, 0xd1, 0x1d }
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+
 [PcdsDynamicExDefault.X64]
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits|8
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91154): https://edk2.groups.io/g/devel/message/91154
Mute This Topic: https://groups.io/mt/92233724/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH V1 5/6] Platform/Intel: Removing ACPI FADT PCDs that are redefined

2022-07-07 Thread Sinha, Ankit 
From: ankit13s 

Some PCDs are redefined in board package DEC file. Need to remove them.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec 
b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
index 196460e170b5..766dc5be4f6d 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
@@ -89,8 +89,6 @@ 
gPlatformModuleTokenSpaceGuid.PcdApicIoAddress|0xFEC0|UINT64|0x900D
 gPlatformModuleTokenSpaceGuid.PcdApicIoMmioSize|0x1000|UINT32|0x900E
 gPlatformModuleTokenSpaceGuid.PcdGttMmAddress|0xCF00|UINT64|0x900F
 gPlatformModuleTokenSpaceGuid.PcdGmAdrAddress|0xD000|UINT64|0x9010
-gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
 
gPlatformModuleTokenSpaceGuid.PcdPcieDockBridgeResourcePatchSmi|0x4D|UINT8|0x9014
 gPlatformModuleTokenSpaceGuid.PcdCmosFastBootDefaultValue|0x01|UINT8|0x9016
 
gPlatformModuleTokenSpaceGuid.PcdCmosDebugPrintErrorLevelDefaultValue|0x8046|UINT32|0x9017
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91153): https://edk2.groups.io/g/devel/message/91153
Mute This Topic: https://groups.io/mt/92233723/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH V1 4/6] Platform/Intel: Updating PCD category based on MinPlatformPkg

2022-07-07 Thread Sinha, Ankit 
From: ankit13s 

ACPI PCDs need to be re-categorized based on MinPlatformPkg definition

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 10 
+++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git 
a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc 
b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
index 9b81726623dc..44b6a812772d 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
@@ -186,9 +186,6 @@
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x450
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x408
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0003
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x0
   gMinPlatformPkgTokenSpaceGuid.PcdLocalApicAddress|0xFEE0
   gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuCoreCount|128
   gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuSocketCount|4
@@ -268,6 +265,13 @@
   gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|3
   gUefiCpuPkgTokenSpaceGuid.PcdCpuS3DataAddress|0
 
+  ##
+  # Platform Configuration
+  ##
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0003
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x0
+
 [PcdsDynamicExDefault.X64]
   ##
   # Edk2 Configuration
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91152): https://edk2.groups.io/g/devel/message/91152
Mute This Topic: https://groups.io/mt/92233720/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH V1 3/6] Platform/Intel: Modifying PCD category based on MinPlatformPkg

2022-07-07 Thread Sinha, Ankit 
From: ankit13s 

PCDs need to be re-categorized based on the changes in MinPlatformPkg
definition

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc | 8 

 Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc | 8 

 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git 
a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc 
b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc
index 6f6fb20d461c..050f9b6228ef 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc
@@ -254,10 +254,6 @@
   gEfiCpuTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
   gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
-
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiEnableSwSmi|0xA0
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiDisableSwSmi|0xA1
 
@@ -372,6 +368,10 @@
 
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+
 [PcdsDynamicExDefault.X64]
 
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
diff --git 
a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc 
b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc
index bed0625df9ef..5940c40dfc9d 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc
@@ -257,10 +257,6 @@
   gEfiCpuTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
   gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
-
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiEnableSwSmi|0xA0
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiDisableSwSmi|0xA1
 
@@ -375,6 +371,10 @@
 
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+
 [PcdsDynamicExDefault.X64]
 
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91151): https://edk2.groups.io/g/devel/message/91151
Mute This Topic: https://groups.io/mt/92233719/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH V1 2/6] Platform/Intel: Removing ACPI FADT PCDs that are redefined

2022-07-07 Thread Sinha, Ankit 
From: ankit13s 

Some ACPI PCDs are redefined in board package DEC file. Removing those
instances.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec 
b/Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec
index 1f8322eaeb22..eca92392be14 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec
+++ b/Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec
@@ -89,8 +89,6 @@ 
gPlatformModuleTokenSpaceGuid.PcdApicIoAddress|0xFEC0|UINT64|0x900D
 gPlatformModuleTokenSpaceGuid.PcdApicIoMmioSize|0x1000|UINT32|0x900E
 gPlatformModuleTokenSpaceGuid.PcdGttMmAddress|0xCF00|UINT64|0x900F
 gPlatformModuleTokenSpaceGuid.PcdGmAdrAddress|0xD000|UINT64|0x9010
-gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
 
gPlatformModuleTokenSpaceGuid.PcdPcieDockBridgeResourcePatchSmi|0x4D|UINT8|0x9014
 gPlatformModuleTokenSpaceGuid.PcdCmosFastBootDefaultValue|0x01|UINT8|0x9016
 
gPlatformModuleTokenSpaceGuid.PcdCmosDebugPrintErrorLevelDefaultValue|0x8046|UINT32|0x9017
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91150): https://edk2.groups.io/g/devel/message/91150
Mute This Topic: https://groups.io/mt/92233717/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH V1 1/6] Platform/Intel: Modifying PCD class for some ACPI related PCDs

2022-07-07 Thread Sinha, Ankit 
From: ankit13s 

Some PCDs related to FADT entries need to be defined as dynamic for
boottime customization and update.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 29 
++-
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 24 
+---
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec   | 30 
++--
 3 files changed, 44 insertions(+), 39 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c 
b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 3c9f79de5c6c..c7e87cbd7d9d 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1068,7 +1068,7 @@ InstallMcfgFromScratch (
  >Header,
  
EFI_ACPI_3_0_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE,
  EFI_ACPI_MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_REVISION,
- 0
+ FixedPcdGet32 (PcdAcpiDefaultOemRevision)
  );
   if (EFI_ERROR (Status)) {
 return Status;
@@ -1195,6 +1195,7 @@ PlatformUpdateTables (
 FadtHeader->PreferredPmProfile= PcdGet8 
(PcdFadtPreferredPmProfile);
 FadtHeader->IaPcBootArch  = PcdGet16 
(PcdFadtIaPcBootArch);
 FadtHeader->Flags = PcdGet32 (PcdFadtFlags);
+FadtHeader->SmiCmd= PcdGet32 (PcdFadtSmiCmd);
 FadtHeader->AcpiEnable= PcdGet8 
(PcdAcpiEnableSwSmi);
 FadtHeader->AcpiDisable   = PcdGet8 
(PcdAcpiDisableSwSmi);
 FadtHeader->Pm1aEvtBlk= PcdGet16 
(PcdAcpiPm1AEventBlockAddress);
@@ -1209,6 +1210,7 @@ PlatformUpdateTables (
 FadtHeader->Gpe1Base  = PcdGet8 (PcdAcpiGpe1Base);
 
 FadtHeader->XPm1aEvtBlk.Address   = PcdGet16 
(PcdAcpiPm1AEventBlockAddress);
+FadtHeader->XPm1bEvtBlk.Address   = PcdGet16 
(PcdAcpiPm1BEventBlockAddress);
 FadtHeader->XPm1aCntBlk.Address   = PcdGet16 
(PcdAcpiPm1AControlBlockAddress);
 FadtHeader->XPm1bCntBlk.Address   = PcdGet16 
(PcdAcpiPm1BControlBlockAddress);
 FadtHeader->XPm2CntBlk.Address= PcdGet16 
(PcdAcpiPm2ControlBlockAddress);
@@ -1216,7 +1218,7 @@ PlatformUpdateTables (
 FadtHeader->XGpe0Blk.Address  = PcdGet16 
(PcdAcpiGpe0BlockAddress);
 FadtHeader->XGpe1Blk.Address  = PcdGet16 
(PcdAcpiGpe1BlockAddress);
 
-FadtHeader->ResetReg.AccessSize   = PcdGet8 
(PcdAcpiResetRegAccessSize);
+FadtHeader->ResetReg.AccessSize   = PcdGet8 
(PcdAcpiResetRegisterAccessSize);
 FadtHeader->XPm1aEvtBlk.AccessSize= PcdGet8 
(PcdAcpiXPm1aEvtBlkAccessSize);
 FadtHeader->XPm1bEvtBlk.AccessSize= PcdGet8 
(PcdAcpiXPm1bEvtBlkAccessSize);
 FadtHeader->XPm1aCntBlk.AccessSize= PcdGet8 
(PcdAcpiXPm1aCntBlkAccessSize);
@@ -1226,22 +1228,23 @@ PlatformUpdateTables (
 FadtHeader->XGpe0Blk.AccessSize   = PcdGet8 
(PcdAcpiXGpe0BlkAccessSize);
 FadtHeader->XGpe1Blk.AccessSize   = PcdGet8 
(PcdAcpiXGpe1BlkAccessSize);
 
-FadtHeader->SleepControlReg.AddressSpaceId= PcdGet8 
(PcdAcpiSleepControlRegAddressSpaceId);
-FadtHeader->SleepControlReg.RegisterBitOffset = PcdGet8 
(PcdAcpiSleepControlRegRegisterBitOffset);
-FadtHeader->SleepControlReg.AccessSize= PcdGet8 
(PcdAcpiSleepControlRegAccessSize);
-FadtHeader->SleepControlReg.Address   = PcdGet64 
(PcdAcpiSleepControlRegAddress);
-FadtHeader->SleepStatusReg.AddressSpaceId = PcdGet8 
(PcdAcpiSleepStatusRegAddressSpaceId);
-FadtHeader->SleepStatusReg.RegisterBitWidth   = PcdGet8 
(PcdAcpiSleepStatusRegRegisterBitWidth);
-FadtHeader->SleepStatusReg.RegisterBitOffset  = PcdGet8 
(PcdAcpiSleepStatusRegRegisterBitOffset);
-FadtHeader->SleepStatusReg.AccessSize = PcdGet8 
(PcdAcpiSleepStatusRegAccessSize);
-FadtHeader->SleepStatusReg.Address= PcdGet64 
(PcdAcpiSleepStatusRegAddress);
+FadtHeader->SleepControlReg.AddressSpaceId= PcdGet8 
(PcdAcpiSleepControlRegisterAddressSpaceId);
+FadtHeader->SleepControlReg.RegisterBitWidth  = PcdGet8 
(PcdAcpiSleepControlRegisterBitWidth);
+FadtHeader->SleepControlReg.RegisterBitOffset = PcdGet8 
(PcdAcpiSleepControlRegisterBitOffset);
+FadtHeader->SleepControlReg.AccessSize= PcdGet8 
(PcdAcpiSleepControlRegisterAccessSize);
+FadtHeader->SleepControlReg.Address   = PcdGet64 
(PcdAcpiSleepControlRegisterAddress);
+FadtHeader->SleepStatusReg.AddressSpaceId = PcdGet8 
(PcdAcpiSleepStatusRegisterAddressSpaceId);
+

[edk2-devel] [edk2-platforms PATCH V1 0/6] Re-organizing ACPI FADT PCD categories

2022-07-07 Thread Sinha, Ankit 
Some ACPI FADT fields need to be update during boot time. This
requires a few PCDs to be defined as Dynamic and not Fixed at build.
This patch series also removes duplicate definition of some PCDs between
MinPlatformPkg and respective board packages.

Reference: https://github.com/ankit13s/edk2-platforms/tree/acpi_pcds

  Platform/Intel: Modifying PCD class for some ACPI related PCDs
  Platform/Intel: Removing ACPI FADT PCDs that are redefined
  Platform/Intel: Modifying PCD category based on MinPlatformPkg
  Platform/Intel: Updating PCD category based on MinPlatformPkg
  Platform/Intel: Removing ACPI FADT PCDs that are redefined
  Platform/Intel: Remove and re-categorize ACPI FADT PCDs

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c| 29 
++-
 Platform/Intel/CometlakeOpenBoardPkg/OpenBoardPkg.dec   |  2 --
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf  | 24 
+---
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec| 30 
++--
 Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc |  8 +++---
 Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc |  8 +++---
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 10 
+--
 Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec |  2 --
 Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec  | 16 
---
 Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc  |  7 +++--
 10 files changed, 63 insertions(+), 73 deletions(-)

-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91148): https://edk2.groups.io/g/devel/message/91148
Mute This Topic: https://groups.io/mt/92233702/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

2022-07-07 Thread Jeff Brasen via groups.io 
Pierre,

 Any thoughts on this v2 version?

-Jeff


> -Original Message-
> From: Jeff Brasen 
> Sent: Friday, July 1, 2022 10:33 AM
> To: devel@edk2.groups.io
> Cc: pierre.gond...@arm.com; sami.muja...@arm.com;
> alexei.fedo...@arm.com; Jeff Brasen 
> Subject: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates
> 
> Add fixes/features to dynamic PCIe support
> 
> - Correct issue with translation in generated ACPI tables.
> - Allow for more than 16 controllers to be generated.
> - Allow optional use of segment number as UID for cases where ACPI path is
> needed in other places.
> - Add support for override protocol that allows platform specific modification
> of node prior to creation.
> 
> Update:
> v2 - Add IsPosDecode logic to translation patch
> 
> Jeff Brasen (4):
>   DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value
>   DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as
> UID
>   DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF
>   DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override
> protocol
> 
>  DynamicTablesPkg/DynamicTablesPkg.dec |  6 ++
>  .../Protocol/SsdtPcieOverrideProtocol.h   | 63 
>  .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 73 ---
>  .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h|  2 +-
>  .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |  7 ++
>  5 files changed, 139 insertions(+), 12 deletions(-)  create mode 100644
> DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h
> 
> --
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91146): https://edk2.groups.io/g/devel/message/91146
Mute This Topic: https://groups.io/mt/92113674/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3] UefiPayloadPkg: Add macro to support selective driver in UPL

2022-07-07 Thread Ni, Ray 
Reviewed-by: Ray Ni 

thanks,
ray

From: Lu, James 
Sent: Friday, July 8, 2022 12:15:09 AM
To: devel@edk2.groups.io 
Cc: Lu, James ; Dong, Guo ; Ni, Ray 
; Guo, Gua 
Subject: [PATCH v3] UefiPayloadPkg: Add macro to support selective driver in UPL

From: James Lu 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3967

Add macros to decide modules built into UPL.elf.

Macro list:
 - GENERIC_MEMORY_TEST_ENABLE: GenericMemoryTestDxe
 - MEMORY_TEST: NullMemoryTestDxe or GenericMemoryDxe
 - ATA_ENABLE: SataControllerDxe, AtaBusDxe
 - SD_ENABLE: SdMmcPciDxe, EmmcDxe, SdDxe
 - PS2_MOUSE_ENABLE: Ps2MouseDxe

Cc: Guo Dong 
Cc: Ray Ni 
Cc: Gua Guo 
Signed-off-by: James Lu 
---
 UefiPayloadPkg/UefiPayloadPkg.dsc | 21 
 UefiPayloadPkg/UefiPayloadPkg.fdf | 14 -
 2 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc 
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index cfcf38578d..ec79914f45 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -36,7 +36,16 @@
   DEFINE PLATFORM_BOOT_TIMEOUT= 3

   DEFINE ABOVE_4G_MEMORY  = TRUE

   DEFINE BOOT_MANAGER_ESCAPE  = FALSE

+  DEFINE ATA_ENABLE   = TRUE

+  DEFINE SD_ENABLE= TRUE

+  DEFINE PS2_MOUSE_ENABLE = TRUE

   DEFINE SD_MMC_TIMEOUT   = 100

+

+  #

+  # NULL:NullMemoryTestDxe

+  # GENERIC: GenericMemoryTestDxe

+  #

+  DEFINE MEMORY_TEST  = NULL

   #

   # SBL:  UEFI payload for Slim Bootloader

   # COREBOOT: UEFI payload for coreboot

@@ -596,7 +605,11 @@
   
MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf

   UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf

   MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf

+!if $(MEMORY_TEST) == "GENERIC"

+  
MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf

+!elseif $(MEMORY_TEST) == "NULL"

   MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf

+!endif

   MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf

   MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf

   MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf

@@ -631,8 +644,10 @@
   MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf

   MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf

   FatPkg/EnhancedFatDxe/Fat.inf

+!if $(ATA_ENABLE) == TRUE

   MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf

   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf

+!endif

   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf

   MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf

   MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf

@@ -644,9 +659,11 @@
   #

   # SD/eMMC Support

   #

+!if $(SD_ENABLE) == TRUE

   MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf

   MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf

   MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf

+!endif



   #

   # Usb Support

@@ -671,7 +688,9 @@
 !if $(PS2_KEYBOARD_ENABLE) == TRUE

   MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf

 !endif

+!if $(PS2_MOUSE_ENABLE) == TRUE

   MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf

+!endif



   #

   # Console Support

@@ -742,12 +761,14 @@
   #  This should be FALSE for compiling the dynamic command.

   gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE

   }

+!if $(PERFORMANCE_MEASUREMENT_ENABLE) == TRUE

   ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf {

 

   ## This flag is used to control initialization of the shell library

   #  This should be FALSE for compiling the dynamic command.

   gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE

   }

+!endif

   ShellPkg/Application/Shell/Shell.inf {

 

   ## This flag is used to control initialization of the shell library

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf 
b/UefiPayloadPkg/UefiPayloadPkg.fdf
index c7b04978ad..35f79be2f0 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -149,7 +149,11 @@ INF 
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf


 INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf

 INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf

-INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf

+!if $(MEMORY_TEST) == "GENERIC"

+INF  
MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf

+!elseif $(MEMORY_TEST) == "NULL"

+INF  MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf

+!endif

 INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf

 INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf

 INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf

@@ -176,7 +180,9 @@ INF OvmfPkg/SioBusDxe/SioBusDxe.inf
 !if $(PS2_KEYBOARD_ENABLE) == TRUE

 INF

Re: [edk2-devel] [PATCH v4] UefiPayloadPkg: Add support for logging to CBMEM console

2022-07-07 Thread Sheng Lean Tan 
Reviewed-by: Lean Sheng Tan


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91144): https://edk2.groups.io/g/devel/message/91144
Mute This Topic: https://groups.io/mt/91945631/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v3] UefiPayloadPkg: Add macro to support selective driver in UPL

2022-07-07 Thread Lu, James 
From: James Lu 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3967

Add macros to decide modules built into UPL.elf.

Macro list:
 - GENERIC_MEMORY_TEST_ENABLE: GenericMemoryTestDxe
 - MEMORY_TEST: NullMemoryTestDxe or GenericMemoryDxe
 - ATA_ENABLE: SataControllerDxe, AtaBusDxe
 - SD_ENABLE: SdMmcPciDxe, EmmcDxe, SdDxe
 - PS2_MOUSE_ENABLE: Ps2MouseDxe

Cc: Guo Dong 
Cc: Ray Ni 
Cc: Gua Guo 
Signed-off-by: James Lu 
---
 UefiPayloadPkg/UefiPayloadPkg.dsc | 21 
 UefiPayloadPkg/UefiPayloadPkg.fdf | 14 -
 2 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc 
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index cfcf38578d..ec79914f45 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -36,7 +36,16 @@
   DEFINE PLATFORM_BOOT_TIMEOUT= 3
   DEFINE ABOVE_4G_MEMORY  = TRUE
   DEFINE BOOT_MANAGER_ESCAPE  = FALSE
+  DEFINE ATA_ENABLE   = TRUE
+  DEFINE SD_ENABLE= TRUE
+  DEFINE PS2_MOUSE_ENABLE = TRUE
   DEFINE SD_MMC_TIMEOUT   = 100
+
+  #
+  # NULL:NullMemoryTestDxe
+  # GENERIC: GenericMemoryTestDxe
+  #
+  DEFINE MEMORY_TEST  = NULL
   #
   # SBL:  UEFI payload for Slim Bootloader
   # COREBOOT: UEFI payload for coreboot
@@ -596,7 +605,11 @@
   
MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf
   UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
   MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
+!if $(MEMORY_TEST) == "GENERIC"
+  
MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf
+!elseif $(MEMORY_TEST) == "NULL"
   MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
+!endif
   MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
   MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
   MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
@@ -631,8 +644,10 @@
   MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
   MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
   FatPkg/EnhancedFatDxe/Fat.inf
+!if $(ATA_ENABLE) == TRUE
   MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
+!endif
   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
   MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
@@ -644,9 +659,11 @@
   #
   # SD/eMMC Support
   #
+!if $(SD_ENABLE) == TRUE
   MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
   MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf
   MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf
+!endif
 
   #
   # Usb Support
@@ -671,7 +688,9 @@
 !if $(PS2_KEYBOARD_ENABLE) == TRUE
   MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
 !endif
+!if $(PS2_MOUSE_ENABLE) == TRUE
   MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf
+!endif
 
   #
   # Console Support
@@ -742,12 +761,14 @@
   #  This should be FALSE for compiling the dynamic command.
   gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
   }
+!if $(PERFORMANCE_MEASUREMENT_ENABLE) == TRUE
   ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf {
 
   ## This flag is used to control initialization of the shell library
   #  This should be FALSE for compiling the dynamic command.
   gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
   }
+!endif
   ShellPkg/Application/Shell/Shell.inf {
 
   ## This flag is used to control initialization of the shell library
diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf 
b/UefiPayloadPkg/UefiPayloadPkg.fdf
index c7b04978ad..35f79be2f0 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -149,7 +149,11 @@ INF 
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
 
 INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
 INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
-INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
+!if $(MEMORY_TEST) == "GENERIC"
+INF  
MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf
+!elseif $(MEMORY_TEST) == "NULL"
+INF  MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
+!endif
 INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
 INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
 INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
@@ -176,7 +180,9 @@ INF OvmfPkg/SioBusDxe/SioBusDxe.inf
 !if $(PS2_KEYBOARD_ENABLE) == TRUE
 INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
 !endif
+!if $(PS2_MOUSE_ENABLE) == TRUE
 INF MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf
+!endif
 
 #
 # Console Support
@@ -195,8 +201,10 @@ INF UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
 INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
 INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 07/07/2022 #cal-reminder

2022-07-07 Thread Group Notification 
*Reminder: TianoCore Community Meeting - EMEA / NAMO*

*When:*
07/07/2022
9:00am to 10:00am
(UTC-07:00) America/Los Angeles

*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%22b286b53a-1218-4db3-bfc9-3d4c5aa7669e%22%7d

*Organizer:* Miki Demeter

View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1519381 )

*Description:*

Microsoft Teams meeting

*Join on your computer or mobile app*

Click here to join the meeting ( 
https://teams.microsoft.com/l/meetup-join/19%3ameeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%22b286b53a-1218-4db3-bfc9-3d4c5aa7669e%22%7d
 )

*Join with a video conferencing device*

te...@conf.intel.com

Video Conference ID: 111 422 379 4

Alternate VTC dialing instructions ( 
https://conf.intel.com/teams/?conf=1114223794=teams=conf.intel.com=test_call
 )

*Or call in (audio only)*

+1 916-245-6934,,482062805# ( tel:+19162456934,,482062805# ) United States, 
Sacramento

Phone Conference ID: 482 062 805#

Find a local number ( 
https://dialin.teams.microsoft.com/d195d438-2daa-420e-b9ea-da26f9d1d6d5?id=482062805
 ) | Reset PIN ( https://mysettings.lync.com/pstnconferencing )

Learn More ( https://aka.ms/JoinTeamsMeeting ) | Meeting options ( 
https://teams.microsoft.com/meetingOptions/?organizerId=b286b53a-1218-4db3-bfc9-3d4c5aa7669e=46c98d88-e344-4ed4-8496-4ed7712e255d=19_meeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh@thread.v2=0=en-US
 )


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91142): https://edk2.groups.io/g/devel/message/91142
Mute This Topic: https://groups.io/mt/92231166/21656
Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 07/07/2022 #cal-reminder

2022-07-07 Thread Group Notification 
*Reminder: TianoCore Community Meeting - EMEA / NAMO*

*When:*
07/07/2022
9:00am to 10:00am
(UTC-07:00) America/Los Angeles

*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%22b286b53a-1218-4db3-bfc9-3d4c5aa7669e%22%7d

*Organizer:* Miki Demeter

View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1519381 )

*Description:*

Microsoft Teams meeting

*Join on your computer or mobile app*

Click here to join the meeting ( 
https://teams.microsoft.com/l/meetup-join/19%3ameeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%22b286b53a-1218-4db3-bfc9-3d4c5aa7669e%22%7d
 )

*Join with a video conferencing device*

te...@conf.intel.com

Video Conference ID: 111 422 379 4

Alternate VTC dialing instructions ( 
https://conf.intel.com/teams/?conf=1114223794=teams=conf.intel.com=test_call
 )

*Or call in (audio only)*

+1 916-245-6934,,482062805# ( tel:+19162456934,,482062805# ) United States, 
Sacramento

Phone Conference ID: 482 062 805#

Find a local number ( 
https://dialin.teams.microsoft.com/d195d438-2daa-420e-b9ea-da26f9d1d6d5?id=482062805
 ) | Reset PIN ( https://mysettings.lync.com/pstnconferencing )

Learn More ( https://aka.ms/JoinTeamsMeeting ) | Meeting options ( 
https://teams.microsoft.com/meetingOptions/?organizerId=b286b53a-1218-4db3-bfc9-3d4c5aa7669e=46c98d88-e344-4ed4-8496-4ed7712e255d=19_meeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh@thread.v2=0=en-US
 )


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91141): https://edk2.groups.io/g/devel/message/91141
Mute This Topic: https://groups.io/mt/92231166/21656
Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms v2 06/11] Platform/RaspberryPi: Update for IORT revision macro renaming

2022-07-07 Thread Jeremy Linton 

Hi,

On 7/6/22 05:39, Sami Mujawar wrote:

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for RaspberryPi platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.

Signed-off-by: Sami Mujawar 
---
  Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc 
b/Platform/RaspberryPi/AcpiTables/Iort.aslc
index 
810307ae376f7d24790775f499daa09e3137fe6c..3ca5471081f2b43e624b35fc7b9bda856b15daa9
 100644
--- a/Platform/RaspberryPi/AcpiTables/Iort.aslc
+++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc
@@ -28,7 +28,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
{
  ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
   RPI4_IO_REMAPPING_STRUCTURE,
- EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
+ EFI_ACPI_IO_REMAPPING_TABLE_REV0),
  3,  // NumNodes
  sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),   // NodeOffset
  0   // Reserved



So, this looks fine to me.

Thanks,

Reviewed-by: Jeremy Linton 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91140): https://edk2.groups.io/g/devel/message/91140
Mute This Topic: https://groups.io/mt/92203687/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2 v3 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2022-07-07 Thread Sami Mujawar 
Fixed issues reported by CI and merged as f193b945eac5..5496c763aadd

Thanks,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91139): https://edk2.groups.io/g/devel/message/91139
Mute This Topic: https://groups.io/mt/88052140/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 1/8] MdePkg: IORT header update for IORT Rev E.d spec

2022-07-07 Thread Sami Mujawar 

Hi Jon,

Thank you for your feedback. Please see my response inline marked [SAMI].

Regards,

Sami Mujawar

On 07/07/2022 07:05 am, Jon Nettleton wrote:

On Wed, Jul 6, 2022 at 11:57 AM Sami Mujawar  wrote:

Bugzilla: 3458 - Add support IORT Rev E.d specification updates
   (https://bugzilla.tianocore.org/show_bug.cgi?id=3458)

The IO Remapping Table, Platform Design Document, Revision E.d,
Feb 2022 (https://developer.arm.com/documentation/den0049/)
introduces the following updates, collectively including the
updates and errata fixes to Rev E, Rev E.a, Rev E.b, Rev E.c:
   - increments the IORT table revision to 5.
   - updates the node definition to add an 'Identifier' field.
   - adds definition of node type 6 - Reserved Memory Range node.
   - adds definition for Memory Range Descriptors.
   - adds flag to indicate PRI support for root complexes.
   - adds flag to indicate if the root complex supports forwarding
 of PASID information on translated transactions to the SMMU.
   - adds flag to indicate if the root complex supports PASID.
   - adds flags to define access privilege and attributes for the
 memory ranges.

Therefore, update the IORT header file to reflect these changes,
and also rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.

Signed-off-by: Sami Mujawar 
---

Notes:
 v4:
   - Updated patch series to IORT specification revision E.d. [SAMI]
   - Add flag to indicate if the root complex supports PASID. [SAMI]
   - Add flags to define access privilege and attributes for  [SAMI]
 the memory ranges.
 v3:
   - Submit patch series to update platform code to use the   [LIMING]
 EFI_ACPI_IO_REMAPPING_TABLE_REV0 macro.
 Ref: https://edk2.groups.io/g/devel/topic/83618423#76799
   - Removed definition of EFI_ACPI_IO_REMAPPING_TABLE_REVISION   [SAMI]
 as EFI_ACPI_IO_REMAPPING_TABLE_REV0 has been provided for
 representing Rev 0. Also, a corresponding patch series
 for updating the platforms in edk2-platforms repository
 shall be submitted to the edk2 mailing list.
   - Include r-b received from v2 series. [SAMI]
 Ref: https://edk2.groups.io/g/devel/topic/83600724#76660

 v2:
   - Set EFI_ACPI_IO_REMAPPING_TABLE_REVISION to Rev 0 as [SAMI]
 setting to Rev 3 will break existing platforms. The
 problem is that existing code would not be populating
 the Identifier field in the nodes. This can lead to
 non-unique values in the Identifier field.

  MdePkg/Include/IndustryStandard/IoRemappingTable.h | 83 ++--
  1 file changed, 75 insertions(+), 8 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/IoRemappingTable.h 
b/MdePkg/Include/IndustryStandard/IoRemappingTable.h
index 
79a34678681d45b2982dc8573db6bd447f42e429..07cb7f49dc936fb00cc549113f1e62f988535e5d
 100644
--- a/MdePkg/Include/IndustryStandard/IoRemappingTable.h
+++ b/MdePkg/Include/IndustryStandard/IoRemappingTable.h
@@ -1,12 +1,19 @@
  /** @file
-  ACPI IO Remapping Table (IORT) as specified in ARM spec DEN0049D
-
-  
http://infocenter.arm.com/help/topic/com.arm.doc.den0049d/DEN0049D_IO_Remapping_Table.pdf
+  ACPI IO Remapping Table (IORT) definitions.

Copyright (c) 2017, Linaro Limited. All rights reserved.
-  Copyright (c) 2018, ARM Limited. All rights reserved.
+  Copyright (c) 2018 - 2022, Arm Limited. All rights reserved.

SPDX-License-Identifier: BSD-2-Clause-Patent
+
+  @par Reference(s):
+  - IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022
+(https://developer.arm.com/documentation/den0049/)
+
+  @par Glossary:
+  - Ref  : Reference
+  - Mem  : Memory
+  - Desc : Descriptor
  **/

  #ifndef __IO_REMAPPING_TABLE_H__
@@ -14,7 +21,8 @@

  #include 

-#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION  0x0
+#define EFI_ACPI_IO_REMAPPING_TABLE_REV0  0x0
+#define EFI_ACPI_IO_REMAPPING_TABLE_REV5  0x5

  #define EFI_ACPI_IORT_TYPE_ITS_GROUP 0x0
  #define EFI_ACPI_IORT_TYPE_NAMED_COMP0x1
@@ -22,6 +30,7 @@
  #define EFI_ACPI_IORT_TYPE_SMMUv1v2  0x3
  #define EFI_ACPI_IORT_TYPE_SMMUv30x4
  #define EFI_ACPI_IORT_TYPE_PMCG  0x5
+#define EFI_ACPI_IORT_TYPE_RMR   0x6

  #define EFI_ACPI_IORT_MEM_ACCESS_PROP_CCA  BIT0

@@ -55,7 +64,29 @@
  #define EFI_ACPI_IORT_SMMUv3_MODEL_CAVIUM_CN99XX 0x2

  #define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED  0x0
-#define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_SUPPORTED0x1
+#define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_SUPPORTEDBIT0
+
+#define EFI_ACPI_IORT_ROOT_COMPLEX_PRI_UNSUPPORTED  0x0
+#define EFI_ACPI_IORT_ROOT_COMPLEX_PRI_SUPPORTEDBIT1
+
+#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_FWD_UNSUPPORTED  0x0
+#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_FWD_SUPPORTEDBIT2
+
+#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_UNSUPPORTED  0x0
+#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_SUPPORTEDBIT1
+
+#define

Re: 回复: [edk2-devel] [PATCH v4 1/8] MdePkg: IORT header update for IORT Rev E.d spec

2022-07-07 Thread Sami Mujawar 

Hi Liming,

Thank you for your feedback. Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 07/07/2022 02:51 am, gaoliming wrote:


Sami:

 I suggest to keep EFI_ACPI_IO_REMAPPING_TABLE_REVISION. Its value can 
be EFI_ACPI_IO_REMAPPING_TABLE_REV5, because the structure has been 
updated, such as EFI_ACPI_6_0_IO_REMAPPING_RC_NODE.



[SAMI] Ack. I will change this in the next patch series.


 Compared to the previous version, EFI_ACPI_6_0_IO_REMAPPING_RC_NODE 
struct is larger. Does this change bring any impact?


[SAMI] The EFI_ACPI_6_0_IO_REMAPPING_NODE.Length field should reflect 
the increased size. Similarly, the Revision field in the IORT ACPI table 
header and the EFI_ACPI_6_0_IO_REMAPPING_NODE.Revision field would also 
be updated accordingly. Therefore, an OS should be able to detect the 
change and handle accordinlgy.


As for existing firmware code that does not make use of the latest IORT 
revision, I have an edk2-platforms patch series that fixes the IORT 
Table revision to EFI_ACPI_IO_REMAPPING_TABLE_REV0, see 
https://edk2.groups.io/g/devel/message/91104.


[/SAMI]



Thanks

Liming

*发件人:*devel@edk2.groups.io  *代表 *Sami Mujawar
*发送时间:*2022年7月6日23:44
*收件人:*Sami Mujawar ; devel@edk2.groups.io
*主题:*Re: [edk2-devel] [PATCH v4 1/8] MdePkg: IORT header update for 
IORT Rev E.d spec


On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote:

-#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0
+#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0
+#define EFI_ACPI_IO_REMAPPING_TABLE_REV5 0x5

Based on discussion at 
https://edk2.groups.io/g/devel/topic/patch_edk2_platforms_v2/92203690?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,92203690,previd%3D1657121904386162709,nextid%3D1657101454237486469=1657121904386162709=1657101454237486469, 
 
the suggestion is to rename these macros to 
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 and 
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_05 respectively.
I will wait for any other feedback on this series, before I send out 
the updated series reflecting the macro renaming.


Regards,

Sami Mujawar






-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91137): https://edk2.groups.io/g/devel/message/91137
Mute This Topic: https://groups.io/mt/92220349/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add CryptoDxe driver to UefiPayload

2022-07-07 Thread Ni, Ray 
Reviewed-by: Ray Ni 

> -Original Message-
> From: Hsieh, PaytonX 
> Sent: Thursday, July 7, 2022 4:52 PM
> To: devel@edk2.groups.io
> Cc: Hsieh, PaytonX ; Dong, Guo ; 
> Ni, Ray ; Lu,
> James ; Guo, Gua 
> Subject: [PATCH v2] UefiPayloadPkg: Add CryptoDxe driver to UefiPayload
> 
> From: PaytonX Hsieh 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3979
> 
> Add CryptoDxe into UPL.
> Drviers can locate protocol instead of building openssl lib into drivers.
> This can reduce the binary size that UPL required.
> 
> Cc: Guo Dong 
> Cc: Ray Ni 
> Cc: James Lu 
> Cc: Gua Guo 
> Signed-off-by: PaytonX Hsieh 
> ---
>  UefiPayloadPkg/UefiPayloadPkg.dsc | 36 ++--
>  UefiPayloadPkg/UefiPayloadPkg.fdf |  1 +
>  2 files changed, 35 insertions(+), 2 deletions(-)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc 
> b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index cfcf38578d..2428bb2ce9 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -180,8 +180,8 @@
>
> CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
> 
>SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> 
>DxeHobListLib|UefiPayloadPkg/Library/DxeHobListLib/DxeHobListLib.inf
> 
> -  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> 
> -  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> 
> +  BaseCryptLib|CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
> 
> +  TlsLib|CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
> 
>IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> 
>OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> 
>RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
> 
> @@ -412,6 +412,29 @@
>gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE)
> 
>gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|180
> 
> 
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family 
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Md5.Family
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Family   
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Dh.Family 
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Random.Family 
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Family
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family   
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family 
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family 
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family 
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.X509.Family   
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Tdes.Family   
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.GetContextSize
>   | TRUE
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.Init 
>| TRUE
> 
> +  
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.CbcEncrypt
>   | TRUE
> 
> +  
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.CbcDecrypt
>   | TRUE
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Arc4.Family   
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Family   
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Tls.Family
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsSet.Family 
>|
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> 
> +  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsGet.Family 
>|
>

Re: [edk2-devel] [PATCH] MdePkg/include: Update DMAR definitions to Intel VT-d spec ver4.0

2022-07-07 Thread Sheng Wei 
Reviewed-by: Sheng Wei 

The change matches the Vtd specification v 4.0


> -Original Message-
> From: Kowalewski, Robert 
> Sent: 2022年7月6日 21:48
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> Huang, Jenny ; Sheng, W 
> Subject: [PATCH] MdePkg/include: Update DMAR definitions to Intel VT-d
> spec ver4.0
> 
> Updated DMAR definitions accordingly to changes in Intel(R) Virtualization
> Technology for Directed I/O (VT-D) Architecture Specification ver4.0.
> 
> Added new definition of remapping structure - SIDP. The SoC Integrated
> Device Property (SIDP) reporting structure identifies devices that have
> special properties and that may put restrictions on how system software
> must configure remapping structures that govern such devices in a platform
> where remapping hardware is enabled.
> 
> Updated DRHD definition - field 'reserved' is replaced with 'Size'.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3978
> 
> Signed-off-by: Robert Kowalewski 
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Jenny Huang 
> Cc: Sheng Wei 
> ---
>  .../DmaRemappingReportingTable.h  | 46 +++
>  1 file changed, 38 insertions(+), 8 deletions(-)
> 
> diff --git
> a/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
> b/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
> index 193e4bced5..00588ff234 100644
> --- a/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
> +++ b/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h
> @@ -2,12 +2,12 @@
>DMA Remapping Reporting (DMAR) ACPI table definition from Intel(R)
>Virtualization Technology for Directed I/O (VT-D) Architecture 
> Specification.
> 
> -  Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
> +  Copyright (c) 2016 - 2022, Intel Corporation. All rights
> + reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>@par Revision Reference:
>  - Intel(R) Virtualization Technology for Directed I/O (VT-D) Architecture
> -  Specification v3.2, Dated October 2020.
> +  Specification v4.0, Dated June 2022.
> 
> https://software.intel.com/content/dam/develop/external/us/en/documen
> ts/vt-directed-io-spec.pdf
> 
>@par Glossary:
> @@ -41,6 +41,7 @@
>  #define EFI_ACPI_DMAR_TYPE_RHSA  0x03
>  #define EFI_ACPI_DMAR_TYPE_ANDD  0x04
>  #define EFI_ACPI_DMAR_TYPE_SATC  0x05
> +#define EFI_ACPI_DMAR_TYPE_SIDP  0x06
>  ///@}
> 
>  ///
> @@ -56,6 +57,12 @@
>  #define EFI_ACPI_DEVICE_SCOPE_ENTRY_TYPE_IOAPIC 0x03
>  #define EFI_ACPI_DEVICE_SCOPE_ENTRY_TYPE_MSI_CAPABLE_HPET
> 0x04
>  #define EFI_ACPI_DEVICE_SCOPE_ENTRY_TYPE_ACPI_NAMESPACE_DEVICE
> 0x05
> +
> +#define
> EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_NESTED_NOTALLOWED  BIT0
> +#define
> EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_PWSNP_NOTALLOWED   BIT1
> +#define EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_PGSNP_NOTALLOWED
> BIT2
> +#define EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_ATC_HARDENED
> BIT3
> +#define EFI_ACPI_DEVICE_SCOPE_REQ_WO_PASID_ATC_REQUIRED
> BIT4
>  ///@}
> 
>  ///
> @@ -83,11 +90,12 @@ typedef struct {
>  /// Device Scope Structure is defined in section 8.3.1  ///  typedef struct {
> -  UINT8 Type;
> -  UINT8 Length;
> -  UINT16Reserved2;
> -  UINT8 EnumerationId;
> -  UINT8 StartBusNumber;
> +  UINT8Type;
> +  UINT8Length;
> +  UINT8Flags;
> +  UINT8Reserved;
> +  UINT8EnumerationId;
> +  UINT8StartBusNumber;
>  } EFI_ACPI_DMAR_DEVICE_SCOPE_STRUCTURE_HEADER;
> 
>  /**
> @@ -111,7 +119,14 @@ typedef struct {
>  - Bits[7:1] Reserved.
>**/
>UINT8 Flags;
> -  UINT8 Reserved;
> +
> +  /**
> +- Bits[3:0]: Indicates the size of the remapping hardware register set 
> for
> + this remapping unit. If the value in this field is N, the 
> size
> + of the register set is 2^N 4 KB pages
> +- Bits[7:4]: Reserved.
> +  **/
> +  UINT8 Size;
>///
>/// The PCI Segment associated with this unit.
>///
> @@ -249,6 +264,20 @@ typedef struct {
>UINT16SegmentNumber;
>  } EFI_ACPI_DMAR_SATC_HEADER;
> 
> +/**
> +  SoC Integrated Device Property (SIDP) Reporting Structure is defined
> +in
> +  section 8.9.
> +**/
> +typedef struct {
> +  EFI_ACPI_DMAR_STRUCTURE_HEADERHeader;
> +
> +  UINT16Reserved;
> +  ///
> +  /// The PCI Segment associated with this SIDP structure.
> +  ///
> +  UINT16SegmentNumber;
> +} EFI_ACPI_DMAR_SIDP_HEADER;
> +
>  /**
>DMA Remapping Reporting Structure Header as defined in section 8.1
>This header will be followed by list of Remapping Structures listed below
> @@ -258,6 +287,7 @@ typedef struct {
>  - Remapping Hardware Static Affinity (RHSA)
>  - ACPI Name-space Device Declaration (ANDD)
>  - SoC Integrated Address Translation Cache reporting (SATC)
> +- SoC Integrated Device Property reporting (SIDP)
>These

[edk2-devel] [PATCH 2/2] OvmfPkg: Update CcProbeLib

2022-07-07 Thread Min Xu 
From: Min M Xu 

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974

CcProbeLib once was designed to probe the Confidential Computing guest
type by checking the PcdOvmfWorkArea. But this memory is allocated with
either EfiACPIMemoryNVS or EfiBootServicesData. It cannot be accessed
after ExitBootService. Please see the detailed analysis in BZ#3974.

To fix this issue, CcProbeLib is redesigned as 2 implementation:
 - SecPeiCcProbeLib
 - CcProbeLib

In SecPeiCcProbeLib we still check the CC guest type by reading the
PcdOvmfWorkArea. Because it is used in SEC / PEI and we don't worry about
the issues in BZ#3974.

In CcProbeLib we call TdIsEnabled() to check if it is of Tdx guest. To
improve the efficiency the result is cached in a global variable. In
current stage only the Tdx related code is added in CcProbeLib. SEV code
may be added in the future.

The reason why we probe CC guest type in 2 different ways is the global
varialbe. Global variable cannot be used in SEC/PEI and CcProbe is called
very frequently.

Cc: Gerd Hoffmann 
Cc: Erdem Aktas 
Cc: James Bottomley 
Cc: Jiewen Yao 
Cc: Tom Lendacky 
Cc: Yuan Yu 
Signed-off-by: Min Xu 
---
 OvmfPkg/IntelTdx/IntelTdxX64.dsc  |  1 +
 OvmfPkg/Library/CcProbeLib/CcProbeLib.c   | 24 +++
 OvmfPkg/Library/CcProbeLib/CcProbeLib.inf |  5 +
 OvmfPkg/OvmfPkgX64.dsc|  3 +++
 4 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
index 144d50aa9dba..ca41d9d13e7a 100644
--- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc
+++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
@@ -234,6 +234,7 @@
   HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
   PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
   PeilessStartupLib|OvmfPkg/Library/PeilessStartupLib/PeilessStartupLib.inf
+  CcProbeLib|OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf
 
 [LibraryClasses.common.DXE_CORE]
   HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
diff --git a/OvmfPkg/Library/CcProbeLib/CcProbeLib.c 
b/OvmfPkg/Library/CcProbeLib/CcProbeLib.c
index d698e5c8d7f8..efb929ef8b21 100644
--- a/OvmfPkg/Library/CcProbeLib/CcProbeLib.c
+++ b/OvmfPkg/Library/CcProbeLib/CcProbeLib.c
@@ -7,8 +7,12 @@
 
 **/
 
+#include 
+#include 
 #include 
-#include 
+
+STATIC UINT8CcProbeGuestType = 0;
+STATIC BOOLEAN  CcProbed = FALSE;
 
 /**
   Probe the ConfidentialComputing Guest type. See defition of
@@ -23,9 +27,21 @@ CcProbe (
   VOID
   )
 {
-  OVMF_WORK_AREA  *WorkArea;
+  if (CcProbed) {
+return CcProbeGuestType;
+  }
 
-  WorkArea = (OVMF_WORK_AREA *)FixedPcdGet32 (PcdOvmfWorkAreaBase);
+  if (TdIsEnabled ()) {
+CcProbeGuestType = CcGuestTypeIntelTdx;
+  } else {
+//
+// SEV code should be added here to determine if it is CcGuestTypeAmdSev.
+// Now we set CcProbeGuestType to CcGuestTypeNonEncrypted.
+//
+CcProbeGuestType = CcGuestTypeNonEncrypted;
+  }
 
-  return WorkArea != NULL ? WorkArea->Header.GuestType : 
CcGuestTypeNonEncrypted;
+  CcProbed = TRUE;
+
+  return CcProbeGuestType;
 }
diff --git a/OvmfPkg/Library/CcProbeLib/CcProbeLib.inf 
b/OvmfPkg/Library/CcProbeLib/CcProbeLib.inf
index 5300c9ba2644..99b7434d6180 100644
--- a/OvmfPkg/Library/CcProbeLib/CcProbeLib.inf
+++ b/OvmfPkg/Library/CcProbeLib/CcProbeLib.inf
@@ -12,7 +12,7 @@
   FILE_GUID  = 05184ec9-abb0-4491-8584-e388639a7c48
   MODULE_TYPE= BASE
   VERSION_STRING = 1.0
-  LIBRARY_CLASS  = CcProbeLib
+  LIBRARY_CLASS  = CcProbeLib|DXE_CORE DXE_DRIVER 
DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
 
 [Sources]
   CcProbeLib.c
@@ -20,6 +20,3 @@
 [Packages]
   MdePkg/MdePkg.dec
   OvmfPkg/OvmfPkg.dec
-
-[Pcd]
-  gUefiOvmfPkgTokenSpaceGuid.PcdOvmfWorkAreaBase
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index 8ad04b50f74f..59d47ae272bb 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -287,6 +287,7 @@
 !endif
   VmgExitLib|OvmfPkg/Library/VmgExitLib/SecVmgExitLib.inf
   MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLib.inf
+  CcProbeLib|OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf
 
 [LibraryClasses.common.PEI_CORE]
   HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
@@ -303,6 +304,7 @@
   DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf
 !endif
   PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
+  CcProbeLib|OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf
 
 [LibraryClasses.common.PEIM]
   HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
@@ -332,6 +334,7 @@
   PlatformInitLib|OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf
 
   MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLib.inf
+  CcProbeLib|OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf
 
 [LibraryClasses.common.DXE_CORE]
   HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
-- 
2.29.2.windows.2



-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/2] OvmfPkg: Add SecPeiCcProbeLib

2022-07-07 Thread Min Xu 
From: Min M Xu 

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974

SecPeiCcProbeLib is designed to probe the Confidential Computing guest
type in SEC/PEI phase. The CC guest type was set by each CC guest at
the beginning of boot up and saved in PcdOvmfWorkArea.

Cc: Erdem Aktas 
Cc: James Bottomley 
Cc: Jiewen Yao 
Cc: Gerd Hoffmann 
Cc: Tom Lendacky 
Cc: Yuan Yu 
Signed-off-by: Min Xu 
---
 OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.c | 31 +++
 .../Library/CcProbeLib/SecPeiCcProbeLib.inf   | 25 +++
 2 files changed, 56 insertions(+)
 create mode 100644 OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.c
 create mode 100644 OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf

diff --git a/OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.c 
b/OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.c
new file mode 100644
index ..d698e5c8d7f8
--- /dev/null
+++ b/OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.c
@@ -0,0 +1,31 @@
+/** @file
+
+  CcProbeLib is used to probe the Confidential computing guest type.
+
+  Copyright (c) 2022, Intel Corporation. All rights reserved.
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include 
+#include 
+
+/**
+  Probe the ConfidentialComputing Guest type. See defition of
+  CC_GUEST_TYPE in .
+
+  @return The guest type
+
+**/
+UINT8
+EFIAPI
+CcProbe (
+  VOID
+  )
+{
+  OVMF_WORK_AREA  *WorkArea;
+
+  WorkArea = (OVMF_WORK_AREA *)FixedPcdGet32 (PcdOvmfWorkAreaBase);
+
+  return WorkArea != NULL ? WorkArea->Header.GuestType : 
CcGuestTypeNonEncrypted;
+}
diff --git a/OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf 
b/OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf
new file mode 100644
index ..f63ed71e7c28
--- /dev/null
+++ b/OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf
@@ -0,0 +1,25 @@
+## @file
+# CcProbeLib is used to probe Confidential Computing guest type.
+#
+#  Copyright (c) 2022, Intel Corporation. All rights reserved.
+#  SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+  INF_VERSION= 0x00010005
+  BASE_NAME  = SecPeiCcProbeLib
+  FILE_GUID  = 78eb7f2a-a42a-4b01-b160-5a05a0a52bac
+  MODULE_TYPE= BASE
+  VERSION_STRING = 1.0
+  LIBRARY_CLASS  = CcProbeLib|SEC PEIM PEI_CORE
+
+[Sources]
+  SecPeiCcProbeLib.c
+
+[Packages]
+  MdePkg/MdePkg.dec
+  OvmfPkg/OvmfPkg.dec
+
+[Pcd]
+  gUefiOvmfPkgTokenSpaceGuid.PcdOvmfWorkAreaBase
-- 
2.29.2.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91133): https://edk2.groups.io/g/devel/message/91133
Mute This Topic: https://groups.io/mt/92223434/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 0/2] Re-design CcProbeLib

2022-07-07 Thread Min Xu 
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974

CcProbeLib once was designed to probe the Confidential Computing guest
type by checking the PcdOvmfWorkArea. But this memory is allocated with
either EfiACPIMemoryNVS or EfiBootServicesData. It cannot be accessed
after ExitBootService. Please see the detailed analysis in BZ#3974.

To fix this issue, CcProbeLib is re-designed as 2 implementation:
 - SecPeiCcProbeLib
 - CcProbeLib

In SecPeiCcProbeLib we still check the CC guest type by reading the
PcdOvmfWorkArea. Because it is used in SEC / PEI and we don't worry about
the issues in BZ#3974.

In CcProbeLib we call TdIsEnabled() to check if it is of Tdx guest. To
improve the efficiency the result is cached in a global variable. In
current stage only the Tdx related code is added in CcProbeLib. SEV code
may be added in the future.

The reason why we probe CC guest type in 2 different ways is the global
varialbe. Global variable cannot be used in SEC/PEI and CcProbe is called
very frequently.

Code: https://github.com/mxu9/edk2/tree/CcProbeLib.BZ3974.v1

Cc: Gerd Hoffmann 
Cc: Erdem Aktas 
Cc: James Bottomley 
Cc: Jiewen Yao 
Cc: Tom Lendacky 
Cc: Yuan Yu 
Signed-off-by: Min Xu 

Min M Xu (2):
  OvmfPkg: Add SecPeiCcProbeLib
  OvmfPkg: Update CcProbeLib

 OvmfPkg/IntelTdx/IntelTdxX64.dsc  |  1 +
 OvmfPkg/Library/CcProbeLib/CcProbeLib.c   | 24 +++---
 OvmfPkg/Library/CcProbeLib/CcProbeLib.inf |  5 +--
 OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.c | 31 +++
 .../Library/CcProbeLib/SecPeiCcProbeLib.inf   | 25 +++
 OvmfPkg/OvmfPkgX64.dsc|  3 ++
 6 files changed, 81 insertions(+), 8 deletions(-)
 create mode 100644 OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.c
 create mode 100644 OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf

-- 
2.29.2.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91132): https://edk2.groups.io/g/devel/message/91132
Mute This Topic: https://groups.io/mt/92223431/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 1/8] MdePkg: IORT header update for IORT Rev E.d spec

2022-07-07 Thread Jon Nettleton 
On Wed, Jul 6, 2022 at 11:57 AM Sami Mujawar  wrote:
>
> Bugzilla: 3458 - Add support IORT Rev E.d specification updates
>   (https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
>
> The IO Remapping Table, Platform Design Document, Revision E.d,
> Feb 2022 (https://developer.arm.com/documentation/den0049/)
> introduces the following updates, collectively including the
> updates and errata fixes to Rev E, Rev E.a, Rev E.b, Rev E.c:
>   - increments the IORT table revision to 5.
>   - updates the node definition to add an 'Identifier' field.
>   - adds definition of node type 6 - Reserved Memory Range node.
>   - adds definition for Memory Range Descriptors.
>   - adds flag to indicate PRI support for root complexes.
>   - adds flag to indicate if the root complex supports forwarding
> of PASID information on translated transactions to the SMMU.
>   - adds flag to indicate if the root complex supports PASID.
>   - adds flags to define access privilege and attributes for the
> memory ranges.
>
> Therefore, update the IORT header file to reflect these changes,
> and also rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro to
> EFI_ACPI_IO_REMAPPING_TABLE_REV0.
>
> Signed-off-by: Sami Mujawar 
> ---
>
> Notes:
> v4:
>   - Updated patch series to IORT specification revision E.d. [SAMI]
>   - Add flag to indicate if the root complex supports PASID. [SAMI]
>   - Add flags to define access privilege and attributes for  [SAMI]
> the memory ranges.
> v3:
>   - Submit patch series to update platform code to use the   [LIMING]
> EFI_ACPI_IO_REMAPPING_TABLE_REV0 macro.
> Ref: https://edk2.groups.io/g/devel/topic/83618423#76799
>   - Removed definition of EFI_ACPI_IO_REMAPPING_TABLE_REVISION   [SAMI]
> as EFI_ACPI_IO_REMAPPING_TABLE_REV0 has been provided for
> representing Rev 0. Also, a corresponding patch series
> for updating the platforms in edk2-platforms repository
> shall be submitted to the edk2 mailing list.
>   - Include r-b received from v2 series. [SAMI]
> Ref: https://edk2.groups.io/g/devel/topic/83600724#76660
>
> v2:
>   - Set EFI_ACPI_IO_REMAPPING_TABLE_REVISION to Rev 0 as [SAMI]
> setting to Rev 3 will break existing platforms. The
> problem is that existing code would not be populating
> the Identifier field in the nodes. This can lead to
> non-unique values in the Identifier field.
>
>  MdePkg/Include/IndustryStandard/IoRemappingTable.h | 83 ++--
>  1 file changed, 75 insertions(+), 8 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/IoRemappingTable.h 
> b/MdePkg/Include/IndustryStandard/IoRemappingTable.h
> index 
> 79a34678681d45b2982dc8573db6bd447f42e429..07cb7f49dc936fb00cc549113f1e62f988535e5d
>  100644
> --- a/MdePkg/Include/IndustryStandard/IoRemappingTable.h
> +++ b/MdePkg/Include/IndustryStandard/IoRemappingTable.h
> @@ -1,12 +1,19 @@
>  /** @file
> -  ACPI IO Remapping Table (IORT) as specified in ARM spec DEN0049D
> -
> -  
> http://infocenter.arm.com/help/topic/com.arm.doc.den0049d/DEN0049D_IO_Remapping_Table.pdf
> +  ACPI IO Remapping Table (IORT) definitions.
>
>Copyright (c) 2017, Linaro Limited. All rights reserved.
> -  Copyright (c) 2018, ARM Limited. All rights reserved.
> +  Copyright (c) 2018 - 2022, Arm Limited. All rights reserved.
>
>SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +  @par Reference(s):
> +  - IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022
> +(https://developer.arm.com/documentation/den0049/)
> +
> +  @par Glossary:
> +  - Ref  : Reference
> +  - Mem  : Memory
> +  - Desc : Descriptor
>  **/
>
>  #ifndef __IO_REMAPPING_TABLE_H__
> @@ -14,7 +21,8 @@
>
>  #include 
>
> -#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION  0x0
> +#define EFI_ACPI_IO_REMAPPING_TABLE_REV0  0x0
> +#define EFI_ACPI_IO_REMAPPING_TABLE_REV5  0x5
>
>  #define EFI_ACPI_IORT_TYPE_ITS_GROUP 0x0
>  #define EFI_ACPI_IORT_TYPE_NAMED_COMP0x1
> @@ -22,6 +30,7 @@
>  #define EFI_ACPI_IORT_TYPE_SMMUv1v2  0x3
>  #define EFI_ACPI_IORT_TYPE_SMMUv30x4
>  #define EFI_ACPI_IORT_TYPE_PMCG  0x5
> +#define EFI_ACPI_IORT_TYPE_RMR   0x6
>
>  #define EFI_ACPI_IORT_MEM_ACCESS_PROP_CCA  BIT0
>
> @@ -55,7 +64,29 @@
>  #define EFI_ACPI_IORT_SMMUv3_MODEL_CAVIUM_CN99XX 0x2
>
>  #define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED  0x0
> -#define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_SUPPORTED0x1
> +#define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_SUPPORTEDBIT0
> +
> +#define EFI_ACPI_IORT_ROOT_COMPLEX_PRI_UNSUPPORTED  0x0
> +#define EFI_ACPI_IORT_ROOT_COMPLEX_PRI_SUPPORTEDBIT1
> +
> +#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_FWD_UNSUPPORTED  0x0
> +#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_FWD_SUPPORTEDBIT2
> +
> +#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_UNSUPPORTED  0x0
> +#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_SUPPORTED