Re: [edk2-devel] [PATCH v2] OvmfPkg: RiscVVirt: Fix network drivers not be built
On Fri, Jan 12, 2024 at 05:05:26PM -0800, Tuan Phan wrote: > Only need to include Network.dsc.inc to have all network > drivers/components be built. Otherwise, there were missing definition > that prevent them from be built for RiscVVirt platform. > > Signed-off-by: Tuan Phan > --- > v2: > - Rebase > > OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > Merged as #5260. Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113798): https://edk2.groups.io/g/devel/message/113798 Mute This Topic: https://groups.io/mt/103695672/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg
On Mon, Jan 15, 2024 at 02:17:09PM +0800, Chao Li wrote: > Ray and Sunil, > > I plan send two example PRs to github to show how to deal the INFs, one to > adjust current INF, and another PR to move the libraris to the current > folders. I hope after these two PRs are sent we can decide what to do with > the INF. What do you think of this plan? > > Hi Chao, That's fine with me. Thanks, Sunil > Thanks, > Chao > On 2024/1/15 13:44, Ni, Ray wrote: > > That will be great! > > > > Thanks, > > Ray > > > -Original Message- > > > From: Sunil V L > > > Sent: Monday, January 15, 2024 12:44 PM > > > To: Ni, Ray > > > Cc:devel@edk2.groups.io;lic...@loongson.cn; Kinney, Michael D > > > ; Laszlo Ersek; Gerd > > > Hoffmann > > > Subject: Re: RFC: Folder layout change in UefiCpuPkg > > > > > > On Mon, Jan 15, 2024 at 01:13:03AM +, Ni, Ray wrote: > > > > Sunil, > > > > I am glad that you don't have concern about the direction. > > > > > > > > "RiscV" is good to me. > > > > > > > > > > > Thanks!, Ray. So, shall I send patches to reorganize this? > > > > > > Thanks, > > > Sunil > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113797): https://edk2.groups.io/g/devel/message/113797 Mute This Topic: https://groups.io/mt/103679850/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg
Ray and Sunil, I plan send two example PRs to github to show how to deal the INFs, one to adjust current INF, and another PR to move the libraris to the current folders. I hope after these two PRs are sent we can decide what to do with the INF. What do you think of this plan? Thanks, Chao On 2024/1/15 13:44, Ni, Ray wrote: That will be great! Thanks, Ray -Original Message- From: Sunil V L Sent: Monday, January 15, 2024 12:44 PM To: Ni, Ray Cc:devel@edk2.groups.io;lic...@loongson.cn; Kinney, Michael D ; Laszlo Ersek; Gerd Hoffmann Subject: Re: RFC: Folder layout change in UefiCpuPkg On Mon, Jan 15, 2024 at 01:13:03AM +, Ni, Ray wrote: Sunil, I am glad that you don't have concern about the direction. "RiscV" is good to me. Thanks!, Ray. So, shall I send patches to reorganize this? Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113796): https://edk2.groups.io/g/devel/message/113796 Mute This Topic: https://groups.io/mt/103679850/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg
That will be great! Thanks, Ray > -Original Message- > From: Sunil V L > Sent: Monday, January 15, 2024 12:44 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; lic...@loongson.cn; Kinney, Michael D > ; Laszlo Ersek ; Gerd > Hoffmann > Subject: Re: RFC: Folder layout change in UefiCpuPkg > > On Mon, Jan 15, 2024 at 01:13:03AM +, Ni, Ray wrote: > > Sunil, > > I am glad that you don't have concern about the direction. > > > > "RiscV" is good to me. > > > > > Thanks!, Ray. So, shall I send patches to reorganize this? > > Thanks, > Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113795): https://edk2.groups.io/g/devel/message/113795 Mute This Topic: https://groups.io/mt/103679850/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Thank Liming! > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming via groups.io > Sent: Monday, January 15, 2024 1:02 PM > To: Luo, Heng ; devel@edk2.groups.io; Kasbekar, Saloni > ; Clark-williams, Zachary willi...@intel.com>; Kinney, Michael D > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > if not connect to AP > > Heng: > This one has been merged. > > Thanks > Liming > > -邮件原件- > > 发件人: Luo, Heng > > 发送时间: 2024年1月15日 11:08 > > 收件人: devel@edk2.groups.io; Luo, Heng ; Gao, > Liming > > ; Kasbekar, Saloni > > ; Clark-williams, Zachary > > ; Kinney, Michael D > > > > 主题: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > > if not connect to AP > > > > Hi Liming & Mike, > > Could you please help to merge PR > > https://github.com/tianocore/edk2/pull/5075 ? > > > > Thanks, > > Heng > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of Heng > > Luo > > > Sent: Tuesday, January 9, 2024 11:17 AM > > > To: Gao, Liming ; devel@edk2.groups.io; > > > Kasbekar, Saloni ; Clark-williams, > > > Zachary ; Kinney, Michael D > > > > > > Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > scan only > > if > > > not connect to AP > > > > > > HI Liming, > > > All checks have passed in https://github.com/tianocore/edk2/pull/5075. > > What > > > do I need to do? > > > > > > Thanks, > > > Heng > > > > > > > -Original Message- > > > > From: Luo, Heng > > > > Sent: Wednesday, January 3, 2024 1:55 PM > > > > To: gaoliming ; devel@edk2.groups.io; > > > > Kasbekar, Saloni ; Clark-williams, > > > > Zachary ; Kinney, Michael D > > > > > > > > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > > scan only if not connect to AP > > > > > > > > Thank Liming, here is the PR: > > > > https://github.com/tianocore/edk2/pull/5075 > > > > > > > > Thanks, > > > > Heng > > > > > > > > > -Original Message- > > > > > From: gaoliming > > > > > Sent: Wednesday, January 3, 2024 8:55 AM > > > > > To: devel@edk2.groups.io; Luo, Heng ; > > > > > Kasbekar, Saloni ; Clark-williams, > > > > > Zachary > > > > > ; Kinney, Michael D > > > > > > > > > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger > > > > > regularly scan only if not connect to AP > > > > > > > > > > Heng: > > > > > Can you help create pull request for this patch? Once it pass > > > > > CI, I will merge it. > > > > > > > > > > Thanks > > > > > Liming > > > > > > -邮件原件- > > > > > > 发件人: devel@edk2.groups.io 代表 Heng > > Luo > > > > > > 发送时间: 2024年1月2日 16:55 > > > > > > 收件人: Kasbekar, Saloni ; > > Clark-williams, > > > > > > Zachary ; > > > > > > devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > > > > scan only > > > > > if > > > > > > not connect to AP > > > > > > > > > > > > Hi Mike, > > > > > > Would you like to help us merge the patch? > > > > > > > > > > > > Thanks, > > > > > > Heng > > > > > > > > > > > > > -Original Message- > > > > > > > From: Kasbekar, Saloni > > > > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > > > > To: Luo, Heng ; Clark-williams, Zachary > > > > > > > > > > > > willi...@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > only if not > > > > > > connect > > > > > > > to AP > > > > > > > > > > > > > > Mike, > > > > > > > > > > > > > > Would you be able to help us merge the patch? > > > > > > > > > > > > > > Thanks, > > > > > > > Saloni > > > > > > > > > > > > > > -Original Message- > > > > > > > From: Luo, Heng > > > > > > > Sent: Thursday, December 14, 2023 3:20 AM > > > > > > > To: Clark-williams, Zachary > > > > > > > ; > > > > > Kasbekar, > > > > > > > Saloni ; devel@edk2.groups.io > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > only if not > > > > > > connect > > > > > > > to AP > > > > > > > > > > > > > > Hi Saloni, > > > > > > > Could you help to merge the patch? > > > > > > > > > > > > > > Thanks, > > > > > > > Heng > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Luo, Heng > > > > > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > > > > > To: Clark-williams, Zachary > > > > > > > > ; > > > > > > > > Kasbekar, Saloni ; > > > > > > > > devel@edk2.groups.io > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > > only if not connect to AP > > > > > > > > > > > > > > > > Hi Zack, > > > > > > > > Could you please review the change? > > > > > > > > Thanks, > > > > > > > > Heng > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > > From: Kasbekar, Saloni > > > > > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > > > > > To: Luo, Heng ; devel@edk2.groups.io > > > > > > > > > Cc: Clark-williams, Zachary > > > > > > > > >
Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: handle floating point number in JSON
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Sunday, January 14, 2024 10:14 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH v2] RedfishPkg/RedfishCrtLib: handle floating point number
> in JSON
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> When the value type is defined as number in Redfish schema, floating
> point number is allowed. RedfishCrtLib raises assert without handling
> this case now. Follow the way in EDK2 to call AsciiStrDecimalToUintnS
> and handle the floating point number. Only the integer value is
> returned.
>
> Signed-off-by: Nickle Wang
> Cc: Abner Chang
> Cc: Igor Kulchytskyy
> Cc: Nick Ramirez
> ---
> RedfishPkg/Library/JsonLib/load.c | 5 +--
> .../RedfishCrtLib/RedfishCrtLib.c | 32 ---
> 2 files changed, 30 insertions(+), 7 deletions(-)
>
> diff --git a/RedfishPkg/Library/JsonLib/load.c
> b/RedfishPkg/Library/JsonLib/load.c
> index 958c3ea8c5..1a3b4a6e6a 100644
> --- a/RedfishPkg/Library/JsonLib/load.c
> +++ b/RedfishPkg/Library/JsonLib/load.c
> @@ -5,6 +5,7 @@
> * it under the terms of the MIT license. See LICENSE for details.
>
> (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
>
> SPDX-License-Identifier: BSD-2-Clause-Patent AND MIT
> */
> @@ -717,8 +718,8 @@ lex_scan_number (
> goto out;
>}
>
> - lex->token = TOKEN_REAL;
> - lex->value.real = doubleval;
> + lex->token = TOKEN_INTEGER;
> + lex->value.integer = doubleval;
>return 0;
>
> out:
> diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
> b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
> index 57a997f351..902dd0b3a0 100644
> --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
> +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
> @@ -4,6 +4,7 @@
>
>Copyright (c) 2019, Intel Corporation. All rights reserved.
>(C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -519,7 +520,7 @@ strtoull (
> }
>
> /**
> - edk2 Jansson port does not support doubles, simply return 0.
> + edk2 Jansson port does not support doubles, simply return integer part.
>
>These conversion functions convert the initial portion of the string
>pointed to by nptr to double, float, and long double representation,
> @@ -540,7 +541,7 @@ strtoull (
>the return value), and ERANGE is stored in errno. If the correct value
>would cause underflow, zero is returned and ERANGE is stored in errno.
>
> - @return Return 0.
> + @return Integer part of decimal number.
> **/
> double
> strtod (
> @@ -548,9 +549,30 @@ strtod (
>char **__restrict endptr
>)
> {
> - DEBUG ((DEBUG_ERROR, "We don't supprot double type on edk2 yet!"));
> - ASSERT (FALSE);
> - return (double)0;
> + UINTN Data;
> + UINTN StrLen;
> +
> + Data = 0;
> + StrLen = 0;
> +
> + if (nptr == NULL) {
> +return (double)0;
> + }
> +
> + AsciiStrDecimalToUintnS (nptr, NULL, );
> + DEBUG ((DEBUG_WARN, "%a: \"%a\" We don't support double type on
> edk2 yet. Only integer part is returned: %d\n", __func__, nptr, Data));
> +
> + //
> + // Force endptr to the last position of nptr because caller may
> + // check endptr and raise assertion. We don't support floating
> + // number in edk2 so this prevents unecessary assertion from happening.
> + //
> + if (endptr != NULL) {
> +StrLen = AsciiStrLen (nptr);
> +*endptr = (char *__restrict)nptr + StrLen;
> + }
> +
> + return (double)Data;
> }
>
> static UINT8 BitMask[] = {
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113793): https://edk2.groups.io/g/devel/message/113793
Mute This Topic: https://groups.io/mt/103718898/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Heng: This one has been merged. Thanks Liming > -邮件原件- > 发件人: Luo, Heng > 发送时间: 2024年1月15日 11:08 > 收件人: devel@edk2.groups.io; Luo, Heng ; Gao, > Liming ; Kasbekar, Saloni > ; Clark-williams, Zachary > ; Kinney, Michael D > > 主题: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if > not connect to AP > > Hi Liming & Mike, > Could you please help to merge PR > https://github.com/tianocore/edk2/pull/5075 ? > > Thanks, > Heng > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Heng > Luo > > Sent: Tuesday, January 9, 2024 11:17 AM > > To: Gao, Liming ; devel@edk2.groups.io; > > Kasbekar, Saloni ; Clark-williams, Zachary > > ; Kinney, Michael D > > > > Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > if > > not connect to AP > > > > HI Liming, > > All checks have passed in https://github.com/tianocore/edk2/pull/5075. > What > > do I need to do? > > > > Thanks, > > Heng > > > > > -Original Message- > > > From: Luo, Heng > > > Sent: Wednesday, January 3, 2024 1:55 PM > > > To: gaoliming ; devel@edk2.groups.io; > > > Kasbekar, Saloni ; Clark-williams, Zachary > > > ; Kinney, Michael D > > > > > > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > > only if not connect to AP > > > > > > Thank Liming, here is the PR: > > > https://github.com/tianocore/edk2/pull/5075 > > > > > > Thanks, > > > Heng > > > > > > > -Original Message- > > > > From: gaoliming > > > > Sent: Wednesday, January 3, 2024 8:55 AM > > > > To: devel@edk2.groups.io; Luo, Heng ; Kasbekar, > > > > Saloni ; Clark-williams, Zachary > > > > ; Kinney, Michael D > > > > > > > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > > scan only if not connect to AP > > > > > > > > Heng: > > > > Can you help create pull request for this patch? Once it pass CI, > > > > I will merge it. > > > > > > > > Thanks > > > > Liming > > > > > -邮件原件- > > > > > 发件人: devel@edk2.groups.io 代表 Heng > Luo > > > > > 发送时间: 2024年1月2日 16:55 > > > > > 收件人: Kasbekar, Saloni ; > Clark-williams, > > > > > Zachary ; devel@edk2.groups.io; > > > > > Kinney, Michael D > > > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > > > > only > > > > if > > > > > not connect to AP > > > > > > > > > > Hi Mike, > > > > > Would you like to help us merge the patch? > > > > > > > > > > Thanks, > > > > > Heng > > > > > > > > > > > -Original Message- > > > > > > From: Kasbekar, Saloni > > > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > > > To: Luo, Heng ; Clark-williams, Zachary > > > > > > > > > > willi...@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > if not > > > > > connect > > > > > > to AP > > > > > > > > > > > > Mike, > > > > > > > > > > > > Would you be able to help us merge the patch? > > > > > > > > > > > > Thanks, > > > > > > Saloni > > > > > > > > > > > > -Original Message- > > > > > > From: Luo, Heng > > > > > > Sent: Thursday, December 14, 2023 3:20 AM > > > > > > To: Clark-williams, Zachary ; > > > > Kasbekar, > > > > > > Saloni ; devel@edk2.groups.io > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > if not > > > > > connect > > > > > > to AP > > > > > > > > > > > > Hi Saloni, > > > > > > Could you help to merge the patch? > > > > > > > > > > > > Thanks, > > > > > > Heng > > > > > > > > > > > > > -Original Message- > > > > > > > From: Luo, Heng > > > > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > > > > To: Clark-williams, Zachary > > > > > > > ; > > > > > > > Kasbekar, Saloni ; > > > > > > > devel@edk2.groups.io > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > > if not connect to AP > > > > > > > > > > > > > > Hi Zack, > > > > > > > Could you please review the change? > > > > > > > Thanks, > > > > > > > Heng > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Kasbekar, Saloni > > > > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > > > > To: Luo, Heng ; devel@edk2.groups.io > > > > > > > > Cc: Clark-williams, Zachary > > > > > > > > > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > > only if not connect to AP > > > > > > > > > > > > > > > > Reviewed-by: Kasbekar, Saloni > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Saloni > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Luo, Heng > > > > > > > > Sent: Monday, November 27, 2023 7:07 PM > > > > > > > > To: devel@edk2.groups.io > > > > > > > > Cc: Kasbekar, Saloni ; > > > > > > > > Clark-williams, Zachary > > > > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > > > if not connect to AP > > > > > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > > >
Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg
On Mon, Jan 15, 2024 at 01:13:03AM +, Ni, Ray wrote: > Sunil, > I am glad that you don't have concern about the direction. > > "RiscV" is good to me. > > Thanks!, Ray. So, shall I send patches to reorganize this? Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113791): https://edk2.groups.io/g/devel/message/113791 Mute This Topic: https://groups.io/mt/103679850/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension
On Sat, Jan 13, 2024 at 10:39:16AM +0800, caiyuqing...@163.com wrote: > From: caiyuqing379 > > Override Sstc extension and use SBI calls itself by default for RISC-V > Sophgo SG2042 platform. > Since the change disables CMO also (BIT 0) which is expected, could you update the commit message to reflect it? Otherwise, Reviewed-by: Sunil V L Thanks, Sunil > Cc: dahogn > Cc: meng-cz > Cc: USER0FISH > Cc: Sunil V L > Signed-off-by: caiyuqing379 > --- > Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc > b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc > index 3bbaeca16970..127182487126 100644 > --- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc > +++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc > @@ -265,6 +265,7 @@ >gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE >gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 >gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE > + gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFC >gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10 >gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 >gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000 > -- > 2.34.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113790): https://edk2.groups.io/g/devel/message/113790 Mute This Topic: https://groups.io/mt/103733215/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] OvmfPkg: RiscVVirt: Fix network drivers not be built
On Fri, Jan 12, 2024 at 05:05:26PM -0800, Tuan Phan wrote: > Only need to include Network.dsc.inc to have all network > drivers/components be built. Otherwise, there were missing definition > that prevent them from be built for RiscVVirt platform. > > Signed-off-by: Tuan Phan > --- > v2: > - Rebase > > OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > Thanks for the patch, Tuan. Sorry, I missed to merge earlier. Reviewed-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113789): https://edk2.groups.io/g/devel/message/113789 Mute This Topic: https://groups.io/mt/103695672/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Hi Liming & Mike, Could you please help to merge PR https://github.com/tianocore/edk2/pull/5075 ? Thanks, Heng > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heng Luo > Sent: Tuesday, January 9, 2024 11:17 AM > To: Gao, Liming ; devel@edk2.groups.io; > Kasbekar, Saloni ; Clark-williams, Zachary > ; Kinney, Michael D > > Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if > not connect to AP > > HI Liming, > All checks have passed in https://github.com/tianocore/edk2/pull/5075. What > do I need to do? > > Thanks, > Heng > > > -Original Message- > > From: Luo, Heng > > Sent: Wednesday, January 3, 2024 1:55 PM > > To: gaoliming ; devel@edk2.groups.io; > > Kasbekar, Saloni ; Clark-williams, Zachary > > ; Kinney, Michael D > > > > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > only if not connect to AP > > > > Thank Liming, here is the PR: > > https://github.com/tianocore/edk2/pull/5075 > > > > Thanks, > > Heng > > > > > -Original Message- > > > From: gaoliming > > > Sent: Wednesday, January 3, 2024 8:55 AM > > > To: devel@edk2.groups.io; Luo, Heng ; Kasbekar, > > > Saloni ; Clark-williams, Zachary > > > ; Kinney, Michael D > > > > > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > scan only if not connect to AP > > > > > > Heng: > > > Can you help create pull request for this patch? Once it pass CI, > > > I will merge it. > > > > > > Thanks > > > Liming > > > > -邮件原件- > > > > 发件人: devel@edk2.groups.io 代表 Heng Luo > > > > 发送时间: 2024年1月2日 16:55 > > > > 收件人: Kasbekar, Saloni ; Clark-williams, > > > > Zachary ; devel@edk2.groups.io; > > > > Kinney, Michael D > > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > > > only > > > if > > > > not connect to AP > > > > > > > > Hi Mike, > > > > Would you like to help us merge the patch? > > > > > > > > Thanks, > > > > Heng > > > > > > > > > -Original Message- > > > > > From: Kasbekar, Saloni > > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > > To: Luo, Heng ; Clark-williams, Zachary > > > > > > > > willi...@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > if not > > > > connect > > > > > to AP > > > > > > > > > > Mike, > > > > > > > > > > Would you be able to help us merge the patch? > > > > > > > > > > Thanks, > > > > > Saloni > > > > > > > > > > -Original Message- > > > > > From: Luo, Heng > > > > > Sent: Thursday, December 14, 2023 3:20 AM > > > > > To: Clark-williams, Zachary ; > > > Kasbekar, > > > > > Saloni ; devel@edk2.groups.io > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > if not > > > > connect > > > > > to AP > > > > > > > > > > Hi Saloni, > > > > > Could you help to merge the patch? > > > > > > > > > > Thanks, > > > > > Heng > > > > > > > > > > > -Original Message- > > > > > > From: Luo, Heng > > > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > > > To: Clark-williams, Zachary > > > > > > ; > > > > > > Kasbekar, Saloni ; > > > > > > devel@edk2.groups.io > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > if not connect to AP > > > > > > > > > > > > Hi Zack, > > > > > > Could you please review the change? > > > > > > Thanks, > > > > > > Heng > > > > > > > > > > > > > -Original Message- > > > > > > > From: Kasbekar, Saloni > > > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > > > To: Luo, Heng ; devel@edk2.groups.io > > > > > > > Cc: Clark-williams, Zachary > > > > > > > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > only if not connect to AP > > > > > > > > > > > > > > Reviewed-by: Kasbekar, Saloni > > > > > > > > > > > > > > Thanks, > > > > > > > Saloni > > > > > > > > > > > > > > -Original Message- > > > > > > > From: Luo, Heng > > > > > > > Sent: Monday, November 27, 2023 7:07 PM > > > > > > > To: devel@edk2.groups.io > > > > > > > Cc: Kasbekar, Saloni ; > > > > > > > Clark-williams, Zachary > > > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > > if not connect to AP > > > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > > > > > > > > > > > When UEFI Wi-Fi is in BSS connected state, the platform is > > > > > > > considered as a static and Wi-Fi roaming support is not needed. > > > > > > > Wifi connection manager should not initiate Scan requests in > > > > > > > this state affect BSS client connectivity and must be avoided. > > > > > > > Triger regularly scan only if not connect to AP. > > > > > > > > > > > > > > Signed-off-by: Heng Luo > > > > > > > Cc: Saloni Kasbekar > > > > > > > Cc: Zachary Clark-williams > > > > > > > > > > > > > > --- > > > > > > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > | > > > > 4 > > > > > ++- > >
Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap
Hi Laszlo, I don't think it is a good idea to explicitly mask out the Accessed/Dirty bit. We can't assume Accessed/Dirty bit are only changed by hardware, because the caller also can change the Accessed/Dirty bit. For API PageTableMap, the IsModified is already set as False in the beginning of the function. For internal function PageTableLibMapInLevel, we don't set IsModified as False in the beginning on purpose, because it keeps the global state of whether the PageTable is changed. I plan to change the comment as below to explicitly explain the behavior: For internal function PageTableLibMapInLevel, the description of IsModified should be: @param[in, out] IsModified change IsModified to True if page table is modified and input parameter Modify is TRUE. For API PageTableMap, the description of IsModified should be: @param[out] IsModified TRUE means page table is modified by software or hardware. FALSE means page table is not modified by software. If the output IsModified is FALSE, there is possibility that the page table is changed by hardware. It is ok because page table can be changed by hardware anytime, and we don't need to Flush TLB. With these comments changed, I don't need to change C code in my patch. BTW, I assume IsModified can be used as an indicator whether the caller need to flush TLB. Do you prefer to change the parameter name to IsFlushTlbNeeded? I am both fine. Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Thursday, January 11, 2024 4:57 PM > To: devel@edk2.groups.io; Ni, Ray ; Liu, Zhiguang > > Cc: Kumar, Rahul R ; Gerd Hoffmann > ; Lee, Crystal > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is > wrongly set in PageTableMap > > On 1/11/24 03:03, Ni, Ray wrote: > >> This function is incredibly complicated, so reviewing this patch is > >> hard, even after reading the bugzilla ticket. > >> > >> The commit message is useless. It should contain a brief description > >> of the problem, and how the fix resolves the problem. > >> > >> The documentation of the PageTableLibMapInLevel() function is wrong, > >> even before this patch. It documents the "IsModified" output-only > >> parameter as follows: > >> > >> "TRUE means page table is modified. FALSE means page table is not > >> modified." > >> > >> This states that "IsModified" is always set on output, to either > >> FALSE or TRUE. Which is an incorrect statement; in reality the caller > >> is expected to pre-set (*IsModified) to FALSE, and > >> PageTableLibMapInLevel() will (conditionally!) perform a FALSE->TRUE > transition only. > >> > >> Now, this patch may fix a bug, but it makes the above-described > >> documentation issue worse, by further restricting the condition for > >> said > >> FALSE->TRUE transition. > > > > Laszlo, thanks for the comments! > > Though the fixing looks simple, Zhiguang and I did have several rounds > > of offline discussions regarding how to fix it. > > > > When the lib accesses the page table content, CPU would set the > > "Access" bit in the page entry that points to the page table memory being > accessed by the lib. > > > > So, even when the "Modify" is FALSE (indicating caller doesn't want > > the lib to modify the page table), lib code should not modify the page > > table but CPU still sets the "Access" bit in some of the entries due to the > reasons above. > > Huh, tricky! > > Should the comparison explicitly mask out the Accessed bit from each of the > "before" page table entry and the "after" one, perhaps? > > > I agree it will be better that the commit message carries above details. > > > > Zhiguang, > > Can we update the code to always assign "IsModified"? I thought we did > that but it seems not. > > That seems doable by (e.g.) setting (*IsModified) to FALSE right at the top of > the function, and then the logic would match the existent comments, I think. > However, I've not checked whether callers actually rely on this "summing" > logic > of the IsModified output parameter -- like call the function a number of times > in a row, using a common local variable to receive IsModified, and then check > the local variable to see if *any one* of the calls in the loop has modified > the > page table. > > Thanks > Laszlo > > > > >> > >> The fix per se looks vaguely reasonable to me (really the function is > >> so complicated that verifying this change from scratch would take me > >> ages), but minimally, the documentation of "IsModified" should > >> certainly be updated too. To something like this: > >> > >> @param[out] IsModified If "Modify" is TRUE on input and the function > >> has actually modified the page table, then > >> set > >> to TRUE on output. Not overwritten > >> otherwise. > >> > >> Laszlo > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this
Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
Hi Liming, Could you help to merge below patches which all your reviewed-by? Thanks! https://github.com/tianocore/edk2/pull/5170 https://github.com/tianocore/edk2/pull/5186 https://github.com/tianocore/edk2/pull/5190 Thanks Ren, Suqiang -Original Message- From: Ren, SuqiangX Sent: Monday, January 8, 2024 9:31 PM To: gaoliming ; devel@edk2.groups.io Cc: Kinney, Michael D ; Liu, Zhiguang ; Li, Yi1 Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig Hi Liming, Could you please help to check and merge this patch? https://github.com/tianocore/edk2/pull/5170 Thanks Ren, Suqiang -Original Message- From: gaoliming Sent: Saturday, December 23, 2023 10:10 AM To: devel@edk2.groups.io; Ren, SuqiangX Cc: Kinney, Michael D ; Liu, Zhiguang ; Li, Yi1 Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 SuqiangX Ren > 发送时间: 2023年12月21日 10:41 > 收件人: devel@edk2.groups.io > 抄送: Ren,Suqiang ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Yi Li > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of > HiiConfigAccess ExtractConfig > > From: "Ren,Suqiang" > > Add status code returned for HiiConfigAccess ExtractConfig to align > with UEFI spec 2.10. > > REF: UEFI spec 2.10 Table 35.5.2 > > Signed-off-by: SuqiangX Ren > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Yi Li > --- > MdePkg/Include/Protocol/HiiConfigAccess.h | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h > b/MdePkg/Include/Protocol/HiiConfigAccess.h > index 3baf91e07b2e..fbee7c52b021 100644 > --- a/MdePkg/Include/Protocol/HiiConfigAccess.h > +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h > @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION; >string. > >@retval EFI_INVALID_PARAMETER Unknown name. Progress points > - to the & before the name in > + to the "&" before the name in >question. > > + @retval EFI_INVALID_PARAMETER If Results or Progress is NULL. > + > + @retval EFI_ACCESS_DENIED The action violated a system policy. > + > + @retval EFI_DEVICE_ERRORFailed to extract the current > configuration > + for one or more named elements. > + > **/ > typedef > EFI_STATUS > -- > 2.26.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113786): https://edk2.groups.io/g/devel/message/113786 Mute This Topic: https://groups.io/mt/103596624/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform
> -原始邮件- > 发件人: "Sunil V L" > 发送时间: 2024-01-11 23:21:21 (星期四) > 收件人: devel@edk2.groups.io, andrei.warken...@intel.com > 抄送: "Yang Wang" , "Ran Wang" , > "Bamvor Jian ZHANG" , "Gao, Liming" > , "Kinney, Michael D" , > "Liu, Zhiguang" > 主题: Re: [edk2-devel] [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv > platform > > On Fri, Jan 05, 2024 at 03:47:07PM +, Andrei Warkentin wrote: > > Looks reasonable to me. > > > > Reviewed-by: Andrei Warkentin > > > > > -Original Message- > > > From: Yang Wang > > > Sent: Wednesday, December 27, 2023 8:57 PM > > > To: Warkentin, Andrei ; devel@edk2.groups.io > > > Cc: Yang Wang ; Ran Wang ; > > > Bamvor Jian ZHANG ; Gao, Liming > > > ; Kinney, Michael D > > > ; Sunil V L ; Liu, > > > Zhiguang > > > Subject: [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform > > > > > > For scene of > > > HandOffToDxeCore()->SwitchStack(DxeCoreEntryPoint)-> > > > InternalSwitchStack()->LongJump(),Variable HobList.Raw > > > will be passed (from *Context1 to register a0) to > > > DxeMain() in parameter *HobStart. > > > > > > However, meanwhile the function LongJump() overrides > > > register a0 with a1 (-1) due to commit (ea628f28e5 "RISCV: Fix > > > InternalLongJump to return correct value"), then cause hang. > > > > > > Replacing calling LongJump() with new InternalSwitchStackAsm() to pass > > > addres data in register s0 to register a0 could fix this issue (just > > > like the solution in MdePkg/Library/BaseLib/AArch64/SwitchStack.S) > > > > > > Signed-off-by: Yang Wang > > > Reviewed-by: Ran Wang > > > Cc: Bamvor Jian ZHANG > > > Cc: Andrei Warkentin > > > Cc: Liming Gao > > > Cc: Michael D Kinney > > > Cc: Sunil V L > > > Cc: Zhiguang Liu > > > --- > Thanks for the patch!. Merged this as #5255 after fixing a minor > formatting issue. Thank you. > > Thanks, > Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113785): https://edk2.groups.io/g/devel/message/113785 Mute This Topic: https://groups.io/mt/103395756/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V2 0/2] Update keybaord map based on UEFI spec 2.10
Hi Liming, Could you help merge below patches which got your reviewed-by? Thanks! https://github.com/tianocore/edk2/pull/5210 https://github.com/tianocore/edk2/pull/5187 Regards, Yi -Original Message- From: gaoliming Sent: Monday, January 8, 2024 9:16 AM To: Li, Yi1 ; devel@edk2.groups.io Cc: Kinney, Michael D ; Liu, Zhiguang ; 'Rebecca Cran' ; Feng, Bob C ; Chen, Christine Subject: 回复: [PATCH V2 0/2] Update keybaord map based on UEFI spec 2.10 Reviewed-by: Liming Gao > -邮件原件- > 发件人: Yi Li > 发送时间: 2023年12月25日 10:23 > 收件人: devel@edk2.groups.io > 抄送: Yi Li ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Rebecca Cran > ; Bob Feng ; Yuwei Chen > > 主题: [PATCH V2 0/2] Update keybaord map based on UEFI spec 2.10 > > REF: UEFI SPEC 2.10 34.8.10 EFI_KEY > > Add EfiKeyIntl0-9. > > Signed-off-by: Yi Li > > v2: > Remove changes in HiiFramework.h because it should follow HII spec. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > > Yi Li (2): > MdePkg: Update keybaord map based on UEFI spec 2.10 > BaseTools: Update keybaord map based on UEFI spec 2.10 > > .../Include/Common/UefiInternalFormRepresentation.h | 12 > +++- > MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 12 > +++- > 2 files changed, 22 insertions(+), 2 deletions(-) > > -- > 2.42.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113784): https://edk2.groups.io/g/devel/message/113784 Mute This Topic: https://groups.io/mt/103730745/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg
Sunil, I am glad that you don't have concern about the direction. "RiscV" is good to me. Thanks, Ray > -Original Message- > From: Sunil V L > Sent: Friday, January 12, 2024 6:19 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; lic...@loongson.cn; Kinney, Michael D > ; Laszlo Ersek ; Gerd > Hoffmann > Subject: Re: RFC: Folder layout change in UefiCpuPkg > > Hi Ray, > > On Fri, Jan 12, 2024 at 09:12:34AM +, Ni, Ray wrote: > > Sunil, > > I would like to hear your feedback regarding locations of following RiscV64 > components in UefiCpuPkg: > > * UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/ > > * UefiCpuPkg/Library/BaseRiscV64CpuTimerLib/ > > * UefiCpuPkg/CpuDxeRiscV64/ > > * UefiCpuPkg/CpuTimerDxeRiscV64/ > > > > I would like to move them to the following new locations accordingly: > > * UefiCpuPkg/Library/CpuExceptionHandlerLib/RiscV64/ > > * UefiCpuPkg/Library/CpuTimerLib/RiscV64/ > > * UefiCpuPkg/CpuDxe/RiscV64/ > > * UefiCpuPkg/CpuTimerDxe/RiscV64/ > > > > > > I want to avoid too many similar drivers in root folder, and too many > > libraries > in Library folder. > > > > Movement of the first 3 ones put the RiscV components under existing > folders. > > Movement of the last one creates the UefiCpuPkg/CpuTimerDxe folder, that > could be potentially shared by other archs as well. > > > > I raised similar comments to Chao Li who is working on LoongArch upstream. > > > > The location movement follows the 2nd pattern defined by edk2 coding > standard: > > Driver's location could be: > > [[]] > > or > > [/[/]] > > > > Library's location could be: > > > > [[]][] > > > > or > > > > []/[[/]] > > > > > Your proposal looks good to me except better to keep directory name as > RiscV as in other packages. > > Thanks, > Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113783): https://edk2.groups.io/g/devel/message/113783 Mute This Topic: https://groups.io/mt/103679850/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, January 15, 2024 #cal-reminder
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, January 15, 2024 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%2223af6561-6e1c-450d-b917-d9d674eb3cb6%22%7d View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=2159617 ) *Description:* TianoCore community, Microsoft and Intel will be hosting a series of open meetings to discuss build, CI, tools, and other related topics. If you are interested, have ideas/opinions please join us. These meetings will be Monday 4:30pm Pacific Time on Microsoft Teams. MS Teams Link in following discussion: * https://github.com/tianocore/edk2/discussions/2614 Anyone is welcome to join. * tianocore/edk2: EDK II (github.com) * tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module (github.com) https://github.com/tianocore/edk2-basetools * tianocore/edk2-pytool-extensions: Extensions to the edk2 build system allowing for a more robust and plugin based build system and tool execution environment (github.com) https://github.com/tianocore/edk2-pytool-extensions * tianocore/edk2-pytool-library: Python library package that supports UEFI development (github.com) https://github.com/tianocore/edk2-pytool-library MS Teams Browser Clients * https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113782): https://edk2.groups.io/g/devel/message/113782 Mute This Topic: https://groups.io/mt/103729867/21656 Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: handle floating point number in JSON
Thanks Abner. I found an issue in this patch and resolved it in version 2 here:
https://edk2.groups.io/g/devel/message/113780
Could you please help me to review it again?
Regards,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Saturday, January 13, 2024 10:19 PM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nick Ramirez
> Subject: RE: [PATCH] RedfishPkg/RedfishCrtLib: handle floating point number in
> JSON
>
> External email: Use caution opening links or attachments
>
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Abner Chang
>
> > -Original Message-
> > From: Nickle Wang
> > Sent: Friday, January 12, 2024 6:42 PM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner ; Igor Kulchytskyy
> > ; Nick Ramirez
> > Subject: [PATCH] RedfishPkg/RedfishCrtLib: handle floating point
> > number in JSON
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > When the value type is defined as number in Redfish schema, floating
> > point number is allowed. RedfishCrtLib raises assert without handling
> > this case now. Follow the way in EDK2 to call AsciiStrDecimalToUintnS
> > and handle the floating point number.
> >
> > Signed-off-by: Nickle Wang
> > Cc: Abner Chang
> > Cc: Igor Kulchytskyy
> > Cc: Nick Ramirez
> > ---
> > .../PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c | 15
> > ++-
> > 1 file changed, 10 insertions(+), 5 deletions(-)
> >
> > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
> > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
> > index 57a997f351..e88d874224 100644
> > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
> > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
> > @@ -4,6 +4,7 @@
> >
> >Copyright (c) 2019, Intel Corporation. All rights reserved.
> >(C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > + Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
> > reserved.
> >
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -519,7 +520,7 @@ strtoull (
> > }
> >
> > /**
> > - edk2 Jansson port does not support doubles, simply return 0.
> > + edk2 Jansson port does not support doubles, simply return integer part.
> >
> >These conversion functions convert the initial portion of the string
> >pointed to by nptr to double, float, and long double
> > representation, @@ -540,7 +541,7 @@ strtoull (
> >the return value), and ERANGE is stored in errno. If the correct value
> >would cause underflow, zero is returned and ERANGE is stored in errno.
> >
> > - @return Return 0.
> > + @return Integer part of decimal number.
> > **/
> > double
> > strtod (
> > @@ -548,9 +549,13 @@ strtod (
> >char **__restrict endptr
> >)
> > {
> > - DEBUG ((DEBUG_ERROR, "We don't supprot double type on edk2 yet!"));
> > - ASSERT (FALSE);
> > - return (double)0;
> > + UINTN Data;
> > +
> > + Data = 0;
> > +
> > + AsciiStrDecimalToUintnS (nptr, endptr, ); DEBUG ((DEBUG_WARN,
> > + "%a: We don't support double type on edk2 yet.
> > Only integer part is returned\n", __func__));
> > + return (double)Data;
> > }
> >
> > static UINT8 BitMask[] = {
> > --
> > 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113781): https://edk2.groups.io/g/devel/message/113781
Mute This Topic: https://groups.io/mt/103680418/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: handle floating point number in JSON
When the value type is defined as number in Redfish schema, floating
point number is allowed. RedfishCrtLib raises assert without handling
this case now. Follow the way in EDK2 to call AsciiStrDecimalToUintnS
and handle the floating point number. Only the integer value is
returned.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/Library/JsonLib/load.c | 5 +--
.../RedfishCrtLib/RedfishCrtLib.c | 32 ---
2 files changed, 30 insertions(+), 7 deletions(-)
diff --git a/RedfishPkg/Library/JsonLib/load.c
b/RedfishPkg/Library/JsonLib/load.c
index 958c3ea8c5..1a3b4a6e6a 100644
--- a/RedfishPkg/Library/JsonLib/load.c
+++ b/RedfishPkg/Library/JsonLib/load.c
@@ -5,6 +5,7 @@
* it under the terms of the MIT license. See LICENSE for details.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent AND MIT
*/
@@ -717,8 +718,8 @@ lex_scan_number (
goto out;
}
- lex->token = TOKEN_REAL;
- lex->value.real = doubleval;
+ lex->token = TOKEN_INTEGER;
+ lex->value.integer = doubleval;
return 0;
out:
diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
index 57a997f351..902dd0b3a0 100644
--- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
+++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c
@@ -4,6 +4,7 @@
Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -519,7 +520,7 @@ strtoull (
}
/**
- edk2 Jansson port does not support doubles, simply return 0.
+ edk2 Jansson port does not support doubles, simply return integer part.
These conversion functions convert the initial portion of the string
pointed to by nptr to double, float, and long double representation,
@@ -540,7 +541,7 @@ strtoull (
the return value), and ERANGE is stored in errno. If the correct value
would cause underflow, zero is returned and ERANGE is stored in errno.
- @return Return 0.
+ @return Integer part of decimal number.
**/
double
strtod (
@@ -548,9 +549,30 @@ strtod (
char **__restrict endptr
)
{
- DEBUG ((DEBUG_ERROR, "We don't supprot double type on edk2 yet!"));
- ASSERT (FALSE);
- return (double)0;
+ UINTN Data;
+ UINTN StrLen;
+
+ Data = 0;
+ StrLen = 0;
+
+ if (nptr == NULL) {
+return (double)0;
+ }
+
+ AsciiStrDecimalToUintnS (nptr, NULL, );
+ DEBUG ((DEBUG_WARN, "%a: \"%a\" We don't support double type on edk2 yet.
Only integer part is returned: %d\n", __func__, nptr, Data));
+
+ //
+ // Force endptr to the last position of nptr because caller may
+ // check endptr and raise assertion. We don't support floating
+ // number in edk2 so this prevents unecessary assertion from happening.
+ //
+ if (endptr != NULL) {
+StrLen = AsciiStrLen (nptr);
+*endptr = (char *__restrict)nptr + StrLen;
+ }
+
+ return (double)Data;
}
static UINT8 BitMask[] = {
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113780): https://edk2.groups.io/g/devel/message/113780
Mute This Topic: https://groups.io/mt/103718898/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
