Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses
Hi, thank you for taking a look at the patch! This patch can be verified to be working with this app (which was the motivation for submitting this): https://github.com/codyd51/uefirc/releases/tag/1.0.1. I am happy to switch to a tablet device if that's a clearer choice (pending environment setup/line ending issues on my end while generating the patch). I am also happy to add this to other Omvf variants, but am less confident in my ability to test those. All the best, Phillip On Mon, Apr 8, 2024 at 8:35 AM Gerd Hoffmann wrote: > On Sat, Apr 06, 2024 at 02:41:54PM +0200, Heinrich Schuchardt wrote: > > From: Phillip Tennen > > > > From: Phillip Tennen > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4747 > > > > UsbMouseDxe was missing from the OVMF build description, so=20 > > the Simple Pointer Protocol wasn't usable from within QEMU. > > What is the use case? > > How can this be tested? As far I know neither the edk2 setup utility > (aka UiApp) nor typical OS boot loaders have mouse support ... > > Also note that virtual machines typically do *not* have a mouse but a > tablet device, so UsbMouseAbsolutePointerDxe looks like the more > sensible choice to me. > > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > OvmfPkg/OvmfPkgX64.fdf | 1 + > > What about the other ovmf variants? > > take care, > Gerd > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117539): https://edk2.groups.io/g/devel/message/117539 Mute This Topic: https://groups.io/mt/105365480/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] OvmfPkg: OVMF supports USB mouses
From: Phillip Tennen UsbMouseDxe was missing from the OVMF build description, so the Simple Pointer Protocol wasn't usable from within QEMU. Here's an example of somone getting tripped up by this: https://forum.osdev.org/viewtopic.php?f=1=31572. I worked around this by including the below patch in my local builds, and was encouraged by Heinrich Schuchardt to submit a patch. I have not contributed to this project before, so please accept my apologies if I've formatted anything incorrect. All the best. Signed-off-by: Phillip Tennen --- OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/OvmfPkgX64.fdf | 1 + 2 files changed, 2 insertions(+) diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 56c920168d..d76a263859 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -953,6 +953,7 @@ MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf + MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf !include OvmfPkg/Include/Dsc/ShellComponents.dsc.inc diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf index eb3fb90cb8..bfe201a352 100644 --- a/OvmfPkg/OvmfPkgX64.fdf +++ b/OvmfPkg/OvmfPkgX64.fdf @@ -342,6 +342,7 @@ INF MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf +INF MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf INF OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf -- 2.39.3 (Apple Git-145) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117459): https://edk2.groups.io/g/devel/message/117459 Mute This Topic: https://groups.io/mt/105348119/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
