Re: [edk2-devel][PATCH V1 1/1] UefiCpuPkg/SecCore: Add debug messages to illuminate data flow

2022-07-07 Thread Dong, Eric 
Reviewed-by: Eric Dong 

-Original Message-
From: Oram, Isaac W  
Sent: Tuesday, June 28, 2022 6:49 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Dong, Eric ; 
Ni, Ray ; Kumar, Rahul1 ; De, 
Debkumar ; Han, Harry ; West, 
Catharine 
Subject: [edk2-devel][PATCH V1 1/1] UefiCpuPkg/SecCore: Add debug messages to 
illuminate data flow

Add debug messages to make it easier to verify PlatformSecLib is passing the 
data properly.

Cc: Eric Dong 
Cc: Ray Ni 
Cc: Rahul Kumar 
Cc: Debkumar De 
Cc: Harry Han 
Cc: Catharine West 
Signed-off-by: Isaac Oram 
---
 UefiCpuPkg/SecCore/SecMain.c | 37 
 1 file changed, 37 insertions(+)

diff --git a/UefiCpuPkg/SecCore/SecMain.c b/UefiCpuPkg/SecCore/SecMain.c index 
a7526be9dd..4edf0ce972 100644
--- a/UefiCpuPkg/SecCore/SecMain.c
+++ b/UefiCpuPkg/SecCore/SecMain.c
@@ -167,6 +167,15 @@ SecStartup (
 EFI_SOFTWARE_SEC | EFI_SW_SEC_PC_ENTRY_POINT
 );
 
+  DEBUG ((
+DEBUG_INFO,
+"%a() TempRAM Base: 0x%x, TempRAM Size: 0x%x, BootFirmwareVolume 0x%x\n",
+__FUNCTION__,
+TempRamBase,
+SizeOfRam,
+BootFirmwareVolume
+));
+
   PeiStackSize = PcdGet32 (PcdPeiTemporaryRamStackSize);
   if (PeiStackSize == 0) {
 PeiStackSize = (SizeOfRam >> 1);
@@ -229,6 +238,20 @@ SecStartup (
   SecCoreData.StackBase  = (VOID *)(UINTN)(TempRamBase + 
SecCoreData.PeiTemporaryRamSize);
   SecCoreData.StackSize  = PeiStackSize;
 
+  DEBUG ((
+DEBUG_INFO,
+"%a() BFV Base: 0x%x, BFV Size: 0x%x, TempRAM Base: 0x%x, TempRAM Size: 
0x%x, PeiTempRamBase: 0x%x, PeiTempRamSize: 0x%x, StackBase: 0x%x, StackSize: 
0x%x\n",
+__FUNCTION__,
+SecCoreData.BootFirmwareVolumeBase,
+SecCoreData.BootFirmwareVolumeSize,
+SecCoreData.TemporaryRamBase,
+SecCoreData.TemporaryRamSize,
+SecCoreData.PeiTemporaryRamBase,
+SecCoreData.PeiTemporaryRamSize,
+SecCoreData.StackBase,
+SecCoreData.StackSize
+));
+
   //
   // Initialize Debug Agent to support source level debug in SEC/PEI phases 
before memory ready.
   //
@@ -318,6 +341,13 @@ SecStartupPhase2 (
 }
   }
 
+  DEBUG ((
+DEBUG_INFO,
+"%a() PeiCoreEntryPoint: 0x%x\n",
+__FUNCTION__,
+PeiCoreEntryPoint
+));
+
   if (PpiList != NULL) {
 AllSecPpiList = (EFI_PEI_PPI_DESCRIPTOR *)SecCoreData->PeiTemporaryRamBase;
 
@@ -360,6 +390,13 @@ SecStartupPhase2 (
 //
 SecCoreData->PeiTemporaryRamBase  = (VOID 
*)(((UINTN)SecCoreData->PeiTemporaryRamBase + 7) & ~0x07);
 SecCoreData->PeiTemporaryRamSize &= ~(UINTN)0x07;
+DEBUG ((
+  DEBUG_INFO,
+  "%a() PeiTemporaryRamBase: 0x%x, PeiTemporaryRamSize: 0x%x\n",
+  __FUNCTION__,
+  SecCoreData->PeiTemporaryRamBase,
+  SecCoreData->PeiTemporaryRamSize
+  ));
   } else {
 //
 // No addition PPI, PpiList directly point to the common PPI list.
--
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91169): https://edk2.groups.io/g/devel/message/91169
Mute This Topic: https://groups.io/mt/92033232/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel][PATCH V1 1/1] UefiCpuPkg/SecCore: Add debug messages to illuminate data flow

2022-06-27 Thread Oram, Isaac W 
Add debug messages to make it easier to verify PlatformSecLib
is passing the data properly.

Cc: Eric Dong 
Cc: Ray Ni 
Cc: Rahul Kumar 
Cc: Debkumar De 
Cc: Harry Han 
Cc: Catharine West 
Signed-off-by: Isaac Oram 
---
 UefiCpuPkg/SecCore/SecMain.c | 37 
 1 file changed, 37 insertions(+)

diff --git a/UefiCpuPkg/SecCore/SecMain.c b/UefiCpuPkg/SecCore/SecMain.c
index a7526be9dd..4edf0ce972 100644
--- a/UefiCpuPkg/SecCore/SecMain.c
+++ b/UefiCpuPkg/SecCore/SecMain.c
@@ -167,6 +167,15 @@ SecStartup (
 EFI_SOFTWARE_SEC | EFI_SW_SEC_PC_ENTRY_POINT
 );
 
+  DEBUG ((
+DEBUG_INFO,
+"%a() TempRAM Base: 0x%x, TempRAM Size: 0x%x, BootFirmwareVolume 0x%x\n",
+__FUNCTION__,
+TempRamBase,
+SizeOfRam,
+BootFirmwareVolume
+));
+
   PeiStackSize = PcdGet32 (PcdPeiTemporaryRamStackSize);
   if (PeiStackSize == 0) {
 PeiStackSize = (SizeOfRam >> 1);
@@ -229,6 +238,20 @@ SecStartup (
   SecCoreData.StackBase  = (VOID *)(UINTN)(TempRamBase + 
SecCoreData.PeiTemporaryRamSize);
   SecCoreData.StackSize  = PeiStackSize;
 
+  DEBUG ((
+DEBUG_INFO,
+"%a() BFV Base: 0x%x, BFV Size: 0x%x, TempRAM Base: 0x%x, TempRAM Size: 
0x%x, PeiTempRamBase: 0x%x, PeiTempRamSize: 0x%x, StackBase: 0x%x, StackSize: 
0x%x\n",
+__FUNCTION__,
+SecCoreData.BootFirmwareVolumeBase,
+SecCoreData.BootFirmwareVolumeSize,
+SecCoreData.TemporaryRamBase,
+SecCoreData.TemporaryRamSize,
+SecCoreData.PeiTemporaryRamBase,
+SecCoreData.PeiTemporaryRamSize,
+SecCoreData.StackBase,
+SecCoreData.StackSize
+));
+
   //
   // Initialize Debug Agent to support source level debug in SEC/PEI phases 
before memory ready.
   //
@@ -318,6 +341,13 @@ SecStartupPhase2 (
 }
   }
 
+  DEBUG ((
+DEBUG_INFO,
+"%a() PeiCoreEntryPoint: 0x%x\n",
+__FUNCTION__,
+PeiCoreEntryPoint
+));
+
   if (PpiList != NULL) {
 AllSecPpiList = (EFI_PEI_PPI_DESCRIPTOR *)SecCoreData->PeiTemporaryRamBase;
 
@@ -360,6 +390,13 @@ SecStartupPhase2 (
 //
 SecCoreData->PeiTemporaryRamBase  = (VOID 
*)(((UINTN)SecCoreData->PeiTemporaryRamBase + 7) & ~0x07);
 SecCoreData->PeiTemporaryRamSize &= ~(UINTN)0x07;
+DEBUG ((
+  DEBUG_INFO,
+  "%a() PeiTemporaryRamBase: 0x%x, PeiTemporaryRamSize: 0x%x\n",
+  __FUNCTION__,
+  SecCoreData->PeiTemporaryRamBase,
+  SecCoreData->PeiTemporaryRamSize
+  ));
   } else {
 //
 // No addition PPI, PpiList directly point to the common PPI list.
-- 
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90793): https://edk2.groups.io/g/devel/message/90793
Mute This Topic: https://groups.io/mt/92033232/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-