Re: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues
On Thu, 14 Mar 2024 at 15:52, gaoliming via groups.io wrote: > > For this patch set, I have no comments. Reviewed-by: Liming Gao > > Merged as #5471 > > -邮件原件- > > 发件人: Oliver Smith-Denny > > 发送时间: 2024年3月10日 3:06 > > 收件人: devel@edk2.groups.io > > 抄送: Leif Lindholm ; Ard Biesheuvel > > ; Sami Mujawar ; > > Liming Gao > > 主题: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues > > > > This patch series is the third version of > > MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations. > > The subject line has been updated because this went from a one commit > > patch with no cover letter to a multi-commit patch. > > > > The commit messages cover the vast amount of detail here, but this > > patchset fixes three issues: > > - a UEFI spec violation for which memory types require runtime page > > allocation granularity alignment > > - An incompatibility of the heap guard system to guard these regions > > that require runtime page allocation granularities greater than > > the EFI_PAGE_SIZE. > > - A CodeQL error that fails CI when updating the Page.c code > > > > v3: > > - edit comments for readability > > > > v2: > > - Add commit to fix UEFI spec violation > > - Add commit to fix newly flagged CodeQL error > > - Update guard commit message, comments, and static assert to use > > the correct types > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Sami Mujawar > > Cc: Liming Gao > > > > Oliver Smith-Denny (3): > > MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages > > MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type > > MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types > > > > MdeModulePkg/MdeModulePkg.dec | 10 + > > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 14 > > + > > MdeModulePkg/Core/Dxe/Mem/Page.c | 22 > > +--- > > MdeModulePkg/Core/Dxe/Mem/Pool.c | 15 > > +++-- > > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++-- > > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +- > > 6 files changed, 59 insertions(+), 8 deletions(-) > > > > -- > > 2.40.1 > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116772): https://edk2.groups.io/g/devel/message/116772 Mute This Topic: https://groups.io/mt/104930045/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues
For this patch set, I have no comments. Reviewed-by: Liming Gao > -邮件原件- > 发件人: Oliver Smith-Denny > 发送时间: 2024年3月10日 3:06 > 收件人: devel@edk2.groups.io > 抄送: Leif Lindholm ; Ard Biesheuvel > ; Sami Mujawar ; > Liming Gao > 主题: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues > > This patch series is the third version of > MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations. > The subject line has been updated because this went from a one commit > patch with no cover letter to a multi-commit patch. > > The commit messages cover the vast amount of detail here, but this > patchset fixes three issues: > - a UEFI spec violation for which memory types require runtime page > allocation granularity alignment > - An incompatibility of the heap guard system to guard these regions > that require runtime page allocation granularities greater than > the EFI_PAGE_SIZE. > - A CodeQL error that fails CI when updating the Page.c code > > v3: > - edit comments for readability > > v2: > - Add commit to fix UEFI spec violation > - Add commit to fix newly flagged CodeQL error > - Update guard commit message, comments, and static assert to use > the correct types > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Liming Gao > > Oliver Smith-Denny (3): > MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages > MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type > MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types > > MdeModulePkg/MdeModulePkg.dec | 10 + > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 14 > + > MdeModulePkg/Core/Dxe/Mem/Page.c | 22 > +--- > MdeModulePkg/Core/Dxe/Mem/Pool.c | 15 > +++-- > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++-- > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +- > 6 files changed, 59 insertions(+), 8 deletions(-) > > -- > 2.40.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116762): https://edk2.groups.io/g/devel/message/116762 Mute This Topic: https://groups.io/mt/104927832/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues
Hi Ray and Mike, Can you help get this patchset reviewed and merged? It contains a fix for a UEFI spec violation and it has been sitting on the mailing list for a month. Unfortunately Liming has not reviewed after weekly friendly pings and he is the only main level MdeModulePkg maintainer. Liming, perhaps you could use a co-maintainer from the community to help balance the load? I totally understand that being a maintainer is a large burden, but I also have several patchsets up that need reviews and merging for over a month. Thanks, Oliver On 3/9/2024 11:06 AM, Oliver Smith-Denny wrote: This patch series is the third version of MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations. The subject line has been updated because this went from a one commit patch with no cover letter to a multi-commit patch. The commit messages cover the vast amount of detail here, but this patchset fixes three issues: - a UEFI spec violation for which memory types require runtime page allocation granularity alignment - An incompatibility of the heap guard system to guard these regions that require runtime page allocation granularities greater than the EFI_PAGE_SIZE. - A CodeQL error that fails CI when updating the Page.c code v3: - edit comments for readability v2: - Add commit to fix UEFI spec violation - Add commit to fix newly flagged CodeQL error - Update guard commit message, comments, and static assert to use the correct types Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Liming Gao Oliver Smith-Denny (3): MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types MdeModulePkg/MdeModulePkg.dec | 10 + MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 14 + MdeModulePkg/Core/Dxe/Mem/Page.c | 22 +--- MdeModulePkg/Core/Dxe/Mem/Pool.c | 15 +++-- MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++-- MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +- 6 files changed, 59 insertions(+), 8 deletions(-) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116719): https://edk2.groups.io/g/devel/message/116719 Mute This Topic: https://groups.io/mt/104832605/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues
This patch series is the third version of MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations. The subject line has been updated because this went from a one commit patch with no cover letter to a multi-commit patch. The commit messages cover the vast amount of detail here, but this patchset fixes three issues: - a UEFI spec violation for which memory types require runtime page allocation granularity alignment - An incompatibility of the heap guard system to guard these regions that require runtime page allocation granularities greater than the EFI_PAGE_SIZE. - A CodeQL error that fails CI when updating the Page.c code v3: - edit comments for readability v2: - Add commit to fix UEFI spec violation - Add commit to fix newly flagged CodeQL error - Update guard commit message, comments, and static assert to use the correct types Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Liming Gao Oliver Smith-Denny (3): MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types MdeModulePkg/MdeModulePkg.dec | 10 + MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 14 + MdeModulePkg/Core/Dxe/Mem/Page.c | 22 +--- MdeModulePkg/Core/Dxe/Mem/Pool.c | 15 +++-- MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++-- MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +- 6 files changed, 59 insertions(+), 8 deletions(-) -- 2.40.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116559): https://edk2.groups.io/g/devel/message/116559 Mute This Topic: https://groups.io/mt/104832605/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
