Re: [edk2-devel] [[edk2-platforms][PATCH V2] 07/30] Platform/Hisilicon: Replace BSD License with BSD+Patent License

2019-05-20 Thread Ming Huang



On 5/17/2019 6:59 PM, Leif Lindholm wrote:
> On Wed, May 15, 2019 at 04:09:48PM -0700, Michael D Kinney wrote:
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1373
>>
>> Replace BSD 2-Clause License with BSD+Patent License.  This change is
>> based on the following emails:
>>
>>   https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
>>   https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
>>
>> RFCs with detailed process for the license change:
>>
>>   V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
>>   V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
>>   V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html
> 
> As far as I can tell, this excludes 4 (iasl generated) .asl files
> currently not displaying any explicit license at all.
> 
> This is correct, and as discussed offline, but it would be worth
> pointing it out explicitly in the commit message.
> 
> Ming, Heyi - can you confirm that:
> 
> Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/D03Iort.asl
> Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Iort.asl
> Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl
> Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620IortNoSmmu.asl
> 
> were intended to be contributed with a 2-clause BSD license and under
> TianoCore Contribution Agreement 1.1?

Yes.

Thanks

> 
> Other than that, looks good to me.
> 
> /
> Leif
> 
>> Cc: Leif Lindholm 
>> Cc: Ard Biesheuvel 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Michael D Kinney 
>> ---
>>  .../SystemFirmwareUpdateConfig.ini|   8 +---
>>  Platform/Hisilicon/D03/D03.dec|   8 +---
>>  Platform/Hisilicon/D03/D03.dsc|   8 +---
>>  Platform/Hisilicon/D03/D03.fdf|   8 +---
>>  .../OemNicConfig2PHi1610/OemNicConfig.h   |   8 +---
>>  .../OemNicConfig2PHi1610/OemNicConfig2P.c |   8 +---
>>  .../OemNicConfig2PHi1610/OemNicConfig2P.inf   |   8 +---
>>  .../SystemFirmwareDescriptor.aslc |   8 +---
>>  .../SystemFirmwareDescriptor.inf  |   8 +---
>>  .../SystemFirmwareDescriptorPei.c |   8 +---
>>  .../D03/EarlyConfigPeim/EarlyConfigPeimD03.c  |   8 +---
>>  .../EarlyConfigPeim/EarlyConfigPeimD03.inf|   8 +---
>>  .../Hisilicon/D03/Include/Library/CpldD03.h   |   8 +---
>>  .../DS3231RealTimeClock.h |   8 +---
>>  .../DS3231RealTimeClockLib.c  |   8 +---
>>  .../DS3231RealTimeClockLib.inf|   7 +--
>>  .../D03/Library/FdtUpdateLib/FdtUpdateLib.c   |   8 +---
>>  .../D03/Library/FdtUpdateLib/FdtUpdateLib.inf |   8 +---
>>  .../OemMiscLib2P/BoardFeature2PHi1610.c   |   8 +---
>>  .../BoardFeature2PHi1610Strings.uni   | Bin 4292 -> 3538 bytes
>>  .../Library/OemMiscLib2P/OemMiscLib2PHi1610.c |   8 +---
>>  .../OemMiscLib2P/OemMiscLib2PHi1610.inf   |   8 +---
>>  .../Library/PlatformPciLib/PlatformPciLib.c   |   8 +---
>>  .../Library/PlatformPciLib/PlatformPciLib.inf |   7 +--
>>  .../SystemFirmwareUpdateConfig.ini|   8 +---
>>  Platform/Hisilicon/D05/D05.dsc|   8 +---
>>  Platform/Hisilicon/D05/D05.fdf|   8 +---
>>  .../SystemFirmwareDescriptor.aslc |   8 +---
>>  .../SystemFirmwareDescriptor.inf  |   8 +---
>>  .../SystemFirmwareDescriptorPei.c |   8 +---
>>  .../D05/EarlyConfigPeim/EarlyConfigPeimD05.c  |   8 +---
>>  .../EarlyConfigPeim/EarlyConfigPeimD05.inf|   8 +---
>>  .../Library/OemMiscLibD05/BoardFeatureD05.c   |   8 +---
>>  .../OemMiscLibD05/BoardFeatureD05Strings.uni  |   8 +---
>>  .../D05/Library/OemMiscLibD05/OemMiscLibD05.c |   8 +---
>>  .../Library/OemMiscLibD05/OemMiscLibD05.inf   |   8 +---
>>  .../Library/PlatformPciLib/PlatformPciLib.c   |   8 +---
>>  .../Library/PlatformPciLib/PlatformPciLib.inf |   7 +--
>>  .../SystemFirmwareUpdateConfig.ini|   8 +---
>>  Platform/Hisilicon/D06/D06.dec|   8 +---
>>  Platform/Hisilicon/D06/D06.dsc|   8 +---
>>  Platform/Hisilicon/D06/D06.fdf|   8 +---
>>  .../OemNicConfig2PHi1620/OemNicConfig.h   |   8 +---
>>  .../OemNicConfig2PHi1620/OemNicConfig2P.c |   8 +---
>>  .../OemNicConfig2PHi1620/OemNicConfig2P.inf   |   8 +---
>>  .../SystemFirmwareDescriptor.aslc |   8 +---
>>  .../SystemFirmwareDescriptor.inf  |   8 +---
>>  .../SystemFirmwareDescriptorPei.c |   8 +---
>>  .../D06/EarlyConfigPeim/EarlyConfigPeimD06.c  |   8 +---
>>  .../EarlyConfigPeim/EarlyConfigPeimD06.inf|   8 +---
>>  .../Hisilicon/D06/Include/Library/CpldD06.h   |   8 +---
>>  .../Library/OemMiscLibD06/BoardFeatureD06.c   |   8 +---
>>  

Re: [edk2-devel] [[edk2-platforms][PATCH V2] 07/30] Platform/Hisilicon: Replace BSD License with BSD+Patent License

2019-05-17 Thread Leif Lindholm
On Wed, May 15, 2019 at 04:09:48PM -0700, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> 
> Replace BSD 2-Clause License with BSD+Patent License.  This change is
> based on the following emails:
> 
>   https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
>   https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
> 
> RFCs with detailed process for the license change:
> 
>   V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
>   V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
>   V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html

As far as I can tell, this excludes 4 (iasl generated) .asl files
currently not displaying any explicit license at all.

This is correct, and as discussed offline, but it would be worth
pointing it out explicitly in the commit message.

Ming, Heyi - can you confirm that:

Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/D03Iort.asl
Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Iort.asl
Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl
Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620IortNoSmmu.asl

were intended to be contributed with a 2-clause BSD license and under
TianoCore Contribution Agreement 1.1?

Other than that, looks good to me.

/
Leif

> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney 
> ---
>  .../SystemFirmwareUpdateConfig.ini|   8 +---
>  Platform/Hisilicon/D03/D03.dec|   8 +---
>  Platform/Hisilicon/D03/D03.dsc|   8 +---
>  Platform/Hisilicon/D03/D03.fdf|   8 +---
>  .../OemNicConfig2PHi1610/OemNicConfig.h   |   8 +---
>  .../OemNicConfig2PHi1610/OemNicConfig2P.c |   8 +---
>  .../OemNicConfig2PHi1610/OemNicConfig2P.inf   |   8 +---
>  .../SystemFirmwareDescriptor.aslc |   8 +---
>  .../SystemFirmwareDescriptor.inf  |   8 +---
>  .../SystemFirmwareDescriptorPei.c |   8 +---
>  .../D03/EarlyConfigPeim/EarlyConfigPeimD03.c  |   8 +---
>  .../EarlyConfigPeim/EarlyConfigPeimD03.inf|   8 +---
>  .../Hisilicon/D03/Include/Library/CpldD03.h   |   8 +---
>  .../DS3231RealTimeClock.h |   8 +---
>  .../DS3231RealTimeClockLib.c  |   8 +---
>  .../DS3231RealTimeClockLib.inf|   7 +--
>  .../D03/Library/FdtUpdateLib/FdtUpdateLib.c   |   8 +---
>  .../D03/Library/FdtUpdateLib/FdtUpdateLib.inf |   8 +---
>  .../OemMiscLib2P/BoardFeature2PHi1610.c   |   8 +---
>  .../BoardFeature2PHi1610Strings.uni   | Bin 4292 -> 3538 bytes
>  .../Library/OemMiscLib2P/OemMiscLib2PHi1610.c |   8 +---
>  .../OemMiscLib2P/OemMiscLib2PHi1610.inf   |   8 +---
>  .../Library/PlatformPciLib/PlatformPciLib.c   |   8 +---
>  .../Library/PlatformPciLib/PlatformPciLib.inf |   7 +--
>  .../SystemFirmwareUpdateConfig.ini|   8 +---
>  Platform/Hisilicon/D05/D05.dsc|   8 +---
>  Platform/Hisilicon/D05/D05.fdf|   8 +---
>  .../SystemFirmwareDescriptor.aslc |   8 +---
>  .../SystemFirmwareDescriptor.inf  |   8 +---
>  .../SystemFirmwareDescriptorPei.c |   8 +---
>  .../D05/EarlyConfigPeim/EarlyConfigPeimD05.c  |   8 +---
>  .../EarlyConfigPeim/EarlyConfigPeimD05.inf|   8 +---
>  .../Library/OemMiscLibD05/BoardFeatureD05.c   |   8 +---
>  .../OemMiscLibD05/BoardFeatureD05Strings.uni  |   8 +---
>  .../D05/Library/OemMiscLibD05/OemMiscLibD05.c |   8 +---
>  .../Library/OemMiscLibD05/OemMiscLibD05.inf   |   8 +---
>  .../Library/PlatformPciLib/PlatformPciLib.c   |   8 +---
>  .../Library/PlatformPciLib/PlatformPciLib.inf |   7 +--
>  .../SystemFirmwareUpdateConfig.ini|   8 +---
>  Platform/Hisilicon/D06/D06.dec|   8 +---
>  Platform/Hisilicon/D06/D06.dsc|   8 +---
>  Platform/Hisilicon/D06/D06.fdf|   8 +---
>  .../OemNicConfig2PHi1620/OemNicConfig.h   |   8 +---
>  .../OemNicConfig2PHi1620/OemNicConfig2P.c |   8 +---
>  .../OemNicConfig2PHi1620/OemNicConfig2P.inf   |   8 +---
>  .../SystemFirmwareDescriptor.aslc |   8 +---
>  .../SystemFirmwareDescriptor.inf  |   8 +---
>  .../SystemFirmwareDescriptorPei.c |   8 +---
>  .../D06/EarlyConfigPeim/EarlyConfigPeimD06.c  |   8 +---
>  .../EarlyConfigPeim/EarlyConfigPeimD06.inf|   8 +---
>  .../Hisilicon/D06/Include/Library/CpldD06.h   |   8 +---
>  .../Library/OemMiscLibD06/BoardFeatureD06.c   |   8 +---
>  .../OemMiscLibD06/BoardFeatureD06Strings.uni  |   8 +---
>  .../D06/Library/OemMiscLibD06/OemMiscLibD06.c |   8 +---
>  .../Library/OemMiscLibD06/OemMiscLibD06.inf   |   8 +---
>  

[edk2-devel] [[edk2-platforms][PATCH V2] 07/30] Platform/Hisilicon: Replace BSD License with BSD+Patent License

2019-05-15 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1373

Replace BSD 2-Clause License with BSD+Patent License.  This change is
based on the following emails:

  https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
  https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html

RFCs with detailed process for the license change:

  V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
  V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
  V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html

Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney 
---
 .../SystemFirmwareUpdateConfig.ini|   8 +---
 Platform/Hisilicon/D03/D03.dec|   8 +---
 Platform/Hisilicon/D03/D03.dsc|   8 +---
 Platform/Hisilicon/D03/D03.fdf|   8 +---
 .../OemNicConfig2PHi1610/OemNicConfig.h   |   8 +---
 .../OemNicConfig2PHi1610/OemNicConfig2P.c |   8 +---
 .../OemNicConfig2PHi1610/OemNicConfig2P.inf   |   8 +---
 .../SystemFirmwareDescriptor.aslc |   8 +---
 .../SystemFirmwareDescriptor.inf  |   8 +---
 .../SystemFirmwareDescriptorPei.c |   8 +---
 .../D03/EarlyConfigPeim/EarlyConfigPeimD03.c  |   8 +---
 .../EarlyConfigPeim/EarlyConfigPeimD03.inf|   8 +---
 .../Hisilicon/D03/Include/Library/CpldD03.h   |   8 +---
 .../DS3231RealTimeClock.h |   8 +---
 .../DS3231RealTimeClockLib.c  |   8 +---
 .../DS3231RealTimeClockLib.inf|   7 +--
 .../D03/Library/FdtUpdateLib/FdtUpdateLib.c   |   8 +---
 .../D03/Library/FdtUpdateLib/FdtUpdateLib.inf |   8 +---
 .../OemMiscLib2P/BoardFeature2PHi1610.c   |   8 +---
 .../BoardFeature2PHi1610Strings.uni   | Bin 4292 -> 3538 bytes
 .../Library/OemMiscLib2P/OemMiscLib2PHi1610.c |   8 +---
 .../OemMiscLib2P/OemMiscLib2PHi1610.inf   |   8 +---
 .../Library/PlatformPciLib/PlatformPciLib.c   |   8 +---
 .../Library/PlatformPciLib/PlatformPciLib.inf |   7 +--
 .../SystemFirmwareUpdateConfig.ini|   8 +---
 Platform/Hisilicon/D05/D05.dsc|   8 +---
 Platform/Hisilicon/D05/D05.fdf|   8 +---
 .../SystemFirmwareDescriptor.aslc |   8 +---
 .../SystemFirmwareDescriptor.inf  |   8 +---
 .../SystemFirmwareDescriptorPei.c |   8 +---
 .../D05/EarlyConfigPeim/EarlyConfigPeimD05.c  |   8 +---
 .../EarlyConfigPeim/EarlyConfigPeimD05.inf|   8 +---
 .../Library/OemMiscLibD05/BoardFeatureD05.c   |   8 +---
 .../OemMiscLibD05/BoardFeatureD05Strings.uni  |   8 +---
 .../D05/Library/OemMiscLibD05/OemMiscLibD05.c |   8 +---
 .../Library/OemMiscLibD05/OemMiscLibD05.inf   |   8 +---
 .../Library/PlatformPciLib/PlatformPciLib.c   |   8 +---
 .../Library/PlatformPciLib/PlatformPciLib.inf |   7 +--
 .../SystemFirmwareUpdateConfig.ini|   8 +---
 Platform/Hisilicon/D06/D06.dec|   8 +---
 Platform/Hisilicon/D06/D06.dsc|   8 +---
 Platform/Hisilicon/D06/D06.fdf|   8 +---
 .../OemNicConfig2PHi1620/OemNicConfig.h   |   8 +---
 .../OemNicConfig2PHi1620/OemNicConfig2P.c |   8 +---
 .../OemNicConfig2PHi1620/OemNicConfig2P.inf   |   8 +---
 .../SystemFirmwareDescriptor.aslc |   8 +---
 .../SystemFirmwareDescriptor.inf  |   8 +---
 .../SystemFirmwareDescriptorPei.c |   8 +---
 .../D06/EarlyConfigPeim/EarlyConfigPeimD06.c  |   8 +---
 .../EarlyConfigPeim/EarlyConfigPeimD06.inf|   8 +---
 .../Hisilicon/D06/Include/Library/CpldD06.h   |   8 +---
 .../Library/OemMiscLibD06/BoardFeatureD06.c   |   8 +---
 .../OemMiscLibD06/BoardFeatureD06Strings.uni  |   8 +---
 .../D06/Library/OemMiscLibD06/OemMiscLibD06.c |   8 +---
 .../Library/OemMiscLibD06/OemMiscLibD06.inf   |   8 +---
 .../D06/Library/OemNicLib/OemNicLib.c |   8 +---
 .../D06/Library/OemNicLib/OemNicLib.inf   |   8 +---
 .../PciHostBridgeLib/PciHostBridgeLib.c   |   8 +---
 .../PciHostBridgeLib/PciHostBridgeLib.inf |   7 +--
 Platform/Hisilicon/HiKey/HiKey.dec|   8 +---
 Platform/Hisilicon/HiKey/HiKey.dsc|   8 +---
 Platform/Hisilicon/HiKey/HiKey.fdf|   8 +---
 Platform/Hisilicon/HiKey/HiKeyDxe/HiKeyDxe.c  |   8 +---
 Platform/Hisilicon/HiKey/HiKeyDxe/HiKeyDxe.h  |   8 +---
 .../Hisilicon/HiKey/HiKeyDxe/HiKeyDxe.inf |   8 +---
 .../HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c |   8 +---
 .../HiKey/HiKeyGpioDxe/HiKeyGpioDxe.inf   |   8 +---
 .../Hisilicon/HiKey/Include/ArmPlatform.h |   8 +---
 .../Hisilicon/HiKey/Library/HiKeyLib/HiKey.c  |   8 +---