Re: [edk2-devel] [PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg

2019-07-10 Thread Laszlo Ersek 
On 07/10/19 10:05, Ray Ni wrote:
> Signed-off-by: Ray Ni 
> Cc: Andrew Fish 
> Cc: Laszlo Ersek 
> Cc: Leif Lindholm 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> ---
>  Maintainers.txt | 12 
>  1 file changed, 12 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 788b46202c..eb41dba7b1 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -130,18 +130,6 @@ M: Chasel Chiu 
>  R: Nate DeSimone 
>  R: Star Zeng 
>  
> -IntelFspPkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg
> -M: Chasel Chiu 
> -R: Nate DeSimone 
> -R: Star Zeng 
> -
> -IntelFspWrapperPkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspWrapperPkg
> -M: Chasel Chiu 
> -R: Nate DeSimone 
> -R: Star Zeng 
> -
>  MdeModulePkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
>  M: Jian J Wang 
> 

The patch itself looks OK to me, but I dislike empty commit message
bodies. Please say at least something like the following:

"We removed IntelFspPkg and IntelFspWrapperPkg for
; now remove the
dangling maintainer/reviewer assignments too".

With that update (no need to repost):

Reviewed-by: Laszlo Ersek 

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43484): https://edk2.groups.io/g/devel/message/43484
Mute This Topic: https://groups.io/mt/32414115/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg

2019-07-10 Thread Chiu, Chasel 


Reviewed-by: Chasel Chiu 

> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Wednesday, July 10, 2019 4:05 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Laszlo Ersek ; Leif
> Lindholm ; Kinney, Michael D
> ; Gao, Liming 
> Subject: [edk2-devel] [PATCH] Maintainers.txt: Remove maintainer info for
> IntelFsp[Wrapper]Pkg
> 
> Signed-off-by: Ray Ni 
> Cc: Andrew Fish 
> Cc: Laszlo Ersek 
> Cc: Leif Lindholm 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> ---
>  Maintainers.txt | 12 
>  1 file changed, 12 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt index 788b46202c..eb41dba7b1
> 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -130,18 +130,6 @@ M: Chasel Chiu 
>  R: Nate DeSimone 
>  R: Star Zeng 
> 
> -IntelFspPkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg
> -M: Chasel Chiu 
> -R: Nate DeSimone 
> -R: Star Zeng 
> -
> -IntelFspWrapperPkg
> -W:
> https://github.com/tianocore/tianocore.github.io/wiki/IntelFspWrapperPkg
> -M: Chasel Chiu 
> -R: Nate DeSimone 
> -R: Star Zeng 
> -
>  MdeModulePkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
>  M: Jian J Wang 
> --
> 2.21.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43477): https://edk2.groups.io/g/devel/message/43477
Mute This Topic: https://groups.io/mt/32414115/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg

2019-07-10 Thread Ni, Ray 
Signed-off-by: Ray Ni 
Cc: Andrew Fish 
Cc: Laszlo Ersek 
Cc: Leif Lindholm 
Cc: Michael D Kinney 
Cc: Liming Gao 
---
 Maintainers.txt | 12 
 1 file changed, 12 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 788b46202c..eb41dba7b1 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -130,18 +130,6 @@ M: Chasel Chiu 
 R: Nate DeSimone 
 R: Star Zeng 
 
-IntelFspPkg
-W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg
-M: Chasel Chiu 
-R: Nate DeSimone 
-R: Star Zeng 
-
-IntelFspWrapperPkg
-W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspWrapperPkg
-M: Chasel Chiu 
-R: Nate DeSimone 
-R: Star Zeng 
-
 MdeModulePkg
 W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
 M: Jian J Wang 
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43464): https://edk2.groups.io/g/devel/message/43464
Mute This Topic: https://groups.io/mt/32414115/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-