Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, June 18, 2019 1:16 PM
> To: Wu, Hao A; devel@edk2.groups.io; ler...@redhat.com; Gao, Zhichao
> Cc: Bret Barkelew; Wang, Jian J; Ni, Ray; Zeng, Star; Sean Brogan; Michael
> Turner
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial
> change for PeiAllocatePool
>
>
> >-Original Message-
> >From: Wu, Hao A
> >Sent: Tuesday, June 18, 2019 1:15 PM
> >To: devel@edk2.groups.io; ler...@redhat.com; Gao, Zhichao
> >; Gao, Liming
> >Cc: Bret Barkelew ; Wang, Jian J
> >; Ni, Ray ; Zeng, Star
> >; Sean Brogan ;
> Michael
> >Turner
> >Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial
> >change for PeiAllocatePool
> >
> >> -Original Message-
> >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> >> Laszlo Ersek
> >> Sent: Wednesday, June 12, 2019 4:34 PM
> >> To: devel@edk2.groups.io; Gao, Zhichao
> >> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao,
> Liming;
> >> Sean Brogan; Michael Turner
> >> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial
> >> change for PeiAllocatePool
> >>
> >> Hi Zhichao,
> >>
> >> On 06/12/19 06:50, Gao, Zhichao wrote:
> >> > From: Bret Barkelew
> >> >
> >> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1901
> >> >
> >> > The original logic is ASSERT if fail to create HOB. But
> >> > that doesn't make sense for release version. So it is required
> >> > to set the Buffer to null to indicate the failure.
> >>
> >> this patch may or may not be worthwhile; that's for the PEI Core
> >> maintainers to evaluate.
> >
> >
> >Looks to me like a valid enhancement for error handling.
> >
> >Liming,
> >Do you have any comment on this one?
> >
> I agree the code change. With subject update, Reviewed-by: Liming Gao
>
Acked-by: Hao A Wu
Pushed via commit 8797683f96.
(With subject updated.)
Best Regards,
Hao Wu
>
>
> >Best Regards,
> >Hao Wu
> >
> >
> >>
> >> Either way, the subject line is completely useless. "Substantial change"
> >> means nothing at all. Please write a subject line that reflects what
> >> this patch *actually does*.
> >>
> >> For example:
> >>
> >> MdeModulePkg/PeiMain: PeiAllocatePool: output NULL if HOB creation
> fails
> >>
> >> (72 characters).
> >>
> >> Thanks
> >> Laszlo
> >>
> >> > Cc: Jian J Wang
> >> > Cc: Hao Wu
> >> > Cc: Ray Ni
> >> > Cc: Star Zeng
> >> > Cc: Liming Gao
> >> > Cc: Sean Brogan
> >> > Cc: Michael Turner
> >> > Cc: Bret Barkelew
> >> > Signed-off-by: Zhichao Gao
> >> > ---
> >> > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 7 ++-
> >> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> >> b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> >> > index 42f79ab076..37b0cfa3cf 100644
> >> > --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> >> > +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> >> > @@ -802,7 +802,12 @@ PeiAllocatePool (
> >> > (VOID **)
> >> > );
> >> >ASSERT_EFI_ERROR (Status);
> >> > - *Buffer = Hob+1;
> >> > +
> >> > + if (EFI_ERROR (Status)) {
> >> > +*Buffer = NULL;
> >> > + } else {
> >> > +*Buffer = Hob+1;
> >> > + }
> >> >
> >> >return Status;
> >> > }
> >> >
> >>
> >>
> >>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42728): https://edk2.groups.io/g/devel/message/42728
Mute This Topic: https://groups.io/mt/32038027/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool
>-Original Message-
>From: Wu, Hao A
>Sent: Tuesday, June 18, 2019 1:15 PM
>To: devel@edk2.groups.io; ler...@redhat.com; Gao, Zhichao
>; Gao, Liming
>Cc: Bret Barkelew ; Wang, Jian J
>; Ni, Ray ; Zeng, Star
>; Sean Brogan ; Michael
>Turner
>Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial
>change for PeiAllocatePool
>
>> -Original Message-
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Laszlo Ersek
>> Sent: Wednesday, June 12, 2019 4:34 PM
>> To: devel@edk2.groups.io; Gao, Zhichao
>> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming;
>> Sean Brogan; Michael Turner
>> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial
>> change for PeiAllocatePool
>>
>> Hi Zhichao,
>>
>> On 06/12/19 06:50, Gao, Zhichao wrote:
>> > From: Bret Barkelew
>> >
>> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1901
>> >
>> > The original logic is ASSERT if fail to create HOB. But
>> > that doesn't make sense for release version. So it is required
>> > to set the Buffer to null to indicate the failure.
>>
>> this patch may or may not be worthwhile; that's for the PEI Core
>> maintainers to evaluate.
>
>
>Looks to me like a valid enhancement for error handling.
>
>Liming,
>Do you have any comment on this one?
>
I agree the code change. With subject update, Reviewed-by: Liming Gao
>Best Regards,
>Hao Wu
>
>
>>
>> Either way, the subject line is completely useless. "Substantial change"
>> means nothing at all. Please write a subject line that reflects what
>> this patch *actually does*.
>>
>> For example:
>>
>> MdeModulePkg/PeiMain: PeiAllocatePool: output NULL if HOB creation fails
>>
>> (72 characters).
>>
>> Thanks
>> Laszlo
>>
>> > Cc: Jian J Wang
>> > Cc: Hao Wu
>> > Cc: Ray Ni
>> > Cc: Star Zeng
>> > Cc: Liming Gao
>> > Cc: Sean Brogan
>> > Cc: Michael Turner
>> > Cc: Bret Barkelew
>> > Signed-off-by: Zhichao Gao
>> > ---
>> > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 7 ++-
>> > 1 file changed, 6 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
>> b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
>> > index 42f79ab076..37b0cfa3cf 100644
>> > --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
>> > +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
>> > @@ -802,7 +802,12 @@ PeiAllocatePool (
>> > (VOID **)
>> > );
>> >ASSERT_EFI_ERROR (Status);
>> > - *Buffer = Hob+1;
>> > +
>> > + if (EFI_ERROR (Status)) {
>> > +*Buffer = NULL;
>> > + } else {
>> > +*Buffer = Hob+1;
>> > + }
>> >
>> >return Status;
>> > }
>> >
>>
>>
>>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42529): https://edk2.groups.io/g/devel/message/42529
Mute This Topic: https://groups.io/mt/32038027/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool
Thanks for the comments.
Your example makes the purpose clear. I would update the subject like that.
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 12, 2019 4:34 PM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Bret Barkelew ; Wang, Jian J
> ; Wu, Hao A ; Ni, Ray
> ; Zeng, Star ; Gao, Liming
> ; Sean Brogan ;
> Michael Turner
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial
> change for PeiAllocatePool
>
> Hi Zhichao,
>
> On 06/12/19 06:50, Gao, Zhichao wrote:
> > From: Bret Barkelew
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1901
> >
> > The original logic is ASSERT if fail to create HOB. But that doesn't
> > make sense for release version. So it is required to set the Buffer to
> > null to indicate the failure.
>
> this patch may or may not be worthwhile; that's for the PEI Core maintainers
> to evaluate.
>
> Either way, the subject line is completely useless. "Substantial change"
> means nothing at all. Please write a subject line that reflects what this
> patch
> *actually does*.
>
> For example:
>
> MdeModulePkg/PeiMain: PeiAllocatePool: output NULL if HOB creation fails
>
> (72 characters).
>
> Thanks
> Laszlo
>
> > Cc: Jian J Wang
> > Cc: Hao Wu
> > Cc: Ray Ni
> > Cc: Star Zeng
> > Cc: Liming Gao
> > Cc: Sean Brogan
> > Cc: Michael Turner
> > Cc: Bret Barkelew
> > Signed-off-by: Zhichao Gao
> > ---
> > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 7 ++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> > b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> > index 42f79ab076..37b0cfa3cf 100644
> > --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> > +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> > @@ -802,7 +802,12 @@ PeiAllocatePool (
> > (VOID **)
> > );
> >ASSERT_EFI_ERROR (Status);
> > - *Buffer = Hob+1;
> > +
> > + if (EFI_ERROR (Status)) {
> > +*Buffer = NULL;
> > + } else {
> > +*Buffer = Hob+1;
> > + }
> >
> >return Status;
> > }
> >
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42318): https://edk2.groups.io/g/devel/message/42318
Mute This Topic: https://groups.io/mt/32038027/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool
Hi Zhichao,
On 06/12/19 06:50, Gao, Zhichao wrote:
> From: Bret Barkelew
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1901
>
> The original logic is ASSERT if fail to create HOB. But
> that doesn't make sense for release version. So it is required
> to set the Buffer to null to indicate the failure.
this patch may or may not be worthwhile; that's for the PEI Core
maintainers to evaluate.
Either way, the subject line is completely useless. "Substantial change"
means nothing at all. Please write a subject line that reflects what
this patch *actually does*.
For example:
MdeModulePkg/PeiMain: PeiAllocatePool: output NULL if HOB creation fails
(72 characters).
Thanks
Laszlo
> Cc: Jian J Wang
> Cc: Hao Wu
> Cc: Ray Ni
> Cc: Star Zeng
> Cc: Liming Gao
> Cc: Sean Brogan
> Cc: Michael Turner
> Cc: Bret Barkelew
> Signed-off-by: Zhichao Gao
> ---
> MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> index 42f79ab076..37b0cfa3cf 100644
> --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> @@ -802,7 +802,12 @@ PeiAllocatePool (
> (VOID **)
> );
>ASSERT_EFI_ERROR (Status);
> - *Buffer = Hob+1;
> +
> + if (EFI_ERROR (Status)) {
> +*Buffer = NULL;
> + } else {
> +*Buffer = Hob+1;
> + }
>
>return Status;
> }
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42272): https://edk2.groups.io/g/devel/message/42272
Mute This Topic: https://groups.io/mt/32038027/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1901
The original logic is ASSERT if fail to create HOB. But
that doesn't make sense for release version. So it is required
to set the Buffer to null to indicate the failure.
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming Gao
Cc: Sean Brogan
Cc: Michael Turner
Cc: Bret Barkelew
Signed-off-by: Zhichao Gao
---
MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
index 42f79ab076..37b0cfa3cf 100644
--- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
+++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
@@ -802,7 +802,12 @@ PeiAllocatePool (
(VOID **)
);
ASSERT_EFI_ERROR (Status);
- *Buffer = Hob+1;
+
+ if (EFI_ERROR (Status)) {
+*Buffer = NULL;
+ } else {
+*Buffer = Hob+1;
+ }
return Status;
}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42253): https://edk2.groups.io/g/devel/message/42253
Mute This Topic: https://groups.io/mt/32038027/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
