回复: [edk2-devel] [PATCH] MdeModulePkg/UefiHiiLib: Fix typo

2022-09-20 Thread gaoliming via groups.io
Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Konstantin
> Aladyshev
> 发送时间: 2022年9月1日 23:54
> 收件人: devel@edk2.groups.io
> 抄送: dandan...@intel.com; eric.d...@intel.com; Konstantin Aladyshev
> 
> 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiHiiLib: Fix typo
> 
> Fix typo in the set default value action define name:
> DEFAUTL -> DEFAULT
> 
> Signed-off-by: Konstantin Aladyshev 
> ---
>  MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> index 63a37ab59a..5821bd5488 100644
> --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> @@ -12,7 +12,7 @@
>  #define NAME_CONFIG_STRING_TYPE  0x01
> 
>  #define PATH_CONFIG_STRING_TYPE  0x02
> 
> 
> 
> -#define ACTION_SET_DEFAUTL_VALUE  0x01
> 
> +#define ACTION_SET_DEFAULT_VALUE  0x01
> 
>  #define ACTION_VALIDATE_SETTING   0x02
> 
> 
> 
>  #define HII_LIB_DEFAULT_VARSTORE_SIZE  0x200
> 
> @@ -2350,7 +2350,7 @@ InternalHiiIfrValueAction (
>//
> 
>// Only support set default and validate setting action.
> 
>//
> 
> -  if ((ActionType != ACTION_SET_DEFAUTL_VALUE) && (ActionType !=
> ACTION_VALIDATE_SETTING)) {
> 
> +  if ((ActionType != ACTION_SET_DEFAULT_VALUE) && (ActionType !=
> ACTION_VALIDATE_SETTING)) {
> 
>  return FALSE;
> 
>}
> 
> 
> 
> @@ -2511,7 +2511,7 @@ InternalHiiIfrValueAction (
>VarGuid,
> 
>VarName,
> 
>DevicePath,
> 
> -  (ActionType ==
> ACTION_SET_DEFAUTL_VALUE) ?  : NULL,  // it can be NULL to
> get the current setting.
> 
> +  (ActionType ==
> ACTION_SET_DEFAULT_VALUE) ?  : NULL,  // it can be NULL to
> get the current setting.
> 
>
> 
>);
> 
> 
> 
> @@ -2534,7 +2534,7 @@ InternalHiiIfrValueAction (
>  // 4. Set the default configuration information or Validate current
> setting by parse IFR code.
> 
>  //Current Setting is in ConfigResp, will be set into buffer, then
> check it again.
> 
>  //
> 
> -if (ActionType == ACTION_SET_DEFAUTL_VALUE) {
> 
> +if (ActionType == ACTION_SET_DEFAULT_VALUE) {
> 
>//
> 
>// Set the default configuration information.
> 
>//
> 
> @@ -2716,7 +2716,7 @@ HiiSetToDefaults (
>IN UINT16DefaultId
> 
>)
> 
>  {
> 
> -  return InternalHiiIfrValueAction (Request, DefaultId,
> ACTION_SET_DEFAUTL_VALUE);
> 
> +  return InternalHiiIfrValueAction (Request, DefaultId,
> ACTION_SET_DEFAULT_VALUE);
> 
>  }
> 
> 
> 
>  /**
> 
> --
> 2.25.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#93056): https://edk2.groups.io/g/devel/message/93056
> Mute This Topic: https://groups.io/mt/93398909/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94020): https://edk2.groups.io/g/devel/message/94020
Mute This Topic: https://groups.io/mt/93817813/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH] MdeModulePkg/UefiHiiLib: Fix typo

2022-09-01 Thread Konstantin Aladyshev
Fix typo in the set default value action define name:
DEFAUTL -> DEFAULT

Signed-off-by: Konstantin Aladyshev 
---
 MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c 
b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
index 63a37ab59a..5821bd5488 100644
--- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
+++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
@@ -12,7 +12,7 @@
 #define NAME_CONFIG_STRING_TYPE  0x01
 #define PATH_CONFIG_STRING_TYPE  0x02
 
-#define ACTION_SET_DEFAUTL_VALUE  0x01
+#define ACTION_SET_DEFAULT_VALUE  0x01
 #define ACTION_VALIDATE_SETTING   0x02
 
 #define HII_LIB_DEFAULT_VARSTORE_SIZE  0x200
@@ -2350,7 +2350,7 @@ InternalHiiIfrValueAction (
   //
   // Only support set default and validate setting action.
   //
-  if ((ActionType != ACTION_SET_DEFAUTL_VALUE) && (ActionType != 
ACTION_VALIDATE_SETTING)) {
+  if ((ActionType != ACTION_SET_DEFAULT_VALUE) && (ActionType != 
ACTION_VALIDATE_SETTING)) {
 return FALSE;
   }
 
@@ -2511,7 +2511,7 @@ InternalHiiIfrValueAction (
   VarGuid,
   VarName,
   DevicePath,
-  (ActionType == ACTION_SET_DEFAUTL_VALUE) ? 
 : NULL,  // it can be NULL to get the current setting.
+  (ActionType == ACTION_SET_DEFAULT_VALUE) ? 
 : NULL,  // it can be NULL to get the current setting.
   
   );
 
@@ -2534,7 +2534,7 @@ InternalHiiIfrValueAction (
 // 4. Set the default configuration information or Validate current 
setting by parse IFR code.
 //Current Setting is in ConfigResp, will be set into buffer, then 
check it again.
 //
-if (ActionType == ACTION_SET_DEFAUTL_VALUE) {
+if (ActionType == ACTION_SET_DEFAULT_VALUE) {
   //
   // Set the default configuration information.
   //
@@ -2716,7 +2716,7 @@ HiiSetToDefaults (
   IN UINT16DefaultId
   )
 {
-  return InternalHiiIfrValueAction (Request, DefaultId, 
ACTION_SET_DEFAUTL_VALUE);
+  return InternalHiiIfrValueAction (Request, DefaultId, 
ACTION_SET_DEFAULT_VALUE);
 }
 
 /**
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93056): https://edk2.groups.io/g/devel/message/93056
Mute This Topic: https://groups.io/mt/93398909/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-