Re: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table
Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, September 8, 2022 2:11 PM
> To: devel@edk2.groups.io; Luo, Heng
> Cc: Wang, Jian J ; Gao, Liming
> ; Liu, Zhiguang ; Bi,
> Dandan ; Zeng, Star ; Gao,
> Zhichao
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe:
> Add Type4 CurrentSpeed to filter table
>
> Reviewed-by: Jiewen Yao
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Heng
> > Luo
> > Sent: Thursday, September 8, 2022 1:41 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J ; Gao, Liming
> > ; Liu, Zhiguang ;
> > Bi, Dandan ; Zeng, Star ;
> > Gao, Zhichao
> > Subject: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe:
> > Add Type4 CurrentSpeed to filter table
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4051
> >
> > The Type4 CurrentSpeed field may be various.
> > So this patch adds it into the filter table.
> >
> > Signed-off-by: Heng Luo
> > Cc: Jian J Wang
> > Cc: Liming Gao
> > Cc: Zhiguang Liu
> > Cc: Dandan Bi
> > Cc: Star Zeng
> > Cc: Zhichao Gao
> > ---
> >
> >
> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement
> > Dxe.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git
> >
> a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen
> > tDxe.c
> >
> b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme
> > ntDxe.c
> > index 348082ff86..d61edc846b 100644
> > ---
> >
> a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen
> > tDxe.c
> > +++
> >
> b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme
> > ntDxe.c
> > @@ -1,7 +1,7 @@
> > /** @file
> >This driver measures SMBIOS table to TPM.
> >
> > -Copyright (c) 2015 - 2019, Intel Corporation. All rights
> > reserved.
> > +Copyright (c) 2015 - 2022, Intel Corporation. All rights
> > +reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > **/
> > @@ -66,6 +66,7 @@ SMBIOS_FILTER_TABLE mSmbiosFilterType4BlackList[]
> =
> > {
> >{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2),
> > FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2),
> > 0 },
> >{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),
> FIELD_SIZE_OF
> > (SMBIOS_TABLE_TYPE4, ThreadCount2),
> > 0 },
> >{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, Voltage), FIELD_SIZE_OF
> > (SMBIOS_TABLE_TYPE4, Voltage), 0
> > },
> > + { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),
> > FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),
> > 0 },
> > };
> > SMBIOS_FILTER_TABLE mSmbiosFilterType17BlackList[] = {
> >{ 0x11, OFFSET_OF (SMBIOS_TABLE_TYPE17, SerialNumber),
> > FIELD_SIZE_OF (SMBIOS_TABLE_TYPE17, SerialNumber),
> > SMBIOS_FILTER_TABLE_FLAG_IS_STRING },
> > --
> > 2.31.1.windows.1
> >
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93732): https://edk2.groups.io/g/devel/message/93732
Mute This Topic: https://groups.io/mt/93542880/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table
Reviewed-by: James Lu
-Original Message-
From: devel@edk2.groups.io On Behalf Of Heng Luo
Sent: Thursday, September 8, 2022 1:41 PM
To: devel@edk2.groups.io
Cc: Wang, Jian J ; Gao, Liming
; Liu, Zhiguang ; Bi, Dandan
; Zeng, Star ; Gao, Zhichao
Subject: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4
CurrentSpeed to filter table
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4051
The Type4 CurrentSpeed field may be various.
So this patch adds it into the filter table.
Signed-off-by: Heng Luo
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Dandan Bi
Cc: Star Zeng
Cc: Zhichao Gao
---
MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
index 348082ff86..d61edc846b 100644
--- a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
+++ b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
@@ -1,7 +1,7 @@
/** @file
This driver measures SMBIOS table to TPM.
-Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -66,6 +66,7 @@ SMBIOS_FILTER_TABLE mSmbiosFilterType4BlackList[] = {
{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE4, EnabledCoreCount2), 0 },
{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, ThreadCount2), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE4, ThreadCount2), 0 },
{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, Voltage), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE4, Voltage), 0 },
+ { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE4, CurrentSpeed), 0 },
};
SMBIOS_FILTER_TABLE mSmbiosFilterType17BlackList[] = {
{ 0x11, OFFSET_OF (SMBIOS_TABLE_TYPE17, SerialNumber), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE17, SerialNumber), SMBIOS_FILTER_TABLE_FLAG_IS_STRING },
--
2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93707): https://edk2.groups.io/g/devel/message/93707
Mute This Topic: https://groups.io/mt/93542880/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table
Reviewed-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Heng
> Luo
> Sent: Thursday, September 8, 2022 1:41 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Liu, Zhiguang ; Bi,
> Dandan ; Zeng, Star ; Gao,
> Zhichao
> Subject: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe:
> Add Type4 CurrentSpeed to filter table
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4051
>
> The Type4 CurrentSpeed field may be various.
> So this patch adds it into the filter table.
>
> Signed-off-by: Heng Luo
> Cc: Jian J Wang
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Dandan Bi
> Cc: Star Zeng
> Cc: Zhichao Gao
> ---
>
> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement
> Dxe.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
> a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen
> tDxe.c
> b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme
> ntDxe.c
> index 348082ff86..d61edc846b 100644
> ---
> a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen
> tDxe.c
> +++
> b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme
> ntDxe.c
> @@ -1,7 +1,7 @@
> /** @file
>This driver measures SMBIOS table to TPM.
>
> -Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -66,6 +66,7 @@ SMBIOS_FILTER_TABLE mSmbiosFilterType4BlackList[]
> = {
>{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2),
> FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2),
> 0 },
>{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),
> FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),
> 0 },
>{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, Voltage), FIELD_SIZE_OF
> (SMBIOS_TABLE_TYPE4, Voltage), 0 },
> + { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),
> FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),
> 0 },
> };
> SMBIOS_FILTER_TABLE mSmbiosFilterType17BlackList[] = {
>{ 0x11, OFFSET_OF (SMBIOS_TABLE_TYPE17, SerialNumber),
> FIELD_SIZE_OF (SMBIOS_TABLE_TYPE17, SerialNumber),
> SMBIOS_FILTER_TABLE_FLAG_IS_STRING },
> --
> 2.31.1.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93517): https://edk2.groups.io/g/devel/message/93517
Mute This Topic: https://groups.io/mt/93542880/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4051
The Type4 CurrentSpeed field may be various.
So this patch adds it into the filter table.
Signed-off-by: Heng Luo
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Dandan Bi
Cc: Star Zeng
Cc: Zhichao Gao
---
MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
index 348082ff86..d61edc846b 100644
--- a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
+++ b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
@@ -1,7 +1,7 @@
/** @file
This driver measures SMBIOS table to TPM.
-Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -66,6 +66,7 @@ SMBIOS_FILTER_TABLE mSmbiosFilterType4BlackList[] = {
{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE4, EnabledCoreCount2), 0 },
{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, ThreadCount2), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE4, ThreadCount2), 0 },
{ 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, Voltage), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE4, Voltage), 0 },
+ { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE4, CurrentSpeed), 0 },
};
SMBIOS_FILTER_TABLE mSmbiosFilterType17BlackList[] = {
{ 0x11, OFFSET_OF (SMBIOS_TABLE_TYPE17, SerialNumber), FIELD_SIZE_OF
(SMBIOS_TABLE_TYPE17, SerialNumber), SMBIOS_FILTER_TABLE_FLAG_IS_STRING },
--
2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93516): https://edk2.groups.io/g/devel/message/93516
Mute This Topic: https://groups.io/mt/93542880/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
