Re: [edk2-devel] [PATCH] UefiCpuPkg/UefiCpuLib: Add GetCpuFamilyModel and GetCpuSteppingId

2021-11-09 Thread Dong, Eric 
Reviewed-by: Eric Dong 

-Original Message-
From: Ni, Ray  
Sent: Tuesday, October 19, 2021 2:42 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul1 
Subject: [PATCH] UefiCpuPkg/UefiCpuLib: Add GetCpuFamilyModel and 
GetCpuSteppingId

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3698

Lots of code relies on CPU Family/Model/Stepping for different logics.

The change adds two APIs for such needs.

Signed-off-by: Ray Ni 
Cc: Eric Dong 
Cc: Rahul Kumar 
---
 UefiCpuPkg/Include/Library/UefiCpuLib.h   | 23 +-
 .../Library/BaseUefiCpuLib/BaseUefiCpuLib.c   | 43 +++
 2 files changed, 65 insertions(+), 1 deletion(-)

diff --git a/UefiCpuPkg/Include/Library/UefiCpuLib.h 
b/UefiCpuPkg/Include/Library/UefiCpuLib.h
index 5326e72463..092c1d2116 100644
--- a/UefiCpuPkg/Include/Library/UefiCpuLib.h
+++ b/UefiCpuPkg/Include/Library/UefiCpuLib.h
@@ -4,7 +4,7 @@
   This library class defines some routines that are generic for IA32 family CPU

   to be UEFI specification compliant.

 

-  Copyright (c) 2009, Intel Corporation. All rights reserved.

+  Copyright (c) 2009 - 2021, Intel Corporation. All rights reserved.

   Copyright (c) 2020, AMD Inc. All rights reserved.

   SPDX-License-Identifier: BSD-2-Clause-Patent

 

@@ -43,4 +43,25 @@ StandardSignatureIsAuthenticAMD (
   VOID

   );

 

+/**

+  Return the 32bit CPU family and model value.

+

+  @return CPUID[01h].EAX with Processor Type and Stepping ID cleared.

+**/

+UINT32

+EFIAPI

+GetCpuFamilyModel (

+  VOID

+  );

+

+/**

+  Return the CPU stepping ID.

+  @return CPU stepping ID value in CPUID[01h].EAX.

+**/

+UINT8

+EFIAPI

+GetCpuSteppingId (

+  VOID

+  );

+

 #endif

diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c 
b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c
index c2cc3ff9a7..50891618c4 100644
--- a/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c
+++ b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c
@@ -4,6 +4,7 @@
   The library routines are UEFI specification compliant.

 

   Copyright (c) 2020, AMD Inc. All rights reserved.

+  Copyright (c) 2021, Intel Corporation. All rights reserved.

   SPDX-License-Identifier: BSD-2-Clause-Patent

 

 **/

@@ -36,3 +37,45 @@ StandardSignatureIsAuthenticAMD (
   RegEcx == CPUID_SIGNATURE_AUTHENTIC_AMD_ECX &&

   RegEdx == CPUID_SIGNATURE_AUTHENTIC_AMD_EDX);

 }

+

+/**

+  Return the 32bit CPU family and model value.

+

+  @return CPUID[01h].EAX with Processor Type and Stepping ID cleared.

+**/

+UINT32

+EFIAPI

+GetCpuFamilyModel (

+  VOID

+  )

+{

+  CPUID_VERSION_INFO_EAX  Eax;

+

+  AsmCpuid (CPUID_VERSION_INFO, , NULL, NULL, NULL);

+

+  //

+  // Mask other fields than Family and Model.

+  //

+  Eax.Bits.SteppingId= 0;

+  Eax.Bits.ProcessorType = 0;

+  Eax.Bits.Reserved1 = 0;

+  Eax.Bits.Reserved2 = 0;

+  return Eax.Uint32;

+}

+

+/**

+  Return the CPU stepping ID.

+  @return CPU stepping ID value in CPUID[01h].EAX.

+**/

+UINT8

+EFIAPI

+GetCpuSteppingId (

+  VOID

+  )

+{

+  CPUID_VERSION_INFO_EAX  Eax;

+

+  AsmCpuid (CPUID_VERSION_INFO, , NULL, NULL, NULL);

+

+  return (UINT8) Eax.Bits.SteppingId;

+}

-- 
2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83507): https://edk2.groups.io/g/devel/message/83507
Mute This Topic: https://groups.io/mt/86434196/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] UefiCpuPkg/UefiCpuLib: Add GetCpuFamilyModel and GetCpuSteppingId

2021-10-19 Thread Ni, Ray 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3698

Lots of code relies on CPU Family/Model/Stepping for different logics.

The change adds two APIs for such needs.

Signed-off-by: Ray Ni 
Cc: Eric Dong 
Cc: Rahul Kumar 
---
 UefiCpuPkg/Include/Library/UefiCpuLib.h   | 23 +-
 .../Library/BaseUefiCpuLib/BaseUefiCpuLib.c   | 43 +++
 2 files changed, 65 insertions(+), 1 deletion(-)

diff --git a/UefiCpuPkg/Include/Library/UefiCpuLib.h 
b/UefiCpuPkg/Include/Library/UefiCpuLib.h
index 5326e72463..092c1d2116 100644
--- a/UefiCpuPkg/Include/Library/UefiCpuLib.h
+++ b/UefiCpuPkg/Include/Library/UefiCpuLib.h
@@ -4,7 +4,7 @@
   This library class defines some routines that are generic for IA32 family CPU
   to be UEFI specification compliant.
 
-  Copyright (c) 2009, Intel Corporation. All rights reserved.
+  Copyright (c) 2009 - 2021, Intel Corporation. All rights reserved.
   Copyright (c) 2020, AMD Inc. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -43,4 +43,25 @@ StandardSignatureIsAuthenticAMD (
   VOID
   );
 
+/**
+  Return the 32bit CPU family and model value.
+
+  @return CPUID[01h].EAX with Processor Type and Stepping ID cleared.
+**/
+UINT32
+EFIAPI
+GetCpuFamilyModel (
+  VOID
+  );
+
+/**
+  Return the CPU stepping ID.
+  @return CPU stepping ID value in CPUID[01h].EAX.
+**/
+UINT8
+EFIAPI
+GetCpuSteppingId (
+  VOID
+  );
+
 #endif
diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c 
b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c
index c2cc3ff9a7..50891618c4 100644
--- a/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c
+++ b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c
@@ -4,6 +4,7 @@
   The library routines are UEFI specification compliant.
 
   Copyright (c) 2020, AMD Inc. All rights reserved.
+  Copyright (c) 2021, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -36,3 +37,45 @@ StandardSignatureIsAuthenticAMD (
   RegEcx == CPUID_SIGNATURE_AUTHENTIC_AMD_ECX &&
   RegEdx == CPUID_SIGNATURE_AUTHENTIC_AMD_EDX);
 }
+
+/**
+  Return the 32bit CPU family and model value.
+
+  @return CPUID[01h].EAX with Processor Type and Stepping ID cleared.
+**/
+UINT32
+EFIAPI
+GetCpuFamilyModel (
+  VOID
+  )
+{
+  CPUID_VERSION_INFO_EAX  Eax;
+
+  AsmCpuid (CPUID_VERSION_INFO, , NULL, NULL, NULL);
+
+  //
+  // Mask other fields than Family and Model.
+  //
+  Eax.Bits.SteppingId= 0;
+  Eax.Bits.ProcessorType = 0;
+  Eax.Bits.Reserved1 = 0;
+  Eax.Bits.Reserved2 = 0;
+  return Eax.Uint32;
+}
+
+/**
+  Return the CPU stepping ID.
+  @return CPU stepping ID value in CPUID[01h].EAX.
+**/
+UINT8
+EFIAPI
+GetCpuSteppingId (
+  VOID
+  )
+{
+  CPUID_VERSION_INFO_EAX  Eax;
+
+  AsmCpuid (CPUID_VERSION_INFO, , NULL, NULL, NULL);
+
+  return (UINT8) Eax.Bits.SteppingId;
+}
-- 
2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82298): https://edk2.groups.io/g/devel/message/82298
Mute This Topic: https://groups.io/mt/86434196/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-