Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-27 Thread PierreGondois 

Hello Leif,

On 3/12/24 17:47, Leif Lindholm wrote:

On 2024-03-12 02:18, Pierre Gondois wrote:

This patch relies on [1].

Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
move the Chipset/* files to the MdePkg as the Armlib.h relies on
them.

These patches span over multiple packages as these Chipset/* files
are relocated to a new directory and include paths must be updated.


I like this!
Traveling this week, so unable to test until Wednesday next week at the
earliest, which I would like to do for something this core before giving
a Reviewed-by. So for now, for the series:
Acked-by: Leif Lindholm 


I forgot to add your Acked-by tag.

Just a ping if the v2 was forgotten:
- https://edk2.groups.io/g/devel/message/116759

Regards,
Pierre




[1] https://edk2.groups.io/g/devel/message/111566

Cc: Ard Biesheuvel 
Cc: Gerd Hoffmann 
Cc: Jiewen Yao 
Cc: Leif Lindholm 
Cc: Liming Gao 
Cc: Michael D Kinney 
Cc: Pierre Gondois 
Cc: Sami Mujawar 
Cc: Zhiguang Liu 

Pierre Gondois (2):
ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg
ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg

   ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 2 +-
   ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S | 2 +-
   ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 2 +-
   ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c| 2 +-
   ArmPkg/Library/ArmLib/AArch64/AArch64Support.S| 2 +-
   ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c  | 2 +-
   ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c  | 2 +-
   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c   | 2 +-
   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c  | 2 +-
   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c| 2 +-
   ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 2 +-
   ArmPlatformPkg/PrePeiCore/AArch64/Helper.S| 2 +-
   ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
   ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S   | 2 +-
   ArmVirtPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
   {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h  | 2 +-
   .../Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h   | 0
   .../Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h   | 2 +-
   .../Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h | 0
   MdePkg/Include/Library/ArmLib.h   | 4 ++--
   20 files changed, 19 insertions(+), 19 deletions(-)
   rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h (94%)
   rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h (100%)
   rename ArmPkg/Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h (95%)
   rename ArmPkg/Include/Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h 
(100%)






-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117164): https://edk2.groups.io/g/devel/message/117164
Mute This Topic: https://groups.io/mt/104881290/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-13 Thread PierreGondois 

Hello Michael,

On 3/12/24 17:53, Kinney, Michael D wrote:

The MdePkg does have a standard location for CPU specific register
related includes.

Did you consider moving some of the content into

* MdePkg/Include/Register/Arm
* MdePkg/Include/Register/AArch64


Yes right, this should be a better location,

Regards,
Pierre



Thanks,

Mike


-Original Message-
From: Leif Lindholm 
Sent: Tuesday, March 12, 2024 9:47 AM
To: Pierre Gondois ; devel@edk2.groups.io
Cc: Ard Biesheuvel ; Gerd Hoffmann
; Yao, Jiewen ; Liming Gao
; Kinney, Michael D ;
Sami Mujawar ; Liu, Zhiguang 
Subject: Re: [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

On 2024-03-12 02:18, Pierre Gondois wrote:

This patch relies on [1].

Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
move the Chipset/* files to the MdePkg as the Armlib.h relies on
them.

These patches span over multiple packages as these Chipset/* files
are relocated to a new directory and include paths must be updated.


I like this!
Traveling this week, so unable to test until Wednesday next week at the
earliest, which I would like to do for something this core before giving
a Reviewed-by. So for now, for the series:
Acked-by: Leif Lindholm 


[1] https://edk2.groups.io/g/devel/message/111566

Cc: Ard Biesheuvel 
Cc: Gerd Hoffmann 
Cc: Jiewen Yao 
Cc: Leif Lindholm 
Cc: Liming Gao 
Cc: Michael D Kinney 
Cc: Pierre Gondois 
Cc: Sami Mujawar 
Cc: Zhiguang Liu 

Pierre Gondois (2):
ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg
ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg

   ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 2 +-
   ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S | 2 +-
   ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 2 +-
   ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c| 2 +-
   ArmPkg/Library/ArmLib/AArch64/AArch64Support.S| 2 +-
   ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c  | 2 +-
   ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c  | 2 +-
   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c   | 2 +-
   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c  | 2 +-
   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c| 2 +-
   ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 2 +-
   ArmPlatformPkg/PrePeiCore/AArch64/Helper.S| 2 +-
   ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
   ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S   | 2 +-
   ArmVirtPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
   {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h  | 2 +-
   .../Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h   | 0
   .../Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h   | 2 +-
   .../Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h | 0
   MdePkg/Include/Library/ArmLib.h   | 4 ++--
   20 files changed, 19 insertions(+), 19 deletions(-)
   rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h

(94%)

   rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h

(100%)

   rename ArmPkg/Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h

(95%)

   rename ArmPkg/Include/Chipset/ArmV7Mmu.h =>

MdePkg/Include/Arm/AArch32Mmu.h (100%)







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116714): https://edk2.groups.io/g/devel/message/116714
Mute This Topic: https://groups.io/mt/104881290/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-12 Thread Michael D Kinney 
The MdePkg does have a standard location for CPU specific register
related includes.

Did you consider moving some of the content into

* MdePkg/Include/Register/Arm
* MdePkg/Include/Register/AArch64

Thanks,

Mike

> -Original Message-
> From: Leif Lindholm 
> Sent: Tuesday, March 12, 2024 9:47 AM
> To: Pierre Gondois ; devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Yao, Jiewen ; Liming Gao
> ; Kinney, Michael D ;
> Sami Mujawar ; Liu, Zhiguang 
> Subject: Re: [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg
> 
> On 2024-03-12 02:18, Pierre Gondois wrote:
> > This patch relies on [1].
> >
> > Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
> > move the Chipset/* files to the MdePkg as the Armlib.h relies on
> > them.
> >
> > These patches span over multiple packages as these Chipset/* files
> > are relocated to a new directory and include paths must be updated.
> 
> I like this!
> Traveling this week, so unable to test until Wednesday next week at the
> earliest, which I would like to do for something this core before giving
> a Reviewed-by. So for now, for the series:
> Acked-by: Leif Lindholm 
> 
> > [1] https://edk2.groups.io/g/devel/message/111566
> >
> > Cc: Ard Biesheuvel 
> > Cc: Gerd Hoffmann 
> > Cc: Jiewen Yao 
> > Cc: Leif Lindholm 
> > Cc: Liming Gao 
> > Cc: Michael D Kinney 
> > Cc: Pierre Gondois 
> > Cc: Sami Mujawar 
> > Cc: Zhiguang Liu 
> >
> > Pierre Gondois (2):
> >ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg
> >ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg
> >
> >   ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 2 +-
> >   ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S | 2 +-
> >   ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 2 +-
> >   ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c| 2 +-
> >   ArmPkg/Library/ArmLib/AArch64/AArch64Support.S| 2 +-
> >   ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c  | 2 +-
> >   ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c  | 2 +-
> >   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c   | 2 +-
> >   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c  | 2 +-
> >   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c| 2 +-
> >   ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 2 +-
> >   ArmPlatformPkg/PrePeiCore/AArch64/Helper.S| 2 +-
> >   ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
> >   ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S   | 2 +-
> >   ArmVirtPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
> >   {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h  | 2 +-
> >   .../Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h   | 0
> >   .../Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h   | 2 +-
> >   .../Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h | 0
> >   MdePkg/Include/Library/ArmLib.h   | 4 ++--
> >   20 files changed, 19 insertions(+), 19 deletions(-)
> >   rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h
> (94%)
> >   rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h
> (100%)
> >   rename ArmPkg/Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h
> (95%)
> >   rename ArmPkg/Include/Chipset/ArmV7Mmu.h =>
> MdePkg/Include/Arm/AArch32Mmu.h (100%)
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116694): https://edk2.groups.io/g/devel/message/116694
Mute This Topic: https://groups.io/mt/104881290/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-12 Thread Leif Lindholm 

On 2024-03-12 02:18, Pierre Gondois wrote:

This patch relies on [1].

Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
move the Chipset/* files to the MdePkg as the Armlib.h relies on
them.

These patches span over multiple packages as these Chipset/* files
are relocated to a new directory and include paths must be updated.


I like this!
Traveling this week, so unable to test until Wednesday next week at the 
earliest, which I would like to do for something this core before giving 
a Reviewed-by. So for now, for the series:

Acked-by: Leif Lindholm 


[1] https://edk2.groups.io/g/devel/message/111566

Cc: Ard Biesheuvel 
Cc: Gerd Hoffmann 
Cc: Jiewen Yao 
Cc: Leif Lindholm 
Cc: Liming Gao 
Cc: Michael D Kinney 
Cc: Pierre Gondois 
Cc: Sami Mujawar 
Cc: Zhiguang Liu 

Pierre Gondois (2):
   ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg
   ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg

  ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 2 +-
  ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S | 2 +-
  ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 2 +-
  ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c| 2 +-
  ArmPkg/Library/ArmLib/AArch64/AArch64Support.S| 2 +-
  ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c  | 2 +-
  ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c  | 2 +-
  ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c   | 2 +-
  ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c  | 2 +-
  ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c| 2 +-
  ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 2 +-
  ArmPlatformPkg/PrePeiCore/AArch64/Helper.S| 2 +-
  ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
  ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S   | 2 +-
  ArmVirtPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
  {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h  | 2 +-
  .../Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h   | 0
  .../Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h   | 2 +-
  .../Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h | 0
  MdePkg/Include/Library/ArmLib.h   | 4 ++--
  20 files changed, 19 insertions(+), 19 deletions(-)
  rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h (94%)
  rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h (100%)
  rename ArmPkg/Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h (95%)
  rename ArmPkg/Include/Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h 
(100%)





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116692): https://edk2.groups.io/g/devel/message/116692
Mute This Topic: https://groups.io/mt/104881290/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-12 Thread PierreGondois 
This patch relies on [1].

Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
move the Chipset/* files to the MdePkg as the Armlib.h relies on
them.

These patches span over multiple packages as these Chipset/* files
are relocated to a new directory and include paths must be updated.

[1] https://edk2.groups.io/g/devel/message/111566

Cc: Ard Biesheuvel 
Cc: Gerd Hoffmann 
Cc: Jiewen Yao 
Cc: Leif Lindholm 
Cc: Liming Gao 
Cc: Michael D Kinney 
Cc: Pierre Gondois 
Cc: Sami Mujawar 
Cc: Zhiguang Liu 

Pierre Gondois (2):
  ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg
  ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg

 ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 2 +-
 ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S | 2 +-
 ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 2 +-
 ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c| 2 +-
 ArmPkg/Library/ArmLib/AArch64/AArch64Support.S| 2 +-
 ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c  | 2 +-
 ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c  | 2 +-
 ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c   | 2 +-
 ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c  | 2 +-
 ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c| 2 +-
 ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 2 +-
 ArmPlatformPkg/PrePeiCore/AArch64/Helper.S| 2 +-
 ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
 ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S   | 2 +-
 ArmVirtPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
 {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h  | 2 +-
 .../Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h   | 0
 .../Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h   | 2 +-
 .../Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h | 0
 MdePkg/Include/Library/ArmLib.h   | 4 ++--
 20 files changed, 19 insertions(+), 19 deletions(-)
 rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h (94%)
 rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h (100%)
 rename ArmPkg/Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h (95%)
 rename ArmPkg/Include/Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h 
(100%)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116673): https://edk2.groups.io/g/devel/message/116673
Mute This Topic: https://groups.io/mt/104881290/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-