Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD
Yes, we will remove them later after confirming no impact to all platforms. Regards, Chasel > -Original Message- > From: Gao, Liming > Sent: Tuesday, July 30, 2019 11:46 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Sinha, Ankit > ; Desimone, Nathaniel L > > Subject: RE: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD > > Chasel: > This is a good enhancement. With this change, can > RebaseAndPatchFspBinBaseAddress.py and PatchFspBinFvsBaseAddress.py be > removed? > > Thanks > Liming > > -Original Message- > > From: Chiu, Chasel > > Sent: Monday, July 29, 2019 7:07 PM > > To: devel@edk2.groups.io > > Cc: Kubacki, Michael A ; Sinha, Ankit > > ; Desimone, Nathaniel L > > ; Gao, Liming > > Subject: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 > > > > PcdFsp*BaseAddress now will be updated in FDF basing on flash map. > > DSC will only define types of those PCDs and always having 0 as > > default. > > New script added to only rebase FSP binary without patching DSC file. > > > > Test: interanl platform booted with this patch. > > > > Cc: Michael Kubacki > > Cc: Ankit Sinha > > Cc: Nate DeSimone > > Cc: Liming Gao > > Signed-off-by: Chasel Chiu > > > > Chasel Chiu (4): > > MinPlatformPkg: Auto configure Fsp*BaseAddress PCD > > Platform/Intel: Auto configure Fsp*BaseAddress PCD > > KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > > ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > > > > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf > | 3 +++ > > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc > | 12 +--- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > | 3 +++ > > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc > | 12 +--- > > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | > 96 > > > > > > Platform/Intel/build_bios.py | 7 > > ++- > > 6 files changed, 122 insertions(+), 11 deletions(-) create mode > > 100644 > > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > > > > -- > > 2.13.3.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44587): https://edk2.groups.io/g/devel/message/44587 Mute This Topic: https://groups.io/mt/32640908/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD
Chasel: This is a good enhancement. With this change, can RebaseAndPatchFspBinBaseAddress.py and PatchFspBinFvsBaseAddress.py be removed? Thanks Liming > -Original Message- > From: Chiu, Chasel > Sent: Monday, July 29, 2019 7:07 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 > > PcdFsp*BaseAddress now will be updated in FDF basing > on flash map. > DSC will only define types of those PCDs and always > having 0 as default. > New script added to only rebase FSP binary without > patching DSC file. > > Test: interanl platform booted with this patch. > > Cc: Michael Kubacki > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Chasel Chiu > > Chasel Chiu (4): > MinPlatformPkg: Auto configure Fsp*BaseAddress PCD > Platform/Intel: Auto configure Fsp*BaseAddress PCD > KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | 3 +++ > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc | 12 > +--- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf| 3 +++ > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 12 > +--- > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 96 > > Platform/Intel/build_bios.py | 7 > ++- > 6 files changed, 122 insertions(+), 11 deletions(-) > create mode 100644 > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > > -- > 2.13.3.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44585): https://edk2.groups.io/g/devel/message/44585 Mute This Topic: https://groups.io/mt/32640908/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD
Thanks for the good catch! I have corrected BZ and will update subject from next patch. Thanks! Chasel > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, July 29, 2019 9:47 PM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Kubacki, Michael A ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD > > On 07/29/19 13:07, Chiu, Chasel wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 > > > > PcdFsp*BaseAddress now will be updated in FDF basing on flash map. > > DSC will only define types of those PCDs and always having 0 as > > default. > > New script added to only rebase FSP binary without patching DSC file. > > > > Test: interanl platform booted with this patch. > > > > Cc: Michael Kubacki > > Cc: Ankit Sinha > > Cc: Nate DeSimone > > Cc: Liming Gao > > Signed-off-by: Chasel Chiu > > > > Chasel Chiu (4): > > MinPlatformPkg: Auto configure Fsp*BaseAddress PCD > > Platform/Intel: Auto configure Fsp*BaseAddress PCD > > KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > > ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > > > > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf > | 3 +++ > > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc > | 12 +--- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > | 3 +++ > > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc > | 12 +--- > > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | > 96 > > > > Platform/Intel/build_bios.py | 7 > > ++- > > 6 files changed, 122 insertions(+), 11 deletions(-) create mode > > 100644 > > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > > > > I think the classification on TianoCore BZ#1863 is wrong. It should be > "EDK2 Platforms", probably. Please update the BZ. > > > Accordingly, the subject prefix on this patch series should not be "PATCH", > but > "edk2-platforms PATCH". No need to resend the v1 patch series just for this, > but > if you send a v2, please set the correct subject prefix: > > git format-patch -v2 --subject-prefix='edk2-platforms PATCH' ... > > Thanks > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44575): https://edk2.groups.io/g/devel/message/44575 Mute This Topic: https://groups.io/mt/32640908/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD
On 07/29/19 13:07, Chiu, Chasel wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 > > PcdFsp*BaseAddress now will be updated in FDF basing > on flash map. > DSC will only define types of those PCDs and always > having 0 as default. > New script added to only rebase FSP binary without > patching DSC file. > > Test: interanl platform booted with this patch. > > Cc: Michael Kubacki > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Chasel Chiu > > Chasel Chiu (4): > MinPlatformPkg: Auto configure Fsp*BaseAddress PCD > Platform/Intel: Auto configure Fsp*BaseAddress PCD > KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | 3 +++ > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc | 12 > +--- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf| 3 +++ > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 12 > +--- > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 96 > > Platform/Intel/build_bios.py | 7 > ++- > 6 files changed, 122 insertions(+), 11 deletions(-) > create mode 100644 > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > I think the classification on TianoCore BZ#1863 is wrong. It should be "EDK2 Platforms", probably. Please update the BZ. Accordingly, the subject prefix on this patch series should not be "PATCH", but "edk2-platforms PATCH". No need to resend the v1 patch series just for this, but if you send a v2, please set the correct subject prefix: git format-patch -v2 --subject-prefix='edk2-platforms PATCH' ... Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44521): https://edk2.groups.io/g/devel/message/44521 Mute This Topic: https://groups.io/mt/32640908/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 PcdFsp*BaseAddress now will be updated in FDF basing on flash map. DSC will only define types of those PCDs and always having 0 as default. New script added to only rebase FSP binary without patching DSC file. Test: interanl platform booted with this patch. Cc: Michael Kubacki Cc: Ankit Sinha Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu Chasel Chiu (4): MinPlatformPkg: Auto configure Fsp*BaseAddress PCD Platform/Intel: Auto configure Fsp*BaseAddress PCD KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | 3 +++ Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc | 12 +--- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf| 3 +++ Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 12 +--- Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 96 Platform/Intel/build_bios.py | 7 ++- 6 files changed, 122 insertions(+), 11 deletions(-) create mode 100644 Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py -- 2.13.3.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44509): https://edk2.groups.io/g/devel/message/44509 Mute This Topic: https://groups.io/mt/32640908/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
