Re: [edk2-devel] [PATCH 0/5] [PATCH 0/5] Config language searching algorithm enhancement and the bug fixes

2024-03-26 Thread Nickle Wang via groups.io
Thanks for working on Redfish performance improvements, Abner. Per offline 
discussion, I have updated this patch series to support menu path reporting for 
BIOS attribute registry.

Please send version 2 patch series if you are ok with my modifications.

Thanks,
Nickle

> -Original Message-
> From: abner.ch...@amd.com 
> Sent: Friday, March 22, 2024 5:43 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy 
> Subject: [PATCH 0/5] [PATCH 0/5] Config language searching algorithm
> enhancement and the bug fixes
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Abner Chang 
> 
> PR # 5491
> 
> In this patch set,
> 1 We enhance the config language searching algorithm.
>   As the performance of searching config language using HII GetString is
>   pretty slow. For the example, 1800 HII BIOS options takes over 30 mins
>   to build up the metadata required for Redfish BIOS resource. With this
>   improvement, it only takes 4 seconds.
> 
> 2.Introduce the Redfish debug framework, there are three edk2 Redfish
>   debug scopes.
>   a. PcdDebugPrintErrorLevel, DEBUG_MANAGEABILITY to enable debug message
>  for edk2 Redfish.
>   b. PcdRedfishDebugCategory, enablement of individule edk2 Redfish
>  component. Currently we only support RedfishPlatformConfigDxe
>  module.
>   c. PcdRedfishPlatformConfigDebugProperty, edk2 Redfish module debug
>  scope. This PCD is used by RedfishPlatformConfigDxe debug enablement.
> 
> 3 This patch set also fixes an issue that deletes HII string unexpectedly.
> 
> Signed-off-by: Abner Chang 
> Co-authored-by: Nickle Wang 
> Cc: Igor Kulchytskyy 
> 
> Abner Chang (4):
>   RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro
>   RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support
>   RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted
> unexpectedly
>   EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs
> 
> abnchang (1):
>   RedfishPkg/RedfishPlatformConfigDxe: Config language searching
> optimization
> 
>  RedfishPkg/RedfishPkg.dec |  24 +
>  EmulatorPkg/EmulatorPkg.dsc   |  21 +
>  .../RedfishDebugLib/RedfishDebugLib.inf   |   4 +
>  .../RedfishPlatformConfigDxe.inf  |   8 +
>  RedfishPkg/Include/Library/RedfishDebugLib.h  |  43 +-
>  .../RedfishPlatformConfigDxe.h|  46 +-
>  .../RedfishPlatformConfigImpl.h   | 131 ++-
>  .../Library/RedfishDebugLib/RedfishDebugLib.c |  55 +-
>  .../RedfishPlatformConfigCapability.c |  52 +
>  .../RedfishPlatformConfigDxe.c|  89 +-
>  .../RedfishPlatformConfigImpl.c   | 894 --
>  11 files changed, 1196 insertions(+), 171 deletions(-)  create mode 100644
> RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapability.c
> 
> --
> 2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117109): https://edk2.groups.io/g/devel/message/117109
Mute This Topic: https://groups.io/mt/105082172/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH 0/5] [PATCH 0/5] Config language searching algorithm enhancement and the bug fixes

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang 

PR # 5491

In this patch set,
1 We enhance the config language searching algorithm.
  As the performance of searching config language using HII GetString is
  pretty slow. For the example, 1800 HII BIOS options takes over 30 mins
  to build up the metadata required for Redfish BIOS resource. With this
  improvement, it only takes 4 seconds.

2.Introduce the Redfish debug framework, there are three edk2 Redfish
  debug scopes.
  a. PcdDebugPrintErrorLevel, DEBUG_MANAGEABILITY to enable debug message
 for edk2 Redfish.
  b. PcdRedfishDebugCategory, enablement of individule edk2 Redfish
 component. Currently we only support RedfishPlatformConfigDxe
 module.
  c. PcdRedfishPlatformConfigDebugProperty, edk2 Redfish module debug
 scope. This PCD is used by RedfishPlatformConfigDxe debug enablement.

3 This patch set also fixes an issue that deletes HII string unexpectedly.

Signed-off-by: Abner Chang 
Co-authored-by: Nickle Wang 
Cc: Igor Kulchytskyy 

Abner Chang (4):
  RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro
  RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support
  RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted
unexpectedly
  EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs

abnchang (1):
  RedfishPkg/RedfishPlatformConfigDxe: Config language searching
optimization

 RedfishPkg/RedfishPkg.dec |  24 +
 EmulatorPkg/EmulatorPkg.dsc   |  21 +
 .../RedfishDebugLib/RedfishDebugLib.inf   |   4 +
 .../RedfishPlatformConfigDxe.inf  |   8 +
 RedfishPkg/Include/Library/RedfishDebugLib.h  |  43 +-
 .../RedfishPlatformConfigDxe.h|  46 +-
 .../RedfishPlatformConfigImpl.h   | 131 ++-
 .../Library/RedfishDebugLib/RedfishDebugLib.c |  55 +-
 .../RedfishPlatformConfigCapability.c |  52 +
 .../RedfishPlatformConfigDxe.c|  89 +-
 .../RedfishPlatformConfigImpl.c   | 894 --
 11 files changed, 1196 insertions(+), 171 deletions(-)
 create mode 100644 
RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapability.c

-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117036): https://edk2.groups.io/g/devel/message/117036
Mute This Topic: https://groups.io/mt/105082172/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-