Re: [edk2-devel] [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call
On Tue, 17 Sep 2019 at 21:49, Laszlo Ersek wrote: > > - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: > > IN OUT EFI_HANDLE *ChildHandle > > - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: > > IN EFI_HANDLE ChildHandle > > Fix the DestroyChild() call in TcpFastbootTransportStop(). > > This is an actual bugfix; I don't know why the current code doesn't crash. > Perhaps the function is never reached in practice? (It could be tied to an > error path.) > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Laszlo Ersek Acked-by: Ard Biesheuvel > --- > > Notes: > build-tested only > > EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c | > 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > index 29f23a82c75f..34f9ba74e4db 100644 > --- > a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > +++ > b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( >Status = mTcpListener->Configure (mTcpListener, NULL); >ASSERT_EFI_ERROR (Status); > > - Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, > ); > + Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpHandle); > >// Free any data the user didn't pick up >Entry = (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (); > -- > 2.19.1.3.g30247aa5d201 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48100): https://edk2.groups.io/g/devel/message/48100 Mute This Topic: https://groups.io/mt/34180202/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call
Leif, Ard, On 09/17/19 21:49, Laszlo Ersek wrote: > - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: > > IN OUT EFI_HANDLE *ChildHandle > > - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: > > IN EFI_HANDLE ChildHandle > > Fix the DestroyChild() call in TcpFastbootTransportStop(). > > This is an actual bugfix; I don't know why the current code doesn't crash. > Perhaps the function is never reached in practice? (It could be tied to an > error path.) > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c | > 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) can you please ACK this one too? (Apologies if it's already on your radar.) Thanks! Laszlo > diff --git > a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > index 29f23a82c75f..34f9ba74e4db 100644 > --- > a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > +++ > b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( >Status = mTcpListener->Configure (mTcpListener, NULL); >ASSERT_EFI_ERROR (Status); > > - Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, > ); > + Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpHandle); > >// Free any data the user didn't pick up >Entry = (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (); > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48094): https://edk2.groups.io/g/devel/message/48094 Mute This Topic: https://groups.io/mt/34180202/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: > > IN OUT EFI_HANDLE *ChildHandle > > - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: > > IN EFI_HANDLE ChildHandle > > Fix the DestroyChild() call in TcpFastbootTransportStop(). > > This is an actual bugfix; I don't know why the current code doesn't crash. > Perhaps the function is never reached in practice? (It could be tied to an > error path.) > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c | > 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > index 29f23a82c75f..34f9ba74e4db 100644 > --- > a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > +++ > b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( >Status = mTcpListener->Configure (mTcpListener, NULL); >ASSERT_EFI_ERROR (Status); > > - Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, > ); > + Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpHandle); > >// Free any data the user didn't pick up >Entry = (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (); > Reviewed-by: Philippe Mathieu-Daude -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47919): https://edk2.groups.io/g/devel/message/47919 Mute This Topic: https://groups.io/mt/34180202/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call
- The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: IN OUT EFI_HANDLE *ChildHandle - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: IN EFI_HANDLE ChildHandle Fix the DestroyChild() call in TcpFastbootTransportStop(). This is an actual bugfix; I don't know why the current code doesn't crash. Perhaps the function is never reached in practice? (It could be tied to an error path.) Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Laszlo Ersek --- Notes: build-tested only EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c index 29f23a82c75f..34f9ba74e4db 100644 --- a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c +++ b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( Status = mTcpListener->Configure (mTcpListener, NULL); ASSERT_EFI_ERROR (Status); - Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, ); + Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpHandle); // Free any data the user didn't pick up Entry = (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (); -- 2.19.1.3.g30247aa5d201 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47390): https://edk2.groups.io/g/devel/message/47390 Mute This Topic: https://groups.io/mt/34180202/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
