Re: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data

2020-06-16 Thread Wang, Jian J 
Reviewed-by: Jian J Wang 

Regards,
Jian

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Tan, Ming
> Sent: Monday, June 15, 2020 10:04 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do
> not output \n\r for string data
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2787
> 
> When output string data through serial port, will not ouput \n\r now.
> Caller can output several data in one line, and output \n\r when needed.
> 
> Signed-off-by: Ming Tan 
> ---
> V2: Make it as a standalone patch.
>  .../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c| 2 +-
>  .../StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c   | 2 +-
>  .../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c| 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
> b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
> index 2455f8b2a908..3aa5642b64fb 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
> @@ -134,7 +134,7 @@ SerialStatusCodeReportWorker (
>  CharCount = AsciiSPrint (
>Buffer,
>sizeof (Buffer),
> -  "%a\n\r",
> +  "%a",
>((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
>);
>} else {
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode
> Worker.c
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode
> Worker.c
> index 2dc3ecfff52e..0b98e7ec6315 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode
> Worker.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode
> Worker.c
> @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
>  CharCount = AsciiSPrint (
>Buffer,
>sizeof (Buffer),
> -  "%a\n\r",
> +  "%a",
>((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
>);
>} else {
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.
> c
> b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.
> c
> index c0c907b32f5a..3df0a6712611 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.
> c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.
> c
> @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
>  CharCount = AsciiSPrint (
>Buffer,
>sizeof (Buffer),
> -  "%a\n\r",
> +  "%a",
>((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
>);
>} else {
> --
> 2.24.0.windows.2
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61371): https://edk2.groups.io/g/devel/message/61371
Mute This Topic: https://groups.io/mt/74887116/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data

2020-06-14 Thread Dong, Eric 
Reviewed-by: Eric Dong 

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Tan,
> Ming
> Sent: Monday, June 15, 2020 10:04 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler:
> do not output \n\r for string data
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2787
> 
> When output string data through serial port, will not ouput \n\r now.
> Caller can output several data in one line, and output \n\r when needed.
> 
> Signed-off-by: Ming Tan 
> ---
> V2: Make it as a standalone patch.
>  .../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c| 2 +-
>  .../StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c   | 2 +-
>  .../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c| 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork
> er.c
> b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork
> er.c
> index 2455f8b2a908..3aa5642b64fb 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork
> er.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWork
> er.c
> @@ -134,7 +134,7 @@ SerialStatusCodeReportWorker (
>  CharCount = AsciiSPrint (
>Buffer,
>sizeof (Buffer),
> -  "%a\n\r",
> +  "%a",
>((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
>);
>} else {
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC
> odeWorker.c
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC
> odeWorker.c
> index 2dc3ecfff52e..0b98e7ec6315 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC
> odeWorker.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusC
> odeWorker.c
> @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
>  CharCount = AsciiSPrint (
>Buffer,
>sizeof (Buffer),
> -  "%a\n\r",
> +  "%a",
>((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
>);
>} else {
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo
> rker.c
> b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo
> rker.c
> index c0c907b32f5a..3df0a6712611 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo
> rker.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWo
> rker.c
> @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
>  CharCount = AsciiSPrint (
>Buffer,
>sizeof (Buffer),
> -  "%a\n\r",
> +  "%a",
>((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
>);
>} else {
> --
> 2.24.0.windows.2
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61264): https://edk2.groups.io/g/devel/message/61264
Mute This Topic: https://groups.io/mt/74887116/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data

2020-06-14 Thread Tan, Ming 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2787

When output string data through serial port, will not ouput \n\r now.
Caller can output several data in one line, and output \n\r when needed.

Signed-off-by: Ming Tan 
---
V2: Make it as a standalone patch.
 .../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c| 2 +-
 .../StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c   | 2 +-
 .../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c| 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c 
b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
index 2455f8b2a908..3aa5642b64fb 100644
--- a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
+++ b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
@@ -134,7 +134,7 @@ SerialStatusCodeReportWorker (
 CharCount = AsciiSPrint (
   Buffer,
   sizeof (Buffer),
-  "%a\n\r",
+  "%a",
   ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
   );
   } else {
diff --git 
a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c 
b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c
index 2dc3ecfff52e..0b98e7ec6315 100644
--- 
a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c
+++ 
b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c
@@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
 CharCount = AsciiSPrint (
   Buffer,
   sizeof (Buffer),
-  "%a\n\r",
+  "%a",
   ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
   );
   } else {
diff --git 
a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c 
b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c
index c0c907b32f5a..3df0a6712611 100644
--- a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c
+++ b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c
@@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
 CharCount = AsciiSPrint (
   Buffer,
   sizeof (Buffer),
-  "%a\n\r",
+  "%a",
   ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
   );
   } else {
-- 
2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61260): https://edk2.groups.io/g/devel/message/61260
Mute This Topic: https://groups.io/mt/74887116/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-