Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()
On 10/08/19 02:32, Fu, Siyuan wrote:
> Just return from vacation. Sorry for late response.
>
> Reviewed-by: Siyuan Fu
Thank you and Mike both!
Laszlo
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Philippe
>> Mathieu-Daudé
>> Sent: 2019年9月24日 19:00
>> To: devel@edk2.groups.io; ler...@redhat.com
>> Cc: Wu, Jiaxin ; Fu, Siyuan
>> Subject: Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type
>> typo in NetLibGetMacAddress()
>>
>> On 9/17/19 9:49 PM, Laszlo Ersek wrote:
>>> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
>>> NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
>>> NULL-check. Fix the type of "SnpHandle".
>>>
>>> This patch is a no-op.
>>>
>>> Cc: Jiaxin Wu
>>> Cc: Siyuan Fu
>>> Signed-off-by: Laszlo Ersek
>>> ---
>>>
>>> Notes:
>>> lightly tested: MAC strings are displayed in UiApp
>>>
>>> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> index 8e2f720666ea..a39c20be3d34 100644
>>> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> @@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
>>>EFI_SIMPLE_NETWORK_MODE SnpModeData;
>>>EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
>>>EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
>>> - EFI_HANDLE *SnpHandle;
>>> + EFI_HANDLE SnpHandle;
>>>EFI_HANDLE MnpChildHandle;
>>>
>>>ASSERT (MacAddress != NULL);
>>>
>>
>> Since SnpHandle is only checked for being non-null, this change is
>> indeed a no-op, else it would probably fixed some bug.
>>
>> Reviewed-by: Philippe Mathieu-Daude
>>
>>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48612): https://edk2.groups.io/g/devel/message/48612
Mute This Topic: https://groups.io/mt/34180219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()
Just return from vacation. Sorry for late response.
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Philippe
> Mathieu-Daudé
> Sent: 2019年9月24日 19:00
> To: devel@edk2.groups.io; ler...@redhat.com
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type
> typo in NetLibGetMacAddress()
>
> On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> > NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
> > NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
> > NULL-check. Fix the type of "SnpHandle".
> >
> > This patch is a no-op.
> >
> > Cc: Jiaxin Wu
> > Cc: Siyuan Fu
> > Signed-off-by: Laszlo Ersek
> > ---
> >
> > Notes:
> > lightly tested: MAC strings are displayed in UiApp
> >
> > NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> > index 8e2f720666ea..a39c20be3d34 100644
> > --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> > +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> > @@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
> >EFI_SIMPLE_NETWORK_MODE SnpModeData;
> >EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
> >EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
> > - EFI_HANDLE *SnpHandle;
> > + EFI_HANDLE SnpHandle;
> >EFI_HANDLE MnpChildHandle;
> >
> >ASSERT (MacAddress != NULL);
> >
>
> Since SnpHandle is only checked for being non-null, this change is
> indeed a no-op, else it would probably fixed some bug.
>
> Reviewed-by: Philippe Mathieu-Daude
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48511): https://edk2.groups.io/g/devel/message/48511
Mute This Topic: https://groups.io/mt/34180219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()
Laszlo,
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Laszlo Ersek
> Sent: Tuesday, September 17, 2019 12:49 PM
> To: edk2-devel-groups-io
> Cc: Wu, Jiaxin ; Fu, Siyuan
>
> Subject: [edk2-devel] [PATCH 18/35]
> NetworkPkg/DxeNetLib: fix type typo in
> NetLibGetMacAddress()
>
> NetLibGetSnpHandle() returns an EFI_HANDLE, not an
> (EFI_HANDLE*).
> NetLibGetMacAddress() only uses the return value
> ("SnpHandle") for a NULL-check. Fix the type of
> "SnpHandle".
>
> This patch is a no-op.
>
> Cc: Jiaxin Wu
> Cc: Siyuan Fu
> Signed-off-by: Laszlo Ersek
> ---
>
> Notes:
> lightly tested: MAC strings are displayed in UiApp
>
> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> index 8e2f720666ea..a39c20be3d34 100644
> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> @@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
>EFI_SIMPLE_NETWORK_MODE SnpModeData;
>EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
>EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
> - EFI_HANDLE *SnpHandle;
> + EFI_HANDLE SnpHandle;
>EFI_HANDLE MnpChildHandle;
>
>ASSERT (MacAddress != NULL);
> --
> 2.19.1.3.g30247aa5d201
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this
> group.
>
> View/Reply Online (#47405):
> https://edk2.groups.io/g/devel/message/47405
> Mute This Topic: https://groups.io/mt/34180219/1643496
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [michael.d.kin...@intel.com]
> -=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48505): https://edk2.groups.io/g/devel/message/48505
Mute This Topic: https://groups.io/mt/34180219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()
Ping
On 10/03/19 13:05, Laszlo Ersek wrote:
> Pinging NetworkPkg maintainers again. Please?
>
> Thanks
> Laszlo
>
> On 09/26/19 14:14, Laszlo Ersek wrote:
>> Jiaxin, Siyuan,
>>
>> can you please review this patch?
>>
>> Thanks
>> Laszlo
>>
>> On 09/17/19 21:49, Laszlo Ersek wrote:
>>> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
>>> NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
>>> NULL-check. Fix the type of "SnpHandle".
>>>
>>> This patch is a no-op.
>>>
>>> Cc: Jiaxin Wu
>>> Cc: Siyuan Fu
>>> Signed-off-by: Laszlo Ersek
>>> ---
>>>
>>> Notes:
>>> lightly tested: MAC strings are displayed in UiApp
>>>
>>> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> index 8e2f720666ea..a39c20be3d34 100644
>>> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> @@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
>>>EFI_SIMPLE_NETWORK_MODE SnpModeData;
>>>EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
>>>EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
>>> - EFI_HANDLE *SnpHandle;
>>> + EFI_HANDLE SnpHandle;
>>>EFI_HANDLE MnpChildHandle;
>>>
>>>ASSERT (MacAddress != NULL);
>>>
>>
>>
>>
>>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48486): https://edk2.groups.io/g/devel/message/48486
Mute This Topic: https://groups.io/mt/34180219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()
Pinging NetworkPkg maintainers again. Please?
Thanks
Laszlo
On 09/26/19 14:14, Laszlo Ersek wrote:
> Jiaxin, Siyuan,
>
> can you please review this patch?
>
> Thanks
> Laszlo
>
> On 09/17/19 21:49, Laszlo Ersek wrote:
>> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
>> NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
>> NULL-check. Fix the type of "SnpHandle".
>>
>> This patch is a no-op.
>>
>> Cc: Jiaxin Wu
>> Cc: Siyuan Fu
>> Signed-off-by: Laszlo Ersek
>> ---
>>
>> Notes:
>> lightly tested: MAC strings are displayed in UiApp
>>
>> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>> index 8e2f720666ea..a39c20be3d34 100644
>> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>> @@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
>>EFI_SIMPLE_NETWORK_MODE SnpModeData;
>>EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
>>EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
>> - EFI_HANDLE *SnpHandle;
>> + EFI_HANDLE SnpHandle;
>>EFI_HANDLE MnpChildHandle;
>>
>>ASSERT (MacAddress != NULL);
>>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48430): https://edk2.groups.io/g/devel/message/48430
Mute This Topic: https://groups.io/mt/34180219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()
Jiaxin, Siyuan,
can you please review this patch?
Thanks
Laszlo
On 09/17/19 21:49, Laszlo Ersek wrote:
> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
> NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
> NULL-check. Fix the type of "SnpHandle".
>
> This patch is a no-op.
>
> Cc: Jiaxin Wu
> Cc: Siyuan Fu
> Signed-off-by: Laszlo Ersek
> ---
>
> Notes:
> lightly tested: MAC strings are displayed in UiApp
>
> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> index 8e2f720666ea..a39c20be3d34 100644
> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> @@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
>EFI_SIMPLE_NETWORK_MODE SnpModeData;
>EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
>EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
> - EFI_HANDLE *SnpHandle;
> + EFI_HANDLE SnpHandle;
>EFI_HANDLE MnpChildHandle;
>
>ASSERT (MacAddress != NULL);
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48095): https://edk2.groups.io/g/devel/message/48095
Mute This Topic: https://groups.io/mt/34180219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
> NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
> NULL-check. Fix the type of "SnpHandle".
>
> This patch is a no-op.
>
> Cc: Jiaxin Wu
> Cc: Siyuan Fu
> Signed-off-by: Laszlo Ersek
> ---
>
> Notes:
> lightly tested: MAC strings are displayed in UiApp
>
> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> index 8e2f720666ea..a39c20be3d34 100644
> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> @@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
>EFI_SIMPLE_NETWORK_MODE SnpModeData;
>EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
>EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
> - EFI_HANDLE *SnpHandle;
> + EFI_HANDLE SnpHandle;
>EFI_HANDLE MnpChildHandle;
>
>ASSERT (MacAddress != NULL);
>
Since SnpHandle is only checked for being non-null, this change is
indeed a no-op, else it would probably fixed some bug.
Reviewed-by: Philippe Mathieu-Daude
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47922): https://edk2.groups.io/g/devel/message/47922
Mute This Topic: https://groups.io/mt/34180219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()
NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
NULL-check. Fix the type of "SnpHandle".
This patch is a no-op.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Laszlo Ersek
---
Notes:
lightly tested: MAC strings are displayed in UiApp
NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
index 8e2f720666ea..a39c20be3d34 100644
--- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
+++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
@@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
EFI_SIMPLE_NETWORK_MODE SnpModeData;
EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
- EFI_HANDLE *SnpHandle;
+ EFI_HANDLE SnpHandle;
EFI_HANDLE MnpChildHandle;
ASSERT (MacAddress != NULL);
--
2.19.1.3.g30247aa5d201
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47405): https://edk2.groups.io/g/devel/message/47405
Mute This Topic: https://groups.io/mt/34180219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
