Re: [edk2-devel] [PATCH 35/43] OvmfPkg/PciHostBridgeLibScan: clean up file names and file-top comments

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/26/21 10:14 PM, Laszlo Ersek wrote:
> Rename "XenSupport.c" to "ScanForRootBridges.c", after the main function
> in it.
> 
> Update the file-top comments; refer to both Bhyve and Xen.
> 
> Cc: Anthony Perard 
> Cc: Ard Biesheuvel 
> Cc: Jordan Justen 
> Cc: Julien Grall 
> Cc: Peter Grehan 
> Cc: Philippe Mathieu-Daudé 
> Cc: Rebecca Cran 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> Signed-off-by: Laszlo Ersek 
> ---
>  OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf   
> | 4 ++--
>  OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridge.h
> | 3 ++-
>  OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLib.c 
> | 2 +-
>  OvmfPkg/Library/PciHostBridgeLibScan/{XenSupport.c => ScanForRootBridges.c} 
> | 2 +-
>  4 files changed, 6 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daude 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75775): https://edk2.groups.io/g/devel/message/75775
Mute This Topic: https://groups.io/mt/83111054/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH 35/43] OvmfPkg/PciHostBridgeLibScan: clean up file names and file-top comments

2021-05-26 Thread Laszlo Ersek
Rename "XenSupport.c" to "ScanForRootBridges.c", after the main function
in it.

Update the file-top comments; refer to both Bhyve and Xen.

Cc: Anthony Perard 
Cc: Ard Biesheuvel 
Cc: Jordan Justen 
Cc: Julien Grall 
Cc: Peter Grehan 
Cc: Philippe Mathieu-Daudé 
Cc: Rebecca Cran 
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Signed-off-by: Laszlo Ersek 
---
 OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf   | 
4 ++--
 OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridge.h| 
3 ++-
 OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLib.c | 
2 +-
 OvmfPkg/Library/PciHostBridgeLibScan/{XenSupport.c => ScanForRootBridges.c} | 
2 +-
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf 
b/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf
index 199db4cbbd19..a2ac5f93d193 100644
--- a/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf
+++ b/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf
@@ -1,8 +1,8 @@
 ## @file
-#  OVMF's instance of the PCI Host Bridge Library.
+#  OVMF's instance of the PCI Host Bridge Library, for Bhyve and Xen guests.
 #
 #  Copyright (C) 2016-2021, Red Hat, Inc.
 #  Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -24,13 +24,13 @@ [Defines]
 #  VALID_ARCHITECTURES   = IA32 X64 EBC
 #
 
 [Sources]
   PciHostBridge.h
   PciHostBridgeLib.c
-  XenSupport.c
+  ScanForRootBridges.c
 
 [Packages]
   MdeModulePkg/MdeModulePkg.dec
   MdePkg/MdePkg.dec
   OvmfPkg/OvmfPkg.dec
 
diff --git a/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridge.h 
b/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridge.h
index 582b7929aff2..cb05220161d7 100644
--- a/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridge.h
+++ b/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridge.h
@@ -1,8 +1,9 @@
 /** @file
-  Header file of OVMF instance of PciHostBridgeLib.
+  OVMF's instance of the PCI Host Bridge Library, for Bhyve and Xen guests;
+  internal declarations.
 
   Copyright (C) 2021, Red Hat, Inc.
   Copyright (c) 2016, Intel Corporation. All rights reserved.
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
diff --git a/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLib.c 
b/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLib.c
index f0166e0f7279..ac8d1033df24 100644
--- a/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLib.c
+++ b/OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLib.c
@@ -1,8 +1,8 @@
 /** @file
-  OVMF's instance of the PCI Host Bridge Library.
+  OVMF's instance of the PCI Host Bridge Library, for Bhyve and Xen guests.
 
   Copyright (C) 2016-2021, Red Hat, Inc.
   Copyright (c) 2016, Intel Corporation. All rights reserved.
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
diff --git a/OvmfPkg/Library/PciHostBridgeLibScan/XenSupport.c 
b/OvmfPkg/Library/PciHostBridgeLibScan/ScanForRootBridges.c
similarity index 96%
rename from OvmfPkg/Library/PciHostBridgeLibScan/XenSupport.c
rename to OvmfPkg/Library/PciHostBridgeLibScan/ScanForRootBridges.c
index edf993e82dcc..a6126a1aea52 100644
--- a/OvmfPkg/Library/PciHostBridgeLibScan/XenSupport.c
+++ b/OvmfPkg/Library/PciHostBridgeLibScan/ScanForRootBridges.c
@@ -1,8 +1,8 @@
 /** @file
-  Scan the entire PCI bus for root bridges to support OVMF above Xen.
+  Scan the entire PCI bus for root bridges to support OVMF on Bhyve and Xen.
 
   Copyright (C) 2021, Red Hat, Inc.
   Copyright (c) 2016, Intel Corporation. All rights reserved.
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
-- 
2.19.1.3.g30247aa5d201




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75706): https://edk2.groups.io/g/devel/message/75706
Mute This Topic: https://groups.io/mt/83111054/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-