Re: [edk2-devel] [PATCH V2 00/32] Introduce AMD Vangogh platform reference code

2024-01-26 Thread Chang, Abner via groups.io 
Hi Duke,
Besides the AMD copyright is put in an improper place. I also found that there 
are several #include guards that don't follow edk2 C coding standard. There are 
several trailing underscores (like four underscores) attached to the macro. 
Please just put one trailing underscore as "INCLUDE_GUARD_".

Please send out V3 with the fixes.
Thanks
Abenr


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114571): https://edk2.groups.io/g/devel/message/114571
Mute This Topic: https://groups.io/mt/103971387/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH V2 00/32] Introduce AMD Vangogh platform reference code

2024-01-25 Thread Zhai, MingXin (Duke) via groups.io 
From: Duke Zhai 

In V2: Improve coding style.
  1.Remove the leading underscore and use double underscore at trailing in C 
header files.
  2.Remove old tianocore licenses and redundant license description.
  3.Improve coding style. For example: remove space between @param.

In V1:
  This AMD reference platform BIOS supports AMD Vangogh B0 SOC and Chachani 
board.

Duke Zhai (32):
  AMD/AmdPlatformPkg: Check in AMD S3 logo
  AMD/VanGoghBoard: Check in ACPI tables
  AMD/VanGoghBoard: Check in Capsule update
  AMD/VanGoghBoard: Check in AgesaPublic pkg
  AMD/VanGoghBoard: Check in PlatformSecLib
  AMD/VanGoghBoard: Check in AmdIdsExtLib
  AMD/VanGoghBoard: Check in PciPlatform
  AMD/VanGoghBoard: Check in UDKFlashUpdate
  AMD/VanGoghBoard: Check in Flash_AB
  AMD/VanGoghBoard: Check in FlashUpdate
  AMD/VanGoghBoard: Check in FvbServices
  AMD/VanGoghBoard: Check in AMD BaseSerialPortLib
  AMD/VanGoghBoard: Check in PlatformFlashAccessLib
  AMD/VanGoghBoard: Check in SmbiosLib
  AMD/VanGoghBoard: Check in SpiFlashDeviceLib
  AMD/VanGoghBoard: Check in BaseTscTimerLib
  AMD/VanGoghBoard: Check in Smm access module
  AMD/VanGoghBoard: Check in PciHostBridge module
  AMD/VanGoghBoard: Check in PcatRealTimeClockRuntimeDxe  module
  AMD/VanGoghBoard: Check in FTPM module
  AMD/VanGoghBoard: Check in SignedCapsule
  AMD/VanGoghBoard: Check in Vtf0
  AMD/VanGoghBoard: Check in AcpiPlatform
  AMD/VanGoghBoard: Check in FchSpi module
  AMD/VanGoghBoard: Check in PlatformInitPei module
  AMD/VanGoghBoard: Check in Smbios platform dxe drivers
  AMD/VanGoghBoard: Check in Fsp2WrapperPkg
  AMD/VanGoghBoard: Check in SmmCpuFeaturesLibCommon  module
  AMD/VanGoghBoard: Check in SmramSaveState module
  AMD/VanGoghBoard: Check in EDK2 override files
  AMD/VanGoghBoard: Check in AMD SmmControlPei module
  AMD/VanGoghBoard: Check in Chachani board project files  and build
script

 .../AmdPlatformPkg/Universal/LogoDxe/Logo.c   |  198 +
 .../Universal/LogoDxe/S3Logo.bmp  |  Bin 0 -> 964114 bytes
 .../Universal/LogoDxe/S3Logo.idf  |9 +
 .../Universal/LogoDxe/S3LogoDxe.inf   |   55 +
 .../VanGoghBoard/AgesaPublic/AgesaPublic.dec  |   61 +
 .../VanGoghBoard/AgesaPublic/Include/AGESA.h  |   35 +
 .../VanGoghBoard/AgesaPublic/Include/AMD.h|  189 +
 .../AgesaPublic/Include/AmdPspDirectory.h |   55 +
 .../AgesaPublic/Include/FchRegistersCommon.h  |   23 +
 .../Include/Guid/AmdMemoryInfoHob.h   |   51 +
 .../Include/Library/AmdPspBaseLibV2.h |  248 +
 .../Include/Library/AmdPspCommonLib.h |   29 +
 .../Include/Library/AmdPspFtpmLib.h   |   94 +
 .../AgesaPublic/Include/Ppi/AmdPspFtpmPpi.h   |   80 +
 .../Include/Protocol/AmdPspFtpmProtocol.h |  112 +
 .../Acpi/AcpiTables/AcpiTables.inf|   33 +
 .../Acpi/AcpiTables/Dsdt/CPU.asl  |   22 +
 .../Acpi/AcpiTables/Dsdt/Dsdt.asl |   36 +
 .../Acpi/AcpiTables/Dsdt/FchShang.asi |  927 ++
 .../Acpi/AcpiTables/Dsdt/GloblNvs.asl |   17 +
 .../Acpi/AcpiTables/Dsdt/HOST_BUS.ASL |  209 +
 .../Acpi/AcpiTables/Dsdt/LINK.ASL |  481 ++
 .../Acpi/AcpiTables/Dsdt/Lpc0.asl |  168 +
 .../Acpi/AcpiTables/Dsdt/PciTree.asl  |  776 ++
 .../Acpi/AcpiTables/Dsdt/Platform.asl |  135 +
 .../Acpi/AcpiTables/Dsdt/_PR.asl  |   36 +
 .../Acpi/AcpiTables/Facs/Facs.h   |   31 +
 .../Acpi/AcpiTables/Facs/Facs50.aslc  |   68 +
 .../Acpi/AcpiTables/Fadt/Fadt.h   |   64 +
 .../Acpi/AcpiTables/Fadt/Fadt50.aslc  |  159 +
 .../Acpi/AcpiTables/Hpet/Hpet.h   |   70 +
 .../Acpi/AcpiTables/Hpet/Hpet50.aslc  |   58 +
 .../Acpi/AcpiTables/Madt/Madt.h   |  114 +
 .../Acpi/AcpiTables/Madt/Madt50.aslc  |  327 +
 .../Acpi/AcpiTables/Mcfg/Mcfg.h   |   61 +
 .../Acpi/AcpiTables/Mcfg/Mcfg50.aslc  |   61 +
 .../BIOSImageDirectory32M.xml |   63 +
 .../VanGoghBoard/ChachaniBoardPkg/Board.env   |   23 +
 .../ChachaniBoardPkg/BuildPspImage.bat|  126 +
 .../SystemFirmwareDescriptor.aslc |   85 +
 .../SystemFirmwareDescriptor.inf  |   39 +
 .../SystemFirmwareDescriptorPei.c |   64 +
 .../ChachaniBoardPkg/Conf/ReadMe.txt  |   14 +
 .../ChachaniBoardPkg/Conf/build_rule.txt  |  654 ++
 .../ChachaniBoardPkg/Conf/target.txt  |   73 +
 .../ChachaniBoardPkg/Conf/tools_def.txt   | 7571 +
 .../ChachaniBoardPkg/FlashABImage32M.py   |  102 +
 .../ChachaniBoardPkg/GenCapsule.bat   |   81 +
 .../ChachaniBoardPkg/GenFlashABImage.bat  |   39 +
 .../ChachaniBoardPkg/GoZ_ChachaniExt.bat  |   81 +
 .../Include/Library/CapsuleHookLib.h  |   40 +
 .../Include/Protocol/GlobalNvsArea.h  |   63 +
 .../AmdIdsExtLibNull/AmdIdsHookExtLibNull.c   |   33 +
 .../AmdIdsExtLibNull/AmdIdsHookExtLibNull.inf |   39 +