Re: [edk2-devel] [PATCH v1] UefiCpuPkg/Library: Support to get processor extended info

2024-04-29 Thread Wu, Jiaxin 
Thanks Ray, please help add the push label for the PR: 
https://github.com/tianocore/edk2/pull/5608


From: Ni, Ray 
Sent: Tuesday, April 30, 2024 1:33 PM
To: Wu, Jiaxin ; devel@edk2.groups.io
Cc: Zeng, Star ; Gerd Hoffmann ; Kumar, 
Rahul R 
Subject: Re: [PATCH v1] UefiCpuPkg/Library: Support to get processor extended 
info

Reviewed-by: Ray Ni mailto:ray...@intel.com>>

Thanks,
Ray


From: Wu, Jiaxin mailto:jiaxin...@intel.com>>
Sent: Tuesday, April 30, 2024 11:33
To: devel@edk2.groups.io 
mailto:devel@edk2.groups.io>>
Cc: Ni, Ray mailto:ray...@intel.com>>; Zeng, Star 
mailto:star.z...@intel.com>>; Gerd Hoffmann 
mailto:kra...@redhat.com>>; Kumar, Rahul R 
mailto:rahul.r.ku...@intel.com>>
Subject: [PATCH v1] UefiCpuPkg/Library: Support to get processor extended info

Intel has some features need to use processor extended
information under CPU feature InitializeFunc(), so add code
to support it: This patch is to add CPU_V2_EXTENDED_TOPOLOGY
to get processor extended info.

Cc: Ray Ni mailto:ray...@intel.com>>
Cc: Zeng Star mailto:star.z...@intel.com>>
Cc: Gerd Hoffmann mailto:kra...@redhat.com>>
Cc: Rahul Kumar mailto:rahul1.ku...@intel.com>>
Signed-off-by: Jiaxin Wu mailto:jiaxin...@intel.com>>
---
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c | 4 ++--
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
index e635cade5d..d799b7f5d1 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
@@ -1,9 +1,9 @@
 /** @file
   CPU Register Table Library functions.

-  Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
+  Copyright (c) 2017 - 2024, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent

 **/

 #include 
@@ -99,11 +99,11 @@ GetProcessorInformation (
   CpuFeaturesData = GetCpuFeaturesData ();
   MpServices  = CpuFeaturesData->MpService.Protocol;

   Status = MpServices->GetProcessorInfo (
  MpServices,
- ProcessorNumber,
+ ProcessorNumber | CPU_V2_EXTENDED_TOPOLOGY,
  ProcessorInfoBuffer
  );
   return Status;
 }

diff --git 
a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
index d4c528b3e9..1db6adc280 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
@@ -1,9 +1,9 @@
 /** @file
   CPU Register Table Library functions.

-  Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
+  Copyright (c) 2016 - 2024, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent

 **/

 #include 
@@ -137,11 +137,11 @@ GetProcessorInformation (
   CpuFeaturesData = GetCpuFeaturesData ();
   CpuMp2Ppi   = CpuFeaturesData->MpService.Ppi;

   Status = CpuMp2Ppi->GetProcessorInfo (
 CpuMp2Ppi,
-ProcessorNumber,
+ProcessorNumber | CPU_V2_EXTENDED_TOPOLOGY,
 ProcessorInfoBuffer
 );
   return Status;
 }

--
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118409): https://edk2.groups.io/g/devel/message/118409
Mute This Topic: https://groups.io/mt/105815222/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/Library: Support to get processor extended info

2024-04-29 Thread Ni, Ray 
Reviewed-by: Ray Ni 

Thanks,
Ray


From: Wu, Jiaxin 
Sent: Tuesday, April 30, 2024 11:33
To: devel@edk2.groups.io 
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann 
; Kumar, Rahul R 
Subject: [PATCH v1] UefiCpuPkg/Library: Support to get processor extended info

Intel has some features need to use processor extended
information under CPU feature InitializeFunc(), so add code
to support it: This patch is to add CPU_V2_EXTENDED_TOPOLOGY
to get processor extended info.

Cc: Ray Ni 
Cc: Zeng Star 
Cc: Gerd Hoffmann 
Cc: Rahul Kumar 
Signed-off-by: Jiaxin Wu 
---
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c | 4 ++--
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
index e635cade5d..d799b7f5d1 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
@@ -1,9 +1,9 @@
 /** @file
   CPU Register Table Library functions.

-  Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
+  Copyright (c) 2017 - 2024, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent

 **/

 #include 
@@ -99,11 +99,11 @@ GetProcessorInformation (
   CpuFeaturesData = GetCpuFeaturesData ();
   MpServices  = CpuFeaturesData->MpService.Protocol;

   Status = MpServices->GetProcessorInfo (
  MpServices,
- ProcessorNumber,
+ ProcessorNumber | CPU_V2_EXTENDED_TOPOLOGY,
  ProcessorInfoBuffer
  );
   return Status;
 }

diff --git 
a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
index d4c528b3e9..1db6adc280 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
@@ -1,9 +1,9 @@
 /** @file
   CPU Register Table Library functions.

-  Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
+  Copyright (c) 2016 - 2024, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent

 **/

 #include 
@@ -137,11 +137,11 @@ GetProcessorInformation (
   CpuFeaturesData = GetCpuFeaturesData ();
   CpuMp2Ppi   = CpuFeaturesData->MpService.Ppi;

   Status = CpuMp2Ppi->GetProcessorInfo (
 CpuMp2Ppi,
-ProcessorNumber,
+ProcessorNumber | CPU_V2_EXTENDED_TOPOLOGY,
 ProcessorInfoBuffer
 );
   return Status;
 }

--
2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118405): https://edk2.groups.io/g/devel/message/118405
Mute This Topic: https://groups.io/mt/105815222/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v1] UefiCpuPkg/Library: Support to get processor extended info

2024-04-29 Thread Wu, Jiaxin 
Intel has some features need to use processor extended
information under CPU feature InitializeFunc(), so add code
to support it: This patch is to add CPU_V2_EXTENDED_TOPOLOGY
to get processor extended info.

Cc: Ray Ni 
Cc: Zeng Star 
Cc: Gerd Hoffmann 
Cc: Rahul Kumar 
Signed-off-by: Jiaxin Wu 
---
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c | 4 ++--
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
index e635cade5d..d799b7f5d1 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
@@ -1,9 +1,9 @@
 /** @file
   CPU Register Table Library functions.
 
-  Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
+  Copyright (c) 2017 - 2024, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
 
 #include 
@@ -99,11 +99,11 @@ GetProcessorInformation (
   CpuFeaturesData = GetCpuFeaturesData ();
   MpServices  = CpuFeaturesData->MpService.Protocol;
 
   Status = MpServices->GetProcessorInfo (
  MpServices,
- ProcessorNumber,
+ ProcessorNumber | CPU_V2_EXTENDED_TOPOLOGY,
  ProcessorInfoBuffer
  );
   return Status;
 }
 
diff --git 
a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
index d4c528b3e9..1db6adc280 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
@@ -1,9 +1,9 @@
 /** @file
   CPU Register Table Library functions.
 
-  Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
+  Copyright (c) 2016 - 2024, Intel Corporation. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
 
 #include 
@@ -137,11 +137,11 @@ GetProcessorInformation (
   CpuFeaturesData = GetCpuFeaturesData ();
   CpuMp2Ppi   = CpuFeaturesData->MpService.Ppi;
 
   Status = CpuMp2Ppi->GetProcessorInfo (
 CpuMp2Ppi,
-ProcessorNumber,
+ProcessorNumber | CPU_V2_EXTENDED_TOPOLOGY,
 ProcessorInfoBuffer
 );
   return Status;
 }
 
-- 
2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118404): https://edk2.groups.io/g/devel/message/118404
Mute This Topic: https://groups.io/mt/105815222/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-