Re: [edk2-devel] [PATCH v2 0/3] UefiCpuPkg/ResetVector: Remove pre-built binaries
Reviewed-by: Eric Dong -Original Message- From: Ni, Ray Sent: Wednesday, June 21, 2023 2:01 PM To: Liu, Zhiguang ; Dong, Eric Cc: devel@edk2.groups.io; Ni, Ray Subject: RE: [edk2-devel] [PATCH v2 0/3] UefiCpuPkg/ResetVector: Remove pre-built binaries I updated the patch per Zhiguang's comments to remove ALIGN 16 requirement. Can you please review again? Only the 2nd patch is updated. Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, June 21, 2023 10:55 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v2 0/3] UefiCpuPkg/ResetVector: Remove > pre- built binaries > > Ray Ni (3): > UefiCpuPkg: Include ResetVector in DSC > UefiCpuPkg/ResetVector: Add guidance of FDF ffs rule > UefiCpuPkg/ResetVector: Remove pre-built binaries > > .../Vtf0/Bin/IA32/ResetVector.ia32.port80.raw | Bin 532 -> 0 bytes > .../Vtf0/Bin/IA32/ResetVector.ia32.raw| Bin 500 -> 0 bytes > .../Vtf0/Bin/IA32/ResetVector.ia32.serial.raw | Bin 900 -> 0 bytes > .../ResetVector/Vtf0/Bin/ResetVector.inf | 31 -- > .../ResetVector/Vtf0/Bin/ResetVector.uni | 16 > .../ResetVector/Vtf0/Bin/ResetVector1G.inf| 31 -- > .../ResetVector/Vtf0/Bin/ResetVectorExtra.uni | 12 --- > .../PageTable1G/ResetVector.x64.port80.raw| Bin 12292 -> 0 bytes > .../Bin/X64/PageTable1G/ResetVector.x64.raw | Bin 12292 -> 0 bytes > .../PageTable1G/ResetVector.x64.serial.raw| Bin 12292 -> 0 bytes > .../PageTable2M/ResetVector.x64.port80.raw| Bin 28676 -> 0 bytes > .../Bin/X64/PageTable2M/ResetVector.x64.raw | Bin 28676 -> 0 bytes > .../PageTable2M/ResetVector.x64.serial.raw| Bin 28676 -> 0 bytes > UefiCpuPkg/ResetVector/Vtf0/Build.py | 89 -- > UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt| 27 ++ > .../Vtf0/Tools/FixupForRawSection.py | 20 > UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf | 28 +- > UefiCpuPkg/UefiCpuPkg.dsc | 4 +- > 18 files changed, 36 insertions(+), 222 deletions(-) delete mode > 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/IA32/ResetVector.ia32.port80.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/IA32/ResetVector.ia32.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/IA32/ResetVector.ia32.serial.raw > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.uni > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector1G.inf > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVectorExtra.uni > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable1G/ResetVector.x64.port80 > .raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable1G/ResetVector.x64.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable1G/ResetVector.x64.serial > .r > aw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable2M/ResetVector.x64.port8 > 0.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable2M/ResetVector.x64.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable2M/ResetVector.x64.serial > .r > aw > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Build.py > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Tools/FixupForRawSection.py > > -- > 2.39.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106283): https://edk2.groups.io/g/devel/message/106283 Mute This Topic: https://groups.io/mt/99669680/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/3] UefiCpuPkg/ResetVector: Remove pre-built binaries
I updated the patch per Zhiguang's comments to remove ALIGN 16 requirement. Can you please review again? Only the 2nd patch is updated. Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, June 21, 2023 10:55 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v2 0/3] UefiCpuPkg/ResetVector: Remove pre- > built binaries > > Ray Ni (3): > UefiCpuPkg: Include ResetVector in DSC > UefiCpuPkg/ResetVector: Add guidance of FDF ffs rule > UefiCpuPkg/ResetVector: Remove pre-built binaries > > .../Vtf0/Bin/IA32/ResetVector.ia32.port80.raw | Bin 532 -> 0 bytes > .../Vtf0/Bin/IA32/ResetVector.ia32.raw| Bin 500 -> 0 bytes > .../Vtf0/Bin/IA32/ResetVector.ia32.serial.raw | Bin 900 -> 0 bytes > .../ResetVector/Vtf0/Bin/ResetVector.inf | 31 -- > .../ResetVector/Vtf0/Bin/ResetVector.uni | 16 > .../ResetVector/Vtf0/Bin/ResetVector1G.inf| 31 -- > .../ResetVector/Vtf0/Bin/ResetVectorExtra.uni | 12 --- > .../PageTable1G/ResetVector.x64.port80.raw| Bin 12292 -> 0 bytes > .../Bin/X64/PageTable1G/ResetVector.x64.raw | Bin 12292 -> 0 bytes > .../PageTable1G/ResetVector.x64.serial.raw| Bin 12292 -> 0 bytes > .../PageTable2M/ResetVector.x64.port80.raw| Bin 28676 -> 0 bytes > .../Bin/X64/PageTable2M/ResetVector.x64.raw | Bin 28676 -> 0 bytes > .../PageTable2M/ResetVector.x64.serial.raw| Bin 28676 -> 0 bytes > UefiCpuPkg/ResetVector/Vtf0/Build.py | 89 -- > UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt| 27 ++ > .../Vtf0/Tools/FixupForRawSection.py | 20 > UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf | 28 +- > UefiCpuPkg/UefiCpuPkg.dsc | 4 +- > 18 files changed, 36 insertions(+), 222 deletions(-) > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/IA32/ResetVector.ia32.port80.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/IA32/ResetVector.ia32.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/IA32/ResetVector.ia32.serial.raw > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.uni > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector1G.inf > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVectorExtra.uni > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable1G/ResetVector.x64.port80 > .raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable1G/ResetVector.x64.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable1G/ResetVector.x64.serial.r > aw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable2M/ResetVector.x64.port8 > 0.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable2M/ResetVector.x64.raw > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable2M/ResetVector.x64.serial.r > aw > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Build.py > delete mode 100644 > UefiCpuPkg/ResetVector/Vtf0/Tools/FixupForRawSection.py > > -- > 2.39.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106242): https://edk2.groups.io/g/devel/message/106242 Mute This Topic: https://groups.io/mt/99669680/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 0/3] UefiCpuPkg/ResetVector: Remove pre-built binaries
Ray Ni (3): UefiCpuPkg: Include ResetVector in DSC UefiCpuPkg/ResetVector: Add guidance of FDF ffs rule UefiCpuPkg/ResetVector: Remove pre-built binaries .../Vtf0/Bin/IA32/ResetVector.ia32.port80.raw | Bin 532 -> 0 bytes .../Vtf0/Bin/IA32/ResetVector.ia32.raw| Bin 500 -> 0 bytes .../Vtf0/Bin/IA32/ResetVector.ia32.serial.raw | Bin 900 -> 0 bytes .../ResetVector/Vtf0/Bin/ResetVector.inf | 31 -- .../ResetVector/Vtf0/Bin/ResetVector.uni | 16 .../ResetVector/Vtf0/Bin/ResetVector1G.inf| 31 -- .../ResetVector/Vtf0/Bin/ResetVectorExtra.uni | 12 --- .../PageTable1G/ResetVector.x64.port80.raw| Bin 12292 -> 0 bytes .../Bin/X64/PageTable1G/ResetVector.x64.raw | Bin 12292 -> 0 bytes .../PageTable1G/ResetVector.x64.serial.raw| Bin 12292 -> 0 bytes .../PageTable2M/ResetVector.x64.port80.raw| Bin 28676 -> 0 bytes .../Bin/X64/PageTable2M/ResetVector.x64.raw | Bin 28676 -> 0 bytes .../PageTable2M/ResetVector.x64.serial.raw| Bin 28676 -> 0 bytes UefiCpuPkg/ResetVector/Vtf0/Build.py | 89 -- UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt| 27 ++ .../Vtf0/Tools/FixupForRawSection.py | 20 UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf | 28 +- UefiCpuPkg/UefiCpuPkg.dsc | 4 +- 18 files changed, 36 insertions(+), 222 deletions(-) delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/IA32/ResetVector.ia32.port80.raw delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/IA32/ResetVector.ia32.raw delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/IA32/ResetVector.ia32.serial.raw delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.uni delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector1G.inf delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVectorExtra.uni delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable1G/ResetVector.x64.port80.raw delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable1G/ResetVector.x64.raw delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable1G/ResetVector.x64.serial.raw delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable2M/ResetVector.x64.port80.raw delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable2M/ResetVector.x64.raw delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Bin/X64/PageTable2M/ResetVector.x64.serial.raw delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Build.py delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Tools/FixupForRawSection.py -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106233): https://edk2.groups.io/g/devel/message/106233 Mute This Topic: https://groups.io/mt/99669680/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-