Re: [edk2-devel] [PATCH v6 19/52] TigerlakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

2021-10-28 Thread Heng Luo
Reviewed-by: Heng Luo 

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Michael
> Kubacki
> Sent: Friday, October 29, 2021 4:43 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Desimone,
> Nathaniel L ; Luo, Heng 
> Subject: [edk2-devel] [PATCH v6 19/52] TigerlakeSiliconPkg: Use 
> IntelSiliconPkg
> BIOS area and ucode PCDs
> 
> From: Michael Kubacki 
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
> 
> Removes the PCDs from SiPkg.dec since they are defined in IntelSiliconPkg.dec.
> 
> Cc: Sai Chaganty 
> Cc: Nate DeSimone 
> Cc: Heng Luo 
> Signed-off-by: Michael Kubacki 
> Reviewed-by: Nate DeSimone 
> ---
>  Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec | 5 -
>  1 file changed, 5 deletions(-)
> 
> diff --git a/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
> b/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
> index 0c0f2db1048d..37f61cc5ee18 100644
> --- a/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
> +++ b/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
> @@ -837,15 +837,10 @@ [PcdsFixedAtBuild]  ## NOTE: The size restriction may
> be changed in next generation processor.
>  ## Please refer to Processor BWG for detail.
>  ##
> -
> gSiPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF80|UINT32|0x1
> 001
> -gSiPkgTokenSpaceGuid.PcdBiosSize|0x0080|UINT32|0x1002
> 
> gSiPkgTokenSpaceGuid.PcdTemporaryRamBase|0xfef0|UINT32|0x000100
> 28
>  gSiPkgTokenSpaceGuid.PcdTemporaryRamSize|0x2000|UINT32|0x00010029
>  gSiPkgTokenSpaceGuid.PcdTopMemoryCacheSize|0x0|UINT32|0x0001002A
> -
> gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE6|UINT32|0x3000
> 0004
> -
> gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A|UINT32|0x3000
> 0005
> 
> gSiPkgTokenSpaceGuid.PcdFlashMicrocodeOffset|0x0060|UINT32|0x3000
> 0013
> -
> gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x0066|UINT32|0x30
> 06
>  ##
>  ## The CPU Trace Hub's BARs base and size  ##
> --
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#82838): https://edk2.groups.io/g/devel/message/82838
> Mute This Topic: https://groups.io/mt/86662304/3906523
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [heng@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82898): https://edk2.groups.io/g/devel/message/82898
Mute This Topic: https://groups.io/mt/86662304/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH v6 19/52] TigerlakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

2021-10-28 Thread Michael Kubacki
From: Michael Kubacki 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307

Removes the PCDs from SiPkg.dec since they are defined in
IntelSiliconPkg.dec.

Cc: Sai Chaganty 
Cc: Nate DeSimone 
Cc: Heng Luo 
Signed-off-by: Michael Kubacki 
Reviewed-by: Nate DeSimone 
---
 Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec | 5 -
 1 file changed, 5 deletions(-)

diff --git a/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec 
b/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
index 0c0f2db1048d..37f61cc5ee18 100644
--- a/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
+++ b/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec
@@ -837,15 +837,10 @@ [PcdsFixedAtBuild]
 ## NOTE: The size restriction may be changed in next generation processor.
 ## Please refer to Processor BWG for detail.
 ##
-gSiPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF80|UINT32|0x1001
-gSiPkgTokenSpaceGuid.PcdBiosSize|0x0080|UINT32|0x1002
 gSiPkgTokenSpaceGuid.PcdTemporaryRamBase|0xfef0|UINT32|0x00010028
 gSiPkgTokenSpaceGuid.PcdTemporaryRamSize|0x2000|UINT32|0x00010029
 gSiPkgTokenSpaceGuid.PcdTopMemoryCacheSize|0x0|UINT32|0x0001002A
-gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE6|UINT32|0x3004
-gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A|UINT32|0x3005
 gSiPkgTokenSpaceGuid.PcdFlashMicrocodeOffset|0x0060|UINT32|0x3013
-gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x0066|UINT32|0x3006
 ##
 ## The CPU Trace Hub's BARs base and size
 ##
-- 
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82838): https://edk2.groups.io/g/devel/message/82838
Mute This Topic: https://groups.io/mt/86662304/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-