Re: [edk2-devel] [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings

2019-04-25 Thread Steele, Kelly



Reviewed-by: Kelly Steele 




> -Original Message-
> From: Kinney, Michael D
> Sent: April 25, 2019 11:59
> To: devel@edk2.groups.io
> Cc: Steele, Kelly 
> Subject: [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings
> 
> Resolve a few warnings from the latest iASL compilers.
> 
> Cc: Kelly Steele 
> Signed-off-by: Michael D Kinney 
> ---
>  QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi | 4 ++--
>  QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl   | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
> b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
> index 979e5b58b1..9a5812d068 100644
> --- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
> +++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
> @@ -1,7 +1,7 @@
>  /** @file
>  Expose GPIO resources to usermode through client driver.
> 
> -Copyright (c) 2013-2015 Intel Corporation.
> +Copyright (c) 2013-2019 Intel Corporation.
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -11,7 +11,7 @@ Device(GPOT)
>  {
>  Name(_HID, "INT349A")
>  Name(_CID, "INT349A")
> -Method(_CRS, 0x0, NotSerialized)
> +Method(_CRS, 0x0, Serialized)
>  {
>  Name(RBUF, ResourceTemplate()
>  {
> diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
> b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
> index 53633dfbe4..35bae8248a 100644
> --- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
> +++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
> @@ -1,7 +1,7 @@
>  /** @file
>  Contains root level name space objects for the platform
> 
> -Copyright (c) 2013-2015 Intel Corporation.
> +Copyright (c) 2013-2019 Intel Corporation.
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -50,7 +50,7 @@ DefinitionBlock (
>"DSDT",
>1,
>"INTEL ",
> -  "QuarkNcSocId",
> +  "QuarkNcS",
>3)
>  {
>  //
> @@ -275,7 +275,7 @@ DefinitionBlock (
>  Method (_INI)
>  {
>  Store(LINUX, OSTP) // Set the default os is 
> Linux
> -If (CondRefOf (_OSI, local0))
> +If (CondRefOf (_OSI))
>  {
>  //
>  //_OSI is supported, so it is WinXp or Win2003Server
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39583): https://edk2.groups.io/g/devel/message/39583
Mute This Topic: https://groups.io/mt/31345792/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[edk2-devel] [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings

2019-04-25 Thread Michael D Kinney
Resolve a few warnings from the latest iASL compilers.

Cc: Kelly Steele 
Signed-off-by: Michael D Kinney 
---
 QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi | 4 ++--
 QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi 
b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
index 979e5b58b1..9a5812d068 100644
--- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
+++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
@@ -1,7 +1,7 @@
 /** @file
 Expose GPIO resources to usermode through client driver.
 
-Copyright (c) 2013-2015 Intel Corporation.
+Copyright (c) 2013-2019 Intel Corporation.
 
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -11,7 +11,7 @@ Device(GPOT)
 {
 Name(_HID, "INT349A")
 Name(_CID, "INT349A")
-Method(_CRS, 0x0, NotSerialized)
+Method(_CRS, 0x0, Serialized)
 {
 Name(RBUF, ResourceTemplate()
 {
diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl 
b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
index 53633dfbe4..35bae8248a 100644
--- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
+++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
@@ -1,7 +1,7 @@
 /** @file
 Contains root level name space objects for the platform
 
-Copyright (c) 2013-2015 Intel Corporation.
+Copyright (c) 2013-2019 Intel Corporation.
 
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -50,7 +50,7 @@ DefinitionBlock (
   "DSDT",
   1,
   "INTEL ",
-  "QuarkNcSocId",
+  "QuarkNcS",
   3)
 {
 //
@@ -275,7 +275,7 @@ DefinitionBlock (
 Method (_INI)
 {
 Store(LINUX, OSTP) // Set the default os is 
Linux
-If (CondRefOf (_OSI, local0))
+If (CondRefOf (_OSI))
 {
 //
 //_OSI is supported, so it is WinXp or Win2003Server
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39576): https://edk2.groups.io/g/devel/message/39576
Mute This Topic: https://groups.io/mt/31345792/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-