Re: [edk2-devel] [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility

[Gerd Hoffmann]

On Fri, May 26, 2023 at 04:17:34PM -0700, Michael D Kinney wrote:
> Move initialization of local variable structure from declaration
> to statements to fix VS2015x86 build break.

Acked-by: Gerd Hoffmann 

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105483): https://edk2.groups.io/g/devel/message/105483
Mute This Topic: https://groups.io/mt/99160001/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility

[Ard Biesheuvel]

On Sat, 27 May 2023 at 01:17, Michael D Kinney
 wrote:
>
> Move initialization of local variable structure from declaration
> to statements to fix VS2015x86 build break.
>
> Cc: Ard Biesheuvel 
> Cc: Jiewen Yao 
> Cc: Jordan Justen 
> Cc: Gerd Hoffmann 
> Signed-off-by: Michael D Kinney 

Reviewed-by: Ard Biesheuvel 

> ---
>  OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c 
> b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
> index bfb2b324eadf..df545c080e9d 100644
> --- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
> +++ b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
> @@ -66,11 +66,11 @@ VirtioSerialTxControl (
>IN UINT16 Value
>)
>  {
> -  VIRTIO_SERIAL_CONTROL  Control = {
> -.Id= Id,
> -.Event = Event,
> -.Value = Value,
> -  };
> +  VIRTIO_SERIAL_CONTROL  Control;
> +
> +  Control.Id= Id;
> +  Control.Event = Event;
> +  Control.Value = Value;
>
>DEBUG ((
>  DEBUG_INFO,
> --
> 2.40.1.windows.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105351): https://edk2.groups.io/g/devel/message/105351
Mute This Topic: https://groups.io/mt/99160001/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility

[Michael D Kinney]

Move initialization of local variable structure from declaration
to statements to fix VS2015x86 build break.

Cc: Ard Biesheuvel 
Cc: Jiewen Yao 
Cc: Jordan Justen 
Cc: Gerd Hoffmann 
Signed-off-by: Michael D Kinney 
---
 OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c 
b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
index bfb2b324eadf..df545c080e9d 100644
--- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
+++ b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
@@ -66,11 +66,11 @@ VirtioSerialTxControl (
   IN UINT16 Value
   )
 {
-  VIRTIO_SERIAL_CONTROL  Control = {
-.Id= Id,
-.Event = Event,
-.Value = Value,
-  };
+  VIRTIO_SERIAL_CONTROL  Control;
+
+  Control.Id= Id;
+  Control.Event = Event;
+  Control.Value = Value;
 
   DEBUG ((
 DEBUG_INFO,
-- 
2.40.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105347): https://edk2.groups.io/g/devel/message/105347
Mute This Topic: https://groups.io/mt/99160001/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-