Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'
Reviewed-by: Chasel Chiu < chasel.c...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38647): https://edk2.groups.io/g/devel/message/38647 Mute This Topic: https://groups.io/mt/30893896/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'
Reviewed-by: Chasel Chiu > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 4, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Chiu, Chasel ; > Kubacki, Michael A > Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] > KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer' > > For KabylakeRvp3, it is using the HPET timer unconditionally. The PCD > 'PcdUseHpetTimer' is not being used. > > This commit will remove the usage of the above PCD in package DSC files. > > Cc: Chasel Chiu > Cc: Michael Kubacki > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.d > sc | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig > .dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig > .dsc > index bb06ff5a2a..f3d082ce41 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig > .dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfi > +++ g.dsc > @@ -1,7 +1,7 @@ > ## @file > # Platform configuration file. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved. > # > # This program and the accompanying materials are licensed and made available > under # the terms and conditions of the BSD License which accompanies this > distribution. > @@ -111,7 +111,6 @@ [PcdsFeatureFlag] >gSiPkgTokenSpaceGuid.PcdSmmVariableEnable|TRUE >gSiPkgTokenSpaceGuid.PcdSoftwareGuardEnable|TRUE >gSiPkgTokenSpaceGuid.PcdSsaFlagEnable|FALSE > - gSiPkgTokenSpaceGuid.PcdUseHpetTimer|TRUE # TRUE - > HPET / FALSE - 8254 timer is used. >gSiPkgTokenSpaceGuid.PcdOcWdtEnable|TRUE >gSiPkgTokenSpaceGuid.PcdSiCatalogDebugEnable|FALSE > > -- > 2.12.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38654): https://edk2.groups.io/g/devel/message/38654 Mute This Topic: https://groups.io/mt/30893896/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'
For KabylakeRvp3, it is using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is not being used. This commit will remove the usage of the above PCD in package DSC files. Cc: Chasel Chiu Cc: Michael Kubacki Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc index bb06ff5a2a..f3d082ce41 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc @@ -1,7 +1,7 @@ ## @file # Platform configuration file. # -# Copyright (c) 2017, Intel Corporation. All rights reserved. +# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # # This program and the accompanying materials are licensed and made available under # the terms and conditions of the BSD License which accompanies this distribution. @@ -111,7 +111,6 @@ [PcdsFeatureFlag] gSiPkgTokenSpaceGuid.PcdSmmVariableEnable|TRUE gSiPkgTokenSpaceGuid.PcdSoftwareGuardEnable|TRUE gSiPkgTokenSpaceGuid.PcdSsaFlagEnable|FALSE - gSiPkgTokenSpaceGuid.PcdUseHpetTimer|TRUE # TRUE - HPET / FALSE - 8254 timer is used. gSiPkgTokenSpaceGuid.PcdOcWdtEnable|TRUE gSiPkgTokenSpaceGuid.PcdSiCatalogDebugEnable|FALSE -- 2.12.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#32): https://edk2.groups.io/g/devel/message/32 Mute This Topic: https://groups.io/mt/30893896/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
