Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev
On Mon, Sep 09, 2019 at 05:53:10PM +0200, Patryk Duda wrote: > This patch fixes missing MdioIndex copying during initialization. > This bug appeared as inability to communicate with PHY connected > to MDIO other than first. > > Signed-off-by: Patryk Duda Reviewed-by: Leif Lindholm Pushed as e4d3ddd7a51b. Thanks! > --- > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > index 6cdef42391..2d2aad7e38 100644 > --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > @@ -419,8 +419,12 @@ MvPhyInit ( >PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE)); >PhyDev->Addr = PhySmiAddresses[PhyIndex]; >PhyDev->Connection = PhyConnection; > - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n", > -PhyDev->Addr, PhyConnection)); > + PhyDev->MdioIndex = MdioIndex; > + DEBUG ((DEBUG_INFO, > +"MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n", > +PhyDev->MdioIndex, > +PhyDev->Addr, > +PhyConnection)); >*OutPhyDev = PhyDev; > >DeviceIds = PcdGetPtr (PcdPhyDeviceIds); > -- > 2.16.4 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48248): https://edk2.groups.io/g/devel/message/48248 Mute This Topic: https://groups.io/mt/34085586/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev
Hi, Do you have any remarks to this patch? Best Regards, Patryk wt., 10 wrz 2019 o 08:24 Marcin Wojtas napisał(a): > pon., 9 wrz 2019 o 17:53 Patryk Duda napisał(a): > > > > This patch fixes missing MdioIndex copying during initialization. > > This bug appeared as inability to communicate with PHY connected > > to MDIO other than first. > > > > Signed-off-by: Patryk Duda > > --- > > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > > index 6cdef42391..2d2aad7e38 100644 > > --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > > +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > > @@ -419,8 +419,12 @@ MvPhyInit ( > >PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE)); > >PhyDev->Addr = PhySmiAddresses[PhyIndex]; > >PhyDev->Connection = PhyConnection; > > - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n", > > -PhyDev->Addr, PhyConnection)); > > + PhyDev->MdioIndex = MdioIndex; > > + DEBUG ((DEBUG_INFO, > > +"MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n", > > +PhyDev->MdioIndex, > > +PhyDev->Addr, > > +PhyConnection)); > >*OutPhyDev = PhyDev; > > > >DeviceIds = PcdGetPtr (PcdPhyDeviceIds); > > -- > > Tested-by: Marcin Wojtas > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48226): https://edk2.groups.io/g/devel/message/48226 Mute This Topic: https://groups.io/mt/34085586/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev
pon., 9 wrz 2019 o 17:53 Patryk Duda napisał(a): > > This patch fixes missing MdioIndex copying during initialization. > This bug appeared as inability to communicate with PHY connected > to MDIO other than first. > > Signed-off-by: Patryk Duda > --- > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > index 6cdef42391..2d2aad7e38 100644 > --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > @@ -419,8 +419,12 @@ MvPhyInit ( >PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE)); >PhyDev->Addr = PhySmiAddresses[PhyIndex]; >PhyDev->Connection = PhyConnection; > - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n", > -PhyDev->Addr, PhyConnection)); > + PhyDev->MdioIndex = MdioIndex; > + DEBUG ((DEBUG_INFO, > +"MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n", > +PhyDev->MdioIndex, > +PhyDev->Addr, > +PhyConnection)); >*OutPhyDev = PhyDev; > >DeviceIds = PcdGetPtr (PcdPhyDeviceIds); > -- Tested-by: Marcin Wojtas -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47066): https://edk2.groups.io/g/devel/message/47066 Mute This Topic: https://groups.io/mt/34085586/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev
This patch fixes missing MdioIndex copying during initialization. This bug appeared as inability to communicate with PHY connected to MDIO other than first. Signed-off-by: Patryk Duda --- Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c index 6cdef42391..2d2aad7e38 100644 --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c @@ -419,8 +419,12 @@ MvPhyInit ( PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE)); PhyDev->Addr = PhySmiAddresses[PhyIndex]; PhyDev->Connection = PhyConnection; - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n", -PhyDev->Addr, PhyConnection)); + PhyDev->MdioIndex = MdioIndex; + DEBUG ((DEBUG_INFO, +"MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n", +PhyDev->MdioIndex, +PhyDev->Addr, +PhyConnection)); *OutPhyDev = PhyDev; DeviceIds = PcdGetPtr (PcdPhyDeviceIds); -- 2.16.4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47051): https://edk2.groups.io/g/devel/message/47051 Mute This Topic: https://groups.io/mt/34085586/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
