Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures
Pushed as 91e4065 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Thursday, November 30, 2023 4:18 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Ni, Ray ; Chaganty, Rangasai V ; Gao, Liming ; Kinney, Michael D ; Kelly Steele ; Taylor Beebe ; Kubacki, Michael Subject: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and hence currently fail to build. This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg and resolves the build failure. Cc: Chasel Chiu Cc: Ray Ni Cc: Sai Chaganty Cc: Liming Gao Cc: Michael D Kinney Cc: Kelly Steele Cc: Taylor Beebe Cc: Michael Kubacki Signed-off-by: Nate DeSimone --- Platform/Intel/QuarkPlatformPkg/Quark.dsc| 1 + Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc index 7cc548058a..40d9768336 100644 --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc @@ -196,6 +196,7 @@ !endif FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf + + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib + /ImagePropertiesRecordLib.inf # # CPU diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc index 59577eda4f..67472930c9 100644 --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc @@ -167,6 +167,7 @@ !endif CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf + + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib + /ImagePropertiesRecordLib.inf # # CPU -- 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111956): https://edk2.groups.io/g/devel/message/111956 Mute This Topic: https://groups.io/mt/102906246/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures
Reviewed-by: Michael D Kinney > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 30, 2023 4:18 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ni, Ray ; > Chaganty, Rangasai V ; Gao, Liming > ; Kinney, Michael D ; > Kelly Steele ; Taylor Beebe > ; Kubacki, Michael > > Subject: [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build > Failures > > Commit 7284c44 in edk2 introduces an incompatibility that causes any > project that uses DxeMain.inf to fail to build. This is due to the > addition of ImagePropertiesRecordLib, and a new added dependency on > that library in DxeMain. Platforms will not have this LibraryClass > defined in their DSC yet and hence currently fail to build. > > This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg > and resolves the build failure. > > Cc: Chasel Chiu > Cc: Ray Ni > Cc: Sai Chaganty > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Kelly Steele > Cc: Taylor Beebe > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > Platform/Intel/QuarkPlatformPkg/Quark.dsc| 1 + > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > index 7cc548058a..40d9768336 100644 > --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > @@ -196,6 +196,7 @@ > !endif > >FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > + > ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/Imag > ePropertiesRecordLib.inf > ># ># CPU > diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > index 59577eda4f..67472930c9 100644 > --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > @@ -167,6 +167,7 @@ > !endif > >CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > + > ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/Imag > ePropertiesRecordLib.inf > ># ># CPU > -- > 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111954): https://edk2.groups.io/g/devel/message/111954 Mute This Topic: https://groups.io/mt/102906246/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures
Reviewed-by: Michael Kubacki On 11/30/2023 7:18 PM, Nate DeSimone wrote: Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and hence currently fail to build. This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg and resolves the build failure. Cc: Chasel Chiu Cc: Ray Ni Cc: Sai Chaganty Cc: Liming Gao Cc: Michael D Kinney Cc: Kelly Steele Cc: Taylor Beebe Cc: Michael Kubacki Signed-off-by: Nate DeSimone --- Platform/Intel/QuarkPlatformPkg/Quark.dsc| 1 + Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc index 7cc548058a..40d9768336 100644 --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc @@ -196,6 +196,7 @@ !endif FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf # # CPU diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc index 59577eda4f..67472930c9 100644 --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc @@ -167,6 +167,7 @@ !endif CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf # # CPU -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111932): https://edk2.groups.io/g/devel/message/111932 Mute This Topic: https://groups.io/mt/102906246/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures
Hey Taylor, I think I gotten everything in Platform/Intel, it should also fix QemuOpenBoardPkg and AmdMinBoardPkg. I saw that Levi also fixed ARM\VExpressPkg in https://edk2.groups.io/g/devel/message/111905. Everything else I'm not sure. Thanks for being proactive on fixing it! Best Regards, Nate -Original Message- From: Taylor Beebe Sent: Thursday, November 30, 2023 4:22 PM To: Desimone, Nathaniel L ; devel@edk2.groups.io Cc: Chiu, Chasel ; Ni, Ray ; Chaganty, Rangasai V ; Gao, Liming ; Kinney, Michael D ; Kelly Steele ; Kubacki, Michael Subject: Re: [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures Hey Nate, I'm about to send out a series to add the library across the repo -- just having some smtp authentication issues :D Are you updating all the packages or just a subset? -Taylor On 11/30/2023 4:18 PM, Nate DeSimone wrote: > Commit 7284c44 in edk2 introduces an incompatibility that causes any > project that uses DxeMain.inf to fail to build. This is due to the > addition of ImagePropertiesRecordLib, and a new added dependency on > that library in DxeMain. Platforms will not have this LibraryClass > defined in their DSC yet and hence currently fail to build. > > This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg and > resolves the build failure. > > Cc: Chasel Chiu > Cc: Ray Ni > Cc: Sai Chaganty > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Kelly Steele > Cc: Taylor Beebe > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > Platform/Intel/QuarkPlatformPkg/Quark.dsc| 1 + > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > index 7cc548058a..40d9768336 100644 > --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > @@ -196,6 +196,7 @@ > !endif > > > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.i > nf > + > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordL > + ib/ImagePropertiesRecordLib.inf > > # > # CPU > diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > index 59577eda4f..67472930c9 100644 > --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > @@ -167,6 +167,7 @@ > !endif > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in > f > + > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordL > + ib/ImagePropertiesRecordLib.inf > > # > # CPU -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111931): https://edk2.groups.io/g/devel/message/111931 Mute This Topic: https://groups.io/mt/102906246/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures
Hey Nate, I'm about to send out a series to add the library across the repo -- just having some smtp authentication issues :D Are you updating all the packages or just a subset? -Taylor On 11/30/2023 4:18 PM, Nate DeSimone wrote: Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and hence currently fail to build. This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg and resolves the build failure. Cc: Chasel Chiu Cc: Ray Ni Cc: Sai Chaganty Cc: Liming Gao Cc: Michael D Kinney Cc: Kelly Steele Cc: Taylor Beebe Cc: Michael Kubacki Signed-off-by: Nate DeSimone --- Platform/Intel/QuarkPlatformPkg/Quark.dsc| 1 + Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc index 7cc548058a..40d9768336 100644 --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc @@ -196,6 +196,7 @@ !endif FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf # # CPU diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc index 59577eda4f..67472930c9 100644 --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc @@ -167,6 +167,7 @@ !endif CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf # # CPU -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111929): https://edk2.groups.io/g/devel/message/111929 Mute This Topic: https://groups.io/mt/102906246/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures
Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and hence currently fail to build. This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg and resolves the build failure. Cc: Chasel Chiu Cc: Ray Ni Cc: Sai Chaganty Cc: Liming Gao Cc: Michael D Kinney Cc: Kelly Steele Cc: Taylor Beebe Cc: Michael Kubacki Signed-off-by: Nate DeSimone --- Platform/Intel/QuarkPlatformPkg/Quark.dsc| 1 + Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc index 7cc548058a..40d9768336 100644 --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc @@ -196,6 +196,7 @@ !endif FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf # # CPU diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc index 59577eda4f..67472930c9 100644 --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc @@ -167,6 +167,7 @@ !endif CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf # # CPU -- 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111927): https://edk2.groups.io/g/devel/message/111927 Mute This Topic: https://groups.io/mt/102906246/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
