Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Nate DeSimone > Sent: Friday, August 9, 2019 8:47 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-devel] [edk2-platforms] [PATCH] > Platform/Intel/KabylakeOpenBoardPkg: Fix build. > > The build for KabylakeOpenBoardPkg is presently broken due to > WORKSPACE_PLATFORM_BIN being defined to a marco of the same name in > KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > > Setting this macro to an empty string resolves the issue. > > Cc: Chasel Chiu > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > .../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg| 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > index bf89ea399c..ab1a9a61c2 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > @@ -7,7 +7,7 @@ > > > [CONFIG] > -WORKSPACE_PLATFORM_BIN = WORKSPACE_PLATFORM_BIN > +WORKSPACE_PLATFORM_BIN = > EDK_SETUP_OPTION = > openssl_path = > PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg > -- > 2.17.1.windows.2 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45342): https://edk2.groups.io/g/devel/message/45342 Mute This Topic: https://groups.io/mt/32805602/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Pushed: https://github.com/tianocore/edk2-platforms/commit/84627927fa195703752c7fd5ab4437f87c547b87 -Original Message- From: Kubacki, Michael A Sent: Friday, August 9, 2019 11:13 AM To: devel@edk2.groups.io; Desimone, Nathaniel L Cc: Chiu, Chasel Subject: RE: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build. Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Nate DeSimone > Sent: Thursday, August 8, 2019 5:47 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-devel] [edk2-platforms] [PATCH] > Platform/Intel/KabylakeOpenBoardPkg: Fix build. > > The build for KabylakeOpenBoardPkg is presently broken due to > WORKSPACE_PLATFORM_BIN being defined to a marco of the same name in > KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > > Setting this macro to an empty string resolves the issue. > > Cc: Chasel Chiu > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > .../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg| 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > index bf89ea399c..ab1a9a61c2 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > @@ -7,7 +7,7 @@ > > > [CONFIG] > -WORKSPACE_PLATFORM_BIN = WORKSPACE_PLATFORM_BIN > +WORKSPACE_PLATFORM_BIN = > EDK_SETUP_OPTION = > openssl_path = > PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg > -- > 2.17.1.windows.2 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45323): https://edk2.groups.io/g/devel/message/45323 Mute This Topic: https://groups.io/mt/32805602/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Nate DeSimone > Sent: Thursday, August 8, 2019 5:47 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-devel] [edk2-platforms] [PATCH] > Platform/Intel/KabylakeOpenBoardPkg: Fix build. > > The build for KabylakeOpenBoardPkg is presently broken due to > WORKSPACE_PLATFORM_BIN being defined to a marco of the same name in > KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > > Setting this macro to an empty string resolves the issue. > > Cc: Chasel Chiu > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > .../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg| 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > index bf89ea399c..ab1a9a61c2 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > @@ -7,7 +7,7 @@ > > > [CONFIG] > -WORKSPACE_PLATFORM_BIN = WORKSPACE_PLATFORM_BIN > +WORKSPACE_PLATFORM_BIN = > EDK_SETUP_OPTION = > openssl_path = > PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg > -- > 2.17.1.windows.2 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45289): https://edk2.groups.io/g/devel/message/45289 Mute This Topic: https://groups.io/mt/32805602/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.
The build for KabylakeOpenBoardPkg is presently broken due to WORKSPACE_PLATFORM_BIN being defined to a marco of the same name in KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg Setting this macro to an empty string resolves the issue. Cc: Chasel Chiu Cc: Michael Kubacki Signed-off-by: Nate DeSimone --- .../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg index bf89ea399c..ab1a9a61c2 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg @@ -7,7 +7,7 @@ [CONFIG] -WORKSPACE_PLATFORM_BIN = WORKSPACE_PLATFORM_BIN +WORKSPACE_PLATFORM_BIN = EDK_SETUP_OPTION = openssl_path = PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg -- 2.17.1.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45248): https://edk2.groups.io/g/devel/message/45248 Mute This Topic: https://groups.io/mt/32805602/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
