Re: [edk2-devel] [edk2-staging][PATCH 2/2] CryptoPkg: fix wrong name in tls 1.2 cipher suite

2023-02-28 Thread Heng Luo
Reviewed-by: Heng Luo 

> -Original Message-
> From: Li, Yi1 
> Sent: Friday, February 24, 2023 2:49 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 ; Gao, Zhichao ; Tan,
> Ming ; Luo, Heng 
> Subject: [edk2-staging][PATCH 2/2] CryptoPkg: fix wrong name in tls 1.2
> cipher suite
> 
> Keep cipher name consistent with openssl.
> 
> Cc: Zhichao Gao 
> Cc: Ming Tan 
> Cc: Heng Luo 
> Signed-off-by: Yi Li 
> ---
>  CryptoPkg/Library/TlsLib/TlsConfig.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/CryptoPkg/Library/TlsLib/TlsConfig.c
> b/CryptoPkg/Library/TlsLib/TlsConfig.c
> index 3a3490c2ac..30247b931b 100644
> --- a/CryptoPkg/Library/TlsLib/TlsConfig.c
> +++ b/CryptoPkg/Library/TlsLib/TlsConfig.c
> @@ -70,8 +70,8 @@ STATIC CONST TLS_CIPHER_MAPPING
> TlsCipherMappingTable[] = {
>MAP (0x1302, "TLS_AES_256_GCM_SHA384"),  ///
> TLS_AES_256_GCM_SHA384
>MAP (0x1303, "TLS_CHACHA20_POLY1305_SHA256"),///
> TLS_CHACHA20_POLY1305_SHA256
>MAP (0x1301, "TLS_AES_128_GCM_SHA256"),  ///
> TLS_AES_128_GCM_SHA256
> -  MAP (0xC02B, "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256"), ///
> TLS_ECDHE_ECDSA_AES128_GCM_SHA256
> -  MAP (0xC02C, "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384"), ///
> TLS_ECDHE_ECDSA_AES256_GCM_SHA384
> +  MAP (0xC02B, "ECDHE-ECDSA-AES128-GCM-SHA256"),   ///
> TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
> +  MAP (0xC02C, "ECDHE-ECDSA-AES256-GCM-SHA384"),   ///
> TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384
>MAP (0xC030, "ECDHE-RSA-AES256-GCM-SHA384"), ///
> TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
>  };
> 
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100541): https://edk2.groups.io/g/devel/message/100541
Mute This Topic: https://groups.io/mt/97201411/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [edk2-staging][PATCH 2/2] CryptoPkg: fix wrong name in tls 1.2 cipher suite

2023-02-23 Thread Li, Yi
Keep cipher name consistent with openssl.

Cc: Zhichao Gao 
Cc: Ming Tan 
Cc: Heng Luo 
Signed-off-by: Yi Li 
---
 CryptoPkg/Library/TlsLib/TlsConfig.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CryptoPkg/Library/TlsLib/TlsConfig.c 
b/CryptoPkg/Library/TlsLib/TlsConfig.c
index 3a3490c2ac..30247b931b 100644
--- a/CryptoPkg/Library/TlsLib/TlsConfig.c
+++ b/CryptoPkg/Library/TlsLib/TlsConfig.c
@@ -70,8 +70,8 @@ STATIC CONST TLS_CIPHER_MAPPING  TlsCipherMappingTable[] = {
   MAP (0x1302, "TLS_AES_256_GCM_SHA384"),  /// 
TLS_AES_256_GCM_SHA384
   MAP (0x1303, "TLS_CHACHA20_POLY1305_SHA256"),/// 
TLS_CHACHA20_POLY1305_SHA256
   MAP (0x1301, "TLS_AES_128_GCM_SHA256"),  /// 
TLS_AES_128_GCM_SHA256
-  MAP (0xC02B, "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256"), /// 
TLS_ECDHE_ECDSA_AES128_GCM_SHA256
-  MAP (0xC02C, "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384"), /// 
TLS_ECDHE_ECDSA_AES256_GCM_SHA384
+  MAP (0xC02B, "ECDHE-ECDSA-AES128-GCM-SHA256"),   /// 
TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
+  MAP (0xC02C, "ECDHE-ECDSA-AES256-GCM-SHA384"),   /// 
TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384
   MAP (0xC030, "ECDHE-RSA-AES256-GCM-SHA384"), /// 
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
 };
 
-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100485): https://edk2.groups.io/g/devel/message/100485
Mute This Topic: https://groups.io/mt/97201411/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-