subject:"\[edk2\-devel\] \[edk2\-test\]"

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-10 Thread Chao Li


Hi Edhay,

Okay, I will retest using the rc2 today and expect to upload the logs 
tonight or next Monday under edk2-test-rc2-202405.



Thanks,
Chao
On 2024/5/10 22:56, G Edhaya Chandran wrote:


Hi Chao,

Yes, it is best to test based on the new tag at-least on one environment.

Note: The difference between old and new tag is mainly resolving build 
related issues.


There is no change in test coverage.

With WarM Regards,
Edhay

*From:*Chao Li 
*Sent:* Thursday, May 9, 2024 9:56 PM
*To:* devel@edk2.groups.io; G Edhaya Chandran 
; David Wright ; 
Heinrich Schuchardt 
*Cc:* Alex Fox ; Stuart Yoder 
; gao...@byosoft.com.cn
*Subject:* Re: [edk2-devel] edk2-test Release candidate 2: 
edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up


Hi Edhay,

Do I need to retest based on the edk2-test-rc2_202405 tag?

Thanks,
Chao

On 2024/5/10 10:43, G Edhaya Chandran wrote:

Thank you, David.

The results are well received.

With Warm Regards,
Edhay

*From:*David Wright 
<mailto:david_wri...@phoenix.com>
*Sent:* Thursday, May 9, 2024 3:23 PM
*To:* G Edhaya Chandran 
<mailto:edhaya.chand...@arm.com>; Heinrich Schuchardt

<mailto:heinrich.schucha...@canonical.com>
*Cc:* Alex Fox 
<mailto:alex_...@phoenix.com>; lic...@loongson.cn; Stuart Yoder
 <mailto:stuart.yo...@arm.com>;
devel@edk2.groups.io; gao...@byosoft.com.cn
*Subject:* RE: edk2-test Release candidate 2: edk2-test-rc2_202405
// RE: [PATCH v2 0/4] TCG2 protocol clean up

Hi all,

Phoenix has completed testing on *edk2-test-rc2_202405*

Results have been uploaded to their respective folders.

Thanks,

David Wright
QA Team Leader

david_wri...@phoenix.com

503-730-4537 Tel

www.phoenix.com

<https://mailgw.loongson.cn/linkserver?dest=http%3A%2F%2Fwww.phoenix.com%2F=_8Dx2enliT1mLVoKAA--.14549S3=lic...@loongson.cn=1=0>


THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE
THE INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS
STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR,
PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE OR REPLY EMAIL,
AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.

*From:*G Edhaya Chandran 
*Sent:* Friday, May 3, 2024 4:47 PM
*To:* Heinrich Schuchardt 
*Cc:* Alex Fox ; David Wright
; lic...@loongson.cn; Stuart Yoder
; devel@edk2.groups.io; gao...@byosoft.com.cn
*Subject:* edk2-test Release candidate 2: edk2-test-rc2_202405 //
RE: [PATCH v2 0/4] TCG2 protocol clean up

[Caution, this message was sent from an external sender.]

Hi All,

   A new release candidate is published after upstreaming Stuart's
commits on build cleanup.

https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405
<https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405>

The updates since the old tag are the following commits in the
patch series:

[PATCH v2 0/4] TCG2 protocol clean up (groups.io)

<https://mailgw.loongson.cn/linkserver?dest=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F117882%3Fp%3D%252C%252C%252C20%252C0%252C0%252C0%253A%253Arecentpostdate%252Fsticky%252C%252Cstuart%2Byoder%252C20%252C2%252C0%252C105558005=_8Dx2enliT1mLVoKAA--.14549S3=lic...@loongson.cn=1=1>

The release candidate may be used for any further testing.

With Warm Regards,
Edhay

> -Original Message-

> From: G Edhaya Chandran

> Sent: Tuesday, April 23, 2024 4:52 AM

> To: Heinrich Schuchardt 

> Cc: alex_...@phoenix.com; david_wri...@phoenix.com;

> lic...@loongson.cn; Stuart Yoder ;

> devel@edk2.groups.io; gao...@byosoft.com.cn

> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up

> 


> Hi Heinrich,

> 


>    Yes. A new release candidate shall be published after review and 
upstream

> of the patches.

> Will further send an update.

> 


> With Warm Regards,

> Edhay

> 

> 


> > -Original Message-

> > From: Heinrich Schuchardt 

> > Sent: Tuesday, April 23, 2024 12:46 AM

> > To: G Edhaya Chandran 

> > Cc: alex_...@phoenix.com; david_wri...@phoenix.com;

> > lic...@loongson.cn; Stuart Yoder ;

> > devel@edk2.groups.io; gao...@byosoft.com.cn

> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up

> >

> > On 4/16/24 16:53, Stuart Yoder wrote:

> > > This patch series cleans up some issues found when building

> > > edk2-test with a non-GCC compiler:

> > >    -TPMT_HA struct had an error due to incorrect use of C flexible

> > > array

> > member

> > >    -compute struct member offsets using OFFSET_OF, which is not GC

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-10 Thread G Edhaya Chandran

Hi Chao,

   Yes, it is best to test based on the new tag at-least on one environment.

Note: The difference between old and new tag is mainly resolving build related 
issues.
There is no change in test coverage.

With WarM Regards,
Edhay


From: Chao Li 
Sent: Thursday, May 9, 2024 9:56 PM
To: devel@edk2.groups.io; G Edhaya Chandran ; David 
Wright ; Heinrich Schuchardt 

Cc: Alex Fox ; Stuart Yoder ; 
gao...@byosoft.com.cn
Subject: Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 
// RE: [PATCH v2 0/4] TCG2 protocol clean up


Hi Edhay,

Do I need to retest based on the edk2-test-rc2_202405 tag?

Thanks,
Chao
On 2024/5/10 10:43, G Edhaya Chandran wrote:
Thank you, David.
The results are well received.

With Warm Regards,
Edhay


From: David Wright <mailto:david_wri...@phoenix.com>
Sent: Thursday, May 9, 2024 3:23 PM
To: G Edhaya Chandran 
<mailto:edhaya.chand...@arm.com>; Heinrich Schuchardt 
<mailto:heinrich.schucha...@canonical.com>
Cc: Alex Fox <mailto:alex_...@phoenix.com>; 
lic...@loongson.cn<mailto:lic...@loongson.cn>; Stuart Yoder 
<mailto:stuart.yo...@arm.com>; 
devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 
gao...@byosoft.com.cn<mailto:gao...@byosoft.com.cn>
Subject: RE: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH 
v2 0/4] TCG2 protocol clean up

Hi all,

Phoenix has completed testing on edk2-test-rc2_202405

Results have been uploaded to their respective folders.

[cid:image001.png@01DAA2BF.53E23D80]


Thanks,
David Wright
QA Team Leader
david_wri...@phoenix.com<mailto:david_wri...@phoenix.com>
503-730-4537 Tel
[cid:image002.jpg@01DAA2BF.53E23D80]
www.phoenix.com<https://mailgw.loongson.cn/linkserver?dest=http%3A%2F%2Fwww.phoenix.com%2F=_8Dx2enliT1mLVoKAA--.14549S3=lic...@loongson.cn=1=0>
THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE INTENDED 
RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS STRICTLY PROHIBITED. IF 
YOU HAVE RECEIVED THIS MESSAGE IN ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER 
BY TELEPHONE OR REPLY EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.




From: G Edhaya Chandran 
mailto:edhaya.chand...@arm.com>>
Sent: Friday, May 3, 2024 4:47 PM
To: Heinrich Schuchardt 
mailto:heinrich.schucha...@canonical.com>>
Cc: Alex Fox mailto:alex_...@phoenix.com>>; David Wright 
mailto:david_wri...@phoenix.com>>; 
lic...@loongson.cn<mailto:lic...@loongson.cn>; Stuart Yoder 
mailto:stuart.yo...@arm.com>>; 
devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 
gao...@byosoft.com.cn<mailto:gao...@byosoft.com.cn>
Subject: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 
0/4] TCG2 protocol clean up


[Caution, this message was sent from an external sender.]

Hi All,

   A new release candidate is published after upstreaming Stuart's commits on 
build cleanup.
https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405

The updates since the old tag are the following commits in the patch series:
[PATCH v2 0/4] TCG2 protocol clean up 
(groups.io)<https://mailgw.loongson.cn/linkserver?dest=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F117882%3Fp%3D%252C%252C%252C20%252C0%252C0%252C0%253A%253Arecentpostdate%252Fsticky%252C%252Cstuart%2Byoder%252C20%252C2%252C0%252C105558005=_8Dx2enliT1mLVoKAA--.14549S3=lic...@loongson.cn=1=1>

The release candidate may be used for any further testing.

With Warm Regards,
Edhay



> -Original Message-
> From: G Edhaya Chandran
> Sent: Tuesday, April 23, 2024 4:52 AM
> To: Heinrich Schuchardt 
> mailto:heinrich.schucha...@canonical.com>>
> Cc: alex_...@phoenix.com<mailto:alex_...@phoenix.com>; 
> david_wri...@phoenix.com<mailto:david_wri...@phoenix.com>;
> lic...@loongson.cn<mailto:lic...@loongson.cn>; Stuart Yoder 
> mailto:stuart.yo...@arm.com>>;
> devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 
> gao...@byosoft.com.cn<mailto:gao...@byosoft.com.cn>
> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Heinrich,
>
>Yes. A new release candidate shall be published after review and upstream
> of the patches.
> Will further send an update.
>
> With Warm Regards,
> Edhay
>
>
> > -Original Message-
> > From: Heinrich Schuchardt 
> > mailto:heinrich.schucha...@canonical.com>>
> > Sent: Tuesday, April 23, 2024 12:46 AM
> > To: G Edhaya Chandran 
> > mailto:edhaya.chand...@arm.com>>
> > Cc: alex_...@phoenix.com<mailto:alex_...@phoenix.com>; 
> > david_wri...@phoenix.com<mailto:david_wri...@phoenix.com>;
> > lic...@loongson.cn<mailto:lic...@loongson.cn>; Stuart Yoder 
> > mailto:stuart.yo...@arm.com>>;
> > devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 
> > gao...@byosoft.c

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-09 Thread Chao Li


Hi Edhay,

Do I need to retest based on the edk2-test-rc2_202405 tag?


Thanks,
Chao
On 2024/5/10 10:43, G Edhaya Chandran wrote:


Thank you, David.

The results are well received.

With Warm Regards,
Edhay

*From:*David Wright 
*Sent:* Thursday, May 9, 2024 3:23 PM
*To:* G Edhaya Chandran ; Heinrich Schuchardt 

*Cc:* Alex Fox ; lic...@loongson.cn; Stuart 
Yoder ; devel@edk2.groups.io; gao...@byosoft.com.cn
*Subject:* RE: edk2-test Release candidate 2: edk2-test-rc2_202405 // 
RE: [PATCH v2 0/4] TCG2 protocol clean up


Hi all,

Phoenix has completed testing on *edk2-test-rc2_202405*

Results have been uploaded to their respective folders.

Thanks,

David Wright
QA Team Leader

david_wri...@phoenix.com

503-730-4537 Tel

www.phoenix.com 




THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE 
INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS 
STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR, 
PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE OR REPLY EMAIL, AND 
IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.


*From:*G Edhaya Chandran 
*Sent:* Friday, May 3, 2024 4:47 PM
*To:* Heinrich Schuchardt 
*Cc:* Alex Fox ; David Wright 
; lic...@loongson.cn; Stuart Yoder 
; devel@edk2.groups.io; gao...@byosoft.com.cn
*Subject:* edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: 
[PATCH v2 0/4] TCG2 protocol clean up


[Caution, this message was sent from an external sender.]

Hi All,

   A new release candidate is published after upstreaming Stuart's 
commits on build cleanup.


https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405 



The updates since the old tag are the following commits in the patch 
series:


[PATCH v2 0/4] TCG2 protocol clean up (groups.io) 



The release candidate may be used for any further testing.

With Warm Regards,
Edhay

> -Original Message-

> From: G Edhaya Chandran

> Sent: Tuesday, April 23, 2024 4:52 AM

> To: Heinrich Schuchardt 

> Cc: alex_...@phoenix.com; david_wri...@phoenix.com;

> lic...@loongson.cn; Stuart Yoder ;

> devel@edk2.groups.io; gao...@byosoft.com.cn

> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up

> 


> Hi Heinrich,

> 


>    Yes. A new release candidate shall be published after review and upstream

> of the patches.

> Will further send an update.

> 


> With Warm Regards,

> Edhay

> 

> 


> > -Original Message-

> > From: Heinrich Schuchardt 

> > Sent: Tuesday, April 23, 2024 12:46 AM

> > To: G Edhaya Chandran 

> > Cc: alex_...@phoenix.com; david_wri...@phoenix.com;

> > lic...@loongson.cn; Stuart Yoder ;

> > devel@edk2.groups.io; gao...@byosoft.com.cn

> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up

> >

> > On 4/16/24 16:53, Stuart Yoder wrote:

> > > This patch series cleans up some issues found when building

> > > edk2-test with a non-GCC compiler:

> > >   -TPMT_HA struct had an error due to incorrect use of C flexible

> > > array

> > member

> > >   -compute struct member offsets using OFFSET_OF, which is not GCC

> specific

> > >   -clean up of #pragma pack in one file

> > >   -resolve type conversion warnings

> > >

> > > Patches are in github here:

> > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup

> > >

> > > Version 2

> > >   -add SM3 hash type to TPM2.h

> > >   -resolve type conversion warnings

> > >

> > > Stuart Yoder (4):

> > >   uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct

> > >   uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets

> > >   uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup

> > >   uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings

> > >

> > >  uefi-

> >

> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe

> > st.h    |  3 +--

> > >  uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 17

> > +++--

> > >  uefi-

> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB

> > Te stConformance.c | 25 +---

> > >   3 files changed, 27 insertions(+), 18 deletions(-)

> > >

> >

> > Hello Edhaya,

> >

> > Will we have another release candidate with these patches included?

> >

> > Best regards

> >

> > Heinrich

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended 
recipient, please notify the sender immediately and do not disclose 
the contents to any other person, use it for any purpose, or store or 
copy

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-09 Thread G Edhaya Chandran

Thank you, David.
The results are well received.

With Warm Regards,
Edhay


From: David Wright 
Sent: Thursday, May 9, 2024 3:23 PM
To: G Edhaya Chandran ; Heinrich Schuchardt 

Cc: Alex Fox ; lic...@loongson.cn; Stuart Yoder 
; devel@edk2.groups.io; gao...@byosoft.com.cn
Subject: RE: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH 
v2 0/4] TCG2 protocol clean up

Hi all,

Phoenix has completed testing on edk2-test-rc2_202405

Results have been uploaded to their respective folders.

[cid:image001.png@01DAA259.ED4F57C0]


Thanks,
David Wright
QA Team Leader
david_wri...@phoenix.com
503-730-4537 Tel
[cid:image002.jpg@01DAA259.ED4F57C0]
www.phoenix.com
THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE INTENDED 
RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS STRICTLY PROHIBITED. IF 
YOU HAVE RECEIVED THIS MESSAGE IN ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER 
BY TELEPHONE OR REPLY EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.




From: G Edhaya Chandran 
mailto:edhaya.chand...@arm.com>>
Sent: Friday, May 3, 2024 4:47 PM
To: Heinrich Schuchardt 
mailto:heinrich.schucha...@canonical.com>>
Cc: Alex Fox mailto:alex_...@phoenix.com>>; David Wright 
mailto:david_wri...@phoenix.com>>; 
lic...@loongson.cn; Stuart Yoder 
mailto:stuart.yo...@arm.com>>; 
devel@edk2.groups.io; 
gao...@byosoft.com.cn
Subject: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 
0/4] TCG2 protocol clean up


[Caution, this message was sent from an external sender.]

Hi All,

   A new release candidate is published after upstreaming Stuart's commits on 
build cleanup.
https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405

The updates since the old tag are the following commits in the patch series:
[PATCH v2 0/4] TCG2 protocol clean up 
(groups.io)

The release candidate may be used for any further testing.

With Warm Regards,
Edhay



> -Original Message-
> From: G Edhaya Chandran
> Sent: Tuesday, April 23, 2024 4:52 AM
> To: Heinrich Schuchardt 
> mailto:heinrich.schucha...@canonical.com>>
> Cc: alex_...@phoenix.com; 
> david_wri...@phoenix.com;
> lic...@loongson.cn; Stuart Yoder 
> mailto:stuart.yo...@arm.com>>;
> devel@edk2.groups.io; 
> gao...@byosoft.com.cn
> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Heinrich,
>
>Yes. A new release candidate shall be published after review and upstream
> of the patches.
> Will further send an update.
>
> With Warm Regards,
> Edhay
>
>
> > -Original Message-
> > From: Heinrich Schuchardt 
> > mailto:heinrich.schucha...@canonical.com>>
> > Sent: Tuesday, April 23, 2024 12:46 AM
> > To: G Edhaya Chandran 
> > mailto:edhaya.chand...@arm.com>>
> > Cc: alex_...@phoenix.com; 
> > david_wri...@phoenix.com;
> > lic...@loongson.cn; Stuart Yoder 
> > mailto:stuart.yo...@arm.com>>;
> > devel@edk2.groups.io; 
> > gao...@byosoft.com.cn
> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
> >
> > On 4/16/24 16:53, Stuart Yoder wrote:
> > > This patch series cleans up some issues found when building
> > > edk2-test with a non-GCC compiler:
> > >-TPMT_HA struct had an error due to incorrect use of C flexible
> > > array
> > member
> > >-compute struct member offsets using OFFSET_OF, which is not GCC
> specific
> > >-clean up of #pragma pack in one file
> > >-resolve type conversion warnings
> > >
> > > Patches are in github here:
> > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> > >
> > > Version 2
> > >-add SM3 hash type to TPM2.h
> > >-resolve type conversion warnings
> > >
> > > Stuart Yoder (4):
> > >uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
> > >uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
> > >uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
> > >uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> > >
> > >   uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> > st.h|  3 +--
> > >   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h
> > >  | 17
> > +++--
> > >   uefi-
> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
> > Te stConformance.c | 25 +---
> > >   3 files changed, 27 insertions(+), 18 deletions(-)
> > >
> >
> > Hello Edhaya,
> >
> > Will we have

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-09 Thread David Wright

Hi all,

Phoenix has completed testing on edk2-test-rc2_202405

Results have been uploaded to their respective folders.

[cid:image001.png@01DAA213.C980F100]


Thanks,
David Wright
QA Team Leader
david_wri...@phoenix.com
503-730-4537 Tel
[cid:image002.jpg@01DAA213.C980F100]
www.phoenix.com
THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE INTENDED 
RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS STRICTLY PROHIBITED. IF 
YOU HAVE RECEIVED THIS MESSAGE IN ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER 
BY TELEPHONE OR REPLY EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.




From: G Edhaya Chandran 
Sent: Friday, May 3, 2024 4:47 PM
To: Heinrich Schuchardt 
Cc: Alex Fox ; David Wright ; 
lic...@loongson.cn; Stuart Yoder ; devel@edk2.groups.io; 
gao...@byosoft.com.cn
Subject: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 
0/4] TCG2 protocol clean up


[Caution, this message was sent from an external sender.]

Hi All,

   A new release candidate is published after upstreaming Stuart's commits on 
build cleanup.
https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405

The updates since the old tag are the following commits in the patch series:
[PATCH v2 0/4] TCG2 protocol clean up 
(groups.io)

The release candidate may be used for any further testing.

With Warm Regards,
Edhay



> -Original Message-
> From: G Edhaya Chandran
> Sent: Tuesday, April 23, 2024 4:52 AM
> To: Heinrich Schuchardt 
> mailto:heinrich.schucha...@canonical.com>>
> Cc: alex_...@phoenix.com; 
> david_wri...@phoenix.com;
> lic...@loongson.cn; Stuart Yoder 
> mailto:stuart.yo...@arm.com>>;
> devel@edk2.groups.io; 
> gao...@byosoft.com.cn
> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Heinrich,
>
>Yes. A new release candidate shall be published after review and upstream
> of the patches.
> Will further send an update.
>
> With Warm Regards,
> Edhay
>
>
> > -Original Message-
> > From: Heinrich Schuchardt 
> > mailto:heinrich.schucha...@canonical.com>>
> > Sent: Tuesday, April 23, 2024 12:46 AM
> > To: G Edhaya Chandran 
> > mailto:edhaya.chand...@arm.com>>
> > Cc: alex_...@phoenix.com; 
> > david_wri...@phoenix.com;
> > lic...@loongson.cn; Stuart Yoder 
> > mailto:stuart.yo...@arm.com>>;
> > devel@edk2.groups.io; 
> > gao...@byosoft.com.cn
> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
> >
> > On 4/16/24 16:53, Stuart Yoder wrote:
> > > This patch series cleans up some issues found when building
> > > edk2-test with a non-GCC compiler:
> > >-TPMT_HA struct had an error due to incorrect use of C flexible
> > > array
> > member
> > >-compute struct member offsets using OFFSET_OF, which is not GCC
> specific
> > >-clean up of #pragma pack in one file
> > >-resolve type conversion warnings
> > >
> > > Patches are in github here:
> > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> > >
> > > Version 2
> > >-add SM3 hash type to TPM2.h
> > >-resolve type conversion warnings
> > >
> > > Stuart Yoder (4):
> > >uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
> > >uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
> > >uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
> > >uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> > >
> > >   uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> > st.h|  3 +--
> > >   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h
> > >  | 17
> > +++--
> > >   uefi-
> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
> > Te stConformance.c | 25 +---
> > >   3 files changed, 27 insertions(+), 18 deletions(-)
> > >
> >
> > Hello Edhaya,
> >
> > Will we have another release candidate with these patches included?
> >
> > Best regards
> >
> > Heinrich

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118776): https://edk2.groups.io/g/devel/message/118776
Mute This Topic: https://groups.io/mt/105898910/21656
Group

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

2024-05-06 Thread G Edhaya Chandran

Hi Heinrich,

   The folder structure for edk2-test-rc2_202405 is created:
https://members.uefi.org/wg/utwg/document/folder/128

With Warm Regards,
Edhay


> -Original Message-
> From: Heinrich Schuchardt 
> Sent: Sunday, May 5, 2024 5:22 PM
> To: G Edhaya Chandran 
> Cc: alex_...@phoenix.com; david_wri...@phoenix.com;
> lic...@loongson.cn; Stuart Yoder ;
> devel@edk2.groups.io; gao...@byosoft.com.cn
> Subject: Re: edk2-test Release candidate 2: edk2-test-rc2_202405
>
> On 5/4/24 01:47, G Edhaya Chandran wrote:
> > Hi All,
> > A new release candidate is published after upstreaming Stuart's
> > commits on build cleanup.
> > _https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405_
> > 
> > The updates since the old tag are the following commits in the patch
> > series:
> > _[PATCH v2 0/4] TCG2 protocol clean up (groups.io)_
> >
>  C0%2
> >
> C0%3A%3Arecentpostdate%2Fsticky%2C%2Cstuart+yoder%2C20%2C2%2C0%
> 2C10555
> > 8005> The release candidate may be used for any further testing.
> > With Warm Regards,
> > Edhay
>
> Hello Edhaya,
>
> I am not allowed to create the folder structure for uploading the test 
> results.
>
> Could you, please, create it and inform us.
>
> Best regards
>
> Heinrich
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118608): https://edk2.groups.io/g/devel/message/118608
Mute This Topic: https://groups.io/mt/105929926/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

2024-05-05 Thread Heinrich Schuchardt


On 5/4/24 01:47, G Edhaya Chandran wrote:

Hi All,
    A new release candidate is published after upstreaming Stuart's 
commits on build cleanup.
_https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405_ 

The updates since the old tag are the following commits in the patch 
series:
_[PATCH v2 0/4] TCG2 protocol clean up (groups.io)_ 


The release candidate may be used for any further testing.
With Warm Regards,
Edhay


Hello Edhaya,

I am not allowed to create the folder structure for uploading the test 
results.


Could you, please, create it and inform us.

Best regards

Heinrich


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118576): https://edk2.groups.io/g/devel/message/118576
Mute This Topic: https://groups.io/mt/105929926/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-03 Thread G Edhaya Chandran

Hi All,

   A new release candidate is published after upstreaming Stuart's commits on 
build cleanup.
https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405

The updates since the old tag are the following commits in the patch series:
[PATCH v2 0/4] TCG2 protocol clean up 
(groups.io)

The release candidate may be used for any further testing.

With Warm Regards,
Edhay



> -Original Message-
> From: G Edhaya Chandran
> Sent: Tuesday, April 23, 2024 4:52 AM
> To: Heinrich Schuchardt 
> Cc: alex_...@phoenix.com; david_wri...@phoenix.com;
> lic...@loongson.cn; Stuart Yoder ;
> devel@edk2.groups.io; gao...@byosoft.com.cn
> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Heinrich,
>
>Yes. A new release candidate shall be published after review and upstream
> of the patches.
> Will further send an update.
>
> With Warm Regards,
> Edhay
>
>
> > -Original Message-
> > From: Heinrich Schuchardt 
> > mailto:heinrich.schucha...@canonical.com>>
> > Sent: Tuesday, April 23, 2024 12:46 AM
> > To: G Edhaya Chandran 
> > mailto:edhaya.chand...@arm.com>>
> > Cc: alex_...@phoenix.com; 
> > david_wri...@phoenix.com;
> > lic...@loongson.cn; Stuart Yoder 
> > mailto:stuart.yo...@arm.com>>;
> > devel@edk2.groups.io; 
> > gao...@byosoft.com.cn
> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
> >
> > On 4/16/24 16:53, Stuart Yoder wrote:
> > > This patch series cleans up some issues found when building
> > > edk2-test with a non-GCC compiler:
> > >-TPMT_HA struct had an error due to incorrect use of C flexible
> > > array
> > member
> > >-compute struct member offsets using OFFSET_OF, which is not GCC
> specific
> > >-clean up of #pragma pack in one file
> > >-resolve type conversion warnings
> > >
> > > Patches are in github here:
> > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> > >
> > > Version 2
> > >-add SM3 hash type to TPM2.h
> > >-resolve type conversion warnings
> > >
> > > Stuart Yoder (4):
> > >uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
> > >uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
> > >uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
> > >uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> > >
> > >   uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> > st.h|  3 +--
> > >   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h
> > >  | 17
> > +++--
> > >   uefi-
> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
> > Te stConformance.c | 25 +---
> > >   3 files changed, 27 insertions(+), 18 deletions(-)
> > >
> >
> > Hello Edhaya,
> >
> > Will we have another release candidate with these patches included?
> >
> > Best regards
> >
> > Heinrich

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118565): https://edk2.groups.io/g/devel/message/118565
Mute This Topic: https://groups.io/mt/105898910/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Heinrich Schuchardt


On 27.02.24 07:37, Chao Li wrote:

DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a
bug, code:

SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH)));

DNS is a pointer, which is increased by a structure size and converted
to EFI_IPv4_ADDRESS*, which will point to an unknown address. So fix it.

Fixes: 847e0363e846 ("SctPkg: Fix the UefiSct-Wincompatible-pointer-types 
warnings")

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4712

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Carolyn Gjertsen 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Supreeth Venkatesh 
Cc: Heinrich Schuchardt 
Signed-off-by: Chao Li 
---
  .../BlackBoxTest/DevicePathFromTextBBTestCoverage.c   | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
index c96ee246..bd11c25a 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
@@ -1734,13 +1734,13 @@ CreateDNSDeviceNode (
}
  
if (DNS->IsIPv6 == 0) {

-SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH)));
-SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
+SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)((UINT8 *)DNS + sizeof 
(DNS_DEVICE_PATH)));
+SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)((UINT8 *)DNS + sizeof 
(DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
}
  
if (DNS->IsIPv6 == 1) {

-SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH)));
-SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
+SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)((UINT8 *)DNS + sizeof 
(DNS_DEVICE_PATH)));
+SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)((UINT8 *)DNS + sizeof 
(DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
}
  
return (EFI_DEVICE_PATH_PROTOCOL *) DNS;


Reviewed-by: Heinrich Schuchardt 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116044): https://edk2.groups.io/g/devel/message/116044
Mute This Topic: https://groups.io/mt/104598721/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread G Edhaya Chandran

The patch is upstreamed through the commit:
https://github.com/tianocore/edk2-test/commit/cabb98d44be94e7547605435a0be7c4946d10f8b


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116022): https://edk2.groups.io/g/devel/message/116022
Mute This Topic: https://groups.io/mt/104598721/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Chao Li


Hi Edhay,

OK, thank you!


Thanks,
Chao
On 2024/2/27 17:19, G Edhaya Chandran wrote:


Hi Li Chao,

    As per the maintenance process, I will raise a PR on your behalf 
based on your patch.


And will later close your PR.

With Warm Regards,
Edhay

*From:* Chao Li 
*Sent:* Tuesday, February 27, 2024 1:34 PM
*To:* devel@edk2.groups.io; G Edhaya Chandran 
*Subject:* Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter 
error in DevicePathFromTextBBTestCoverage.c


Hi Edhaya,

Thanks for you review, I have created a PR on Github: 
https://github.com/tianocore/edk2-test/pull/87


Thanks,
Chao

On 2024/2/27 15:50, G Edhaya Chandran wrote:

Hi Li Chao, Thank you for the solution.
Reviewed OK.

Reviewed-by: G Edhaya Chandran 
<mailto:edhaya.chand...@arm.com>



IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended 
recipient, please notify the sender immediately and do not disclose 
the contents to any other person, use it for any purpose, or store or 
copy the information in any medium. Thank you. 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116013): https://edk2.groups.io/g/devel/message/116013
Mute This Topic: https://groups.io/mt/104598721/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread G Edhaya Chandran

Hi Li Chao,

As per the maintenance process, I will raise a PR on your behalf based on 
your patch.
And will later close your PR.

With Warm Regards,
Edhay


From: Chao Li 
Sent: Tuesday, February 27, 2024 1:34 PM
To: devel@edk2.groups.io; G Edhaya Chandran 
Subject: Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in 
DevicePathFromTextBBTestCoverage.c


Hi Edhaya,

Thanks for you review, I have created a PR on Github: 
https://github.com/tianocore/edk2-test/pull/87

Thanks,
Chao
On 2024/2/27 15:50, G Edhaya Chandran wrote:
Hi Li Chao, Thank you for the solution.
Reviewed OK.

Reviewed-by: G Edhaya Chandran 
<mailto:edhaya.chand...@arm.com>

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116012): https://edk2.groups.io/g/devel/message/116012
Mute This Topic: https://groups.io/mt/104598721/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Chao Li


Hi Edhaya,

Thanks for you review, I have created a PR on Github: 
https://github.com/tianocore/edk2-test/pull/87



Thanks,
Chao
On 2024/2/27 15:50, G Edhaya Chandran wrote:

Hi Li Chao, Thank you for the solution.
Reviewed OK.

Reviewed-by: G Edhaya Chandran 




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116008): https://edk2.groups.io/g/devel/message/116008
Mute This Topic: https://groups.io/mt/104598721/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread G Edhaya Chandran

Hi Li Chao, Thank you for the solution.
Reviewed OK.

Reviewed-by: G Edhaya Chandran 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116007): https://edk2.groups.io/g/devel/message/116007
Mute This Topic: https://groups.io/mt/104598721/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread Chao Li

DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a
bug, code:

SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH)));

DNS is a pointer, which is increased by a structure size and converted
to EFI_IPv4_ADDRESS*, which will point to an unknown address. So fix it.

Fixes: 847e0363e846 ("SctPkg: Fix the UefiSct-Wincompatible-pointer-types 
warnings")

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4712

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Carolyn Gjertsen 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Supreeth Venkatesh 
Cc: Heinrich Schuchardt 
Signed-off-by: Chao Li 
---
 .../BlackBoxTest/DevicePathFromTextBBTestCoverage.c   | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
index c96ee246..bd11c25a 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
@@ -1734,13 +1734,13 @@ CreateDNSDeviceNode (
   }
 
   if (DNS->IsIPv6 == 0) {
-SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH)));
-SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
+SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)((UINT8 *)DNS + sizeof 
(DNS_DEVICE_PATH)));
+SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)((UINT8 *)DNS + sizeof 
(DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
   }
 
   if (DNS->IsIPv6 == 1) {
-SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH)));
-SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)(DNS + sizeof 
(DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
+SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)((UINT8 *)DNS + sizeof 
(DNS_DEVICE_PATH)));
+SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)((UINT8 *)DNS + sizeof 
(DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
   }
 
   return (EFI_DEVICE_PATH_PROTOCOL *) DNS;
-- 
2.27.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116004): https://edk2.groups.io/g/devel/message/116004
Mute This Topic: https://groups.io/mt/104598721/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

2024-02-25 Thread Laszlo Ersek

Hello Charles,

On 2/24/24 17:01, Charles Hyde wrote:
> There is a bug in the following source file:
>
> uefi-sct\
>   SctPkg\
>  TestCase\
> UEFI\
>EFI\
>   Protocol\
>  DevicePathFromText\
> BlackBoxTest\
>DevicePathFromTextBBTestCoverage.c
>
>
> Lines 1737, 1738, 1742, and 1743 reference DNS without any cast
> override, which causes the pointer reference logic to be wrong,
> leading the functions SctStrToIPv4Addr and SctStrToIPv6Addr to cause
> memory corruption.  The DNS reference needs to have (UINT8 *) cast
> override, like is done in DevicePathToTextBBTestMain.c.

You are correct, as far as I can tell.

This is a regression from:

commit 847e0363e846296881c238dc43766fd40f6c2aec
Author: Abdul Lateef Attar 
Date:   Thu Jun 9 16:24:02 2022 +0530

SctPkg: Fix the UefiSct -Wincompatible-pointer-types warnings

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2126

Fixes the incompatible pointer types warning for UefiSct package.

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Carolyn Gjertsen 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Supreeth Venkatesh 
Signed-off-by: Abdul Lateef Attar 

 500 files changed, 5537 insertions(+), 1162 deletions(-)

Unfortunately, the change for "DevicePathFromTextBBTestCoverage.c" in
this -- *way* oversized -- patch was incorrect:

> @@ -1734,13 +1734,13 @@ CreateDNSDeviceNode (
>}
>
>if (DNS->IsIPv6 == 0) {
> -SctStrToIPv4Addr (, (UINT8 *)DNS + sizeof (DNS_DEVICE_PATH));
> -SctStrToIPv4Addr (, (UINT8 *)DNS + sizeof (DNS_DEVICE_PATH) + 
> sizeof(EFI_IP_ADDRESS));
> +SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof 
> (DNS_DEVICE_PATH)));
> +SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof 
> (DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
>}
>
>if (DNS->IsIPv6 == 1) {
> -SctStrToIPv6Addr (, (UINT8 *)DNS + sizeof (DNS_DEVICE_PATH));
> -SctStrToIPv6Addr (, (UINT8 *)DNS + sizeof (DNS_DEVICE_PATH) + 
> sizeof(EFI_IP_ADDRESS));
> +SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)(DNS + sizeof 
> (DNS_DEVICE_PATH)));
> +SctStrToIPv6Addr (, (EFI_IPv6_ADDRESS *)(DNS + sizeof 
> (DNS_DEVICE_PATH) + sizeof(EFI_IP_ADDRESS)));
>}
>
>return (EFI_DEVICE_PATH_PROTOCOL *) DNS;

The original (UINT8*) cast was correct for determining the "IPv4Addr"
and "IPv6Addr" argument *values* for SctStrToIPv4Addr() and
SctStrToIPv6Addr(), respectively; the problem was with the argument
*types*. The patch added the necessary outer cast, but incorrectly
removed the still needed inner cast.

... The original code was in poor style to begin with. The following
should work, without any casts at all:

  SctStrToIPv4Addr (, >DnsServerIp[0].v4);
  SctStrToIPv4Addr (, >DnsServerIp[1].v4);

  SctStrToIPv6Addr (, >DnsServerIp[0].v6);
  SctStrToIPv6Addr (, >DnsServerIp[1].v6);

That's because DNS is of type pointer-to-DNS_DEVICE_PATH, and
DNS_DEVICE_PATH is defined as follows, in
"MdePkg/Include/Protocol/DevicePath.h":

> #pragma pack(1)
> ...
> typedef struct {
>   EFI_DEVICE_PATH_PROTOCOLHeader;
>   ///
>   /// Indicates the DNS server address is IPv4 or IPv6 address.
>   ///
>   UINT8   IsIPv6;
>   ///
>   /// Instance of the DNS server address.
>   ///
>   EFI_IP_ADDRESS  DnsServerIp[];
> } DNS_DEVICE_PATH;
> ...
> #pragma pack()

and "EFI_IP_ADDRESS" is defined in "MdePkg/Include/Uefi/UefiBaseType.h"
as follows:

> typedef union {
>   UINT32  Addr[4];
>   EFI_IPv4_ADDRESSv4;
>   EFI_IPv6_ADDRESSv6;
> } EFI_IP_ADDRESS;

The "DnsServerIp" flexible array member should simply be put to use.

AbduL, can you please post a fix?

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115930): https://edk2.groups.io/g/devel/message/115930
Mute This Topic: https://groups.io/mt/104548292/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

2024-02-24 Thread Charles Hyde


There is a bug in the following source file:

uefi-sct\
  SctPkg\
 TestCase\
UEFI\
   EFI\
  Protocol\
 DevicePathFromText\
BlackBoxTest\
   DevicePathFromTextBBTestCoverage.c


Lines 1737, 1738, 1742, and 1743 reference DNS without any cast override, 
which causes the pointer reference logic to be wrong, leading the functions 
SctStrToIPv4Addr and SctStrToIPv6Addr to cause memory corruption.  The DNS 
reference needs to have (UINT8 *) cast override, like is done in 
DevicePathToTextBBTestMain.c.


Regards,
Chip 




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115906): https://edk2.groups.io/g/devel/message/115906
Mute This Topic: https://groups.io/mt/104548292/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 0/4] uefi-sct/SctPkg: Add SCT Documents

2024-02-20 Thread G Edhaya Chandran

Thank you Samer.

The test case spec is consolidated and upstreamed by: 
https://github.com/tianocore/edk2-test/commit/f999690054b56780f5efbe0999507d7176bd87f6


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115661): https://edk2.groups.io/g/devel/message/115661
Mute This Topic: https://groups.io/mt/76416700/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2023-07-20 Thread Ard Biesheuvel

On Thu, 20 Jul 2023 at 16:30, G Edhaya Chandran  wrote:
>
> The patch is upstreamed by: 
> https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4

Checking the memory map for memory below 4G only makes sense if the
system has no IOMMU and does not use translation for inbound PCI
transactions.

So the patch seems rather dubious to me.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107105): https://edk2.groups.io/g/devel/message/107105
Mute This Topic: https://groups.io/mt/94228672/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2023-07-20 Thread G Edhaya Chandran

The patch is upstreamed by: 
https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107101): https://edk2.groups.io/g/devel/message/107101
Mute This Topic: https://groups.io/mt/94228672/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test]

2023-07-18 Thread Andrew Fish via groups.io

John,

The UEFI Forum (https://uefi.org/) is the industry trade group that owns the 
UEFI and ACPI specifications. It also hosts the SCTs: https://uefi.org/testtools

Thanks,

Andrew Fish

> On Jul 17, 2023, at 9:31 AM, Sellock, John via groups.io 
>  wrote:
> 
> Hello,
>  
> I am John Sellock, an Associate Software Engineering Technician at Leonardo 
> DRS.
> I believe I need Self-Certification Test source code for UEFI 2.5, but I 
> cannot find any saved archive for it available in the tianocore or edk2-test 
> repositories.
> I would appreciate if someone could point me in the right direction, if I 
> overlooked it, or let me know if archived SCT source are no longer available 
> by any means.
> 
> Thank you,
> John Sellock
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107018): https://edk2.groups.io/g/devel/message/107018
Mute This Topic: https://groups.io/mt/100212052/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test]

2023-07-18 Thread Sellock, John via groups.io

Hello,

 

I am John Sellock, an Associate Software Engineering Technician at Leonardo
DRS.

I believe I need Self-Certification Test source code for UEFI 2.5, but I
cannot find any saved archive for it available in the tianocore or edk2-test
repositories.
I would appreciate if someone could point me in the right direction, if I
overlooked it, or let me know if archived SCT source are no longer available
by any means.

Thank you,

John Sellock



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106987): https://edk2.groups.io/g/devel/message/106987
Mute This Topic: https://groups.io/mt/100212052/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




smime.p7s
Description: S/MIME cryptographic signature

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2022-12-01 Thread Sunny Wang

Reviewed the patch with Stuart and Edhaya in edk2-test monthly meeting. The 
patch looks good to me. Thanks, Dimitrije.

Reviewed-by: Sunny Wang 

-Original Message-
From: Dimitrije Pavlov 
Sent: 10 October 2022 03:06
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Jeff Booher-Kaeding 
; Samer El-Haj-Mahmoud 
; Sunny Wang 
Subject: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4009

Check if there is usable memory below 4 GiB before testing for
allocation without the EFI_PCI_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute.

Cc: G Edhaya Chandran 
Cc: Jeff Booher-Kaeding 
Cc: Samer El-Haj-Mahmoud 
Cc: Sunny Wang 

Signed-off-by: Dimitrije Pavlov 
---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
 | 142 +++-
 1 file changed, 140 insertions(+), 2 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
index 89adcba91e70..fafbf62f77c6 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
@@ -4118,7 +4118,69 @@ AllocateBuffer_Func (
   UINTNAttributesNum;
   EFI_PCI_ROOT_BRIDGE_IO_DEVICE*RBDev;
   EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL  *RootBridgeIo;
+  EFI_MEMORY_DESCRIPTOR*MemoryMap;
+  EFI_MEMORY_DESCRIPTOR*Entry;
+  UINTNMemoryMapSize;
+  UINTNMapKey;
+  UINTNDescriptorSize;
+  UINT32   DescriptorVersion;
+  UINTNIterator;
+  BOOLEAN  UsableMemoryBelow4G;

+  //
+  // Obtain the memory map size
+  //
+  MemoryMapSize = 0;
+  Status = gBS->GetMemoryMap (
+  ,
+  NULL,
+  ,
+  ,
+  
+  );
+  ASSERT (Status == EFI_BUFFER_TOO_SMALL);
+  //
+  // Allocating a buffer for the memory map will change
+  // the memory map, so we increase the size here just in case
+  //
+  MemoryMapSize += EFI_PAGE_SIZE;
+  Status = gBS->AllocatePool (
+  EfiLoaderData,
+  MemoryMapSize,
+  (VOID **)
+  );
+  if (EFI_ERROR (Status)) {
+return Status;
+  }
+  //
+  // Get the actual memory map
+  //
+  Status = gBS->GetMemoryMap (
+  ,
+  MemoryMap,
+  ,
+  ,
+  
+  );
+  if (EFI_ERROR (Status)) {
+gBS->FreePool (MemoryMap);
+  }
+
+  //
+  // Check each entry in the memory map for free memory below 4 GiB and set
+  // UsableMemoryBelow4G accordingly
+  //
+  UsableMemoryBelow4G = FALSE;
+  for (Iterator = 0; Iterator < MemoryMapSize; Iterator += DescriptorSize) {
+Entry = (EFI_MEMORY_DESCRIPTOR *)((UINTN)MemoryMap + Iterator);
+if ( Entry->PhysicalStart < (EFI_PHYSICAL_ADDRESS)SIZE_4GB
+  && ( Entry->Type == EfiConventionalMemory || Entry->Type == 
EfiPersistentMemory))
+{
+  UsableMemoryBelow4G = TRUE;
+  break;
+}
+  }
+  gBS->FreePool (MemoryMap);

   AllocateType = 0;

@@ -4188,7 +4250,14 @@ AllocateBuffer_Func (

   for (MemoryTypeNum = 0; MemoryTypeNum < 2; MemoryTypeNum++) {
 for (AttributesNum = 0; AttributesNum < 8; AttributesNum++) {
-
+  //
+  // If there is no usable memory below 4 GiB, skip 32-bit allocations
+  //
+  if ( !UsableMemoryBelow4G
+&& !(Attributes[AttributesNum] & EFI_PCI_ATTRIBUTE_DUAL_ADDRESS_CYCLE))
+  {
+continue;
+  }
   Status = RootBridgeIo->AllocateBuffer (
RootBridgeIo,
AllocateType,
@@ -4298,7 +4367,69 @@ FreeBuffer_Func (
   UINTNAttributesNum;
   EFI_PCI_ROOT_BRIDGE_IO_DEVICE*RBDev;
   EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL  *RootBridgeIo;
+  EFI_MEMORY_DESCRIPTOR*MemoryMap;
+  EFI_MEMORY_DESCRIPTOR*Entry;
+  UINTNMemoryMapSize;
+  UINTNMapKey;
+  UINTNDescriptorSize;
+  UINT32   DescriptorVersion;
+  UINTNIterator;
+  BOOLEAN  UsableMemoryBelow4G;

+  //
+  // Obtain the memory map size
+  //
+  MemoryMapSize = 0;
+

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2022-12-01 Thread G Edhaya Chandran

Reviewed-by: G Edhaya Chandran 

Refactoring suggestion: Can the code for checking of the UsableMemoryBelow4G 
moved to a function? Since it is used in two places.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96831): https://edk2.groups.io/g/devel/message/96831
Mute This Topic: https://groups.io/mt/94228672/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2022-11-29 Thread G Edhaya Chandran

Hi Dimitrije,

For some cases, the above solution may not scale for a system that is capable 
of allocating 64 bit addresses (> 4 GiB).
This may prevent the test from running the full coverage on 64 bit system.

A possible case:
The UEFI-SCT is executing this test on a 64 bit machine.
So far, the memory map contains the ranges only within 4 GB (however this does 
not prevent AllocateBuffer to allocate further higher memory).
After the fix the test will not exercise the cases of AllocateBuffer with 
attribute EFI_PCI_ATTRIBUTE_DUAL_ADDRESS_CYCLE

With Warm Regards,

Edhay


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96670): https://edk2.groups.io/g/devel/message/96670
Mute This Topic: https://groups.io/mt/94228672/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2022-10-09 Thread Dimitrije Pavlov

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4009

Check if there is usable memory below 4 GiB before testing for
allocation without the EFI_PCI_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute.

Cc: G Edhaya Chandran 
Cc: Jeff Booher-Kaeding 
Cc: Samer El-Haj-Mahmoud 
Cc: Sunny Wang 

Signed-off-by: Dimitrije Pavlov 
---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
 | 142 +++-
 1 file changed, 140 insertions(+), 2 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
index 89adcba91e70..fafbf62f77c6 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PciRootBridgeIo/BlackBoxTest/PciRootBridgeIoBBTestFunction_2.c
@@ -4118,7 +4118,69 @@ AllocateBuffer_Func (
   UINTNAttributesNum;
   EFI_PCI_ROOT_BRIDGE_IO_DEVICE*RBDev;
   EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL  *RootBridgeIo;
+  EFI_MEMORY_DESCRIPTOR*MemoryMap;
+  EFI_MEMORY_DESCRIPTOR*Entry;
+  UINTNMemoryMapSize;
+  UINTNMapKey;
+  UINTNDescriptorSize;
+  UINT32   DescriptorVersion;
+  UINTNIterator;
+  BOOLEAN  UsableMemoryBelow4G;
 
+  //
+  // Obtain the memory map size
+  //
+  MemoryMapSize = 0;
+  Status = gBS->GetMemoryMap (
+  ,
+  NULL,
+  ,
+  ,
+  
+  );
+  ASSERT (Status == EFI_BUFFER_TOO_SMALL);
+  //
+  // Allocating a buffer for the memory map will change
+  // the memory map, so we increase the size here just in case
+  //
+  MemoryMapSize += EFI_PAGE_SIZE;
+  Status = gBS->AllocatePool (
+  EfiLoaderData,
+  MemoryMapSize,
+  (VOID **)
+  );
+  if (EFI_ERROR (Status)) {
+return Status;
+  }
+  //
+  // Get the actual memory map
+  //
+  Status = gBS->GetMemoryMap (
+  ,
+  MemoryMap,
+  ,
+  ,
+  
+  );
+  if (EFI_ERROR (Status)) {
+gBS->FreePool (MemoryMap);
+  }
+
+  //
+  // Check each entry in the memory map for free memory below 4 GiB and set
+  // UsableMemoryBelow4G accordingly
+  //
+  UsableMemoryBelow4G = FALSE;
+  for (Iterator = 0; Iterator < MemoryMapSize; Iterator += DescriptorSize) {
+Entry = (EFI_MEMORY_DESCRIPTOR *)((UINTN)MemoryMap + Iterator);
+if ( Entry->PhysicalStart < (EFI_PHYSICAL_ADDRESS)SIZE_4GB
+  && ( Entry->Type == EfiConventionalMemory || Entry->Type == 
EfiPersistentMemory))
+{
+  UsableMemoryBelow4G = TRUE;
+  break;
+}
+  }
+  gBS->FreePool (MemoryMap);
 
   AllocateType = 0;
 
@@ -4188,7 +4250,14 @@ AllocateBuffer_Func (
 
   for (MemoryTypeNum = 0; MemoryTypeNum < 2; MemoryTypeNum++) {
 for (AttributesNum = 0; AttributesNum < 8; AttributesNum++) {
-
+  //
+  // If there is no usable memory below 4 GiB, skip 32-bit allocations
+  //
+  if ( !UsableMemoryBelow4G
+&& !(Attributes[AttributesNum] & EFI_PCI_ATTRIBUTE_DUAL_ADDRESS_CYCLE))
+  {
+continue;
+  }
   Status = RootBridgeIo->AllocateBuffer (
RootBridgeIo,
AllocateType,
@@ -4298,7 +4367,69 @@ FreeBuffer_Func (
   UINTNAttributesNum;
   EFI_PCI_ROOT_BRIDGE_IO_DEVICE*RBDev;
   EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL  *RootBridgeIo;
+  EFI_MEMORY_DESCRIPTOR*MemoryMap;
+  EFI_MEMORY_DESCRIPTOR*Entry;
+  UINTNMemoryMapSize;
+  UINTNMapKey;
+  UINTNDescriptorSize;
+  UINT32   DescriptorVersion;
+  UINTNIterator;
+  BOOLEAN  UsableMemoryBelow4G;
 
+  //
+  // Obtain the memory map size
+  //
+  MemoryMapSize = 0;
+  Status = gBS->GetMemoryMap (
+  ,
+  NULL,
+  ,
+  ,
+  
+  );
+  ASSERT (Status == EFI_BUFFER_TOO_SMALL);
+  //
+  // Allocating a buffer for the memory map will change
+  // the memory map, so we increase the size here just in case
+  //
+  MemoryMapSize += EFI_PAGE_SIZE;
+  Status = gBS->AllocatePool (
+

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-07-19 Thread G Edhaya Chandran

Upstreamed through commit : 
https://github.com/tianocore/edk2-test/commit/4a25c3b3c79f63bd9f98b4fffcb21b5c66dd14bb


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91525): https://edk2.groups.io/g/devel/message/91525
Mute This Topic: https://groups.io/mt/92068027/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-07-19 Thread G Edhaya Chandran

Reviewed-by: G Edhaya Chandran 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91524): https://edk2.groups.io/g/devel/message/91524
Mute This Topic: https://groups.io/mt/92068027/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-07-14 Thread Sunny Wang

Looks good to me. Thanks for fixing the issue, Dimitrije.
Add Chandni. She has run into this issue as well.

Reviewed-by: Sunny Wang 

-Original Message-
From: Dimitrije Pavlov 
Sent: 29 June 2022 16:59
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Jeff Booher-Kaeding 
; Samer El-Haj-Mahmoud 
; Sunny Wang ; Jeremy Linton 

Subject: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check 
PixelInformation

According to UEFI 2.9 Section 12.9, the PixelInformation field of the
EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure is valid only if
PixelFormat is PixelBitMask. The current implementation always checks
the contents of PixelInformation field of the
EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure returned by QueryMode,
regardless of PixelFormat. Check PixelInformation only if
PixelFormat is PixelBitMask.

Cc: G Edhaya Chandran 
Cc: Jeff Booher-Kaeding 
Cc: Samer El-Haj-Mahmoud 
Cc: Sunny Wang 
Cc: Jeremy Linton 

Signed-off-by: Dimitrije Pavlov 
---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
 | 30 ++--
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
| 19 +
 2 files changed, 35 insertions(+), 14 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
index 13e7227f5845..b2bff9d756b1 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
@@ -493,16 +493,28 @@ Returns:
  );
   if (Status != EFI_SUCCESS) {
 AssertionType = EFI_TEST_ASSERTION_FAILED;
-  }   else {
+  } else {
 AssertionType = EFI_TEST_ASSERTION_PASSED;
-  }
-
-  if (SctCompareMem (
-  (void *) info,
-  (void *) GraphicsOutput->Mode->Info,
-  sizeof (EFI_GRAPHICS_OUTPUT_MODE_INFORMATION)
-  ) != 0) {
-AssertionType = EFI_TEST_ASSERTION_FAILED;
+if (info != NULL) {
+  //
+  // PixelInformation is checked only if PixelFormat is PixelBitMask
+  //
+  if ( info->Version  != 
GraphicsOutput->Mode->Info->Version
+|| info->HorizontalResolution != 
GraphicsOutput->Mode->Info->HorizontalResolution
+|| info->VerticalResolution   != 
GraphicsOutput->Mode->Info->VerticalResolution
+|| info->PixelFormat  != 
GraphicsOutput->Mode->Info->PixelFormat
+|| info->PixelsPerScanLine!= 
GraphicsOutput->Mode->Info->PixelsPerScanLine
+|| ( info->PixelFormat == PixelBitMask
+  && ( info->PixelInformation.RedMask  != 
GraphicsOutput->Mode->Info->PixelInformation.RedMask
+|| info->PixelInformation.GreenMask!= 
GraphicsOutput->Mode->Info->PixelInformation.GreenMask
+|| info->PixelInformation.BlueMask != 
GraphicsOutput->Mode->Info->PixelInformation.BlueMask
+|| info->PixelInformation.ReservedMask != 
GraphicsOutput->Mode->Info->PixelInformation.ReservedMask)))
+  {
+AssertionType = EFI_TEST_ASSERTION_FAILED;
+  }
+} else {
+  AssertionType = EFI_TEST_ASSERTION_FAILED;
+}
   }

   if (info != NULL) {
diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
index da51fbc44596..f31ea8175af8 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
@@ -125,11 +125,20 @@ Returns:
 } else {
   AssertionType = EFI_TEST_ASSERTION_PASSED;
   if (Info != NULL) {
-if (SctCompareMem (
-(void *) Info,
-(void *) GraphicsOutput->Mode->Info,
-sizeof (EFI_GRAPHICS_OUTPUT_MODE_INFORMATION)
-) != 0) {
+//
+// PixelInformation is checked only if PixelFormat is PixelBitMask
+//
+if ( Info->Version  != GraphicsOutput->Mode->Info->Version
+  || Info->HorizontalResolution != 
GraphicsOutput->Mode->Info->HorizontalResolution
+  || Info->VerticalResolution   != 
GraphicsOutput->Mode->Info->VerticalResolution
+  || Info->PixelFormat  != 
GraphicsOutput->Mode->Info->PixelFormat
+  || Info->PixelsPerScanLine!= 
GraphicsOutput->Mode->Info->PixelsPerScanLine
+  || ( Info->PixelFormat == PixelBitMask
+&& (

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-06-29 Thread Dimitrije Pavlov

According to UEFI 2.9 Section 12.9, the PixelInformation field of the
EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure is valid only if
PixelFormat is PixelBitMask. The current implementation always checks
the contents of PixelInformation field of the
EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure returned by QueryMode,
regardless of PixelFormat. Check PixelInformation only if
PixelFormat is PixelBitMask.

Cc: G Edhaya Chandran 
Cc: Jeff Booher-Kaeding 
Cc: Samer El-Haj-Mahmoud 
Cc: Sunny Wang 
Cc: Jeremy Linton 

Signed-off-by: Dimitrije Pavlov 
---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
 | 30 ++--
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
| 19 +
 2 files changed, 35 insertions(+), 14 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
index 13e7227f5845..b2bff9d756b1 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c
@@ -493,16 +493,28 @@ Returns:
  );
   if (Status != EFI_SUCCESS) {
 AssertionType = EFI_TEST_ASSERTION_FAILED;
-  }   else {
+  } else {
 AssertionType = EFI_TEST_ASSERTION_PASSED;
-  }
-
-  if (SctCompareMem (
-  (void *) info,
-  (void *) GraphicsOutput->Mode->Info,
-  sizeof (EFI_GRAPHICS_OUTPUT_MODE_INFORMATION)
-  ) != 0) {
-AssertionType = EFI_TEST_ASSERTION_FAILED;
+if (info != NULL) {
+  //
+  // PixelInformation is checked only if PixelFormat is PixelBitMask
+  //
+  if ( info->Version  != 
GraphicsOutput->Mode->Info->Version
+|| info->HorizontalResolution != 
GraphicsOutput->Mode->Info->HorizontalResolution
+|| info->VerticalResolution   != 
GraphicsOutput->Mode->Info->VerticalResolution
+|| info->PixelFormat  != 
GraphicsOutput->Mode->Info->PixelFormat
+|| info->PixelsPerScanLine!= 
GraphicsOutput->Mode->Info->PixelsPerScanLine
+|| ( info->PixelFormat == PixelBitMask
+  && ( info->PixelInformation.RedMask  != 
GraphicsOutput->Mode->Info->PixelInformation.RedMask
+|| info->PixelInformation.GreenMask!= 
GraphicsOutput->Mode->Info->PixelInformation.GreenMask
+|| info->PixelInformation.BlueMask != 
GraphicsOutput->Mode->Info->PixelInformation.BlueMask
+|| info->PixelInformation.ReservedMask != 
GraphicsOutput->Mode->Info->PixelInformation.ReservedMask)))
+  {
+AssertionType = EFI_TEST_ASSERTION_FAILED;
+  }
+} else {
+  AssertionType = EFI_TEST_ASSERTION_FAILED;
+}
   }

   if (info != NULL) {
diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
index da51fbc44596..f31ea8175af8 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c
@@ -125,11 +125,20 @@ Returns:
 } else {
   AssertionType = EFI_TEST_ASSERTION_PASSED;
   if (Info != NULL) {
-if (SctCompareMem (
-(void *) Info,
-(void *) GraphicsOutput->Mode->Info,
-sizeof (EFI_GRAPHICS_OUTPUT_MODE_INFORMATION)
-) != 0) {
+//
+// PixelInformation is checked only if PixelFormat is PixelBitMask
+//
+if ( Info->Version  != GraphicsOutput->Mode->Info->Version
+  || Info->HorizontalResolution != 
GraphicsOutput->Mode->Info->HorizontalResolution
+  || Info->VerticalResolution   != 
GraphicsOutput->Mode->Info->VerticalResolution
+  || Info->PixelFormat  != 
GraphicsOutput->Mode->Info->PixelFormat
+  || Info->PixelsPerScanLine!= 
GraphicsOutput->Mode->Info->PixelsPerScanLine
+  || ( Info->PixelFormat == PixelBitMask
+&& ( Info->PixelInformation.RedMask  != 
GraphicsOutput->Mode->Info->PixelInformation.RedMask
+  || Info->PixelInformation.GreenMask!= 
GraphicsOutput->Mode->Info->PixelInformation.GreenMask
+  || Info->PixelInformation.BlueMask != 
GraphicsOutput->Mode->Info->PixelInformation.BlueMask
+  || Info->PixelInformation.ReservedMask != 
GraphicsOutput->Mode->Info->PixelInformation.ReservedMask)))
+{

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

2022-02-02 Thread G Edhaya Chandran

Solution is upstreamed through commit: 
https://github.com/tianocore/edk2-test/commit/d919c4a5d9fe2681de4d11a0bbfb07373fe6f9c7


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86356): https://edk2.groups.io/g/devel/message/86356
Mute This Topic: https://groups.io/mt/88360183/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow some SNP functions to return EFI_UNSUPPORTED

2022-02-02 Thread G Edhaya Chandran

The solution is upstreamed through commit-id: 
https://github.com/tianocore/edk2-test/commit/733a11dceaa043e9e5f95e9e224442f134d0975f


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86355): https://edk2.groups.io/g/devel/message/86355
Mute This Topic: https://groups.io/mt/88360239/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

2022-01-31 Thread G Edhaya Chandran

Reviewed-by: G Edhaya Chandran 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86252): https://edk2.groups.io/g/devel/message/86252
Mute This Topic: https://groups.io/mt/88360183/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow some SNP functions to return EFI_UNSUPPORTED

2022-01-31 Thread G Edhaya Chandran

Reviewed-by: G Edhaya Chandran 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86250): https://edk2.groups.io/g/devel/message/86250
Mute This Topic: https://groups.io/mt/88360239/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

2022-01-31 Thread Sunny Wang

I'm just aware that it is difficult to review this patch as it includes white 
space changes (Trimming the trailing space and transferring TABs to spaces) for 
edk2 coding-standard compliance.
Therefore, please use the link below that hides white spaces changes to review 
the changes. Thanks for Edhaya's offline reminder!

https://github.com/sunnywang-arm/edk2-test/pull/1/files?diff=unified=1

Best Regards,
Sunny
-Original Message-
From: devel@edk2.groups.io  On Behalf Of Sunny Wang via 
groups.io
Sent: 11 January 2022 21:53
To: devel@edk2.groups.io
Cc: Sunny Wang ; G Edhaya Chandran 
; Barton Gao ; Carolyn Gjertsen 
; Heinrich Schuchardt 
; Samer El-Haj-Mahmoud 
; Sunny Wang 
Subject: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow 
SimpleTextOut SetMode to return EFI_UNSUPPORTED

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3738

The SimpleTestOut test cases don't allow SetMode to return
EFI_UNSUPPORTED, which doesn't comply with UEFI spec.

UEFI spec allows EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetMode function to
return EFI_UNSUPPORTED for the condition below:

if the output devices support 80x50, that is defined to be mode 1.
All other text dimensions supported by the device will follow as
modes 2 and above. If an output device supports modes 2 and above,
but does not support 80x50, then querying for mode 1 will return
EFI_UNSUPPORTED.

Therefore, update the test cases to fix this issue.

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Carolyn Gjertsen 
Cc: Heinrich Schuchardt 
Cc: Samer El-Haj-Mahmoud 

Signed-off-by: Sunny Wang 
---
 .../SimpleTextOutBBTestConformance_efi.c  |  13 +-
 .../SimpleTextOutBBTestConformance_uefi.c |  15 +-
 .../SimpleTextOutBBTestFunction_efi.c |  46 +-
 .../SimpleTextOutBBTestFunction_uefi.c| 349 +
 .../SimpleTextOutBBTestConformance_uefi.c |  15 +-
 .../SimpleTextOutBBTestFunction_uefi.c| 715 +-
 6 files changed, 623 insertions(+), 530 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_efi.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_efi.c
index 8b8c3f86..d3861e3c 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_efi.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_efi.c
@@ -2,15 +2,16 @@

   Copyright 2006 - 2016 Unified EFI, Inc.
   Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.
+  Copyright (c) 2022, ARM Limited. All rights reserved.

   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at
+  which accompanies this distribution.  The full text of the license may be 
found at
   http://opensource.org/licenses/bsd-license.php
-
+
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
+
 **/
 /*++

@@ -761,7 +762,11 @@ BBTestSetCursorPositionConformanceAutoTest (
 //
 Status = SimpleOut->SetMode (SimpleOut, Mode);
 if (EFI_ERROR(Status)) {
-  AssertionType = EFI_TEST_ASSERTION_FAILED;
+  if (EFI_UNSUPPORTED == Status) {
+AssertionType = EFI_TEST_ASSERTION_PASSED;
+  } else {
+AssertionType = EFI_TEST_ASSERTION_FAILED;
+  }
   StandardLib->RecordAssertion (
  StandardLib,
  AssertionType,
diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c
index 99e14d7b..555f78e7 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c
@@ -2,15 +2,16 @@

   Copyright 2006 - 2016 Unified EFI, Inc.
   Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.
+  Copyright (c) 2022, ARM Limited. All rights reserved.

   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at
+  which accompanies this distribution.  The full text of the license may be 
found at
   http://opensource.org/licenses/bsd-license.php
-
+
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
+
 **/
 /*++

@@ -82,7 +83,7 @@ BBTestQueryModeConformanceAutoTest (

[edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

2022-01-11 Thread Sunny Wang

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3738

The SimpleTestOut test cases don't allow SetMode to return
EFI_UNSUPPORTED, which doesn't comply with UEFI spec.

UEFI spec allows EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetMode function to
return EFI_UNSUPPORTED for the condition below:

if the output devices support 80x50, that is defined to be mode 1.
All other text dimensions supported by the device will follow as
modes 2 and above. If an output device supports modes 2 and above,
but does not support 80x50, then querying for mode 1 will return
EFI_UNSUPPORTED.

Therefore, update the test cases to fix this issue.

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Carolyn Gjertsen 
Cc: Heinrich Schuchardt 
Cc: Samer El-Haj-Mahmoud 

Signed-off-by: Sunny Wang 
---
 .../SimpleTextOutBBTestConformance_efi.c  |  13 +-
 .../SimpleTextOutBBTestConformance_uefi.c |  15 +-
 .../SimpleTextOutBBTestFunction_efi.c |  46 +-
 .../SimpleTextOutBBTestFunction_uefi.c| 349 +
 .../SimpleTextOutBBTestConformance_uefi.c |  15 +-
 .../SimpleTextOutBBTestFunction_uefi.c| 715 +-
 6 files changed, 623 insertions(+), 530 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_efi.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_efi.c
index 8b8c3f86..d3861e3c 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_efi.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_efi.c
@@ -2,15 +2,16 @@
 
   Copyright 2006 - 2016 Unified EFI, Inc.
   Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.
+  Copyright (c) 2022, ARM Limited. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at 
+  which accompanies this distribution.  The full text of the license may be 
found at
   http://opensource.org/licenses/bsd-license.php
- 
+
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
- 
+
 **/
 /*++
 
@@ -761,7 +762,11 @@ BBTestSetCursorPositionConformanceAutoTest (
 //
 Status = SimpleOut->SetMode (SimpleOut, Mode);
 if (EFI_ERROR(Status)) {
-  AssertionType = EFI_TEST_ASSERTION_FAILED;
+  if (EFI_UNSUPPORTED == Status) {
+AssertionType = EFI_TEST_ASSERTION_PASSED;
+  } else {
+AssertionType = EFI_TEST_ASSERTION_FAILED;
+  }
   StandardLib->RecordAssertion (
  StandardLib,
  AssertionType,
diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c
index 99e14d7b..555f78e7 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c
@@ -2,15 +2,16 @@
 
   Copyright 2006 - 2016 Unified EFI, Inc.
   Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.
+  Copyright (c) 2022, ARM Limited. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at 
+  which accompanies this distribution.  The full text of the license may be 
found at
   http://opensource.org/licenses/bsd-license.php
- 
+
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
- 
+
 **/
 /*++
 
@@ -82,7 +83,7 @@ BBTestQueryModeConformanceAutoTest (
);
 return Status;
   }
-   
+
   SimpleOut = (EFI_SIMPLE_TEXT_OUT_PROTOCOL *)ClientInterface;
 
   //
@@ -759,7 +760,11 @@ BBTestSetCursorPositionConformanceAutoTest (
 //
 Status = SimpleOut->SetMode (SimpleOut, Mode);
 if (EFI_ERROR(Status)) {
-  AssertionType = EFI_TEST_ASSERTION_FAILED;
+  if (EFI_UNSUPPORTED == Status) {
+AssertionType = EFI_TEST_ASSERTION_PASSED;
+  } else {
+AssertionType = EFI_TEST_ASSERTION_FAILED;
+  }
   StandardLib->RecordAssertion (
  StandardLib,
  AssertionType,
diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestFunction_efi.c

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-11-12 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io

[Public]

Hi Heinrich,
Not able to attach the patch to the below Bugzilla link (yet to create 
an account).
Hence attaching the patch with this mail.

Also find the reference branch link below.
https://github.com/abdattar/edk2-test/tree/X64_GCC_Compilation_fix

Thanks
AbduL


-Original Message-
From: devel@edk2.groups.io  On Behalf Of Heinrich 
Schuchardt via groups.io
Sent: 11 November 2021 21:08
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) 

Cc: G Edhaya Chandran ; Barton Gao 
; Gjertsen, Carolyn ; Samer 
El-Haj-Mahmoud ; Eric Jin ; 
Arvin Chen ; Venkatesh, Supreeth 

Subject: Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build 
errors for GCC toolchain

[CAUTION: External Email]

On 10/26/21 13:42, Abdul Lateef Attar via groups.io wrote:
> Corrects the function declaration/definition by adding EFIAPI.
> Removes duplicate functions.


Unfortunately this mail is not a valid patch:

$ wget 
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchew.org%2FEDK2%2F20211026114226.30761-1-abdattar%40amd.com%2Fmboxdata=04%7C01%7CAbdulLateef.Attar%40amd.com%7C69f89e5e843d4f4c090408d9a5295496%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637722419244229218%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=O69zx8gRDRS9%2B4bGupVaKV8R%2FBDQ6fNhz00pVzb9h3w%3Dreserved=0
$ git am mbox --keep-cr
Applying: SctPkg: Fix X64 build errors for GCC toolchain
error: patch fragment without header at line 246: @@ -84,6 +85,7 @@ 
InitializeHIIStringBBTest ( Patch failed at 0001 SctPkg: Fix X64 build errors 
for GCC toolchain

Could you, please, upload the patch to
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2126data=04%7C01%7CAbdulLateef.Attar%40amd.com%7C69f89e5e843d4f4c090408d9a5295496%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637722419244239170%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=mE96wdLHZwXHoneiPcImLwvMLaohiwuYRuuaKQUzY4o%3Dreserved=0

Best regards

Heinrich






-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83694): https://edk2.groups.io/g/devel/message/83694
Mute This Topic: https://groups.io/mt/86600279/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




0001-SctPkg-Fix-X64-build-errors-for-GCC-toolchain.patch
Description: 0001-SctPkg-Fix-X64-build-errors-for-GCC-toolchain.patch

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-11-11 Thread Heinrich Schuchardt


On 10/26/21 13:42, Abdul Lateef Attar via groups.io wrote:

Corrects the function declaration/definition
by adding EFIAPI.
Removes duplicate functions.



Unfortunately this mail is not a valid patch:

$ wget https://patchew.org/EDK2/20211026114226.30761-1-abdat...@amd.com/mbox
$ git am mbox --keep-cr
Applying: SctPkg: Fix X64 build errors for GCC toolchain
error: patch fragment without header at line 246: @@ -84,6 +85,7 @@
InitializeHIIStringBBTest (
Patch failed at 0001 SctPkg: Fix X64 build errors for GCC toolchain

Could you, please, upload the patch to
https://bugzilla.tianocore.org/show_bug.cgi?id=2126

Best regards

Heinrich


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83654): https://edk2.groups.io/g/devel/message/83654
Mute This Topic: https://groups.io/mt/86600279/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-10-26 Thread Abdul Lateef Attar via groups.io

Corrects the function declaration/definition
by adding EFIAPI.
Removes duplicate functions.

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Carolyn Gjertsen 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Supreeth Venkatesh 
Signed-off-by: Abdul Lateef Attar 
---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIFontEx/BlackBoxTest/HIIFontExBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIImage/BlackBoxTest/HIIImageBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIImageEx/BlackBoxTest/HIIImageExBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIString/BlackBoxTest/HIIStringBBTestMain.h
|  3 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/LoadedImage/BlackBoxTest/LoadedImageBBTest.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PartitionInfo/BlackBoxTest/PartitionInfoBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ResetNotification/BlackBoxTest/ResetNotificationBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemBBTest.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextIn/BlackBoxTest/SimpleTextInBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_efi.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_uefi.h
   |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UFSDeviceConfig/BlackBoxTest/UFSDeviceConfigBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemBBTest.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextIn/BlackBoxTest/SimpleTextInBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_uefi.h
   |  1 +
 uefi-sct/SctPkg/SCRT/SCRTDriver/ia32/Debug.c   
|  9 --
 uefi-sct/SctPkg/SCRT/SCRTDriver/x64/Debug.c
|  9 --
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/AddressResolutionProtocol/Arp/ArpENTSTest.c
 |  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/AddressResolutionProtocol/ArpServiceBinding/ArpServiceBindingENTSTest.c
 |  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp4/Dhcp4/Dhcp4ENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp4/Dhcp4SB/Dhcp4SBENTSTest.c 
|  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp6/Dhcp6/Dhcp6ENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp6/Dhcp6SB/Dhcp6SBENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Http/Http/HttpENTSTest.c
|  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/Http/HttpServiceBinding/HttpServiceBindingENTSTest.c
|  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4/Ip4ENTSTest.c 
|  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4Config/Ip4ConfigENTSTest.c
 |  3 ++
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4Config2/Ip4Config2ENTSTest.c
   |  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4ServiceBinding/Ip4ServiceBindingENTSTest.c
 |  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol6/Ip6/Ip6ENTSTest.c 
|  3 ++
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol6/Ip6Config/Ip6ConfigENTSTest.c
 |  3

[edk2-devel] [edk2-test] [PATCH v1 0/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-10-26 Thread Abdul Lateef Attar via groups.io

Resubmitting patch with correct format and email ids.
Corrects the function declaration/definition
by adding EFIAPI.
Removes duplicate functions.


Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Carolyn Gjertsen 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Supreeth Venkatesh 
Signed-off-by: Abdul Lateef Attar 
---
*** BLURB HERE ***

Abdul Lateef Attar (1):
  SctPkg: Fix X64 build errors for GCC toolchain

 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIFontEx/BlackBoxTest/HIIFontExBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIImage/BlackBoxTest/HIIImageBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIImageEx/BlackBoxTest/HIIImageExBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIString/BlackBoxTest/HIIStringBBTestMain.h
|  3 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/LoadedImage/BlackBoxTest/LoadedImageBBTest.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PartitionInfo/BlackBoxTest/PartitionInfoBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ResetNotification/BlackBoxTest/ResetNotificationBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemBBTest.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextIn/BlackBoxTest/SimpleTextInBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_efi.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_uefi.h
   |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UFSDeviceConfig/BlackBoxTest/UFSDeviceConfigBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemBBTest.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextIn/BlackBoxTest/SimpleTextInBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_uefi.h
   |  1 +
 uefi-sct/SctPkg/SCRT/SCRTDriver/ia32/Debug.c   
|  9 --
 uefi-sct/SctPkg/SCRT/SCRTDriver/x64/Debug.c
|  9 --
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/AddressResolutionProtocol/Arp/ArpENTSTest.c
 |  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/AddressResolutionProtocol/ArpServiceBinding/ArpServiceBindingENTSTest.c
 |  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp4/Dhcp4/Dhcp4ENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp4/Dhcp4SB/Dhcp4SBENTSTest.c 
|  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp6/Dhcp6/Dhcp6ENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp6/Dhcp6SB/Dhcp6SBENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Http/Http/HttpENTSTest.c
|  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/Http/HttpServiceBinding/HttpServiceBindingENTSTest.c
|  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4/Ip4ENTSTest.c 
|  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4Config/Ip4ConfigENTSTest.c
 |  3 ++
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4Config2/Ip4Config2ENTSTest.c
   |  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4ServiceBinding/Ip4ServiceBindingENTSTest.c
 |  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol6/Ip6/Ip6ENTSTest.c

[edk2-devel] [[edk2-test] PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-10-07 Thread Abdul Lateef Attar via groups.io

From: Abdul Lateef Attar 

From: Your Name 

Signed-off-by: Abdul Lateef Attar 
---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIFontEx/BlackBoxTest/HIIFontExBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIImage/BlackBoxTest/HIIImageBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIImageEx/BlackBoxTest/HIIImageExBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIString/BlackBoxTest/HIIStringBBTestMain.h
|  3 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/LoadedImage/BlackBoxTest/LoadedImageBBTest.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PartitionInfo/BlackBoxTest/PartitionInfoBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ResetNotification/BlackBoxTest/ResetNotificationBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemBBTest.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextIn/BlackBoxTest/SimpleTextInBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_efi.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_uefi.h
   |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UFSDeviceConfig/BlackBoxTest/UFSDeviceConfigBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemBBTest.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextIn/BlackBoxTest/SimpleTextInBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_uefi.h
   |  1 +
 uefi-sct/SctPkg/SCRT/SCRTDriver/ia32/Debug.c   
|  9 --
 uefi-sct/SctPkg/SCRT/SCRTDriver/x64/Debug.c
|  9 --
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/AddressResolutionProtocol/Arp/ArpENTSTest.c
 |  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/AddressResolutionProtocol/ArpServiceBinding/ArpServiceBindingENTSTest.c
 |  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp4/Dhcp4/Dhcp4ENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp4/Dhcp4SB/Dhcp4SBENTSTest.c 
|  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp6/Dhcp6/Dhcp6ENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp6/Dhcp6SB/Dhcp6SBENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Http/Http/HttpENTSTest.c
|  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/Http/HttpServiceBinding/HttpServiceBindingENTSTest.c
|  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4/Ip4ENTSTest.c 
|  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4Config/Ip4ConfigENTSTest.c
 |  3 ++
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4Config2/Ip4Config2ENTSTest.c
   |  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4ServiceBinding/Ip4ServiceBindingENTSTest.c
 |  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol6/Ip6/Ip6ENTSTest.c 
|  3 ++
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol6/Ip6Config/Ip6ConfigENTSTest.c
 |  3 ++
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol6/Ip6ServiceBinding/Ip6ServiceBindingENTSTest.c
 |  1 +

[edk2-devel] [edk2-test] [PATCH v1 0/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-10-07 Thread Abdul Lateef Attar via groups.io

Removes duplicate function definations.
Adds EFIAPI to function definations/declerations.

Abdul Lateef Attar (1):
  SctPkg: Fix X64 build errors for GCC toolchain

 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIFontEx/BlackBoxTest/HIIFontExBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIImage/BlackBoxTest/HIIImageBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIImageEx/BlackBoxTest/HIIImageExBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIString/BlackBoxTest/HIIStringBBTestMain.h
|  3 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/LoadedImage/BlackBoxTest/LoadedImageBBTest.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PartitionInfo/BlackBoxTest/PartitionInfoBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ResetNotification/BlackBoxTest/ResetNotificationBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemBBTest.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextIn/BlackBoxTest/SimpleTextInBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_efi.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_uefi.h
   |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UFSDeviceConfig/BlackBoxTest/UFSDeviceConfigBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemBBTest.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextIn/BlackBoxTest/SimpleTextInBBTestMain.h
  |  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestMain.h
|  1 +
 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestMain_uefi.h
   |  1 +
 uefi-sct/SctPkg/SCRT/SCRTDriver/ia32/Debug.c   
|  9 --
 uefi-sct/SctPkg/SCRT/SCRTDriver/x64/Debug.c
|  9 --
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/AddressResolutionProtocol/Arp/ArpENTSTest.c
 |  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/AddressResolutionProtocol/ArpServiceBinding/ArpServiceBindingENTSTest.c
 |  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp4/Dhcp4/Dhcp4ENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp4/Dhcp4SB/Dhcp4SBENTSTest.c 
|  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp6/Dhcp6/Dhcp6ENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Dhcp6/Dhcp6SB/Dhcp6SBENTSTest.c 
|  1 +
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/Http/Http/HttpENTSTest.c
|  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/Http/HttpServiceBinding/HttpServiceBindingENTSTest.c
|  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4/Ip4ENTSTest.c 
|  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4Config/Ip4ConfigENTSTest.c
 |  3 ++
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4Config2/Ip4Config2ENTSTest.c
   |  1 +
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol4/Ip4ServiceBinding/Ip4ServiceBindingENTSTest.c
 |  3 ++
 uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol6/Ip6/Ip6ENTSTest.c 
|  3 ++
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol6/Ip6Config/Ip6ConfigENTSTest.c
 |  3 ++
 
uefi-sct/SctPkg/TestCase/RIVL/Protocol/InternetProtocol6/Ip6ServiceBinding/Ip6ServiceBindingENTSTest.c

[edk2-devel] edk2-test-stable202108 is Released

2021-08-25 Thread G Edhaya Chandran

Hello All,

edk2-test-stable202108 is now released.
Please refer to the link for more details : 
https://github.com/tianocore/edk2-test/releases/tag/edk2-test-stable202108

Thanking you all for your contributions.
Please feel free to contact me or Barton for any clarifications.

With Warm Regards,
Edhay



From: G Edhaya Chandran
Sent: 11 August 2021 01:02
To: devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud ; Barton Gao 

Subject: edk2-test Release Notice

Hello All,

 This mail is to notify that the edk2-test repository shall be released by 
end of August 2021
with the tag edk2-test-stable202108.

The base-line commit shall be: 814b2af535d977b3967d65de77e42ab18a4f4db4

Please feel free to contact me or Barton for any clarifications.

With Warm Regards,
Edhay

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79796): https://edk2.groups.io/g/devel/message/79796
Mute This Topic: https://groups.io/mt/85133980/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

2021-08-23 Thread G Edhaya Chandran

This patch is upstreamed through the commit-id: 
https://github.com/tianocore/edk2-test/commit/f3b3456152dacf26ec0abaa0c21a9432cc176630


> -Original Message-
> From: G Edhaya Chandran
> Sent: 20 August 2021 12:48
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: gao...@byosoft.com.cn; Samer El-Haj-Mahmoud  mahm...@arm.com>; eric@intel.com; arvinx.c...@intel.com; Jeff Brasen
> (jbra...@nvidia.com) 
> Subject: RE: [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot 
> services
> functions
>
> Reviewed-by: G Edhaya Chandran
>
> > -Original Message-
> > From: Jeff Brasen 
> > Sent: 12 August 2021 21:43
> > To: devel@edk2.groups.io
> > Cc: G Edhaya Chandran ;
> > gao...@byosoft.com.cn; Samer El-Haj-Mahmoud
> > ; eric@intel.com;
> > arvinx.c...@intel.com; Jeff Brasen (jbra...@nvidia.com)
> > 
> > Subject: [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot
> > services functions
> >
> > SctAPrint uses boot services functions but is called after ExitBootServices.
> > Replace with call to Printf which is safe for use in runtime.
> >
> > Signed-off-by: Jeff Brasen 
> > ---
> >  .../SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c | 52 +--
> >  uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c| 52 +--
> >  .../SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c | 52 +--
> >  3 files changed, 78 insertions(+), 78 deletions(-)
> >
> > diff --git a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c b/uefi-
> > sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> > index cc8d9869..5688849c 100644
> > --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> > +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> > @@ -26,43 +26,43 @@ Module Name:
> >  VOID
> >  DumpRuntimeTable()
> >  {
> > -  SctAPrint ("\nDump Runtime
> > Table===\n");
> > -  SctAPrint ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
> > +  Printf ("\nDump Runtime Table===\n");
> > + Printf ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
> >
> > -  SctAPrint ("\nGetTime Service==\n");
> > -  SctAPrint ("GetTime @ 0x%x\n", VRT->GetTime);
> > +  Printf ("\nGetTime Service==\n");
> > + Printf ("GetTime @ 0x%x\n", VRT->GetTime);
> >
> > -  SctAPrint ("\nSetTime Service==\n");
> > -  SctAPrint ("SetTime @ 0x%x\n", VRT->SetTime);
> > +  Printf ("\nSetTime Service==\n");
> > + Printf ("SetTime @ 0x%x\n", VRT->SetTime);
> >
> > -  SctAPrint ("\nGetWakeupTime
> > Service==\n");
> > -  SctAPrint ("GetWakeupTime @ 0x%x\n", VRT->GetWakeupTime);
> > +  Printf ("\nGetWakeupTime Service==\n");
> > + Printf ("GetWakeupTime @ 0x%x\n", VRT->GetWakeupTime);
> >
> > -  SctAPrint ("\nSetWakeupTime
> > Service==\n");
> > -  SctAPrint ("SetWakeupTime @ 0x%x\n", VRT->SetWakeupTime);
> > +  Printf ("\nSetWakeupTime Service==\n");
> > + Printf ("SetWakeupTime @ 0x%x\n", VRT->SetWakeupTime);
> >
> > -  SctAPrint ("\nGetVariable
> > Service==\n");
> > -  SctAPrint ("GetVariable @ 0x%x\n", VRT->GetVariable);
> > +  Printf ("\nGetVariable Service==\n");
> > + Printf ("GetVariable @ 0x%x\n", VRT->GetVariable);
> >
> > -  SctAPrint ("\nGetNextVariableName
> > Service==\n");
> > -  SctAPrint ("GetNextVariableName @ 0x%x\n",
> > VRT->GetNextVariableName);
> > +  Printf ("\nGetNextVariableName
> > + Service==\n");  Printf ("GetNextVariableName @ 0x%x\n",
> > + VRT->GetNextVariableName);
> >
> > -  SctAPrint ("\nSetVariable
> > Service==\n");
> > -  SctAPrint ("SetVariable @ 0x%x\n", VRT->SetVariable);
> > +  Printf ("\nSetVariable Service==\n");
> > + Printf ("SetVariable @ 0x%x\n", VRT->SetVariable);
> >
> > -  SctAPrint ("\nGetNextHighMonotonicCount
> > Service==\n");
> > -  SctAPrint ("GetNextHighMonotonicCount @ 0x%x\n", VRT-
> > >GetNextHighMonotonicCount);
> > +  Printf ("\nGetNextHighMonotonicCount
> > + Service==\n");  Printf ("GetNextHighMonotonicCount @
> > + 0x%x\n", VRT->GetNextHighMonotonicCount);
> >
> > -  SctAPrint ("\nResetSystem
> > Service==\n");
> > -  SctAPrint ("ResetSystem @ 0x%x\n", VRT->ResetSystem);
> > +  Printf ("\nResetSystem Service==\n");
> > + Printf ("ResetSystem @ 0x%x\n", VRT->ResetSystem);
> >  #if 0
> > -  SctAPrint ("\nUpdateCapsule
> > Service==\n");
> > -  SctAPrint ("UpdateCapsule @ 0x%x\n", VRT->UpdateCapsule);
> > +  Printf ("\nUpdateCapsule Service==\n");
> > + Printf ("UpdateCapsule @ 0x%x\n", VRT->UpdateCapsule);
> >
> > -  SctAPrint ("\nQueryCapsuleCapabilities
> >

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] uefi-sct: Propose maintainers from AMD

2021-08-20 Thread Samer El-Haj-Mahmoud

Thanks Supreeth and Carolyn. It is nice to see AMD step up to help with SCT !

Reviewed-By: Samer El-Haj-Mahmoud 
samer.el-haj-mahm...@arm.com<mailto:samer.el-haj-mahm...@arm.com>





From: devel@edk2.groups.io  on behalf of Supreeth 
Venkatesh via groups.io 
Sent: Thursday, August 19, 2021 2:50:42 PM
To: devel@edk2.groups.io 
Cc: carolyn.gjert...@amd.com ; Supreeth Venkatesh 

Subject: [edk2-devel] [edk2-test] [PATCH v1 1/1] uefi-sct: Propose maintainers 
from AMD

This patch proposes Carolyn Gjertsen as maintainer of edk2-test
repository and Supreeth Venkatesh as reviewer from AMD.

Signed-off-by: Supreeth Venkatesh 
---
 uefi-sct/Maintainers.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/uefi-sct/Maintainers.txt b/uefi-sct/Maintainers.txt
index c93b83ec..a94255f0 100644
--- a/uefi-sct/Maintainers.txt
+++ b/uefi-sct/Maintainers.txt
@@ -41,10 +41,12 @@ UEFI-SCT:

 M: G Edhaya Chandran 
 M: Barton Gao 
+M: Carolyn Gjertsen 

 R: Samer El-Haj-Mahmoud 
 R: Eric Jin 
 R: Arvin Chen 
+R: Supreeth Venkatesh 

 General questions on UEFI-SCT with the subject [edk2-test] can be sent to
 L: edk2-devel 
--
2.25.1





IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79644): https://edk2.groups.io/g/devel/message/79644
Mute This Topic: https://groups.io/mt/85009511/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

2021-08-20 Thread G Edhaya Chandran

Reviewed-by: G Edhaya Chandran

> -Original Message-
> From: Jeff Brasen 
> Sent: 12 August 2021 21:43
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; gao...@byosoft.com.cn;
> Samer El-Haj-Mahmoud ;
> eric@intel.com; arvinx.c...@intel.com; Jeff Brasen (jbra...@nvidia.com)
> 
> Subject: [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services
> functions
>
> SctAPrint uses boot services functions but is called after ExitBootServices.
> Replace with call to Printf which is safe for use in runtime.
>
> Signed-off-by: Jeff Brasen 
> ---
>  .../SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c | 52 +--
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c| 52 +--
>  .../SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c | 52 +--
>  3 files changed, 78 insertions(+), 78 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> index cc8d9869..5688849c 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> @@ -26,43 +26,43 @@ Module Name:
>  VOID
>  DumpRuntimeTable()
>  {
> -  SctAPrint ("\nDump Runtime Table===\n");
> -  SctAPrint ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
> +  Printf ("\nDump Runtime Table===\n");
> + Printf ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
>
> -  SctAPrint ("\nGetTime Service==\n");
> -  SctAPrint ("GetTime @ 0x%x\n", VRT->GetTime);
> +  Printf ("\nGetTime Service==\n");  Printf
> + ("GetTime @ 0x%x\n", VRT->GetTime);
>
> -  SctAPrint ("\nSetTime Service==\n");
> -  SctAPrint ("SetTime @ 0x%x\n", VRT->SetTime);
> +  Printf ("\nSetTime Service==\n");  Printf
> + ("SetTime @ 0x%x\n", VRT->SetTime);
>
> -  SctAPrint ("\nGetWakeupTime
> Service==\n");
> -  SctAPrint ("GetWakeupTime @ 0x%x\n", VRT->GetWakeupTime);
> +  Printf ("\nGetWakeupTime Service==\n");
> + Printf ("GetWakeupTime @ 0x%x\n", VRT->GetWakeupTime);
>
> -  SctAPrint ("\nSetWakeupTime
> Service==\n");
> -  SctAPrint ("SetWakeupTime @ 0x%x\n", VRT->SetWakeupTime);
> +  Printf ("\nSetWakeupTime Service==\n");
> + Printf ("SetWakeupTime @ 0x%x\n", VRT->SetWakeupTime);
>
> -  SctAPrint ("\nGetVariable Service==\n");
> -  SctAPrint ("GetVariable @ 0x%x\n", VRT->GetVariable);
> +  Printf ("\nGetVariable Service==\n");
> + Printf ("GetVariable @ 0x%x\n", VRT->GetVariable);
>
> -  SctAPrint ("\nGetNextVariableName
> Service==\n");
> -  SctAPrint ("GetNextVariableName @ 0x%x\n", VRT->GetNextVariableName);
> +  Printf ("\nGetNextVariableName
> + Service==\n");  Printf ("GetNextVariableName @ 0x%x\n",
> + VRT->GetNextVariableName);
>
> -  SctAPrint ("\nSetVariable Service==\n");
> -  SctAPrint ("SetVariable @ 0x%x\n", VRT->SetVariable);
> +  Printf ("\nSetVariable Service==\n");
> + Printf ("SetVariable @ 0x%x\n", VRT->SetVariable);
>
> -  SctAPrint ("\nGetNextHighMonotonicCount
> Service==\n");
> -  SctAPrint ("GetNextHighMonotonicCount @ 0x%x\n", VRT-
> >GetNextHighMonotonicCount);
> +  Printf ("\nGetNextHighMonotonicCount
> + Service==\n");  Printf ("GetNextHighMonotonicCount @
> + 0x%x\n", VRT->GetNextHighMonotonicCount);
>
> -  SctAPrint ("\nResetSystem Service==\n");
> -  SctAPrint ("ResetSystem @ 0x%x\n", VRT->ResetSystem);
> +  Printf ("\nResetSystem Service==\n");
> + Printf ("ResetSystem @ 0x%x\n", VRT->ResetSystem);
>  #if 0
> -  SctAPrint ("\nUpdateCapsule Service==\n");
> -  SctAPrint ("UpdateCapsule @ 0x%x\n", VRT->UpdateCapsule);
> +  Printf ("\nUpdateCapsule Service==\n");
> + Printf ("UpdateCapsule @ 0x%x\n", VRT->UpdateCapsule);
>
> -  SctAPrint ("\nQueryCapsuleCapabilities
> Service==\n");
> -  SctAPrint ("QueryCapsuleCapabilities @ 0x%x\n", VRT-
> >QueryCapsuleCapabilities);
> +  Printf ("\nQueryCapsuleCapabilities
> + Service==\n");  Printf ("QueryCapsuleCapabilities @
> + 0x%x\n", VRT->QueryCapsuleCapabilities);
>
> -  SctAPrint ("\nQueryVariableInfo
> Service==\n");
> -  SctAPrint ("QueryVariableInfo @ 0x%x\n", VRT->QueryVariableInfo);
> +  Printf ("\nQueryVariableInfo
> + Service==\n");  Printf ("QueryVariableInfo @ 0x%x\n",
> + VRT->QueryVariableInfo);
>  #endif
>  }
> diff --git a/uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c
> index

[edk2-devel] [edk2-test] [PATCH v1 1/1] uefi-sct: Propose maintainers from AMD

2021-08-19 Thread Supreeth Venkatesh via groups.io

This patch proposes Carolyn Gjertsen as maintainer of edk2-test
repository and Supreeth Venkatesh as reviewer from AMD.

Signed-off-by: Supreeth Venkatesh 
---
 uefi-sct/Maintainers.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/uefi-sct/Maintainers.txt b/uefi-sct/Maintainers.txt
index c93b83ec..a94255f0 100644
--- a/uefi-sct/Maintainers.txt
+++ b/uefi-sct/Maintainers.txt
@@ -41,10 +41,12 @@ UEFI-SCT:
 
 M: G Edhaya Chandran 
 M: Barton Gao 
+M: Carolyn Gjertsen 
 
 R: Samer El-Haj-Mahmoud 
 R: Eric Jin 
 R: Arvin Chen 
+R: Supreeth Venkatesh 
 
 General questions on UEFI-SCT with the subject [edk2-test] can be sent to
 L: edk2-devel 
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79596): https://edk2.groups.io/g/devel/message/79596
Mute This Topic: https://groups.io/mt/85009511/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

2021-08-12 Thread Samer El-Haj-Mahmoud

Thanks for the catch Jeff!!

Reviewed-by: Samer El-Haj-Mahmoud 



> -Original Message-
> From: Jeff Brasen 
> Sent: Thursday, August 12, 2021 12:13 PM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ;
> gao...@byosoft.com.cn; Samer El-Haj-Mahmoud  mahm...@arm.com>; eric@intel.com; arvinx.c...@intel.com; Jeff
> Brasen (jbra...@nvidia.com) 
> Subject: [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services
> functions
>
> SctAPrint uses boot services functions but is called after
> ExitBootServices. Replace with call to Printf which is safe for use in
> runtime.
>
> Signed-off-by: Jeff Brasen 
> ---
>  .../SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c | 52 +--
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c| 52 +--
>  .../SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c | 52 +--
>  3 files changed, 78 insertions(+), 78 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> index cc8d9869..5688849c 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> @@ -26,43 +26,43 @@ Module Name:
>  VOID
>  DumpRuntimeTable()
>  {
> -  SctAPrint ("\nDump Runtime
> Table===\n");
> -  SctAPrint ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
> +  Printf ("\nDump Runtime
> Table===\n");
> +  Printf ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
>
> -  SctAPrint ("\nGetTime Service==\n");
> -  SctAPrint ("GetTime @ 0x%x\n", VRT->GetTime);
> +  Printf ("\nGetTime Service==\n");
> +  Printf ("GetTime @ 0x%x\n", VRT->GetTime);
>
> -  SctAPrint ("\nSetTime Service==\n");
> -  SctAPrint ("SetTime @ 0x%x\n", VRT->SetTime);
> +  Printf ("\nSetTime Service==\n");
> +  Printf ("SetTime @ 0x%x\n", VRT->SetTime);
>
> -  SctAPrint ("\nGetWakeupTime
> Service==\n");
> -  SctAPrint ("GetWakeupTime @ 0x%x\n", VRT->GetWakeupTime);
> +  Printf ("\nGetWakeupTime
> Service==\n");
> +  Printf ("GetWakeupTime @ 0x%x\n", VRT->GetWakeupTime);
>
> -  SctAPrint ("\nSetWakeupTime
> Service==\n");
> -  SctAPrint ("SetWakeupTime @ 0x%x\n", VRT->SetWakeupTime);
> +  Printf ("\nSetWakeupTime
> Service==\n");
> +  Printf ("SetWakeupTime @ 0x%x\n", VRT->SetWakeupTime);
>
> -  SctAPrint ("\nGetVariable
> Service==\n");
> -  SctAPrint ("GetVariable @ 0x%x\n", VRT->GetVariable);
> +  Printf ("\nGetVariable Service==\n");
> +  Printf ("GetVariable @ 0x%x\n", VRT->GetVariable);
>
> -  SctAPrint ("\nGetNextVariableName
> Service==\n");
> -  SctAPrint ("GetNextVariableName @ 0x%x\n", VRT-
> >GetNextVariableName);
> +  Printf ("\nGetNextVariableName
> Service==\n");
> +  Printf ("GetNextVariableName @ 0x%x\n", VRT->GetNextVariableName);
>
> -  SctAPrint ("\nSetVariable
> Service==\n");
> -  SctAPrint ("SetVariable @ 0x%x\n", VRT->SetVariable);
> +  Printf ("\nSetVariable Service==\n");
> +  Printf ("SetVariable @ 0x%x\n", VRT->SetVariable);
>
> -  SctAPrint ("\nGetNextHighMonotonicCount
> Service==\n");
> -  SctAPrint ("GetNextHighMonotonicCount @ 0x%x\n", VRT-
> >GetNextHighMonotonicCount);
> +  Printf ("\nGetNextHighMonotonicCount
> Service==\n");
> +  Printf ("GetNextHighMonotonicCount @ 0x%x\n", VRT-
> >GetNextHighMonotonicCount);
>
> -  SctAPrint ("\nResetSystem
> Service==\n");
> -  SctAPrint ("ResetSystem @ 0x%x\n", VRT->ResetSystem);
> +  Printf ("\nResetSystem
> Service==\n");
> +  Printf ("ResetSystem @ 0x%x\n", VRT->ResetSystem);
>  #if 0
> -  SctAPrint ("\nUpdateCapsule
> Service==\n");
> -  SctAPrint ("UpdateCapsule @ 0x%x\n", VRT->UpdateCapsule);
> +  Printf ("\nUpdateCapsule
> Service==\n");
> +  Printf ("UpdateCapsule @ 0x%x\n", VRT->UpdateCapsule);
>
> -  SctAPrint ("\nQueryCapsuleCapabilities
> Service==\n");
> -  SctAPrint ("QueryCapsuleCapabilities @ 0x%x\n", VRT-
> >QueryCapsuleCapabilities);
> +  Printf ("\nQueryCapsuleCapabilities
> Service==\n");
> +  Printf ("QueryCapsuleCapabilities @ 0x%x\n", VRT-
> >QueryCapsuleCapabilities);
>
> -  SctAPrint ("\nQueryVariableInfo
> Service==\n");
> -  SctAPrint ("QueryVariableInfo @ 0x%x\n", VRT->QueryVariableInfo);
> +  Printf ("\nQueryVariableInfo
> Service==\n");
> +  Printf ("QueryVariableInfo @ 0x%x\n", VRT->QueryVariableInfo);
>  #endif
>  }
> diff --git

[edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

2021-08-12 Thread Jeff Brasen via groups.io

SctAPrint uses boot services functions but is called after
ExitBootServices. Replace with call to Printf which is safe for use in
runtime.

Signed-off-by: Jeff Brasen 
---
 .../SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c | 52 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c| 52 +--
 .../SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c | 52 +--
 3 files changed, 78 insertions(+), 78 deletions(-)

diff --git a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c 
b/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
index cc8d9869..5688849c 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
+++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
@@ -26,43 +26,43 @@ Module Name:
 VOID
 DumpRuntimeTable()
 {
-  SctAPrint ("\nDump Runtime Table===\n");
-  SctAPrint ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
+  Printf ("\nDump Runtime Table===\n");
+  Printf ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
 
-  SctAPrint ("\nGetTime Service==\n");
-  SctAPrint ("GetTime @ 0x%x\n", VRT->GetTime);
+  Printf ("\nGetTime Service==\n");
+  Printf ("GetTime @ 0x%x\n", VRT->GetTime);
 
-  SctAPrint ("\nSetTime Service==\n");
-  SctAPrint ("SetTime @ 0x%x\n", VRT->SetTime);
+  Printf ("\nSetTime Service==\n");
+  Printf ("SetTime @ 0x%x\n", VRT->SetTime);
 
-  SctAPrint ("\nGetWakeupTime Service==\n");
-  SctAPrint ("GetWakeupTime @ 0x%x\n", VRT->GetWakeupTime);
+  Printf ("\nGetWakeupTime Service==\n");
+  Printf ("GetWakeupTime @ 0x%x\n", VRT->GetWakeupTime);
 
-  SctAPrint ("\nSetWakeupTime Service==\n");
-  SctAPrint ("SetWakeupTime @ 0x%x\n", VRT->SetWakeupTime);
+  Printf ("\nSetWakeupTime Service==\n");
+  Printf ("SetWakeupTime @ 0x%x\n", VRT->SetWakeupTime);
 
-  SctAPrint ("\nGetVariable Service==\n");
-  SctAPrint ("GetVariable @ 0x%x\n", VRT->GetVariable);
+  Printf ("\nGetVariable Service==\n");
+  Printf ("GetVariable @ 0x%x\n", VRT->GetVariable);
 
-  SctAPrint ("\nGetNextVariableName Service==\n");
-  SctAPrint ("GetNextVariableName @ 0x%x\n", VRT->GetNextVariableName);
+  Printf ("\nGetNextVariableName Service==\n");
+  Printf ("GetNextVariableName @ 0x%x\n", VRT->GetNextVariableName);
 
-  SctAPrint ("\nSetVariable Service==\n");
-  SctAPrint ("SetVariable @ 0x%x\n", VRT->SetVariable);
+  Printf ("\nSetVariable Service==\n");
+  Printf ("SetVariable @ 0x%x\n", VRT->SetVariable);
 
-  SctAPrint ("\nGetNextHighMonotonicCount 
Service==\n");
-  SctAPrint ("GetNextHighMonotonicCount @ 0x%x\n", 
VRT->GetNextHighMonotonicCount);
+  Printf ("\nGetNextHighMonotonicCount 
Service==\n");
+  Printf ("GetNextHighMonotonicCount @ 0x%x\n", 
VRT->GetNextHighMonotonicCount);
 
-  SctAPrint ("\nResetSystem Service==\n");
-  SctAPrint ("ResetSystem @ 0x%x\n", VRT->ResetSystem);
+  Printf ("\nResetSystem Service==\n");
+  Printf ("ResetSystem @ 0x%x\n", VRT->ResetSystem);
 #if 0
-  SctAPrint ("\nUpdateCapsule Service==\n");
-  SctAPrint ("UpdateCapsule @ 0x%x\n", VRT->UpdateCapsule);
+  Printf ("\nUpdateCapsule Service==\n");
+  Printf ("UpdateCapsule @ 0x%x\n", VRT->UpdateCapsule);
 
-  SctAPrint ("\nQueryCapsuleCapabilities 
Service==\n");
-  SctAPrint ("QueryCapsuleCapabilities @ 0x%x\n", 
VRT->QueryCapsuleCapabilities);
+  Printf ("\nQueryCapsuleCapabilities 
Service==\n");
+  Printf ("QueryCapsuleCapabilities @ 0x%x\n", VRT->QueryCapsuleCapabilities);
 
-  SctAPrint ("\nQueryVariableInfo Service==\n");
-  SctAPrint ("QueryVariableInfo @ 0x%x\n", VRT->QueryVariableInfo);
+  Printf ("\nQueryVariableInfo Service==\n");
+  Printf ("QueryVariableInfo @ 0x%x\n", VRT->QueryVariableInfo);
 #endif
 }
diff --git a/uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c 
b/uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c
index 89e03019..47173d45 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c
+++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c
@@ -27,43 +27,43 @@ Module Name:
 VOID
 DumpRuntimeTable()
 {
-  SctAPrint ("\nDump Runtime Table===\n");
-  SctAPrint ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
+  Printf ("\nDump Runtime Table===\n");
+  Printf ("Header Signature = 0x%x\n", VRT->Hdr.Signature);
 
-  SctAPrint ("\nGetTime Service==\n");
-  SctAPrint ("GetTime @ 0x%x\n",

[edk2-devel] edk2-test Release Notice

2021-08-10 Thread G Edhaya Chandran

Hello All,

 This mail is to notify that the edk2-test repository shall be released by 
end of August 2021
with the tag edk2-test-stable202108.

The base-line commit shall be: 814b2af535d977b3967d65de77e42ab18a4f4db4

Please feel free to contact me or Barton for any clarifications.

With Warm Regards,
Edhay

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79055): https://edk2.groups.io/g/devel/message/79055
Mute This Topic: https://groups.io/mt/84801150/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-08-09 Thread G Edhaya Chandran

Thank you all.

The solution is upstream by the commit : 
https://github.com/tianocore/edk2-test/commit/e4be30440f081454d5d6f047510f484ee5bb8a88


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78950): https://edk2.groups.io/g/devel/message/78950
Mute This Topic: https://groups.io/mt/84303611/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-08-04 Thread Paul Yang



I tested this patch on Ampere Altra system.
Tested-by: Paul Yang 

-Original Message-
From: Sunny Wang 
Sent: Monday, July 19, 2021 4:08 PM
To: devel@edk2.groups.io
Cc: Sunny Wang ; Samer El-Haj-Mahmoud 
; G Edhaya Chandran ; 
Barton Gao ; Sunny Wang 
Subject: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment 
calculations

This is to fix the SCT BS.AllocatePages failures (not found) with the case that 
the Start address is not aligned to 64k.
For example,
  The following is available memory region for testing:
82012000-EB6D9FFF 000696C8
  With the current page alignment calculation, we will get:
Start address is 0x8202
PageNum is 0x696B8
  In BS.AllocatePages, it will make the end address align with 64k,
  so PageNum will be changed from 0x696B8 to 0x696C0. Therefore, the
  end address will become 0xEB6E which is larger than 0xEB6D9FFF,
  so we get not found error in the end.

Therefore, the calculation for getting the PageNum should be updated to PageNum 
- (2 * EFI_SIZE_TO_PAGES(0x1)) so that we won't get a wrong PageNum to 
allocate a memory with a size larger than available space's size.

With this solution, the example above will get 0x696A8 as calculated PageNum. 
Then, in BS.AllocatePages, the PageNum will be changed from
0x696A8 to 0x696B0. Therefore, the end address will become 0xEB6D that is 
smaller than 0xEB6D9FFF, so we get not found error in the end.

I also tested this solution on two ARM platforms (NXP1046A and RPi4).

Cc: Samer El-Haj-Mahmoud 
Cc: G Edhaya Chandran 
Cc: Barton Gao 
Signed-off-by: Sunny Wang 
---
 .../MemoryAllocationServicesBBTestFunction.c  | 110 +++---
 1 file changed, 66 insertions(+), 44 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
index bf8cd3b3..cdfac992 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationSer
+++ vices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
@@ -2,6 +2,7 @@

   Copyright 2006 - 2013 Unified EFI, Inc.
   Copyright (c) 2010 - 2013, Intel Corporation. All rights reserved.
+  Copyright (c) 2021, ARM Limited. All rights reserved.

   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License @@ -24,7 +25,7 @@ Abstract:

 --*/

-#include "SctLib.h"
+#include "SctLib.h"
 #include "MemoryAllocationServicesBBTestMain.h"

 #define ALLOCATEPAGES_MEMORYTYPE_NUM 16 @@ -700,14 +701,17 @@ 
BBTestAllocatePagesInterfaceTest (
 PageNum = (UINTN)Descriptor.NumberOfPages;
 Start   = Descriptor.PhysicalStart;

-//
-// Some memory types need more alignment than 4K, so
-//
-if (PageNum <= 0x10) {
+//
+// Calculate New Start address and PageNum with 64k alignment to
+// cover the case that some memory types' alignment is more than
+// 4k. If the available memory is less than 192k, the memory
+// allocation call will be skipped.
+//
+if (PageNum < (3 * EFI_SIZE_TO_PAGES(0x1))) {
   break;
 }
-Start   = (Start + 0x) & 0x;
-PageNum = PageNum - EFI_SIZE_TO_PAGES(0x1);
+Start   = (Start + 0x) & 0x;
+PageNum = PageNum - (2 * EFI_SIZE_TO_PAGES(0x1));

 Memory  = Start;

@@ -830,14 +834,17 @@ BBTestAllocatePagesInterfaceTest (
 PageNum = (UINTN)Descriptor.NumberOfPages;
 Start   = Descriptor.PhysicalStart;

-//
-// Some memory types need more alignment than 4K, so
-//
-if (PageNum <= 0x10) {
+//
+// Calculate New Start address and PageNum with 64k alignment to
+// cover the case that some memory types' alignment is more than
+// 4k. If the available memory is less than 192k, the memory
+// allocation call will be skipped.
+//
+if (PageNum < (3 * EFI_SIZE_TO_PAGES(0x1))) {
   break;
 }
-Start   = (Start + 0x) & 0x;
-PageNum = PageNum - EFI_SIZE_TO_PAGES(0x1);
+Start   = (Start + 0x) & 0x;
+PageNum = PageNum - (2 * EFI_SIZE_TO_PAGES(0x1));

 Memory  = Start;

@@ -953,14 +960,17 @@ BBTestAllocatePagesInterfaceTest (
 PageNum = (UINTN)Descriptor.NumberOfPages;
 Start   = Descriptor.PhysicalStart;

-//
-// Some memory types need more alignment than 4K, so
-//
-if (PageNum <= 0x10) {
+//
+// Calculate New Start address and PageNum with 64k

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-08-03 Thread Tuan Phan via groups.io

Reviewed-By: Tuan Phan 

> On Jul 19, 2021, at 1:07 AM, Sunny Wang via groups.io 
>  wrote:
> 
> This is to fix the SCT BS.AllocatePages failures (not found) with the
> case that the Start address is not aligned to 64k.
> For example,
>  The following is available memory region for testing:
>82012000-EB6D9FFF 000696C8
>  With the current page alignment calculation, we will get:
>Start address is 0x8202
>PageNum is 0x696B8
>  In BS.AllocatePages, it will make the end address align with 64k,
>  so PageNum will be changed from 0x696B8 to 0x696C0. Therefore, the
>  end address will become 0xEB6E which is larger than 0xEB6D9FFF,
>  so we get not found error in the end.
> 
> Therefore, the calculation for getting the PageNum should be updated
> to PageNum - (2 * EFI_SIZE_TO_PAGES(0x1)) so that we won't get a
> wrong PageNum to allocate a memory with a size larger than available
> space's size.
> 
> With this solution, the example above will get 0x696A8 as calculated
> PageNum. Then, in BS.AllocatePages, the PageNum will be changed from
> 0x696A8 to 0x696B0. Therefore, the end address will become 0xEB6D
> that is smaller than 0xEB6D9FFF, so we get not found error in the end.
> 
> I also tested this solution on two ARM platforms (NXP1046A and RPi4).
> 
> Cc: Samer El-Haj-Mahmoud 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Signed-off-by: Sunny Wang 
> ---
> .../MemoryAllocationServicesBBTestFunction.c  | 110 +++---
> 1 file changed, 66 insertions(+), 44 deletions(-)
> 
> diff --git 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
>  
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
> index bf8cd3b3..cdfac992 100644
> --- 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
> +++ 
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
> @@ -2,6 +2,7 @@
> 
>   Copyright 2006 - 2013 Unified EFI, Inc.
>   Copyright (c) 2010 - 2013, Intel Corporation. All rights reserved.
> +  Copyright (c) 2021, ARM Limited. All rights reserved.
> 
>   This program and the accompanying materials
>   are licensed and made available under the terms and conditions of the BSD 
> License
> @@ -24,7 +25,7 @@ Abstract:
> 
> --*/
> 
> -#include "SctLib.h"
> +#include "SctLib.h"
> #include "MemoryAllocationServicesBBTestMain.h"
> 
> #define ALLOCATEPAGES_MEMORYTYPE_NUM 16
> @@ -700,14 +701,17 @@ BBTestAllocatePagesInterfaceTest (
> PageNum = (UINTN)Descriptor.NumberOfPages;
> Start   = Descriptor.PhysicalStart;
> 
> -//
> -// Some memory types need more alignment than 4K, so
> -//
> -if (PageNum <= 0x10) {
> +//
> +// Calculate New Start address and PageNum with 64k alignment to
> +// cover the case that some memory types' alignment is more than
> +// 4k. If the available memory is less than 192k, the memory
> +// allocation call will be skipped.
> +//
> +if (PageNum < (3 * EFI_SIZE_TO_PAGES(0x1))) {
>   break;
> }
> -Start   = (Start + 0x) & 0x;
> -PageNum = PageNum - EFI_SIZE_TO_PAGES(0x1);
> +Start   = (Start + 0x) & 0x;
> +PageNum = PageNum - (2 * EFI_SIZE_TO_PAGES(0x1));
> 
> Memory  = Start;
> 
> @@ -830,14 +834,17 @@ BBTestAllocatePagesInterfaceTest (
> PageNum = (UINTN)Descriptor.NumberOfPages;
> Start   = Descriptor.PhysicalStart;
> 
> -//
> -// Some memory types need more alignment than 4K, so
> -//
> -if (PageNum <= 0x10) {
> +//
> +// Calculate New Start address and PageNum with 64k alignment to
> +// cover the case that some memory types' alignment is more than
> +// 4k. If the available memory is less than 192k, the memory
> +// allocation call will be skipped.
> +//
> +if (PageNum < (3 * EFI_SIZE_TO_PAGES(0x1))) {
>   break;
> }
> -Start   = (Start + 0x) & 0x;
> -PageNum = PageNum - EFI_SIZE_TO_PAGES(0x1);
> +Start   = (Start + 0x) & 0x;
> +PageNum = PageNum - (2 * EFI_SIZE_TO_PAGES(0x1));
> 
> Memory  = Start;
> 
> @@ -953,14 +960,17 @@ BBTestAllocatePagesInterfaceTest (
> PageNum = (UINTN)Descriptor.NumberOfPages;
> Start   = Descriptor.PhysicalStart;
> 
> -//
> -// Some memory types need more alignment than 4K, so
> -//
> -if (PageNum <= 0x10) {
> +//
> +// Calculate New Start address and PageNum with 64k alignment to
> +// cover the case that some memory types'

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-08-03 Thread Samer El-Haj-Mahmoud

+Heinrich

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Sunny
> Wang via groups.io
> Sent: Monday, July 19, 2021 4:08 AM
> To: devel@edk2.groups.io
> Cc: Sunny Wang ; Samer El-Haj-Mahmoud
> ; G Edhaya Chandran
> ; Barton Gao ;
> Sunny Wang 
> Subject: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update
> page alignment calculations
>
> This is to fix the SCT BS.AllocatePages failures (not found) with the
> case that the Start address is not aligned to 64k.
> For example,
>   The following is available memory region for testing:
> 82012000-EB6D9FFF 000696C8
>   With the current page alignment calculation, we will get:
> Start address is 0x8202
> PageNum is 0x696B8
>   In BS.AllocatePages, it will make the end address align with 64k,
>   so PageNum will be changed from 0x696B8 to 0x696C0. Therefore, the
>   end address will become 0xEB6E which is larger than 0xEB6D9FFF,
>   so we get not found error in the end.
>
> Therefore, the calculation for getting the PageNum should be updated
> to PageNum - (2 * EFI_SIZE_TO_PAGES(0x1)) so that we won't get a
> wrong PageNum to allocate a memory with a size larger than available
> space's size.
>
> With this solution, the example above will get 0x696A8 as calculated
> PageNum. Then, in BS.AllocatePages, the PageNum will be changed from
> 0x696A8 to 0x696B0. Therefore, the end address will become 0xEB6D
> that is smaller than 0xEB6D9FFF, so we get not found error in the end.
>
> I also tested this solution on two ARM platforms (NXP1046A and RPi4).
>
> Cc: Samer El-Haj-Mahmoud 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Signed-off-by: Sunny Wang 
> ---
>  .../MemoryAllocationServicesBBTestFunction.c  | 110 +++---
>  1 file changed, 66 insertions(+), 44 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/Blac
> kBoxTest/MemoryAllocationServicesBBTestFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/Blac
> kBoxTest/MemoryAllocationServicesBBTestFunction.c
> index bf8cd3b3..cdfac992 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/Blac
> kBoxTest/MemoryAllocationServicesBBTestFunction.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/Blac
> kBoxTest/MemoryAllocationServicesBBTestFunction.c
> @@ -2,6 +2,7 @@
>
>Copyright 2006 - 2013 Unified EFI, Inc.
>Copyright (c) 2010 - 2013, Intel Corporation. All rights reserved.
> +  Copyright (c) 2021, ARM Limited. All rights reserved.
>
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
> @@ -24,7 +25,7 @@ Abstract:
>
>  --*/
>
> -#include "SctLib.h"
> +#include "SctLib.h"
>  #include "MemoryAllocationServicesBBTestMain.h"
>
>  #define ALLOCATEPAGES_MEMORYTYPE_NUM 16
> @@ -700,14 +701,17 @@ BBTestAllocatePagesInterfaceTest (
>  PageNum = (UINTN)Descriptor.NumberOfPages;
>  Start   = Descriptor.PhysicalStart;
>
> -//
> -// Some memory types need more alignment than 4K, so
> -//
> -if (PageNum <= 0x10) {
> +//
> +// Calculate New Start address and PageNum with 64k alignment to
> +// cover the case that some memory types' alignment is more than
> +// 4k. If the available memory is less than 192k, the memory
> +// allocation call will be skipped.
> +//
> +if (PageNum < (3 * EFI_SIZE_TO_PAGES(0x1))) {
>break;
>  }
> -Start   = (Start + 0x) & 0x;
> -PageNum = PageNum - EFI_SIZE_TO_PAGES(0x1);
> +Start   = (Start + 0x) & 0x;
> +PageNum = PageNum - (2 * EFI_SIZE_TO_PAGES(0x1));
>
>  Memory  = Start;
>
> @@ -830,14 +834,17 @@ BBTestAllocatePagesInterfaceTest (
>  PageNum = (UINTN)Descriptor.NumberOfPages;
>  Start   = Descriptor.PhysicalStart;
>
> -//
> -// Some memory types need more alignment than 4K, so
> -//
> -if (PageNum <= 0x10) {
> +//
> +// Calculate New Start address and PageNum with 64k alignment to
> +// cover the case that some memory types' alignment is more than
> +// 4k. If the available memory is less than 192k, the memory
> +// allocation call will be skipped.
> +//
> +if (PageNum < (3 * EFI_SIZE_TO_PAGES(0x1))) {
>break;
>  }
> -

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-07-27 Thread G Edhaya Chandran

Reviewed-by: G Edhaya Chandran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78204): https://edk2.groups.io/g/devel/message/78204
Mute This Topic: https://groups.io/mt/83439673/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-07-27 Thread G Edhaya Chandran

Reviewed-by: G Edhaya Chandran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78201): https://edk2.groups.io/g/devel/message/78201
Mute This Topic: https://groups.io/mt/84303611/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-07-19 Thread Sunny Wang

This is to fix the SCT BS.AllocatePages failures (not found) with the
case that the Start address is not aligned to 64k.
For example,
  The following is available memory region for testing:
82012000-EB6D9FFF 000696C8
  With the current page alignment calculation, we will get:
Start address is 0x8202
PageNum is 0x696B8
  In BS.AllocatePages, it will make the end address align with 64k,
  so PageNum will be changed from 0x696B8 to 0x696C0. Therefore, the
  end address will become 0xEB6E which is larger than 0xEB6D9FFF,
  so we get not found error in the end.

Therefore, the calculation for getting the PageNum should be updated
to PageNum - (2 * EFI_SIZE_TO_PAGES(0x1)) so that we won't get a
wrong PageNum to allocate a memory with a size larger than available
space's size.

With this solution, the example above will get 0x696A8 as calculated
PageNum. Then, in BS.AllocatePages, the PageNum will be changed from
0x696A8 to 0x696B0. Therefore, the end address will become 0xEB6D
that is smaller than 0xEB6D9FFF, so we get not found error in the end.

I also tested this solution on two ARM platforms (NXP1046A and RPi4).

Cc: Samer El-Haj-Mahmoud 
Cc: G Edhaya Chandran 
Cc: Barton Gao 
Signed-off-by: Sunny Wang 
---
 .../MemoryAllocationServicesBBTestFunction.c  | 110 +++---
 1 file changed, 66 insertions(+), 44 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
index bf8cd3b3..cdfac992 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
@@ -2,6 +2,7 @@
 
   Copyright 2006 - 2013 Unified EFI, Inc.
   Copyright (c) 2010 - 2013, Intel Corporation. All rights reserved.
+  Copyright (c) 2021, ARM Limited. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
@@ -24,7 +25,7 @@ Abstract:
 
 --*/
 
-#include "SctLib.h"
+#include "SctLib.h"
 #include "MemoryAllocationServicesBBTestMain.h"
 
 #define ALLOCATEPAGES_MEMORYTYPE_NUM 16
@@ -700,14 +701,17 @@ BBTestAllocatePagesInterfaceTest (
 PageNum = (UINTN)Descriptor.NumberOfPages;
 Start   = Descriptor.PhysicalStart;
 
-//
-// Some memory types need more alignment than 4K, so
-//
-if (PageNum <= 0x10) {
+//
+// Calculate New Start address and PageNum with 64k alignment to
+// cover the case that some memory types' alignment is more than
+// 4k. If the available memory is less than 192k, the memory
+// allocation call will be skipped.
+//
+if (PageNum < (3 * EFI_SIZE_TO_PAGES(0x1))) {
   break;
 }
-Start   = (Start + 0x) & 0x;
-PageNum = PageNum - EFI_SIZE_TO_PAGES(0x1);
+Start   = (Start + 0x) & 0x;
+PageNum = PageNum - (2 * EFI_SIZE_TO_PAGES(0x1));
 
 Memory  = Start;
 
@@ -830,14 +834,17 @@ BBTestAllocatePagesInterfaceTest (
 PageNum = (UINTN)Descriptor.NumberOfPages;
 Start   = Descriptor.PhysicalStart;
 
-//
-// Some memory types need more alignment than 4K, so
-//
-if (PageNum <= 0x10) {
+//
+// Calculate New Start address and PageNum with 64k alignment to
+// cover the case that some memory types' alignment is more than
+// 4k. If the available memory is less than 192k, the memory
+// allocation call will be skipped.
+//
+if (PageNum < (3 * EFI_SIZE_TO_PAGES(0x1))) {
   break;
 }
-Start   = (Start + 0x) & 0x;
-PageNum = PageNum - EFI_SIZE_TO_PAGES(0x1);
+Start   = (Start + 0x) & 0x;
+PageNum = PageNum - (2 * EFI_SIZE_TO_PAGES(0x1));
 
 Memory  = Start;
 
@@ -953,14 +960,17 @@ BBTestAllocatePagesInterfaceTest (
 PageNum = (UINTN)Descriptor.NumberOfPages;
 Start   = Descriptor.PhysicalStart;
 
-//
-// Some memory types need more alignment than 4K, so
-//
-if (PageNum <= 0x10) {
+//
+// Calculate New Start address and PageNum with 64k alignment to
+// cover the case that some memory types' alignment is more than
+// 4k. If the available memory is less than 192k, the memory
+// allocation call will be skipped.
+//
+if (PageNum < (3 * EFI_SIZE_TO_PAGES(0x1))) {
   break;
 }
-Start   = (Start + 0x) &

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-06-18 Thread Sunny Wang

Looks good to me.
Reviewed-by: Sunny Wang 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Gao Jie via 
groups.io
Sent: Thursday, June 10, 2021 3:39 PM
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Samer El-Haj-Mahmoud 
; Eric Jin ; Arvin Chen 

Subject: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc 
for RegisterFilterLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246

MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg, RegisterFilterLibNull which will be
consumed by IoLib and BaseLib was added in MdeLibs.dsc.inc.

To build UefiSct with edk2-stable202105 and later, this file
must be included in dsc file.

Cc: G Edhaya Chandran 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 

Signed-off-by: Barton Gao 
---
 uefi-sct/SctPkg/UEFI/IHV_SCT.dsc  | 2 ++
 uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
index 3371141f..7a4393e0 100644
--- a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
+++ b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
@@ -136,6 +136,8 @@

 [Libraries.IA32,Libraries.X64]

+!include MdePkg/MdeLibs.dsc.inc
+
 [LibraryClasses.common]
   
UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
   
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
diff --git a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc 
b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
index 2b4f415f..5b3e5307 100644
--- a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
+++ b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
@@ -138,6 +138,8 @@
 [Libraries.RISCV64]
   ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf

+!include MdePkg/MdeLibs.dsc.inc
+
 [LibraryClasses.common]
   
UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
   
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
--
2.31.0.windows.1







IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76747): https://edk2.groups.io/g/devel/message/76747
Mute This Topic: https://groups.io/mt/83439673/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-15 Thread Sunny Wang

Yeah, that is a typo. The result with 13 passes was got from testing with this 
fix. Thanks for catching this, Barton.

Best Regards,
Sunny Wang

-Original Message-
From: Gao Jie 
Sent: Wednesday, June 16, 2021 9:15 AM
To: devel@edk2.groups.io; Sunny Wang ; Samer El-Haj-Mahmoud 
; 'Heinrich Schuchardt' 
Cc: G Edhaya Chandran ; 'Michael D Kinney' 

Subject: 回复: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create 
event with TPL_HIGH_LEVEL

Hi Sunny,

I believe the result with 13 passes should be tested *with* this fix, right?

I saw reviewed-by/Acked-by from Samer and Heinrich, will get this patch 
upstreamed soon.

Thanks
Barton

-邮件原件-
发件人: devel@edk2.groups.io  代表 Sunny Wang
发送时间: 2021年6月14日 17:53
收件人: Samer El-Haj-Mahmoud ; Heinrich Schuchardt 
; devel@edk2.groups.io
抄送: G Edhaya Chandran ; Barton Gao 
; Michael D Kinney ; Sunny 
Wang 
主题: Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create 
event with TPL_HIGH_LEVEL

Thanks for the review, Samer.
Moreover, I just built it and tested it on my ARM system, and confirmed the 
issue got fixed by this patch.

Without this fix, the result would be 18 tests, and 4 Errors.
CreateEvent_Func: [FAILED]
  Passes... 14
  Warnings. 0
  Errors... 4

Without this fix, the result would be 13 tests, and 0 Errors.
CreateEvent_Func: [PASSED]
  Passes... 13
  Warnings. 0
  Errors... 0

Best Regards,
Sunny Wang

-Original Message-
From: Samer El-Haj-Mahmoud 
Sent: Monday, June 14, 2021 8:36 AM
To: Heinrich Schuchardt ; Sunny Wang ; 
devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao 
; Michael D Kinney ; Samer 
El-Haj-Mahmoud 
Subject: RE: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with 
TPL_HIGH_LEVEL

Reviewed-By: Samer El-Haj-Mahmoud 

> -Original Message-
> From: Heinrich Schuchardt 
> Sent: Friday, June 11, 2021 5:15 AM
> To: Sunny Wang ; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud ; G Edhaya
> Chandran ; Barton Gao
> ; Michael D Kinney 
> Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event
> with TPL_HIGH_LEVEL
>
> On 11.06.21 10:35, Sunny Wang wrote:
> > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent
> failures.
> >
> > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> > exclusive use by the firmware. The creation of events by UEFI
> > applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> > level.
> >
> > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> > with UEFI Spec and fix the failures.
> >
> > For more information, https://edk2.groups.io/g/devel/message/76338
> >
> > Cc: Samer El-Haj-Mahmoud 
> > Cc: G Edhaya Chandran 
> > Cc: Barton Gao 
> > Cc: Heinrich Schuchardt 
> > Cc: Michael D Kinney 
> > Signed-off-by: Sunny Wang 
>
> Acked-by: Heinrich Schuchardt 
>
> > ---
> >  .../EventTimerTaskPriorityServicesBBTestCreateEvent.c| 5 +
> >  .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c  | 4 +---
> >  2 files changed, 2 insertions(+), 7 deletions(-)
> >
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > index a7e7366e..d5c033f7 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > @@ -2,6 +2,7 @@
> >
> >Copyright 2006 - 2012 Unified EFI, Inc.
> >Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
> > +  Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> >This program and the accompanying materials
> >are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> >EFI_TPL NotifyTpls[] = {
> >

回复: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-15 Thread Gao Jie

Hi Sunny,

I believe the result with 13 passes should be tested *with* this fix, right?

I saw reviewed-by/Acked-by from Samer and Heinrich, will get this patch 
upstreamed soon.

Thanks
Barton

-邮件原件-
发件人: devel@edk2.groups.io  代表 Sunny Wang
发送时间: 2021年6月14日 17:53
收件人: Samer El-Haj-Mahmoud ; Heinrich Schuchardt 
; devel@edk2.groups.io
抄送: G Edhaya Chandran ; Barton Gao 
; Michael D Kinney ; Sunny 
Wang 
主题: Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create 
event with TPL_HIGH_LEVEL

Thanks for the review, Samer.
Moreover, I just built it and tested it on my ARM system, and confirmed the 
issue got fixed by this patch.

Without this fix, the result would be 18 tests, and 4 Errors.
CreateEvent_Func: [FAILED]
  Passes... 14
  Warnings. 0
  Errors... 4

Without this fix, the result would be 13 tests, and 0 Errors.
CreateEvent_Func: [PASSED]
  Passes... 13
  Warnings. 0
  Errors... 0

Best Regards,
Sunny Wang

-Original Message-
From: Samer El-Haj-Mahmoud 
Sent: Monday, June 14, 2021 8:36 AM
To: Heinrich Schuchardt ; Sunny Wang ; 
devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao 
; Michael D Kinney ; Samer 
El-Haj-Mahmoud 
Subject: RE: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with 
TPL_HIGH_LEVEL

Reviewed-By: Samer El-Haj-Mahmoud 

> -Original Message-
> From: Heinrich Schuchardt 
> Sent: Friday, June 11, 2021 5:15 AM
> To: Sunny Wang ; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud ; G Edhaya
> Chandran ; Barton Gao
> ; Michael D Kinney 
> Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event
> with TPL_HIGH_LEVEL
>
> On 11.06.21 10:35, Sunny Wang wrote:
> > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent
> failures.
> >
> > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> > exclusive use by the firmware. The creation of events by UEFI
> > applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> > level.
> >
> > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> > with UEFI Spec and fix the failures.
> >
> > For more information, https://edk2.groups.io/g/devel/message/76338
> >
> > Cc: Samer El-Haj-Mahmoud 
> > Cc: G Edhaya Chandran 
> > Cc: Barton Gao 
> > Cc: Heinrich Schuchardt 
> > Cc: Michael D Kinney 
> > Signed-off-by: Sunny Wang 
>
> Acked-by: Heinrich Schuchardt 
>
> > ---
> >  .../EventTimerTaskPriorityServicesBBTestCreateEvent.c| 5 +
> >  .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c  | 4 +---
> >  2 files changed, 2 insertions(+), 7 deletions(-)
> >
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > index a7e7366e..d5c033f7 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > @@ -2,6 +2,7 @@
> >
> >Copyright 2006 - 2012 Unified EFI, Inc.
> >Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
> > +  Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> >This program and the accompanying materials
> >are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIF

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-14 Thread Sunny Wang

Thanks for the review, Samer.
Moreover, I just built it and tested it on my ARM system, and confirmed the 
issue got fixed by this patch.

Without this fix, the result would be 18 tests, and 4 Errors.
CreateEvent_Func: [FAILED]
  Passes... 14
  Warnings. 0
  Errors... 4

Without this fix, the result would be 13 tests, and 0 Errors.
CreateEvent_Func: [PASSED]
  Passes... 13
  Warnings. 0
  Errors... 0

Best Regards,
Sunny Wang

-Original Message-
From: Samer El-Haj-Mahmoud 
Sent: Monday, June 14, 2021 8:36 AM
To: Heinrich Schuchardt ; Sunny Wang ; 
devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao 
; Michael D Kinney ; Samer 
El-Haj-Mahmoud 
Subject: RE: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with 
TPL_HIGH_LEVEL

Reviewed-By: Samer El-Haj-Mahmoud 

> -Original Message-
> From: Heinrich Schuchardt 
> Sent: Friday, June 11, 2021 5:15 AM
> To: Sunny Wang ; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud ; G Edhaya
> Chandran ; Barton Gao
> ; Michael D Kinney 
> Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event
> with TPL_HIGH_LEVEL
>
> On 11.06.21 10:35, Sunny Wang wrote:
> > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent
> failures.
> >
> > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> > exclusive use by the firmware. The creation of events by UEFI
> > applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> > level.
> >
> > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> > with UEFI Spec and fix the failures.
> >
> > For more information, https://edk2.groups.io/g/devel/message/76338
> >
> > Cc: Samer El-Haj-Mahmoud 
> > Cc: G Edhaya Chandran 
> > Cc: Barton Gao 
> > Cc: Heinrich Schuchardt 
> > Cc: Michael D Kinney 
> > Signed-off-by: Sunny Wang 
>
> Acked-by: Heinrich Schuchardt 
>
> > ---
> >  .../EventTimerTaskPriorityServicesBBTestCreateEvent.c| 5 +
> >  .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c  | 4 +---
> >  2 files changed, 2 insertions(+), 7 deletions(-)
> >
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > index a7e7366e..d5c033f7 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > @@ -2,6 +2,7 @@
> >
> >Copyright 2006 - 2012 Unified EFI, Inc.
> >Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
> > +  Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> >This program and the accompanying materials
> >are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > index eb458de5..03b7ae6e 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
>

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-13 Thread Samer El-Haj-Mahmoud

Reviewed-By: Samer El-Haj-Mahmoud 

> -Original Message-
> From: Heinrich Schuchardt 
> Sent: Friday, June 11, 2021 5:15 AM
> To: Sunny Wang ; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud ; G Edhaya
> Chandran ; Barton Gao
> ; Michael D Kinney 
> Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event
> with TPL_HIGH_LEVEL
>
> On 11.06.21 10:35, Sunny Wang wrote:
> > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent
> failures.
> >
> > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> > exclusive use by the firmware. The creation of events by UEFI
> > applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> > level.
> >
> > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> > with UEFI Spec and fix the failures.
> >
> > For more information, https://edk2.groups.io/g/devel/message/76338
> >
> > Cc: Samer El-Haj-Mahmoud 
> > Cc: G Edhaya Chandran 
> > Cc: Barton Gao 
> > Cc: Heinrich Schuchardt 
> > Cc: Michael D Kinney 
> > Signed-off-by: Sunny Wang 
>
> Acked-by: Heinrich Schuchardt 
>
> > ---
> >  .../EventTimerTaskPriorityServicesBBTestCreateEvent.c| 5 +
> >  .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c  | 4 +---
> >  2 files changed, 2 insertions(+), 7 deletions(-)
> >
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > index a7e7366e..d5c033f7 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > @@ -2,6 +2,7 @@
> >
> >Copyright 2006 - 2012 Unified EFI, Inc.
> >Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
> > +  Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> >This program and the accompanying materials
> >are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >  0
> >};
> >EFI_TEST_ASSERTION  AssertionType;
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > index eb458de5..03b7ae6e 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > @@ -2,6 +2,7 @@
> >
> >Copyright 2006 - 2016 Unified EFI, Inc.
> >Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
> > +  Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> >This program and the accompanying materials
> >are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
> >EFI_TPL NotifyTpls[] = {
> >  TPL_CALLBACK,
> >  TPL_NOTIFY,
> > -TPL_HIGH_LEVEL,
> >

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Heinrich Schuchardt

On 11.06.21 10:35, Sunny Wang wrote:
> The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures.
>
> Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> exclusive use by the firmware. The creation of events by UEFI
> applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> level.
>
> Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> with UEFI Spec and fix the failures.
>
> For more information, https://edk2.groups.io/g/devel/message/76338
>
> Cc: Samer El-Haj-Mahmoud 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Heinrich Schuchardt 
> Cc: Michael D Kinney 
> Signed-off-by: Sunny Wang 

Acked-by: Heinrich Schuchardt 

> ---
>  .../EventTimerTaskPriorityServicesBBTestCreateEvent.c| 5 +
>  .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c  | 4 +---
>  2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
>  
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> index a7e7366e..d5c033f7 100644
> --- 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> +++ 
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> @@ -2,6 +2,7 @@
>
>Copyright 2006 - 2012 Unified EFI, Inc.
>Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
> +  Copyright (c) 2021, ARM Limited. All rights reserved.
>
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD 
> License
> @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> diff --git 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
>  
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> index eb458de5..03b7ae6e 100644
> --- 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> +++ 
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> @@ -2,6 +2,7 @@
>
>Copyright 2006 - 2016 Unified EFI, Inc.
>Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
> +  Copyright (c) 2021, ARM Limited. All rights reserved.
>
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD 
> License
> @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_GUID*EventGroups[] = {
> @@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_GUID*EventGroups[] = {
> @@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Sunny Wang

Thanks for catching this, Heinrich.
I sent v2 to also revert TPL_HIGH_LEVEL changes in ae7e5477b555.

Best Regards,
Sunny Wang

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Heinrich 
Schuchardt via groups.io
Sent: Friday, June 11, 2021 4:24 PM
To: Sunny Wang 
Cc: Samer El-Haj-Mahmoud ; G Edhaya Chandran 
; Barton Gao ; Michael D Kinney 
; devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create 
event with TPL_HIGH_LEVEL

On 11.06.21 09:07, Sunny Wang wrote:
> The commit a9d1fb58 caused SCT BS.CreateEvent failures.
>
> Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> exclusive use by the firmware. The creation of events by UEFI
> applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> level.
>
> Therefore, revert TPL_HIGH_LEVEL change in commit a9d1fb58 to not create
> event with TPL_HIGH_LEVEL to be compliant with UEFI Spec and fix the
> failures.
>
> For more information, https://edk2.groups.io/g/devel/message/76338

Please, have a look at commit ae7e5477b555 ("uefi-sct/SctPkg: allowable
NotifyTpl in CreateEventEx") too.

Acked-by: Heinrich Schuchardt 

>
> Cc: Samer El-Haj-Mahmoud 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Heinrich Schuchardt 
> Cc: Michael D Kinney 
> Signed-off-by: Sunny Wang 
> ---
>  .../EventTimerTaskPriorityServicesBBTestCreateEvent.c| 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
>  
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> index a7e7366e..d5c033f7 100644
> --- 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> +++ 
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> @@ -2,6 +2,7 @@
>
>Copyright 2006 - 2012 Unified EFI, Inc.
>Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
> +  Copyright (c) 2021, ARM Limited. All rights reserved.
>
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD 
> License
> @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
>






IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76376): https://edk2.groups.io/g/devel/message/76376
Mute This Topic: https://groups.io/mt/83463343/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Sunny Wang

The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures.

Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
exclusive use by the firmware. The creation of events by UEFI
applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
level.

Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
with UEFI Spec and fix the failures.

For more information, https://edk2.groups.io/g/devel/message/76338

Cc: Samer El-Haj-Mahmoud 
Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Heinrich Schuchardt 
Cc: Michael D Kinney 
Signed-off-by: Sunny Wang 
---
 .../EventTimerTaskPriorityServicesBBTestCreateEvent.c| 5 +
 .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c  | 4 +---
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
index a7e7366e..d5c033f7 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
@@ -2,6 +2,7 @@
 
   Copyright 2006 - 2012 Unified EFI, Inc.
   Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
+  Copyright (c) 2021, ARM Limited. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
@@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_TEST_ASSERTION  AssertionType;
@@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_TEST_ASSERTION  AssertionType;
@@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_TEST_ASSERTION  AssertionType;
@@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_TEST_ASSERTION  AssertionType;
diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
index eb458de5..03b7ae6e 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
@@ -2,6 +2,7 @@
 
   Copyright 2006 - 2016 Unified EFI, Inc.
   Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
+  Copyright (c) 2021, ARM Limited. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
@@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_GUID*EventGroups[] = {
@@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_GUID*EventGroups[] = {
@@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_GUID*EventGroups[] = {
-- 
2.31.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Heinrich Schuchardt

On 11.06.21 09:07, Sunny Wang wrote:
> The commit a9d1fb58 caused SCT BS.CreateEvent failures.
>
> Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> exclusive use by the firmware. The creation of events by UEFI
> applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> level.
>
> Therefore, revert TPL_HIGH_LEVEL change in commit a9d1fb58 to not create
> event with TPL_HIGH_LEVEL to be compliant with UEFI Spec and fix the
> failures.
>
> For more information, https://edk2.groups.io/g/devel/message/76338

Please, have a look at commit ae7e5477b555 ("uefi-sct/SctPkg: allowable
NotifyTpl in CreateEventEx") too.

Acked-by: Heinrich Schuchardt 

>
> Cc: Samer El-Haj-Mahmoud 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Heinrich Schuchardt 
> Cc: Michael D Kinney 
> Signed-off-by: Sunny Wang 
> ---
>  .../EventTimerTaskPriorityServicesBBTestCreateEvent.c| 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
>  
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> index a7e7366e..d5c033f7 100644
> --- 
> a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> +++ 
> b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> @@ -2,6 +2,7 @@
>
>Copyright 2006 - 2012 Unified EFI, Inc.
>Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
> +  Copyright (c) 2021, ARM Limited. All rights reserved.
>
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD 
> License
> @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
> @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
>EFI_TPL NotifyTpls[] = {
>  TPL_CALLBACK,
>  TPL_NOTIFY,
> -TPL_HIGH_LEVEL,
>  0
>};
>EFI_TEST_ASSERTION  AssertionType;
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76374): https://edk2.groups.io/g/devel/message/76374
Mute This Topic: https://groups.io/mt/83463343/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Sunny Wang

The commit a9d1fb58 caused SCT BS.CreateEvent failures.

Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
exclusive use by the firmware. The creation of events by UEFI
applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
level.

Therefore, revert TPL_HIGH_LEVEL change in commit a9d1fb58 to not create
event with TPL_HIGH_LEVEL to be compliant with UEFI Spec and fix the
failures.

For more information, https://edk2.groups.io/g/devel/message/76338

Cc: Samer El-Haj-Mahmoud 
Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Heinrich Schuchardt 
Cc: Michael D Kinney 
Signed-off-by: Sunny Wang 
---
 .../EventTimerTaskPriorityServicesBBTestCreateEvent.c| 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
index a7e7366e..d5c033f7 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
@@ -2,6 +2,7 @@
 
   Copyright 2006 - 2012 Unified EFI, Inc.
   Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
+  Copyright (c) 2021, ARM Limited. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
@@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_TEST_ASSERTION  AssertionType;
@@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_TEST_ASSERTION  AssertionType;
@@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_TEST_ASSERTION  AssertionType;
@@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
   EFI_TPL NotifyTpls[] = {
 TPL_CALLBACK,
 TPL_NOTIFY,
-TPL_HIGH_LEVEL,
 0
   };
   EFI_TEST_ASSERTION  AssertionType;
-- 
2.31.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76368): https://edk2.groups.io/g/devel/message/76368
Mute This Topic: https://groups.io/mt/83463343/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-06-10 Thread Gao Jie

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246

MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg, RegisterFilterLibNull which will be
consumed by IoLib and BaseLib was added in MdeLibs.dsc.inc.

To build UefiSct with edk2-stable202105 and later, this file
must be included in dsc file.

Cc: G Edhaya Chandran 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 

Signed-off-by: Barton Gao 
---
 uefi-sct/SctPkg/UEFI/IHV_SCT.dsc  | 2 ++
 uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
index 3371141f..7a4393e0 100644
--- a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
+++ b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
@@ -136,6 +136,8 @@
 
 [Libraries.IA32,Libraries.X64]
 
+!include MdePkg/MdeLibs.dsc.inc
+
 [LibraryClasses.common]
   
UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
   
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
diff --git a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc 
b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
index 2b4f415f..5b3e5307 100644
--- a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
+++ b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
@@ -138,6 +138,8 @@
 [Libraries.RISCV64]
   ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
 
+!include MdePkg/MdeLibs.dsc.inc
+
 [LibraryClasses.common]
   
UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
   
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
-- 
2.31.0.windows.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76320): https://edk2.groups.io/g/devel/message/76320
Mute This Topic: https://groups.io/mt/83439673/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] edk2-test: Request for new github repo

2021-05-27 Thread Nate DeSimone

Hi Grant,

Edkrepo has a similar high level objective of enabling multi-repository 
workflows in git. However, it is more feature rich than repo. Here is an 
unexhaustive list of features it provides above and beyond repo:

1. Simplified project discovery - The "edkrepo manifest" shows a centralized 
inventory of all currently known projects. For example:

nate@nate-desktop:~$ edkrepo manifest

Syncing the global manifest repository: 
/home/nate/.edkrepo/edk2-edkrepo-manifest-main

Manifest directory:
edk2-edkrepo-manifest

Verifying the active projects in the global manifest repository

Projects:
  EdkRepo
  EdkRepoManifest
  Intel-MinPlatform
  edk2
nate@nate-desktop:~$

Then one can create a new clone of any project by specifying the name 
of the project to be cloned, for example:

edkrepo clone  Intel-MinPlatform

One can also clone from a loose manifest file by providing the path to 
the .xml file in lieu of the project name.

Additional manifest repositories can be added to this list via the 
"edkrepo manifest-repos" command.

2. More hierarchy - Each manifest can describe multiple combinations of 
branches instead of a one-to-one relationship between branches and repositories.

nate@nate-desktop:~/src/min2 [master]$ edkrepo combo -v
* master
edk2   : master
edk2-platforms : master
edk2-non-osi   : master
FSP: master
nate@nate-desktop:~/src/min2 [master]$

3. Cross platform - Runs on Windows, Linux, macOS. With effort put in to 
universal Linux distro compatibility (or at least an attempt at it!)
4. Sparse checkout - Automatically configures the git sparse checkout list 
based on manifest settings. This is particularly useful for edk2-platforms, 
which has a lot of unrelated packages in the same repository.
5. Local caching - An optional feature that will store a bare copy of remote 
git repositories locally, so if you make lots of clones as part of your normal 
workflow they will be created very quickly from the local copy with minimal 
network I/O.
6. Tab autocompletion - Similar to repo, EdkRepo includes shell scripts to 
enable autocompletion of commands for both bash and zsh.

In the future we plan to integrate support for automating the GitHub Pull 
Request process, so once TianoCore moves from email patches to pull requests we 
will have tooling that takes out most of the clicks out of sending a PR.

We use it internally at Intel for all our UEFI firmware development. If you are 
interested in giving it a try, the latest release (at time of writing) is 
available here: 
https://github.com/tianocore/edk2-edkrepo/releases/tag/edkrepo-v2.1.2

We have a (slightly out of date) user's guide available here: 
https://github.com/tianocore/edk2-edkrepo/blob/main/edkrepouserguide.pdf

Both Ashley and I would be happy to hear any feedback that you might have!

Regards,
Nate

-Original Message-
From: Grant Likely  
Sent: Monday, May 24, 2021 4:09 AM
To: Kinney, Michael D ; devel@edk2.groups.io; G 
Edhaya Chandran ; Samer El-Haj-Mahmoud 
; Desimone, Nathaniel L 
; Desimone, Ashley E 

Cc: n...@arm.com
Subject: Re: [edk2-devel] edk2-test: Request for new github repo

Thanks Mike,

I've not come across edkrepo before. I've been using repo becuase it is a 
common tool used by many projects. How does edkrepo compare?

g.

On 12/05/2021 16:53, Kinney, Michael D wrote:
> Hi Grant,
> 
> There is already a repo like this in tianocore:
> 
>   https://github.com/tianocore/edk2-edkrepo-manifest
> 
> It is focused on manifests used by the edkrepo tool:
> 
>   https://github.com/tianocore/edk2-edkrepo
> 
> Nate and Ashley are the maintainers.  They can help you with using 
> edkrepo for this edk2-test use case.
> 
> Thanks,
> 
> Mike
> 
>> -Original Message-
>> From: devel@edk2.groups.io  On Behalf Of Grant 
>> Likely
>> Sent: Wednesday, May 12, 2021 5:32 AM
>> To: devel@edk2.groups.io; G Edhaya Chandran 
>> ; Samer El-Haj-Mahmoud 
>> 
>> Cc: n...@arm.com
>> Subject: [edk2-devel] edk2-test: Request for new github repo
>>
>> Would it be possible to get a new repo under the github.com/tianocore 
>> project? I've got a repo manifest that I've been using for building 
>> the SCT, and is now being used by quite a few people. However it is 
>> currently hosted under my personal area here:
>>
>> https://github.com/glikely/edk2-test-manifest
>>
>> There is very little actually in the manifest, but it makes it really 
>> easy to clone all the pieces needed to build the SCT from scratch 
>> with the following commands:
>>
>> $ mkdir e

Re: [edk2-devel] edk2-test: Request for new github repo

2021-05-24 Thread Grant Likely


Thanks Mike,

I've not come across edkrepo before. I've been using repo becuase it is 
a common tool used by many projects. How does edkrepo compare?


g.

On 12/05/2021 16:53, Kinney, Michael D wrote:

Hi Grant,

There is already a repo like this in tianocore:

https://github.com/tianocore/edk2-edkrepo-manifest

It is focused on manifests used by the edkrepo tool:

https://github.com/tianocore/edk2-edkrepo

Nate and Ashley are the maintainers.  They can help you with using edkrepo for 
this
edk2-test use case.

Thanks,

Mike


-Original Message-
From: devel@edk2.groups.io  On Behalf Of Grant Likely
Sent: Wednesday, May 12, 2021 5:32 AM
To: devel@edk2.groups.io; G Edhaya Chandran ; Samer 
El-Haj-Mahmoud 
Cc: n...@arm.com
Subject: [edk2-devel] edk2-test: Request for new github repo

Would it be possible to get a new repo under the github.com/tianocore
project? I've got a repo manifest that I've been using for building the
SCT, and is now being used by quite a few people. However it is
currently hosted under my personal area here:

https://github.com/glikely/edk2-test-manifest

There is very little actually in the manifest, but it makes it really
easy to clone all the pieces needed to build the SCT from scratch with
the following commands:

$ mkdir edk2-test-build
$ cd edk2-test-build
$ repo init -u https://github.com/glikely/edk2-test-manifest
$ repo sync
$ ./buildzip.sh AARCH64

The buildzip script itself is already hosted in edk2-test. This repo
just contains the repo manifest for cloning the required trees and
creating the needed symlinks.

Would it be possible to host this manifest within the tianocore project
at https://github.com/tianocore/edk2-test-manifest?

Thanks,
g.










-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75512): https://edk2.groups.io/g/devel/message/75512
Mute This Topic: https://groups.io/mt/82770629/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] edk2-test: Request for new github repo

2021-05-12 Thread Michael D Kinney

Hi Grant,

There is already a repo like this in tianocore:

https://github.com/tianocore/edk2-edkrepo-manifest

It is focused on manifests used by the edkrepo tool:

https://github.com/tianocore/edk2-edkrepo

Nate and Ashley are the maintainers.  They can help you with using edkrepo for 
this
edk2-test use case.

Thanks,

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Grant Likely
> Sent: Wednesday, May 12, 2021 5:32 AM
> To: devel@edk2.groups.io; G Edhaya Chandran ; Samer 
> El-Haj-Mahmoud 
> Cc: n...@arm.com
> Subject: [edk2-devel] edk2-test: Request for new github repo
> 
> Would it be possible to get a new repo under the github.com/tianocore
> project? I've got a repo manifest that I've been using for building the
> SCT, and is now being used by quite a few people. However it is
> currently hosted under my personal area here:
> 
> https://github.com/glikely/edk2-test-manifest
> 
> There is very little actually in the manifest, but it makes it really
> easy to clone all the pieces needed to build the SCT from scratch with
> the following commands:
> 
> $ mkdir edk2-test-build
> $ cd edk2-test-build
> $ repo init -u https://github.com/glikely/edk2-test-manifest
> $ repo sync
> $ ./buildzip.sh AARCH64
> 
> The buildzip script itself is already hosted in edk2-test. This repo
> just contains the repo manifest for cloning the required trees and
> creating the needed symlinks.
> 
> Would it be possible to host this manifest within the tianocore project
> at https://github.com/tianocore/edk2-test-manifest?
> 
> Thanks,
> g.
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75074): https://edk2.groups.io/g/devel/message/75074
Mute This Topic: https://groups.io/mt/82770629/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] edk2-test: Request for new github repo

2021-05-12 Thread Grant Likely

Would it be possible to get a new repo under the github.com/tianocore 
project? I've got a repo manifest that I've been using for building the 
SCT, and is now being used by quite a few people. However it is 
currently hosted under my personal area here:


https://github.com/glikely/edk2-test-manifest

There is very little actually in the manifest, but it makes it really 
easy to clone all the pieces needed to build the SCT from scratch with 
the following commands:


$ mkdir edk2-test-build
$ cd edk2-test-build
$ repo init -u https://github.com/glikely/edk2-test-manifest
$ repo sync
$ ./buildzip.sh AARCH64

The buildzip script itself is already hosted in edk2-test. This repo 
just contains the repo manifest for cloning the required trees and 
creating the needed symlinks.


Would it be possible to host this manifest within the tianocore project 
at https://github.com/tianocore/edk2-test-manifest?


Thanks,
g.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75072): https://edk2.groups.io/g/devel/message/75072
Mute This Topic: https://groups.io/mt/82770629/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

2021-05-08 Thread G Edhaya Chandran

Upstreamed by commit : 
https://github.com/tianocore/edk2-test/commit/da461e14fe86a5f4ee03ab64b412bf5f0bfe08e9


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74844): https://edk2.groups.io/g/devel/message/74844
Mute This Topic: https://groups.io/mt/81518326/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

2021-05-08 Thread G Edhaya Chandran

Reviewed-by: G Edhaya Chandran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74843): https://edk2.groups.io/g/devel/message/74843
Mute This Topic: https://groups.io/mt/81518326/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test PATCHv3 3/5] SctPkg: Add RISCV64 build support

2021-03-30 Thread Sunny Wang

Looks good to me. Same comment as the patches 1/5 and 2/5.
Reviewed-by: Sunny Wang 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Daniel Schaefer
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao 
; Samer El-Haj-Mahmoud ; 
Eric Jin ; Arvin Chen ; Leif 
Lindholm ; Heinrich Schuchardt ; Abner 
Chang 
Subject: [edk2-devel] [edk2-test PATCHv3 3/5] SctPkg: Add RISCV64 build support

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
 uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h 
 |  4 ++
 uefi-sct/SctPkg/Library/SctLib/SctLib.inf  
 |  6 ++
 uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf   
 |  5 ++
 uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf 
 |  6 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTest.inf
 |  6 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/Usb2Hc/BlackBoxTest/Usb2HcTest.inf  
 |  4 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/UsbHcTest.inf
 |  4 ++
 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf   
 |  5 ++
 uefi-sct/SctPkg/Tools/Source/GenBin/GNUmakefile
 |  4 ++
 uefi-sct/SctPkg/UEFI/IHV_SCT.dsc   
 | 17 +-
 uefi-sct/SctPkg/UEFI/Protocol/DebugSupport.h   
 | 61 +++-
 uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc  
 | 18 +-
 uefi-sct/SctPkg/build.sh   
 | 11 +++-
 13 files changed, 144 insertions(+), 7 deletions(-)

diff --git a/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h 
b/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h
index a7815580..02f0283e 100644
--- a/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h
+++ b/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h
@@ -3,6 +3,7 @@
   Copyright 2006 - 2017 Unified EFI, Inc.
   Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
   Portions copyright (c) 2014, ARM Ltd. All rights reserved.
+  (C) Copyright 2021 Hewlett Packard Enterprise Development LP

   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License @@ -32,6 +33,9 @@  #elif defined(EFIAARCH64)
   #define INSTALL_SCT_PLATFORM_SHORT_NAME   L"aarch64"
   #define INSTALL_SCT_PLATFORM_NAME L"AARCH64"
+#elif defined(EFIRISCV64)
+  #define INSTALL_SCT_PLATFORM_SHORT_NAME   L"riscv64"
+  #define INSTALL_SCT_PLATFORM_NAME L"RISCV64"
 #else
   #error "Architecture not supported"
 #endif
diff --git a/uefi-sct/SctPkg/Library/SctLib/SctLib.inf 
b/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
index 23cb77fb..7527b203 100644
--- a/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
+++ b/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
@@ -3,6 +3,7 @@
 #  Copyright 2006 - 2016 Unified EFI, Inc.  #  Copyright (c) 2013 - 2014, 
ARM Ltd. All rights reserved.  #  Copyright (c) 2014 - 2019, Intel 
Corporation. All rights reserved.
+#  (C) Copyright 2021 Hewlett Packard Enterprise Development LP
 #
 #  This program and the accompanying materials  #  are licensed and made 
available under the terms and conditions of the BSD License @@ -62,6 +63,11 @@
   Aarch64/initplat.c
   Math.c

+[sources.RISCV64]
+  Riscv64/SctLibPlat.h
+  Riscv64/initplat.c
+  Math.c
+
 [sources.ia32]
   ia32/SctLibPlat.h
   ia32/initplat.c
diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf 
b/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf
index 7aca6e30..8104a4ef 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf
+++ b/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf
@@ -2,6 +2,7 @@
 #
 #  Copyright 2006 - 2016 Unified EFI, Inc.  #  Copyright (c) 2010 - 2016, 
Intel Corporation. All rights reserved.
+#  (C) Copyright 2021 Hewlett Packard Enterprise Development LP
 #
 #  This program and the accompanying materials  #  are licensed and made 
available under the terms and conditions of the BSD License @@ -39,6 +40,10 @@
   Aarch64/GoVirtual.asm | RVCT
   Aarch64/GoVirtual.S | GCC

+[sources.RISCV64]
+  Riscv64/VirtualMemory.c
+  Riscv64/GoVirtual.S | GCC
+
 [sources.ia32]
   ia32/VirtualMemory.c
   ia32/GoVirtual.asm | MSFT
diff --git a/uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf 
b/uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf
index ad0eb0f8..a3ef454e 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf
+++ b/uefi-sct/

Re: [edk2-devel] [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-03-30 Thread Sunny Wang

Hi Daniel,

If my understanding is correct, the build flags below will be used for all the 
architectures. However, it looks like the compiler options "-ffreestanding 
-nostdinc -nostdlib" are not common enough for all the architectures. For ARM, 
this change is ok. However, this may not be ok for IA32 and X64.
GCC:*_*_*_CC_FLAGS= -ffreestanding -nostdinc -nostdlib -Wno-error

In other words, "-ffreestanding -nostdinc -nostdlib" are not currently being 
used by IA32 and x64 CC_FLAGS. The lines for IA32 and X64 having 
"-ffreestanding -nostdinc -nostdlib -Wno-error" are commented out.
#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -ffreestanding 
-nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-arg-probe 
"-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -D MDE_CPU_X32
   GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error
..
#  GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -ffreestanding 
-nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-arg-probe 
"-DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -mabi=ms -D MDE_CPU_X64
   GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error

Therefore, your patch changes the IA32 and X64 compiler options. Do we intend 
to do this? If so, you may also need to check this with Eric and Arvin. If not, 
you will need to update the patch to keep "-ffreestanding -nostdinc -nostdlib" 
in original places and have only one option "-Wno-error " in GCC:*_*_*_CC_FLAGS.

Also, good catch on meaningless compiler options -Wno-error=xxx.

Moreover, I also built SCT with this patch series and run it on my Rasberry Pi 
4, and don't see any obvious issue.

Best Regards,
Sunny Wang

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Daniel Schaefer
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao 
; Samer El-Haj-Mahmoud ; 
Eric Jin ; Arvin Chen ; Leif 
Lindholm ; Heinrich Schuchardt ; Abner 
Chang 
Subject: [edk2-devel] [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all 
GCC platforms

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
 uefi-sct/SctPkg/UEFI/IHV_SCT.dsc  | 15 ---  
uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc | 15 ---
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
index 94bb5c36..91116ca7 100644
--- a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
+++ b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
@@ -69,15 +69,16 @@
   MSFT:*_*_X64_APP_FLAGS   = /D EFIX64
   MSFT:*_*_X64_PP_FLAGS= /D EFIX64

-#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -ffreestanding 
-nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-arg-probe 
"-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -D MDE_CPU_X32
-   GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error
+   GCC:*_*_*_CC_FLAGS= -ffreestanding -nostdinc -nostdlib -Wno-error
+#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -mno-red-zone 
-Wno-address -mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m32 
-mabi=ms -D MDE_CPU_X32
+   GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO)
 #  GCC:*_*_IA32_VFRPP_FLAGS  = -D EFI32 $(GCC_VER_MACRO)
 #  GCC:*_*_IA32_APP_FLAGS= -D EFI32 $(GCC_VER_MACRO)
 #  GCC:*_*_IA32_PP_FLAGS = -D EFI32 $(GCC_VER_MACRO)

-#  GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -ffreestanding 
-nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-arg-probe 
"-DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -mabi=ms -D MDE_CPU_X64
+#  GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -mno-red-zone 
-Wno-address -mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m64 
-mcmodel=large -mabi=ms -D MDE_CPU_X64

-   GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error
+   GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO)
 #  GCC:*_*_X64_VFRPP_FLAGS  = -D EFIX64 $(GCC_VER_MACRO)
 #  GCC:*_*_X64_APP_FLAGS= -D EFIX64 $(GCC_VER_MACRO)
 #  GCC:*_*_X64_PP_FLAGS = -D EFIX64 $(GCC_VER_MACRO)
@@ -85,7 +86,7 @@

   #TODO: OM - fixme RVCT:*_*_ARM_CC_FLAGS = -D EFIARM $(GCC_VER_MACRO)
   *_*_ARM_CC_FLAGS = -D EFIARM
-  GCC:*_*_ARM_CC_FLAGS  = -D EFIARM $(GCC_VER_MACRO) -fno-stack-protector 
-ffreestanding -nostdinc -nostdlib -Wno-error=unused-function 
-Wno-error=unused-but-set-variable -Wno-error=implicit-function-declaration 
-Wno-error
+  GCC:*_*_ARM_CC_FLAGS  = -D EFIARM $(GCC_VER_MACRO)
+ -fno-stack-protector
   *_*_ARM_VFRPP_FLAGS   = -D EFIARM $(GCC_VER_MACRO)
   *_*_ARM_APP_FLAGS = -D EFIARM $(GCC_VER_MACRO)
   *_*_ARM_PP_FLAGS  = -D

Re: [edk2-devel] [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

2021-03-30 Thread Sunny Wang

Looks good to me.
Same comment as patch 1/5. This only affects RISCV. Therefore, as long as you 
build and run SCT on the RISCV platform, this change should be fine.
Reviewed-by: Sunny Wang 

-Original Message-
From: Schaefer, Daniel 
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao 
; Samer El-Haj-Mahmoud ; 
Eric Jin ; Arvin Chen ; Leif 
Lindholm ; Heinrich Schuchardt ; Chang, 
Abner (HPS SW/FW Technologist) 
Subject: [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
 uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
|  3 +-
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S   
|  9 ++--
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c   
| 16 +++
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
| 22 +++--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c   
|  7 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h   
| 48 
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c
 | 12 ++---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/PlatformIsa.c
 |  4 +-
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat.h
 |  3 +-
 9 files changed, 32 insertions(+), 92 deletions(-)

diff --git a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h 
b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
index ee7c656b..69e7f904 100644
--- a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
+++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
@@ -2,6 +2,7 @@


   Copyright 2006 - 2012 Unified EFI, Inc.

   Copyright (c) 2011 - 2012, ARM Ltd. All rights reserved.

+  Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All rights 
reserved.



   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD 
License

@@ -20,7 +21,7 @@ Module Name:


 Abstract:



-  AArch64 specific defines

+  RISCV64 specific defines



 --*/



diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S 
b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
index d223b36b..ae33da18 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
+++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
@@ -2,6 +2,7 @@
 #

 #  Copyright 2010 - 2012 Unified EFI, Inc.

 #  Copyright (c) 2012, ARM Ltd. All rights reserved.

+#  Copyright (c) 2021, Hewlett Packard Enterprise Development LP.

 #

 #  This program and the accompanying materials

 #  are licensed and made available under the terms and conditions of the BSD 
License

@@ -23,8 +24,6 @@
 #--*/

 #start of the code section

 .text

-/* FIXME: Should alignment be different on Aarch64? */

-.align 3



 .global JumpToTestFunc

 .type JumpToTestFunc, %function

@@ -37,8 +36,8 @@
 #   )

 #

 JumpToTestFunc:

-   mov x2, x0

-   mov x0, x1

+   mv x2, x0

+   mv x0, x1



// Jump to Virtual function

-   blr x2

+   jalr x2

diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c 
b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
index 397b3514..00b59594 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
+++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
@@ -2,6 +2,7 @@


   Copyright 2006 - 2012 Unified EFI, Inc.

   Copyright (c) 2012, ARM Ltd. All rights reserved.

+  Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All rights 
reserved.



   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD 
License

@@ -22,9 +23,6 @@ Module Name:


 #include "SCRTApp.h"



-#define VIRT_TO_PHYS_OFFSET   (0x8000) //2G

-

-BOOLEAN HighAddress = FALSE;

 UINTN   PageTable   = 0;





@@ -49,11 +47,10 @@ Returns:


 --*/

 {

-   /*Note: It is presumed that on ARM v5, V6 and V7 architectures

-* the MMU is configured and enabled in PEI phase. As VirtualFunc

-* is already mapped to virtual memory, don't have to do anything here.

+  /* Note: It is presumed that on RISCV architectures the MMU is configured and

+   * enabled in PEI phase. As VirtualFunc is

Re: [edk2-devel] [edk2-test PATCHv3 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources

2021-03-30 Thread Sunny Wang

Looks good to me. This only affects RISCV. Therefore, as long as you build and 
run SCT on the RISCV platform, this change should be fine.
Reviewed-by: Sunny Wang 

Best Regards,
Sunny Wang

-Original Message-
From: Schaefer, Daniel 
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao 
; Samer El-Haj-Mahmoud ; 
Eric Jin ; Arvin Chen ; Leif 
Lindholm ; Heinrich Schuchardt ; Chang, 
Abner (HPS SW/FW Technologist) 
Subject: [edk2-test PATCHv3 1/5] SctPkg: Add RISCV64 support by using Aarch64 
sources

The sources were copied from Aarch64. Follow-up commit will adapt them for 
Riscv64.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
 uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
|  32 +++
 uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c  
|  45 
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S   
|  44 
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c   
| 182 +
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
|  88 +++
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c 
|  68 +
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c   
| 134 ++
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h   
|  48 
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestCacheFunction.c
 | 137 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c
 | 276 
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/PlatformIsa.c
 |  30 +++
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat.h
 |  55 
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c 
   |  55 
 13 files changed, 1194 insertions(+)

diff --git a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h 
b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
new file mode 100644
index ..ee7c656b
--- /dev/null
+++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
@@ -0,0 +1,32 @@
+/** @file

+

+  Copyright 2006 - 2012 Unified EFI, Inc.

+  Copyright (c) 2011 - 2012, ARM Ltd. All rights reserved.

+

+  This program and the accompanying materials

+  are licensed and made available under the terms and conditions of the
+ BSD License

+  which accompanies this distribution.  The full text of the license
+ may be found at

+  http://opensource.org/licenses/bsd-license.php

+

+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

+

+**/

+/*++

+

+Module Name:

+

+  SctLibPlat.h

+

+Abstract:

+

+  AArch64 specific defines

+

+--*/

+

+#ifndef _EFI_LIB_PLAT_H_

+#define _EFI_LIB_PLAT_H_

+

+#define MIN_ALIGNMENT_SIZE  8

+

+#endif

diff --git a/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c 
b/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
new file mode 100644
index ..a48bb2f3
--- /dev/null
+++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
@@ -0,0 +1,45 @@
+/** @file

+

+  Copyright 2006 - 2012 Unified EFI, Inc.

+  Copyright (c) 2011 - 2012, ARM Ltd. All rights reserved.

+

+  This program and the accompanying materials

+  are licensed and made available under the terms and conditions of the
+ BSD License

+  which accompanies this distribution.  The full text of the license
+ may be found at

+  http://opensource.org/licenses/bsd-license.php

+

+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

+

+**/

+/*++

+

+Module Name:

+

+  initplat.c

+

+Abstract:

+

+  Math routines for compatibility with native EFI library routines.

+

+--*/

+

+#include "SctLibInternal.h"

+

+VOID

+InitializeLibPlatform (

+IN EFI_HANDLE   ImageHandle,

+IN EFI_SYSTEM_TABLE *SystemTable

+)

+

+{

+  // No platform-specific initializations

+}

+

+UINT64

+SctReadTsc (

+  VOID

+  )

+{

+

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

2021-03-25 Thread Gao Jie

Reviewed-by: Barton Gao >


On 2021/3/22 14:12, Eric Jin wrote:

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3272

The goal of the Support Routine: CheckForSupportGetImage is to detect the
current FMP instance's capability for supporting GetImage().

In current code, "ImageIndex = 0" is the input parameter, but it is
inconsistent with spec -"A unique number identifying the firmware image(s)
within the device. The number is between 1 and DescriptorCount."

It is a bug and need the fix.
The similar errors exist in CheckForSupportSetImage/CheckForSupportCheckImage.

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Arvin Chen 
Signed-off-by: Eric Jin 
---
  .../BlackBoxTest/FirmwareManagementBBTestConformance.c | 7 ---
  .../BlackBoxTest/FirmwareManagementBBTestConformance.c | 7 ---
  2 files changed, 8 insertions(+), 6 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
index 257f2756dbcb..44d01d27a8f2 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
@@ -2,6 +2,7 @@
  
Copyright 2006 - 2016 Unified EFI, Inc.

Copyright (c) 2010 - 2016, Dell Inc. All rights reserved.
+  Copyright (c) 2021, Intel Corporation. All rights reserved.
  
This program and the accompanying materials

are licensed and made available under the terms and conditions of the BSD 
License
@@ -208,7 +209,7 @@ CheckForSupportGetImage (
TestGuid = gFirmwareManagementBBTestConformanceSupportGuid001;
ResultMessageLabel = L"GetImage, function support check";
  
-  ImageIndex = 0;

+  ImageIndex = 1;
Image = NULL;
ImageSize = 0;
  
@@ -283,7 +284,7 @@ CheckForSupportSetImage (

TestGuid = gFirmwareManagementBBTestConformanceSupportGuid002;
ResultMessageLabel = L"SetImage, function support check";
  
-  ImageIndex = 0;

+  ImageIndex = 1;
Image = NULL;
ImageSize = 0;
AbortReason = NULL;
@@ -362,7 +363,7 @@ CheckForSupportCheckImage (
TestGuid = gFirmwareManagementBBTestConformanceSupportGuid003;
ResultMessageLabel = L"CheckImage, function support check";
  
-  ImageIndex = 0;

+  ImageIndex = 1;
Image = NULL;
ImageSize = 0;
  
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c

index 797229adc8f6..65715f6c33e6 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
@@ -3,6 +3,7 @@
Copyright 2006 - 2016 Unified EFI, Inc.
Copyright (c) 2010 - 2016, Dell Inc. All rights reserved.
Copyright (c) 2019,Microchip Technology Inc.
+  Copyright (c) 2021, Intel Corporation. All rights reserved.
  
This program and the accompanying materials

are licensed and made available under the terms and conditions of the BSD 
License
@@ -209,7 +210,7 @@ CheckForSupportGetImage (
TestGuid = gFirmwareManagementBBTestConformanceSupportGuid001;
ResultMessageLabel = L"GetImage, function support check";
  
-  ImageIndex = 0;

+  ImageIndex = 1;
Image = NULL;
ImageSize = 0;
  
@@ -284,7 +285,7 @@ CheckForSupportSetImage (

TestGuid = gFirmwareManagementBBTestConformanceSupportGuid002;
ResultMessageLabel = L"SetImage, function support check";
  
-  ImageIndex = 0;

+  ImageIndex = 1;
Image = NULL;
ImageSize = 0;
AbortReason = NULL;
@@ -363,7 +364,7 @@ CheckForSupportCheckImage (
TestGuid = gFirmwareManagementBBTestConformanceSupportGuid003;
ResultMessageLabel = L"CheckImage, function support check";
  
-  ImageIndex = 0;

+  ImageIndex = 1;
Image = NULL;
ImageSize = 0;
  



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73307): https://edk2.groups.io/g/devel/message/73307
Mute This Topic: https://groups.io/mt/81518326/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

2021-03-22 Thread Eric Jin

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3272

The goal of the Support Routine: CheckForSupportGetImage is to detect the
current FMP instance's capability for supporting GetImage().

In current code, "ImageIndex = 0" is the input parameter, but it is
inconsistent with spec -"A unique number identifying the firmware image(s)
within the device. The number is between 1 and DescriptorCount."

It is a bug and need the fix.
The similar errors exist in CheckForSupportSetImage/CheckForSupportCheckImage.

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Arvin Chen 
Signed-off-by: Eric Jin 
---
 .../BlackBoxTest/FirmwareManagementBBTestConformance.c | 7 ---
 .../BlackBoxTest/FirmwareManagementBBTestConformance.c | 7 ---
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
index 257f2756dbcb..44d01d27a8f2 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
@@ -2,6 +2,7 @@
 
   Copyright 2006 - 2016 Unified EFI, Inc.
   Copyright (c) 2010 - 2016, Dell Inc. All rights reserved.
+  Copyright (c) 2021, Intel Corporation. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
@@ -208,7 +209,7 @@ CheckForSupportGetImage (
   TestGuid = gFirmwareManagementBBTestConformanceSupportGuid001;
   ResultMessageLabel = L"GetImage, function support check";
 
-  ImageIndex = 0;
+  ImageIndex = 1;
   Image = NULL;
   ImageSize = 0;
 
@@ -283,7 +284,7 @@ CheckForSupportSetImage (
   TestGuid = gFirmwareManagementBBTestConformanceSupportGuid002;
   ResultMessageLabel = L"SetImage, function support check";
 
-  ImageIndex = 0;
+  ImageIndex = 1;
   Image = NULL;
   ImageSize = 0;
   AbortReason = NULL;
@@ -362,7 +363,7 @@ CheckForSupportCheckImage (
   TestGuid = gFirmwareManagementBBTestConformanceSupportGuid003;
   ResultMessageLabel = L"CheckImage, function support check";
 
-  ImageIndex = 0;
+  ImageIndex = 1;
   Image = NULL;
   ImageSize = 0;
 
diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
index 797229adc8f6..65715f6c33e6 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
@@ -3,6 +3,7 @@
   Copyright 2006 - 2016 Unified EFI, Inc.
   Copyright (c) 2010 - 2016, Dell Inc. All rights reserved.
   Copyright (c) 2019,Microchip Technology Inc.
+  Copyright (c) 2021, Intel Corporation. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
@@ -209,7 +210,7 @@ CheckForSupportGetImage (
   TestGuid = gFirmwareManagementBBTestConformanceSupportGuid001;
   ResultMessageLabel = L"GetImage, function support check";
 
-  ImageIndex = 0;
+  ImageIndex = 1;
   Image = NULL;
   ImageSize = 0;
 
@@ -284,7 +285,7 @@ CheckForSupportSetImage (
   TestGuid = gFirmwareManagementBBTestConformanceSupportGuid002;
   ResultMessageLabel = L"SetImage, function support check";
 
-  ImageIndex = 0;
+  ImageIndex = 1;
   Image = NULL;
   ImageSize = 0;
   AbortReason = NULL;
@@ -363,7 +364,7 @@ CheckForSupportCheckImage (
   TestGuid = gFirmwareManagementBBTestConformanceSupportGuid003;
   ResultMessageLabel = L"CheckImage, function support check";
 
-  ImageIndex = 0;
+  ImageIndex = 1;
   Image = NULL;
   ImageSize = 0;
 
-- 
2.20.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73067): https://edk2.groups.io/g/devel/message/73067
Mute This Topic: https://groups.io/mt/81518326/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64

2021-03-15 Thread Daniel Schaefer

Abner has reviewed and approved everything now.
Other people only reviewed v2 5/5.

Does anybody else have any comments?

From: devel@edk2.groups.io  on behalf of Daniel Schaefer 

Sent: Thursday, March 4, 2021 11:21
To: devel@edk2.groups.io 
Cc: G Edhaya Chandran ; Barton Gao 
; Samer El-Haj-Mahmoud ; 
Eric Jin ; Arvin Chen ; Leif 
Lindholm ; Heinrich Schuchardt ; Chang, 
Abner (HPS SW/FW Technologist) 
Subject: [edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64

Changes to previous series:

- Fixed the commit to remove whitespace to *only* remove whitespace. Had
  some mixup there...
- Added missing HPE copyright in one file

I was able to run SCT on my EDK2 port to RISCV64 and I don't see any
obvious failures related to this. Additionally Heinrich has tested the
first series on the U-Boot implementation of UEFI.

If you apply these patches or check out my branch [1] you can easily
review the changes with `git diff -w master`. It will hide anything
that's copied and any whitespace changes.

Cheers,
Daniel

[1] https://github.com/johnazoidberg/edk2-test/tree/riscv64

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 

Daniel Schaefer (5):
  SctPkg: Add RISCV64 support by using Aarch64 sources
  SctPkg: Adapt Aarch64 sources for Riscv64
  SctPkg: Add RISCV64 build support
  SctPkg: Unify CC_FLAGS for all GCC platforms
  SctPkg: Remove trailing whitespace

 uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h 
 |  4 ++
 uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
 |  4 +-
 uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c  
 |  6 +-
 uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/SctLibPlat.h   
 |  7 ++-
 uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/initplat.c 
 |  6 +-
 uefi-sct/SctPkg/Library/SctLib/SctLib.inf  
 |  6 ++
 uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S   
 |  6 +-
 uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c   
 |  6 +-
 uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/GoVirtual.S  
 | 15 +++--
 uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/VirtualMemory.c  
 | 22 +++
 uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf   
 |  5 ++
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c 
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c   
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h   
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Debug.c   
 | 28 -
 uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Dump.c
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Io.c  
 | 15 ++---
 uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf 
 |  6 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestCacheFunction.c
  |  6 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestExceptionCallbackFunction.c
  |  7 +--
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/PlatformIsa.c
  |  6 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTest.inf
 |  6 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest

Re: [edk2-devel] [edk2-test PATCHv3 5/5] SctPkg: Remove trailing whitespace

2021-03-03 Thread Abner Chang

Reviewed-by: Abner Chang 

> -Original Message-
> From: Schaefer, Daniel
> Sent: Thursday, March 4, 2021 11:21 AM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; Barton Gao
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>; Eric Jin ; Arvin Chen
> ; Leif Lindholm ; Heinrich
> Schuchardt ; Chang, Abner (HPS SW/FW Technologist)
> 
> Subject: [edk2-test PATCHv3 5/5] SctPkg: Remove trailing whitespace
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
> 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Samer El-Haj-Mahmoud 
> Cc: Eric Jin 
> Cc: Arvin Chen 
> Cc: Leif Lindholm 
> Cc: Heinrich Schuchardt 
> Cc: Abner Chang 
> Reviewed-by: Samer El-Haj-Mahmoud 
> Reviewed-by: G Edhaya Chandran 
> Signed-off-by: Daniel Schaefer 
> ---
>  uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> | 4 ++--
>  uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> | 6 +++---
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> | 4 ++--
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> | 6 +++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S
> | 6 +++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c
> | 6 +++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> | 6 +++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> | 6 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
> | 8 
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> | 8 
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c
> | 8 
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h
> | 8 
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> | 6 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> | 8 
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> | 8 
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
> 4/DebugSupportBBTestCacheFunction.c | 6 +++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
> 4/DebugSupportBBTestExceptionCallbackFunction.c | 7 +++
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
> 4/PlatformIsa.c | 6 +++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /DebugSupportBBTestCacheFunction.c | 6 +++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /DebugSupportBBTestExceptionCallbackFunction.c | 6 +++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /PlatformIsa.c | 6 +++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLib
> Plat.h | 6 +++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat
> .c| 6 +++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLib
> Plat.h | 6 +++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.
> c| 6 +++---
>  25 files changed, 79 insertions(+), 80 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h b/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> index ee7c656b..b7832e18 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> +++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> @@ -5,12 +5,12 @@
> 
> 
>This program and the accompanying materials
> 
>are licensed and made available under the terms and conditions of the BSD
> License
> 
> -  which accompanies this distribution.  The full text of the license may be
> found at
> 
> +  which accompanies this distribution.  The full text of the license may be
> found at
> 
>http://opensource.org/licenses/bsd-license.php
> 
> 
> 
>THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> 
>WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> 
> -
> 
> +
> 
>  **/
> 
>  /*++
> 
> 
> 
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c b/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> index a48bb2f3..1c247c91 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> +++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> @@ -5,12 +5,12 @@
> 
> 
>This program and the accompanying materials
> 
>are licensed and made available under the terms and conditions of the BSD
> License
> 
> -  which accompanies this distribution.  The full text of the license may be
> found at
> 
> +  which accompanies this distribution.  The full text of the license may be
> found at
> 
>http://opensource.org/licenses/bsd-license.php
> 
> -
> 
> +
> 
>THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> 
>WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> 
> -
>

Re: [edk2-devel] [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-03-03 Thread Abner Chang

Reviewed-by: Abner Chang 

> -Original Message-
> From: Schaefer, Daniel
> Sent: Thursday, March 4, 2021 11:21 AM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; Barton Gao
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>; Eric Jin ; Arvin Chen
> ; Leif Lindholm ; Heinrich
> Schuchardt ; Chang, Abner (HPS SW/FW Technologist)
> 
> Subject: [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all GCC
> platforms
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
> 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Samer El-Haj-Mahmoud 
> Cc: Eric Jin 
> Cc: Arvin Chen 
> Cc: Leif Lindholm 
> Cc: Heinrich Schuchardt 
> Cc: Abner Chang 
> Signed-off-by: Daniel Schaefer 
> ---
>  uefi-sct/SctPkg/UEFI/IHV_SCT.dsc  | 15 ---  uefi-
> sct/SctPkg/UEFI/UEFI_SCT.dsc | 15 ---
>  2 files changed, 16 insertions(+), 14 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-
> sct/SctPkg/UEFI/IHV_SCT.dsc
> index 94bb5c36..91116ca7 100644
> --- a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
> +++ b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
> @@ -69,15 +69,16 @@
>MSFT:*_*_X64_APP_FLAGS   = /D EFIX64
>MSFT:*_*_X64_PP_FLAGS= /D EFIX64
>  -#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -
> ffreestanding -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -
> mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -
> D MDE_CPU_X32
> -   GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error
> +   GCC:*_*_*_CC_FLAGS= -ffreestanding -nostdinc -nostdlib -Wno-
> error+#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -mno-
> red-zone -Wno-address -mno-stack-arg-probe "-
> DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -D MDE_CPU_X32+
> GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) #
> GCC:*_*_IA32_VFRPP_FLAGS  = -D EFI32 $(GCC_VER_MACRO) #
> GCC:*_*_IA32_APP_FLAGS= -D EFI32 $(GCC_VER_MACRO) #
> GCC:*_*_IA32_PP_FLAGS = -D EFI32 $(GCC_VER_MACRO) -#
> GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -ffreestanding
> -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-
> arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -
> mabi=ms -D MDE_CPU_X64
> +#  GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -mno-red-
> zone -Wno-address -mno-stack-arg-probe "-
> DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -mabi=ms -D
> MDE_CPU_X64 -   GCC:*_*_X64_CC_FLAGS = -D EFIX64
> $(GCC_VER_MACRO) -Wno-error +   GCC:*_*_X64_CC_FLAGS = -D EFIX64
> $(GCC_VER_MACRO) #  GCC:*_*_X64_VFRPP_FLAGS  = -D EFIX64
> $(GCC_VER_MACRO) #  GCC:*_*_X64_APP_FLAGS= -D EFIX64
> $(GCC_VER_MACRO) #  GCC:*_*_X64_PP_FLAGS = -D EFIX64
> $(GCC_VER_MACRO)@@ -85,7 +86,7 @@
> #TODO: OM - fixme RVCT:*_*_ARM_CC_FLAGS = -D EFIARM
> $(GCC_VER_MACRO)   *_*_ARM_CC_FLAGS = -D EFIARM-
> GCC:*_*_ARM_CC_FLAGS  = -D EFIARM $(GCC_VER_MACRO) -fno-stack-
> protector -ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -
> Wno-error=unused-but-set-variable -Wno-error=implicit-function-
> declaration -Wno-error+  GCC:*_*_ARM_CC_FLAGS  = -D EFIARM
> $(GCC_VER_MACRO) -fno-stack-protector   *_*_ARM_VFRPP_FLAGS   = -D
> EFIARM $(GCC_VER_MACRO)   *_*_ARM_APP_FLAGS = -D EFIARM
> $(GCC_VER_MACRO)   *_*_ARM_PP_FLAGS  = -D EFIARM
> $(GCC_VER_MACRO)@@ -104,14 +105,14 @@
>RVCT:*_*_ARM_CC_FLAGS= --diag_remark=167 --
> diag_suppress=167,1295,188,550,1,68,111,177*_*_AARCH64_CC_FLAGS
> = -D EFIAARCH64 $(GCC_VER_MACRO)-  GCC:*_*_AARCH64_CC_FLAGS = -
> D EFIAARCH64 $(GCC_VER_MACRO) -ffreestanding -nostdinc -nostdlib -
> Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-
> error+  GCC:*_*_AARCH64_CC_FLAGS = -D EFIAARCH64
> $(GCC_VER_MACRO)   *_*_AARCH64_VFRPP_FLAGS  = -D EFIAARCH64
> $(GCC_VER_MACRO)   *_*_AARCH64_APP_FLAGS= -D EFIAARCH64
> $(GCC_VER_MACRO)   *_*_AARCH64_PP_FLAGS = -D EFIAARCH64
> $(GCC_VER_MACRO)   RVCT:*_*_AARCH64_DLINK_FLAGS = --muldefweak
> *_*_RISCV64_CC_FLAGS = -D EFIRISCV64 $(GCC_VER_MACRO)-
> GCC:*_*_RISCV64_CC_FLAGS  = -D EFIRISCV64 $(GCC_VER_MACRO) -
> ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -Wno-
> error=unused-but-set-variable -Wno-error+  GCC:*_*_RISCV64_CC_FLAGS
> = -D EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_VFRPP_FLAGS  = -D
> EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_APP_FLAGS= -D
> EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_PP_FLAGS = -D
> EFIRISCV64 $(GCC_VER_MACRO)diff --git a/uefi-
> sct/SctPkg/UEFI/UEFI_SCT.dsc b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
> index e13e40e4..3bb57d26 100644
> --- a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
> +++ b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
> @@ -72,14 +72,15 @@
>MSFT:*_*_X64_APP_FLAGS   = /D EFIX64
>MSFT:*_*_X64_PP_FLAGS= /D EFIX64
>  -#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -
> ffreestanding -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -
> mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms

Re: [edk2-devel] [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

2021-03-03 Thread Abner Chang

Reviewed-by: Abner Chang 

> -Original Message-
> From: Schaefer, Daniel
> Sent: Thursday, March 4, 2021 11:21 AM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; Barton Gao
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>; Eric Jin ; Arvin Chen
> ; Leif Lindholm ; Heinrich
> Schuchardt ; Chang, Abner (HPS SW/FW Technologist)
> 
> Subject: [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
> 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Samer El-Haj-Mahmoud 
> Cc: Eric Jin 
> Cc: Arvin Chen 
> Cc: Leif Lindholm 
> Cc: Heinrich Schuchardt 
> Cc: Abner Chang 
> Signed-off-by: Daniel Schaefer 
> ---
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> |  3 +-
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> |  9 ++--
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> | 16 +++
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> | 22 +++--
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> |  7 +--
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h
> | 48 
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /DebugSupportBBTestExceptionCallbackFunction.c | 12 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /PlatformIsa.c |  4 +-
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLib
> Plat.h |  3 +-
>  9 files changed, 32 insertions(+), 92 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h b/uefi-
> sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> index ee7c656b..69e7f904 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> +++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> @@ -2,6 +2,7 @@
> Copyright 2006 - 2012 Unified EFI, Inc.   Copyright (c) 2011 - 2012, 
> ARM
> Ltd. All rights reserved.+  Copyright (c) 2021, Hewlett Packard Enterprise
> Development LP. All rights reserved.This program and the
> accompanying materials   are licensed and made available under the terms
> and conditions of the BSD License@@ -20,7 +21,7 @@ Module Name:
>   Abstract: -  AArch64 specific defines+  RISCV64 specific defines  --*/ diff 
> --git
> a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S b/uefi-
> sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> index d223b36b..ae33da18 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> @@ -2,6 +2,7 @@
>  # #  Copyright 2010 - 2012 Unified EFI, Inc. #  Copyright (c) 2012, ARM
> Ltd. All rights reserved.+#  Copyright (c) 2021, Hewlett Packard
> Enterprise Development LP. # #  This program and the accompanying
> materials #  are licensed and made available under the terms and conditions
> of the BSD License@@ -23,8 +24,6 @@  #--*/ #start of the code section .text-
> /* FIXME: Should alignment be different on Aarch64? */-.align 3  .global
> JumpToTestFunc .type JumpToTestFunc, %function@@ -37,8 +36,8 @@
>  #   ) # JumpToTestFunc:- mov x2, x0- mov x0, x1+ mv x2, x0+
>   mv x0, x1   // Jump to Virtual function-blr x2+ jalr x2diff 
> --git
> a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c b/uefi-
> sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> index 397b3514..00b59594 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> @@ -2,6 +2,7 @@
> Copyright 2006 - 2012 Unified EFI, Inc.   Copyright (c) 2012, ARM 
> Ltd. All
> rights reserved.+  Copyright (c) 2021, Hewlett Packard Enterprise
> Development LP. All rights reserved.This program and the
> accompanying materials   are licensed and made available under the terms
> and conditions of the BSD License@@ -22,9 +23,6 @@ Module Name:
>   #include "SCRTApp.h" -#define VIRT_TO_PHYS_OFFSET   (0x8000)
> //2G--BOOLEAN HighAddress = FALSE; UINTN   PageTable   = 0;  @@ -
> 49,11 +47,10 @@ Returns:
>   --*/ {- /*Note: It is presumed that on ARM v5, V6 and V7 architectures-
>* the MMU is configured and enabled in PEI phase. As VirtualFunc-
>* is already mapped to virtual memory, don't have to do anything
> here.+  /* Note: It is presumed that on RISCV architectures the MMU is
> configured and+   * enabled in PEI phase. As VirtualFunc is already mapped to
> virtual memory,+   * don't have to do anything here.   */-  /* FIXME: Is it
> the same on ARM v8? */ }  @@ -174,9 +171,8 @@ Returns:
>  --*/ {   //-  // Note: It is assumed that the MMU and page tables are
> configured on ARM platforms-  // based on ARM v5 v6 and v7 architecture.+
> // Note: It is assumed that the MMU and page tables are configured on RISC-
> V+  // platforms.   //-  /* FIXME: Is it the same on ARM v8? */
>   JumpToTestFunc(VirtualFunc, HandOffAddr); }diff --git a/uefi-
>

[edk2-devel] [edk2-test PATCHv3 3/5] SctPkg: Add RISCV64 build support

2021-03-03 Thread Daniel Schaefer

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
 uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h 
 |  4 ++
 uefi-sct/SctPkg/Library/SctLib/SctLib.inf  
 |  6 ++
 uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf   
 |  5 ++
 uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf 
 |  6 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTest.inf
 |  6 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/Usb2Hc/BlackBoxTest/Usb2HcTest.inf  
 |  4 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/UsbHcTest.inf
 |  4 ++
 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf   
 |  5 ++
 uefi-sct/SctPkg/Tools/Source/GenBin/GNUmakefile
 |  4 ++
 uefi-sct/SctPkg/UEFI/IHV_SCT.dsc   
 | 17 +-
 uefi-sct/SctPkg/UEFI/Protocol/DebugSupport.h   
 | 61 +++-
 uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc  
 | 18 +-
 uefi-sct/SctPkg/build.sh   
 | 11 +++-
 13 files changed, 144 insertions(+), 7 deletions(-)

diff --git a/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h 
b/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h
index a7815580..02f0283e 100644
--- a/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h
+++ b/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h
@@ -3,6 +3,7 @@
   Copyright 2006 - 2017 Unified EFI, Inc.

   Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.

   Portions copyright (c) 2014, ARM Ltd. All rights reserved.

+  (C) Copyright 2021 Hewlett Packard Enterprise Development LP

 

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD 
License

@@ -32,6 +33,9 @@
 #elif defined(EFIAARCH64)

   #define INSTALL_SCT_PLATFORM_SHORT_NAME   L"aarch64"

   #define INSTALL_SCT_PLATFORM_NAME L"AARCH64"

+#elif defined(EFIRISCV64)

+  #define INSTALL_SCT_PLATFORM_SHORT_NAME   L"riscv64"

+  #define INSTALL_SCT_PLATFORM_NAME L"RISCV64"

 #else

   #error "Architecture not supported"

 #endif

diff --git a/uefi-sct/SctPkg/Library/SctLib/SctLib.inf 
b/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
index 23cb77fb..7527b203 100644
--- a/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
+++ b/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
@@ -3,6 +3,7 @@
 #  Copyright 2006 - 2016 Unified EFI, Inc.

 #  Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.

 #  Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.

+#  (C) Copyright 2021 Hewlett Packard Enterprise Development LP

 #

 #  This program and the accompanying materials

 #  are licensed and made available under the terms and conditions of the BSD 
License

@@ -62,6 +63,11 @@
   Aarch64/initplat.c

   Math.c

 

+[sources.RISCV64]

+  Riscv64/SctLibPlat.h

+  Riscv64/initplat.c

+  Math.c

+

 [sources.ia32]

   ia32/SctLibPlat.h

   ia32/initplat.c

diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf 
b/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf
index 7aca6e30..8104a4ef 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf
+++ b/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf
@@ -2,6 +2,7 @@
 #

 #  Copyright 2006 - 2016 Unified EFI, Inc.

 #  Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.

+#  (C) Copyright 2021 Hewlett Packard Enterprise Development LP

 #

 #  This program and the accompanying materials

 #  are licensed and made available under the terms and conditions of the BSD 
License

@@ -39,6 +40,10 @@
   Aarch64/GoVirtual.asm | RVCT

   Aarch64/GoVirtual.S | GCC

 

+[sources.RISCV64]

+  Riscv64/VirtualMemory.c

+  Riscv64/GoVirtual.S | GCC

+

 [sources.ia32]

   ia32/VirtualMemory.c

   ia32/GoVirtual.asm | MSFT

diff --git a/uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf 
b/uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf
index ad0eb0f8..a3ef454e 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf
+++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf
@@ -2,6 +2,7 @@
 #

 #  Copyright 2006 - 2016 Unified EFI, Inc.

 #  Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.

+#  (C) Copyright 2021 Hewlett Packard Enterprise Development LP

 #

 #  This program and the accompanying materials

 #  are licensed and made available under the terms and conditions of the BSD 
License

@@ -69,6 +70,11 @@
   Aarch64/Dump.c

   Aarch64/Debug.c

 

+[sources.RISCV64]

[edk2-devel] [edk2-test PATCHv3 5/5] SctPkg: Remove trailing whitespace

2021-03-03 Thread Daniel Schaefer

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Reviewed-by: Samer El-Haj-Mahmoud 
Reviewed-by: G Edhaya Chandran 
Signed-off-by: Daniel Schaefer 
---
 uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
| 4 ++--
 uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c  
| 6 +++---
 uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
| 4 ++--
 uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c  
| 6 +++---
 uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S   
| 6 +++---
 uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c   
| 6 +++---
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S   
| 6 +++---
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c   
| 6 +++---
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
| 8 
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c 
| 8 
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c   
| 8 
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h   
| 8 
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
| 6 +++---
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c 
| 8 
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c   
| 8 
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestCacheFunction.c
 | 6 +++---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestExceptionCallbackFunction.c
 | 7 +++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/PlatformIsa.c
 | 6 +++---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestCacheFunction.c
 | 6 +++---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c
 | 6 +++---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/PlatformIsa.c
 | 6 +++---
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLibPlat.h
 | 6 +++---
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat.c 
   | 6 +++---
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat.h
 | 6 +++---
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c 
   | 6 +++---
 25 files changed, 79 insertions(+), 80 deletions(-)

diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h 
b/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
index ee7c656b..b7832e18 100644
--- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
+++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
@@ -5,12 +5,12 @@
 

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD 
License

-  which accompanies this distribution.  The full text of the license may be 
found at 

+  which accompanies this distribution.  The full text of the license may be 
found at

   http://opensource.org/licenses/bsd-license.php

  

   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

- 

+

 **/

 /*++

 

diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c 
b/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
index a48bb2f3..1c247c91 100644
--- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
+++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
@@ -5,12 +5,12 @@
 

   This program and the accompanying materials

   are licensed and made available under the

[edk2-devel] [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-03-03 Thread Daniel Schaefer

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
 uefi-sct/SctPkg/UEFI/IHV_SCT.dsc  | 15 ---
 uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc | 15 ---
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
index 94bb5c36..91116ca7 100644
--- a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
+++ b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
@@ -69,15 +69,16 @@
   MSFT:*_*_X64_APP_FLAGS   = /D EFIX64
   MSFT:*_*_X64_PP_FLAGS= /D EFIX64
 

-#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -ffreestanding 
-nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-arg-probe 
"-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -D MDE_CPU_X32
-   GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error 

+   GCC:*_*_*_CC_FLAGS= -ffreestanding -nostdinc -nostdlib -Wno-error

+#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -mno-red-zone 
-Wno-address -mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m32 
-mabi=ms -D MDE_CPU_X32

+   GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO)

 #  GCC:*_*_IA32_VFRPP_FLAGS  = -D EFI32 $(GCC_VER_MACRO)

 #  GCC:*_*_IA32_APP_FLAGS= -D EFI32 $(GCC_VER_MACRO)

 #  GCC:*_*_IA32_PP_FLAGS = -D EFI32 $(GCC_VER_MACRO)

 

-#  GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -ffreestanding 
-nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-arg-probe 
"-DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -mabi=ms -D MDE_CPU_X64
+#  GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -mno-red-zone 
-Wno-address -mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m64 
-mcmodel=large -mabi=ms -D MDE_CPU_X64

 

-   GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error 

+   GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO)

 #  GCC:*_*_X64_VFRPP_FLAGS  = -D EFIX64 $(GCC_VER_MACRO)

 #  GCC:*_*_X64_APP_FLAGS= -D EFIX64 $(GCC_VER_MACRO)

 #  GCC:*_*_X64_PP_FLAGS = -D EFIX64 $(GCC_VER_MACRO)

@@ -85,7 +86,7 @@
 

   #TODO: OM - fixme RVCT:*_*_ARM_CC_FLAGS = -D EFIARM $(GCC_VER_MACRO)

   *_*_ARM_CC_FLAGS = -D EFIARM

-  GCC:*_*_ARM_CC_FLAGS  = -D EFIARM $(GCC_VER_MACRO) -fno-stack-protector 
-ffreestanding -nostdinc -nostdlib -Wno-error=unused-function 
-Wno-error=unused-but-set-variable -Wno-error=implicit-function-declaration 
-Wno-error

+  GCC:*_*_ARM_CC_FLAGS  = -D EFIARM $(GCC_VER_MACRO) -fno-stack-protector

   *_*_ARM_VFRPP_FLAGS   = -D EFIARM $(GCC_VER_MACRO)

   *_*_ARM_APP_FLAGS = -D EFIARM $(GCC_VER_MACRO)

   *_*_ARM_PP_FLAGS  = -D EFIARM $(GCC_VER_MACRO)

@@ -104,14 +105,14 @@
   RVCT:*_*_ARM_CC_FLAGS= --diag_remark=167 
--diag_suppress=167,1295,188,550,1,68,111,177

 

   *_*_AARCH64_CC_FLAGS = -D EFIAARCH64 $(GCC_VER_MACRO)

-  GCC:*_*_AARCH64_CC_FLAGS = -D EFIAARCH64 $(GCC_VER_MACRO) -ffreestanding 
-nostdinc -nostdlib -Wno-error=unused-function 
-Wno-error=unused-but-set-variable -Wno-error

+  GCC:*_*_AARCH64_CC_FLAGS = -D EFIAARCH64 $(GCC_VER_MACRO)

   *_*_AARCH64_VFRPP_FLAGS  = -D EFIAARCH64 $(GCC_VER_MACRO)

   *_*_AARCH64_APP_FLAGS= -D EFIAARCH64 $(GCC_VER_MACRO)

   *_*_AARCH64_PP_FLAGS = -D EFIAARCH64 $(GCC_VER_MACRO)

   RVCT:*_*_AARCH64_DLINK_FLAGS = --muldefweak

 

   *_*_RISCV64_CC_FLAGS = -D EFIRISCV64 $(GCC_VER_MACRO)

-  GCC:*_*_RISCV64_CC_FLAGS  = -D EFIRISCV64 $(GCC_VER_MACRO) -ffreestanding 
-nostdinc -nostdlib -Wno-error=unused-function 
-Wno-error=unused-but-set-variable -Wno-error

+  GCC:*_*_RISCV64_CC_FLAGS = -D EFIRISCV64 $(GCC_VER_MACRO)

   *_*_RISCV64_VFRPP_FLAGS  = -D EFIRISCV64 $(GCC_VER_MACRO)

   *_*_RISCV64_APP_FLAGS= -D EFIRISCV64 $(GCC_VER_MACRO)

   *_*_RISCV64_PP_FLAGS = -D EFIRISCV64 $(GCC_VER_MACRO)

diff --git a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc 
b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
index e13e40e4..3bb57d26 100644
--- a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
+++ b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
@@ -72,14 +72,15 @@
   MSFT:*_*_X64_APP_FLAGS   = /D EFIX64
   MSFT:*_*_X64_PP_FLAGS= /D EFIX64
 

-#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -ffreestanding 
-nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-arg-probe 
"-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -D MDE_CPU_X32
-  GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error 

+   GCC:*_*_*_CC_FLAGS= -ffreestanding -nostdinc -nostdlib -Wno-error

+#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -mno-red-zone 
-Wno-address -mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m32 
-mabi=ms -D MDE_CPU_X32
+  GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO)

 #  GCC:*_*_IA32_VFRPP_FLAGS  = -D EFI32 $(GCC_VER_MACRO)

 #  GCC:*_*_IA32_APP_FLAGS= -D EFI32

[edk2-devel] [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

2021-03-03 Thread Daniel Schaefer

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
 uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
|  3 +-
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S   
|  9 ++--
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c   
| 16 +++
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
| 22 +++--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c   
|  7 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h   
| 48 
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c
 | 12 ++---
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/PlatformIsa.c
 |  4 +-
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat.h
 |  3 +-
 9 files changed, 32 insertions(+), 92 deletions(-)

diff --git a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h 
b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
index ee7c656b..69e7f904 100644
--- a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
+++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
@@ -2,6 +2,7 @@
 

   Copyright 2006 - 2012 Unified EFI, Inc.

   Copyright (c) 2011 - 2012, ARM Ltd. All rights reserved.

+  Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All rights 
reserved.

 

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD 
License

@@ -20,7 +21,7 @@ Module Name:
 

 Abstract:

 

-  AArch64 specific defines

+  RISCV64 specific defines

 

 --*/

 

diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S 
b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
index d223b36b..ae33da18 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
+++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
@@ -2,6 +2,7 @@
 #

 #  Copyright 2010 - 2012 Unified EFI, Inc.

 #  Copyright (c) 2012, ARM Ltd. All rights reserved.

+#  Copyright (c) 2021, Hewlett Packard Enterprise Development LP.

 #

 #  This program and the accompanying materials

 #  are licensed and made available under the terms and conditions of the BSD 
License

@@ -23,8 +24,6 @@
 #--*/

 #start of the code section

 .text

-/* FIXME: Should alignment be different on Aarch64? */

-.align 3

 

 .global JumpToTestFunc

 .type JumpToTestFunc, %function

@@ -37,8 +36,8 @@
 #   )

 #

 JumpToTestFunc:

-   mov x2, x0

-   mov x0, x1

+   mv x2, x0

+   mv x0, x1

 

// Jump to Virtual function

-   blr x2

+   jalr x2

diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c 
b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
index 397b3514..00b59594 100644
--- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
+++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
@@ -2,6 +2,7 @@
 

   Copyright 2006 - 2012 Unified EFI, Inc.

   Copyright (c) 2012, ARM Ltd. All rights reserved.

+  Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All rights 
reserved.

 

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD 
License

@@ -22,9 +23,6 @@ Module Name:
 

 #include "SCRTApp.h"

 

-#define VIRT_TO_PHYS_OFFSET   (0x8000) //2G

-

-BOOLEAN HighAddress = FALSE;

 UINTN   PageTable   = 0;

 

 

@@ -49,11 +47,10 @@ Returns:
 

 --*/

 {

-   /*Note: It is presumed that on ARM v5, V6 and V7 architectures

-* the MMU is configured and enabled in PEI phase. As VirtualFunc

-* is already mapped to virtual memory, don't have to do anything here.

+  /* Note: It is presumed that on RISCV architectures the MMU is configured and

+   * enabled in PEI phase. As VirtualFunc is already mapped to virtual memory,

+   * don't have to do anything here.

 */

-  /* FIXME: Is it the same on ARM v8? */

 }

 

 

@@ -174,9 +171,8 @@ Returns:
 --*/

 {

   //

-  // Note: It is assumed that the MMU and page tables are configured on ARM 
platforms

-  // based on ARM v5 v6 and v7 architecture.

+  // Note: It is assumed that the MMU and page tables are configured on RISC-V

+  // platforms.

   //

-  /* FIXME: Is it the same on ARM v8? */

JumpToTestFunc(VirtualFunc, HandOffAddr);

 }

diff

[edk2-devel] [edk2-test PATCHv3 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources

2021-03-03 Thread Daniel Schaefer

The sources were copied from Aarch64. Follow-up commit will adapt them
for Riscv64.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
 uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
|  32 +++
 uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c  
|  45 
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S   
|  44 
 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c   
| 182 +
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
|  88 +++
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c 
|  68 +
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c   
| 134 ++
 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h   
|  48 
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestCacheFunction.c
 | 137 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c
 | 276 
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/PlatformIsa.c
 |  30 +++
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat.h
 |  55 
 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c 
   |  55 
 13 files changed, 1194 insertions(+)

diff --git a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h 
b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
new file mode 100644
index ..ee7c656b
--- /dev/null
+++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
@@ -0,0 +1,32 @@
+/** @file

+

+  Copyright 2006 - 2012 Unified EFI, Inc.

+  Copyright (c) 2011 - 2012, ARM Ltd. All rights reserved.

+

+  This program and the accompanying materials

+  are licensed and made available under the terms and conditions of the BSD 
License

+  which accompanies this distribution.  The full text of the license may be 
found at 

+  http://opensource.org/licenses/bsd-license.php

+ 

+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

+ 

+**/

+/*++

+

+Module Name:

+

+  SctLibPlat.h

+

+Abstract:

+

+  AArch64 specific defines

+

+--*/

+

+#ifndef _EFI_LIB_PLAT_H_

+#define _EFI_LIB_PLAT_H_

+

+#define MIN_ALIGNMENT_SIZE  8

+

+#endif

diff --git a/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c 
b/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
new file mode 100644
index ..a48bb2f3
--- /dev/null
+++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
@@ -0,0 +1,45 @@
+/** @file

+

+  Copyright 2006 - 2012 Unified EFI, Inc.

+  Copyright (c) 2011 - 2012, ARM Ltd. All rights reserved.

+

+  This program and the accompanying materials

+  are licensed and made available under the terms and conditions of the BSD 
License

+  which accompanies this distribution.  The full text of the license may be 
found at 

+  http://opensource.org/licenses/bsd-license.php

+ 

+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

+ 

+**/

+/*++

+

+Module Name:

+

+  initplat.c

+

+Abstract:

+

+  Math routines for compatibility with native EFI library routines.

+

+--*/

+

+#include "SctLibInternal.h"

+

+VOID

+InitializeLibPlatform (

+IN EFI_HANDLE   ImageHandle,

+IN EFI_SYSTEM_TABLE *SystemTable

+)

+

+{

+  // No platform-specific initializations

+}

+

+UINT64

+SctReadTsc (

+  VOID

+  )

+{

+  return 0;

+}

diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S 
b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
new file mode 100644
index ..d223b36b
--- /dev/null
+++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
@@ -0,0 +1,44 @@
+## @file

+#

+#  Copyright 2010 - 2012 Unified EFI, Inc.

+#  Copyright (c) 2012, ARM Ltd. All rights reserved.

+#

+#  This program and the accompanying materials

+#  are licensed and made available under the terms and conditions of the BSD 
License

+#  which accompanies this distribution.

[edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64

2021-03-03 Thread Daniel Schaefer

Changes to previous series:

- Fixed the commit to remove whitespace to *only* remove whitespace. Had
  some mixup there...
- Added missing HPE copyright in one file

I was able to run SCT on my EDK2 port to RISCV64 and I don't see any
obvious failures related to this. Additionally Heinrich has tested the
first series on the U-Boot implementation of UEFI.

If you apply these patches or check out my branch [1] you can easily
review the changes with `git diff -w master`. It will hide anything
that's copied and any whitespace changes.

Cheers,
Daniel

[1] https://github.com/johnazoidberg/edk2-test/tree/riscv64

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 

Daniel Schaefer (5):
  SctPkg: Add RISCV64 support by using Aarch64 sources
  SctPkg: Adapt Aarch64 sources for Riscv64
  SctPkg: Add RISCV64 build support
  SctPkg: Unify CC_FLAGS for all GCC platforms
  SctPkg: Remove trailing whitespace

 uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h 
 |  4 ++
 uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
 |  4 +-
 uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c  
 |  6 +-
 uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/SctLibPlat.h   
 |  7 ++-
 uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/initplat.c 
 |  6 +-
 uefi-sct/SctPkg/Library/SctLib/SctLib.inf  
 |  6 ++
 uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S   
 |  6 +-
 uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c   
 |  6 +-
 uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/GoVirtual.S  
 | 15 +++--
 uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/VirtualMemory.c  
 | 22 +++
 uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf   
 |  5 ++
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c 
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c   
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h   
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Debug.c   
 | 28 -
 uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Dump.c
 |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Io.c  
 | 15 ++---
 uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf 
 |  6 ++
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestCacheFunction.c
  |  6 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestExceptionCallbackFunction.c
  |  7 +--
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/PlatformIsa.c
  |  6 +-
 
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTest.inf
 |  6 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 
=> Riscv64}/DebugSupportBBTestCacheFunction.c |  6 +-
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 
=> Riscv64}/DebugSupportBBTestExceptionCallbackFunction.c | 18 +++---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 
=> Riscv64}/PlatformIsa.c | 10 ++--
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/Usb2Hc/BlackBoxTest/Usb2HcTest.inf  
 |  4 ++

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

2021-03-03 Thread Daniel Schaefer


Whoops, you're right! Thanks for checking it. (I had copied the files from 
RiscV64 to Aarch64...)
git show -w on this commit clearly shows that there have been non-whitespace 
changes.
Will send a new series!

On 2/25/21 11:07 AM, Chang, Abner (HPS SW/FW Technologist) wrote:

Some non-whitespace changes in this patch, such as SctLibPlt.h, goVirtual.S and 
maybe others. I think you mixed up the changes by accident?


-Original Message-
From: G Edhaya Chandran [mailto:edhaya.chand...@arm.com]
Sent: Wednesday, February 24, 2021 5:02 PM
To: Schaefer, Daniel ; devel@edk2.groups.io
Cc: Barton Gao ; Samer El-Haj-Mahmoud
; Eric Jin ; Arvin
Chen ; Leif Lindholm ; Heinrich
Schuchardt ; Chang, Abner (HPS SW/FW Technologist)

Subject: RE: [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

Reviewed-by: G Edhaya Chandran


-Original Message-
From: Daniel Schaefer 
Sent: 09 February 2021 21:14
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao
; Samer El-Haj-Mahmoud ; Eric Jin ; Arvin Chen
; Leif Lindholm ; Heinrich
Schuchardt ; Abner Chang



Subject: [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

REF:INVALID URI REMOVED
ocore.org_show-5Fbug.cgi-3Fid-

3D3042=DwIFAg=C5b8zRQO1miGmBeVZ2LFWg



=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E=OvftgethAGVz
_9J6TfZzU

w8dFUYHnlN6sUiEDYhuXY8=O2aIe5GLoSMYAR-

eYh_EPm_WTgaHPatmncmzZlNnYWI

=

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
  uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
|  4 +--
  uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
|  6 ++---
  uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
|  7 +++--
  uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
|  6 ++---
  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S
| 15 ++-
  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c
| 22 +++
  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
|  6 ++---
  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
|  6 ++---
  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
| 28 +++-
  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
|  8 +++---
  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c
| 15 ++-
  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h
|  8 +++---
  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
|  6 ++---
  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
|  8 +++---
  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
|  8 +++---
  uefi-


sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
4/D

ebugSupportBBTestCacheFunction.c |  6 ++---
  uefi-


sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6

4/D ebugSupportBBTestExceptionCallbackFunction.c | 18 ++---
  uefi-


sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
4/Pl

atformIsa.c | 10 +++
  uefi-


sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
/De

bugSupportBBTestCacheFunction.c |  6 ++---
  uefi-


sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv6

4/De bugSupportBBTestExceptionCallbackFunction.c |  6 ++---
  uefi-


sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
/Pl

atformIsa.c |  6 ++---
  uefi-


sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLib
Pla

t.h |  8 +++---
  uefi-
sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPl
at.c
|  6 ++---
  uefi-


sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLib
Plat

.h |  6 ++---
  uefi-
sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPl
at.c
|  6 ++---
  25 files changed, 109 insertions(+), 122 deletions(-)

diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
b/uefi- sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
index ee7c656b..b7832e18 100644
--- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
+++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
@@ -5,12 +5,12 @@
 This program and the accompanying materials   are licensed and made
available under the terms and conditions of the BSD License-  which
accompanies this distribution.  The full text of the license may be
found at + which accompanies this distribution.  The full text of the license

may be found

at   INVALID URI REMOVED

3A__opensource.org_licenses_bsd-
2Dlicense.php=DwIFAg=C5b8zRQO1miGmBeVZ2LFWg=_SN6FZBN4V
gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E=OvftgethAGVz_9J6TfZzUw8dFU
YHnlN6sUiEDYhuXY8=1xg2ZgIGgbWvH65Ek_Blc2bH0tk4175v2jjzPNqPjqY&
e=  THE PROGRAM IS

DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
IMPLIED.- + **/ /*++ diff --git a/uefi-

Re: [edk2-devel] [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-03-03 Thread Daniel Schaefer


On 2/25/21 2:56 PM, Chang, Abner (HPS SW/FW Technologist) wrote:

We unify build options to GCC:*_*_*_CC_FLAGS, but some options were added or 
removed to the specific arch
e.g. for GCC:*_*_IA32_CC_FLAGS, -ffreestanding, -nostdinc, -nostdlib are added 
additionally because of GCC:*_*_*_CC_FLAGS?


As far as I can see GCC:*_*_IA32_CC_FLAGS had -ffreestanding, -nostdinc, 
-nostdlib even before. See below. Hence, no change with this patch.


For GCC:*_*_AARCH64_CC_FLAGS,  some options were removed.


Yes, -Wno-error=unused-function -Wno-error=unused-but-set-variable were removed 
for some platforms.
But since all of the platforms already had -Wno-error (ignoring all errors), 
the build process shouldn't be affected.


Are those option changes affect the original build process? Are this the 
necessary changes?


None of this is necessary but Leif requested me to clean up the flags in the 
last series of these patches.
I don't see any changes to the build process for other platforms.
Everything should be the same if I didn't make a mistake.


Abner


-Original Message-
From: Schaefer, Daniel
Sent: Tuesday, February 9, 2021 11:44 PM
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao
; Samer El-Haj-Mahmoud ; Eric Jin ; Arvin Chen
; Leif Lindholm ; Heinrich
Schuchardt ; Chang, Abner (HPS SW/FW Technologist)

Subject: [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC
platforms

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Cc: G Edhaya Chandran 
Cc: Barton Gao 
Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Cc: Arvin Chen 
Cc: Leif Lindholm 
Cc: Heinrich Schuchardt 
Cc: Abner Chang 
Signed-off-by: Daniel Schaefer 
---
  uefi-sct/SctPkg/UEFI/IHV_SCT.dsc  | 15 ---  uefi-
sct/SctPkg/UEFI/UEFI_SCT.dsc | 15 ---
  2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-
sct/SctPkg/UEFI/IHV_SCT.dsc
index 94bb5c36..91116ca7 100644
--- a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
+++ b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
@@ -69,15 +69,16 @@
MSFT:*_*_X64_APP_FLAGS   = /D EFIX64
MSFT:*_*_X64_PP_FLAGS= /D EFIX64
  -#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -
ffreestanding -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -
mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -


-ffreestanding, -nostdinc, -nostdlib already present.
However it's commented out before and after, so either way it doesn't make a 
difference.


D MDE_CPU_X32
-   GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error
+   GCC:*_*_*_CC_FLAGS= -ffreestanding -nostdinc -nostdlib -Wno-
error+#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -mno-
red-zone -Wno-address -mno-stack-arg-probe "-
DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -D MDE_CPU_X32+
GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) #
GCC:*_*_IA32_VFRPP_FLAGS  = -D EFI32 $(GCC_VER_MACRO) #
GCC:*_*_IA32_APP_FLAGS= -D EFI32 $(GCC_VER_MACRO) #
GCC:*_*_IA32_PP_FLAGS = -D EFI32 $(GCC_VER_MACRO) -#
GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -ffreestanding
-nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-
arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -
mabi=ms -D MDE_CPU_X64
+#  GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -mno-red-
zone -Wno-address -mno-stack-arg-probe "-
DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -mabi=ms -D
MDE_CPU_X64 -   GCC:*_*_X64_CC_FLAGS = -D EFIX64
$(GCC_VER_MACRO) -Wno-error +   GCC:*_*_X64_CC_FLAGS = -D EFIX64
$(GCC_VER_MACRO) #  GCC:*_*_X64_VFRPP_FLAGS  = -D EFIX64
$(GCC_VER_MACRO) #  GCC:*_*_X64_APP_FLAGS= -D EFIX64
$(GCC_VER_MACRO) #  GCC:*_*_X64_PP_FLAGS = -D EFIX64
$(GCC_VER_MACRO)@@ -85,7 +86,7 @@
 #TODO: OM - fixme RVCT:*_*_ARM_CC_FLAGS = -D EFIARM
$(GCC_VER_MACRO)   *_*_ARM_CC_FLAGS = -D EFIARM-
GCC:*_*_ARM_CC_FLAGS  = -D EFIARM $(GCC_VER_MACRO) -fno-stack-
protector -ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -
Wno-error=unused-but-set-variable -Wno-error=implicit-function-
declaration -Wno-error+  GCC:*_*_ARM_CC_FLAGS  = -D EFIARM
$(GCC_VER_MACRO) -fno-stack-protector   *_*_ARM_VFRPP_FLAGS   = -D
EFIARM $(GCC_VER_MACRO)   *_*_ARM_APP_FLAGS = -D EFIARM
$(GCC_VER_MACRO)   *_*_ARM_PP_FLAGS  = -D EFIARM
$(GCC_VER_MACRO)@@ -104,14 +105,14 @@
RVCT:*_*_ARM_CC_FLAGS= --diag_remark=167 --
diag_suppress=167,1295,188,550,1,68,111,177*_*_AARCH64_CC_FLAGS
= -D EFIAARCH64 $(GCC_VER_MACRO)-  GCC:*_*_AARCH64_CC_FLAGS = -
D EFIAARCH64 $(GCC_VER_MACRO) -ffreestanding -nostdinc -nostdlib -
Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-
error+  GCC:*_*_AARCH64_CC_FLAGS = -D EFIAARCH64
$(GCC_VER_MACRO)   *_*_AARCH64_VFRPP_FLAGS  = -D EFIAARCH64
$(GCC_VER_MACRO)   *_*_AARCH64_APP_FLAGS= -D EFIAARCH64
$(GCC_VER_MACRO)   *_*_AARCH64_PP_FLAGS = -D EFIAARCH64
$(GCC_VER_MACRO)   RVCT:*_*_AARCH64_DLINK_FLAGS = --muldefweak

Re: [edk2-devel] [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-02-24 Thread Abner Chang

We unify build options to GCC:*_*_*_CC_FLAGS, but some options were added or 
removed to the specific arch
e.g. for GCC:*_*_IA32_CC_FLAGS, -ffreestanding, -nostdinc, -nostdlib are added 
additionally because of GCC:*_*_*_CC_FLAGS?
For GCC:*_*_AARCH64_CC_FLAGS,  some options were removed.

Are those option changes affect the original build process? Are this the 
necessary changes?
Abner

> -Original Message-
> From: Schaefer, Daniel
> Sent: Tuesday, February 9, 2021 11:44 PM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; Barton Gao
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>; Eric Jin ; Arvin Chen
> ; Leif Lindholm ; Heinrich
> Schuchardt ; Chang, Abner (HPS SW/FW Technologist)
> 
> Subject: [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC
> platforms
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
> 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Samer El-Haj-Mahmoud 
> Cc: Eric Jin 
> Cc: Arvin Chen 
> Cc: Leif Lindholm 
> Cc: Heinrich Schuchardt 
> Cc: Abner Chang 
> Signed-off-by: Daniel Schaefer 
> ---
>  uefi-sct/SctPkg/UEFI/IHV_SCT.dsc  | 15 ---  uefi-
> sct/SctPkg/UEFI/UEFI_SCT.dsc | 15 ---
>  2 files changed, 16 insertions(+), 14 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-
> sct/SctPkg/UEFI/IHV_SCT.dsc
> index 94bb5c36..91116ca7 100644
> --- a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
> +++ b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
> @@ -69,15 +69,16 @@
>MSFT:*_*_X64_APP_FLAGS   = /D EFIX64
>MSFT:*_*_X64_PP_FLAGS= /D EFIX64
>  -#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -
> ffreestanding -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -
> mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -
> D MDE_CPU_X32
> -   GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -Wno-error
> +   GCC:*_*_*_CC_FLAGS= -ffreestanding -nostdinc -nostdlib -Wno-
> error+#  GCC:*_*_IA32_CC_FLAGS = -D EFI32 $(GCC_VER_MACRO) -mno-
> red-zone -Wno-address -mno-stack-arg-probe "-
> DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -D MDE_CPU_X32+
> GCC:*_*_IA32_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) #
> GCC:*_*_IA32_VFRPP_FLAGS  = -D EFI32 $(GCC_VER_MACRO) #
> GCC:*_*_IA32_APP_FLAGS= -D EFI32 $(GCC_VER_MACRO) #
> GCC:*_*_IA32_PP_FLAGS = -D EFI32 $(GCC_VER_MACRO) -#
> GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -ffreestanding
> -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-
> arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -
> mabi=ms -D MDE_CPU_X64
> +#  GCC:*_*_X64_CC_FLAGS = -D EFIX64 $(GCC_VER_MACRO) -mno-red-
> zone -Wno-address -mno-stack-arg-probe "-
> DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -mabi=ms -D
> MDE_CPU_X64 -   GCC:*_*_X64_CC_FLAGS = -D EFIX64
> $(GCC_VER_MACRO) -Wno-error +   GCC:*_*_X64_CC_FLAGS = -D EFIX64
> $(GCC_VER_MACRO) #  GCC:*_*_X64_VFRPP_FLAGS  = -D EFIX64
> $(GCC_VER_MACRO) #  GCC:*_*_X64_APP_FLAGS= -D EFIX64
> $(GCC_VER_MACRO) #  GCC:*_*_X64_PP_FLAGS = -D EFIX64
> $(GCC_VER_MACRO)@@ -85,7 +86,7 @@
> #TODO: OM - fixme RVCT:*_*_ARM_CC_FLAGS = -D EFIARM
> $(GCC_VER_MACRO)   *_*_ARM_CC_FLAGS = -D EFIARM-
> GCC:*_*_ARM_CC_FLAGS  = -D EFIARM $(GCC_VER_MACRO) -fno-stack-
> protector -ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -
> Wno-error=unused-but-set-variable -Wno-error=implicit-function-
> declaration -Wno-error+  GCC:*_*_ARM_CC_FLAGS  = -D EFIARM
> $(GCC_VER_MACRO) -fno-stack-protector   *_*_ARM_VFRPP_FLAGS   = -D
> EFIARM $(GCC_VER_MACRO)   *_*_ARM_APP_FLAGS = -D EFIARM
> $(GCC_VER_MACRO)   *_*_ARM_PP_FLAGS  = -D EFIARM
> $(GCC_VER_MACRO)@@ -104,14 +105,14 @@
>RVCT:*_*_ARM_CC_FLAGS= --diag_remark=167 --
> diag_suppress=167,1295,188,550,1,68,111,177*_*_AARCH64_CC_FLAGS
> = -D EFIAARCH64 $(GCC_VER_MACRO)-  GCC:*_*_AARCH64_CC_FLAGS = -
> D EFIAARCH64 $(GCC_VER_MACRO) -ffreestanding -nostdinc -nostdlib -
> Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-
> error+  GCC:*_*_AARCH64_CC_FLAGS = -D EFIAARCH64
> $(GCC_VER_MACRO)   *_*_AARCH64_VFRPP_FLAGS  = -D EFIAARCH64
> $(GCC_VER_MACRO)   *_*_AARCH64_APP_FLAGS= -D EFIAARCH64
> $(GCC_VER_MACRO)   *_*_AARCH64_PP_FLAGS = -D EFIAARCH64
> $(GCC_VER_MACRO)   RVCT:*_*_AARCH64_DLINK_FLAGS = --muldefweak
> *_*_RISCV64_CC_FLAGS = -D EFIRISCV64 $(GCC_VER_MACRO)-
> GCC:*_*_RISCV64_CC_FLAGS  = -D EFIRISCV64 $(GCC_VER_MACRO) -
> ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -Wno-
> error=unused-but-set-variable -Wno-error+  GCC:*_*_RISCV64_CC_FLAGS
> = -D EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_VFRPP_FLAGS  = -D
> EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_APP_FLAGS= -D
> EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_PP_FLAGS = -D
> EFIRISCV64 $(GCC_VER_MACRO)diff --git a/uefi-
> sct/SctPkg/UEFI/UEFI_SCT.dsc b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
> index e13e40e4..3bb57d26 100644
> ---

Re: [edk2-devel] [edk2-test PATCHv2 3/5] SctPkg: Add RISCV64 build support

2021-02-24 Thread Abner Chang

Reviewed-by: Abner Chang 

> -Original Message-
> From: Schaefer, Daniel
> Sent: Tuesday, February 9, 2021 11:44 PM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; Barton Gao
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>; Eric Jin ; Arvin Chen
> ; Leif Lindholm ; Heinrich
> Schuchardt ; Chang, Abner (HPS SW/FW Technologist)
> 
> Subject: [edk2-test PATCHv2 3/5] SctPkg: Add RISCV64 build support
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
> 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Samer El-Haj-Mahmoud 
> Cc: Eric Jin 
> Cc: Arvin Chen 
> Cc: Leif Lindholm 
> Cc: Heinrich Schuchardt 
> Cc: Abner Chang 
> Signed-off-by: Daniel Schaefer 
> ---
>  uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h   
>|  4
> ++
>  uefi-sct/SctPkg/Library/SctLib/SctLib.inf
>|  6 ++
>  uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf 
>|  5 ++
>  uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf   
>|  6
> ++
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Debug
> SupportBBTest.inf |  6 ++
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/Usb2Hc/BlackBoxTest/Usb2HcTest.in
> f   |  4 ++
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/UsbHcTest.inf
> |  4 ++
>  uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf
> |  5 ++
>  uefi-sct/SctPkg/Tools/Source/GenBin/GNUmakefile  
>|
> 4 ++
>  uefi-sct/SctPkg/UEFI/IHV_SCT.dsc 
>| 17 +-
>  uefi-sct/SctPkg/UEFI/Protocol/DebugSupport.h 
>| 61
> +++-
>  uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
>| 18 +-
>  uefi-sct/SctPkg/build.sh 
>| 11 +++-
>  13 files changed, 144 insertions(+), 7 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h b/uefi-
> sct/SctPkg/Application/InstallSct/InstallSctDef.h
> index a7815580..02f0283e 100644
> --- a/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h
> +++ b/uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h
> @@ -3,6 +3,7 @@
>Copyright 2006 - 2017 Unified EFI, Inc.   Copyright (c) 2010 - 2017, 
> Intel
> Corporation. All rights reserved.   Portions copyright (c) 2014, ARM Ltd.
> All rights reserved.+  (C) Copyright 2021 Hewlett Packard Enterprise
> Development LPThis program and the accompanying materials   are
> licensed and made available under the terms and conditions of the BSD
> License@@ -32,6 +33,9 @@
>  #elif defined(EFIAARCH64)   #define
> INSTALL_SCT_PLATFORM_SHORT_NAME   L"aarch64"   #define
> INSTALL_SCT_PLATFORM_NAME L"AARCH64"+#elif
> defined(EFIRISCV64)+  #define INSTALL_SCT_PLATFORM_SHORT_NAME
> L"riscv64"+  #define INSTALL_SCT_PLATFORM_NAME L"RISCV64" #else
> #error "Architecture not supported" #endifdiff --git a/uefi-
> sct/SctPkg/Library/SctLib/SctLib.inf 
> b/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
> index 23cb77fb..7527b203 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
> +++ b/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
> @@ -3,6 +3,7 @@
>  #  Copyright 2006 - 2016 Unified EFI, Inc. #  Copyright (c) 2013 - 2014,
> ARM Ltd. All rights reserved. #  Copyright (c) 2014 - 2019, Intel
> Corporation. All rights reserved.+#  (C) Copyright 2021 Hewlett Packard
> Enterprise Development LP # #  This program and the accompanying
> materials #  are licensed and made available under the terms and conditions
> of the BSD License@@ -62,6 +63,11 @@
>Aarch64/initplat.c   Math.c +[sources.RISCV64]+  Riscv64/SctLibPlat.h+
> Riscv64/initplat.c+  Math.c+ [sources.ia32]   ia32/SctLibPlat.h
> ia32/initplat.cdiff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf b/uefi-
> sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf
> index 7aca6e30..8104a4ef 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf
> @@ -2,6 +2,7 @@
>  # #  Copyright 2006 - 2016 Unified EFI, Inc. #  Copyright (c) 2010 - 
> 2016,
> Intel Corporation. All rights reserved.+#  (C) Copyright 2021 Hewlett
> Packard Enterprise Development LP # #  This program and the
> accompanying materials #  are licensed and made available under the terms
> and conditions of the BSD License@@ -39,6 +40,10 @@
>Aarch64/GoVirtual.asm | RVCT   Aarch64/GoVirtual.S | GCC
> +[sources.RISCV64]+  Riscv64/VirtualMemory.c+  Riscv64/GoVirtual.S | GCC+
> [sources.ia32]   ia32/VirtualMemory.c   ia32/GoVirtual.asm | MSFTdiff --git
> a/uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf
> index ad0eb0f8..a3ef454e 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf
> +++

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

2021-02-24 Thread Abner Chang

Some non-whitespace changes in this patch, such as SctLibPlt.h, goVirtual.S and 
maybe others. I think you mixed up the changes by accident?

> -Original Message-
> From: G Edhaya Chandran [mailto:edhaya.chand...@arm.com]
> Sent: Wednesday, February 24, 2021 5:02 PM
> To: Schaefer, Daniel ; devel@edk2.groups.io
> Cc: Barton Gao ; Samer El-Haj-Mahmoud
> ; Eric Jin ; Arvin
> Chen ; Leif Lindholm ; Heinrich
> Schuchardt ; Chang, Abner (HPS SW/FW Technologist)
> 
> Subject: RE: [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace
> 
> Reviewed-by: G Edhaya Chandran
> 
> > -Original Message-
> > From: Daniel Schaefer 
> > Sent: 09 February 2021 21:14
> > To: devel@edk2.groups.io
> > Cc: G Edhaya Chandran ; Barton Gao
> > ; Samer El-Haj-Mahmoud  > mahm...@arm.com>; Eric Jin ; Arvin Chen
> > ; Leif Lindholm ; Heinrich
> > Schuchardt ; Abner Chang
> 
> > Subject: [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace
> >
> > REF:INVALID URI REMOVED
> > ocore.org_show-5Fbug.cgi-3Fid-
> 3D3042=DwIFAg=C5b8zRQO1miGmBeVZ2LFWg
> >
> =_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E=OvftgethAGVz
> _9J6TfZzU
> > w8dFUYHnlN6sUiEDYhuXY8=O2aIe5GLoSMYAR-
> eYh_EPm_WTgaHPatmncmzZlNnYWI
> > =
> >
> > Cc: G Edhaya Chandran 
> > Cc: Barton Gao 
> > Cc: Samer El-Haj-Mahmoud 
> > Cc: Eric Jin 
> > Cc: Arvin Chen 
> > Cc: Leif Lindholm 
> > Cc: Heinrich Schuchardt 
> > Cc: Abner Chang 
> > Signed-off-by: Daniel Schaefer 
> > ---
> >  uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> > |  4 +--
> >  uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> > |  6 ++---
> >  uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> > |  7 +++--
> >  uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> > |  6 ++---
> >  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S
> > | 15 ++-
> >  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c
> > | 22 +++
> >  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> > |  6 ++---
> >  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> > |  6 ++---
> >  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
> > | 28 +++-
> >  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> > |  8 +++---
> >  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c
> > | 15 ++-
> >  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h
> > |  8 +++---
> >  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> > |  6 ++---
> >  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> > |  8 +++---
> >  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> > |  8 +++---
> >  uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
> 4/D
> > ebugSupportBBTestCacheFunction.c |  6 ++---
> >  uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
> > 4/D ebugSupportBBTestExceptionCallbackFunction.c | 18 ++---
> >  uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
> 4/Pl
> > atformIsa.c | 10 +++
> >  uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /De
> > bugSupportBBTestCacheFunction.c |  6 ++---
> >  uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv6
> > 4/De bugSupportBBTestExceptionCallbackFunction.c |  6 ++---
> >  uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /Pl
> > atformIsa.c |  6 ++---
> >  uefi-
> >
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLib
> Pla
> > t.h |  8 +++---
> >  uefi-
> > sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPl
> > at.c
> > |  6 ++---
> >  uefi-
> >
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLib
> Plat
> > .h |  6 ++---
> >  uefi-
> > sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPl
> > at.c
> > |  6 ++---
> >  25 files changed, 109 insertions(+), 122 deletions(-)
> >
> > diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> > b/uefi- sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> > index ee7c656b..b7832e18 100644
> > --- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> > +++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> > @@ -5,12 +5,12 @@
> > This program and the accompanying materials   are licensed and made
> > available under the terms and conditions of the BSD License-  which
> > accompanies this distribution.  The full text of the license may be
> > found at + which accompanies this distribution.  The full text of the 
> > license
> may be found
> > at   INVALID URI REMOVED
> 3A__opensource.org_licenses_bsd-
> 2Dlicense.php=DwIFAg=C5b8zRQO1miGmBeVZ2LFWg=_SN6FZBN4V
> gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E=OvftgethAGVz_9J6TfZzUw8dFU
> YHnlN6sUiEDYhuXY8=1xg2ZgIGgbWvH65Ek_Blc2bH0tk4175v2jjzPNqPjqY&
> e=  THE PROGRAM IS
> > DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"

Re: [edk2-devel] [edk2-test PATCHv2 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

2021-02-24 Thread Abner Chang




> -Original Message-
> From: Schaefer, Daniel
> Sent: Tuesday, February 9, 2021 11:44 PM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; Barton Gao
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>; Eric Jin ; Arvin Chen
> ; Leif Lindholm ; Heinrich
> Schuchardt ; Chang, Abner (HPS SW/FW Technologist)
> 
> Subject: [edk2-test PATCHv2 2/5] SctPkg: Adapt Aarch64 sources for Riscv64
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
> 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Samer El-Haj-Mahmoud 
> Cc: Eric Jin 
> Cc: Arvin Chen 
> Cc: Leif Lindholm 
> Cc: Heinrich Schuchardt 
> Cc: Abner Chang 
> Signed-off-by: Daniel Schaefer 
> ---
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> |  3 +-
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> |  9 ++--
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> | 16 +++
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> | 22 +++--
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> |  7 +--
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h
> | 48 
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /DebugSupportBBTestExceptionCallbackFunction.c | 12 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /PlatformIsa.c |  4 +-
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLib
> Plat.h |  2 +-
>  9 files changed, 31 insertions(+), 92 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h b/uefi-
> sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> index ee7c656b..69e7f904 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> +++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> @@ -2,6 +2,7 @@
> Copyright 2006 - 2012 Unified EFI, Inc.   Copyright (c) 2011 - 2012, 
> ARM
> Ltd. All rights reserved.+  Copyright (c) 2021, Hewlett Packard Enterprise
> Development LP. All rights reserved.This program and the
> accompanying materials   are licensed and made available under the terms
> and conditions of the BSD License@@ -20,7 +21,7 @@ Module Name:
>   Abstract: -  AArch64 specific defines+  RISCV64 specific defines  --*/ diff 
> --git
> a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S b/uefi-
> sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> index d223b36b..ae33da18 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> @@ -2,6 +2,7 @@
>  # #  Copyright 2010 - 2012 Unified EFI, Inc. #  Copyright (c) 2012, ARM
> Ltd. All rights reserved.+#  Copyright (c) 2021, Hewlett Packard
> Enterprise Development LP. # #  This program and the accompanying
> materials #  are licensed and made available under the terms and conditions
> of the BSD License@@ -23,8 +24,6 @@  #--*/ #start of the code section .text-
> /* FIXME: Should alignment be different on Aarch64? */-.align 3  .global
> JumpToTestFunc .type JumpToTestFunc, %function@@ -37,8 +36,8 @@
>  #   ) # JumpToTestFunc:- mov x2, x0- mov x0, x1+ mv x2, x0+
>   mv x0, x1   // Jump to Virtual function-blr x2+ jalr x2diff 
> --git
> a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c b/uefi-
> sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> index 397b3514..00b59594 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> @@ -2,6 +2,7 @@
> Copyright 2006 - 2012 Unified EFI, Inc.   Copyright (c) 2012, ARM 
> Ltd. All
> rights reserved.+  Copyright (c) 2021, Hewlett Packard Enterprise
> Development LP. All rights reserved.This program and the
> accompanying materials   are licensed and made available under the terms
> and conditions of the BSD License@@ -22,9 +23,6 @@ Module Name:
>   #include "SCRTApp.h" -#define VIRT_TO_PHYS_OFFSET   (0x8000)
> //2G--BOOLEAN HighAddress = FALSE; UINTN   PageTable   = 0;  @@ -
> 49,11 +47,10 @@ Returns:
>   --*/ {- /*Note: It is presumed that on ARM v5, V6 and V7 architectures-
>* the MMU is configured and enabled in PEI phase. As VirtualFunc-
>* is already mapped to virtual memory, don't have to do anything
> here.+  /* Note: It is presumed that on RISCV architectures the MMU is
> configured and+   * enabled in PEI phase. As VirtualFunc is already mapped to
> virtual memory,+   * don't have to do anything here.   */-  /* FIXME: Is it
> the same on ARM v8? */ }  @@ -174,9 +171,8 @@ Returns:
>  --*/ {   //-  // Note: It is assumed that the MMU and page tables are
> configured on ARM platforms-  // based on ARM v5 v6 and v7 architecture.+
> // Note: It is assumed that the MMU and page tables are configured on RISC-
> V+  // platforms.   //-  /* FIXME: Is it the same on ARM v8? */
>   JumpToTestFunc(VirtualFunc, HandOffAddr); }diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c b/uefi-
>

Re: [edk2-devel] [edk2-test PATCHv2 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources

2021-02-24 Thread Abner Chang

Reviewed-by: Abner Chang 

> -Original Message-
> From: Schaefer, Daniel
> Sent: Tuesday, February 9, 2021 11:44 PM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; Barton Gao
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>; Eric Jin ; Arvin Chen
> ; Leif Lindholm ; Heinrich
> Schuchardt ; Chang, Abner (HPS SW/FW Technologist)
> 
> Subject: [edk2-test PATCHv2 1/5] SctPkg: Add RISCV64 support by using
> Aarch64 sources
> 
> The sources were copied from Aarch64. Follow-up commit will adapt them
> for Riscv64.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
> 
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Samer El-Haj-Mahmoud 
> Cc: Eric Jin 
> Cc: Arvin Chen 
> Cc: Leif Lindholm 
> Cc: Heinrich Schuchardt 
> Cc: Abner Chang 
> Signed-off-by: Daniel Schaefer 
> ---
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> |  32 +++
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> |  45 
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> |  44 
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> | 182 +
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> |  88 +++
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> |  68 +
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> | 134 ++
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h
> |  48 
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /DebugSupportBBTestCacheFunction.c | 137 ++
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /DebugSupportBBTestExceptionCallbackFunction.c | 276
> 
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /PlatformIsa.c |  30 +++
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLib
> Plat.h |  55 
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.
> c|  55 
>  13 files changed, 1194 insertions(+)
> 
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h b/uefi-
> sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> new file mode 100644
> index ..ee7c656b
> --- /dev/null
> +++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> @@ -0,0 +1,32 @@
> +/** @file++  Copyright 2006 - 2012 Unified EFI, Inc.+  Copyright
> +(c) 2011 - 2012, ARM Ltd. All rights reserved.++  This program and
> +the accompanying materials+  are licensed and made available under the
> +terms and conditions of the BSD License+  which accompanies this
> +distribution.  The full text of the license may be found at +
> +http://opensource.org/licenses/bsd-license.php+ +  THE PROGRAM IS
> +DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,+  WITHOUT
> +WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.+
> ++**/+/*Module Name:++  SctLibPlat.h++Abstract:++  AArch64 specific
> +defines++--*/++#ifndef _EFI_LIB_PLAT_H_+#define
> +_EFI_LIB_PLAT_H_++#define MIN_ALIGNMENT_SIZE  8++#endifdiff --git
> +a/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> +b/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> new file mode 100644
> index ..a48bb2f3
> --- /dev/null
> +++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> @@ -0,0 +1,45 @@
> +/** @file++  Copyright 2006 - 2012 Unified EFI, Inc.+  Copyright (c) 2011
> - 2012, ARM Ltd. All rights reserved.++  This program and the
> accompanying materials+  are licensed and made available under the terms
> and conditions of the BSD License+  which accompanies this distribution.  The
> full text of the license may be found at +
> http://opensource.org/licenses/bsd-license.php+ +  THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,+  WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.+ +**/+/*Module Name:++  initplat.c++Abstract:++  Math
> routines for compatibility with native EFI library routines.++--*/++#include
> "SctLibInternal.h"++VOID+InitializeLibPlatform (+IN EFI_HANDLE
> ImageHandle,+IN EFI_SYSTEM_TABLE *SystemTable+)++{+  // No
> platform-specific initializations+}++UINT64+SctReadTsc (+  VOID+  )+{+
> return 0;+}diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> new file mode 100644
> index ..d223b36b
> --- /dev/null
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> @@ -0,0 +1,44 @@
> +## @file+#+#  Copyright 2010 - 2012 Unified EFI, Inc.+#  Copyright (c)
> 2012, ARM Ltd. All rights reserved.+#+#  This program and the
> accompanying materials+#  are licensed and made available under the terms
> and conditions of the BSD License+#  which accompanies this distribution.
> The full text of the license may be found at +#
> http://opensource.org/licenses/bsd-license.php+# +#  THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

2021-02-24 Thread G Edhaya Chandran

Reviewed-by: G Edhaya Chandran

> -Original Message-
> From: Daniel Schaefer 
> Sent: 09 February 2021 21:14
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; Barton Gao
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>; Eric Jin ; Arvin Chen
> ; Leif Lindholm ; Heinrich
> Schuchardt ; Abner Chang 
> Subject: [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
>
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Samer El-Haj-Mahmoud 
> Cc: Eric Jin 
> Cc: Arvin Chen 
> Cc: Leif Lindholm 
> Cc: Heinrich Schuchardt 
> Cc: Abner Chang 
> Signed-off-by: Daniel Schaefer 
> ---
>  uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> |  4 +--
>  uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> |  6 ++---
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> |  7 +++--
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S
> | 15 ++-
>  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c
> | 22 +++
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
> | 28 +++-
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> |  8 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c
> | 15 ++-
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h
> |  8 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> |  8 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> |  8 +++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestCacheFunction.c |  6 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestExceptionCallbackFunction.c | 18 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/Pl
> atformIsa.c | 10 +++
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestCacheFunction.c |  6 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestExceptionCallbackFunction.c |  6 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/Pl
> atformIsa.c |  6 ++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLibPla
> t.h |  8 +++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat.c
> |  6 ++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat
> .h |  6 ++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c
> |  6 ++---
>  25 files changed, 109 insertions(+), 122 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h b/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> index ee7c656b..b7832e18 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> +++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> @@ -5,12 +5,12 @@
> This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be 
> found
> at   http://opensource.org/licenses/bsd-license.php THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/initplat.c b/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> index a48bb2f3..1c247c91 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> +++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> @@ -5,12 +5,12 @@
> This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be 
> found
> at   http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h b/uefi-
> sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> index 69e7f904..b7832e18 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> +++

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

2021-02-20 Thread Samer El-Haj-Mahmoud

Reviewed-by: Samer El-Haj-Mahmoud 

> -Original Message-
> From: Daniel Schaefer 
> Sent: Tuesday, February 9, 2021 10:44 AM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran ; Barton Gao
> ; Samer El-Haj-Mahmoud  mahm...@arm.com>; Eric Jin ; Arvin Chen
> ; Leif Lindholm ; Heinrich
> Schuchardt ; Abner Chang 
> Subject: [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
>
> Cc: G Edhaya Chandran 
> Cc: Barton Gao 
> Cc: Samer El-Haj-Mahmoud 
> Cc: Eric Jin 
> Cc: Arvin Chen 
> Cc: Leif Lindholm 
> Cc: Heinrich Schuchardt 
> Cc: Abner Chang 
> Signed-off-by: Daniel Schaefer 
> ---
>  uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> |  4 +--
>  uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> |  6 ++---
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> |  7 +++--
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S
> | 15 ++-
>  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c
> | 22 +++
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
> | 28 +++-
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> |  8 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c
> | 15 ++-
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h
> |  8 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> |  8 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> |  8 +++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
> 4/DebugSupportBBTestCacheFunction.c |  6 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
> 4/DebugSupportBBTestExceptionCallbackFunction.c | 18 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch6
> 4/PlatformIsa.c | 10 +++
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /DebugSupportBBTestCacheFunction.c |  6 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /DebugSupportBBTestExceptionCallbackFunction.c |  6 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64
> /PlatformIsa.c |  6 ++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLib
> Plat.h |  8 +++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat
> .c|  6 ++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLib
> Plat.h |  6 ++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.
> c|  6 ++---
>  25 files changed, 109 insertions(+), 122 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h b/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> index ee7c656b..b7832e18 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> +++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> @@ -5,12 +5,12 @@
>
>
>This program and the accompanying materials
>
>are licensed and made available under the terms and conditions of the BSD
> License
>
> -  which accompanies this distribution.  The full text of the license may be
> found at
>
> +  which accompanies this distribution.  The full text of the license may be
> found at
>
>http://opensource.org/licenses/bsd-license.php
>
>
>
>THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
>
>WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
>
> -
>
> +
>
>  **/
>
>  /*++
>
>
>
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c b/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> index a48bb2f3..1c247c91 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> +++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> @@ -5,12 +5,12 @@
>
>
>This program and the accompanying materials
>
>are licensed and made available under the terms and conditions of the BSD
> License
>
> -  which accompanies this distribution.  The full text of the license may be
> found at
>
> +  which accompanies this distribution.  The full text of the license may be
> found at
>
>http://opensource.org/licenses/bsd-license.php
>
> -
>
> +
>
>THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
>
>WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
>
> -
>
> +
>
>  **/
>
>  /*++
>
>
>
> diff --git

[edk2-devel] [edk2-test] build EMS tests

2021-02-09 Thread Adriano Kultzak

I would like to perform passive mode tests but I've been unsuccessfully trying 
to build the EMS tool(ver 2.6 and 2.7) following 
https://github.com/tianocore/edk2-test/blob/master/uefi-sct/HowToBuild/HowToBuildEms.txt.
 Since I'm snowballing into poorly updated libs and old compiler versions Is 
there any successful recipe for it or some light on what to attempt? Thanks in 
advance.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71537): https://edk2.groups.io/g/devel/message/71537
Mute This Topic: https://groups.io/mt/80518207/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

1 2 3 4 >

1 - 100 of 303 matches

Mail list logo