Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
On Mon, 29 May 2023 at 13:44, Ard Biesheuvel wrote: > > On Wed, 24 May 2023 at 12:48, Sami Mujawar wrote: > > > > Hi Neil, > > > > Thank you for this patch. > > These changes look good to me. > > > > Reviewed-by: Sami Mujawar > > > > Merged as #4465 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105573): https://edk2.groups.io/g/devel/message/105573 Mute This Topic: https://groups.io/mt/98831775/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
On Wed, 24 May 2023 at 12:48, Sami Mujawar wrote: > > Hi Neil, > > Thank you for this patch. > These changes look good to me. > > Reviewed-by: Sami Mujawar > I cannot apply this. Please resend this (with me on cc) using git send-email -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105377): https://edk2.groups.io/g/devel/message/105377 Mute This Topic: https://groups.io/mt/98831775/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
Hi Neil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105227): https://edk2.groups.io/g/devel/message/105227 Mute This Topic: https://groups.io/mt/98831775/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
(+CC maintainers) On Thu, May 11, 2023 at 5:47 PM wrote: > > The GIC v2 base addresses can be 64bit, don't limit to 32 on 64bit > machines. > > Signed-off-by: Neil Jones > --- > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c > b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c > index 25290342bd..b990bf3a8a 100644 > --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c > +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c > @@ -25,8 +25,8 @@ Abstract: > extern EFI_HARDWARE_INTERRUPT_PROTOCOL gHardwareInterruptV2Protocol; > extern EFI_HARDWARE_INTERRUPT2_PROTOCOL gHardwareInterrupt2V2Protocol; > > -STATIC UINT32 mGicInterruptInterfaceBase; > -STATIC UINT32 mGicDistributorBase; > +STATIC UINTN mGicInterruptInterfaceBase; > +STATIC UINTN mGicDistributorBase; > > /** >Enable interrupt source Source. > -- > 2.39.2 LGTM, particularly as the PCDs are 64-bit already. Reviewed-by: Pedro Falcato but CC'ing the proper maintainers (please do so in the future!) -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104810): https://edk2.groups.io/g/devel/message/104810 Mute This Topic: https://groups.io/mt/98831775/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
The GIC v2 base addresses can be 64bit, don't limit to 32 on 64bit machines. Signed-off-by: Neil Jones --- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c index 25290342bd..b990bf3a8a 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c @@ -25,8 +25,8 @@ Abstract: extern EFI_HARDWARE_INTERRUPT_PROTOCOL gHardwareInterruptV2Protocol; extern EFI_HARDWARE_INTERRUPT2_PROTOCOL gHardwareInterrupt2V2Protocol; -STATIC UINT32 mGicInterruptInterfaceBase; -STATIC UINT32 mGicDistributorBase; +STATIC UINTN mGicInterruptInterfaceBase; +STATIC UINTN mGicDistributorBase; /** Enable interrupt source Source. -- 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104721): https://edk2.groups.io/g/devel/message/104721 Mute This Topic: https://groups.io/mt/98831775/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-