Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9
Thanks All. This patch set is merged just now. - https://github.com/tianocore/edk2/pull/4728 The size increase is indeed a concern since last year. Currently, we have another staging tree - https://github.com/tianocore/edk2-staging/blob/OpenSSL11_EOL to handle that. Thank you Yao, Jiewen > -Original Message- > From: Kenneth Lautner > Sent: Wednesday, August 9, 2023 8:45 AM > To: Yao, Jiewen ; Michael Kubacki > ; devel@edk2.groups.io; Johnson, Brian > ; Gao, Liming ; > llind...@qti.qualcomm.com; Kinney, Michael D ; > Li, Yi1 ; 'Andrew Fish' > Cc: Lu, Xiaoyu1 ; Jiang, Guomin > ; 'Gerd Hoffmann' ; 'Ard > Biesheuvel' ; LEE, TERRY > Subject: RE: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > submodule to 3.0.9 > > Hi Jiewen, > > I've tested the changes on our physical and virtual platforms to make sure > metrics > aren't deviating from our current expectations. > > Our PEI module roughly doubles in size (34.8 KB to 64.5 KB) and our DXE and > SMM modules grow by around 300 KB (1100 KB to 1424.5 KB for DXE and 816 KB > to 1180 KB for SMM). > > From a performance perspective everything seems to be within margin of error > so > no problems there and all expected functionality remains the same. > > Although the size increase is a little concerning and currently doesn't work > with > our physical platforms, with some modifications on our end we should be able > to > make it work. > > We have no issues with the merging. > > Thanks, > Ken > > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, August 8, 2023 5:00 PM > To: Michael Kubacki ; devel@edk2.groups.io; > Johnson, Brian ; Gao, Liming > ; llind...@qti.qualcomm.com; Kinney, Michael D > ; Li, Yi1 ; 'Andrew Fish' > ; Kenneth Lautner > Cc: Lu, Xiaoyu1 ; Jiang, Guomin > ; 'Gerd Hoffmann' ; 'Ard > Biesheuvel' ; LEE, TERRY > Subject: [EXTERNAL] RE: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update > OpenSSL submodule to 3.0.9 > > [You don't often get email from jiewen@intel.com. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > Hi Ken > Do you have any additional feedback for the patch set? > > We are waiting for that since this is a feature needed for 202308 tag. > > Thank you > Yao, Jiewen > > > -Original Message- > > From: Michael Kubacki > > Sent: Saturday, August 5, 2023 6:55 AM > > To: devel@edk2.groups.io; Johnson, Brian ; Gao, > > Liming ; llind...@qti.qualcomm.com; Kinney, > > Michael D ; Li, Yi1 ; > > 'Andrew Fish' ; Lautner, Kenneth > > > > Cc: Yao, Jiewen ; Lu, Xiaoyu1 > > ; Jiang, Guomin ; 'Gerd > Hoffmann' > > ; 'Ard Biesheuvel' ; > > LEE, TERRY > > Subject: Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > > submodule to 3.0.9 > > > > Ken Lautner is helping test on some platforms. The size increase is > > presenting a bit of a challenge at the moment, but he should be able > > to share more feedback early next week. > > > > Regards, > > Michael > > > > On 8/4/2023 4:54 PM, Brian J. Johnson wrote: > > > Liming and Jiewen, > > > > > > I asked Terry Lee to give this patchset a spin, and it seemed to > > > work well for our h/w use case. The size increase vs. OpenSSL > > > 1.1.1n was noticeable, but workable. We're good with merging it. > > > > > > Brian J. Johnson > > > HP Enterprise > > > Misison-Critical Systems > > > > > > Original Message > > > From: gaoliming via groups.io > > > [mailto:gaoliming=byosoft.com...@groups.io] > > > Sent: Friday, August 4, 2023 at 4:44 AM > > > To: , , 'Kinney, > > > Michael D' , 'Li, Yi1' > > > , 'Andrew Fish' > > > Cc: 'Yao, Jiewen' , 'Lu, Xiaoyu1' > > > , 'Jiang, Guomin' , > > > 'Gerd Hoffmann' , 'Ard Biesheuvel' > > > > > Subject: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > > > submodule to 3.0.9 > > > > > > Hi, all > > > We are near to the soft feature freeze for the stable tag 202308. > > > Please give your opinion for this patch set to catch 202308 release. > > > > > > Now, Ard, Jiewen (Crypto Package Maintainer), Yi (Patch > > > Contributor) opinion is to merge this patch set if no other comments in > > > one > week. > > > > > > Leif opinion is to agree with the package maintainer. > > > > > > All changes of this patch set are in CryptoPkg. So, I also agree > > > with CryptoPkg maintainer. &
Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9
Hi Jiewen, I've tested the changes on our physical and virtual platforms to make sure metrics aren't deviating from our current expectations. Our PEI module roughly doubles in size (34.8 KB to 64.5 KB) and our DXE and SMM modules grow by around 300 KB (1100 KB to 1424.5 KB for DXE and 816 KB to 1180 KB for SMM). From a performance perspective everything seems to be within margin of error so no problems there and all expected functionality remains the same. Although the size increase is a little concerning and currently doesn't work with our physical platforms, with some modifications on our end we should be able to make it work. We have no issues with the merging. Thanks, Ken -Original Message- From: Yao, Jiewen Sent: Tuesday, August 8, 2023 5:00 PM To: Michael Kubacki ; devel@edk2.groups.io; Johnson, Brian ; Gao, Liming ; llind...@qti.qualcomm.com; Kinney, Michael D ; Li, Yi1 ; 'Andrew Fish' ; Kenneth Lautner Cc: Lu, Xiaoyu1 ; Jiang, Guomin ; 'Gerd Hoffmann' ; 'Ard Biesheuvel' ; LEE, TERRY Subject: [EXTERNAL] RE: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 [You don't often get email from jiewen@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hi Ken Do you have any additional feedback for the patch set? We are waiting for that since this is a feature needed for 202308 tag. Thank you Yao, Jiewen > -Original Message- > From: Michael Kubacki > Sent: Saturday, August 5, 2023 6:55 AM > To: devel@edk2.groups.io; Johnson, Brian ; Gao, > Liming ; llind...@qti.qualcomm.com; Kinney, > Michael D ; Li, Yi1 ; > 'Andrew Fish' ; Lautner, Kenneth > > Cc: Yao, Jiewen ; Lu, Xiaoyu1 > ; Jiang, Guomin ; 'Gerd > Hoffmann' > ; 'Ard Biesheuvel' ; > LEE, TERRY > Subject: Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > submodule to 3.0.9 > > Ken Lautner is helping test on some platforms. The size increase is > presenting a bit of a challenge at the moment, but he should be able > to share more feedback early next week. > > Regards, > Michael > > On 8/4/2023 4:54 PM, Brian J. Johnson wrote: > > Liming and Jiewen, > > > > I asked Terry Lee to give this patchset a spin, and it seemed to > > work well for our h/w use case. The size increase vs. OpenSSL > > 1.1.1n was noticeable, but workable. We're good with merging it. > > > > Brian J. Johnson > > HP Enterprise > > Misison-Critical Systems > > > > Original Message > > From: gaoliming via groups.io > > [mailto:gaoliming=byosoft.com...@groups.io] > > Sent: Friday, August 4, 2023 at 4:44 AM > > To: , , 'Kinney, > > Michael D' , 'Li, Yi1' > > , 'Andrew Fish' > > Cc: 'Yao, Jiewen' , 'Lu, Xiaoyu1' > > , 'Jiang, Guomin' , > > 'Gerd Hoffmann' , 'Ard Biesheuvel' > > > Subject: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > > submodule to 3.0.9 > > > > Hi, all > > We are near to the soft feature freeze for the stable tag 202308. > > Please give your opinion for this patch set to catch 202308 release. > > > > Now, Ard, Jiewen (Crypto Package Maintainer), Yi (Patch > > Contributor) opinion is to merge this patch set if no other comments in one > > week. > > > > Leif opinion is to agree with the package maintainer. > > > > All changes of this patch set are in CryptoPkg. So, I also agree > > with CryptoPkg maintainer. > > > > Thanks > > Liming > >> -邮件原件- > >> 发件人: devel@edk2.groups.io 代表 Leif Lindholm > >> 发送时间: 2023年8月3日 2:46 > >> 收件人: Kinney, Michael D ; > >> devel@edk2.groups.io; Gao, Liming ; Li, > >> Yi1 > >> 抄送: Yao, Jiewen ; Lu, Xiaoyu1 > >> ; Jiang, Guomin ; > >> 'Gerd Hoffmann' ; Andrew Fish (af...@apple.com) > >> > >> 主题: Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > >> submodule to 3.0.9 > >> > >> I am a little bit nervous about introducing this massive change so > >> late in the cycle, and am not sure whether any deferral of the soft > >> freeze would be sufficient to change that. > >> My preference would be having this introduced right after the > >> stable tag, giving it a full cycle of enforced testing before the next > >> stable tag. > >> > >> *But* I'm probably less vested in that outcome than some others, > >> and am happy to leave the call to the CryptoPkg (and other > >> affected) maintainers. > >> > >> / > >> Leif > >> > >>> -Original Message- > >>> From: Kinney, Michael D > >>
Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9
Hi Ken Do you have any additional feedback for the patch set? We are waiting for that since this is a feature needed for 202308 tag. Thank you Yao, Jiewen > -Original Message- > From: Michael Kubacki > Sent: Saturday, August 5, 2023 6:55 AM > To: devel@edk2.groups.io; Johnson, Brian ; Gao, > Liming ; llind...@qti.qualcomm.com; Kinney, > Michael D ; Li, Yi1 ; 'Andrew > Fish' ; Lautner, Kenneth > Cc: Yao, Jiewen ; Lu, Xiaoyu1 ; > Jiang, Guomin ; 'Gerd Hoffmann' > ; 'Ard Biesheuvel' ; LEE, > TERRY > Subject: Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > submodule to 3.0.9 > > Ken Lautner is helping test on some platforms. The size increase is > presenting a bit of a challenge at the moment, but he should be able to > share more feedback early next week. > > Regards, > Michael > > On 8/4/2023 4:54 PM, Brian J. Johnson wrote: > > Liming and Jiewen, > > > > I asked Terry Lee to give this patchset a spin, and it seemed to work > > well for our h/w use case. The size increase vs. OpenSSL 1.1.1n was > > noticeable, but workable. We're good with merging it. > > > > Brian J. Johnson > > HP Enterprise > > Misison-Critical Systems > > > > Original Message > > From: gaoliming via groups.io [mailto:gaoliming=byosoft.com...@groups.io] > > Sent: Friday, August 4, 2023 at 4:44 AM > > To: , , 'Kinney, > > Michael D' , 'Li, Yi1' , > > 'Andrew Fish' > > Cc: 'Yao, Jiewen' , 'Lu, Xiaoyu1' > > , 'Jiang, Guomin' , 'Gerd > > Hoffmann' , 'Ard Biesheuvel' > > > Subject: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > > submodule to 3.0.9 > > > > Hi, all > > We are near to the soft feature freeze for the stable tag 202308. > > Please give your opinion for this patch set to catch 202308 release. > > > > Now, Ard, Jiewen (Crypto Package Maintainer), Yi (Patch Contributor) > > opinion is to merge this patch set if no other comments in one week. > > > > Leif opinion is to agree with the package maintainer. > > > > All changes of this patch set are in CryptoPkg. So, I also agree > > with CryptoPkg maintainer. > > > > Thanks > > Liming > >> -邮件原件- > >> 发件人: devel@edk2.groups.io 代表 Leif Lindholm > >> 发送时间: 2023年8月3日 2:46 > >> 收件人: Kinney, Michael D ; > >> devel@edk2.groups.io; Gao, Liming ; Li, Yi1 > >> > >> 抄送: Yao, Jiewen ; Lu, Xiaoyu1 > >> ; Jiang, Guomin ; 'Gerd > >> Hoffmann' ; Andrew Fish (af...@apple.com) > >> > >> 主题: Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > >> submodule to 3.0.9 > >> > >> I am a little bit nervous about introducing this massive change so > >> late in the > >> cycle, > >> and am not sure whether any deferral of the soft freeze would be > >> sufficient to > >> change that. > >> My preference would be having this introduced right after the stable tag, > >> giving it a full cycle of enforced testing before the next stable tag. > >> > >> *But* I'm probably less vested in that outcome than some others, and am > >> happy > >> to leave the call to the CryptoPkg (and other affected) maintainers. > >> > >> / > >> Leif > >> > >>> -Original Message- > >>> From: Kinney, Michael D > >>> Sent: Wednesday, August 2, 2023 5:42 PM > >>> To: devel@edk2.groups.io; Gao, Liming ; Li, > >>> Yi1 > >>> > >>> Cc: Yao, Jiewen ; Lu, Xiaoyu1 > >> ; > >>> Jiang, Guomin ; 'Gerd Hoffmann' > >>> ; Andrew Fish (af...@apple.com) ; > >>> Leif Lindholm ; Kinney, Michael D > >>> > >>> Subject: RE: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > >>> submodule to 3.0.9 > >>> > >>> WARNING: This email originated from outside of Qualcomm. Please be wary > >>> of any links or attachments, and do not enable macros. > >>> > >>> Hi Liming, > >>> > >>> I have added Andrew and Leif to this thread so we can discuss > >>> if the release date need to be adjusted. > >>> > >>> Mike > >>> > >>> > >>>> -Original Message- > >>>> From: devel@edk2.groups.io On Behalf Of > >>> gaoliming > >>>> via groups.io > >>>> Sent: Wednesday, August 2, 2023 3:07 AM > >>>> To: devel@edk2.groups.io; Li, Yi1 > >
Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9
Ken Lautner is helping test on some platforms. The size increase is presenting a bit of a challenge at the moment, but he should be able to share more feedback early next week. Regards, Michael On 8/4/2023 4:54 PM, Brian J. Johnson wrote: Liming and Jiewen, I asked Terry Lee to give this patchset a spin, and it seemed to work well for our h/w use case. The size increase vs. OpenSSL 1.1.1n was noticeable, but workable. We're good with merging it. Brian J. Johnson HP Enterprise Misison-Critical Systems Original Message From: gaoliming via groups.io [mailto:gaoliming=byosoft.com...@groups.io] Sent: Friday, August 4, 2023 at 4:44 AM To: , , 'Kinney, Michael D' , 'Li, Yi1' , 'Andrew Fish' Cc: 'Yao, Jiewen' , 'Lu, Xiaoyu1' , 'Jiang, Guomin' , 'Gerd Hoffmann' , 'Ard Biesheuvel' Subject: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 Hi, all We are near to the soft feature freeze for the stable tag 202308. Please give your opinion for this patch set to catch 202308 release. Now, Ard, Jiewen (Crypto Package Maintainer), Yi (Patch Contributor) opinion is to merge this patch set if no other comments in one week. Leif opinion is to agree with the package maintainer. All changes of this patch set are in CryptoPkg. So, I also agree with CryptoPkg maintainer. Thanks Liming -邮件原件- 发件人: devel@edk2.groups.io 代表 Leif Lindholm 发送时间: 2023年8月3日 2:46 收件人: Kinney, Michael D ; devel@edk2.groups.io; Gao, Liming ; Li, Yi1 抄送: Yao, Jiewen ; Lu, Xiaoyu1 ; Jiang, Guomin ; 'Gerd Hoffmann' ; Andrew Fish (af...@apple.com) 主题: Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 I am a little bit nervous about introducing this massive change so late in the cycle, and am not sure whether any deferral of the soft freeze would be sufficient to change that. My preference would be having this introduced right after the stable tag, giving it a full cycle of enforced testing before the next stable tag. *But* I'm probably less vested in that outcome than some others, and am happy to leave the call to the CryptoPkg (and other affected) maintainers. / Leif -Original Message- From: Kinney, Michael D Sent: Wednesday, August 2, 2023 5:42 PM To: devel@edk2.groups.io; Gao, Liming ; Li, Yi1 Cc: Yao, Jiewen ; Lu, Xiaoyu1 ; Jiang, Guomin ; 'Gerd Hoffmann' ; Andrew Fish (af...@apple.com) ; Leif Lindholm ; Kinney, Michael D Subject: RE: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. Hi Liming, I have added Andrew and Leif to this thread so we can discuss if the release date need to be adjusted. Mike -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Wednesday, August 2, 2023 3:07 AM To: devel@edk2.groups.io; Li, Yi1 Cc: Yao, Jiewen ; Lu, Xiaoyu1 ; Jiang, Guomin ; 'Gerd Hoffmann' Subject: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 Yi: Thanks for your great work to update openssl 3.0. The commit message shows this patch set must catch edk2 202308 stable tag. Right? Edk2 202308 stable tag will start soft feature free from Aug 7th (next Monday). That means this patch set needs to pass code review in one week. Jiwen, Gerd: Can you give your comments for this patch set this week? If you need more time, I will raise the request to defer the soft feature freeze. Thanks Liming -邮件原件- 发件人: devel@edk2.groups.io 代表 Li, Yi 发送时间: 2023年7月28日 14:40 收件人: devel@edk2.groups.io 抄送: Yi Li ; Jiewen Yao ; Xiaoyu Lu ; Guomin Jiang ; Gerd Hoffmann 主题: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3466 According to https://www.OpenSSL.org/policies/releasestrat.html , OpenSSL Version 1.1.1 will be supported until 2023-09-11 (LTS). Need to upgrade OpenSsl to 3.0.9 before 1.1.1 support stopping. PR： https://github.com/tianocore/edk2/pull/4692 Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Gerd Hoffmann Gerd Hoffmann (15): CryptoPkg/openssl: update submodule to openssl-3.0.9 CryptoPkg/openssl: cleanup all openssl1.1.1 generated files and code CryptoPkg/openssl: update Openssl*.inf files for openssl 3.0 CryptoPkg/openssl: add openssl3 configure scripts CryptoPkg/openssl: UefiAsm.conf update for openssl 3.0 CryptoPkg/BaseCryptLib: no openssl deprecation warnings please CryptoPkg/BaseCryptLib: adapt CryptSm3.c to openssl 3.0 changes. CryptoPkg/BaseCryptLib: drop BIO_* dummy functions CryptoPkg/TlsLib: ERR_GET_FUNC is gone CryptoPkg/openssl: adapt rand_pool.c to openssl 3.0 changes CryptoPkg/openssl: move compiler_flags to buildinf.c CryptoPkg/openssl: store dummy update for openssl 3.0 CryptoPkg/openssl: adapt EcSm2Null.c for openssl 3.0
Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9
Liming and Jiewen, I asked Terry Lee to give this patchset a spin, and it seemed to work well for our h/w use case. The size increase vs. OpenSSL 1.1.1n was noticeable, but workable. We're good with merging it. Brian J. Johnson HP Enterprise Misison-Critical Systems Original Message From: gaoliming via groups.io [mailto:gaoliming=byosoft.com...@groups.io] Sent: Friday, August 4, 2023 at 4:44 AM To: , , 'Kinney, Michael D' , 'Li, Yi1' , 'Andrew Fish' Cc: 'Yao, Jiewen' , 'Lu, Xiaoyu1' , 'Jiang, Guomin' , 'Gerd Hoffmann' , 'Ard Biesheuvel' Subject: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 Hi, all We are near to the soft feature freeze for the stable tag 202308. Please give your opinion for this patch set to catch 202308 release. Now, Ard, Jiewen (Crypto Package Maintainer), Yi (Patch Contributor) opinion is to merge this patch set if no other comments in one week. Leif opinion is to agree with the package maintainer. All changes of this patch set are in CryptoPkg. So, I also agree with CryptoPkg maintainer. Thanks Liming -邮件原件- 发件人: devel@edk2.groups.io 代表 Leif Lindholm 发送时间: 2023年8月3日 2:46 收件人: Kinney, Michael D ; devel@edk2.groups.io; Gao, Liming ; Li, Yi1 抄送: Yao, Jiewen ; Lu, Xiaoyu1 ; Jiang, Guomin ; 'Gerd Hoffmann' ; Andrew Fish (af...@apple.com) 主题: Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 I am a little bit nervous about introducing this massive change so late in the cycle, and am not sure whether any deferral of the soft freeze would be sufficient to change that. My preference would be having this introduced right after the stable tag, giving it a full cycle of enforced testing before the next stable tag. *But* I'm probably less vested in that outcome than some others, and am happy to leave the call to the CryptoPkg (and other affected) maintainers. / Leif -Original Message- From: Kinney, Michael D Sent: Wednesday, August 2, 2023 5:42 PM To: devel@edk2.groups.io; Gao, Liming ; Li, Yi1 Cc: Yao, Jiewen ; Lu, Xiaoyu1 ; Jiang, Guomin ; 'Gerd Hoffmann' ; Andrew Fish (af...@apple.com) ; Leif Lindholm ; Kinney, Michael D Subject: RE: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. Hi Liming, I have added Andrew and Leif to this thread so we can discuss if the release date need to be adjusted. Mike -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Wednesday, August 2, 2023 3:07 AM To: devel@edk2.groups.io; Li, Yi1 Cc: Yao, Jiewen ; Lu, Xiaoyu1 ; Jiang, Guomin ; 'Gerd Hoffmann' Subject: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 Yi: Thanks for your great work to update openssl 3.0. The commit message shows this patch set must catch edk2 202308 stable tag. Right? Edk2 202308 stable tag will start soft feature free from Aug 7th (next Monday). That means this patch set needs to pass code review in one week. Jiwen, Gerd: Can you give your comments for this patch set this week? If you need more time, I will raise the request to defer the soft feature freeze. Thanks Liming -邮件原件- 发件人: devel@edk2.groups.io 代表 Li, Yi 发送时间: 2023年7月28日 14:40 收件人: devel@edk2.groups.io 抄送: Yi Li ; Jiewen Yao ; Xiaoyu Lu ; Guomin Jiang ; Gerd Hoffmann 主题: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3466 According to https://www.OpenSSL.org/policies/releasestrat.html , OpenSSL Version 1.1.1 will be supported until 2023-09-11 (LTS). Need to upgrade OpenSsl to 3.0.9 before 1.1.1 support stopping. PR： https://github.com/tianocore/edk2/pull/4692 Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Gerd Hoffmann Gerd Hoffmann (15): CryptoPkg/openssl: update submodule to openssl-3.0.9 CryptoPkg/openssl: cleanup all openssl1.1.1 generated files and code CryptoPkg/openssl: update Openssl*.inf files for openssl 3.0 CryptoPkg/openssl: add openssl3 configure scripts CryptoPkg/openssl: UefiAsm.conf update for openssl 3.0 CryptoPkg/BaseCryptLib: no openssl deprecation warnings please CryptoPkg/BaseCryptLib: adapt CryptSm3.c to openssl 3.0 changes. CryptoPkg/BaseCryptLib: drop BIO_* dummy functions CryptoPkg/TlsLib: ERR_GET_FUNC is gone CryptoPkg/openssl: adapt rand_pool.c to openssl 3.0 changes CryptoPkg/openssl: move compiler_flags to buildinf.c CryptoPkg/openssl: store dummy update for openssl 3.0 CryptoPkg/openssl: adapt EcSm2Null.c for openssl 3.0 CryptoPkg/TlsLib: use unsigned long for ErrorCode CryptoPkg/openssl: update CI config for openssl 3.0 Yi Li (14): CryptoPkg: Move all UEFI implement of openssl to OpensslStub CryptoPkg: use UEFI provider as default CryptoPkg: adapt 3.0
回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9
Hi, all We are near to the soft feature freeze for the stable tag 202308. Please give your opinion for this patch set to catch 202308 release. Now, Ard, Jiewen (Crypto Package Maintainer), Yi (Patch Contributor) opinion is to merge this patch set if no other comments in one week. Leif opinion is to agree with the package maintainer. All changes of this patch set are in CryptoPkg. So, I also agree with CryptoPkg maintainer. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > 发送时间: 2023年8月3日 2:46 > 收件人: Kinney, Michael D ; > devel@edk2.groups.io; Gao, Liming ; Li, Yi1 > > 抄送: Yao, Jiewen ; Lu, Xiaoyu1 > ; Jiang, Guomin ; 'Gerd > Hoffmann' ; Andrew Fish (af...@apple.com) > > 主题: Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > submodule to 3.0.9 > > I am a little bit nervous about introducing this massive change so late in the > cycle, > and am not sure whether any deferral of the soft freeze would be sufficient to > change that. > My preference would be having this introduced right after the stable tag, > giving it a full cycle of enforced testing before the next stable tag. > > *But* I'm probably less vested in that outcome than some others, and am > happy > to leave the call to the CryptoPkg (and other affected) maintainers. > > / > Leif > > > -Original Message- > > From: Kinney, Michael D > > Sent: Wednesday, August 2, 2023 5:42 PM > > To: devel@edk2.groups.io; Gao, Liming ; Li, Yi1 > > > > Cc: Yao, Jiewen ; Lu, Xiaoyu1 > ; > > Jiang, Guomin ; 'Gerd Hoffmann' > > ; Andrew Fish (af...@apple.com) ; > > Leif Lindholm ; Kinney, Michael D > > > > Subject: RE: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > > submodule to 3.0.9 > > > > WARNING: This email originated from outside of Qualcomm. Please be wary > > of any links or attachments, and do not enable macros. > > > > Hi Liming, > > > > I have added Andrew and Leif to this thread so we can discuss > > if the release date need to be adjusted. > > > > Mike > > > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of > > gaoliming > > > via groups.io > > > Sent: Wednesday, August 2, 2023 3:07 AM > > > To: devel@edk2.groups.io; Li, Yi1 > > > Cc: Yao, Jiewen ; Lu, Xiaoyu1 > > > ; Jiang, Guomin ; 'Gerd > > > Hoffmann' > > > Subject: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > > > submodule to 3.0.9 > > > > > > Yi: > > > Thanks for your great work to update openssl 3.0. The commit message > > > shows this patch set must catch edk2 202308 stable tag. Right? > > > Edk2 202308 stable tag will start soft feature free from Aug 7th (next > > > Monday). That means this patch set needs to pass code review in one > > > week. > > > > > > Jiwen, Gerd: > > > Can you give your comments for this patch set this week? If you need > > > more time, I will raise the request to defer the soft feature freeze. > > > > > > Thanks > > > Liming > > > > -邮件原件- > > > > 发件人: devel@edk2.groups.io 代表 Li, Yi > > > > 发送时间: 2023年7月28日 14:40 > > > > 收件人: devel@edk2.groups.io > > > > 抄送: Yi Li ; Jiewen Yao ; > > > Xiaoyu > > > > Lu ; Guomin Jiang ; > > Gerd > > > > Hoffmann > > > > 主题: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL > > submodule to > > > > 3.0.9 > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3466 > > > > > > > > According to https://www.OpenSSL.org/policies/releasestrat.html, > > > > OpenSSL Version 1.1.1 will be supported until 2023-09-11 (LTS). > > > > Need to upgrade OpenSsl to 3.0.9 before 1.1.1 support stopping. > > > > > > > > PR： https://github.com/tianocore/edk2/pull/4692 > > > > > > > > Cc: Jiewen Yao > > > > Cc: Xiaoyu Lu > > > > Cc: Guomin Jiang > > > > Cc: Gerd Hoffmann > > > > Gerd Hoffmann (15): > > > > CryptoPkg/openssl: update submodule to openssl-3.0.9 > > > > CryptoPkg/openssl: cleanup all openssl1.1.1 generated files and code > > > > CryptoPkg/openssl: update Openssl*.inf files for openssl 3.0 > > > > CryptoPkg/openssl: add openssl3 configure scripts > > > > CryptoPkg/openssl: UefiAsm.conf update for openssl 3.0 > > > > CryptoPkg/BaseCryptLib: no openssl deprecation warnings pl
回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9
Yi: Thanks for your great work to update openssl 3.0. The commit message shows this patch set must catch edk2 202308 stable tag. Right? Edk2 202308 stable tag will start soft feature free from Aug 7th (next Monday). That means this patch set needs to pass code review in one week. Jiwen, Gerd: Can you give your comments for this patch set this week? If you need more time, I will raise the request to defer the soft feature freeze. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Li, Yi > 发送时间: 2023年7月28日 14:40 > 收件人: devel@edk2.groups.io > 抄送: Yi Li ; Jiewen Yao ; Xiaoyu > Lu ; Guomin Jiang ; Gerd > Hoffmann > 主题: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to > 3.0.9 > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3466 > > According to https://www.OpenSSL.org/policies/releasestrat.html, > OpenSSL Version 1.1.1 will be supported until 2023-09-11 (LTS). > Need to upgrade OpenSsl to 3.0.9 before 1.1.1 support stopping. > > PR： https://github.com/tianocore/edk2/pull/4692 > > Cc: Jiewen Yao > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Gerd Hoffmann > Gerd Hoffmann (15): > CryptoPkg/openssl: update submodule to openssl-3.0.9 > CryptoPkg/openssl: cleanup all openssl1.1.1 generated files and code > CryptoPkg/openssl: update Openssl*.inf files for openssl 3.0 > CryptoPkg/openssl: add openssl3 configure scripts > CryptoPkg/openssl: UefiAsm.conf update for openssl 3.0 > CryptoPkg/BaseCryptLib: no openssl deprecation warnings please > CryptoPkg/BaseCryptLib: adapt CryptSm3.c to openssl 3.0 changes. > CryptoPkg/BaseCryptLib: drop BIO_* dummy functions > CryptoPkg/TlsLib: ERR_GET_FUNC is gone > CryptoPkg/openssl: adapt rand_pool.c to openssl 3.0 changes > CryptoPkg/openssl: move compiler_flags to buildinf.c > CryptoPkg/openssl: store dummy update for openssl 3.0 > CryptoPkg/openssl: adapt EcSm2Null.c for openssl 3.0 > CryptoPkg/TlsLib: use unsigned long for ErrorCode > CryptoPkg/openssl: update CI config for openssl 3.0 > > Yi Li (14): > CryptoPkg: Move all UEFI implement of openssl to OpensslStub > CryptoPkg: use UEFI provider as default > CryptoPkg: adapt 3.0 change in SslNull.c > CryptoPkg: Add instrinsics to support building openssl3 on IA32 > windows > CryptoPkg: disable C4133 warning in openssl libraries > CryptoPkg: Align with 4096 when build with OpensslFullAccel > CryptoPkg: Enable memcpy sys call in RISCV64 build > CryptoPkg: add missing gcc instructions > CryptoPkg: add define of maximum unsigned size_t > CryptoPkg: add implemention of _ftol2_sse() to avoid build error > CryptoPkg: add more dummy implement of openssl for size optimization > CryptoPkg: run configure.py to update all generated files > CryptoPkg: remove strcmp to syscall > CryptoPkg: remove BN and EC accel for size optimization > > CryptoPkg/CryptoPkg.ci.yaml | 54 +- > CryptoPkg/CryptoPkg.dec |4 + > CryptoPkg/CryptoPkg.dsc | 12 +- > .../Library/BaseCryptLib/Hash/CryptSm3.c | 14 +- > .../Library/BaseCryptLib/InternalCryptLib.h |2 + > .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 36 +- > .../SysCall/UnitTestHostCrtWrapper.c | 25 - > CryptoPkg/Library/Include/CrtLibSupport.h |1 + > .../Library/Include/openssl/opensslconf.h | 333 - > .../IntrinsicLib/Ia32/MathDivModU64x64.c | 23 + > .../Library/IntrinsicLib/Ia32/MathDivS64x64.c | 22 + > .../Library/IntrinsicLib/Ia32/MathDivU64x64.c | 22 + > .../Library/IntrinsicLib/Ia32/MathFtol.c | 12 + > .../Library/IntrinsicLib/Ia32/MathLldiv.asm | 203 + > .../Library/IntrinsicLib/Ia32/MathModU64x64.c | 26 + > .../Library/IntrinsicLib/Ia32/MathUlldiv.asm | 157 + > .../Library/IntrinsicLib/Ia32/MathUlldvrm.asm | 184 + > .../Library/IntrinsicLib/Ia32/MathUllrem.asm | 163 + > .../Library/IntrinsicLib/IntrinsicLib.inf | 11 +- > .../Library/IntrinsicLib/MemoryIntrinsics.c |9 - > .../IA32/crypto/modes/ghash-x86.nasm | 700 -- > .../OpensslLib/IA32/crypto/sha/sha1-586.nasm | 1394 --- > .../IA32/crypto/sha/sha256-586.nasm | 3364 --- > .../IA32/crypto/sha/sha512-586.nasm | 579 -- > .../IA32Gcc/crypto/modes/ghash-x86.S | 703 -- > .../OpensslLib/IA32Gcc/crypto/sha/sha1-586.S | 1389 --- > .../IA32Gcc/crypto/sha/sha256-586.S | 3356 --- > .../IA32Gcc/crypto/sha/sha512-586.S | 574 -- > .../Library/OpensslLib/OpenSSL-HOWTO.txt |4 +- > .../OpensslGen/IA32-GCC/crypto/aes/aes-586.S | 3320 +++ > .../IA32-GCC}/crypto/aes/aesni-x86.S | 141 +- > .../IA32-GCC}/crypto/aes/vpaes-x86.S | 92 +- > .../OpensslGen/IA32-GCC/crypto/bn/bn-586.S| 1572 > .../OpensslGen/IA32-GCC/crypto/bn/co-586.S| 1290 +++ > .../OpensslGen/IA32-GCC/crypto/bn/x86-gf2m.S | 374 + > .../OpensslGen/IA32-GCC/crypto/bn/x86-mont.S | 494 + >
