[389-devel] Please review: Issue #49161 memberof fails if group is moved into scop - CI test

[Amita Sharma]

Hi Team,

 https://pagure.io/389-ds-base/pull-request/49852 for CI test.

Thanks,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/5K4M5NJGPTR5UXLWWRUCLBXGVJXQKZQY/

[389-devel] Re: Improve the demo objects from install

[Amita Sharma]

Again a wonderful job William. I always feel proud to work with you and
This change surely deserves outstanding support.

I am thinking, we can publicize this by doing articles on Fedora Magazine
and Commblog.
Also, we should be mentioning about this change in one of our diversity
presentations to inspire others.

firstyear++ :)

Regards,
Ami

On Fri, Jan 12, 2018 at 10:07 AM, William Brown  wrote:

> On Thu, 2018-01-11 at 16:40 +, Brian (bex) Exelbierd wrote:
> > > Hi all,
> > >
> > > It's time that I'm looking at:
> > > https://pagure.io/389-ds-base/issue/49425
> > >
> > > There are some great reasons to freshen up the default objects we
> > > install. The current design isn't really reflective of modern
> > > directory
> > > usage, the aci's are not "great" examples, and it's not a super-
> > > useful
> > > foundation out of the box.
> > >
> > > As a result, I have some improvements I want to make here. Let's
> > > start
> > > with the simple ones:
> > >
> > > Tree layout:
> > >
> > > dc=example,dc=com
> > > cn=389_ds_system,dc=example,dc=com
> > > ou=people,dc=example,dc=com
> > > ou=groups,dc=example,dc=com
> > > ou=services,dc=example,dc=com
> > > ou=permissions,dc=example,dc=com
> > >
> > > This is the structure I want us to ship with: groups, people,
> > > service
> > > accounts, and permission groups. I additionally add an
> > > nscontainer|ldapsubentry 389_ds_system, which is the "hidden"
> > > config
> > > area that we could start to use for things like pwpolicy, keepalive
> > > entries, replication service accounts and more. I don't think
> > > anything
> > > here is too controversial :)
> > >
> > > Next, demo objects!
> > >
> > > uid=demo_user,ou=people,dc=example,dc=com
> > > cn=demo_group,ou=groups,dc=example,dc=com
> > >
> > > These can show a user and group, and lets the cli tools have
> > > something
> > > to show, and how they can be integrated with *acis*.
> > >
> > > Again, nothing complex :)
> > >
> > > Permissions! This is where we start to add aci's and get's a bit
> > > fun.
> > >
> > > I want to ship with a few useful permisisons and acis. The thinking
> > > is:
> > >
> > > * anonymous read to public ou=People and user attributes (ie Sssd
> > > should work oob)
> > > * anonymous read to groups attributes (ie Sssd should work oob)
> > > * a permission group where members can alter group members
> > > * a permission group where members can alter users
> > > * a permission group where members can reset user passwords
> > > * a permission group where members can create/delete users
> > > * a permission group where members can create/delete groups
> > >
> > > This is a pretty simple set of acis, but I want them to show how
> > > delegation of permissions can be done safely, and act as examples
> > > and
> > > templates for admins - as well as just being simple and useful for
> > > small deployments out of the box!
> > >
> > >
> > > Now, this is the final suggestion: I'd like to add some extra
> > > schema
> > > and change user objects by default that we create.
> > >
> > > I would like to add:
> > >
> > > nsPerson
> > >
> > > I would like them to contain the following:
> > >
> > > nsPerson:
> > > MAY: userPassword, telephoneNumber, seeAlso, description, legalName
> > > MUST: cn, displayName
> >
> > I am also very in favor of this change.  I'd love to see this highly
> > advertised once it merges as I think it speaks very highly of how to
> > both be inclusive and move great software forward while continuing to
> > be extremely useful to users.
>
> Thank you that's great to hear! I've just pushed the patch up now for
> our 1.4.0 server support this. :)
>
> >
> > regards,
> >
> > bex
> >
> > >
> > >
> > > This is a shift from the traditional person object and there is a
> > > really good reason -
> > > internationalisation. (we replace sn with legalName and make it
> > > may,
> > > and add
> > > displayName).
> > >
> > >
> > > The current person account *requires* the sn field. However surname
> > > *does not*
> > > translate across many cultural boundaries. Some people have
> > > multiple
> > > surnames, some
> > > have no concept of a surname.
> > >
> > > What people do have is a *legal name* which is their full name -
> > > for me
> > > that would be
> > > givennames + surname. For others just their single name. having a
> > > single legalName
> > > field correctly represents this case. And additionally many
> > > applications don't
> > > even need a legal name, *only* a displayName of the users choice.
> > >
> > > The second reason is identity related. There are many people whos
> > > chosen name
> > > for the world (displayName) differs from their actual legal name.
> > > As a
> > > result
> > > having a displayname field where the user can *choose* how they are
> > > represented
> > > is highly important. Consider divorced people (who haven't yet
> > > changed
> > > legal names)
> > > victims of crime (who need to hide their identity) and more.
> > >
> > > 

[389-devel] Please Review: Issue 48118 - Add CI test case

[Amita Sharma]

Hello,

Please review my patch for - Add CI test for Replication test suit

https://pagure.io/389-ds-base/issue/48118

https://pagure.io/389-ds-base/issue/raw/files/67774c3468e49bb0457d1b36b7de325d2e1fb0b008e66e076e6a8031ec6c8074-0001-Ticket-48118-Add-CI-test-case.patch

Thanks & Regards,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please Review: Issue 49431 - Add CI test for Replication Modrdn

[Amita Sharma]

Hello,

Please review my patch for - Add CI test for Replication test suit

*https://pagure.io/389-ds-base/issue/49431
*

*https://pagure.io/389-ds-base/issue/raw/files/66d1a2a00677119eed6f6d997b41c18a0030d0518412b627bc75180e6874d00b-0001-Ticket-49431-Add-CI-test-case.patch
*

Thanks & Regards,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please Review: Issue 49443 - Add CI test for filter

[Amita Sharma]

Hello,

Please review my patch for - Add CI test for filter test suit

https://pagure.io/389-ds-base/issue/49443

https://pagure.io/389-ds-base/issue/raw/files/554e1fccfc2caca9b4e1dcecc0757040b6770fcc9ae61e28536d45de54885607-0001-Issue-49443-Add-CI-test-case.patch

Thanks & Regards,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please Review: Issue 49455 - Add tests to monitor test suit

[Amita Sharma]

Hello,

Please review my patch for - Add tests to monitor test suit

https://pagure.io/389-ds-base/issue/49455

https://pagure.io/389-ds-base/issue/raw/files/848db9c6c4e65b15c5a0833aa327cb88b5729afabedfac346cfd0587a7c9c864-0001-Ticket-49455-Add-tests-to-monitor-test-suit.patch


Thanks & Regards,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please Review: Issue 3 - Python 3 compatibility

[Amita Sharma]

Hello,

Please review my patch for memberof_plugin tests

https://pagure.io/lib389/issue/3

https://pagure.io/lib389/issue/raw/files/1311ab7378f555a12fafb39acc2c507155d0ef65d7751ec2d47bd8f5871b0964-0001-Ticket-lib389-Python-3-support-for-memberof-plugin-t.patch


Thanks & Regards,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please Review: Issue 3 - Python 3 compatibility

[Amita Sharma]

Hello,

Please review my patch for password - pwdPolicy_controls_test.

https://pagure.io/lib389/issue/3

https://pagure.io/lib389/issue/raw/files/d57761b96039e9f19dcad994f6100e4758436a07b35c49afe82f57073a1c50f4-0001-Issue-lib389-3-Python-3-support-for-pwdPolicy_contro.patch

Thanks & Regards,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please Review: Issue 49381 - Refactor filter test suite docstrings

[Amita Sharma]

Hello,

Please review my patch for ACL test suite docstrings.

https://pagure.io/389-ds-base/issue/49381

https://pagure.io/389-ds-base/issue/raw/files/874af7491286df4e6699b49872902a5b0f7a1f73c3572b56704f4001365461a3-0001-Issue-49381-Refactor-filter-test-suite-docstrings.patch


Thanks & Regards,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please Review: Issue 49381 - Refactor ACL test suite docstrings

[Amita Sharma]

Hello,

Please review my patch for ACL test suite docstrings.

https://pagure.io/389-ds-base/issue/49381

https://pagure.io/389-ds-base/issue/raw/files/b670abf315e22b2695a6a7796162e0ffa83d712fd4cc39690634b89cf6880d1b-0001-Issue-49381-Refactor-ACL-test-suite-docstrings.patch

Thanks & Regards,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 47840-Add docstrings to setup and use generate_ds_params

[Amita Sharma]

https://pagure.io/389-ds-base/issue/47840

https://pagure.io/389-ds-base/issue/raw/files/eaa6e56273ea3713584e252043017927240179e518d23f86000d79378e32-0001-Issue-47840-Add-docstrings-to-setup.patch

Thanks,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] [Review Request] - Setup Test

[Amita Sharma]

Hello,

I have made changes in setup test suit and uploaded patch on ticket [1].
Please review.

Thanks,
Amita

[1]. https://pagure.io/389-ds-base/issue/47840
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Review Request - https://pagure.io/389-ds-base/issue/48056

[Amita Sharma]

Hello Everyone,

I have uploaded a patch which includes doc strings for test cases in
basic test suit [1]. Please review the same and share your feedback.

Thanks & Regards,
Amita

[1]. https://pagure.io/389-ds-base/issue/48056
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

Re: [389-devel] Review Request for test cases

[Amita Sharma]

On 08/06/2015 06:13 PM, Mark Reynolds wrote:



On 08/06/2015 06:24 AM, Amita Sharma wrote:

Hi All,

I have automated few test cases for 
https://fedorahosted.org/389/attachment/ticket/47910/ .
Here is my patch :: 
https://fedorahosted.org/389/attachment/ticket/47910/0001-Ticket-47910-allow-logconv.pl-S-E-switches-to-work-e.2.patch


I request for your valuable feedback.

Hi Amita,

Thanks for writing a lib389 test!  I do have some comments, see below...

In function log_dir:

First, you are using the DATA directory for temporary storage, you 
should be using the TMP dir - this way the contents are removed for 
you before the next test runs.


ldif_file = topology.standalone.getDir(__file__, TMP_DIR) + 
ticket47910.ldif


-
Note, for future tests, if you need to store files permanently, they 
should be in subdirectories of DATA:


getDir(__file__, DATA_DIR) + /ticket47910/ticket47910.ldif
-

Next in log_dir

You are generating an ldif file, and then importing it for each test 
function.  This seems excessive for trying to generate logging.   The 
only thing that is logged is the adding of the task entry.  So like 6 
lines of logging.  It would be easier/faster to just do a single 
search.  You can also disable access log buffering so you don't have 
to wait for the logging to be written to disk.


There is a shortcut function for setting access log buffering:

topology.standalone.setAccessLogBuffering (False)

You still need to sleep for 1 second, but it's a lot better than 50 
seconds.


The rest looks good.

Thanks Mark.

Here is the update patch :: 
https://fedorahosted.org/389/attachment/ticket/47910/0001-Ticket-47910-allow-logconv.pl-S-E-switches-to-work.patch


Regards,
Amita


Thanks,
Mark


Thanks  Regards,
Amita
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel




--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel


--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Review Request for test cases

[Amita Sharma]

Hi All,

I have automated few test cases for 
https://fedorahosted.org/389/attachment/ticket/47910/ .
Here is my patch :: 
https://fedorahosted.org/389/attachment/ticket/47910/0001-Ticket-47910-allow-logconv.pl-S-E-switches-to-work-e.2.patch


I request for your valuable feedback.

Thanks  Regards,
Amita
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel