Re: [Heads-up] libical 3.0.0 to reach rawhide, replacing libical-glib
On Tue, 14 Nov 2017 08:27:28 +0100, Milan Crha wrote: > Hi, > the sum of changes is part of the release notes, which can be found > here: > https://github.com/libical/libical/releases Would be great, if such a document were included within the package. > > vcal_manager.c: In function 'vcal_manager_event_dump': > > vcal_manager.c:398:30: warning: implicit declaration of function > > 'icaltime_from_timet'; did you mean 'icaltime_as_timet'? [-Wimplicit- > > function-declaration] > > icalproperty_vanew_dtstamp(icaltime_from_timet(time(NULL), TRUE), > > (void*)0)); > > In your case replace >icaltime_from_timet() > with >icaltime_from_timet_with_zone() > where the last argument, the zone to use, will be NULL. Oh! So they only removed a method they could have kept as a wrapper call to the new method. Interestingly, in the headers in libical-devel.x86_64 2.0.0-12.fc27 both functions exist already and no deprecation warning in there. Thanks. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: [Heads-up] libical 3.0.0 to reach rawhide, replacing libical-glib
On Mon, 2017-11-13 at 10:01 -0800, Kevin Fenzi wrote: > Orage (the Xfce calendar app) is also broken if you have time to take a > look: > > https://bugzilla.redhat.com/show_bug.cgi?id=1512302 > https://bugzilla.xfce.org/show_bug.cgi?id=13997 Hi, sure, I'll reply on the Red Hat bug. Bye, Milan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: [Heads-up] libical 3.0.0 to reach rawhide, replacing libical-glib
On Tue, 2017-11-14 at 01:36 +0100, Michael Schwendt wrote: > Dunno yet what's the reason. Haven't had a look at it except for unpacking > libical-devel in hope that its %doc section would contain a file that sums > up the API changes. No such file in there. And the "Using Libical" guide > claims it's from 2001, but comes with a fresh timestamp and doesn't tell > about the changes either. Hi, the sum of changes is part of the release notes, which can be found here: https://github.com/libical/libical/releases > vcal_manager.c: In function 'vcal_manager_event_dump': > vcal_manager.c:398:30: warning: implicit declaration of function > 'icaltime_from_timet'; did you mean 'icaltime_as_timet'? [-Wimplicit- > function-declaration] > icalproperty_vanew_dtstamp(icaltime_from_timet(time(NULL), TRUE), > (void*)0)); In your case replace icaltime_from_timet() with icaltime_from_timet_with_zone() where the last argument, the zone to use, will be NULL. Bye, Milan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: [Heads-up] libical 3.0.0 to reach rawhide, replacing libical-glib
On Mon, 13 Nov 2017 15:04:55 +0100, Milan Crha wrote: > > The upgrade seems to be API incompatible, so more than rebuilding > > dependencies is necessary. > > Hi, > that's true. libical upstream removed some deprecated symbols, most > notably icaltimetype::is_utc. Dunno yet what's the reason. Haven't had a look at it except for unpacking libical-devel in hope that its %doc section would contain a file that sums up the API changes. No such file in there. And the "Using Libical" guide claims it's from 2001, but comes with a fresh timestamp and doesn't tell about the changes either. libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../.. -I../../../src -I../../../src/common -I../../../src/common -I../../../src/gtk -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 -pthread -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -Wno-unused-function -Wno-pointer-sign -Wall -I/usr/include/enchant -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -c plugin.c -o vcalendar_la-plugin.o >/dev/null 2>&1 vcal_manager.c: In function 'vcal_manager_event_dump': vcal_manager.c:398:30: warning: implicit declaration of function 'icaltime_from_timet'; did you mean 'icaltime_as_timet'? [-Wimplicit-function-declaration] icalproperty_vanew_dtstamp(icaltime_from_timet(time(NULL), TRUE), (void*)0)); ^~~ icaltime_as_timet vcal_manager.c:398:30: error: incompatible type for argument 1 of 'icalproperty_vanew_dtstamp' In file included from vcal_manager.c:35:0: /usr/include/libical/ical.h:3306:35: note: expected 'struct icaltimetype' but argument is of type 'int' LIBICAL_ICAL_EXPORT icalproperty *icalproperty_vanew_dtstamp(struct icaltimetype v, ...); ^~ vcal_manager.c:426:30: error: incompatible type for argument 1 of 'icalproperty_vanew_created' icalproperty_vanew_created(icaltime_from_timet(time(NULL), TRUE), (void*)0)); ^~~ In file included from vcal_manager.c:35:0: /usr/include/libical/ical.h:3246:35: note: expected 'struct icaltimetype' but argument is of type 'int' LIBICAL_ICAL_EXPORT icalproperty *icalproperty_vanew_created(struct icaltimetype v, ...); ^~ vcal_manager.c:428:35: error: incompatible type for argument 1 of 'icalproperty_vanew_lastmodified' icalproperty_vanew_lastmodified(icaltime_from_timet(time(NULL), TRUE), (void*)0)); ^~~ In file included from vcal_manager.c:35:0: /usr/include/libical/ical.h:3371:35: note: expected 'struct icaltimetype' but argument is of type 'int' LIBICAL_ICAL_EXPORT icalproperty *icalproperty_vanew_lastmodified(struct icaltimetype v, ...); ^~~ vcalendar.c: In function 'create_meeting_from_message_cb_ui': vcalendar.c:160:54: warning: implicit declaration of function 'icaltime_from_timet'; did you mean 'icaltime_as_timet'? [-Wimplicit-function-declaration] gchar *dtstart = g_strdup(icaltime_as_ical_string(icaltime_from_timet(t, FALSE))); ^~~ icaltime_as_timet vcalendar.c:160:54: error: incompatible type for argument 1 of 'icaltime_as_ical_string' In file included from vcalendar.c:30:0: /usr/include/libical/ical.h:171:33: note: expected 'const struct icaltimetype' but argument is of type 'int' LIBICAL_ICAL_EXPORT const char *icaltime_as_ical_string(const struct icaltimetype tt); ^~~ vcalendar.c:161:52: error: incompatible type for argument 1 of 'icaltime_as_ical_string' gchar *dtend = g_strdup(icaltime_as_ical_string(icaltime_from_timet(t2, FALSE))); ^~~ In file included from vcalendar.c:30:0: /usr/include/libical/ical.h:171:33: note: expected 'const struct icaltimetype' but argument is of type 'int' LIBICAL_ICAL_EXPORT const char *icaltime_as_ical_string(const struct icaltimetype tt); ^~~ make[5]: *** [Makefile:666: vcalendar_la-vcal_manager.lo] Error 1 ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedor
Re: [Heads-up] libical 3.0.0 to reach rawhide, replacing libical-glib
On 11/13/2017 06:04 AM, Milan Crha wrote: > On Mon, 2017-11-13 at 14:47 +0100, Michael Schwendt wrote: >> The upgrade seems to be API incompatible, so more than rebuilding >> dependencies is necessary. > > Hi, > that's true. libical upstream removed some deprecated symbols, most > notably icaltimetype::is_utc. It's replaced with icaltime_is_utc() > function (available for a long time) and instead of writing to > icaltimetype::is_utc one should set the timezone properly, thus when it > had been set to 1 the icaltimetype::zone should be > icaltimezone_get_utc_timezone(), when set to 0, then to something else. > >> Claws Mail doesn't rebuild. > > I do not see that failed build in koji, do you have a build log from > there, please? I can help with patches, as I already did with > kdepimlibs (a bug filled, patch attached). I do not have commit rights > for all those still failing packages, thus my help ability is slightly > limited. Orage (the Xfce calendar app) is also broken if you have time to take a look: https://bugzilla.redhat.com/show_bug.cgi?id=1512302 https://bugzilla.xfce.org/show_bug.cgi?id=13997 kevin signature.asc Description: OpenPGP digital signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: [Heads-up] libical 3.0.0 to reach rawhide, replacing libical-glib
On Mon, 2017-11-13 at 14:47 +0100, Michael Schwendt wrote: > The upgrade seems to be API incompatible, so more than rebuilding > dependencies is necessary. Hi, that's true. libical upstream removed some deprecated symbols, most notably icaltimetype::is_utc. It's replaced with icaltime_is_utc() function (available for a long time) and instead of writing to icaltimetype::is_utc one should set the timezone properly, thus when it had been set to 1 the icaltimetype::zone should be icaltimezone_get_utc_timezone(), when set to 0, then to something else. > Claws Mail doesn't rebuild. I do not see that failed build in koji, do you have a build log from there, please? I can help with patches, as I already did with kdepimlibs (a bug filled, patch attached). I do not have commit rights for all those still failing packages, thus my help ability is slightly limited. Bye, Milan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: [Heads-up] libical 3.0.0 to reach rawhide, replacing libical-glib
On Wed, 01 Nov 2017 12:26:12 +0100, Milan Crha wrote: > Hello, > I'd like to give a heads up about a plan to update libical to its 3.0.0 > release in rawhide once I figure out some details about its build. This > release also obsoletes libical-glib package, the project had been added > into libical itself. > > I currently plan to push the update on Monday, November 6th. The upgrade seems to be API incompatible, so more than rebuilding dependencies is necessary. Claws Mail doesn't rebuild. And since texlive is waiting for a rebuild due to poppler SONAME breakage, temporarily one would need to set %build_manual to 0 in claws-mail.spec file. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
[Heads-up] libical 3.0.0 to reach rawhide, replacing libical-glib
Hello, I'd like to give a heads up about a plan to update libical to its 3.0.0 release in rawhide once I figure out some details about its build. This release also obsoletes libical-glib package, the project had been added into libical itself. I currently plan to push the update on Monday, November 6th. The list of dependencies according to: # dnf repoquery --whatrequires libical-devel --alldeps follows: evolution-data-server-devel libical-glib-devel kf5-kcalendarcore-devel maya-calendar-devel I have commit rights only for the first two, where the second is to be obsoleted anyway. The list of packages using libical is much longer: # dnf repoquery --whatrequires libical --alldeps akonadi-calendar-tools akonadiconsole almanah asterisk-calendar bijiben blogilo bluez-obexd cairo-dock-plug-ins-base california calligra-plan-libs claws-mail-plugins-vcalendar cyrus-imapd cyrus-imapd-utils digikam digikam-libs evolution evolution-bogofilter evolution-data-server evolution-data-server-tests evolution-ews evolution-mapi evolution-pst evolution-spamassassin gnokii gnome-calendar gnome-shell gnome-todo kalarm kdepim-addons kdepim-runtime kdepim-runtime-libs kdepimlibs kf5-akonadi-calendar kf5-akonadi-search kf5-calendarsupport kf5-eventviews kf5-incidenceeditor kf5-kalarmcal kf5-kblog kf5-kcalendarcore kf5-kcalendarutils kf5-ktnef kf5-messagelib kmail kmail-libs kmymoney knotes-libs korganizer korganizer-libs libical-glib libkgapi libkolab libopensync-plugin-evolution2 maya-calendar openchange-client orage osmo python2-kolab renku syncevolution syncevolution-libs syncevolution-libs-akonadi wingpanel-indicator-datetime zanshin I know they get the dependency mostly due to using one or more of the packages from the first list, but I guess it will be safer to rebuild them too. I have commit rights to many of those, but not to all, thus I'd need help with rebuilds from the respective maintainers, co-maintainers or proven packager(s), once I push the libical 3.0.0 to the rawhide. Bye, Milan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
