Re: Autoclosure of review requests?
On Fri, Jun 26, 2020 at 12:07 PM Mattia Verga via devel wrote: > > Ben, the review-stats app is ready to do some automatic "cleanup": > > https://pagure.io/fedora-infra/review_stats/pull-request/6 > This looks awesome! > The Pull Request was merged in the master branch, but I have not yet > deployed into production. I'm waiting for the staging environment to be > available again after the datacenter move and I would like to do some > testing dry run before actually move the code into production. > > But I can also do the big step and simply deploy it into production and > let the script do only some dry runs before enable the real cleanup. > Shall I? > We've gone this long without addressing it, I don't think it will hurt to wait until after the datacenter move so you can do some dry runs in staging. -- Ben Cotton He / Him / His Senior Program Manager, Fedora & CentOS Stream Red Hat TZ=America/Indiana/Indianapolis ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Autoclosure of review requests?
Il 26/06/20 16:27, Ben Cotton ha scritto: > > Nope! The lukewarm reaction and subsequent *guestures at the state > of the world* moved this to the bottom of the stack. It's still on my > todo list for some point in the future. > Ben, the review-stats app is ready to do some automatic "cleanup": https://pagure.io/fedora-infra/review_stats/pull-request/6 The Pull Request was merged in the master branch, but I have not yet deployed into production. I'm waiting for the staging environment to be available again after the datacenter move and I would like to do some testing dry run before actually move the code into production. But I can also do the big step and simply deploy it into production and let the script do only some dry runs before enable the real cleanup. Shall I? Mattia ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Autoclosure of review requests?
On Fri, Jun 26, 2020 at 9:03 AM Robert-André Mauchin wrote: > > Any news on that? Nope! The lukewarm reaction and subsequent *guestures at the state of the world* moved this to the bottom of the stack. It's still on my todo list for some point in the future. > Dropping requests on the last comment date, not last > activity, as some CC/Un-assigning may happen well after the real bug activity. > That's a good point. -- Ben Cotton He / Him / His Senior Program Manager, Fedora & CentOS Stream Red Hat TZ=America/Indiana/Indianapolis ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Autoclosure of review requests?
On Monday, 24 February 2020 23:04:26 CEST Ben Cotton wrote: > In the weekly Fedora program update that I publish on > communityblog.fedoraproject.org, I have started to include a count of the > open package review requests. As of this moment, there are ~1300 open > review requests. Some of these were opened in 2006. > > The usual Bugzilla housekeeping (branching, EOL closure, etc) explicitly > excludes review request bugs. Having a large number of open, ancient review > requests isn't exactly harmful, but it's not very helpful either. > > Before I make a proposal to FPC, I thought I'd open a conversation here. > What does a reasonable cleanup of review requests look like? > > My initial thought is to close all review requests that were opened >2 > years ago, to be performed at the EOL closure for each release. Any news on that? Dropping requests on the last comment date, not last activity, as some CC/Un-assigning may happen well after the real bug activity. There is around 500 "old" bugs which are still "New" or Unassigned from my Bugzilla searches. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Autoclosure of review requests?
Il 24/02/20 23:04, Ben Cotton ha scritto: > In the weekly Fedora program update that I publish on > communityblog.fedoraproject.org, I have started to include a count of the > open package review requests. As of this moment, there are ~1300 open review > requests. Some of these were opened in 2006. Have a look at https://mattia.fedorapeople.org/review_stats/ These pages were generated by the script at https://pagure.io/Fedora-Infra/review_stats which should replace (?) the actual script that generates https://fedoraproject.org/PackageReviewStatus/ In general, both the old and new pages can give you a hint of why a review ticket is stuck. The newer script hides less tickets than the older. Mattia___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Autoclosure of review requests?
On Mon, Feb 24, 2020 at 05:04:26PM -0500, Ben Cotton wrote: > The usual Bugzilla housekeeping (branching, EOL closure, etc) explicitly > excludes review request bugs. Having a large number of open, ancient review > requests isn't exactly harmful, but it's not very helpful either. > > Before I make a proposal to FPC, I thought I'd open a conversation here. > What does a reasonable cleanup of review requests look like? > > My initial thought is to close all review requests that were opened >2 > years ago, to be performed at the EOL closure for each release. Here are my thoughts: It depends on who is waiting. If the submitter is not responding to a reviewer, it makes sense to close the review request rather soon (maybe after 6 weeks). If the reviewer is not responding after the submitter updated the review request, the request should be unassigned to show that it is available for other reviewers. This should happen rather soon for review requests from new packagers (blocking NEEDSPONSOR) to keep newcomers on the hook (maybe after 2 weeks). If the review request is not moving forward in general, the submitter should be asked if they still have interest and only if there is no response, it should be closed. Maybe after 6-12 months. Kind regards Till ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Autoclosure of review requests?
On Tue, Feb 25, 2020 at 3:43 PM Ben Cotton wrote: > > > > On Mon, Feb 24, 2020, 17:32 Fabio Valentini wrote: >> >> >> It sounds like you are both not aware that there's actually an >> existing policy that covers stalled Review Requests: >> https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews (snip) > Ah ha! I thought I remembered seeing something before, but it wasn't on > docs.fp.o when I was looking yesterday. That's a separate bug to fix. :-) I got to thank my firefox browser history. It's an endless repository of knowledge :-) > The problem with the existing policy is that it's geared toward review > requests that someone is actively paying attention to. If neither there's no > reviewer and the submitter just walks away from it, this policy is never > executed. > > What I'm suggesting is a backstop to that. Sure, I think it's reasonable to close Review Requests that haven't been touched in over year, or something like that. The creation date alone might not be accurate enough, as some old requests are actually getting picked up and are being worked on. Fabio >> > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Autoclosure of review requests?
On Mon, Feb 24, 2020, 17:32 Fabio Valentini wrote: > > It sounds like you are both not aware that there's actually an > existing policy that covers stalled Review Requests: > https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews Ah ha! I thought I remembered seeing something before, but it wasn't on docs.fp.o when I was looking yesterday. That's a separate bug to fix. :-) The problem with the existing policy is that it's geared toward review requests that someone is actively paying attention to. If neither there's no reviewer and the submitter just walks away from it, this policy is never executed. What I'm suggesting is a backstop to that. > ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Autoclosure of review requests?
On Mon, Feb 24, 2020 at 11:23 PM Iñaki Ucar wrote: > > On Mon, 24 Feb 2020 at 23:13, Ben Cotton wrote: > > > > In the weekly Fedora program update that I publish on > > communityblog.fedoraproject.org, I have started to include a count of the > > open package review requests. As of this moment, there are ~1300 open > > review requests. Some of these were opened in 2006. > > > > The usual Bugzilla housekeeping (branching, EOL closure, etc) explicitly > > excludes review request bugs. Having a large number of open, ancient review > > requests isn't exactly harmful, but it's not very helpful either. > > > > Before I make a proposal to FPC, I thought I'd open a conversation here. > > What does a reasonable cleanup of review requests look like? > > Similar to other procedures for non-responsive people I guess: after a > timeout, set a flag and post a comment there, and if nobody steps up > to take it, close it. > > > My initial thought is to close all review requests that were opened >2 > > years ago, to be performed at the EOL closure for each release. > > Sounds reasonable. > > Iñaki It sounds like you are both not aware that there's actually an existing policy that covers stalled Review Requests: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews Fabio > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Autoclosure of review requests?
On Mon, 24 Feb 2020 at 23:13, Ben Cotton wrote: > > In the weekly Fedora program update that I publish on > communityblog.fedoraproject.org, I have started to include a count of the > open package review requests. As of this moment, there are ~1300 open review > requests. Some of these were opened in 2006. > > The usual Bugzilla housekeeping (branching, EOL closure, etc) explicitly > excludes review request bugs. Having a large number of open, ancient review > requests isn't exactly harmful, but it's not very helpful either. > > Before I make a proposal to FPC, I thought I'd open a conversation here. What > does a reasonable cleanup of review requests look like? Similar to other procedures for non-responsive people I guess: after a timeout, set a flag and post a comment there, and if nobody steps up to take it, close it. > My initial thought is to close all review requests that were opened >2 years > ago, to be performed at the EOL closure for each release. Sounds reasonable. Iñaki ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Autoclosure of review requests?
In the weekly Fedora program update that I publish on communityblog.fedoraproject.org, I have started to include a count of the open package review requests. As of this moment, there are ~1300 open review requests. Some of these were opened in 2006. The usual Bugzilla housekeeping (branching, EOL closure, etc) explicitly excludes review request bugs. Having a large number of open, ancient review requests isn't exactly harmful, but it's not very helpful either. Before I make a proposal to FPC, I thought I'd open a conversation here. What does a reasonable cleanup of review requests look like? My initial thought is to close all review requests that were opened >2 years ago, to be performed at the EOL closure for each release. -- Ben Cotton He / Him / His Senior Program Manager, Fedora & CentOS Stream Red Hat TZ=America/Indiana/Indianapolis ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
