Re: Build error with GCC 14, not even a warning in GCC 13

2024-01-17 Thread Aleksei Bavshin 

On 1/16/24 15:54, Tom Hughes via devel wrote:

On 16/01/2024 23:49, Richard Shaw wrote:
On Tue, Jan 16, 2024 at 5:36 PM Aleksei Bavshin 
mailto:aleba...@fedoraproject.org>> wrote:


    Ah, I misread the include path. It's our package that is too old :(
    https://src.fedoraproject.org/rpms/rapidjson/pull-request/4
     should
    help.

It doesn't look like the pull request has gotten any attention. 
Perhaps it's time to initiate the non-responsive maintainer process?


Right because the other two PRs I've merged in the last couple of
weeks, including one today, are not evidence of responsiveness?

That PR is on my to look at list but rather obviously it needs
more work than the other ones.

I'm not really keen on packaging a random git snapshot because
there's no way to know how good or bad it is but I realise that
due to upstream being a pain it may be necessary here.


For a conservative approach, cherry-picking 3b2441b, 862c39b, 24ebd51, 
64faab2, a98e999 seems to be enough. The first 2 commits take care of 
the issue from this thread, and the remaining 3 are needed to support 
using rapidjson from projects with -std=c++20.




Tom





OpenPGP_signature.asc
Description: OpenPGP digital signature
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Re: Build error with GCC 14, not even a warning in GCC 13

2024-01-16 Thread Daniel P . Berrangé 
On Tue, Jan 16, 2024 at 11:54:48PM +, Tom Hughes via devel wrote:
> On 16/01/2024 23:49, Richard Shaw wrote:
> > On Tue, Jan 16, 2024 at 5:36 PM Aleksei Bavshin
> > mailto:aleba...@fedoraproject.org>> wrote:
> > 
> > Ah, I misread the include path. It's our package that is too old :(
> > https://src.fedoraproject.org/rpms/rapidjson/pull-request/4
> >  should
> > help.
> > 
> > It doesn't look like the pull request has gotten any attention. Perhaps
> > it's time to initiate the non-responsive maintainer process?
> 
> Right because the other two PRs I've merged in the last couple of
> weeks, including one today, are not evidence of responsiveness?
> 
> That PR is on my to look at list but rather obviously it needs
> more work than the other ones.
> 
> I'm not really keen on packaging a random git snapshot because
> there's no way to know how good or bad it is but I realise that
> due to upstream being a pain it may be necessary here.

The big question is whether the git snapshot is API compatible with
the current version in Fedora.  There are a decent number of things
that depend on rapidjson in the distro and so this needs testing
IMHO before pulling in a git snapshot.

Given the upstream seemingly has no intention of doing more releases,
it feels like our hand will be forced though.

With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Re: Build error with GCC 14, not even a warning in GCC 13

2024-01-16 Thread Tom Hughes via devel 

On 16/01/2024 23:49, Richard Shaw wrote:
On Tue, Jan 16, 2024 at 5:36 PM Aleksei Bavshin 
mailto:aleba...@fedoraproject.org>> wrote:


Ah, I misread the include path. It's our package that is too old :(
https://src.fedoraproject.org/rpms/rapidjson/pull-request/4
 should
help.

It doesn't look like the pull request has gotten any attention. Perhaps 
it's time to initiate the non-responsive maintainer process?


Right because the other two PRs I've merged in the last couple of
weeks, including one today, are not evidence of responsiveness?

That PR is on my to look at list but rather obviously it needs
more work than the other ones.

I'm not really keen on packaging a random git snapshot because
there's no way to know how good or bad it is but I realise that
due to upstream being a pain it may be necessary here.

Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Re: Build error with GCC 14, not even a warning in GCC 13

2024-01-16 Thread Richard Shaw 
On Tue, Jan 16, 2024 at 5:36 PM Aleksei Bavshin 
wrote:

> Ah, I misread the include path. It's our package that is too old :(
> https://src.fedoraproject.org/rpms/rapidjson/pull-request/4 should help.
>

It doesn't look like the pull request has gotten any attention. Perhaps
it's time to initiate the non-responsive maintainer process?

Thanks!
Richard
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Re: Build error with GCC 14, not even a warning in GCC 13

2024-01-16 Thread Jakub Jelinek 
On Tue, Jan 16, 2024 at 03:32:14PM -0800, Aleksei Bavshin wrote:
> On Tue, Jan 16, 2024 at 3:07 PM Richard Shaw  wrote:
> >
> > I'm working on getting a new dependency of one of my packages into Fedora:
> >
> > https://github.com/socketio/socket.io-client-cpp/releases
> >
> > After doing successful test builds locally in mock (no error output at all) 
> > I used fedora-create-review but all the builds failed with:
> >
> > In file included from 
> > /builddir/build/BUILD/socket.io-client-cpp-3.1.0/src/internal/sio_packet.cpp:8:
> > /usr/include/rapidjson/document.h: In member function 
> > ‘rapidjson::GenericStringRef& 
> > rapidjson::GenericStringRef::operator=(const 
> > rapidjson::GenericStringRef&)’:
> > /usr/include/rapidjson/document.h:319:82: error: assignment of read-only 
> > member ‘rapidjson::GenericStringRef::length’
> >   319 | GenericStringRef& operator=(const GenericStringRef& rhs) { s = 
> > rhs.s; length = rhs.length; }
> >   | 
> >   ~~~^~~~
> > gmake[2]: *** [CMakeFiles/sioclient.dir/build.make:121: 
> > CMakeFiles/sioclient.dir/src/internal/sio_packet.cpp.o] Error 1
> >
> > Full logs: https://koji.fedoraproject.org/koji/taskinfo?taskID=111852023
> >
> > Is this a real error?
> 
> Yes, see https://github.com/Tencent/rapidjson/issues/718. The operator
> implementation is most certainly not legal, but previous versions of
> the compiler may have been ignoring that due to not being asked to
> instantiate the specific method.
> This was fixed 8 years ago, apparently bundled deps in
> socket.io-client-cpp are even older.

Yeah, basically what rapidjson does is something like
using size_t = decltype (sizeof 0); 

  
template

  
struct S {  

  
  template

  
  S (const T ()[N]) : s (str), length (N - 1) {}

  
  S (const T *str, size_t len) : s (str), length (len) {}   

  
  S (const S ) : s (rhs.s), length (rhs.length) {}  

  
  S = (const S ) { s = rhs.s; length = rhs.length; }   

  
  const T *const s; 

  
  const size_t length;  

  
};  

  
and gcc only diagnoses that starting with https://gcc.gnu.org/r14-4111
when operator= doesn't need to be instantiated (C++ generally allows
but doesn't require such diagnostics on uninstantiated always invalid
templates), though only for the length store, the s store is invalid
too but it has a dependent type in that case.

Jakub
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Re: Build error with GCC 14, not even a warning in GCC 13

2024-01-16 Thread Aleksei Bavshin 
Ah, I misread the include path. It's our package that is too old :(
https://src.fedoraproject.org/rpms/rapidjson/pull-request/4 should help.

On Tue, Jan 16, 2024 at 3:32 PM Aleksei Bavshin
 wrote:
>
> On Tue, Jan 16, 2024 at 3:07 PM Richard Shaw  wrote:
> >
> > I'm working on getting a new dependency of one of my packages into Fedora:
> >
> > https://github.com/socketio/socket.io-client-cpp/releases
> >
> > After doing successful test builds locally in mock (no error output at all) 
> > I used fedora-create-review but all the builds failed with:
> >
> > In file included from 
> > /builddir/build/BUILD/socket.io-client-cpp-3.1.0/src/internal/sio_packet.cpp:8:
> > /usr/include/rapidjson/document.h: In member function 
> > ‘rapidjson::GenericStringRef& 
> > rapidjson::GenericStringRef::operator=(const 
> > rapidjson::GenericStringRef&)’:
> > /usr/include/rapidjson/document.h:319:82: error: assignment of read-only 
> > member ‘rapidjson::GenericStringRef::length’
> >   319 | GenericStringRef& operator=(const GenericStringRef& rhs) { s = 
> > rhs.s; length = rhs.length; }
> >   | 
> >   ~~~^~~~
> > gmake[2]: *** [CMakeFiles/sioclient.dir/build.make:121: 
> > CMakeFiles/sioclient.dir/src/internal/sio_packet.cpp.o] Error 1
> >
> > Full logs: https://koji.fedoraproject.org/koji/taskinfo?taskID=111852023
> >
> > Is this a real error?
>
> Yes, see https://github.com/Tencent/rapidjson/issues/718. The operator
> implementation is most certainly not legal, but previous versions of
> the compiler may have been ignoring that due to not being asked to
> instantiate the specific method.
> This was fixed 8 years ago, apparently bundled deps in
> socket.io-client-cpp are even older.
>
> >
> > Thanks,
> > Richard
> > --
> > ___
> > devel mailing list -- devel@lists.fedoraproject.org
> > To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> > Fedora Code of Conduct: 
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives: 
> > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> > Do not reply to spam, report it: 
> > https://pagure.io/fedora-infrastructure/new_issue
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Re: Build error with GCC 14, not even a warning in GCC 13

2024-01-16 Thread Aleksei Bavshin 
On Tue, Jan 16, 2024 at 3:07 PM Richard Shaw  wrote:
>
> I'm working on getting a new dependency of one of my packages into Fedora:
>
> https://github.com/socketio/socket.io-client-cpp/releases
>
> After doing successful test builds locally in mock (no error output at all) I 
> used fedora-create-review but all the builds failed with:
>
> In file included from 
> /builddir/build/BUILD/socket.io-client-cpp-3.1.0/src/internal/sio_packet.cpp:8:
> /usr/include/rapidjson/document.h: In member function 
> ‘rapidjson::GenericStringRef& 
> rapidjson::GenericStringRef::operator=(const 
> rapidjson::GenericStringRef&)’:
> /usr/include/rapidjson/document.h:319:82: error: assignment of read-only 
> member ‘rapidjson::GenericStringRef::length’
>   319 | GenericStringRef& operator=(const GenericStringRef& rhs) { s = 
> rhs.s; length = rhs.length; }
>   |   
> ~~~^~~~
> gmake[2]: *** [CMakeFiles/sioclient.dir/build.make:121: 
> CMakeFiles/sioclient.dir/src/internal/sio_packet.cpp.o] Error 1
>
> Full logs: https://koji.fedoraproject.org/koji/taskinfo?taskID=111852023
>
> Is this a real error?

Yes, see https://github.com/Tencent/rapidjson/issues/718. The operator
implementation is most certainly not legal, but previous versions of
the compiler may have been ignoring that due to not being asked to
instantiate the specific method.
This was fixed 8 years ago, apparently bundled deps in
socket.io-client-cpp are even older.

>
> Thanks,
> Richard
> --
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> Do not reply to spam, report it: 
> https://pagure.io/fedora-infrastructure/new_issue
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Build error with GCC 14, not even a warning in GCC 13

2024-01-16 Thread Richard Shaw 
I'm working on getting a new dependency of one of my packages into Fedora:

https://github.com/socketio/socket.io-client-cpp/releases

After doing successful test builds locally in mock (no error output at all)
I used fedora-create-review but all the builds failed with:

In file included from
/builddir/build/BUILD/socket.io-client-cpp-3.1.0/src/internal/sio_packet.cpp:8:
/usr/include/rapidjson/document.h: In member function
‘rapidjson::GenericStringRef&
rapidjson::GenericStringRef::operator=(const
rapidjson::GenericStringRef&)’:
/usr/include/rapidjson/document.h:319:82: error: assignment of read-only
member ‘rapidjson::GenericStringRef::length’
  319 | GenericStringRef& operator=(const GenericStringRef& rhs) { s =
rhs.s; length = rhs.length; }
  |
  ~~~^~~~
gmake[2]: *** [CMakeFiles/sioclient.dir/build.make:121:
CMakeFiles/sioclient.dir/src/internal/sio_packet.cpp.o] Error 1

Full logs: https://koji.fedoraproject.org/koji/taskinfo?taskID=111852023

Is this a real error?

Thanks,
Richard
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue