Re: F23 Self Contained Change: RPM MPI Requires Provides - Review request
On 07/08/2015 05:03 PM, Sandro Mani wrote: On 08.07.2015 22:28, Orion Poplawski wrote: It appears to be sufficient to define this macro anywhere, not just in elf.attr. So I think it could be added in to a rpm macros file in openmpi/mpich-devel. Ah cool, actually it seems to also work if I add it directly to mpi.attrs, meaning that all pieces are nicely confined in one place. Agreed. Also I think you need (64)? or (|64). Correct, fixed. I'm seeing this also in cmake: $ grep '(64)' /usr/lib/rpm/fileattrs/cmake.attr %__cmake_path ^/usr/lib(64)/cmake/.*/.*(Config\.cmake|-config\.cmake)$ suppose it should be fixed there too. Thanks. Fixed in rawhide now. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane or...@nwra.com Boulder, CO 80301 http://www.nwra.com -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: F23 Self Contained Change: RPM MPI Requires Provides - Review request
On 09.07.2015 21:39, Orion Poplawski wrote: On 07/08/2015 05:03 PM, Sandro Mani wrote: Once the package is approved, openmpi and mpich will need to BuildRequire: rpm-mpi-hooks, and openmpi-devel and mpich-devel will need to Require: rpm-mpi-hooks. And finally, once that is done too, all *-openmpi and *-mpich packages will need to be rebuilt. We (i.e. you :) ) should build this up in a copr first for testing. Yes good idea, I'll start firing builds as soon as the pending issues with rpm-mpi-hooks are resolved. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: F23 Self Contained Change: RPM MPI Requires Provides - Review request
On 07/08/2015 05:03 PM, Sandro Mani wrote: Once the package is approved, openmpi and mpich will need to BuildRequire: rpm-mpi-hooks, and openmpi-devel and mpich-devel will need to Require: rpm-mpi-hooks. And finally, once that is done too, all *-openmpi and *-mpich packages will need to be rebuilt. We (i.e. you :) ) should build this up in a copr first for testing. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane or...@nwra.com Boulder, CO 80301 http://www.nwra.com -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: F23 Self Contained Change: RPM MPI Requires Provides - Review request
On 08.07.2015 22:28, Orion Poplawski wrote: It appears to be sufficient to define this macro anywhere, not just in elf.attr. So I think it could be added in to a rpm macros file in openmpi/mpich-devel. Ah cool, actually it seems to also work if I add it directly to mpi.attrs, meaning that all pieces are nicely confined in one place. Also I think you need (64)? or (|64). Correct, fixed. I'm seeing this also in cmake: $ grep '(64)' /usr/lib/rpm/fileattrs/cmake.attr %__cmake_path ^/usr/lib(64)/cmake/.*/.*(Config\.cmake|-config\.cmake)$ suppose it should be fixed there too. I've now posted the review request for the rpm-mpi-hooks package at https://bugzilla.redhat.com/show_bug.cgi?id=1241282 A quick double check of the mpi.req and mpi.prov as part of the review would also be appreciated. Once the package is approved, openmpi and mpich will need to BuildRequire: rpm-mpi-hooks, and openmpi-devel and mpich-devel will need to Require: rpm-mpi-hooks. And finally, once that is done too, all *-openmpi and *-mpich packages will need to be rebuilt. Thanks, Sandro -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
