Re: Mass change of LicenseRef-KDE-Accepted-* licenses

2024-01-29 Thread Miroslav Suchý

Dne 29. 01. 24 v 13:58 Ben Beasley napsal(a):


Could you please double-check this change? I noticed that in spacebar, LicenseRef-KDE-Accepted-GPL was the actual name 
of a license file in the %files section; this was replaced with (GPL-2.0-only OR GPL-3.0-only), which causes the 
package to FTBFS.


Looking at the grep output you originally posted, it seems like plasma-phonebook has a similar problem, and 
kf6-kglobalaccel, kf6-kjobwidgets, and kf6-kservice had filenames in comments replaced, which won’t break their builds 
but isn’t correct either.


Indeed. This possibility did not cross my mind. I fixed all of them and fixed my grep'o'foo script and find only the 
cases you reported. Nothing else.


I checked scratch and it was mass rebuilt before my change, so it was build 
sucessfully. So I did not rebuilt it.



I still appreciate that you are cleaning this up!


And I appreciate you understand human mistake. Still - I am sorry for this.

--
Miroslav Suchy, RHCA
Red Hat, Manager, Packit and CPT, #brno, #fedora-buildsys
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Mass change of LicenseRef-KDE-Accepted-* licenses

2024-01-29 Thread Ben Beasley

Miroslav,

Could you please double-check this change? I noticed that in spacebar, 
LicenseRef-KDE-Accepted-GPL was the actual name of a license file in the 
%files section; this was replaced with (GPL-2.0-only OR GPL-3.0-only), 
which causes the package to FTBFS.


Looking at the grep output you originally posted, it seems like 
plasma-phonebook has a similar problem, and kf6-kglobalaccel, 
kf6-kjobwidgets, and kf6-kservice had filenames in comments replaced, 
which won’t break their builds but isn’t correct either.


I still appreciate that you are cleaning this up!

Thanks,
Ben Beasley (FAS: music)

On 1/23/24 04:52, Miroslav Suchý wrote:


Lots of packages in Fedora use license LicenseRef-KDE-Accepted-GPL and 
LicenseRef-KDE-Accepted-LGPL. These licenses were never approved. It 
took lots of time to discuss it and document it. We finally come with:


https://docs.fedoraproject.org/en-US/legal/update-existing-packages/#_licenseref_kde_accepted

(copy for your convience)

> KDE project uses LicenseRef-KDE-Accepted-* licenses. This was 
discussed here and here. The consensus is that upstream license 
LicenseRef-KDE-Accepted-GPL should be replaced in Fedora by 
GPL-2.0-only OR GPL-3.0-only. And upstream license 
LicenseRef-KDE-Accepted-LGPL should be replaced by LGPL-2.1-only OR 
LGPL-3.0-only.


It is used 123 times in our spec files (full list at the bottom of 
this email). I am willing to do the mass change (with my proven 
package hat on). I welcome your feedback. If no one stops me with a 
reason by end of this month, I will do the change early next month.


$ grepLicenseRef-KDE-Accepted *
akonadiconsole.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only 
AND GPL-2.0-or-later AND GPL-3.0-only AND LGPL-2.0-or-later AND 
LGPL-2.1-or-later AND LicenseRef-KDE-Accepted-GPL
akonadi-mime.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only 
AND LGPL-2.0-only AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND 
LGPL-3.0-only AND LicenseRef-KDE-Accepted-LGPL
akonadi-search.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only 
AND GPL-2.0-or-later AND GPL-3.0-only AND LGPL-2.0-or-later AND 
LGPL-2.1-only AND LGPL-2.1-or-later AND LGPL-3.0-only
AND LicenseRef-KDE-Accepted-GPL AND LicenseRef-KDE-Accepted-LGPL AND 
(MIT OR Apache-2.0) AND MIT
calendarsupport.spec:License: BSD-3-Clause AND CC0-1.0 AND 
GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LicenseRef-KDE-Accepted-GPL
incidenceeditor.spec:License: BSD-3-Clause AND CC0-1.0 AND 
GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LicenseRef-KDE-Accepted-GPL
kactivitymanagerd.spec:License: CC0-1.0 AND GPL-2.0-only AND 
GPL-2.0-or-later AND GPL-3.0-only AND LGPL-2.1-only AND LGPL-3.0-only 
AND LicenseRef-KDE-Accepted-GPL AND LicenseRef-KDE-Accepte

d-LGPL
kalendar.spec:License:    BSD-2-Clause AND BSD-3-Clause AND 
CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-2.1-only A
ND LGPL-2.1-or-later AND LGPL-3.0-only AND LGPL-3.0-or-later AND 
LicenseRef-KDE-Accepted-GPL AND LicenseRef-KDE-Accepted-LGPL
kdepim-addons.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only 
AND GPL-2.0-or-later AND GPL-3.0-only AND LGPL-2.0-only AND 
LGPL-2.0-or-later AND LGPL-3.0-only AND LicenseRef-KDE-Acce

pted-GPL AND LicenseRef-KDE-Accepted-LGPL
kdepim-runtime.spec:License: AGPL-3.0-or-later AND BSD-2-Clause AND 
BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND 
GPL-3.0-only AND GPL-3.0-or-later AND LGPL-2.0-only AN
D LGPL-2.0-or-later AND LGPL-2.1-or-later AND LGPL-3.0-only AND 
LGPL-3.0-or-later AND LicenseRef-KDE-Accepted-GPL AND 
LicenseRef-KDE-Accepted-LGPL
kdeplasma-addons.spec:License: BSD-3-Clause AND CC0-1.0 AND 
GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
GPL-3.0-or-later AND LGPL-2.0-only AND LGPL-2.0-or-later AND LGPL-2.1-only
AND LGPL-2.1-or-later AND LGPL-3.0-only AND LGPL-3.0-or-later AND 
LicenseRef-KDE-Accepted-GPL AND LicenseRef-KDE-Accepted-LGPL AND MIT
kf5-akonadi-mime.spec:License: BSD-3-Clause AND CC0-1.0 AND 
GPL-2.0-only AND LGPL-2.0-only AND LGPL-2.0-or-later AND 
LGPL-2.1-or-later AND LGPL-3.0-only AND LicenseRef-KDE-Accepted-LGPL
kf5-akonadi-search.spec:License: BSD-3-Clause AND CC0-1.0 AND 
GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LGPL-2.1-only AND LGPL-2.1-or-later AND LGPL-3.0-o

nly AND LicenseRef-KDE-Accepted-GPL AND LicenseRef-KDE-Accepted-LGPL
kf5-akonadi-server.spec:License: BSD-3-Clause AND CC0-1.0 AND 
GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND LGPL-2.0-only 
AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND LicenseRef

-KDE-Accepted-GPL AND MIT
kf5-attica.spec:License: CC0-1.0 AND LGPL-2.0-or-later AND 
LGPL-2.1-only AND LGPL-3.0-only AND LicenseRef-KDE-Accepted-LGPL
kf5-bluez-qt.spec:License:    CC0-1.0, LGPL-2.1-only AND 
LGPL-2.1-or-later AND LGPL-3.0-only AND LicenseRef-KDE-Accepted-LGPL
kf5-calendarsupport.spec:License: BSD

Re: Mass change of LicenseRef-KDE-Accepted-* licenses

2024-01-23 Thread Richard Fontana
On Tue, Jan 23, 2024 at 4:52 AM Miroslav Suchý  wrote:
>
> Lots of packages in Fedora use license LicenseRef-KDE-Accepted-GPL and 
> LicenseRef-KDE-Accepted-LGPL. These licenses were never approved. It took 
> lots of time to discuss it and document it. We finally come with:
>
> https://docs.fedoraproject.org/en-US/legal/update-existing-packages/#_licenseref_kde_accepted
>
> (copy for your convience)
>
> > KDE project uses LicenseRef-KDE-Accepted-* licenses. This was discussed 
> > here and here. The consensus is that upstream license 
> > LicenseRef-KDE-Accepted-GPL should be replaced in Fedora by GPL-2.0-only OR 
> > GPL-3.0-only. And upstream license LicenseRef-KDE-Accepted-LGPL should be 
> > replaced by LGPL-2.1-only OR LGPL-3.0-only.

Thinking about this some more, it's a little confusing and a specific
case of how we have been somewhat mixing up two issues, (1) approval
of licenses for Fedora, and (2) policy on what should go in the
License tag. I've been trying to revise the legal docs to clear some
of this up.

The KDE formulation is basically an alternative to the traditional "or
any later version" approach to *GPL licensing. Basically, instead of
allowing blanket use of future versions authored by the FSF, KDE is
saying you can use future versions authored by the FSF and authorized
by KDE. I'll call this the KDE "proxy" permission because the term
"proxy" is used with this scenario in mind in *GPLv3.

"LicenseRef-" is an SPDX construct that allows creation of custom
license identifiers (i.e., license identifiers not on the SPDX license
list). SPDX has to date chosen not to adopt any sort of namespacing
system for LicenseRef-s despite some proposals. So the KDE LicenseRefs
are not Fedora LicenseRefs. That's one complication here, resulting
from multiple differing uses of SPDX license expressions by two
projects. Another issue was that I found that KDE has not had a stable
definition of at least one of these LicenseRefs, so we can't just
easily adopt the KDE LicenseRef as a Fedora LicenseRef pointing to
wherever KDE defines what it means since we can't be sure that KDE
might not revise it again.

There's no reason why the KDE formulation should be *disapproved* --
in that sense, maybe we should add some representation of it to Fedora
License Data somehow. But the existing Fedora approach (to the extent
there was any guidance on this), from the Callaway System Era (i.e.
prior to the adoption of SPDX license expressions), was not to
represent the KDE proxy permission in License tags. So the thought was
not to depart from the Callaway tradition. Logically, there's no basis
for disapproving the KDE proxy permission since it's a subset of a
permission that Fedora already approves (the general *GPL "or later"
permission).

So: don't use the KDE proxy permission in License tags. But we might
have to revise the docs and Fedora License Data in some way.

Richard
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Mass change of LicenseRef-KDE-Accepted-* licenses

2024-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 23, 2024 at 10:52:16AM +0100, Miroslav Suchý wrote:
> > KDE project uses LicenseRef-KDE-Accepted-* licenses. This was discussed
> > here and here. The consensus is that upstream license
> > LicenseRef-KDE-Accepted-GPL should be replaced in Fedora by GPL-2.0-only OR
> > GPL-3.0-only. And upstream license LicenseRef-KDE-Accepted-LGPL should be
> > replaced by LGPL-2.1-only OR LGPL-3.0-only.
> 
> It is used 123 times in our spec files (full list at the bottom of this
> email). I am willing to do the mass change (with my proven package hat on).
> I welcome your feedback. If no one stops me with a reason by end of this
> month, I will do the change early next month.

Yes please!

Zbyszek
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Mass change of LicenseRef-KDE-Accepted-* licenses

2024-01-23 Thread Miroslav Suchý
Lots of packages in Fedora use license LicenseRef-KDE-Accepted-GPL and LicenseRef-KDE-Accepted-LGPL. These licenses were 
never approved. It took lots of time to discuss it and document it. We finally come with:


https://docs.fedoraproject.org/en-US/legal/update-existing-packages/#_licenseref_kde_accepted

(copy for your convience)

> KDE project uses LicenseRef-KDE-Accepted-* licenses. This was discussed here and here. The consensus is that upstream 
license LicenseRef-KDE-Accepted-GPL should be replaced in Fedora by GPL-2.0-only OR GPL-3.0-only. And upstream license 
LicenseRef-KDE-Accepted-LGPL should be replaced by LGPL-2.1-only OR LGPL-3.0-only.


It is used 123 times in our spec files (full list at the bottom of this email). I am willing to do the mass change (with 
my proven package hat on). I welcome your feedback. If no one stops me with a reason by end of this month, I will do the 
change early next month.


$ grepLicenseRef-KDE-Accepted *
akonadiconsole.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LGPL-2.1-or-later AND LicenseRef-KDE-Accepted-GPL
akonadi-mime.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND LGPL-2.0-only AND LGPL-2.0-or-later AND 
LGPL-2.1-or-later AND LGPL-3.0-only AND LicenseRef-KDE-Accepted-LGPL
akonadi-search.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LGPL-2.1-only AND LGPL-2.1-or-later AND LGPL-3.0-only

AND LicenseRef-KDE-Accepted-GPL AND LicenseRef-KDE-Accepted-LGPL AND (MIT OR 
Apache-2.0) AND MIT
calendarsupport.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LicenseRef-KDE-Accepted-GPL
incidenceeditor.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LicenseRef-KDE-Accepted-GPL
kactivitymanagerd.spec:License: CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND LGPL-2.1-only AND 
LGPL-3.0-only AND LicenseRef-KDE-Accepted-GPL AND LicenseRef-KDE-Accepte

d-LGPL
kalendar.spec:License:    BSD-2-Clause AND BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND 
GPL-3.0-only AND GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-2.1-only A
ND LGPL-2.1-or-later AND LGPL-3.0-only AND LGPL-3.0-or-later AND LicenseRef-KDE-Accepted-GPL AND 
LicenseRef-KDE-Accepted-LGPL
kdepim-addons.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-only AND LGPL-2.0-or-later AND LGPL-3.0-only AND LicenseRef-KDE-Acce

pted-GPL AND LicenseRef-KDE-Accepted-LGPL
kdepim-runtime.spec:License: AGPL-3.0-or-later AND BSD-2-Clause AND BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND 
GPL-2.0-or-later AND GPL-3.0-only AND GPL-3.0-or-later AND LGPL-2.0-only AN
D LGPL-2.0-or-later AND LGPL-2.1-or-later AND LGPL-3.0-only AND LGPL-3.0-or-later AND LicenseRef-KDE-Accepted-GPL AND 
LicenseRef-KDE-Accepted-LGPL
kdeplasma-addons.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
GPL-3.0-or-later AND LGPL-2.0-only AND LGPL-2.0-or-later AND LGPL-2.1-only
AND LGPL-2.1-or-later AND LGPL-3.0-only AND LGPL-3.0-or-later AND LicenseRef-KDE-Accepted-GPL AND 
LicenseRef-KDE-Accepted-LGPL AND MIT
kf5-akonadi-mime.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND LGPL-2.0-only AND LGPL-2.0-or-later AND 
LGPL-2.1-or-later AND LGPL-3.0-only AND LicenseRef-KDE-Accepted-LGPL
kf5-akonadi-search.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LGPL-2.1-only AND LGPL-2.1-or-later AND LGPL-3.0-o

nly AND LicenseRef-KDE-Accepted-GPL AND LicenseRef-KDE-Accepted-LGPL
kf5-akonadi-server.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-only AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND LicenseRef

-KDE-Accepted-GPL AND MIT
kf5-attica.spec:License: CC0-1.0 AND LGPL-2.0-or-later AND LGPL-2.1-only AND 
LGPL-3.0-only AND LicenseRef-KDE-Accepted-LGPL
kf5-bluez-qt.spec:License:    CC0-1.0, LGPL-2.1-only AND LGPL-2.1-or-later AND LGPL-3.0-only AND 
LicenseRef-KDE-Accepted-LGPL
kf5-calendarsupport.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LicenseRef-KDE-Accepted-GPL
kf5-frameworkintegration.spec:License: CC0-1.0 AND LGPL-2.0-only AND LGPL-2.0-or-later AND LGPL-3.0-only AND 
LicenseRef-KDE-Accepted-LGPL
kf5-incidenceeditor.spec:License: BSD-3-Clause AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND 
LGPL-2.0-or-later AND LicenseRef-KDE-Accepted-GPL
kf5-kactivities.spec:License: CC0-1.0 AND GPL-2.0-or-later AND LGPL-2.0-or-later AND LGPL-2.1-only AND LGPL-3.0-only AND 
LicenseRef-KDE-Accepted-LGPL AND MIT
kf5-kactivities-stats.spec:License: CC0-1.0 AND GPL-2.0-only AND GPL-2.