Re: Inclusion/Exclusion of BuildRoot tag and %defattr
On Mon, Jul 18, 2011 at 01:20:30PM +0100, Damian L Brasher wrote: Hi List Referring to sections of Packaging Guidelines: No longer necessary to explicitly include %defattr at the beginning of % files. and the fact that the BuildRoot tag, eve if defined, is ignored. After reviewing packages I have suggested %defattr is not strictly necessary. I have also removed %defattr(-,root,root,-) from my contributed spec file https://bugzilla.redhat.com/show_bug.cgi?id=644711 Is this correct, i.e. do the package review request authors need to be notified? i.e. https://bugzilla.redhat.com/show_bug.cgi?id=720085 They are now optional but there's no need to force people to be rid of them. In particular, some people like to build a package for both Fedora and EPEL-5. In this case, a lot of the things that are optional in Fedora have to remain for the EPEL package. -Toshio pgpzNIRFAB2zd.pgp Description: PGP signature -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Inclusion/Exclusion of BuildRoot tag and %defattr
TK == Toshio Kuratomi a.bad...@gmail.com writes: TK They are now optional but there's no need to force people to be rid TK of them. In particular, some people like to build a package for both TK Fedora and EPEL-5. In this case, a lot of the things that are TK optional in Fedora have to remain for the EPEL package. Note that according to our guideline page only RPM releases older than 4.4 require %defattr, which would limit the requirement for it to specs which need to build unmodified on EL4. - J -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Inclusion/Exclusion of BuildRoot tag and %defattr
On Mon, Jul 18, 2011 at 02:14:48PM -0500, Jason L Tibbitts III wrote: TK == Toshio Kuratomi a.bad...@gmail.com writes: TK They are now optional but there's no need to force people to be rid TK of them. In particular, some people like to build a package for both TK Fedora and EPEL-5. In this case, a lot of the things that are TK optional in Fedora have to remain for the EPEL package. Note that according to our guideline page only RPM releases older than 4.4 require %defattr, which would limit the requirement for it to specs which need to build unmodified on EL4. Ah... I always forget that -- %defattr is optional in EL-5 but not EL-4 ; buildroot is needed even in EL-5. https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines -Toshio pgpDPZ78Kb0ol.pgp Description: PGP signature -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel