Re: Issue with patches on gdesklets
Thank you Michael for the guide especially the use of rpmbuild -bp command. Following your advice, it turned out one of applied patches was a duplicate which I removed it. I renamed the .desktop patch name to .gdesklets-desktop to avoid duplicate which explained why the built could not find gdesktop.desktop file. gdesklets update is now in bodhi[1] so I will need some volunteer to test if the memory leak still occurs. Ref: [1] https://admin.fedoraproject.org/updates/FEDORA-2012-5537/gdesklets-0.36.3-6.1.fc16?_csrf_token=b95b5c6e7a98187002deb149afae3d3d966edbc5 On 04/04/12 02:48 AM, Michael Schwendt wrote: On Tue, 03 Apr 2012 21:08:53 -0700, LT (Luya) wrote: Greetings, I have an issue rebuilding a gdesklets package using koji. According to the task: http://koji.fedoraproject.org/koji/taskinfo?taskID=3962388 Hunks seemed to be rejected. Can anyone check what went wrong. Thanks in advance. This is basic package maintenance stuff. Does it build for you in Mock or plain rpmbuild? Have you verified that the patches apply cleanly (note that the maximum fuzz factor is set to 0) or may need to be rediffed? You can run rpmbuild -bp gdesklets.spec repeatedly or try to apply them manually running the patch command. -- Luya Tshimbalanga Graphic Web Designer E: l...@fedoraproject.org W: http://www.thefinalzone.net -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Issue with patches on gdesklets
On 4.4.2012 12:29, Kevin Kofler wrote: %patch2 needs to be applied with -p1, not -p0. For future, lsdiff(1) and generally whole patchutils are your friend. Use it, enjoy it! Matěj -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Issue with patches on gdesklets
Thanks Michael, I changed the suffix from .desktop to .gdesklets-desktop. Following your advice, the built ran smoothly and I will update the package for F17 and rawhide followed by F16 and F15. http://koji.fedoraproject.org/koji/taskinfo?taskID=3971749 On 04/04/12 02:48 AM, Michael Schwendt wrote: On Tue, 03 Apr 2012 21:08:53 -0700, LT (Luya) wrote: Greetings, I have an issue rebuilding a gdesklets package using koji. According to the task: http://koji.fedoraproject.org/koji/taskinfo?taskID=3962388 Hunks seemed to be rejected. Can anyone check what went wrong. Thanks in advance. This is basic package maintenance stuff. Does it build for you in Mock or plain rpmbuild? Have you verified that the patches apply cleanly (note that the maximum fuzz factor is set to 0) or may need to be rediffed? You can run rpmbuild -bp gdesklets.spec repeatedly or try to apply them manually running the patch command. Btw: + /bin/cat /builddir/build/SOURCES/gdesklets-desktop.patch + /usr/bin/patch -s -p0 -b --suffix .desktop --fuzz=0 Caution! This suffix .desktop bears a risk, because the backup file with such a file name extension will match a *.desktop wildcard anywhere in the spec file and/or the build framework. Something like this has lead to including wrong/duplicate files in a package before. -- Luya Tshimbalanga Graphic Web Designer E: l...@fedoraproject.org W: http://www.thefinalzone.net -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Issue with patches on gdesklets
On Tue, 03 Apr 2012 21:08:53 -0700, LT (Luya) wrote: Greetings, I have an issue rebuilding a gdesklets package using koji. According to the task: http://koji.fedoraproject.org/koji/taskinfo?taskID=3962388 Hunks seemed to be rejected. Can anyone check what went wrong. Thanks in advance. This is basic package maintenance stuff. Does it build for you in Mock or plain rpmbuild? Have you verified that the patches apply cleanly (note that the maximum fuzz factor is set to 0) or may need to be rediffed? You can run rpmbuild -bp gdesklets.spec repeatedly or try to apply them manually running the patch command. Btw: + /bin/cat /builddir/build/SOURCES/gdesklets-desktop.patch + /usr/bin/patch -s -p0 -b --suffix .desktop --fuzz=0 Caution! This suffix .desktop bears a risk, because the backup file with such a file name extension will match a *.desktop wildcard anywhere in the spec file and/or the build framework. Something like this has lead to including wrong/duplicate files in a package before. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
