Re: Orphaning PycURL
On Fri, Feb 22, 2013 at 03:17:57PM -0500, Seth Vidal wrote: it's not under my control anymore - but the idea of python-requests and its deps pulled into @core does not fill me with joy. Sooo $ rpm -qR python-requests|grep -v ^rpmlib\( ca-certificates python(abi) = 2.7 (And ca-certificates doesn't require anything.) It's relatively big for a core package (couple of megabytes, give or take). And curl is required by a number of *other* things, and it's pretty nice to have such a utility in standard if not in core at least, so it's almost free as a base. Does requests still have some local copy of other libs? Apparently it doesn't pull them in from other packages. :) -- Matthew Miller ☁☁☁ Fedora Cloud Architect ☁☁☁ mat...@fedoraproject.org -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Sat, 2013-02-23 at 04:47 -0500, Matthew Miller wrote: On Fri, Feb 22, 2013 at 03:17:57PM -0500, Seth Vidal wrote: it's not under my control anymore - but the idea of python-requests and its deps pulled into @core does not fill me with joy. Sooo $ rpm -qR python-requests|grep -v ^rpmlib\( ca-certificates python(abi) = 2.7 (And ca-certificates doesn't require anything.) It's relatively big for a core package (couple of megabytes, give or take). And curl is required by a number of *other* things, and it's pretty nice to have such a utility in standard if not in core at least, so it's almost free as a base. Does requests still have some local copy of other libs? Apparently it doesn't pull them in from other packages. :) There is work in progress to unbundle the libraries that requests bundles, that will make it loose some weight but will increase the dependency chain: https://bugzilla.redhat.com/show_bug.cgi?id=904623 Pierre -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Sat, Feb 23, 2013 at 10:53:53AM +0100, Pierre-Yves Chibon wrote: On Sat, 2013-02-23 at 04:47 -0500, Matthew Miller wrote: It's relatively big for a core package (couple of megabytes, give or take). And curl is required by a number of *other* things, and it's pretty nice to have such a utility in standard if not in core at least, so it's almost free as a base. Does requests still have some local copy of other libs? Apparently it doesn't pull them in from other packages. :) There is work in progress to unbundle the libraries that requests bundles, that will make it loose some weight but will increase the dependency chain: https://bugzilla.redhat.com/show_bug.cgi?id=904623 Also note, Fedora is currently on an old version of python-requests. In part, this is because it is licensed ISC (GPL compatible) and the next version is licensed Apache v2 (GPLv3 compatible but not GPLv2 compatible). I've asked spot how the licensing concerns affect python code (by extension other scripting languages in a similar situation) and he thought that it would likely be fine if GPLv2 code is importing Apache code but not fine if the code is being copied. However, he also warned that the only way to know that for sure would be to ask the lawyers to look into it. We've recently ported python=fedora from pycurl over to python-requests. The API seems easier to work with at first and we were able to achieve a healthy speedup (because we were not making use of a connection pool with our curl code and python-requests comes with one builtin). However, we did encounter several bugs with the code that we had to fix, some security issues that had languished a bit upstream, the bundled libraries that are noted above Now that we've ironed out the major difficulties and have a handle on what would be needed to take care of, for instance, the bundled libraries, I think we're going to stick with it in python-fedora but I wouldn't want to recommend it to others without them being aware of the potential caveats to using it. -Toshio pgpgZs8jUpURb.pgp Description: PGP signature -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, Feb 22, 2013 at 3:45 PM, Jeffrey Ollie j...@ocjtech.us wrote: On Fri, Feb 22, 2013 at 3:37 PM, Kamil Dudka kdu...@redhat.com wrote: I have taken the ownership for now. I was cleaning up some old email when I ran across an email from Tomáš Smetana that python-pycurl has been incorporated into RHEL as of RHEL6, so it would make sense for someone @ Red Hat to maintain python-pycurl in Fedora (not necessarily Kamil Dudka though). -- Jeff Ollie -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Sat, 23 Feb 2013, Matthew Miller wrote: On Fri, Feb 22, 2013 at 03:17:57PM -0500, Seth Vidal wrote: it's not under my control anymore - but the idea of python-requests and its deps pulled into @core does not fill me with joy. Sooo $ rpm -qR python-requests|grep -v ^rpmlib\( ca-certificates python(abi) = 2.7 (And ca-certificates doesn't require anything.) It's relatively big for a core package (couple of megabytes, give or take). And curl is required by a number of *other* things, and it's pretty nice to have such a utility in standard if not in core at least, so it's almost free as a base. Does requests still have some local copy of other libs? Apparently it doesn't pull them in from other packages. :) See Pierre's msg following this - the issue is what it bundles. But the yum devs can make a decision on what they want to do with urlgrabber. Not sure what dnf is using at the moment. -sv -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On 02/22/2013 10:02 AM, Jeffrey Ollie wrote: Personally, I'd like to see Yum move away from PycURL but if someone wants to take over upstream development more power to them. I use pycurl as well. Do you have a suggestion for an alternative package to use that has similar capabilities? -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, 2013-02-22 at 12:02 -0800, Samuel Sieb wrote: On 02/22/2013 10:02 AM, Jeffrey Ollie wrote: Personally, I'd like to see Yum move away from PycURL but if someone wants to take over upstream development more power to them. I use pycurl as well. Do you have a suggestion for an alternative package to use that has similar capabilities? requests? Or plain urllib although it remains quite painfull. Pierre -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, 22 Feb 2013, Pierre-Yves Chibon wrote: On Fri, 2013-02-22 at 12:02 -0800, Samuel Sieb wrote: On 02/22/2013 10:02 AM, Jeffrey Ollie wrote: Personally, I'd like to see Yum move away from PycURL but if someone wants to take over upstream development more power to them. I use pycurl as well. Do you have a suggestion for an alternative package to use that has similar capabilities? requests? Or plain urllib although it remains quite painfull. it's not under my control anymore - but the idea of python-requests and its deps pulled into @core does not fill me with joy. Does requests still have some local copy of other libs? -sv -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, Feb 22, 2013 at 2:17 PM, Seth Vidal skvi...@fedoraproject.orgwrote: On Fri, 22 Feb 2013, Pierre-Yves Chibon wrote: On Fri, 2013-02-22 at 12:02 -0800, Samuel Sieb wrote: On 02/22/2013 10:02 AM, Jeffrey Ollie wrote: Personally, I'd like to see Yum move away from PycURL but if someone wants to take over upstream development more power to them. I use pycurl as well. Do you have a suggestion for an alternative package to use that has similar capabilities? requests? Or plain urllib although it remains quite painfull. it's not under my control anymore - but the idea of python-requests and its deps pulled into @core does not fill me with joy. Does requests still have some local copy of other libs? I'm not familiar with it, nor is it in Fedora yet, but would curlish work? https://pypi.python.org/pypi/curlish/ -J -sv -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.**org/mailman/listinfo/develhttps://admin.fedoraproject.org/mailman/listinfo/devel -- http://cecinestpasunefromage.wordpress.com/ in your fear, seek only peace in your fear, seek only love -d. bowie -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, Feb 22, 2013 at 2:19 PM, Jon Ciesla limburg...@gmail.com wrote: On Fri, Feb 22, 2013 at 2:17 PM, Seth Vidal skvi...@fedoraproject.orgwrote: On Fri, 22 Feb 2013, Pierre-Yves Chibon wrote: On Fri, 2013-02-22 at 12:02 -0800, Samuel Sieb wrote: On 02/22/2013 10:02 AM, Jeffrey Ollie wrote: Personally, I'd like to see Yum move away from PycURL but if someone wants to take over upstream development more power to them. I use pycurl as well. Do you have a suggestion for an alternative package to use that has similar capabilities? requests? Or plain urllib although it remains quite painfull. it's not under my control anymore - but the idea of python-requests and its deps pulled into @core does not fill me with joy. Does requests still have some local copy of other libs? I'm not familiar with it, nor is it in Fedora yet, but would curlish work? https://pypi.python.org/pypi/curlish/ -J Also, I'm looking at pycurl, and so far I have this backtrace from a rawhide mock build. Program received signal SIGSEGV, Segmentation fault. 0x7fffef794da7 in curl_multi_cleanup () from /lib64/libcurl.so.4 (gdb) bt #0 0x7fffef794da7 in curl_multi_cleanup () from /lib64/libcurl.so.4 #1 0x7fffef9d3e72 in do_multi_dealloc (self=0x7a2f70) at src/pycurl.c:2296 #2 0x77a9bdc7 in PyDict_DelItem () from /lib64/libpython2.7.so.1.0 #3 0x77af6818 in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0 #4 0x77afa53d in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0 #5 0x77afa642 in PyEval_EvalCode () from /lib64/libpython2.7.so.1.0 #6 0x77b133df in ?? () from /lib64/libpython2.7.so.1.0 #7 0x77b1448e in PyRun_FileExFlags () from /lib64/libpython2.7.so.1.0 #8 0x77b155e7 in PyRun_SimpleFileExFlags () from /lib64/libpython2.7.so.1.0 #9 0x77b25f87 in Py_Main () from /lib64/libpython2.7.so.1.0 #10 0x76d59b75 in __libc_start_main () from /lib64/libc.so.6 #11 0x00400721 in _start () -J -sv -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.**org/mailman/listinfo/develhttps://admin.fedoraproject.org/mailman/listinfo/devel -- http://cecinestpasunefromage.wordpress.com/ in your fear, seek only peace in your fear, seek only love -d. bowie -- http://cecinestpasunefromage.wordpress.com/ in your fear, seek only peace in your fear, seek only love -d. bowie -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, 22 Feb 2013, Jon Ciesla wrote: I'm not familiar with it, nor is it in Fedora yet, but would curlish work? https://pypi.python.org/pypi/curlish/ It's calling out to curl via subprocess - that doesn't feel like a good idea -sv -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, Feb 22, 2013 at 2:21 PM, Seth Vidal skvi...@fedoraproject.orgwrote: On Fri, 22 Feb 2013, Jon Ciesla wrote: I'm not familiar with it, nor is it in Fedora yet, but would curlish work? https://pypi.python.org/pypi/**curlish/https://pypi.python.org/pypi/curlish/ It's calling out to curl via subprocess - that doesn't feel like a good idea Ew, I'd not looked that closely yet. No, I agrees. -J -sv -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.**org/mailman/listinfo/develhttps://admin.fedoraproject.org/mailman/listinfo/devel -- http://cecinestpasunefromage.wordpress.com/ in your fear, seek only peace in your fear, seek only love -d. bowie -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Friday, February 22, 2013 12:02:47 Jeffrey Ollie wrote: The final straw is that the package failed to build in the latest mass rebuild: https://bugzilla.redhat.com/show_bug.cgi?id=914411 Thanks for heads up! This is a bug in the latest upstream release of libcurl. I will apply the upstream fix for this: https://github.com/bagder/curl/commit/da3fc1ee Kamil -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, Feb 22, 2013 at 2:29 PM, Kamil Dudka kdu...@redhat.com wrote: On Friday, February 22, 2013 12:02:47 Jeffrey Ollie wrote: The final straw is that the package failed to build in the latest mass rebuild: https://bugzilla.redhat.com/show_bug.cgi?id=914411 Thanks for heads up! This is a bug in the latest upstream release of libcurl. I will apply the upstream fix for this: https://github.com/bagder/curl/commit/da3fc1ee Excellent! Jeffrey, will you be picking python-pycurl up again, then? -J Kamil -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel -- http://cecinestpasunefromage.wordpress.com/ in your fear, seek only peace in your fear, seek only love -d. bowie -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, Feb 22, 2013 at 2:33 PM, Jon Ciesla limburg...@gmail.com wrote: Excellent! Jeffrey, will you be picking python-pycurl up again, then? No. While this was an easy fix that was actually in another package, PycURL has other problems. I think that the most obvious one is handling errors encountered by libcurl (DNS errors, connection refused, etc.) and passing back sensible error messages back to the Python layer. I'm sure a little trolling of bugzilla would turn up others. There are patches out there that fix these and other problems, but as I said, I don't want to become the de facto upstream PycURL maintainer, especially for a package that is this critical to the project. I just don't have the time or interest. -- Jeff Ollie -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Friday, February 22, 2013 14:54:04 Jeffrey Ollie wrote: On Fri, Feb 22, 2013 at 2:33 PM, Jon Ciesla limburg...@gmail.com wrote: Excellent! Jeffrey, will you be picking python-pycurl up again, then? No. While this was an easy fix that was actually in another package, PycURL has other problems. I think that the most obvious one is handling errors encountered by libcurl (DNS errors, connection refused, etc.) and passing back sensible error messages back to the Python layer. I'm sure a little trolling of bugzilla would turn up others. There are patches out there that fix these and other problems, but as I said, I don't want to become the de facto upstream PycURL maintainer, especially for a package that is this critical to the project. I just don't have the time or interest. I have taken the ownership for now. Kamil -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Orphaning PycURL
On Fri, Feb 22, 2013 at 3:37 PM, Kamil Dudka kdu...@redhat.com wrote: I have taken the ownership for now. Thanks! -- Jeff Ollie -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
