Re: Release rpkg-1.66 and fedpkg-1.44
On 13. 03. 23 21:53, Otto Liljalaakso wrote: Miro Hrončok kirjoitti 9.3.2023 klo 13.17: On 09. 03. 23 10:05, Otto Liljalaakso wrote: Miro Hrončok kirjoitti 8.3.2023 klo 17.29: However, maybe it does not work as I expected? [python-setuptools (bundles %)]$ fedpkg prep Not downloading already downloaded setuptools-65.5.1.tar.gz Could not execute prep: Could not find the release/dist from branch name bundles Please specify with --release Right, it looks like you interpreted "outside of an established dist-git repository" to cover the case where you do have a Git repository, but are in a local branch with a custom name. Unfortunately, currently only the case where there is no Git repository at all is covered. Mea culpa. I assumed that's the case because I don't use fedpkg outside of git much. I presume that in your example you intend to eventually create a pull request. Fedpkg should have a great support for that as well, but a bit (just a bit) more work is needed to cover that case. I suppose that it would be enough to, instead of printing the error you saw, fall back to using the same default mechanism that is used for the no-Git case. I will take a look at some point — unless somebody beats me to it, of course. I took a look at this, and making '--release rawhide' for unknown branches is very easy [1]. I did not create a pull request yet, because I am a bit unsure if this is a good idea. My assumption is still that the vast majority of unknown branches are created for Rawhide pull requests. But for the ones that are for some other purpose, the default behavior changes from asking to be explicit with --release, to doing the wrong thing. There would be log output notifying about defaulting to 'rawhide', and the --release parameter could still be used to select the correct release. So maybe convenience for the majority case weighs more than some risk for the minority case? I think so. This can even be improved to make f38-foo default to f38 etc. That way, I would hardly ever need to use --release except for cases where I want to test-build foo on both rawhide and f38. If you worry about the risks, I suppose fedpkg build (without --scratch) might abort without --release when the branch is not "proper". All the other use cases i could think of should be safe. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Release rpkg-1.66 and fedpkg-1.44
On Mon, Mar 13, 2023 at 10:53:41PM +0200, Otto Liljalaakso wrote:
> Miro Hrončok kirjoitti 9.3.2023 klo 13.17:
> > On 09. 03. 23 10:05, Otto Liljalaakso wrote:
> > > Miro Hrončok kirjoitti 8.3.2023 klo 17.29:
> > > >
> > > > However, maybe it does not work as I expected?
> > > >
> > > > [python-setuptools (bundles %)]$ fedpkg prep
> > > > Not downloading already downloaded setuptools-65.5.1.tar.gz
> > > > Could not execute prep: Could not find the release/dist from
> > > > branch name bundles
> > > > Please specify with --release
> > >
> > > Right, it looks like you interpreted "outside of an established
> > > dist-git repository" to cover the case where you do have a Git
> > > repository, but are in a local branch with a custom name.
> > > Unfortunately, currently only the case where there is no Git
> > > repository at all is covered.
> >
> > Mea culpa. I assumed that's the case because I don't use fedpkg outside
> > of git much.
> >
> > > I presume that in your example you intend to eventually create a
> > > pull request. Fedpkg should have a great support for that as well,
> > > but a bit (just a bit) more work is needed to cover that case. I
> > > suppose that it would be enough to, instead of printing the error
> > > you saw, fall back to using the same default mechanism that is used
> > > for the no-Git case. I will take a look at some point — unless
> > > somebody beats me to it, of course.
>
> I took a look at this, and making '--release rawhide' for unknown branches
> is very easy [1]. I did not create a pull request yet, because I am a bit
> unsure if this is a good idea. My assumption is still that the vast majority
> of unknown branches are created for Rawhide pull requests. But for the ones
> that are for some other purpose, the default behavior changes from asking to
> be explicit with --release, to doing the wrong thing.
>
> There would be log output notifying about defaulting to 'rawhide', and the
> --release parameter could still be used to select the correct release. So
> maybe convenience for the majority case weighs more than some risk for the
> minority case?
>
> [1]:
> https://pagure.io/fork/oturpe/fedpkg/c/712dc656c4b06dafb693e5048baef45a0d82e973
I think this is reasonable.
> self.log.info("'%s' is not match any release branch. "
"does not match".
I'd make it just one line:
"'%s' does not match any release branch, using 'rawhide'."
Zbyszek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: Release rpkg-1.66 and fedpkg-1.44
Miro Hrončok kirjoitti 9.3.2023 klo 13.17: On 09. 03. 23 10:05, Otto Liljalaakso wrote: Miro Hrončok kirjoitti 8.3.2023 klo 17.29: However, maybe it does not work as I expected? [python-setuptools (bundles %)]$ fedpkg prep Not downloading already downloaded setuptools-65.5.1.tar.gz Could not execute prep: Could not find the release/dist from branch name bundles Please specify with --release Right, it looks like you interpreted "outside of an established dist-git repository" to cover the case where you do have a Git repository, but are in a local branch with a custom name. Unfortunately, currently only the case where there is no Git repository at all is covered. Mea culpa. I assumed that's the case because I don't use fedpkg outside of git much. I presume that in your example you intend to eventually create a pull request. Fedpkg should have a great support for that as well, but a bit (just a bit) more work is needed to cover that case. I suppose that it would be enough to, instead of printing the error you saw, fall back to using the same default mechanism that is used for the no-Git case. I will take a look at some point — unless somebody beats me to it, of course. I took a look at this, and making '--release rawhide' for unknown branches is very easy [1]. I did not create a pull request yet, because I am a bit unsure if this is a good idea. My assumption is still that the vast majority of unknown branches are created for Rawhide pull requests. But for the ones that are for some other purpose, the default behavior changes from asking to be explicit with --release, to doing the wrong thing. There would be log output notifying about defaulting to 'rawhide', and the --release parameter could still be used to select the correct release. So maybe convenience for the majority case weighs more than some risk for the minority case? [1]: https://pagure.io/fork/oturpe/fedpkg/c/712dc656c4b06dafb693e5048baef45a0d82e973 ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Release rpkg-1.66 and fedpkg-1.44
On 09. 03. 23 10:05, Otto Liljalaakso wrote: Miro Hrončok kirjoitti 8.3.2023 klo 17.29: On 08. 03. 23 9:29, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Mar 08, 2023 at 08:13:57AM +0100, Ondrej Nosek wrote: Changelog (web documentation): https://docs.pagure.org/rpkg/releases/1.66.html https://docs.pagure.org/fedpkg/releases/1.44.html In Fedora, the principle is to perform all modifications in ‘Rawhide’ first. Thus, it makes sense to assume that any work that happens outside of an established dist-git repository is targeting Rawhide. Previously, the user had to manually specify --release rawhide on every invocation. That sounds wonderful! However, maybe it does not work as I expected? [python-setuptools (bundles %)]$ fedpkg prep Not downloading already downloaded setuptools-65.5.1.tar.gz Could not execute prep: Could not find the release/dist from branch name bundles Please specify with --release [python-setuptools (bundles %)]$ rpm -q fedpkg fedpkg-1.44-2.fc37.noarch [python-setuptools (bundles %)]$ rpm -q rpkg-common rpkg-common-1.66-3.fc37.noarch Right, it looks like you interpreted "outside of an established dist-git repository" to cover the case where you do have a Git repository, but are in a local branch with a custom name. Unfortunately, currently only the case where there is no Git repository at all is covered. Mea culpa. I assumed that's the case because I don't use fedpkg outside of git much. I presume that in your example you intend to eventually create a pull request. Fedpkg should have a great support for that as well, but a bit (just a bit) more work is needed to cover that case. I suppose that it would be enough to, instead of printing the error you saw, fall back to using the same default mechanism that is used for the no-Git case. I will take a look at some point — unless somebody beats me to it, of course. Thanks, Otto. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Release rpkg-1.66 and fedpkg-1.44
Miro Hrončok kirjoitti 8.3.2023 klo 17.29: On 08. 03. 23 9:29, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Mar 08, 2023 at 08:13:57AM +0100, Ondrej Nosek wrote: Changelog (web documentation): https://docs.pagure.org/rpkg/releases/1.66.html https://docs.pagure.org/fedpkg/releases/1.44.html In Fedora, the principle is to perform all modifications in ‘Rawhide’ first. Thus, it makes sense to assume that any work that happens outside of an established dist-git repository is targeting Rawhide. Previously, the user had to manually specify --release rawhide on every invocation. That sounds wonderful! However, maybe it does not work as I expected? [python-setuptools (bundles %)]$ fedpkg prep Not downloading already downloaded setuptools-65.5.1.tar.gz Could not execute prep: Could not find the release/dist from branch name bundles Please specify with --release [python-setuptools (bundles %)]$ rpm -q fedpkg fedpkg-1.44-2.fc37.noarch [python-setuptools (bundles %)]$ rpm -q rpkg-common rpkg-common-1.66-3.fc37.noarch Right, it looks like you interpreted "outside of an established dist-git repository" to cover the case where you do have a Git repository, but are in a local branch with a custom name. Unfortunately, currently only the case where there is no Git repository at all is covered. I presume that in your example you intend to eventually create a pull request. Fedpkg should have a great support for that as well, but a bit (just a bit) more work is needed to cover that case. I suppose that it would be enough to, instead of printing the error you saw, fall back to using the same default mechanism that is used for the no-Git case. I will take a look at some point — unless somebody beats me to it, of course. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Release rpkg-1.66 and fedpkg-1.44
On 08. 03. 23 15:40, Miro Hrončok wrote: On 08. 03. 23 9:29, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Mar 08, 2023 at 08:13:57AM +0100, Ondrej Nosek wrote: Hi all, a new version rpkg-1.66 together with fedpkg-1.44 are released containing both features and bugfixes. Currently, only Fedora 37 (and Rawhide) packages are present in stable repositories. Other supported packages are waiting in testing repositories and should be available in stable in the next two days. Changelog (web documentation): https://docs.pagure.org/rpkg/releases/1.66.html https://docs.pagure.org/fedpkg/releases/1.44.html In Fedora, the principle is to perform all modifications in ‘Rawhide’ first. Thus, it makes sense to assume that any work that happens outside of an established dist-git repository is targeting Rawhide. Previously, the user had to manually specify --release rawhide on every invocation. That sounds wonderful! Thank You! Thank You! Thank You! However, maybe it does not work as I expected? [python-setuptools (bundles %)]$ fedpkg prep Not downloading already downloaded setuptools-65.5.1.tar.gz Could not execute prep: Could not find the release/dist from branch name bundles Please specify with --release [python-setuptools (bundles %)]$ rpm -q fedpkg fedpkg-1.44-2.fc37.noarch [python-setuptools (bundles %)]$ rpm -q rpkg-common rpkg-common-1.66-3.fc37.noarch -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Release rpkg-1.66 and fedpkg-1.44
On 08. 03. 23 9:29, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Mar 08, 2023 at 08:13:57AM +0100, Ondrej Nosek wrote: Hi all, a new version rpkg-1.66 together with fedpkg-1.44 are released containing both features and bugfixes. Currently, only Fedora 37 (and Rawhide) packages are present in stable repositories. Other supported packages are waiting in testing repositories and should be available in stable in the next two days. Changelog (web documentation): https://docs.pagure.org/rpkg/releases/1.66.html https://docs.pagure.org/fedpkg/releases/1.44.html In Fedora, the principle is to perform all modifications in ‘Rawhide’ first. Thus, it makes sense to assume that any work that happens outside of an established dist-git repository is targeting Rawhide. Previously, the user had to manually specify --release rawhide on every invocation. That sounds wonderful! Thank You! Thank You! Thank You! -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Release rpkg-1.66 and fedpkg-1.44
On 3/8/23 00:29, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Mar 08, 2023 at 08:13:57AM +0100, Ondrej Nosek wrote: Hi all, a new version rpkg-1.66 together with fedpkg-1.44 are released containing both features and bugfixes. Currently, only Fedora 37 (and Rawhide) packages are present in stable repositories. Other supported packages are waiting in testing repositories and should be available in stable in the next two days. Changelog (web documentation): https://docs.pagure.org/rpkg/releases/1.66.html https://docs.pagure.org/fedpkg/releases/1.44.html In Fedora, the principle is to perform all modifications in ‘Rawhide’ first. Thus, it makes sense to assume that any work that happens outside of an established dist-git repository is targeting Rawhide. Previously, the user had to manually specify --release rawhide on every invocation. That sounds wonderful! Zbyszek I agree, this is a great change. Thank you! -Tom ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Release rpkg-1.66 and fedpkg-1.44
Zbigniew Jędrzejewski-Szmek kirjoitti 8.3.2023 klo 10.29: On Wed, Mar 08, 2023 at 08:13:57AM +0100, Ondrej Nosek wrote: Hi all, a new version rpkg-1.66 together with fedpkg-1.44 are released containing both features and bugfixes. Currently, only Fedora 37 (and Rawhide) packages are present in stable repositories. Other supported packages are waiting in testing repositories and should be available in stable in the next two days. Changelog (web documentation): https://docs.pagure.org/rpkg/releases/1.66.html https://docs.pagure.org/fedpkg/releases/1.44.html In Fedora, the principle is to perform all modifications in ‘Rawhide’ first. Thus, it makes sense to assume that any work that happens outside of an established dist-git repository is targeting Rawhide. Previously, the user had to manually specify --release rawhide on every invocation. That sounds wonderful! Thank you for the encouraging feedback. I think Fedora needs one tool that provides a consistent and simple experience, usable for all normal packaging tasks. Working with specfiles outside of Git repositories falls into that category, be it for preparing a new package, reviewing them or just playing around with a specfile you just downloaded from somewhere. The pull request to move the harmless but scary-looking "Failed Git this-and-that" printouts was just merged. With that fix in, I think when rpkg 1.67 is released, the no-Git use case for fedpkg will finally be in good shape. Apart from that, there is still the serious problem that 'fedpkg import' and rpmautospec do not play well together. But, I think that is fixable too, and I intend to look at that next. If anybody knows of another case where things do not work nicely, I would be interested in hearing about it and making it work. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Release rpkg-1.66 and fedpkg-1.44
On Wed, Mar 08, 2023 at 08:13:57AM +0100, Ondrej Nosek wrote: > Hi all, > a new version rpkg-1.66 together with fedpkg-1.44 are released containing > both features and bugfixes. > Currently, only Fedora 37 (and Rawhide) packages are present in stable > repositories. > Other supported packages are waiting in testing repositories and should be > available in stable in the next two days. > > Changelog (web documentation): > https://docs.pagure.org/rpkg/releases/1.66.html > https://docs.pagure.org/fedpkg/releases/1.44.html In Fedora, the principle is to perform all modifications in ‘Rawhide’ first. Thus, it makes sense to assume that any work that happens outside of an established dist-git repository is targeting Rawhide. Previously, the user had to manually specify --release rawhide on every invocation. That sounds wonderful! Zbyszek ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Release rpkg-1.66 and fedpkg-1.44
Hi all, a new version rpkg-1.66 together with fedpkg-1.44 are released containing both features and bugfixes. Currently, only Fedora 37 (and Rawhide) packages are present in stable repositories. Other supported packages are waiting in testing repositories and should be available in stable in the next two days. Changelog (web documentation): https://docs.pagure.org/rpkg/releases/1.66.html https://docs.pagure.org/fedpkg/releases/1.44.html Both released (rpkg & fedpkg) versions need to be installed together, they contain some changes incompatible with older packages. Updates: https://bodhi.fedoraproject.org/updates/?builds=rpkg-1.66-3.el7=rpkg-1.66-3.el8=rpkg-1.66-3.el9=rpkg-1.66-3.fc39=rpkg-1.66-3.fc36=rpkg-1.66-3.fc37=rpkg-1.66-3.fc38=fedpkg-1.44-2.el7=fedpkg-1.44-2.el8=fedpkg-1.44-2.el9=fedpkg-1.44-2.fc39=fedpkg-1.44-2.fc36=fedpkg-1.44-2.fc37=fedpkg-1.44-2.fc38 Alternative link: https://bodhi.fedoraproject.org/updates/?packages=rpkg=1 https://bodhi.fedoraproject.org/updates/?packages=fedpkg=1 rpkg is also available from PyPI. Thanks to all contributors. Special thanks to Otto Liljalaakso , who contributed to many pull-requests. Regards > ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
