Re: Request for assistance: zfs-fuse

2022-08-10 Thread Daniel P . Berrangé
On Wed, Aug 10, 2022 at 07:31:37AM -0400, Neal Gompa wrote:
> On Wed, Aug 10, 2022 at 7:21 AM Richard W.M. Jones  wrote:
> >
> > On Tue, Aug 09, 2022 at 04:51:03PM +, Gwyn Ciesla via devel wrote:
> > > Good morning!
> > >
> > > zfs-fuse is FTBFS starting with f36.
> > >
> > > https://bugzilla.redhat.com/show_bug.cgi?id=2047144
> > >
> > > I've been banging my head on it for a long time, to no avail. I can get 
> > > around the SConstruct failure by removing some environment variables, and 
> > > then I hit a linking issue I can't get past.
> > >
> > > Only libguestfs and libvirt require this, other that users with ZFS 
> > > filesystems, but I'd rather not retire it if it can be avoided.
> >
> > We can drop this dep if needed.  It would mean we could not inspect
> > guests that use ZFS, but they are very rare.
> >
> 
> It also means that ZFS code is enabled and useful if people want to
> use OpenZFS instead.

I don't believe that there's any compile time dep on zfs-fuse anymore.
Previously we'd probe for the binaries at build time, but now we can
just unconditionally enable the code and locate them at runtime.

IOW, we can drop the zfs-fuse dep, and still have the ZFS code enabled
in the build, allowing use of OpenZFS.

With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Request for assistance: zfs-fuse

2022-08-10 Thread Neal Gompa
On Wed, Aug 10, 2022 at 7:21 AM Richard W.M. Jones  wrote:
>
> On Tue, Aug 09, 2022 at 04:51:03PM +, Gwyn Ciesla via devel wrote:
> > Good morning!
> >
> > zfs-fuse is FTBFS starting with f36.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=2047144
> >
> > I've been banging my head on it for a long time, to no avail. I can get 
> > around the SConstruct failure by removing some environment variables, and 
> > then I hit a linking issue I can't get past.
> >
> > Only libguestfs and libvirt require this, other that users with ZFS 
> > filesystems, but I'd rather not retire it if it can be avoided.
>
> We can drop this dep if needed.  It would mean we could not inspect
> guests that use ZFS, but they are very rare.
>

It also means that ZFS code is enabled and useful if people want to
use OpenZFS instead.


-- 
真実はいつも一つ!/ Always, there's only one truth!
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Request for assistance: zfs-fuse

2022-08-10 Thread Richard W.M. Jones
On Tue, Aug 09, 2022 at 04:51:03PM +, Gwyn Ciesla via devel wrote:
> Good morning!
> 
> zfs-fuse is FTBFS starting with f36.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2047144
> 
> I've been banging my head on it for a long time, to no avail. I can get 
> around the SConstruct failure by removing some environment variables, and 
> then I hit a linking issue I can't get past.
> 
> Only libguestfs and libvirt require this, other that users with ZFS 
> filesystems, but I'd rather not retire it if it can be avoided.

We can drop this dep if needed.  It would mean we could not inspect
guests that use ZFS, but they are very rare.

Rich.

> Thanks in advance,
> 
> -- 
> Gwyn Ciesla
> she/her/hers
>  
> in your fear, seek only peace 
> in your fear, seek only love
> -d. bowie
> 
> 
> Sent with Proton Mail secure email.




> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> Do not reply to spam, report it: 
> https://pagure.io/fedora-infrastructure/new_issue


-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Request for assistance: zfs-fuse

2022-08-09 Thread Vitaly Zaitsev via devel

On 09/08/2022 20:17, Gwyn Ciesla via devel wrote:

+ export CCFLAGS=-O2 -flto=auto -ffat-lto-objects -fexceptions -g 
-grecord-gcc-switches


Export must be quoted. GCC compiler options - must not.

Try removing optim='%{optflags}' from your SPEC. It should automatically 
pick flags from $CCFLAGS.


--
Sincerely,
  Vitaly Zaitsev (vit...@easycoding.org)
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Request for assistance: zfs-fuse

2022-08-09 Thread Gwyn Ciesla via devel


--- Original Message ---
On Tuesday, August 9th, 2022 at 1:31 PM, Daniel P. Berrangé 
 wrote:


> On Tue, Aug 09, 2022 at 04:51:03PM +, Gwyn Ciesla via devel wrote:
> 

> > Good morning!
> > 

> > zfs-fuse is FTBFS starting with f36.
> > 

> > https://bugzilla.redhat.com/show_bug.cgi?id=2047144
> > 

> > I've been banging my head on it for a long time, to no avail. I can get 
> > around the SConstruct failure by removing some environment variables, and 
> > then I hit a linking issue I can't get past.
> 

> 

> Most problems are caused by GCC 10 no longer merging duplicate global
> variable storage. This was super tedios to resolve. I started with
> the gcc10_fixes.patch from Debian and had to tweak it even more.
> 

> A build system bug was causing the extra quotes in compiler options.
> 

> The code is broken wrt -Wformat-security. So this has to be turned
> off, unless someone wants to audit all the printf() calls and fix
> them up. I'd recommend the latter really, but I attach the quick
> fix since that is at least no more awful than it has been for every
> Fedora release previously.
> 

> So in the RPM spec add
> 

> diff --git a/zfs-fuse.spec b/zfs-fuse.spec
> index b26c656..84b6eb0 100644
> --- a/zfs-fuse.spec
> +++ b/zfs-fuse.spec
> @@ -17,6 +17,8 @@ Patch0: zfs-fuse-0.7.2.2-stack.patch
> Patch1: zfs-fuse-0.7.2.2-python3.patch
> Patch2: tirpc.patch
> Patch3: common.patch
> +Patch4: gcc.patch
> +
> BuildRequires: gcc
> BuildRequires: fuse-devel libaio-devel perl-generators scons gcc-c++
> BuildRequires: zlib-devel openssl-devel libattr-devel lzo-devel bzip2-devel 
> xz-devel
> @@ -50,6 +52,7 @@ operating system.
> %patch1 -p1
> %patch2 -p1
> %patch3 -p0
> +%patch4 -p1
> 

> f=LICENSE
> mv $f $f.iso88591
> @@ -63,6 +66,7 @@ chmod -x contrib/zfsstress.py
> cp -f /usr/lib/rpm/redhat/config.{guess,sub} src/lib/libumem/
> 

> %build
> +%define _warning_options '-Wall'
> export CCFLAGS="%{optflags}"
> pushd src
> 

> 

> The gcc.patch is attached.
> 

> > Only libguestfs and libvirt require this, other that users with
> > ZFS filesystems, but I'd rather not retire it if it can be avoided.
> 

> 

> Don't let libvirt/libguestfs force you to keep maintaining zfs-fuse.
> 

> If you want to retire it, we'll just disable zfs in libvirt/libguestfs.
> 

> Honestly I'd retire it, given it is dead upstream, unless someone
> wants to re-incarnate the upstream project and bring the code upto
> modern standards. Even with the patches there's still tonnes of
> (non-fatal) compiler warnings that really ought to be evaluated
> for correctness.

That did the trick, thank you! 


I'd like to keep it around at least for awhile. I'm not sure it's worth that 
level of maintenance, at least by me, who doesn't use ZFS. It *is* worth quick 
fixes like this, IMHO.


> With regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

signature.asc
Description: OpenPGP digital signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Request for assistance: zfs-fuse

2022-08-09 Thread Daniel P . Berrangé
On Tue, Aug 09, 2022 at 04:51:03PM +, Gwyn Ciesla via devel wrote:
> Good morning!
> 
> zfs-fuse is FTBFS starting with f36.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2047144
> 
> I've been banging my head on it for a long time, to no avail. I can get 
> around the SConstruct failure by removing some environment variables, and 
> then I hit a linking issue I can't get past.

Most problems are caused by GCC 10 no longer merging duplicate global
variable storage. This was super tedios to resolve. I started with
the gcc10_fixes.patch from Debian and had to tweak it even more.

A build system bug was causing the extra quotes in compiler options.

The code is broken wrt -Wformat-security. So this has to be turned
off, unless someone wants to audit all the printf() calls and fix
them up. I'd recommend the latter really, but I attach the quick
fix since that is at least no more awful than it has been for every
Fedora release previously.

So in the RPM spec add

diff --git a/zfs-fuse.spec b/zfs-fuse.spec
index b26c656..84b6eb0 100644
--- a/zfs-fuse.spec
+++ b/zfs-fuse.spec
@@ -17,6 +17,8 @@ Patch0:   zfs-fuse-0.7.2.2-stack.patch
 Patch1:   zfs-fuse-0.7.2.2-python3.patch
 Patch2:   tirpc.patch
 Patch3:   common.patch
+Patch4:   gcc.patch
+
 BuildRequires:  gcc
 BuildRequires:fuse-devel libaio-devel perl-generators scons gcc-c++
 BuildRequires:zlib-devel openssl-devel libattr-devel lzo-devel bzip2-devel 
xz-devel
@@ -50,6 +52,7 @@ operating system.
 %patch1 -p1
 %patch2 -p1
 %patch3 -p0
+%patch4 -p1
 
 f=LICENSE
 mv $f $f.iso88591
@@ -63,6 +66,7 @@ chmod -x contrib/zfsstress.py
 cp -f /usr/lib/rpm/redhat/config.{guess,sub} src/lib/libumem/
 
 %build
+%define _warning_options '-Wall'
 export CCFLAGS="%{optflags}"
 pushd src
 

The gcc.patch is attached.

> Only libguestfs and libvirt require this, other that users with
> ZFS filesystems, but I'd rather not retire it if it can be avoided.

Don't let libvirt/libguestfs force you to keep maintaining zfs-fuse.

If you want to retire it, we'll just disable zfs in libvirt/libguestfs.

Honestly I'd retire it, given it is dead upstream, unless someone
wants to re-incarnate the upstream project and bring the code upto
modern standards.  Even with the patches there's still tonnes of
(non-fatal) compiler warnings that really ought to be evaluated
for correctness.

With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
diff -x src/lib/libsolkerncompat/include/sys/utsname.h -rup 
zfs-fuse-0.7.2.2.orig/src/cmd/mount_zfs/mount_zfs.c 
zfs-fuse-0.7.2.2.new/src/cmd/mount_zfs/mount_zfs.c
--- zfs-fuse-0.7.2.2.orig/src/cmd/mount_zfs/mount_zfs.c 2015-11-24 
11:32:31.0 -0500
+++ zfs-fuse-0.7.2.2.new/src/cmd/mount_zfs/mount_zfs.c  2022-08-09 
14:09:10.011720713 -0400
@@ -35,6 +35,7 @@
 #include 
 
 libzfs_handle_t *g_zfs;
+int aok;
 
 typedef struct option_map {
const char *name;
diff -x src/lib/libsolkerncompat/include/sys/utsname.h -rup 
zfs-fuse-0.7.2.2.orig/src/cmd/zfs/zfs_main.c 
zfs-fuse-0.7.2.2.new/src/cmd/zfs/zfs_main.c
--- zfs-fuse-0.7.2.2.orig/src/cmd/zfs/zfs_main.c2022-08-09 
13:12:22.885797414 -0400
+++ zfs-fuse-0.7.2.2.new/src/cmd/zfs/zfs_main.c 2022-08-09 14:11:52.170622824 
-0400
@@ -57,6 +57,7 @@
 #include "zfs_comutil.h"
 
 libzfs_handle_t *g_zfs;
+int aok;
 
 static FILE *mnttab_file;
 static char history_str[HIS_MAX_RECORD_LEN];
diff -x src/lib/libsolkerncompat/include/sys/utsname.h -rup 
zfs-fuse-0.7.2.2.orig/src/cmd/zfs/zfs_util.h 
zfs-fuse-0.7.2.2.new/src/cmd/zfs/zfs_util.h
--- zfs-fuse-0.7.2.2.orig/src/cmd/zfs/zfs_util.h2015-11-24 
11:32:31.0 -0500
+++ zfs-fuse-0.7.2.2.new/src/cmd/zfs/zfs_util.h 2022-08-09 14:05:33.980183340 
-0400
@@ -34,7 +34,7 @@ extern "C" {
 
 void * safe_malloc(size_t size);
 void nomem(void);
-libzfs_handle_t *g_zfs;
+extern libzfs_handle_t *g_zfs;
 
 #ifdef __cplusplus
 }
diff -x src/lib/libsolkerncompat/include/sys/utsname.h -rup 
zfs-fuse-0.7.2.2.orig/src/cmd/zpool/zpool_main.c 
zfs-fuse-0.7.2.2.new/src/cmd/zpool/zpool_main.c
--- zfs-fuse-0.7.2.2.orig/src/cmd/zpool/zpool_main.c2015-11-24 
11:32:31.0 -0500
+++ zfs-fuse-0.7.2.2.new/src/cmd/zpool/zpool_main.c 2022-08-09 
14:13:03.659138821 -0400
@@ -53,6 +53,8 @@
 #include "statcommon.h"
 #include "format.h"
 
+int aok;
+
 static int zpool_do_create(int, char **);
 static int zpool_do_destroy(int, char **);
 
@@ -181,6 +183,8 @@ static char history_str[HIS_MAX_RECORD_L
 
 static uint_t timestamp_fmt = NODATE;
 
+libzfs_handle_t *g_zfs;
+
 static const char *
 get_usage(zpool_help_t idx) {
switch (idx) {
diff -x src/lib/libsolkerncompat/include/sys/utsname.h -rup 
zfs-fuse-0.7.2.2.orig/src/cmd/zpool/zpool_util.h 
zfs-fuse-0.7.2.2.new/src/cmd/zpool/zpool_util.h
--- 

Re: Request for assistance: zfs-fuse

2022-08-09 Thread Nathanael D. Noblet
On Tue, 2022-08-09 at 18:17 +, Gwyn Ciesla via devel wrote:
> 
> 
> > gcc -o cmd/mount_zfs/mount_zfs.o -c "-O2 -flto=auto -ffat-lto-
> > objects
> > -fexceptions -g -grecord-gcc-switches -pipe -Wall
> > -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> > -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-
> > hardened-cc1
> > -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-
> > cc1
> > -m64 -mcpu=power8 -mtune=power8 -fasynchronous-unwind-tables
> > -fstack-clash-protection" -pipe -Wall -std=c99 -Wno-switch -Wno-
> > unused
> > -Wno-missing-braces -Wno-parentheses -Wno-uninitialized -Wcast-
> > align
> > -fno-strict-aliasing -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -
> > D_REENTRANT
> > -DTEXT_DOMAIN=\"zfs-fuse\" -ggdb -DDEBUG -fPIC -DLINUX_AIO
> > -I/usr/include/tirpc -Ilib/libuutil/include -Ilib/libnvpair/include
> > -Ilib/libumem/include -Ilib/libzfscommon/include -
> > Ilib/libzpool/include
> > -Ilib/libzfs/include -Ilib/libsolcompat/include -
> > Ilib/libavl/include
> > cmd/mount_zfs/mount_zfs.c
> > cc1: error: argument to '-O' should be a non-negative integer, 'g',
> > 's',
> > 'z' or 'fast'
> > 
> 
> Doesn't help:
> 
> + '[' -f /usr/lib/rpm/generate-rpm-note.sh ']'
> + /usr/lib/rpm/generate-rpm-note.sh zfs-fuse 0.7.2.2-22.fc38 x86_64
> + cd zfs-fuse-0.7.2.2
> + export CCFLAGS=-O2 -flto=auto -ffat-lto-objects -fexceptions -g -
> grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-
> D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -
> specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-
> strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -
> mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -
> fcf-protection
> + CCFLAGS=-O2
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-flto=auto': not a valid
> identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-ffat-lto-objects': not a
> valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-fexceptions': not a valid
> identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-g': not a valid
> identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-grecord-gcc-switches':
> not a valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-pipe': not a valid
> identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-Wall': not a valid
> identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-Werror=format-security':
> not a valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-Wp,-D_FORTIFY_SOURCE=2':
> not a valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-Wp,-
> D_GLIBCXX_ASSERTIONS': not a valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-
> specs=/usr/lib/rpm/redhat/redhat-hardened-cc1': not a valid
> identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-fstack-protector-strong':
> not a valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-
> specs=/usr/lib/rpm/redhat/redhat-annobin-cc1': not a valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-m64': not a valid
> identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-mtune=generic': not a
> valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-fasynchronous-unwind-
> tables': not a valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-fstack-clash-protection':
> not a valid identifier
> /var/tmp/rpm-tmp.u56vY5: line 42: export: `-fcf-protection': not a
> valid identifier
> error: Bad exit status from /var/tmp/rpm-tmp.u56vY5 (%build)
> 


I'm no expert but you're hitting two different issues. Your first error
message was running the compilre gcc with options being quoted.

gcc -o cmd/mount_zfs/mount_zfs.o -c "-O2 -flto=auto "

The second is when the environment variable is being exported.

export CCFLAGS=-O2 -flto=auto ...

I think you want export CCFLAGS="-O2 -flto=auto" and the gcc line to
not quote the env var.

Maybe post the spec somewhere?

Sincerely,
-- 
Nathanael
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Request for assistance: zfs-fuse

2022-08-09 Thread Gwyn Ciesla via devel


--- Original Message ---
On Tuesday, August 9th, 2022 at 12:06 PM, Vitaly Zaitsev via devel 
 wrote:


> On 09/08/2022 18:51, Gwyn Ciesla via devel wrote:
> 

> > zfs-fuse is FTBFS starting with f36.
> 

> 

> gcc -o cmd/mount_zfs/mount_zfs.o -c "-O2 -flto=auto -ffat-lto-objects
> -fexceptions -g -grecord-gcc-switches -pipe -Wall
> -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1
> -m64 -mcpu=power8 -mtune=power8 -fasynchronous-unwind-tables
> -fstack-clash-protection" -pipe -Wall -std=c99 -Wno-switch -Wno-unused
> -Wno-missing-braces -Wno-parentheses -Wno-uninitialized -Wcast-align
> -fno-strict-aliasing -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_REENTRANT
> -DTEXT_DOMAIN=\"zfs-fuse\" -ggdb -DDEBUG -fPIC -DLINUX_AIO
> -I/usr/include/tirpc -Ilib/libuutil/include -Ilib/libnvpair/include
> -Ilib/libumem/include -Ilib/libzfscommon/include -Ilib/libzpool/include
> -Ilib/libzfs/include -Ilib/libsolcompat/include -Ilib/libavl/include
> cmd/mount_zfs/mount_zfs.c
> cc1: error: argument to '-O' should be a non-negative integer, 'g', 's',
> 'z' or 'fast'
> 

> Remove the quotes around Fedora build flags.
> 

> Correct:
> -O2 -flto=auto -ffat-lto-objects -fexceptions -g ...
> 

> Bogus:
> "-O2 -flto=auto -ffat-lto-objects -fexceptions -g ..."

Doesn't help:

+ '[' -f /usr/lib/rpm/generate-rpm-note.sh ']'
+ /usr/lib/rpm/generate-rpm-note.sh zfs-fuse 0.7.2.2-22.fc38 x86_64
+ cd zfs-fuse-0.7.2.2
+ export CCFLAGS=-O2 -flto=auto -ffat-lto-objects -fexceptions -g 
-grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection
+ CCFLAGS=-O2
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-flto=auto': not a valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-ffat-lto-objects': not a valid 
identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-fexceptions': not a valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-g': not a valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-grecord-gcc-switches': not a valid 
identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-pipe': not a valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-Wall': not a valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-Werror=format-security': not a 
valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-Wp,-D_FORTIFY_SOURCE=2': not a 
valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-Wp,-D_GLIBCXX_ASSERTIONS': not a 
valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: 
`-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1': not a valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-fstack-protector-strong': not a 
valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: 
`-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1': not a valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-m64': not a valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-mtune=generic': not a valid 
identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-fasynchronous-unwind-tables': not a 
valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-fstack-clash-protection': not a 
valid identifier
/var/tmp/rpm-tmp.u56vY5: line 42: export: `-fcf-protection': not a valid 
identifier
error: Bad exit status from /var/tmp/rpm-tmp.u56vY5 (%build)




> --
> Sincerely,
> Vitaly Zaitsev (vit...@easycoding.org)
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> Do not reply to spam, report it: 
> https://pagure.io/fedora-infrastructure/new_issue

signature.asc
Description: OpenPGP digital signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Request for assistance: zfs-fuse

2022-08-09 Thread Vitaly Zaitsev via devel

On 09/08/2022 18:51, Gwyn Ciesla via devel wrote:

zfs-fuse is FTBFS starting with f36.


gcc -o cmd/mount_zfs/mount_zfs.o -c "-O2 -flto=auto -ffat-lto-objects 
-fexceptions -g -grecord-gcc-switches -pipe -Wall 
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 
-Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
-fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 
-m64 -mcpu=power8 -mtune=power8 -fasynchronous-unwind-tables 
-fstack-clash-protection" -pipe -Wall -std=c99 -Wno-switch -Wno-unused 
-Wno-missing-braces -Wno-parentheses -Wno-uninitialized -Wcast-align 
-fno-strict-aliasing -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_REENTRANT 
-DTEXT_DOMAIN=\"zfs-fuse\" -ggdb -DDEBUG -fPIC -DLINUX_AIO 
-I/usr/include/tirpc -Ilib/libuutil/include -Ilib/libnvpair/include 
-Ilib/libumem/include -Ilib/libzfscommon/include -Ilib/libzpool/include 
-Ilib/libzfs/include -Ilib/libsolcompat/include -Ilib/libavl/include 
cmd/mount_zfs/mount_zfs.c
cc1: error: argument to '-O' should be a non-negative integer, 'g', 's', 
'z' or 'fast'


Remove the quotes around Fedora build flags.

Correct:
-O2 -flto=auto -ffat-lto-objects -fexceptions -g ...

Bogus:
"-O2 -flto=auto -ffat-lto-objects -fexceptions -g ..."

--
Sincerely,
  Vitaly Zaitsev (vit...@easycoding.org)
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Request for assistance: zfs-fuse

2022-08-09 Thread Gwyn Ciesla via devel
Good morning!

zfs-fuse is FTBFS starting with f36.

https://bugzilla.redhat.com/show_bug.cgi?id=2047144

I've been banging my head on it for a long time, to no avail. I can get around 
the SConstruct failure by removing some environment variables, and then I hit a 
linking issue I can't get past.

Only libguestfs and libvirt require this, other that users with ZFS 
filesystems, but I'd rather not retire it if it can be avoided.

Thanks in advance,

-- 
Gwyn Ciesla
she/her/hers
 
in your fear, seek only peace 
in your fear, seek only love
-d. bowie


Sent with Proton Mail secure email.

signature.asc
Description: OpenPGP digital signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue