Re: Review swap: voikko-fi (for Finnish spell-checking)

2021-02-07 Thread Ville-Pekka Vainio
Hi all,

This work is finally done and the packages are in Rawhide, in good
time before the beta. Thank you Miro and Zbyszek!
I think I found a fedpkg import bug while importing voikko-fi from
SRPM, I'll make a new thread about that.

-Ville-Pekka
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Review swap: voikko-fi (for Finnish spell-checking)

2021-01-24 Thread Miro Hrončok

On 24. 01. 21 19:43, Ville-Pekka Vainio wrote:

Hi,

This is a re-review for a rename and going from arch-specific to
noarch: https://bugzilla.redhat.com/show_bug.cgi?id=1919688

The arch-noarch stuff was discussed here:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/JSEYB5XU24HEX7BR2QVJ732MR5P52YJ6/

Voikko 4.3, which is needed to build this, is not yet in Rawhide. I'll
push it as soon as someone commits to working on this review. Pushing
Voikko 4.3 to Rawhide will break Finnish spell-checking until this
package is in Rawhide as well.


Please, avoid even a temporary breakage. Let's push the update and the renamed 
package together? You can get a review of voikko-fi just based on the copr repo 
you already have. I can take a look, but not sooner than tomorrow.


Adding some initial comments now.


The best packages for me to review would probably be autotools-based
C/C++ stuff and Python stuff. I usually have time for Fedora work only
during weekends.


Don't worry about it.

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Review swap: voikko-fi (for Finnish spell-checking)

2021-01-24 Thread Ville-Pekka Vainio
Hi,

This is a re-review for a rename and going from arch-specific to
noarch: https://bugzilla.redhat.com/show_bug.cgi?id=1919688

The arch-noarch stuff was discussed here:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/JSEYB5XU24HEX7BR2QVJ732MR5P52YJ6/

Voikko 4.3, which is needed to build this, is not yet in Rawhide. I'll
push it as soon as someone commits to working on this review. Pushing
Voikko 4.3 to Rawhide will break Finnish spell-checking until this
package is in Rawhide as well.

The best packages for me to review would probably be autotools-based
C/C++ stuff and Python stuff. I usually have time for Fedora work only
during weekends.

-Ville-Pekka
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org