Re: Unannounced soname bump: libotf

2023-07-27 Thread Michal Schorm
On Wed, Jul 26, 2023 at 5:32 PM Jason L Tibbitts III  wrote:
>
> > Gary Buhrmaster  writes:
>
> > I have found that using something like libfoo.so.X{,.*} in the %files
> > directive can be a useful reminder (enforcer) to reduce such surprises
> > (that particular glob presumes semantic versioning, and that minor and
> > patch level updates do not require rebuilds, but that is true much of
> > the time).
>
> In fact, excessively wide globbing here is explicitly discouraged by the
> packaging guidelines:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files
>
> Looking at the current spec, it uses "%{_libdir}/*.so.*"; had it
> followed this guideline, I believe this issue would not have occurred.

I agree, fixed:
https://src.fedoraproject.org/rpms/libotf/c/0ccd534c?branch=rawhide


--

Michal Schorm
Software Engineer
Core Services - Databases Team
Red Hat

--

On Wed, Jul 26, 2023 at 5:32 PM Jason L Tibbitts III  wrote:
>
> > Gary Buhrmaster  writes:
>
> > I have found that using something like libfoo.so.X{,.*} in the %files
> > directive can be a useful reminder (enforcer) to reduce such surprises
> > (that particular glob presumes semantic versioning, and that minor and
> > patch level updates do not require rebuilds, but that is true much of
> > the time).
>
> In fact, excessively wide globbing here is explicitly discouraged by the
> packaging guidelines:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files
>
> Looking at the current spec, it uses "%{_libdir}/*.so.*"; had it
> followed this guideline, I believe this issue would not have occurred.
>
>  - J<
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> Do not reply to spam, report it: 
> https://pagure.io/fedora-infrastructure/new_issue
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Unannounced soname bump: libotf

2023-07-26 Thread Jason L Tibbitts III
> Gary Buhrmaster  writes:

> I have found that using something like libfoo.so.X{,.*} in the %files
> directive can be a useful reminder (enforcer) to reduce such surprises
> (that particular glob presumes semantic versioning, and that minor and
> patch level updates do not require rebuilds, but that is true much of
> the time).

In fact, excessively wide globbing here is explicitly discouraged by the
packaging guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files

Looking at the current spec, it uses "%{_libdir}/*.so.*"; had it
followed this guideline, I believe this issue would not have occurred.

 - J<
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Unannounced soname bump: libotf

2023-07-26 Thread Gary Buhrmaster
On Wed, Jul 26, 2023 at 1:56 PM Michal Schorm  wrote:
>
> My apologies !
> I built the new version when cleaning old PRs and I failed to check
> for the soname bump.
> Thank you for cleaning up after me. I will try my best to remember to
> check it next time.

I have found that using something like
   libfoo.so.X{,.*}
in the %files directive can be a useful
reminder (enforcer) to reduce such
surprises (that particular glob presumes
semantic versioning, and that minor
and patch level updates do not require
rebuilds, but that is true much of the time).

To be fair, I have sometimes forgotten to
change the glob when I have intended to
bump the package/soname version in an
update, but at least I did get the intended
reminder!
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Unannounced soname bump: libotf

2023-07-26 Thread Michal Schorm
My apologies !
I built the new version when cleaning old PRs and I failed to check
for the soname bump.
Thank you for cleaning up after me. I will try my best to remember to
check it next time.

Michal

--

Michal Schorm
Software Engineer
Core Services - Databases Team
Red Hat

--

On Wed, Jul 26, 2023 at 3:02 PM Scott Talbert  wrote:
>
> On Tue, 25 Jul 2023, Scott Talbert wrote:
>
> >> libotf was just bumped from libotf.so.0 to libotf.so.1.
> >>
> >> $ dnf repoquery --whatrequires 'libotf.so.0()(64bit)' --disablerepo='*'
> >> --enablerepo=rawhide
> >> emacs-1:28.2-6.fc39.x86_64
> >> emacs-lucid-1:28.2-6.fc39.x86_64
> >> libotf-devel-0:0.9.13-22.fc38.x86_64
> >> m17n-lib-tools-0:1.8.2-1.fc39.x86_64
> >>
> >> Please announce soname bumps in advance and coordinate rebuilds in side
> >> tags. :)
> >
> > It looks like m17n-lib needs to be rebuilt first and then emacs can be
> > rebuilt.
> >
> > @mfabian, can you please take care of m17n-lib?
>
> Thanks @besser82 for taking care of these!
>
> Scott
>
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Unannounced soname bump: libotf

2023-07-26 Thread Scott Talbert

On Tue, 25 Jul 2023, Scott Talbert wrote:


libotf was just bumped from libotf.so.0 to libotf.so.1.

$ dnf repoquery --whatrequires 'libotf.so.0()(64bit)' --disablerepo='*' 
--enablerepo=rawhide

emacs-1:28.2-6.fc39.x86_64
emacs-lucid-1:28.2-6.fc39.x86_64
libotf-devel-0:0.9.13-22.fc38.x86_64
m17n-lib-tools-0:1.8.2-1.fc39.x86_64

Please announce soname bumps in advance and coordinate rebuilds in side 
tags. :)


It looks like m17n-lib needs to be rebuilt first and then emacs can be 
rebuilt.


@mfabian, can you please take care of m17n-lib?


Thanks @besser82 for taking care of these!

Scott
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Re: Unannounced soname bump: libotf

2023-07-25 Thread Scott Talbert

On Tue, 25 Jul 2023, Scott Talbert wrote:


libotf was just bumped from libotf.so.0 to libotf.so.1.

$ dnf repoquery --whatrequires 'libotf.so.0()(64bit)' --disablerepo='*' 
--enablerepo=rawhide

emacs-1:28.2-6.fc39.x86_64
emacs-lucid-1:28.2-6.fc39.x86_64
libotf-devel-0:0.9.13-22.fc38.x86_64
m17n-lib-tools-0:1.8.2-1.fc39.x86_64

Please announce soname bumps in advance and coordinate rebuilds in side tags. 
:)


It looks like m17n-lib needs to be rebuilt first and then emacs can be 
rebuilt.


@mfabian, can you please take care of m17n-lib?

Scott
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


Unannounced soname bump: libotf

2023-07-25 Thread Scott Talbert

libotf was just bumped from libotf.so.0 to libotf.so.1.

$ dnf repoquery --whatrequires 'libotf.so.0()(64bit)' --disablerepo='*' 
--enablerepo=rawhide
emacs-1:28.2-6.fc39.x86_64
emacs-lucid-1:28.2-6.fc39.x86_64
libotf-devel-0:0.9.13-22.fc38.x86_64
m17n-lib-tools-0:1.8.2-1.fc39.x86_64

Please announce soname bumps in advance and coordinate rebuilds in side 
tags.  :)


Scott
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue