Re: Asking for a review swap Was: Why no wdune sponsoring ?
* J. Scheurich [13/01/2019 09:42] :
>
> What can be improvided ?
Hi.
I reviewed your spec file and found a number of chnages that could me made.
* The tags would be more readable if their values were aligned.
* This is the longest description I've ever seen. I would shorten it.
* Some lines are over 75 chars long and should be split over several lines
It seems you modify the only entry in the %changelog when you update the spec
file. I usually start adding entries once I submit spec files to make it
clearer what has changed and when.
My version of your spec file is attached. I've haven't tried to build an rpm
from it so you probably want to test it through mock.
Emmanuel
%global extraver pl1216
Summary:A graphical X3D/VRML97 editor, simple 3D modeler and animation
tool
Name: wdune
Version:0.99
Release:1.%{extraver}%{?dist}
#Copyright: GPL
License:GPLv3+
URL:http://wdune.ourproject.org/
Source: ftp://ftp.ourproject.org/pub/wdune/wdune-%{version}.tar.bz2
BuildRequires: gcc-c++
BuildRequires: gawk
BuildRequires: make
BuildRequires: bash
BuildRequires: motif-devel
BuildRequires: libXi-devel
BuildRequires: libpng-devel
BuildRequires: libjpeg-devel
BuildRequires: mesa-libGLU-devel
BuildRequires: expat-devel
BuildRequires: flex
BuildRequires: bison
BuildRequires: libusb-devel
BuildRequires: CGAL-devel
BuildRequires: gmp-devel
BuildRequires: libcurl-devel
BuildRequires: ImageMagick
BuildRequires: aqsis-core
BuildRequires: freetype-devel
BuildRequires: bitstream-vera-sans-fonts
BuildRequires: desktop-file-utils
Requires: rcs
Requires: firefox
Requires: kolourpaint
Requires: audacity
Requires: lxterminal
Requires: ImageMagick
Requires: aqsis-core
Requires: bitstream-vera-sans-fonts
%description
The white_dune program is a graphical X3D/VRML97 editor,
simple extrusion/NURBS/Superformula 3D modeler and animation tool.
X3D and VRML97 are the ISO standard for displaying 3D data over the web.
With Cobweb or X3DOM it can displayed in any webgl enabled web browser.
This includes animation, real-time interaction and multimedia (image, movie,
sound).
Dune can read X3DV/VRML97 files, display and let the user change the
scene-graph and all fields of all nodes. The most powerful 3D modeling
features of white_dune support the VRML97 Amendment1 style NURBS nodes
and Superformula based PROTOs.
%prep
%setup -q
%build
%configure --with-optimization \
--without-devil \
--with-vrmlbrowser=firefox \
--with-helpurl="/usr/share/doc/wdune/docs/" \
--with-protobaseurl="/usr/share/doc/wdune/docs" \
--with-checkincommand="ci" \
--with-imageeditor="pinta" \
--with-imageeditor4kids="kolourpaint" \
--with-soundeditor=audacity
%make_build
%install
mkdir -p $RPM_BUILD_ROOT/%{_bindir}
mkdir -p $RPM_BUILD_ROOT/%{_mandir}/man1
mkdir -p $RPM_BUILD_ROOT/%{_datadir}/misc/white_dune
mkdir -p $RPM_BUILD_ROOT/%{_datadir}/applications
mkdir -p $RPM_BUILD_ROOT/%{_datadir}/icons/Bluecurve/48x48/apps
mkdir -p $RPM_BUILD_ROOT/%{_datadir}/pixmaps/
install -m 755 -p bin/dune $RPM_BUILD_ROOT/%{_bindir}/dune
install -m 755 -p bin/dune4kids $RPM_BUILD_ROOT/%{_bindir}/dune4kids
install -m 755 -p bin/illegal2vrml $RPM_BUILD_ROOT/%{_bindir}/illegal2vrml
install -m 644 -p desktop/kde/dune.desktop
$RPM_BUILD_ROOT/%{_datadir}/applications/dune.desktop
install -m 644 -p desktop/kde/dune.png
$RPM_BUILD_ROOT/%{_datadir}/pixmaps/dune.png
install -m 644 -p desktop/kde/dune4kids.desktop
$RPM_BUILD_ROOT/%{_datadir}/applications/dune4kids.desktop
install -m 644 -p desktop/kde/dune4kids.png
$RPM_BUILD_ROOT/%{_datadir}/pixmaps/dune4kids.png
install -m 644 -p man/dune.1 $RPM_BUILD_ROOT/%{_mandir}/man1/dune.1
install -m 644 -p man/dune4kids.1 $RPM_BUILD_ROOT/%{_mandir}/man1/dune4kids.1
install -m 644 -p man/illegal2vrml.1
$RPM_BUILD_ROOT/%{_mandir}/man1/illegal2vrml.1
desktop-file-install --add-category="Graphics" \
--delete-original \
--dir=%{buildroot}%{_datadir}/applications \
%{buildroot}/%{_datadir}/applications/dune.desktop
%files
%doc README.txt COPYING.txt docs
%{_bindir}/dune
%{_bindir}dune4kids
%{_bindir}/illegal2vrml
%{_datadir}/applications/dune.desktop
%{_datadir}/pixmaps/dune.png
%{_datadir}/applications/dune4kids.desktop
%{_datadir}/pixmaps/dune4kids.png
%{_mandir}/man1/dune.1*
%{_mandir}/man1/dune4kids.1*
%{_mandir}/man1/illegal2vrml.1*
%changelog
* Wed Sep 20 2017 J. Scheurich 0.99pl765
-- Initial packaging
Release: 1%{?dist}
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
Re: Asking for a review swap Was: Why no wdune sponsoring ?
On Sun, 13 Jan 2019 09:55:22 +0100 Dan Horák wrote: > On Sun, 13 Jan 2019 09:42:55 +0100 > "J. Scheurich" wrote: > > > > > > I have looked at your spec/srpm and it needs much improvement, > > > > What can be improvided ? > > The srpm produces a valid rpm on all architecures, > > all tips of > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1653481 > > > > has been followed. > > well, I can't even see the spec file, the Spec URL: points to a web > site, not to the spec file :-( There is a reason why the review > template has this entry. ah, there is a second review where it has been fixed Dan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Asking for a review swap Was: Why no wdune sponsoring ?
I added a comment to the bug review https://bugzilla.redhat.com/show_bug.cgi?id=1658153#c16 ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Asking for a review swap Was: Why no wdune sponsoring ?
On Sun, 13 Jan 2019 09:42:55 +0100 "J. Scheurich" wrote: > > > I have looked at your spec/srpm and it needs much improvement, > > What can be improvided ? > The srpm produces a valid rpm on all architecures, > all tips of > > https://bugzilla.redhat.com/show_bug.cgi?id=1653481 > > has been followed. well, I can't even see the spec file, the Spec URL: points to a web site, not to the spec file :-( There is a reason why the review template has this entry. Dan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Asking for a review swap Was: Why no wdune sponsoring ?
> I have looked at your spec/srpm and it needs much improvement, What can be improvided ? The srpm produces a valid rpm on all architecures, all tips of https://bugzilla.redhat.com/show_bug.cgi?id=1653481 has been followed. so long MUFTI ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Asking for a review swap Was: Why no wdune sponsoring ?
I have looked at your spec/srpm and it needs much improvement, it demonstrates that your rpm packaging skills are lacking . Did you even take the time to read the Fedora packaging guidelines? Currently I wouldn't consider sponsoring you and I doubt anyone else will till it improves. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why no wdune sponsoring ?
Fabio Valentini wrote: > - Since this is your first package, you as a *packager* have to be > sponsored by a "proven packager". No, by a packager sponsor. Those are 2 orthogonal concepts: There are sponsors that are not provenpackagers and there are provenpackagers that are not sponsors. (Only people who became sponsors a long time ago, as in my case, automatically got provenpackager access at the same time. This was changed in order to lower the barrier to becoming a sponsor. So these are now separate concepts that you have to apply for separately.) Kevin Kofler ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Asking for a review swap Was: Why no wdune sponsoring ?
Asking for a review swap is usually done as a post to this very "devel" mailing list, and it includes the package name, bugzilla link, and which kinds of packages you can review in return. package name: wdune (whitr_dune) bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1658153 I have experience in C, C++, java, sh, OpenGL, X11, awk, rpm... so long MUFTI ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why no wdune sponsoring ?
On Sat, 2019-01-12 at 11:18 +0100, Fabio Valentini wrote: > On Sat, Jan 12, 2019 at 10:23 AM J. Scheurich wrote: > > > > > LMGTFY (fedora review swap ) > > > > > > > > > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/5OPPTTNKQF2S5PUOX4HNAW5B7R4UFREU/ > > > > > > > > > > This review ends with > > > > https://bugzilla.redhat.com/show_bug.cgi?id=557546 > > > > > Fedora Update System 2010-03-23 23:30:09 UTC > > > telepathy-sunshine-0.1.6-1.fc13 has been pushed to the Fedora 13 > > > > stable repository. If problems still > > > persist, please make note of it in this bug report. > > > > Are there any other review requests which can return sponsorship ? > > I assume Sérgio posted that link as an example of how a request for > review swaps would look like, and not as a concrete bug for you to > look at. To summarize: Asking for a review swap is usually done as a > post to this very "devel" mailing list, and it includes the package > name, bugzilla link, and which kinds of packages you can review in > return. Exactly > > Googling "fedora review swap sponsor" shows nothing interesting 8-( > > Probably because "review swap" and "sponsorship" are two entirely > different and only slightly related things, but both of them need to > happen, before you can submit this package to fedora. > > In short: > - Since this is your first package, you as a *packager* have to be > sponsored by a "proven packager". This usually involves doing some > non-binding, informal reviews of pending packages to show that you > understand the Packaging Guidelines and process. > - Every submitted package (not only your first one) has to be > reviewed > by someone who already is a packager for fedora. This is to ensure > package correctness and quality, and legal conformity (licensing > appropriate, no patents involved). This can be done via "review > swaps", where two packagers review each other's package submissions > to > speed up the process. > > So, it's not your wdune package that needs to be sponsored, but you > as > a packager. yes , you need convince someone to sponsor you [1] [1] https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Convincing_someone_to_sponsor_you Best regards, > Also - according to > https://bugzilla.redhat.com/show_bug.cgi?id=1658153 - there have been > some comments on your package review, but it's still unassigned and > has not been formally approved. You'll need somebody to step as > "official" reviewer and to set the "fedora-review" flag > appropriately. > > I hope this clears things up for you. > > Fabio > > > so long > > MUFTI > > ___ > > devel mailing list -- devel@lists.fedoraproject.org > > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > > List Guidelines: > > https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: > > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org -- Sérgio M. B. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why no wdune sponsoring ?
On Sat, Jan 12, 2019 at 10:23 AM J. Scheurich wrote: > > > LMGTFY (fedora review swap ) > > > > > > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/5OPPTTNKQF2S5PUOX4HNAW5B7R4UFREU/ > > > > > > This review ends with > > https://bugzilla.redhat.com/show_bug.cgi?id=557546 > > | Fedora Update System 2010-03-23 23:30:09 UTC > > | telepathy-sunshine-0.1.6-1.fc13 has been pushed to the Fedora 13 > stable repository. If problems still > | persist, please make note of it in this bug report. > > Are there any other review requests which can return sponsorship ? I assume Sérgio posted that link as an example of how a request for review swaps would look like, and not as a concrete bug for you to look at. To summarize: Asking for a review swap is usually done as a post to this very "devel" mailing list, and it includes the package name, bugzilla link, and which kinds of packages you can review in return. > Googling "fedora review swap sponsor" shows nothing interesting 8-( Probably because "review swap" and "sponsorship" are two entirely different and only slightly related things, but both of them need to happen, before you can submit this package to fedora. In short: - Since this is your first package, you as a *packager* have to be sponsored by a "proven packager". This usually involves doing some non-binding, informal reviews of pending packages to show that you understand the Packaging Guidelines and process. - Every submitted package (not only your first one) has to be reviewed by someone who already is a packager for fedora. This is to ensure package correctness and quality, and legal conformity (licensing appropriate, no patents involved). This can be done via "review swaps", where two packagers review each other's package submissions to speed up the process. So, it's not your wdune package that needs to be sponsored, but you as a packager. Also - according to https://bugzilla.redhat.com/show_bug.cgi?id=1658153 - there have been some comments on your package review, but it's still unassigned and has not been formally approved. You'll need somebody to step as "official" reviewer and to set the "fedora-review" flag appropriately. I hope this clears things up for you. Fabio > so long > MUFTI > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why no wdune sponsoring ?
LMGTFY (fedora review swap ) https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/5OPPTTNKQF2S5PUOX4HNAW5B7R4UFREU/ This review ends with https://bugzilla.redhat.com/show_bug.cgi?id=557546 | Fedora Update System 2010-03-23 23:30:09 UTC | telepathy-sunshine-0.1.6-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still | persist, please make note of it in this bug report. Are there any other review requests which can return sponsorship ? Googling "fedora review swap sponsor" shows nothing interesting 8-( so long MUFTI ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why no wdune sponsoring ?
On Fri, 2019-01-11 at 18:16 +0100, J. Scheurich wrote: > Hi, > > > Are there any tips how to get wdune fedora sponsoring ? > > > > What to do ? > > Propose a review swap , you review a package for other and other > > review > > your package and sponsor / mentor you . > > How to initialise a review swap ? LMGTFY (fedora review swap ) https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/5OPPTTNKQF2S5PUOX4HNAW5B7R4UFREU/ https://fedoraproject.org/wiki/Package_Review_Process > Is there a mailing list or something to initialise review swaps ? > > Are there any lists with potential review swap ? > Most people which need a review also need sponsoring by themselves, > or > am i wrong ? > > so long > MUFTI > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org -- Sérgio M. B. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why no wdune sponsoring ?
Hi, Are there any tips how to get wdune fedora sponsoring ? What to do ? Propose a review swap , you review a package for other and other review your package and sponsor / mentor you . How to initialise a review swap ? Is there a mailing list or something to initialise review swaps ? Are there any lists with potential review swap ? Most people which need a review also need sponsoring by themselves, or am i wrong ? so long MUFTI ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why no wdune sponsoring ?
On Fri, 2019-01-11 at 18:00 +0100, J. Scheurich wrote: > Hi, > > Are there any tips how to get wdune fedora sponsoring ? Is not wdune that need be sponsored is you that need be sponsored, you by being sponsored get permissions to write and include wdune in Fedora . I can't sponsor you because I don't have the ACL for sponsoring . > We are working years on free software, but the distributors simply > ignore it > (or worse) use a more than 10 years old version (like in > debian/ubuntu) 8-( > > What is wrong with wdune ? > > It uses old technologies like motif or X3D. > Motif has the advantage that the 2D-GUI did not change over the years > (a lot of interesting software under Linux died from changing > versions of > QT or gtk for example). > X3D has been superseded by webgl, but X3D can be displayed via webgl > (X_ITE or x3dom). > > What need to be done, to bring wdune to fedora ? > If i get no fedora sponsoring, are there some volunteers to add wdune > to > fedora ? > > It looks like, is not much work, it looks like wdune passed the > review > process: > > https://bugzilla.redhat.com/show_bug.cgi?id=1658153 > > What to do ? Propose a review swap , you review a package for other and other review your package and sponsor / mentor you . > so long > MUFTI > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org -- Sérgio M. B. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Why no wdune sponsoring ?
Hi, Are there any tips how to get wdune fedora sponsoring ? We are working years on free software, but the distributors simply ignore it (or worse) use a more than 10 years old version (like in debian/ubuntu) 8-( What is wrong with wdune ? It uses old technologies like motif or X3D. Motif has the advantage that the 2D-GUI did not change over the years (a lot of interesting software under Linux died from changing versions of QT or gtk for example). X3D has been superseded by webgl, but X3D can be displayed via webgl (X_ITE or x3dom). What need to be done, to bring wdune to fedora ? If i get no fedora sponsoring, are there some volunteers to add wdune to fedora ? It looks like, is not much work, it looks like wdune passed the review process: https://bugzilla.redhat.com/show_bug.cgi?id=1658153 What to do ? so long MUFTI ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
