Re: bash completion dirs

[Ville Skyttä]

On Mon, Feb 22, 2016 at 5:11 PM, Ondřej Vašík  wrote:
> Ville Skyttä píše v Po 22. 02. 2016 v 14:12 +0200:
>> On Mon, Feb 22, 2016 at 2:04 PM, Thomas Moschny
>>
>> Why not. Note however that if going this route, the dirs
>> /usr/share/bash-completion and /usr/share/bash-completion/helpers
>> should be owned by it as well.
>
> Hmmms, makes sense... will add the ownerships in next rawhide filesystem
> package build.

Good, thanks. I see it hasn't happened yet -- any ETA for this build?
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: bash completion dirs

[Andrew Lutomirski]

On Mon, Feb 22, 2016 at 7:22 AM, Neal Gompa  wrote:
> On Mon, Feb 22, 2016 at 10:16 AM, Andrew Lutomirski  wrote:
>>
>> On Feb 22, 2016 7:14 AM, "Neal Gompa"  wrote:
>>>
>>> On Mon, Feb 22, 2016 at 10:11 AM, Ondřej Vašík  wrote:
>>> > Ville Skyttä píše v Po 22. 02. 2016 v 14:12 +0200:
>>> >> On Mon, Feb 22, 2016 at 2:04 PM, Thomas Moschny
>>> >>  wrote:
>>> >> > However, for the same reasons, shouldn't the filesystem package also
>>> >> > own the "new" /usr/share/bash-completion/completions location?
>>> >>
>>> >> Why not. Note however that if going this route, the dirs
>>> >> /usr/share/bash-completion and /usr/share/bash-completion/helpers
>>> >> should be owned by it as well.
>>> >
>>> > Hmmms, makes sense... will add the ownerships in next rawhide filesystem
>>> > package build.
>>> >
>>> > Regards,
>>> > Ondrej
>>> >
>>>
>>> If you're doing that, you might as well do the same for the other
>>> shells we support completions for (zsh, fish, etc.).
>>
>> Fish is slightly in flux here, so maybe wait a little bit on that one?  I'll
>> file a bug when the dust settles.
>>
>
> Okay, wait a bit on fish, but afaik, zsh and ksh have completion
> directories. I'm a bit hazy on ksh, but I know zsh does.
>

Can you make filesystem own:

/usr/share/fish/vendor_completions.d

(Actually, it should probably be:

%{buildroot}%{_datadir}/fish/vendor_completions.d

which is roughly the same thing)

Later on, we'll want vendor_conf.d, too, but that feature isn't a
clean backport, so I'll probably wait for a new upstream release.  If
you need to coordinate
with the fish package to avoid a conflict, ping me off-list.

Thanks!
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: bash completion dirs

[Neal Gompa]

On Mon, Feb 22, 2016 at 10:16 AM, Andrew Lutomirski  wrote:
>
> On Feb 22, 2016 7:14 AM, "Neal Gompa"  wrote:
>>
>> On Mon, Feb 22, 2016 at 10:11 AM, Ondřej Vašík  wrote:
>> > Ville Skyttä píše v Po 22. 02. 2016 v 14:12 +0200:
>> >> On Mon, Feb 22, 2016 at 2:04 PM, Thomas Moschny
>> >>  wrote:
>> >> > However, for the same reasons, shouldn't the filesystem package also
>> >> > own the "new" /usr/share/bash-completion/completions location?
>> >>
>> >> Why not. Note however that if going this route, the dirs
>> >> /usr/share/bash-completion and /usr/share/bash-completion/helpers
>> >> should be owned by it as well.
>> >
>> > Hmmms, makes sense... will add the ownerships in next rawhide filesystem
>> > package build.
>> >
>> > Regards,
>> > Ondrej
>> >
>>
>> If you're doing that, you might as well do the same for the other
>> shells we support completions for (zsh, fish, etc.).
>
> Fish is slightly in flux here, so maybe wait a little bit on that one?  I'll
> file a bug when the dust settles.
>

Okay, wait a bit on fish, but afaik, zsh and ksh have completion
directories. I'm a bit hazy on ksh, but I know zsh does.


-- 
真実はいつも一つ！/ Always, there's only one truth!
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: bash completion dirs

[Andrew Lutomirski]

On Feb 22, 2016 7:14 AM, "Neal Gompa"  wrote:
>
> On Mon, Feb 22, 2016 at 10:11 AM, Ondřej Vašík  wrote:
> > Ville Skyttä píše v Po 22. 02. 2016 v 14:12 +0200:
> >> On Mon, Feb 22, 2016 at 2:04 PM, Thomas Moschny
> >>  wrote:
> >> > However, for the same reasons, shouldn't the filesystem package also
> >> > own the "new" /usr/share/bash-completion/completions location?
> >>
> >> Why not. Note however that if going this route, the dirs
> >> /usr/share/bash-completion and /usr/share/bash-completion/helpers
> >> should be owned by it as well.
> >
> > Hmmms, makes sense... will add the ownerships in next rawhide filesystem
> > package build.
> >
> > Regards,
> > Ondrej
> >
>
> If you're doing that, you might as well do the same for the other
> shells we support completions for (zsh, fish, etc.).

Fish is slightly in flux here, so maybe wait a little bit on that one?
I'll file a bug when the dust settles.

--Andy

>
>
>
> --
> 真実はいつも一つ！/ Always, there's only one truth!
> --
> devel mailing list
> devel@lists.fedoraproject.org
> http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: bash completion dirs

[Neal Gompa]

On Mon, Feb 22, 2016 at 10:11 AM, Ondřej Vašík  wrote:
> Ville Skyttä píše v Po 22. 02. 2016 v 14:12 +0200:
>> On Mon, Feb 22, 2016 at 2:04 PM, Thomas Moschny
>>  wrote:
>> > However, for the same reasons, shouldn't the filesystem package also
>> > own the "new" /usr/share/bash-completion/completions location?
>>
>> Why not. Note however that if going this route, the dirs
>> /usr/share/bash-completion and /usr/share/bash-completion/helpers
>> should be owned by it as well.
>
> Hmmms, makes sense... will add the ownerships in next rawhide filesystem
> package build.
>
> Regards,
> Ondrej
>

If you're doing that, you might as well do the same for the other
shells we support completions for (zsh, fish, etc.).



-- 
真実はいつも一つ！/ Always, there's only one truth!
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: bash completion dirs

[Ondřej Vašík]

Ville Skyttä píše v Po 22. 02. 2016 v 14:12 +0200:
> On Mon, Feb 22, 2016 at 2:04 PM, Thomas Moschny
>  wrote:
> > However, for the same reasons, shouldn't the filesystem package also
> > own the "new" /usr/share/bash-completion/completions location?
> 
> Why not. Note however that if going this route, the dirs
> /usr/share/bash-completion and /usr/share/bash-completion/helpers
> should be owned by it as well.

Hmmms, makes sense... will add the ownerships in next rawhide filesystem
package build.

Regards,
Ondrej

> --
> devel mailing list
> devel@lists.fedoraproject.org
> http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: bash completion dirs

[Ville Skyttä]

On Mon, Feb 22, 2016 at 2:04 PM, Thomas Moschny
 wrote:
> However, for the same reasons, shouldn't the filesystem package also
> own the "new" /usr/share/bash-completion/completions location?

Why not. Note however that if going this route, the dirs
/usr/share/bash-completion and /usr/share/bash-completion/helpers
should be owned by it as well.
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

bash completion dirs

[Thomas Moschny]

Hi,

the "old" bash completion dir /etc/bash_completion.d is now owned by
the filesystem package, so packages don't need (actually: are
forbidden) to own that dir and also don't have to depend on the
bash-completion package. This perfectly makes sense.

However, for the same reasons, shouldn't the filesystem package also
own the "new" /usr/share/bash-completion/completions location?

- Thomas
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org